[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

rymiel added a comment. This patch will probably need unit tests Comment at: clang/lib/Format/TokenAnnotator.cpp:5004-5005 const FormatToken *Previous = Right.MatchingParen->Previous; -return !(Previous && (Previous->is(tok::kw_for) || Previous->isIf())); +// avoid

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D137517: [TargetSupport] Generate the defs for RISCV CPUs using llvm-tblgen.

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:509-517 +class RISCVProcessorModelPROC { + string Enum = enum; + string EnumFeatures = enum_features; + string DefaultMarch = default_march; +} + +class RISCVProcessorModelTUNE_PROC { Giv

[PATCH] D136354: [Driver] Enable nested configuration files

sepavloff updated this revision to Diff 474455. sepavloff added a comment. Rebase patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136354/new/ https://reviews.llvm.org/D136354 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/Diag

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdd9f7963e434: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is… (authored by mhjacobson). C

[clang] dd9f796 - [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

Author: Matt Jacobson Date: 2022-11-10T02:10:30-05:00 New Revision: dd9f7963e434a53e8d70f607392ee9abf76f1d99 URL: https://github.com/llvm/llvm-project/commit/dd9f7963e434a53e8d70f607392ee9abf76f1d99 DIFF: https://github.com/llvm/llvm-project/commit/dd9f7963e434a53e8d70f607392ee9abf76f1d99.diff

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3918673 , @owenpan wrote: > In D137181#3918117 , @goldstein.w.n > wrote: > maybe you did something different? >>> >>> Here is what I did: >>> >>> $ git diff Unwrap

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 474447. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[clang] a86b506 - [NFC] Fixing a comment and some indentations

Author: sandeepkosuri Date: 2022-11-10T01:02:12-06:00 New Revision: a86b506294bc7b9a921e3e613f49730c5780eb22 URL: https://github.com/llvm/llvm-project/commit/a86b506294bc7b9a921e3e613f49730c5780eb22 DIFF: https://github.com/llvm/llvm-project/commit/a86b506294bc7b9a921e3e613f49730c5780eb22.diff

[PATCH] D137693: [NFC] [C++20] [Modules] [clangd] Add test for code completion for C++20 Named Modules

ChuanqiXu updated this revision to Diff 474445. ChuanqiXu added a comment. Add dependency to clangd tests to make sure they can find the corresponding rules. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137693/new/ https://reviews.llvm.org/D137693 Files: clang-tools-extra/clangd/te

[PATCH] D137765: [NFC] Fixing a comment and some indentations

sandeepkosuri created this revision. sandeepkosuri added reviewers: cchen, ABataev, RitanyaB, soumitra. Herald added a project: All. sandeepkosuri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

owenpan added a comment. In D137181#3918117 , @goldstein.w.n wrote: >>> maybe you did something different? >> >> Here is what I did: >> >> $ git diff UnwrappedLineParser.cpp >> diff --git a/clang/lib/Format/UnwrappedLineParser.cpp >> b/clang/lib/For

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii updated this revision to Diff 474440. francii added a comment. Use existing error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137756/new/ https://reviews.llvm.org/D137756 Files: clang/lib/Driver/ToolChains/ZOS.cpp clang/test/Driver/z

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added a comment. Another test case for function pointers is here: F25259090: tmp.c Before applying these changes, it is: clang-format -style="{BasedOnStyle: LLVM, AlignAfterOpenBracket: BlockIndent}" tmp.c int foo(long l) { return l; } int m

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added a comment. A test case from the GitHub Issue https://github.com/llvm/llvm-project/issues/57250 is attached here: F25258989: test.c When run without these changes, it yields: clang-format -style="{BasedOnStyle: LLVM, AlignAfterOpenBracket: BlockI

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474430. gedare added a comment. Add a fix to enable breaking for continuation after a )( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/Cont

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 474429. gedare added a comment. Allow line breaks in a continuation with BlockIndent after )( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

SeanP added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:241 +def err_option_unsupported_zos: Error< + "the clang compiler does not support the '%0' option on z/OS.">; + Rather than saying "on z/OS" you should say "by the targe

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare added a comment. Something about this is still a bit off though. This change seems to prevent any more breaking on the line. For example, the test example given in GitHub Issue https://github.com/llvm/llvm-project/issues/57250 when formatted with this change becomes: `clang-format -styl

[PATCH] D127855: [OpenMP] Basic parse and sema support for modifiers in order clause

sandeepkosuri added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10634 "OpenMP constructs may not be nested inside an atomic region">; +def err_omp_prohibited_region_order +: Error<"construct %0 not allowed in a region associated with a dir

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare created this revision. Herald added a project: All. gedare requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The BracketAlignmentStyle BAS_BlockIndent was forcing breaks before a closing right parenthesis yielding strange-looking resul

[PATCH] D137760: Add FP8 E4M3 support to APFloat.

reedwm created this revision. reedwm added reviewers: stellaraccident, bkramer, rengolin, jpienaar. Herald added subscribers: bzcheeseman, rriddle, hiraditya, kristof.beyls. Herald added a project: All. reedwm requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, s

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

SixWeining updated this revision to Diff 474414. SixWeining added a comment. Revise the `err_drv_loongarch_invalid_mfpu_EQ` diagnostic info. Add necessary braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136146/new/ https://reviews.llvm.org/D

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ cfe-commits mailing list cfe-comm

[PATCH] D137756: [z/OS][p][pg] Throw Error When Using -p or -pg on z/OS

francii created this revision. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Throw an error when trying to compile with `-p` or `-pg` on z/OS, as the platform does not support `prof` and `gprof

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry added a comment. @kadircet Thanks for your suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474399. v1nh1shungry added a comment. Apply the reviewing suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D137755: [clang-format] Treats &/&& as reference when followed by ',' or ')'.

red1bluelost created this revision. red1bluelost added a reviewer: curdeius. Herald added a project: All. red1bluelost requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Ran into an issue where function declarations inside function scopes or u

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 474396. francii added a comment. Update the recently-added test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp c

[PATCH] D137753: [Clang][p]Enable -p Functionality

francii added a comment. A test case will be added shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D137753: [Clang][p]Enable -p Functionality

francii created this revision. Herald added a subscriber: ormris. Herald added a project: All. francii requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. This patch enables general, non-platform-specific `-p` functionality into Clang t

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei added inline comments. Comment at: clang/test/VFS/Inputs/root-relative-overlay.yaml:4 + 'case-sensitive': false, + 'overlay-relative': true, + 'root-relative': 'yaml-dir', haowei wrote: > haowei wrote: > > bnbarham wrote: > > > bnbarham wrote: > > > > I

[PATCH] D137473: [vfs] Allow root paths relative to the directory of the vfsoverlay YAML file

haowei updated this revision to Diff 474391. haowei added a comment. Add additional unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137473/new/ https://reviews.llvm.org/D137473 Files: clang/test/VFS/Inputs/root-relative-overlay.yaml c

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

Eugene.Zelenko added a comment. In D137740#3918335 , @stephanemoore wrote: > In D137740#3918271 , > @Eugene.Zelenko wrote: > >> Will be good idea to combine this patch with D137738 >>

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

rsmith updated this revision to Diff 474385. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137751/new/ https://reviews.llvm.org/D137751 Files: clang/test/Driver/aix-ld.c Index: clang/test/Driver/aix-ld.c === --- clang/te

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

stephanemoore added a comment. In D137740#3918271 , @Eugene.Zelenko wrote: > Will be good idea to combine this patch with D137738 > . My intent was to land the simpler linter fixes first while iterating on the fixes i

[PATCH] D137751: Produce a more informative diagnostics when Clang runs out of source locations

rsmith created this revision. rsmith added a reviewer: aaron.ballman. Herald added a subscriber: mgrang. Herald added a project: All. rsmith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If Clang runs out of source location address space,

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 474382. tarunprabhu added a comment. Previous revision was missing the tests. Only add a dependence to the Bye plugin when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 Files:

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 474381. tarunprabhu added a comment. Only add a dependence to the Bye plugin when plugins are enabled. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 Files: clang/include/clang/Driver/Options.td c

[clang] a11cd0d - Move googletest to the third-party directory

Author: Tom Stellard Date: 2022-11-09T15:28:08-08:00 New Revision: a11cd0d94ed3cabf0998a0289aead05da94c86eb URL: https://github.com/llvm/llvm-project/commit/a11cd0d94ed3cabf0998a0289aead05da94c86eb DIFF: https://github.com/llvm/llvm-project/commit/a11cd0d94ed3cabf0998a0289aead05da94c86eb.diff

[PATCH] D137740: [clang-tidy][NFC] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

Eugene.Zelenko added a comment. Will be good idea to combine this patch with D137738 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137740/new/ https://reviews.llvm.org/D137740 __

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

abrachet added a comment. I believe this patch might be the cause of some assertion failures we are seeing in a two stage lto build, as it's only happening for arm64-darwin. See https://ci.chromium.org/ui/p/fuchsia/builders/prod/clang-mac-xarm64/b8798097341668696785/overview and it's correspond

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders added a comment. Hmm I added the test for the flag to Sema, but now we kinda have the same test case duplicated in sema and clangd tests - I guess for clangd we now actually only have to test that the SnippetSuffix is cleared when FunctionCanBeCall is true, but I don't see an easy wa

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n added a comment. In D137181#3916605 , @owenpan wrote: > In D137181#3916558 , @goldstein.w.n > wrote: > >> In D137181#3916547 , @owenpan >> wrote: >> >>> Ye

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 474359. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders updated this revision to Diff 474358. tom-anders added a comment. Add test to sema Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137040/new/ https://reviews.llvm.org/D137040 Files: clang-tools-extra/clangd/CodeComplete.cpp clang-too

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 🫢

stephanemoore created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. stephanemoore updated this revision to Diff 474350. stephanemoore added a comment. stephanemoore updated this revision to Diff 474356. stephanemoo

[PATCH] D137740: [clang-tidy] Fix namespace comments in AvoidThrowingObjCExceptionCheck.cpp 🧹

stephanemoore created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. stephanemoore published this revision for review. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This commit

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

mgorny added inline comments. Comment at: clang/CMakeLists.txt:14 set(CLANG_BUILT_STANDALONE TRUE) + if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0") +message(WARNING I wonder if we could move this to `CMakePolicy.cmake`, though admittedly you'd have to som

[PATCH] D137154: Adding nvvm_reflect clang builtin

jhuber6 added a comment. In D137154#3917752 , @tra wrote: > As for the code specialization, why not build for individual GPUs? To me it > looks like this use case is a good match for the "new-driver" offloading > that's been recently implemented in clan

[PATCH] D137609: [C++20] [Modules] Remove unmaintained header modules

dblaikie added a comment. > I'm not aware of anyone using this mode, but please wait for responses from > Google and Meta people to verify that. Best understanding on the Google side is we aren't using this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137609/new/ https://reviews.llv

[PATCH] D136701: [LinkerWrapper] Perform device linking steps in parallel

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136701/new/ https://reviews.llvm.org/D136701 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

ldionne added a comment. LGTM (sorry, it looks like I approved on behalf of all libc++ vendors but that wasn't my intention). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 _

[clang] e07a704 - [Test][AIX][pg] Add 32-bit linker invocation tests

Author: Michael Francis Date: 2022-11-09T15:02:45-05:00 New Revision: e07a7040d9c6dbdd71e55d1153bfe1357079e511 URL: https://github.com/llvm/llvm-project/commit/e07a7040d9c6dbdd71e55d1153bfe1357079e511 DIFF: https://github.com/llvm/llvm-project/commit/e07a7040d9c6dbdd71e55d1153bfe1357079e511.dif

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 ___ cfe-commits mailing list

[clang] dc9846c - [Test][AIX][p] Add 64-bit linker invocation tests

Author: Michael Francis Date: 2022-11-09T14:51:40-05:00 New Revision: dc9846ce988b9ddfcbc42cd462d5d94b634b3161 URL: https://github.com/llvm/llvm-project/commit/dc9846ce988b9ddfcbc42cd462d5d94b634b3161 DIFF: https://github.com/llvm/llvm-project/commit/dc9846ce988b9ddfcbc42cd462d5d94b634b3161.dif

[PATCH] D137373: [Test][[AIX][p] Add 64-bit linker invocation tests

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Test only patch is safe to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137373/new/ https://reviews.llvm.org/D1373

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] 8a084f6 - Revert "Move googletest to the third-party directory"

Author: Tom Stellard Date: 2022-11-09T11:34:59-08:00 New Revision: 8a084f68c8a1cac99d9fa0fbcf490b53ab3b6e0c URL: https://github.com/llvm/llvm-project/commit/8a084f68c8a1cac99d9fa0fbcf490b53ab3b6e0c DIFF: https://github.com/llvm/llvm-project/commit/8a084f68c8a1cac99d9fa0fbcf490b53ab3b6e0c.diff

[PATCH] D134089: [clang] Mention vector in the description for -mno-implict-float.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0453857d7402: [clang] Mention vector in the description for -mno-implict-float. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134

[clang] 0453857 - [clang] Mention vector in the description for -mno-implict-float.

Author: Craig Topper Date: 2022-11-09T11:32:19-08:00 New Revision: 0453857d740248a8991ac28981784445dffa8dee URL: https://github.com/llvm/llvm-project/commit/0453857d740248a8991ac28981784445dffa8dee DIFF: https://github.com/llvm/llvm-project/commit/0453857d740248a8991ac28981784445dffa8dee.diff

[PATCH] D137154: Adding nvvm_reflect clang builtin

tra added a subscriber: jhuber6. tra added a comment. In D137154#3917692 , @hdelan wrote: > Thanks for feedback. Instead of adding `__nvvm_reflect` as a clang builtin, > would it be acceptable if I modified the NVVMReflect pass That would be less proble

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. In D91950#3917635 , @MyDeveloperDay wrote: > I think this is them.. > > https://twitter.com/xen_org/status/1397581514318225412 > https://xenproject.org/ > https://xenproject.org/2021/09/22/clang-format-for-xen-coding-st

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

dblaikie added a comment. In D137583#3917706 , @aaron.ballman wrote: >> ...we expect template params to be fully qualified when comparing them for >> simple template names > > So lldb is not inspecting the AST, they're doing reflection (of a sort) on >

[PATCH] D137372: [Test][[AIX][pg] Add 32-bit linker invocation tests

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. LGTM. Test only patch is safe to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137372/new/ https://reviews.llvm.org/D1373

[PATCH] D137386: [clang][Interp] Reject invalid declarations and expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1235-1236 bool ByteCodeExprGen::visitDecl(const VarDecl *VD) { - Optional VarT = classify(VD->getType()); + if (VD->isInvalidDecl()) +return false; Because we can't

[PATCH] D131919: Move googletest to the third-party directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG59052468c3e3: Move googletest to the third-party directory (authored by tstellar). Changed prior to commit: https://reviews.llvm.org/D131919?vs=46

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/arrays.cpp:216 - static_assert(getNextElem(E, 1) == 3); -#endif + static_assert(getNextElem(E, 1) == 3, ""); + aaron.ballman wrote: > I'd like test cases where the pointer arithmetic has r

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

This revision was automatically updated to reflect the committed changes. Closed by commit rG82ca918b5755: [clangd] Fix the code action `RemoveUsingNamespace` (authored by v1nh1shungry, committed by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang-tools-extra] 82ca918 - [clangd] Fix the code action `RemoveUsingNamespace`

Author: v1nh1shungry Date: 2022-11-09T21:04:21+01:00 New Revision: 82ca918b5755f3c442e247563dc011f7b310e446 URL: https://github.com/llvm/llvm-project/commit/82ca918b5755f3c442e247563dc011f7b310e446 DIFF: https://github.com/llvm/llvm-project/commit/82ca918b5755f3c442e247563dc011f7b310e446.diff

[PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

aaron.ballman added a comment. > ...we expect template params to be fully qualified when comparing them for > simple template names So lldb is not inspecting the AST, they're doing reflection (of a sort) on the pretty printed names? Or am I misunderstanding something? Commen

[PATCH] D137154: Adding nvvm_reflect clang builtin

hdelan added a comment. Thanks for feedback. Instead of adding `__nvvm_reflect` as a clang builtin, would it be acceptable if I modified the NVVMReflect pass so that it works with addrspace casting as well? This would allow us to use `__nvvm_reflect` in openCL Repository: rG LLVM Github Mono

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

sepavloff updated this revision to Diff 474304. sepavloff added a comment. Remove accidentally added file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137719/new/ https://reviews.llvm.org/D137719 Files: clang/lib/AST/ExprConstant.cpp clang/te

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

sepavloff updated this revision to Diff 474303. sepavloff added a comment. Removed unused parateters from HandleIntToFloatCast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137719/new/ https://reviews.llvm.org/D137719 Files: clang/lib/AST/ExprCo

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917644 , @MaskRay wrote: > I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for > standalone builds is not necessary. The check in `llvm/CMakeLists.txt` > suffices. > It's unlikely the users w

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

MaskRay accepted this revision as: MaskRay. MaskRay added a comment. I think `if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR)` checks for standalone builds is not necessary. The check in `llvm/CMakeLists.txt` suffices. It's unlikely the users will use different cmake versions to configure

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. In D136146#3911137 , @SixWeining wrote: > Sorry for the late reply. > > Should we choose not to implement the `-mfpu=` option which is not mandatory

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added a comment. I think this is them.. https://twitter.com/xen_org/status/1397581514318225412 https://xenproject.org/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ cfe-commits m

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

ilya-biryukov added a comment. Sent out rG453c2879cb2ad6c46267ef8f39f0274aed69d9ee to fix this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135859/new/ https://reviews.llvm.or

[clang-tools-extra] 453c287 - [include-cleaner] Add dependency to fix build with shared libraries

Author: Ilya Biryukov Date: 2022-11-09T18:31:14+01:00 New Revision: 453c2879cb2ad6c46267ef8f39f0274aed69d9ee URL: https://github.com/llvm/llvm-project/commit/453c2879cb2ad6c46267ef8f39f0274aed69d9ee DIFF: https://github.com/llvm/llvm-project/commit/453c2879cb2ad6c46267ef8f39f0274aed69d9ee.diff

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante added a comment. In D137724#3917616 , @thieta wrote: > I think this is fine as we have discussed before. But I really dislike the > code duplication for the check. We could put it in a include() I guess - but > maybe it's not worth it. I wante

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta accepted this revision as: thieta. thieta added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, JDevlieghere. I think this is fine as we have discussed before. But I really dislike the code duplication for the check. We could put it in a include() I guess

[PATCH] D137712: Correctly handle Substitution failure in concept specialization.

erichkeane added a comment. I dont have a good hold as to why this is the solution, can you better explain the issue and the solution that you made? I will take a look when I get a chance next week, as the ISO meeting is taking up my week. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante created this revision. Herald added a reviewer: bollu. Herald added subscribers: Moerafaat, zero9178, Enna1, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiag

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

maryammo added a comment. @kadircet, this commit causes failure on https://lab.llvm.org/buildbot/#/builders/121 which is possible to reproduce locally, can you please take a look? [ 35/111] Linking CXX executable tools/clang/tools/extra/include-cleaner/unittests/ClangIncludeCleanerTests F

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

TIFitis updated this revision to Diff 474284. TIFitis added a comment. Fix commit message indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137720/new/ https://reviews.llvm.org/D137720 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clan

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2653 + APFloat::opStatus St = Result.convertFromAPInt(Value, Value.isSigned(), RM); + return checkFloatingPointResult(Info, E, St); } tbaeder wrote: > `SrcType` was already unused before

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

TIFitis created this revision. TIFitis added reviewers: jdoerfert, jsjodin. Herald added a subscriber: hiraditya. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: clang, LLVM. This patch re

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

tbaeder added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2653 + APFloat::opStatus St = Result.convertFromAPInt(Value, Value.isSigned(), RM); + return checkFloatingPointResult(Info, E, St); } `SrcType` was already unused before, but not so is `

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

sepavloff added a comment. Patch https://reviews.llvm.org/D137719 fixed int->float conversion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137719: [clang] Missed rounding mode use in constant evaluation

sepavloff created this revision. sepavloff added reviewers: rjmccall, efriedma, aaron.ballman. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Integer-to-float conversion was handled in constant evaluator with default rounding mode. This cha

[PATCH] D137650: [clangd] Implement hover for string literals

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:816 + if (llvm::isa(E)) { +HoverInfo::PrintedType PT; +PT.Type = E->getType().getAsString(PP); can you extract this into a function, similar to the cases below?

[PATCH] D137232: [clang][Interp] Support inc/dec operators on pointers

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Opcodes.td:421-425 +// [Pointer] -> [] +def IncPtr : Opcode { + let HasGroup = 0; +} +// [Pointer] -> [] aaron.ballman wrote: > Don't both of these result in a `Pointer`? And should they have a `Typ

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder marked an inline comment as done. tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:591 + + static_assert(IntDiv(INT_MIN, -1) == 0, ""); + aaron.ballman wrote: > This one should fail for the same reason as `%` Works when repla

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 474273. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST/Interp/literals.cpp =

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. Hmm, I still had a crash on this latest code (although it is crashing much more rarely now. It crashes on scanning this file https://github.com/facebookresearch/habitat-sim/blob/5fb04078b0b8432dc4a88ec186a2b7af74163be1/src/esp/core/managedContainers/ManagedContainerB

[PATCH] D122385: [clang][deps] Fix clang-cl output argument parsing

saudi added inline comments. Herald added a subscriber: ributzka. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:487 +if (!llvm::sys::path::has_extension(CurrentO)) + LastO = (CurrentO + ".obj").str(); +else

[PATCH] D137618: [Clang] Fix behavior of -ffp-model option when overriden

zahiraam added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3034 RoundingFPMath = false; + FPExceptionBehavior = ""; // If fast-math is set then set the fp-contract mode to fast. FPExceptionBehavior should be set here and

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 474262. v1nh1shungry added a comment. Format codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137550/new/ https://reviews.llvm.org/D137550 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingN

  1   2   >