[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. In D136436#3898394 , @SixWeining wrote: > In D136436#3898392 , @tangyouling > wrote: > >> Is it acceptable to add the `non-prefix $`? if not, an alternative fix for >> the build fai

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xry111 added a comment. In D136436#3898398 , @xry111 wrote: > In D136436#3898392 , @tangyouling > wrote: > >> Is it acceptable to add the `non-prefix $`? if not, an alternative fix for >> the build failure is to

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

xry111 added a comment. In D136436#3898392 , @tangyouling wrote: > Is it acceptable to add the `non-prefix $`? if not, an alternative fix for > the build failure is to add the `prefix $` in > sanitizer_syscall_linux_loongarch64.inc I wrote `sanitizer_

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

SixWeining added a comment. In D136436#3898392 , @tangyouling wrote: > Is it acceptable to add the `non-prefix $`? if not, an alternative fix for > the build failure is to add the `prefix $` in > sanitizer_syscall_linux_loongarch64.inc People have dif

[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

tangyouling added a comment. Is it acceptable to add the `non-prefix $`? if not, an alternative fix for the build failure is to add the `prefix $` in sanitizer_syscall_linux_loongarch64.inc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136436/new/

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny reopened this revision. mgorny added a comment. This revision is now accepted and ready to land. Gotta figure the buildbot regression out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 __

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

This revision was automatically updated to reflect the committed changes. Closed by commit rG37acf9bdd468: [compiler-rt] Switch from llvm-config to find_package(LLVM) (authored by mgorny). Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Repository: rG LLVM Github Mono

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

owenpan added a comment. In D137052#3895426 , @sstwcw wrote: > This patch fixes the regression caused by 2183fe2 > while > introducing a new regression. But in my opinion the new reg

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

owenpan updated this revision to Diff 472204. owenpan added a comment. Tweaked the fix and added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137052/new/ https://reviews.llvm.org/D137052 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ChuanqiXu added a comment. In D137059#3896661 , @dblaikie wrote: > Could you link to the email/discourse discussion about supporting this mode > (I think you've linked it in other discussions, be good to have it for > reference here & Probably in the ot

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe added a comment. For saving capacity of ProcessorSubtypes, gcc decided to not support part of compiler features of these two cpus: __builtin_cpu_is("meteorlake") __attribute__((target("arch=raptorlake"))) ... some others I don't know. Updated to align with gcc first. Welcome opin

[PATCH] D135937: [WIP][X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 472203. FreddyYe marked 7 inline comments as done. FreddyYe added a comment. Address comments and update to align with gcc. See my latest comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ htt

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:181 + FPFeatures.allowFPContractAcrossStatement()); } zahiraam wrote: > Shouldn't then this also check for FPFeatures.getFPContractMode() ? This should be covere

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added a comment. Status update: While investigating @cor3ntin's comment about refactoring `VisitInitListExpr` and `VisitCXXParenListInitExpr` as they share common code, I discovered that flexible array members would cause this patch to explode. Specifically, the following code: struc

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 472190. ayzhao marked 6 inline comments as done. ayzhao added a comment. address some comments and implement disallowing flexible array members Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://r

[PATCH] D136894: Add clang-doc readme

paulkirth requested changes to this revision. paulkirth added a comment. This revision now requires changes to proceed. First, I don't think this is a good fit for a `README.txt` based on the content of other clang-tool `README.txt` files. Most of them only outline project scope or point to form

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. Thanks Egor! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136844/new/ https://reviews.llvm.org/D136844 ___

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan updated this revision to Diff 472171. egorzhdan added a comment. Preserve `CodeCompletionResult::ResultKind` and do the conversion to `CXCompletionResultKind` in `CIndexCodeCompletion.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen added a comment. In D136790#3897184 , @aaron.ballman wrote: > please be sure to add a release note so users know there's a new warning. I'll add a release note. Thanks for the reminder! Comment at: clang/include/clang/Ba

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu updated this revision to Diff 472161. tarunprabhu added a comment. Added a dependence for the flang tests on LLVM's Bye plugin. This results in the Bye plugin being built when check-flang is run, even if building examples has been explicitly disabled. Removed the dependency on 'exam

[PATCH] D137073: [clang] Fix inline builtin functions of an __asm__ renamed function with symbol prefixes

rnk added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:5020 +std::string AsmName; +if (auto *A = FD->getAttr()) { + StringRef UserLabelPrefix = I think you can call CGM.getMangledName, but I might be wrong. It's worth doing if straightf

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2868-2873 + // If we happen to share the same indirect and default dest, don't re-add + // stores. That was done for the default destination in the above call to + // EmitAsmStores. +

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 472152. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - reroll for a new sha so that phab unmarks this as "changes planned" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2868-2873 + // If we happen to share the same indirect and default dest, don't re-add + // stores. That was done for the default destination in the above call to + // EmitAsmStores. +

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 472144. nickdesaulniers added a comment. - remove unnecssary asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rs

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2868-2873 + // If we happen to share the same indirect and default dest, don't re-add + // stores. That was done for the default destination in the above call to + // EmitAsmStores. +

[PATCH] D137116: [AggressiveInstCombine] Remove legacy PM pass

aeubanks created this revision. aeubanks added a reviewer: asbirlea. Herald added a reviewer: deadalnix. Herald added subscribers: ormris, hiraditya. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald ad

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2868-2873 + // If we happen to share the same indirect and default dest, don't re-add + // stores. That was done for the default destination in the above call to + // EmitAsmStores. + llvm::B

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2867 +for (unsigned i = 0, e = CBR->getNumIndirectDests(); i != e; ++i) { + assert(CBRRegResults[i].size() == ResultRegTypes.size()); +

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

void accepted this revision. void added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 ___

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

mstorsjo added a comment. In D137107#3897326 , @rnk wrote: > Unless I'm missing something, I think Clang's behavior here is preferable to > MSVC's. MSVC produces code which will not link. Clang turns the linker error > into a compiler error, which is ge

[PATCH] D135987: [clangBasic] Refactor StaticAnalyzer to use `clang::SarifDocumentWriter`

vaibhav.y created this revision. vaibhav.y added reviewers: aaron.ballman, cjdb. Herald added subscribers: steakhal, wenlei, martong. Herald added a reviewer: NoQ. Herald added a project: All. vaibhav.y updated this revision to Diff 472133. vaibhav.y added a comment. vaibhav.y added a reviewer: dbe

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 472136. nickdesaulniers added a comment. - rebase on D137113 , add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 F

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2850 assert(RegResults.size() == ResultRegTypes.size()); assert(RegResults.size() == ResultTruncRegTypes.size()); nickdesaulniers wrote: > void wrote: > > Should these asserts

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 472132. nickdesaulniers added a comment. - move asserts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index: clang/li

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

glandium added a comment. > you're using the SDK libc++ with a ToT clang, which is technically not a > supported combination. Where is it specified that it's not a supported combination? Why should it not be supported? You don't even get libc++ from the llvm tree unless you explicitly enable i

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3897326 , @rnk wrote: > Unless I'm missing something, I think Clang's behavior here is preferable to > MSVC's. MSVC produces code which will not link. Clang turns the linker error > into a compiler error, which is ge

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGStmt.cpp:2362 + // a pointer. + if (TruncTy->isFloatingPointTy()) +Tmp = Builder.CreateFPTrunc(Tmp, TruncTy); nickdesaulniers wrote: > void wrote: > > This looks like a direc

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Let me move the asserts, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 ___

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. In D136497#3889938 , @void wrote: > It might be easier to see the main changes here if you submit the (very nice) > refactoring of `EmitAsmStores` first. D137113

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, nikic, jyknight, efriedma, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D134089: [clang] Mention vector in the description for -mno-implict-float.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM We might want per-target documentation somewhere for what counts as an "floating point or vector instruction". It's not entirely obvious whether, for example, `cvtss2si (%rax), %ecx

[clang] 1391843 - [Hexagon] Add builtins and intrinsics for V6_v[add|sub]carryo

Author: Krzysztof Parzyszek Date: 2022-10-31T13:41:31-07:00 New Revision: 13918432cf67c60d56b7a89bf9b1acf9c0d0866a URL: https://github.com/llvm/llvm-project/commit/13918432cf67c60d56b7a89bf9b1acf9c0d0866a DIFF: https://github.com/llvm/llvm-project/commit/13918432cf67c60d56b7a89bf9b1acf9c0d0866a

[clang] 6288f70 - [lit] Fix typo in REQUIRES clause

Author: Paul Robinson Date: 2022-10-31T13:15:09-07:00 New Revision: 6288f70bda7438c7d249a4d54d8317172bce2b88 URL: https://github.com/llvm/llvm-project/commit/6288f70bda7438c7d249a4d54d8317172bce2b88 DIFF: https://github.com/llvm/llvm-project/commit/6288f70bda7438c7d249a4d54d8317172bce2b88.diff

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

rnk added a subscriber: akhuang. rnk added a comment. @akhuang, can you help out with this? The address of dllimport symbols not being constexpr is a big pain point for our users too, and I'd love to fix it: https://github.com/protocolbuffers/protobuf/issues/10159 I am ready to be wrong here: if

[PATCH] D133998: [HIP][test] Avoid %T

probinson added a comment. I filed #58711 to get the test fixed; in the meantime, removed `clang-driver` and added `XFAIL: *` in rG7af01fe4 Repository: rG LLVM Github Mon

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

rnk added a comment. Unless I'm missing something, I think Clang's behavior here is preferable to MSVC's. MSVC produces code which will not link. Clang turns the linker error into a compiler error, which is generally easier for the user to understand. To my knowledge, it is still true that ther

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song added a comment. @aaron.ballman or @dblaikie I have addressed the comments, could you take a look again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136807/new/ https://reviews.llvm.org/D136807

[clang] 7af01fe - [lit] Remove undefined keyword from a Driver test

Author: Paul Robinson Date: 2022-10-31T13:01:05-07:00 New Revision: 7af01fe42f1634297601016cd4ef84c34cd84bca URL: https://github.com/llvm/llvm-project/commit/7af01fe42f1634297601016cd4ef84c34cd84bca DIFF: https://github.com/llvm/llvm-project/commit/7af01fe42f1634297601016cd4ef84c34cd84bca.diff

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam created this revision. zahiraam added reviewers: majnemer, rnk. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Microsoft allows the support of ‘constexpr’ with ‘__declspec(dllimport) starting from VS2017 15.u update 4. See Constexpr

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472108. cor3ntin added a comment. Move more getExpr methods in the header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

tom-anders updated this revision to Diff 472103. tom-anders added a comment. Added missing hunk in CodeComplete.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137104/new/ https://reviews.llvm.org/D137104 Files: clang-tools-extra/clangd/CodeCo

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

tom-anders created this revision. tom-anders added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. tom-anders requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D136925: [clangd] Index scoped enums for code completion

tom-anders updated this revision to Diff 472101. tom-anders marked 3 inline comments as done. tom-anders added a comment. Herald added a subscriber: wenlei. Add test to CodeCompletionTests, only consider unscoped enums in this patch (move scoped enums to separate patch) Repository: rG LLVM Gi

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4712 +Module &M, OffloadEntriesInfoManager &OffloadEntriesInfoManager, +bool isDevice) { + // If we are in target mode, load the metadata from t

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

TIFitis updated this revision to Diff 472094. TIFitis added a comment. Removed isDevice from parameters. Added documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136872/new/ https://reviews.llvm.org/D136872 Files: clang/lib/CodeGen/CGO

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane updated this revision to Diff 472093. erichkeane added a comment. ACTUALLY add the libcxx testing, also rebase so hopefully it applies cleanly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://reviews.llvm.org/D136975 Files: clang/docs/ReleaseNotes.rst c

[PATCH] D136554: Implement CWG2631

aaron.ballman added a comment. I'm still thinking about the implementation, but I think this is heading in the correct direction. Comment at: clang/lib/AST/ExprCXX.cpp:970-973 +const Expr *CXXDefaultArgExpr::getExpr() const { + return CXXDefaultArgExprBits.HasRewrittenInit ?

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

aaron.ballman added a comment. Thank you for the new diagnostic, please be sure to add a release note so users know there's a new warning. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

luken-google added a comment. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://reviews.llvm.org/D136975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1685 + + const std::string ompOffloadInfoName = "omp_offload.info"; + Drive by, add doxygen documentation to all methods + members please. Repository: rG LLVM Githu

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || philnik wrote: > a

[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

jsjodin added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4712 +Module &M, OffloadEntriesInfoManager &OffloadEntriesInfoManager, +bool isDevice) { + // If we are in target mode, load the metadata from the host IR. This code has ---

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

erichkeane updated this revision to Diff 472086. erichkeane added a comment. Add DELETE_ME so that the libcxx tests run. Due to the nature of this patch, it is possible that I will have missed a few cases where we should be 're-starting' the substitution stack checking. CHANGES SINCE LAST ACT

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

aaron.ballman added reviewers: clang-language-wg, aaron.ballman. aaron.ballman added a comment. Thank you for the changes! One thing you should add is a release note so users know there's been a diagnostic improvement. Comment at: clang/lib/Parse/ParseDecl.cpp:5384-5385 +boo

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

mizvekov added a comment. I'll need to have another look at this, apparently the synthesized `std` namespace breaks some tests on arm platforms. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136886/new/ https://reviews.llvm.org/D136886 _

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. I think the 'this results in a hard error, not failed lookup' is a necessity here based on discussions on the core reflector. Also see: https://reviews.llvm.org/D133052 Re

[clang-tools-extra] ee1f132 - Revert "[clang] ASTImporter: Fix importing of va_list types and declarations"

Author: Matheus Izvekov Date: 2022-10-31T19:34:23+01:00 New Revision: ee1f132d2c4d399be711275a62698ea9e766c199 URL: https://github.com/llvm/llvm-project/commit/ee1f132d2c4d399be711275a62698ea9e766c199 DIFF: https://github.com/llvm/llvm-project/commit/ee1f132d2c4d399be711275a62698ea9e766c199.dif

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

egorzhdan added inline comments. Comment at: clang/include/clang/Sema/CodeCompleteConsumer.h:755 - /// Describes the kind of result generated. - enum ResultKind { -/// Refers to a declaration. kadircet wrote: > egorzhdan wrote: > > kadircet wrote: > > > i d

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb added a comment. In D137067#3896524 , @dblaikie wrote: > Test case can be simplified a bit further: Thank you! > but otherwise I'm OK with this - I don't /fully/ understand it, but it sounds > plausible enough. (if you have time, I wouldn't mind

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

krisb updated this revision to Diff 472079. krisb added a comment. Apply review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137067/new/ https://reviews.llvm.org/D137067 Files: clang/test/CodeGenCXX/debug-info-enum-metadata-collision.

[PATCH] D134089: [clang] Mention vector in the description for -mno-implict-float.

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134089/new/ https://reviews.llvm.org/D134089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D137058: [Driver] [Modules] Support -fsave-std-c++-module-file (1/2)

dblaikie added a comment. @ben.boeckel maybe this'd be the place to discuss the motivation for this feature (picking up from your comment here: https://reviews.llvm.org/D134267#3892629 ) Could you expound a bit on why "write the .pcm to the same path as the .o" isn't sufficient? (like Split DW

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472071. cor3ntin marked 6 inline comments as done. cor3ntin added a comment. Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || philnik wrote: > a

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

aaron.ballman added inline comments. Comment at: clang/test/Sema/constant-builtins-ilogb.cpp:1 +// RUN: %clang_cc1 -fsyntax-only -verify %s +// expected-no-diagnostics hubert.reinterpretcast wrote: > aaron.ballman wrote: > > hubert.reinterpretcast wrote: > > > Th

[PATCH] D137054: [X86][Driver] Remove stale FIXME. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6fa0e3df97ac: [X86][Driver] Remove stale FIXME. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137054/new/ https://reviews.ll

[clang] 6fa0e3d - [X86][Driver] Remove stale FIXME. NFC

Author: Craig Topper Date: 2022-10-31T10:41:40-07:00 New Revision: 6fa0e3df97ac1280da98bd1bc156dad5e036246b URL: https://github.com/llvm/llvm-project/commit/6fa0e3df97ac1280da98bd1bc156dad5e036246b DIFF: https://github.com/llvm/llvm-project/commit/6fa0e3df97ac1280da98bd1bc156dad5e036246b.diff

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

Re: [clang] a88ebd4 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Sure. The original reason was for a pre-existing problem uncovered in a dependent patch (broken canonicalization of NTTPs), which the underlying issue has been fixed, and then this was merged and reverted again, for a different pre-existing bug with this patch made worse. That bug has been fixed by

[PATCH] D121593: [clangd][WIP] Provide clang-include-cleaner

Abpostelnicu added a comment. @sammccall was there any progress on this so far? This would be really useful to be a clang-tidy check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121593/new/ https://reviews.llvm.org/D121593 _

[PATCH] D136554: Implement CWG2631

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:1315 + // Retrieve the rewritten init expression (for an init expression containing + // immediate calls) With the top level FullExpr and ConstantExpr stripped off. + const Expr *getAdjustedRew

[clang] 06f640d - [X86] Enable EVEX GFNI instructions without avx512bw.

Author: Craig Topper Date: 2022-10-31T10:31:45-07:00 New Revision: 06f640d3fb060e2e9cfed1d7c44636c7ffe3308b URL: https://github.com/llvm/llvm-project/commit/06f640d3fb060e2e9cfed1d7c44636c7ffe3308b DIFF: https://github.com/llvm/llvm-project/commit/06f640d3fb060e2e9cfed1d7c44636c7ffe3308b.diff

[PATCH] D137036: [X86] Enable EVEX GFNI instructions without avx512bw.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06f640d3fb06: [X86] Enable EVEX GFNI instructions without avx512bw. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D136930: [RISCV] Support -mcpu/mtune=native

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2190 CmdArgs.push_back("-tune-cpu"); -CmdArgs.push_back(A->getValue()); +if (strcmp(A->getValue(), "native") == 0) + CmdArgs.push_back(Args.MakeArgString(llvm::sys::getHostCPUN

[PATCH] D137077: [Diagnostic] Clarify -Winfinite-recursion message

aaron.ballman added a comment. In D137077#3896561 , @merrymeerkat wrote: > In D137077#3896369 , @aaron.ballman > wrote: > >> Thank you for the patch! However, I think this isn't an improvement to the >> diagnos

Re: [clang] a88ebd4 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Please include some details about the reason for a revert in the revert commit message in addition to the precanned revision/subject quoting On Wed, Oct 26, 2022 at 1:16 AM Matheus Izvekov via cfe-commits wrote: > > > Author: Matheus Izvekov > Date: 2022-10-26T10:14:27+02:00 > New Revision: a88eb

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

jmciver added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:676 +namespace { +void applyNoundefToLoadInst(bool enable, const clang::QualType &Ty, +llvm::LoadInst *Load) { tschuett wrote: > Nit: You meant static. Thank you f

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

andrew.w.kaylor added a comment. In D136786#3893559 , @michele.scandale wrote: > The fact that `"unsafe-fp-math"="true"` implies `-ffp-contract=fast` is quite > unfortunate, and it is something that in principle should be addressed. > My understanding i

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/test/Modules/reserved-names-1.cpp:33 +expected-error {{module declaration must occur at the start of the translation unit}} + +// Show that

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman updated this revision to Diff 472052. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. Added an additional test case, reworked the comments in one of the tests as well. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

jmciver updated this revision to Diff 472051. jmciver added a comment. Updating D134410 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2) Refactor local linkage function, applyNoundefToLoadInst, to use static rather than an anonym

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

tahonermann updated this revision to Diff 472050. tahonermann retitled this revision from "[Clang] Set thread_local Itanium ABI guard variables before calling constructors." to "[Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duratio

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman marked 9 inline comments as done. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName

[PATCH] D135919: [Clang] Correct when Itanium ABI guard variables are set for non-block variables with static or thread storage duration.

tahonermann added a comment. > Please add a comment something like this: Done. Thank you for the prior review comments. This is again ready for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135919/new/ https://reviews.llvm.org/D135919 ___

[PATCH] D136565: [clang] Instantiate alias templates with sugar

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG279fe6281d2c: [clang] Instantiate alias templates with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D136564: [clang] Instantiate NTTPs and template default arguments with sugar

This revision was automatically updated to reflect the committed changes. Closed by commit rGab1140874fc6: [clang] Instantiate NTTPs and template default arguments with sugar (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13656

[PATCH] D136886: [clang] ASTImporter: Fix importing of va_list types and declarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f820c0f55cd: [clang] ASTImporter: Fix importing of va_list types and declarations (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1368

[PATCH] D136977: [clang] Fix handling of unexpanded packs in template argument expressions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGedf1a2e89340: [clang] Fix handling of unexpanded packs in template argument expressions. (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

  1   2   3   >