[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471033. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/Rel

[PATCH] D136817: [RISCV] Add H extension

kito-cheng created this revision. kito-cheng added reviewers: asb, craig.topper, reames. Herald added subscribers: sunshaoce, VincentWu, StephenFan, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinM

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/avxifmaintrin.h:36 +/// __m128i +/// _mm_madd52hi_avx_epu64 (__m128i __X, __m128i __Y, __m128i __Z) +/// \endcode FreddyYe wrote: > pengfei wrote: > > Should we provide unified intrinsic `_mm_madd52hi_e

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

serge-sans-paille accepted this revision. serge-sans-paille added a comment. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 ___ cfe-commits mailing

[PATCH] D135951: [X86][1/2] SUPPORT RAO-INT

FreddyYe added inline comments. Comment at: clang/docs/ReleaseNotes.rst:553 - Fix 32-bit ``__fastcall`` and ``__vectorcall`` ABI mismatch with MSVC. +- Add support for ``RAO-INT`` instructions. Add bullets for supported intrinsics. Comment a

[PATCH] D136815: [clang][Interp] Ignore visitDecl() for local declarations

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We reach visitDecl() for both local and global va

[libunwind] 6408e6c - [libunwind] Add module maps for libunwind

Author: Ian Anderson Date: 2022-10-26T22:39:46-07:00 New Revision: 6408e6c99d42af3bf866f92931d1f17d97bb7d37 URL: https://github.com/llvm/llvm-project/commit/6408e6c99d42af3bf866f92931d1f17d97bb7d37 DIFF: https://github.com/llvm/llvm-project/commit/6408e6c99d42af3bf866f92931d1f17d97bb7d37.diff

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:205 X86_FEATURE (AVX512FP16, "avx512fp16") +X86_FEATURE (AVXVNNIINT8, "avxvnniint8") X86_FEATURE (AVXVNNI, "avxvnni") skan wrote: > Move

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe added inline comments. Comment at: clang/lib/Headers/avxifmaintrin.h:36 +/// __m128i +/// _mm_madd52hi_avx_epu64 (__m128i __X, __m128i __Y, __m128i __Z) +/// \endcode pengfei wrote: > Should we provide unified intrinsic `_mm_madd52hi_epu64` like AVXVNNI?

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471022. FreddyYe added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135932/new/ https://reviews.llvm.org/D135932 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/BuiltinsX8

[PATCH] D133698: [clang][dataflow] Implement transferBranch

martong added a comment. In D133698#3886329 , @aaron.ballman wrote: > FWIW, it looks like this change broke the AIX bot: > https://lab.llvm.org/buildbot/#/builders/214/builds/3932 Yes, I've received many build bot failures complaining about the unused

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134859/new/ https://reviews.llvm.org/D134859 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135750/new/ https://reviews.llvm.org/D135750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135366: [clang][Interp] Implement String- and CharacterLiterals

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135366/new/ https://reviews.llvm.org/D135366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

diseraluca added a comment. In D136604#3882192 , @aaron.ballman wrote: > In D136604#3881949 , @diseraluca > wrote: > >> In D136604#3879928 , >> @aaron.ballman wrote: >>

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

This revision was automatically updated to reflect the committed changes. Closed by commit rG476a497f729a: Add clang_CXXMethod_isCopyAssignmentOperator to libclang (authored by diseraluca, committed by Luca Di Sera ). Changed prior to commit: https://reviews.llvm.org/D136604

[clang] 476a497 - Add clang_CXXMethod_isCopyAssignmentOperator to libclang

Author: Luca Di Sera Date: 2022-10-27T06:55:11+02:00 New Revision: 476a497f729a408ba436f75fc50a41254ce65bc8 URL: https://github.com/llvm/llvm-project/commit/476a497f729a408ba436f75fc50a41254ce65bc8 DIFF: https://github.com/llvm/llvm-project/commit/476a497f729a408ba436f75fc50a41254ce65bc8.diff

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth added a comment. Thanks for the feedback. Those are good catches. I'll send out a patch cleaning those up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 __

[clang] b806437 - [clang] Instantiate concepts with sugared template arguments

Author: Matheus Izvekov Date: 2022-10-27T06:18:53+02:00 New Revision: b8064374b217db061213c561ec8f3376681ff9c8 URL: https://github.com/llvm/llvm-project/commit/b8064374b217db061213c561ec8f3376681ff9c8 DIFF: https://github.com/llvm/llvm-project/commit/b8064374b217db061213c561ec8f3376681ff9c8.dif

[clang] 59f0827 - [clang] Instantiate alias templates with sugar

Author: Matheus Izvekov Date: 2022-10-27T06:18:52+02:00 New Revision: 59f0827e2cf3755834620e7e0b6d946832440f80 URL: https://github.com/llvm/llvm-project/commit/59f0827e2cf3755834620e7e0b6d946832440f80 DIFF: https://github.com/llvm/llvm-project/commit/59f0827e2cf3755834620e7e0b6d946832440f80.dif

[PATCH] D135488: [codegen] Display stack layouts in console

myhsu added a comment. Just some drive-by comments Comment at: llvm/lib/CodeGen/StackFramePrinterPass.cpp:79 + + void printBody(raw_ostream &OS, SlotData &D) const { +OS << formatv("{0,-11} {1,-5} {2,-9} {3,-10}\n", genStackOffset(D.Offset), const SlotData

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

FreddyYe updated this revision to Diff 471014. FreddyYe marked 4 inline comments as done. FreddyYe added a comment. Address comments and update. THX for review: Added llvm/test/CodeGen/X86/stack-folding-int-avx512ifma.ll and llvm/test/CodeGen/X86/stack-folding-int-avxifma.ll. Repository: rG L

[clang] d4b1964 - [clang] Instantiate NTTPs and template default arguments with sugar

Author: Matheus Izvekov Date: 2022-10-27T06:18:12+02:00 New Revision: d4b1964f0554046b1e64908e5c1cd701b25f4c9e URL: https://github.com/llvm/llvm-project/commit/d4b1964f0554046b1e64908e5c1cd701b25f4c9e DIFF: https://github.com/llvm/llvm-project/commit/d4b1964f0554046b1e64908e5c1cd701b25f4c9e.dif

[clang] 326feaa - [clang] Implement sugared substitution changes to infrastructure

Author: Matheus Izvekov Date: 2022-10-27T06:18:07+02:00 New Revision: 326feaafb0913ec6b21d1d89d09cbdbb40db7503 URL: https://github.com/llvm/llvm-project/commit/326feaafb0913ec6b21d1d89d09cbdbb40db7503 DIFF: https://github.com/llvm/llvm-project/commit/326feaafb0913ec6b21d1d89d09cbdbb40db7503.dif

[clang] 63f465b - [clang] Perform sugared substitution of builtin templates

Author: Matheus Izvekov Date: 2022-10-27T06:01:12+02:00 New Revision: 63f465b7f45d374f92d0e7697fddb3fb9b74241e URL: https://github.com/llvm/llvm-project/commit/63f465b7f45d374f92d0e7697fddb3fb9b74241e DIFF: https://github.com/llvm/llvm-project/commit/63f465b7f45d374f92d0e7697fddb3fb9b74241e.dif

[PATCH] D136812: [RISCV] Drop single letter b extension support

kito-cheng created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal,

[PATCH] D136803: [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27f9b0c619c6: [clang] Include the type of a pointer or reference non-type template parameter… (authored by rsmith, committed by mizvekov). Changed

[clang] 27f9b0c - [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

Author: Richard Smith Date: 2022-10-27T05:24:23+02:00 New Revision: 27f9b0c619c6e1439532434b632ea4f9b98f9f97 URL: https://github.com/llvm/llvm-project/commit/27f9b0c619c6e1439532434b632ea4f9b98f9f97 DIFF: https://github.com/llvm/llvm-project/commit/27f9b0c619c6e1439532434b632ea4f9b98f9f97.diff

[PATCH] D136811: WIP: RFC: NFC: C++ Buffer Hardening user documentation.

NoQ created this revision. NoQ added reviewers: aaron.ballman, gribozavr2, xazax.hun, ldionne, jkorous, t-rasmud, ziqingluo-90, malavikasamak. Herald added subscribers: steakhal, martong, rnkovacs. Herald added a project: All. NoQ requested review of this revision. This document accompanies the L

[PATCH] D136803: [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx1z.cpp:592 + + // FIXME: We will need to mangle these cases differently too! + int m; Should be

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice updated this revision to Diff 470992. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt clang/runtime/CMakeLists.txt compiler-rt/cmake/base-config-ix.cma

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 470989. paulkirth added a comment. Fix up use of 'auto' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: llvm/include/llvm/CodeGen/Passes.h llvm/include/l

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice added a comment. Thanks a lot if someone can commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 ___ cfe-commits mailing list cfe-c

[PATCH] D136809: [CMake] Make sure all headers are installed into `CLANG_RESOURCE_DIR`

paperchalice created this revision. paperchalice added reviewers: phosek, Ericson2314. paperchalice added projects: LLVM, clang, OpenMP. Herald added a subscriber: Enna1. Herald added a project: All. paperchalice requested review of this revision. Herald added a reviewer: jdoerfert. Herald added su

[PATCH] D127462: [Clang] Begin implementing Plan 9 C extensions

ksaunders added a comment. Thanks for your response. I am working on an RFC now which addresses your feedback and questions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127462/new/ https://reviews.llvm.org/D127462 __

[PATCH] D134128: [P0857R0 Part B] Resubmit an implemention for constrained template template parameters

h-vetinari added inline comments. Comment at: clang/docs/ReleaseNotes.rst:554 +- Implemented `P0857R0 `_, + which words for constrained lambdas and constrained template *template-parameter*\s. ---

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 470984. paulkirth added a comment. Fix pass name in a comment block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: llvm/include/llvm/CodeGen/Passes.h ll

[PATCH] D135488: [codegen] Display stack layouts in console

paulkirth updated this revision to Diff 470983. paulkirth retitled this revision from "[codegen][WIP] Display stack layouts in console" to "[codegen] Display stack layouts in console". paulkirth edited the summary of this revision. paulkirth added a comment. Rebase and update description Reposi

[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

yonghong-song created this revision. yonghong-song added reviewers: aaron.ballman, dblaikie. yonghong-song added a project: clang. Herald added a project: All. yonghong-song requested review of this revision. Herald added a subscriber: cfe-commits. For the following program, $ cat t.c struct

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks for confirming. I have pushed a patch at: https://reviews.llvm.org/D136803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874 ___

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. I can confirm that applying the following: diff --git a/clang/lib/AST/ASTContext.cpp b/clang/lib/AST/ASTContext.cpp index a8585a6d84ad..f07c40cb6c5d 100644 --- a/clang/lib/AST/ASTContext.cpp +++ b/clang/lib/AST/ASTContext.cpp @@ -6774,7 +6774,7 @@ ASTContext::g

[PATCH] D136803: [clang] Include the type of a pointer or reference non-type template parameter in its notion of template argument identity.

mizvekov created this revision. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We already did this for all the other kinds of non-type template argument. We're still missing the type from the mangling,

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. I think there is a high chance that the bug that caused richard's patch to be reverted, was actually fixed afterwards by https://github.com/llvm/llvm-project/commit/acb767f5cda59302aa9100afcf6133d66779d42c So I will try to land that one again, and then I will try to la

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

kees accepted this revision. kees added a comment. The self-tests all look correct to me, so I expect it is working how I'd expect. I haven't had a chance to do kernel builds with this yet, but I'm hoping to make time soon. I'd say if others are happy, let's land it, and if anything unexpected

[PATCH] D135284: [Driver] allow target override containing . in executable name

This revision was automatically updated to reflect the committed changes. Closed by commit rG0d7eba1aeed8: [Driver] Allow target override containing . in executable name (authored by dankm, committed by MaskRay). Changed prior to commit: https://reviews.llvm.org/D135284?vs=470918&id=470970#toc

[clang] 0d7eba1 - [Driver] Allow target override containing . in executable name

Author: Dan McGregor Date: 2022-10-26T16:52:32-07:00 New Revision: 0d7eba1aeed853798bd8012f786c305e83a97b67 URL: https://github.com/llvm/llvm-project/commit/0d7eba1aeed853798bd8012f786c305e83a97b67 DIFF: https://github.com/llvm/llvm-project/commit/0d7eba1aeed853798bd8012f786c305e83a97b67.diff

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added a comment. Quick ping to @kees and @serge-sans-paille for any comments. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134902/new/ https://reviews.llvm.org/D134902 ___ cfe-commits mailing li

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. This is surprisingly not from a bug in this patch. So `getCanonicalTemplateArgument` is broken for the types of declarations. This bug was supposedly fixed by zygoloid (https://github.com/llvm/llvm-project/commit/849c60541b630ddf8cabf9179fa771b3f4207) But then was reve

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron marked 2 inline comments as done. Izaron added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:12452 +int Ilogb; +if (APFloat::opStatus St = ilogb(F, Ilogb); !isConstantOpStatus(St)) + return false; jcranmer-intel wrote: > Izaron w

[PATCH] D136568: [Clang] Support constexpr builtin ilogb

Izaron updated this revision to Diff 470962. Izaron added a comment. Add test for min/max value. Fix comment for ilog. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136568/new/ https://reviews.llvm.org/D136568 Files: clang/docs/LanguageExtension

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#388 , @glandium wrote: > It's the opposite of deprecated, it's (optionally) using something that is > only available in newer versions of macos. Right, I mis-typed, but this is probably using the 'availability' a

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec273d3e3a8c: Add a warning for not packing non-POD members in packed structs (authored by dblaikie). Changed prior to commit: https://reviews.llv

[clang] ec273d3 - Add a warning for not packing non-POD members in packed structs

Author: David Blaikie Date: 2022-10-26T22:18:51Z New Revision: ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af URL: https://github.com/llvm/llvm-project/commit/ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af DIFF: https://github.com/llvm/llvm-project/commit/ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af.diff LOG:

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:249 unless(isVariadic()), parameterCountIs(0), +un

[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

alexander-shaposhnikov created this revision. alexander-shaposhnikov added reviewers: gribozavr2, ymandel, LegalizeAdulthood, alexfh. alexander-shaposhnikov created this object with visibility "All Users". Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. alexander-s

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7846d590033e: Extend the C++03 definition of POD to include defaulted functions (authored by dblaikie). Changed prior to commit: https://reviews.l

[clang] 7846d59 - Extend the C++03 definition of POD to include defaulted functions

Author: David Blaikie Date: 2022-10-26T22:00:49Z New Revision: 7846d590033e8d661198f4c00f56f46a4993c526 URL: https://github.com/llvm/llvm-project/commit/7846d590033e8d661198f4c00f56f46a4993c526 DIFF: https://github.com/llvm/llvm-project/commit/7846d590033e8d661198f4c00f56f46a4993c526.diff LOG:

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

mizvekov added a comment. Thanks. Reduced to: void foo(); template void bar() {} template void bar<>(); template void bar(); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133874/new/ https://reviews.llvm.org/D133874

[PATCH] D134453: Disambiguate type names when printing NTTP types

dblaikie added a comment. >>> So we might print it with a syntax as if the class was a simple pod type, >>> even though that might produce a completely different result if used in >>> practice. >>> I don't think we can do much better without having the actual expression >>> used. >>> >>> That m

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, tra, yaxunl, jdoerfert, tianshilei1992. Herald added a subscriber: hiraditya. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a project: All

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

glandium added a comment. In D136533#3885302 , @mizvekov wrote: > Nonetheless, it seems libc++ uses a deprecated declaration from it's own > headers. It's the opposite of deprecated, it's (optionally) using something that is only available in newer ver

[clang] f039437 - git clang-format HEAD~

Author: Nick Desaulniers Date: 2022-10-26T14:24:30-07:00 New Revision: f03943722ba5a9fb2a0f23eb158ad469428b8876 URL: https://github.com/llvm/llvm-project/commit/f03943722ba5a9fb2a0f23eb158ad469428b8876 DIFF: https://github.com/llvm/llvm-project/commit/f03943722ba5a9fb2a0f23eb158ad469428b8876.di

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen added reviewers: aaron.ballman, nickdesaulniers, pcc, joaomoreira, kees, nathanchance. samitolvanen added a comment. Similarly to D134831 , `-Wincompatible-function-pointer-types` also seems to miss int <-> enum mismatches in function pointer assig

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen created this revision. Herald added a project: All. samitolvanen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang supports indirect call Control-Flow Integrity (CFI) sanitizers (e.g. -fsanitize=cfi-icall), which enforce an

[PATCH] D136789: [clang] Remove no-op -fexperimental-new-pass-manager/-fno-legacy-pass-manager flags

aeubanks created this revision. aeubanks added a reviewer: MaskRay. Herald added a subscriber: StephenFan. Herald added a reviewer: ctetreau. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These have b

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOp

[PATCH] D135284: [Driver] allow target override containing . in executable name

dankm added a comment. Thanks! Since I don't have privileges to push, can you do that on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135284/new/ https://reviews.llvm.org/D135284 ___ cfe-comm

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1865 FuncAttrs.addAttribute("approx-func-fp-math", "true"); -if ((LangOpts.FastMath || - (!LangOpts.FastMath && LangOpts.AllowFPReassoc && - LangOpts.AllowRecip && !LangOp

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1aad641c7930: [Clang][Sema] Add -Wcast-function-type-strict (authored by samitolvanen). Changed prior to commit: https://reviews.llvm.org/D134831?

[clang] 1aad641 - [Clang][Sema] Add -Wcast-function-type-strict

Author: Sami Tolvanen Date: 2022-10-26T20:38:37Z New Revision: 1aad641c793090b4d036c03e737df2ebe2c32c57 URL: https://github.com/llvm/llvm-project/commit/1aad641c793090b4d036c03e737df2ebe2c32c57 DIFF: https://github.com/llvm/llvm-project/commit/1aad641c793090b4d036c03e737df2ebe2c32c57.diff LOG:

[PATCH] D136635: [clang-format] Don't misannotate in CTor init list

HazardyKnusperkeks updated this revision to Diff 470921. HazardyKnusperkeks marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136635/new/ https://reviews.llvm.org/D136635 Files: clang/lib/Format/TokenAnnotator.cpp c

[PATCH] D135284: [Driver] allow target override containing . in executable name

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135284/new/ https://reviews.llvm.org/D135284 __

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm once D136624 lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136007/new/ https://reviews.llvm

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale created this revision. michele.scandale added reviewers: zahiraam, aaron.ballman, andrew.w.kaylor, rjmccall, efriedma, fhahn. Herald added a subscriber: ormris. Herald added a project: All. michele.scandale requested review of this revision. Herald added a project: clang. Herald a

[PATCH] D135284: [Driver] select alternative target containing . in executable name

dankm added a comment. In D135284#3886471 , @MaskRay wrote: > In D135284#3886469 , @dankm wrote: > >> Thanks for the feedback. I've added a testcase for this, I'll push that >> change and update the summary. > >

[PATCH] D135284: [Driver] select alternative target containing . in executable name

dankm updated this revision to Diff 470918. dankm added a comment. Added a simple testcase, and updated commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135284/new/ https://reviews.llvm.org/D135284 Files: clang/lib/Driver/ToolChain.

[PATCH] D135284: [Driver] select alternative target containing . in executable name

MaskRay added a comment. In D135284#3886469 , @dankm wrote: > Thanks for the feedback. I've added a testcase for this, I'll push that > change and update the summary. Did you upload a new patch to the differential? I cannot see it. Repository: rG LL

[PATCH] D135284: [Driver] select alternative target containing . in executable name

dankm added a comment. Thanks for the feedback. I've added a testcase for this, I'll push that change and update the summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135284/new/ https://reviews.llvm.org/D135284 _

[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

glandium added a comment. Reduced testcase: cc1 command line: `clang-16 -cc1 -triple x86_64-unknown-linux-gnu -emit-obj -o Unified_cpp_editor_txmgr0.o -x c++-cpp-output Unified_cpp_editor_txmgr0.ii` source file content: class nsCycleCollectionParticipant; class nsCycleCollectingAutoRefCnt;

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:336 + Previous.MatchingParen && Previous.MatchingParen->Previous && + Previous.MatchingParen->Previous->is(tok::r_brace) && + Previous.MatchingParen->Previous->MatchingP

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

HazardyKnusperkeks updated this revision to Diff 470914. HazardyKnusperkeks marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135918/new/ https://reviews.llvm.org/D135918 Files: clang/lib/Format/ContinuationIndenter.c

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

steven_wu added a comment. > Yes, we can. I pondered doing it in the original patch but didn't see a > reason this would evolve in the future. Of course, I can't predict the > future, so maybe a version field is the safe approach. I think a version number should be good enough for now. For the

[PATCH] D135472: [ODRHash] Hash attributes on declarations.

vsapsai updated this revision to Diff 470915. vsapsai added a comment. Rebase and diagnose attribute mismatch for function parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135472/new/ https://reviews.llvm.org/D135472 Files: clang/includ

[PATCH] D136723: [include-cleaner] Record main-file macro occurences and includes

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:52 struct Symbol { enum Kind { // A canonical clang dec

[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

kda added a comment. This may have broken HWASAN buildbot: https://lab.llvm.org/buildbot/#/builders/236/builds/786 Running a build just before and after to check to validate guess based on stack. log snippet: ==956880==ERROR: HWAddressSanitizer: tag-mismatch on address 0xc09c0031 at pc 0

[PATCH] D136784: [Clang] Improve diagnotisc message for loop hint pragma

eopXD updated this revision to Diff 470913. eopXD added a comment. Trigger upon parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136784/new/ https://reviews.llvm.org/D136784 Files: clang/lib/Parse/ParsePragma.cpp clang/test/Parse

[PATCH] D136784: [Clang] Improve diagnotisc message for loop hint pragma

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Originally the loop hint is not displayed correctly in the diagnostic. This patch fixes it. Repository: rG LLVM

[PATCH] D136783: Pre-commit test case

eopXD created this revision. Herald added a project: All. eopXD requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136783 Files: clang/test/Parser/pragma-loop.cpp

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks added a comment. Do you still intend to work on this? Otherwise I will commandeer and abandon. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 ___ cfe-commits mailing list cfe-comm

[PATCH] D136782: [include-cleaner] Move the writeHTMLReport to the public header, NFC.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D136782 Files: clang-tools-extra/include-cleaner/in

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

benlangmuir added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4324 +if (Epoch.getAsInteger(10, V) || V > MaxTimestamp) { Diags.Report(diag::err_fe_invalid_source_date_epoch) << Epoch << MaxTimestamp; benlangmuir wr

[PATCH] D136717: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG211f5af38af1: [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC (authored by benlangmuir). Herald added a project: clang. Herald add

[clang] 211f5af - [clang] Move getenv call for SOURCE_DATE_EPOCH out of frontend NFC

Author: Ben Langmuir Date: 2022-10-26T12:42:56-07:00 New Revision: 211f5af38af1810925343bb71d90ca8485e66300 URL: https://github.com/llvm/llvm-project/commit/211f5af38af1810925343bb71d90ca8485e66300 DIFF: https://github.com/llvm/llvm-project/commit/211f5af38af1810925343bb71d90ca8485e66300.diff

[clang] 126db46 - [OpenMP][FIX] Adjust to clang tests after D136740

Author: Johannes Doerfert Date: 2022-10-26T12:33:55-07:00 New Revision: 126db4674aa54a37af4349d39f22e506b93d15de URL: https://github.com/llvm/llvm-project/commit/126db4674aa54a37af4349d39f22e506b93d15de DIFF: https://github.com/llvm/llvm-project/commit/126db4674aa54a37af4349d39f22e506b93d15de.d

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added inline comments. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:3002 +// The format of the stat cache is (pseudo-code): +// struct stat_cache { +//char Magic[4]; // "STAT" or "Stat" steven_wu wrote: > Few comments about stats repres

[PATCH] D133698: [clang][dataflow] Implement transferBranch

aaron.ballman added a comment. FWIW, it looks like this change broke the AIX bot: https://lab.llvm.org/buildbot/#/builders/214/builds/3932 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133698/new/ https://reviews.llvm.org/D133698

[PATCH] D136715: [NFC][Offload Bundler] Formatting clang offloadbundler source file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b11caa82620: [NFC][Offload Bundler] Formatting clang offloadbundler source file. (authored by raghavmedicherla). Repository: rG LLVM Github Monor

[clang] 5b11caa - [NFC][Offload Bundler] Formatting clang offloadbundler source file.

Author: raghavmedicherla Date: 2022-10-26T15:12:47-04:00 New Revision: 5b11caa826202126ff102f3452d60d6c7b009913 URL: https://github.com/llvm/llvm-project/commit/5b11caa826202126ff102f3452d60d6c7b009913 DIFF: https://github.com/llvm/llvm-project/commit/5b11caa826202126ff102f3452d60d6c7b009913.di

[PATCH] D136779: [clang][AST] make FunctionProtoType::Profile consistent for FoldingSet

troyj created this revision. troyj added a reviewer: bruno. Herald added a project: All. troyj requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch changes the Profile function to match the FunctionProtoType constructor, which uses e

[PATCH] D136737: [Draft] [clang] Add builtin_unspecified_value

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11725 +TreeTransform::TransformUnspecifiedValueExpr(UnspecifiedValueExpr *E) { + return E; +} aaron.ballman wrote: > @erichkeane -- is this correct, or does work need to be done to ins

  1   2   3   >