[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added a comment. > Yes, all of this stuff is important (and, yes, we are drifting into other > [related] topics) - we already have a mechanism for providing function bodies > to optimisation [LTO] - I do not think we should want to make module > interfaces larger than necessary to dup

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. I am also OK with doing this in two steps (first in the driver with this patch and then by updating the FE to allow the two outputs from one invocation - my draft patch series). BTW: I did mean to ask before .,, did you consider this (existing) command syntax? `-fmodule

[clang] dbfa97b - [doc] Fix invalid reference to `hasReturnArgument` matcher.

Author: Clement Courbet Date: 2022-10-18T08:47:21+02:00 New Revision: dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b URL: https://github.com/llvm/llvm-project/commit/dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b DIFF: https://github.com/llvm/llvm-project/commit/dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b.dif

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

iains added a comment. In D134267#3863938 , @ChuanqiXu wrote: >>> Although modular code is user-facing - BMIs are an implementational detail, >>> right? >> >> but I don't think BMIs are an implementation detail, anymore than object >> files are - users

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen updated this revision to Diff 468430. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136133/new/ https://reviews.llvm.org/D136133 Files: clang/test/CXX/drs/dr25xx.cpp clang/test/CXX/drs/dr2xx.cpp clang/ww

[PATCH] D136134: [NFC] [DirectX backend] move ResourceClass into llvm.

python3kgae created this revision. python3kgae added reviewers: pow2clk, beanz, bogner. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Move Re

[PATCH] D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status

ychen created this revision. ychen added reviewers: royjacobson, erichkeane. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For https://github.com/llvm/llvm-project/issues/58382 Repository: rG LLVM Gi

[clang] 4e2a629 - [Clang] add DR tests for D128745

Author: Yuanfang Chen Date: 2022-10-17T23:24:29-07:00 New Revision: 4e2a629c7238008de0ab45e6bb96aeaecac2bca9 URL: https://github.com/llvm/llvm-project/commit/4e2a629c7238008de0ab45e6bb96aeaecac2bca9 DIFF: https://github.com/llvm/llvm-project/commit/4e2a629c7238008de0ab45e6bb96aeaecac2bca9.diff

[PATCH] D135801: [clang][Lexer] Speedup HeaderSearch when there are many HeaderMaps

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Thanks for the detailed explanations, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135801/new/ https://reviews.llvm.org/D135801 __

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

sepavloff added a comment. In D135439#3864165 , @MaskRay wrote: > I am not familiar with `ExpansionContext`. Is there any behavior difference > which can be demonstrated by a test? This is an NFC test, it does not change behavior. However moving these

[PATCH] D135340: [PGO] Make emitted symbols hidden

abrachet updated this revision to Diff 468425. abrachet added a comment. The error @zequanwu ran into happens only on MacOS because it this Darwin-only test happens to be the only one that tests instrprof with no code. `__llvm_profile_filename` doesn't get emitted in this case so it ends up pul

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

yonghong-song added a comment. In D136041#3863748 , @dblaikie wrote: > Hmm - this does mean linking IR can produce invalid code, though, right (you > link in a definition of the function, so what was valid is now invalid - > because it now has a definit

[PATCH] D135439: Keep configuration file search directories in ExpansionContext. NFC

MaskRay added a comment. I am not familiar with `ExpansionContext`. Is there any behavior difference which can be demonstrated by a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135439/new/ https://reviews.llvm.org/D135439 _

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94215d2b2103: [clang-format] Correctly annotate star/amp in function pointer params (authored by rymiel). Repository: rG LLVM Github Monorepo CHA

[clang] 94215d2 - [clang-format] Correctly annotate star/amp in function pointer params

Author: Emilia Dreamer Date: 2022-10-18T08:17:23+03:00 New Revision: 94215d2b2103c5ad74596dd51704836f92afec89 URL: https://github.com/llvm/llvm-project/commit/94215d2b2103c5ad74596dd51704836f92afec89 DIFF: https://github.com/llvm/llvm-project/commit/94215d2b2103c5ad74596dd51704836f92afec89.diff

[clang] 8e7d5d5 - [NFC] Add missing ABI requirement from the previous patch

Author: Chuanqi Xu Date: 2022-10-18T13:16:04+08:00 New Revision: 8e7d5d5863105aa2c0610bc5d00e5cfad683c7fd URL: https://github.com/llvm/llvm-project/commit/8e7d5d5863105aa2c0610bc5d00e5cfad683c7fd DIFF: https://github.com/llvm/llvm-project/commit/8e7d5d5863105aa2c0610bc5d00e5cfad683c7fd.diff LO

[PATCH] D129443: [clang-format] Add option for aligning requires clause body

rymiel updated this revision to Diff 468414. rymiel added a comment. Swap the default for LLVM style, and adjust tests which depended on the previous style to still use it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129443/new/ https://reviews.

[PATCH] D134853: [clang-format] Correctly annotate UDLs as OverloadedOperator

rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:413 + EXPECT_TOKEN(Tokens[3], tok::string_literal, TT_OverloadedOperator); + EXPECT_TOKEN(Tokens[4], tok::identifier, TT_OverloadedOperator); + EXPECT_TOKEN(Tokens[5], tok::l_paren, TT_Over

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire marked 5 inline comments as done. junaire added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:17398-17399 + const bool IsDiscardMisalignedPointer = + T->isPointerType() && + (T->getPointeeType()->isIncompleteType() || T->isDependentTy

[PATCH] D136018: [Clang] Fix crash when checking misaligned member with dependent type

junaire updated this revision to Diff 468409. junaire added a comment. Add the original mailformed test case, thanks Shafik! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136018/new/ https://reviews.llvm.org/D136018 Files: clang/lib/Sema/SemaChe

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-redefinition.m:37 +// RUN: %clang @%t/third.cc1.rsp +// RUN: %clang @%t/first.cc1.rsp Before this patch, this would fail with duplicate definition of module 'X'. It would be reached

[clang] db82096 - [NFC] [C++20] [Modules] Test if the functions in importee are generated

Author: Chuanqi Xu Date: 2022-10-18T11:40:49+08:00 New Revision: db82096ff0aaadd4ce9b76ea3ffb188c9e5a0a64 URL: https://github.com/llvm/llvm-project/commit/db82096ff0aaadd4ce9b76ea3ffb188c9e5a0a64 DIFF: https://github.com/llvm/llvm-project/commit/db82096ff0aaadd4ce9b76ea3ffb188c9e5a0a64.diff LO

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8141 + i128mem, X86vpdpbssd, SchedWriteVecIMul.XMM, + 1>, T8XD; + defm VPDPBSSDY : avx_dotprod_rm<0x50,"vpdpbssd", v8i32, VR2

[PATCH] D136124: [clang][deps] Remove unintentional `move`

jansvoboda11 created this revision. jansvoboda11 added a reviewer: DavidSpickett. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a fix related to D13541

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe updated this revision to Diff 468398. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135938/new/ https://reviews.llvm.org/D135938 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8118 +let Predicates = [HasCMPCCXADD, In64BitMode], Constraints = "$dstsrc2 = $dst" in +multiclass CMPCCXADD_BASE Opc, string OpcodeStr> { craig.topper wrote: > This feels like

[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

FreddyYe marked 2 inline comments as done. FreddyYe added inline comments. Comment at: llvm/test/MC/Disassembler/X86/avx-vnni_int8-att.txt:1 +# RUN: llvm-mc --disassemble %s -triple=i686 | FileCheck %s + RKSimon wrote: > I think we'd be better off merging the att

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86_64.def:138 +TARGET_BUILTIN(__builtin_ia32_cmpccxadd64, "SLLiv*SLLiSLLiIi", "n", "cmpccxadd") #undef BUILTIN #undef TARGET_BUILTIN There was a blank line here. Put it back.

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:781 +Builder.defineMacro("__CMPCCXADD__"); + Builder.defineMacro("__CMPCCXADD_SUPPORTED__"); if (HasAVXVNNI) What is __CMPCCXADD_SUPPORTED__ for? Comment at

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ChuanqiXu added subscribers: ruoso, ben.boeckel. ChuanqiXu added a comment. >> Although modular code is user-facing - BMIs are an implementational detail, >> right? > > but I don't think BMIs are an implementation detail, anymore than object > files are - users should/will be as aware of BMIs as

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:588 +else if (A->getOption().matches(options::OPT_ggdb) || + Args.getLastArg(options::O

[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

vangthao added inline comments. Comment at: clang/test/SemaCXX/references.cpp:93 -struct C : B, A { }; // expected-warning {{direct base 'A' is inaccessible due to ambiguity:\nstruct C -> struct B -> struct A\nstruct C -> struct A}} +struct C : B, A { }; // expected-warnin

[PATCH] D135772: Stop evaluating trailing requires clause after overload resolution

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135772/new/ https://reviews.llvm.org/D135772 ___ cfe-commits mailing list c

[PATCH] D130325: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2662009c87f4: [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches. (authored by vsapsai). Changed prior to commit: https://reviews.

[clang] 2662009 - [ODRHash] Hash `ObjCMethodDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2022-10-17T18:48:24-07:00 New Revision: 2662009c87f470ec5bc13c237cd62c57b28e4032 URL: https://github.com/llvm/llvm-project/commit/2662009c87f470ec5bc13c237cd62c57b28e4032 DIFF: https://github.com/llvm/llvm-project/commit/2662009c87f470ec5bc13c237cd62c57b28e4032.di

[PATCH] D135937: [X86] Support -march=meteorlake

FreddyYe marked 3 inline comments as done. FreddyYe added a comment. THX for review! Gcc is also recently reviewing related patches. So to align with the compiler-rt and libgcc, let's wait for their land first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D135937: [X86] Support -march=meteorlake

FreddyYe updated this revision to Diff 468387. FreddyYe added a comment. Merge raptorlake patch and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D135937 Files: clang/docs/ReleaseNotes.rst

[PATCH] D135936: [X86] Support -march=raptorlake

FreddyYe marked 4 inline comments as done. FreddyYe added a comment. THX for review! Merged to https://reviews.llvm.org/D135937 and addressed there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135936/new/ https://reviews.llvm.org/D135936 ___

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

vsapsai added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130324/new/ https://reviews.llvm.org/D130324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] 37fdca2 - [ODRHash] Rename `isDeclToBeProcessed` to `isSubDeclToBeProcessed`. NFC intended.

Author: Volodymyr Sapsai Date: 2022-10-17T18:24:44-07:00 New Revision: 37fdca21f7f61dee5426f55b0ee7bf601d95afcd URL: https://github.com/llvm/llvm-project/commit/37fdca21f7f61dee5426f55b0ee7bf601d95afcd DIFF: https://github.com/llvm/llvm-project/commit/37fdca21f7f61dee5426f55b0ee7bf601d95afcd.di

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

On Mon, Oct 17, 2022 at 5:52 PM stan li wrote: > > Thanks for the suggestion. > > > > Updated llvm_unreachable. > > > > The static_cast not only check the switch cases all covered, also make sure 2 > enums not out of sync. Ah, OK - thanks for explaining! > > > > > > > > Sent from Mail for Win

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. In D134267#3851479 , @ChuanqiXu wrote: > In D134267#3849629 , @dblaikie > wrote: > >> To the original point I was making about implicit modules (which might've >> been my own confusion

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

dblaikie added a comment. (sorry I've not been following all this as closely as I should - but I don't think BMIs are an implementation detail, anymore than object files are - users should/will be as aware of BMIs as they are of .o files - there build artifacts that need to be cached, can be ou

[clang] 3a671c8 - [NFC] use llvm_unreachable instead of return on switch which all cases are covered.

Author: Xiang Li Date: 2022-10-17T17:47:48-07:00 New Revision: 3a671c8e91c04a3288357f088adcd364a6cd6b22 URL: https://github.com/llvm/llvm-project/commit/3a671c8e91c04a3288357f088adcd364a6cd6b22 DIFF: https://github.com/llvm/llvm-project/commit/3a671c8e91c04a3288357f088adcd364a6cd6b22.diff LOG:

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

Also the static_assert is probably not needed - Clang builds with -Wswitch-enum, which will warn if a switch over an enum doesn't cover all the enumerators. We have lots of other switches over enums that depend on this warning to detect code that needs to be updated when an enum is modified. On Mo

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

If the switch is exhaustive (covers all the enumerators in an enumeration), we usually use an llvm_unreachable at the end, rather than a return. Could you change this to an llvm_unreachable? On Mon, Oct 17, 2022 at 3:52 PM Xiang Li via cfe-commits wrote: > > > Author: Xiang Li > Date: 2022-10-17T

[PATCH] D136041: [clang][DebugInfo] Emit DISubprogram for extern functions with reserved names

dblaikie added a comment. Hmm - this does mean linking IR can produce invalid code, though, right (you link in a definition of the function, so what was valid is now invalid - because it now has a definition, can be inlined, etc)? Is that new? concerning? Repository: rG LLVM Github Monorepo

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

tstellar added a comment. In what scenarios will clang load the clang.cfg file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134337/new/ https://reviews.llvm.org/D134337 ___ cfe-commits mailing list cfe

[PATCH] D134337: [clang] [Driver] More flexible rules for loading default configs

tstellar added inline comments. Comment at: clang/docs/UsersManual.rst:954 + +For example, ``x86_64-pc-linux-gnu-clang-g++`` will attempt to load two +configuration files named respectively:: Is `x86_64-pc-linux-gnu-clang-g++ ` being passed to --driver= in this e

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

rjmccall added a comment. It's certainly possible that other targets will want to support multiple C++ ABIs in the future, but it's okay for us to design things around the situation we've got today. A lot of these "ABIs" are just target-specific variants; if it simplifies code to just make ABI

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

nridge added a comment. In D127403#3863686 , @thakis wrote: > In D127403#3863641 , @nridge wrote: > >> Landed https://reviews.llvm.org/rGc93430bae4fc > > Still failing with that: http://45.33.8.238/linux/89240/ste

[PATCH] D135713: [cmake][Fuchsia] Add -ftrivial-auto-var-init=zero to runtimes build

dblaikie added a comment. any chance of using pattern init rather than zero init, so this doesn't hide uninitialized bugs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135713/new/ https://reviews.llvm.org/D135713

[clang-tools-extra] d5a99bf - [clangd] Update 'using enum' semantic highlighting testcase to use the 'definition' modifier

Author: Nathan Ridge Date: 2022-10-17T20:15:52-04:00 New Revision: d5a99bf5e134b31cf6ef3219313fa7d2fc480629 URL: https://github.com/llvm/llvm-project/commit/d5a99bf5e134b31cf6ef3219313fa7d2fc480629 DIFF: https://github.com/llvm/llvm-project/commit/d5a99bf5e134b31cf6ef3219313fa7d2fc480629.diff

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

dblaikie added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:2 // REQUIRES: x86-registered-target -// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0 -fsanitize=array-bounds%s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-STR

[PATCH] D136120: [Clang] follow-up D128745, remove all ClangABICompat checks

ychen created this revision. ychen added reviewers: aaron.ballman, erichkeane, hubert.reinterpretcast. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per discussions in D128745

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

thakis added a comment. In D127403#3863641 , @nridge wrote: > Landed https://reviews.llvm.org/rGc93430bae4fc Still failing with that: http://45.33.8.238/linux/89240/step_9.txt Time to revert to green? Things have been broken for a few hours now. Maybe

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

shafik requested changes to this revision. shafik added a comment. This revision now requires changes to proceed. The current approach of mixing bytes and indices in the same diagnostic is too confusing. I think we see some acceptable messages for out of bounds access by looking at three differe

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

nridge added a comment. Landed https://reviews.llvm.org/rGc93430bae4fc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@

[clang-tools-extra] c93430b - [clangd] Update testcase for issue 1222 to use the 'definition' modifier

Author: Nathan Ridge Date: 2022-10-17T19:56:19-04:00 New Revision: c93430bae4fc95b58185900aa5f0ccbc037de031 URL: https://github.com/llvm/llvm-project/commit/c93430bae4fc95b58185900aa5f0ccbc037de031 DIFF: https://github.com/llvm/llvm-project/commit/c93430bae4fc95b58185900aa5f0ccbc037de031.diff

[PATCH] D131594: WORK IN PROGRESS Add Clang UEFI target to support "x86_64-unknown-uefi" triple

Prabhuk updated this revision to Diff 468370. Prabhuk added a comment. Herald added a subscriber: MaskRay. Added changes to the Driver.cpp. This version uses underlying MSVC toolchain to compile UEFI target introduced here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

nridge added a comment. Landing the fix now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D136103: OpenMP asynchronous memory copy support

jdoerfert added a comment. First set of comments. Comment at: clang/docs/ReleaseNotes.rst:253 + `Issue 47177 `_ + `Issue 47179 `_ Unrelated, probably bad d

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

thakis added a comment. Looks like this breaks check-clangd everywhere, eg http://45.33.8.238/linux/89237/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 __

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 468366. ayzhao added a comment. accidentally removed an extra curly brace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clan

[PATCH] D130324: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9c79eab7fdd5: [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches. (authored by vsapsai). Changed prior to commit: https://review

[clang] 9c79eab - [ODRHash] Hash `ObjCProtocolDecl` and diagnose discovered mismatches.

Author: Volodymyr Sapsai Date: 2022-10-17T16:29:52-07:00 New Revision: 9c79eab7fdd5e2bc413e9c4510f759716cd09184 URL: https://github.com/llvm/llvm-project/commit/9c79eab7fdd5e2bc413e9c4510f759716cd09184 DIFF: https://github.com/llvm/llvm-project/commit/9c79eab7fdd5e2bc413e9c4510f759716cd09184.di

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 468356. void added a comment. Fix rogue test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added a comment. The messages that's a bit annoying are the ones reporting "0 bytes past the end of the array": warning: array index 2 is 0 bytes past the end of the array (that has type 'int[2]') I'm not sure what to do with these (except to leave them alone). Repository: rG LLVM G

[PATCH] D136111: [OpenMP] Make device functions have hidden visibility

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, should be fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136111/new/ https://reviews.llvm.org/D136111 __

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 468355. void added a comment. Update more testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135920/new/ https://reviews.llvm.org/D135920 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/li

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void updated this revision to Diff 468353. void added a comment. Improve the error message to include how many bytes the index goes over warning: the pointer incremented by 14 refers 1 byte past the end of the array (that has type 'const char[13]') Repository: rG LLVM Github Monorepo CHAN

[clang] 0674f2e - [NFC] Fix warning on no return after switch.

Author: Xiang Li Date: 2022-10-17T15:52:23-07:00 New Revision: 0674f2ec96422131abde0c042fbf2c11267db210 URL: https://github.com/llvm/llvm-project/commit/0674f2ec96422131abde0c042fbf2c11267db210 DIFF: https://github.com/llvm/llvm-project/commit/0674f2ec96422131abde0c042fbf2c11267db210.diff LOG:

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

nridge added a comment. Looks like an error introduced when rebasing the patch: a recently added test case (for https://github.com/clangd/clangd/issues/1222) needs to be updated to reflect the `_decl` to `_def` change that this patch makes to all semantic highlighting tests. I'll land a fix.

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

Izaron added a comment. > It looks like unrelated formatting changes snuck in to this file. @aaron.ballman JFYI after I reverted what `git clang-format HEAD~1` did to the code, the build has failed ERROR git-clang-format returned an non-zero exit code 1 Build completed with failures http

[PATCH] D126908: [VerifyDiagnosticConsumer] Fix last line being discarded when parsing newline

jkorous added a comment. Thank you for the patch! Comment at: clang/test/SemaCXX/references.cpp:93 -struct C : B, A { }; // expected-warning {{direct base 'A' is inaccessible due to ambiguity:\nstruct C -> struct B -> struct A\nstruct C -> struct A}} +struct C : B, A { }

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

ormris added a comment. Looks like there are some test failures associated with this commit: https://lab.llvm.org/buildbot/#/builders/123/builds/13698 The change list is a bit confusing, as it's only showing LLVM commits. But the change list includes the commit before and the commit after this

[PATCH] D135832: Do not append terminating NUL to the string with embedded GPU binary.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa10eb07d1acc: Do not append terminating NUL to the binary string with embedded fatbin. (authored by tra). Repository: rG LLVM Github Monorepo CHA

[clang] a10eb07 - Do not append terminating NUL to the binary string with embedded fatbin.

Author: Artem Belevich Date: 2022-10-17T15:39:39-07:00 New Revision: a10eb07d1acc2f132b4d0cf522097814a8340b47 URL: https://github.com/llvm/llvm-project/commit/a10eb07d1acc2f132b4d0cf522097814a8340b47 DIFF: https://github.com/llvm/llvm-project/commit/a10eb07d1acc2f132b4d0cf522097814a8340b47.diff

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

mcgrathr added a comment. I'm quite sure that we will always want a means to select the original Itanium ABI. It's also quite likely that there will be future innovations in the Fuchsia C++ ABI and we'll go through migration periods of supporting additional variants and changing the default for

[PATCH] D135920: [clang][Sema] Use correct array size for diagnostic

void added inline comments. Comment at: clang/test/SemaCXX/array-bounds.cpp:240 -((char*)foo)[sizeof(foo)] = '\0'; // expected-warning {{array index 32768 is past the end of the array (which contains 32768 elements)}} +((char*)foo)[sizeof(foo)] = '\0'; // expected-wa

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

nikic added subscribers: arsenm, nikic. nikic added a comment. Checking back here, have you made any progress on reducing the issue? cc @arsenm for awareness Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135269/new/ https://reviews.llvm.org/D13526

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 468347. ayzhao added a comment. Fill out ItaniumMangle.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clang/include/clang

[PATCH] D136106: [clang][RISCV] Set vscale_range attribute based on VLEN

reames updated this revision to Diff 468344. reames edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136106/new/ https://reviews.llvm.org/D136106 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/CodeGen/riscv-vector-bits-vscale-range.c llvm/incl

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Hooks.h:9 +// +// Where Analysis.h analyzes AST nodes and recorded preprocessor events, this +// file defines ways to capture AST and preprocessor information from a pars

[PATCH] D135956: [include-cleaner] Add include-cleaner tool, with initial HTML report

sammccall updated this revision to Diff 468343. sammccall marked 2 inline comments as done. sammccall added a comment. Herald added a project: clang. address comments, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135956/new/ https://revi

[PATCH] D135707: [clang-format] Correctly annotate star/amp in function pointer params

MyDeveloperDay added a comment. I learn a lot from watching the others code review. Definitely not an expert here either, just try to help where I can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135707/new/ https://reviews.llvm.org/D135707 ___

[PATCH] D135908: [clang][LTO] Setting Desired Default AIX Debugging Options

qiongsiwu1 updated this revision to Diff 468341. qiongsiwu1 added a comment. Clean up testcases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135908/new/ https://reviews.llvm.org/D135908 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang

[PATCH] D136100: [clang-format] Do not parse certain characters in pragma directives

MyDeveloperDay added a comment. Pretty interesting, it looks ok from what I can tell, let the others take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136100/new/ https://reviews.llvm.org/D136100 ___

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. Comment at: clang/lib/CodeGen/CGExpr.cpp:1746 + if (auto TyPtr = Ty.getTypePtrOrNull()) { +if (!(TyPtr->isSpecificBuiltinType(BuiltinType::UChar) || Taking into account potantial risks from pre-existing UB, I believe we need

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary)

vitalybuka added a comment. In D134410#3860646 , @xbolva00 wrote: >> I assume with this patch landed, many such cases may change code behavior. >> So we will need to update msan to have a tool to detect cases like this >> anyway. > > I believe that upda

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 468333. ayzhao added a comment. implement CIndex.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/include/clang-c/Index.h clang/include/clang/AST/D

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13163dd8abc5: [HLSL] CodeGen hlsl resource binding. (authored by python3kgae). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130951/new/ https://reviews.llv

[clang] 13163dd - [HLSL] CodeGen hlsl resource binding.

Author: Xiang Li Date: 2022-10-17T14:29:19-07:00 New Revision: 13163dd8abc57443bd0e931650a3c64fead5235e URL: https://github.com/llvm/llvm-project/commit/13163dd8abc57443bd0e931650a3c64fead5235e DIFF: https://github.com/llvm/llvm-project/commit/13163dd8abc57443bd0e931650a3c64fead5235e.diff LOG:

[PATCH] D136111: [OpenMP] Make device functions have hidden visibility

jhuber6 updated this revision to Diff 468328. jhuber6 added a comment. We can't make every function hidden for non-GPU offloading. So we only apply it to the functions inside the `declare target` clause there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D128567: [WIP][Fuchsia] Set LLVM_TOOL_LLD_BUILD to allow some extra runtimes tests to run

aeubanks added a comment. In D128567#3863222 , @abrachet wrote: > In D128567#3863178 , @aeubanks > wrote: > >> I've noticed that we're skipping compiler-rt tests with `REQUIRED: >> lld-available` because `LLVM_T

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

python3kgae added inline comments. Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:73 CodeGenModule &CGM; uint32_t ResourceCounters[static_cast( hlsl::ResourceClass::NumClasses)] = {0}; beanz wrote: > The `ResourceCounters` here was a stand-in for allo

[PATCH] D130951: [HLSL] CodeGen hlsl resource binding.

beanz accepted this revision. beanz added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/CodeGen/CGHLSLRuntime.h:73 CodeGenModule &CGM; uint32_t ResourceCounters[static_cast( hlsl::ResourceClass::NumClasses)] = {0}; --

[PATCH] D136036: [Clang] Add __has_constexpr_builtin support

Izaron added inline comments. Comment at: clang/docs/LanguageExtensions.rst:96 +the constant evaluation of the corresponding builtin (for example, +``std::fmax`` calls ``__builtin_fmax``) is supported in Clang. + Izaron wrote: > Just to be clear: this isn't a tru

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

nridge added a comment. I went ahead and landed this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127403/new/ https://reviews.llvm.org/D127403 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D127403: [clangd] Implement semantic token modifier "definition"

This revision was automatically updated to reflect the committed changes. Closed by commit rG4abc910a42e5: [clangd] Implement semantic token modifier "definition" (authored by ckandeler, committed by nridge). Changed prior to commit: https://reviews.llvm.org/D127403?vs=466731&id=468318#toc Rep

  1   2   3   >