[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 465661. python3kgae added a comment. Fix test fail caused by max address space change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files: clang/include/clan

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

kees added inline comments. Comment at: clang/test/CodeGen/object-size-flex-array.c:45 + // CHECK-STRICT-2: ret i32 -1 + // CHECK-STRICT-3: ret i32 0 return OBJECT_SIZE_BUILTIN(f->c, 1); serge-sans-paille wrote: > This one worries me a bit, as an array of si

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

serge-sans-paille added inline comments. Comment at: clang/test/CodeGen/bounds-checking-fam.c:2 // REQUIRES: x86-registered-target -// RUN: %clang_cc1 -emit-llvm -triple x86_64 -fstrict-flex-arrays=0 -fsanitize=array-bounds%s -o - | FileCheck %s --check-prefixes=CHECK,

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

serge-sans-paille accepted this revision. serge-sans-paille added a comment. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 ___ cfe-com

[clang] 7cbc920 - [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

Author: owenca Date: 2022-10-05T21:54:40-07:00 New Revision: 7cbc9206697e2e7ce0ae2c671c80133327631e7f URL: https://github.com/llvm/llvm-project/commit/7cbc9206697e2e7ce0ae2c671c80133327631e7f DIFF: https://github.com/llvm/llvm-project/commit/7cbc9206697e2e7ce0ae2c671c80133327631e7f.diff LOG: [

[PATCH] D134852: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7cbc9206697e: [clang-format][NFC] Clean up class HeaderIncludes and Format.cpp (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D132855: [OpenMP] Extend the lit test for uses_allocators in target region

animeshk-amd added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_10.cpp:19 +// RUN: %clang_cc1 -no-opaque-pointers -DCK11 -fopenmp -fopenmp-targets=i386-pc-linux-gnu -x c++ -std=c++11 -triple i386-unknown-unknown -emit-pch -o %t %s +// RUN: %clang_cc1 -no-op

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

lime updated this revision to Diff 465652. lime added a comment. Thanks for the advice. I used `AdjustConstraintDepth` before `subsume`. The adjusted constraints are assigned to new addresses, but I think `MutableArrayRef` could be used here. > what do you mean by 'tailing' here? I wanted to e

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

kees accepted this revision. kees added a comment. This revision is now accepted and ready to land. L Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 ___ cfe-co

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(&TT); + } else { ychen wrote: > MaskRay wrote: > > ychen wrote

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

MaskRay updated this revision to Diff 465649. MaskRay marked an inline comment as done. MaskRay edited the summary of this revision. MaskRay added a comment. Use `??? ?? ` or `??:??:??` is gmtime/localtime returns null Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D134478: BareMetal: detect usr/include/c++/v1 path in sysroot

manojgupta updated this revision to Diff 465647. manojgupta added a comment. address comments and check CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134478/new/ https://reviews.llvm.org/D134478 Files: clang/lib/Driver/ToolChains/BareMetal.c

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(&TT); + } else { MaskRay wrote: > ychen wrote: > > MaskRay wrote: > > > ychen wrote: > > > > Why not use l

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane, tcanens. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is information that the compiler already has, and should be

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(&TT); + } else { ychen wrote: > MaskRay wrote: > > ychen wrote

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it possible to be used in all modes, instead of just when `-fm

[PATCH] D135338: [clang] adds move-assignable type-trait builtins

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `__is_move_assignable` - `__is_nothrow_move_assignable` - `__is_trivial

[PATCH] D135060: [HLSL] Add groupshare address space.

python3kgae updated this revision to Diff 465628. python3kgae added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135060/new/ https://reviews.llvm.org/D135060 Files: clang/include/clang/Basic/AddressSpaces.h clang/include/cla

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(&TT); + } else { MaskRay wrote: > ychen wrote: > > Why not use localtime as the else branch? > > > > As m

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added inline comments. Comment at: clang/test/Driver/hip-phases.hip:553 +// +// RUN: %clang -### --target=x86_64-linux-gnu --offload-new-driver -ccc-print-phases \ +// RUN:--offload-arch=gfx90a --offload-arch=gfx908 -foffload-lto -fgpu-rdc -c %s 2>&1 \ -

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1792 // attach range metadata to the load. - } else if (CGM.getCodeGenOpts().OptimizationLevel > 0) +// TODO: Enable range metadata for AMDGCN after backend i

[PATCH] D135335: [HLSL] Add Resource kind for HLSLResourceAttr.

python3kgae created this revision. python3kgae added reviewers: beanz, pow2clk, bogner. Herald added a reviewer: aaron.ballman. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D135287: Disallow dereferencing of void* in C++.

shafik accepted this revision as: shafik. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/docs/ReleaseNotes.rst:92 + error so constraint checking and SFINAE checking can be compatible with other + compilers. It is likely that th

[PATCH] D135306: [CUDA] Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:30-32 +#define SM_89 "sm_87|" SM_90 +#define SM_87 "sm_89|" SM_89 +#define SM_86 "sm_89|" SM_87 yaxunl wrote: > typo? Good catch. Fixed. Repository: rG LLVM Github Monorepo CH

[PATCH] D135306: [CUDA] Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

tra updated this revision to Diff 465612. tra added a comment. fixed typos. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135306/new/ https://reviews.llvm.org/D135306 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/BuiltinsNVPTX.d

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

tra added inline comments. Comment at: clang/lib/Basic/Cuda.cpp:59 +CudaVersion ToCudaVersion(llvm::VersionTuple Version) { + int IVer = Version.getMajor() * 10 + Version.getMinor().value_or(0); + for (auto *I = CudaNameVersionMap; I->Version != CudaVersion::UNKNOWN; ++I) -

[PATCH] D135306: [CUDA] Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:30-32 +#define SM_89 "sm_87|" SM_90 +#define SM_87 "sm_89|" SM_89 +#define SM_86 "sm_89|" SM_87 typo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:553 +// +// RUN: %clang -### --target=x86_64-linux-gnu --offload-new-driver -ccc-print-phases \ +// RUN:--offload-arch=gfx90a --offload-arch=gfx908 -foffload-lto -fgpu-rdc -c %s 2>&1 \ --

[PATCH] D135170: [LLDB] Fix crash when printing a struct with a static signed char member

shafik accepted this revision. shafik added a comment. LGTM Comment at: lldb/test/API/lang/cpp/const_static_integral_member/main.cpp:39 const static auto char_min = std::numeric_limits::min(); const static auto uchar_min = std::numeric_limits::min(); We

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 465606. ayzhao added a comment. implement union support Unions actually work as-is - the only thing I had to do was to cap the number of parameters at 1 Also add some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

yaxunl added inline comments. Comment at: clang/lib/Basic/Cuda.cpp:59 +CudaVersion ToCudaVersion(llvm::VersionTuple Version) { + int IVer = Version.getMajor() * 10 + Version.getMinor().value_or(0); + for (auto *I = CudaNameVersionMap; I->Version != CudaVersion::UNKNOWN; ++I) --

[PATCH] D135256: [clang] Add Create method for CXXBoolLiteralExpr

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135256/new/ https://reviews.llvm.org/D135256 ___

[PATCH] D135306: [CUDA] Add support for CUDA-11.8 and sm_{87,89,90} GPUs.

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, hiraditya, yaxunl. Herald added a project: All. tra updated this revision to Diff 465512. tra added a comment. tra updated this revision to Diff 465557. tra updated this revision to Diff 465577. tra updated

[PATCH] D134546: [clang-offload-bundler] extracting compatible bundle entry

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG844b84af20c7: [clang-offload-bundler] extracting compatible bundle entry (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM

[clang] 844b84a - [clang-offload-bundler] extracting compatible bundle entry

Author: Yaxun (Sam) Liu Date: 2022-10-05T19:44:38-04:00 New Revision: 844b84af20c71482093995b1d64abc190eb5a5f9 URL: https://github.com/llvm/llvm-project/commit/844b84af20c71482093995b1d64abc190eb5a5f9 DIFF: https://github.com/llvm/llvm-project/commit/844b84af20c71482093995b1d64abc190eb5a5f9.dif

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

tra updated this revision to Diff 465601. tra added a comment. Use int max for the "new" CUDA version value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135328/new/ https://reviews.llvm.org/D135328 Files: clang/lib/Basic/Cuda.cpp clang/lib/B

[PATCH] D135328: [CUDA] Refactored CUDA version housekeeping to use less boilerplate.

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, yaxunl. Herald added a project: All. tra updated this revision to Diff 465598. tra added a comment. tra retitled this revision from "Refactored CUDA version housekeeping to use less boilerplate." to "[CUDA]

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1092 +TT = *PP.getPreprocessorOpts().SourceDateEpoch; +TM = std::gmtime(&TT); + } else { ychen wrote: > Why not use localtime as the e

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:774-775 +if ((!Constructor->isDeleted() && !Constructor->isDefaulted()) || +(getLangOpts().getClangABICompat() <= + LangOptions::ClangABI::Ver15 || Target.isPS() || Target.isOSDarwin

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 updated this revision to Diff 465584. jhuber6 added a comment. Changing two tests to use phases instead to illustrate the `lto-bc` usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https://reviews.llvm.org/D135305 Files: c

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

tra added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:1792 // attach range metadata to the load. - } else if (CGM.getCodeGenOpts().OptimizationLevel > 0) +// TODO: Enable range metadata for AMDGCN after backend issue is fixed. + } else if (CGM.getCodeGenO

[PATCH] D134923: [clang][deps] Canonicalize module map path

This revision was automatically updated to reflect the committed changes. Closed by commit rG074fcec1eabf: [clang][deps] Canonicalize module map path (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134923/new/ https://review

[clang] 074fcec - [clang][deps] Canonicalize module map path

Author: Ben Langmuir Date: 2022-10-05T15:42:38-07:00 New Revision: 074fcec1eabfc992c46c95df215b1caf5cf58970 URL: https://github.com/llvm/llvm-project/commit/074fcec1eabfc992c46c95df215b1caf5cf58970 DIFF: https://github.com/llvm/llvm-project/commit/074fcec1eabfc992c46c95df215b1caf5cf58970.diff

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

rnk added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:953 + }; + virtual TailPaddingUseRules getTailPaddingUseRules() const { +return UseTailPaddingUnlessPOD03; The virtual method works, but it does seem to have caused a behavior cha

[PATCH] D135269: [AMDGPU] Disable bool range metadata to workaround backend issue

yaxunl added a comment. In D135269#3837394 , @tra wrote: > Is there more info about the issue? What does AMDGPU currently emit for the > test case? > > AFAICT from running it on CE (https://godbolt.org/z/ccq3vnbrM) llvm optimizes > it to essentially `*y

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file,function}-list= to match gcc options.

paquette added a comment. +1, someone just asked me if this feature exists and then found this patch. If this could be revived, I think it would help a lot of folks out. :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D37624/new/ https://reviews.llvm.org/D37624 ___

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838490 , @yaxunl wrote: > In D135305#3838435 , @jhuber6 wrote: > >> In D135305#3838412 , @yaxunl wrote: >> >>> should we test with -cc

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. In D119051#3834985 , @rnk wrote: > Relatedly, if we put this POD behavior query on TargetInfo, I wonder if it > makes sense to move the tail padding predicate from TargetCXXABI to > TargetInfo: > https://github.com/llvm/llvm-pr

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

yaxunl added a comment. In D135305#3838435 , @jhuber6 wrote: > In D135305#3838412 , @yaxunl wrote: > >> should we test with -ccc-print-phases instead? It is not clear what actions >> are produced by driver. > > A

[PATCH] D135326: Half-done attempt to move tail padding callback from TargetCXXABI to TargetInfo

dblaikie created this revision. dblaikie added a reviewer: rnk. Herald added subscribers: kristof.beyls, dschuff. Herald added a project: All. dblaikie requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. Spinoff from D119051

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838412 , @yaxunl wrote: > should we test with -ccc-print-phases instead? It is not clear what actions > are produced by driver. Ah, realized you meant with phases. This is good enough for NVPTX as there is no explic

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 added a comment. In D135305#3838412 , @yaxunl wrote: > should we test with -ccc-print-phases instead? It is not clear what actions > are produced by driver. Of the four run lines added, three use `-ccc-print-phases`. The last uses just `-###` b

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

yaxunl added a comment. should we test with -ccc-print-phases instead? It is not clear what actions are produced by driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135305/new/ https://reviews.llvm.org/D135305 ___

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

samitolvanen added a comment. In D134831#3838373 , @nickdesaulniers wrote: > Please consider waiting until the warning flag has started propagating to > branches of stable, at least to whatever branch -Werror is first enabled in. Yes, I'm planning to w

[PATCH] D134831: [Clang][Sema] Add -Wcast-function-type-strict

nickdesaulniers added a comment. Please consider waiting until the warning flag has started propagating to branches of stable, at least to whatever branch -Werror is first enabled in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134831/new/ https

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4151 + QualType T = Entity.getType(); + // FIXME: Union is unsupported. + int InitKind = T->isArrayType() ? 0 : 4; ayzhao wrote: > ayzhao wrote: > > Hmm...it seems like as is thi

[clang-tools-extra] 60b4b39 - [clangd] Avoid lexicographic compare when sorting SymbolIDs. NFC

Author: Sam McCall Date: 2022-10-05T23:02:28+02:00 New Revision: 60b4b39f5a78661e2b9d222cf6ba7d9d5d7511ed URL: https://github.com/llvm/llvm-project/commit/60b4b39f5a78661e2b9d222cf6ba7d9d5d7511ed DIFF: https://github.com/llvm/llvm-project/commit/60b4b39f5a78661e2b9d222cf6ba7d9d5d7511ed.diff LO

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465549. ychen added a comment. - rebased on D135088 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465547. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[PATCH] D134923: [clang][deps] Canonicalize module map path

benlangmuir updated this revision to Diff 465544. benlangmuir added a comment. Rebased after landing https://reviews.llvm.org/D135220, which should hopefully fix the Windows test failure (it fixed the path for me locally on Windows, but I had some python-related issues that prevented me from run

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen updated this revision to Diff 465543. ychen added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128750/new/ https://reviews.llvm.org/D128750 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/DeclTemplate.h

[PATCH] D135314: [clangd] Avoid scanning up to end of file on each comment!

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Assigning

[clang] b61860e - Use inheriting ctors for OSTargetInfo

Author: David Blaikie Date: 2022-10-05T20:22:19Z New Revision: b61860e63e34d955a9841389583978af93c2b97a URL: https://github.com/llvm/llvm-project/commit/b61860e63e34d955a9841389583978af93c2b97a DIFF: https://github.com/llvm/llvm-project/commit/b61860e63e34d955a9841389583978af93c2b97a.diff LOG:

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void updated this revision to Diff 465526. void added a comment. Rebase with ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 Files: clang/include/clang/AST/Expr.h clang/include/clang/Basic/LangOp

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ea78c4113f8: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135220

[clang] 5ea78c4 - [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

Author: Ben Langmuir Date: 2022-10-05T13:12:43-07:00 New Revision: 5ea78c4113f8d2c8be24152f2dd0cadaea352c9d URL: https://github.com/llvm/llvm-project/commit/5ea78c4113f8d2c8be24152f2dd0cadaea352c9d DIFF: https://github.com/llvm/llvm-project/commit/5ea78c4113f8d2c8be24152f2dd0cadaea352c9d.diff

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5301826fa86a: [clang][ExtractAPI] Don't print locations for anonymous tags (authored by zixuw). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 5301826 - [clang][ExtractAPI] Don't print locations for anonymous tags

Author: Zixu Wang Date: 2022-10-05T13:11:21-07:00 New Revision: 5301826fa86aa520b65c86abbe3b3a7194849e27 URL: https://github.com/llvm/llvm-project/commit/5301826fa86aa520b65c86abbe3b3a7194849e27 DIFF: https://github.com/llvm/llvm-project/commit/5301826fa86aa520b65c86abbe3b3a7194849e27.diff LOG

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

zixuw added a comment. In D135295#3837895 , @zixuw wrote: > In D135295#3837855 , @zixuw wrote: > >> In D135295#3837734 , @ributzka >> wrote: >> >>> This doesn't affect an

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

zixuw added a comment. With the PrintingPolicy fix in https://reviews.llvm.org/D135295 and landed USR fix, the diff within ExtractAPI tests is only the wording with anonymous enums, and we can drop the lit change: 658c658 < "spelling": "(anonymous)" --- > "spelli

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG371883f46dc2: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics (authored by akyrtzi). Repository: rG LLVM Github Monorepo

[clang] 371883f - [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

Author: Argyrios Kyrtzidis Date: 2022-10-05T12:58:01-07:00 New Revision: 371883f46dc23f8464cbf578e2d12a4f92e61917 URL: https://github.com/llvm/llvm-project/commit/371883f46dc23f8464cbf578e2d12a4f92e61917 DIFF: https://github.com/llvm/llvm-project/commit/371883f46dc23f8464cbf578e2d12a4f92e61917.

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

zixuw added a comment. I'm pulling this on top of https://reviews.llvm.org/D135295 to try locally now. Comment at: clang/include/clang/AST/Decl.h:3647 + void printName(raw_ostream &OS, const PrintingPolicy &Policy) const; + nit: missing an `override` here. (

[PATCH] D135285: [OpenMP] Make the exec_mode global have protected visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8ec170e01dd: [OpenMP] Make the exec_mode global have protected visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135285/new/

[clang] a8ec170 - [OpenMP] Make the exec_mode global have protected visibility

Author: Joseph Huber Date: 2022-10-05T14:39:22-05:00 New Revision: a8ec170e01dd0d0cbf8c059aa7addaaf3d886876 URL: https://github.com/llvm/llvm-project/commit/a8ec170e01dd0d0cbf8c059aa7addaaf3d886876 DIFF: https://github.com/llvm/llvm-project/commit/a8ec170e01dd0d0cbf8c059aa7addaaf3d886876.diff

[PATCH] D135305: [Clang] Fix using LTO with the new driver in RDC-mode

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, tra, yaxunl. Herald added a subscriber: inglorion. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The new driv

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

zixuw marked an inline comment as done. zixuw added a comment. In D135295#3837855 , @zixuw wrote: > In D135295#3837734 , @ributzka > wrote: > >> This doesn't affect any tests? > > Just finished building locally,

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

zixuw updated this revision to Diff 465505. zixuw added a comment. Update on top of the existing PrintingPolicy in the ASTContext instead of creating a new default one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135295/new/ https://reviews.llvm

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

zixuw added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:854 + // Do not include location in anonymous decls. + PrintingPolicy Policy(CI.getASTContext().getLangOpts()); + Policy.AnonymousTagLocations = false; sammccall wrote: > nit:

[PATCH] D133415: [clangd] Fix non-idempotent cases of canonicalRenameDecl()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG5f7f4846e826: [clangd] Fix non-idempotent cases of canonicalRenameDecl() (authored by sammccall). Change

[clang-tools-extra] 5f7f484 - [clangd] Fix non-idempotent cases of canonicalRenameDecl()

Author: Sam McCall Date: 2022-10-05T21:22:08+02:00 New Revision: 5f7f4846e826f97c7f298fe419c958398d5a0386 URL: https://github.com/llvm/llvm-project/commit/5f7f4846e826f97c7f298fe419c958398d5a0386 DIFF: https://github.com/llvm/llvm-project/commit/5f7f4846e826f97c7f298fe419c958398d5a0386.diff LO

[PATCH] D133415: [clangd] Fix non-idempotent cases of canonicalRenameDecl()

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:1521 R"cpp( template class Foo { virtual void [[m]](); }; class Bar : Foo { void [[^m]]() override; }; ---

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

zixuw added a comment. In D135295#3837734 , @ributzka wrote: > This doesn't affect any tests? Just finished building locally, running tests to verify now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13529

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

MaskRay updated this revision to Diff 465501. MaskRay marked an inline comment as done. MaskRay added a comment. Make error message precise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135045/new/ https://reviews.llvm.org/D135045 Files: clang/d

[PATCH] D135300: [PowerPC] Fix types for vcipher builtins.

stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added subscribers: shchenz, kbarton. Herald added a project: All. stefanp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation specifies that the par

[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ea83fc98fd1: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135231/

[clang-tools-extra] 6ea83fc - [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

Author: Sam McCall Date: 2022-10-05T20:55:53+02:00 New Revision: 6ea83fc98fd120066c3c42d88c5517ab811152bc URL: https://github.com/llvm/llvm-project/commit/6ea83fc98fd120066c3c42d88c5517ab811152bc DIFF: https://github.com/llvm/llvm-project/commit/6ea83fc98fd120066c3c42d88c5517ab811152bc.diff LO

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG from my side assuming you're happy with the strings changing. In D135295#3837734 , @ributzka wrote: > This doesn't affect any tests? This do

[PATCH] D129156: Add -fpass-plugin option to Flang

clementval added a comment. As @awarzynski mentioned, it is likely a missing dependency on the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___ cfe-com

[PATCH] D135226: [clangd] Optimize Dex::generateProximityURIs().

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:358 +// Returns^ +const char *findPathInURI(const char *S) { + // Skip over scheme. adamcz wrote: > Is there a reason why you're doing this with manual manipulation o

[PATCH] D135226: [clangd] Optimize Dex::generateProximityURIs().

sammccall updated this revision to Diff 465492. sammccall added a comment. pointers -> StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135226/new/ https://reviews.llvm.org/D135226 Files: clang-tools-extra/clangd/index/dex/Dex.cpp clang

[PATCH] D129156: Add -fpass-plugin option to Flang

MatsPetersson added a comment. In D129156#3837709 , @awarzynski wrote: > I suspect that this fails when running `ninja check-flang`, right? > > Most likely `Bye` needs to be added as a dependency for Flang tests, > something akin to this >

[clang] 4d1460c - Revert "[flang] Add -fpass-plugin option to Flang frontend"

Author: Mats Petersson Date: 2022-10-05T19:43:02+01:00 New Revision: 4d1460c77d0095fb5eb974b42d96ca4f4567a7cd URL: https://github.com/llvm/llvm-project/commit/4d1460c77d0095fb5eb974b42d96ca4f4567a7cd DIFF: https://github.com/llvm/llvm-project/commit/4d1460c77d0095fb5eb974b42d96ca4f4567a7cd.diff

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

ributzka added a comment. This doesn't affect any tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135295/new/ https://reviews.llvm.org/D135295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

zixuw updated this revision to Diff 465486. zixuw added a comment. Set PrintingPolicy properly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135295/new/ https://reviews.llvm.org/D135295 Files: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp Index:

[PATCH] D129156: Add -fpass-plugin option to Flang

awarzynski added a comment. I suspect that this fails when running `ninja check-flang`, right? Most likely `Bye` needs to be added as a dependency for Flang tests, something akin to this

[PATCH] D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH

ychen added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4313 +// 253402300799 is the UNIX timestamp of -12-31T23:59:59Z. +if (StringRef(Epoch).getAsInteger(10, V) || V > 253402300799) + Diags.Report(diag::err_fe_invalid_source_date_epoc

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

zixuw added a comment. Setting `PrintingPolicy::AnonymousTagLocations` to `false` in https://reviews.llvm.org/D135295 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134813/new/ https://reviews.llvm.org/D134813 _

[PATCH] D135295: [clang][ExtractAPI] Don't print locations for anonymous tags

zixuw created this revision. Herald added a subscriber: ributzka. Herald added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ExtractAPI doesn't care a

[PATCH] D135287: Disallow dereferencing of void* in C++.

erichkeane added a comment. In D135287#3837584 , @jrtc27 wrote: > What about `__typeof__(*p)`? Yes, that would also be an error in C++, as it is on all other compilers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135287/new/ https://reviews.

  1   2   3   >