[PATCH] D135240: [clang] adds move-constructible type-trait builtins

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `__is_move_constructible` - `__is_nothrow_move_constructible` - `__is_trivially_move_const

[PATCH] D135239: [clang] adds copy-assignable type-trait builtins

cjdb updated this revision to Diff 465286. cjdb edited the summary of this revision. cjdb added a comment. corrects commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135239/new/ https://reviews.llvm.org/D135239 Files: clang/include/cl

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb updated this revision to Diff 465285. cjdb edited the summary of this revision. cjdb added a comment. rewords commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135238/new/ https://reviews.llvm.org/D135238 Files: clang/include/cla

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle added a comment. Thank you all for the reviews. I've integrated the suggestions except for: > A possible alternative solution would be to build clangSupport_sources as an > object library, and then link that library into clangSupport and clang-tblgen > which could be done unconditional

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle updated this revision to Diff 465284. nhaehnle added a comment. Remove the confusing "accidentally" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134637/new/ https://reviews.llvm.org/D134637 Files: clang/lib/Support/CMakeLists.txt cla

[PATCH] D134637: clang-tblgen build: avoid duplicate inclusion of libLLVMSupport

nhaehnle updated this revision to Diff 465283. nhaehnle added a comment. - define an alias so that clang-tblgen can always link against "clangSupport_tablegen" - use add_llvm_library(... BUILDTREE_ONLY ...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D135239: [clang] adds copy-assignable type-trait builtins

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `__is_copy_assignable` - `__is_nothrow_copy_assignable` - `__is_trivially_copy_assignable`

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 465280. to268 added a comment. Added a check to not diagnose a missing type specifier in C2x mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/include

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:606 T __builtin_elementwise_ceil(T x) return the smallest integral value greater than or equal to xfloating point types + T __builtin_elementwise_cos(T x)return the rati

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

craig.topper added inline comments. Comment at: clang/docs/LanguageExtensions.rst:607 + T __builtin_elementwise_cos(T x)return the ratio of the adjacent side length over thefloating point types + hypoteneuse sid

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

craig.topper added a comment. In D135011#3835553 , @bob80905 wrote: > - add sve tests to prove compiler doesn't crash Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.l

[PATCH] D134699: [clang][Interp] Implement This pointer passing to methods

tbaeder updated this revision to Diff 465279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134699/new/ https://reviews.llvm.org/D134699 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/I

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb updated this revision to Diff 465278. cjdb added a comment. Restarts CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135238/new/ https://reviews.llvm.org/D135238 Files: clang/include/clang/Basic/TokenKinds.def clang/lib/Parse/ParseDeclCX

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb updated this revision to Diff 465277. cjdb edited the summary of this revision. cjdb added a comment. Updates the commit message so patch applications work Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/ https://reviews.llvm.org/D135

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb created this revision. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `__is_copy_constructible` - `__is_nothrow_copy_constructible` - `__is_trivially_copy_constructible` This is information that th

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb updated this revision to Diff 465273. cjdb added a comment. Replaces `T`/`F` with `static_assert` to match D116203 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/ https://reviews.llvm.org/D135177

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

cjdb updated this revision to Diff 465272. cjdb added a comment. Changes `T`/`F` to `static_assert` to match D116203 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135175/new/ https://reviews.llvm.org/D135175 Fil

[PATCH] D135025: [clang][Interp] Support base class constructors

tbaeder updated this revision to Diff 465271. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135025/new/ https://reviews.llvm.org/D135025 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/

[PATCH] D134546: [clang-offload-bundler] extracting compatible bundle entry

yaxunl updated this revision to Diff 465265. yaxunl marked an inline comment as done. yaxunl added a comment. check bundle entry ID compatibility when bundling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134546/new/ https://reviews.llvm.org/D134546 Files: clang/include/clang/Basic/

[PATCH] D134546: [clang-offload-bundler] extracting compatible bundle entry

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/OffloadBundler.cpp:1008 +auto Output = Worklist.begin(); +for (auto E = Worklist.end(); Output != E; Output++) { + if (isCodeObjectCompatible( tra wro

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

arsenm accepted this revision. arsenm added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1226 def int_amdgcn_raw_tbuffer_store : Intrinsic < [], Default Comment a

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

jdoerfert updated this revision to Diff 465262. jdoerfert marked 6 inline comments as done. jdoerfert added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135155/new/ https://reviews.llvm.org/D135155 Files: clang/test/

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

arsenm added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 ClangBuiltin<"__builtin_amdgcn_ds_swizzle">, - Intrinsic<[llvm_i32_ty], [llvm_i32_ty, llvm_i32_ty], -[IntrNoMem, IntrConvergent, IntrWillReturn, + DefaultAttrsIntrinsic<[llvm_

[PATCH] D135155: [AMDGPU] Annotate the intrinsics to be default and nocallback

jdoerfert updated this revision to Diff 465256. jdoerfert added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135155/new/ https://reviews.llvm.org/D13515

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

eopXD added a comment. Please disregard my previous comment, I missed the latest commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128142/new/ https://reviews.llvm.org/D128142 ___ cfe-commits mailing

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

eopXD added a comment. I see that this revision is reverted along with reversion of D128143 , I see that D128143 is re-commited. The commit message of D128143 says that it depends on this pat

[clang] b60e7a7 - [clang-format] Handle C# interpolated verbatim string prefix @$

Author: owenca Date: 2022-10-04T18:27:36-07:00 New Revision: b60e7a7f1afc45af5a6ca9fc8a531c41d0e93c85 URL: https://github.com/llvm/llvm-project/commit/b60e7a7f1afc45af5a6ca9fc8a531c41d0e93c85 DIFF: https://github.com/llvm/llvm-project/commit/b60e7a7f1afc45af5a6ca9fc8a531c41d0e93c85.diff LOG: [

[PATCH] D135026: [clang-format] Handle C# interpolated verbatim string prefix @$

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb60e7a7f1afc: [clang-format] Handle C# interpolated verbatim string prefix @$ (authored by owenpan). Changed prior to commit: https://reviews.llvm

[PATCH] D135232: [modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.

vsapsai added a comment. Here is the documentation for both flags: - https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fmodules-validate-system-headers - https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fmodules-validate-once-per-build-session

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi marked an inline comment as done. akyrtzi added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:1091 virtual void collectPropertiesToImplement(PropertyMap &PM, PropertyDeclOrder &PO) const {} --

[PATCH] D135232: [modules] Allow to validate system headers less often with `-fmodules-validate-once-per-build-session`.

vsapsai created this revision. vsapsai added reviewers: benlangmuir, MaskRay. Herald added subscribers: StephenFan, ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Make flags `-fmodules-validat

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi updated this revision to Diff 465241. akyrtzi added a comment. Herald added subscribers: steakhal, martong. Herald added a reviewer: NoQ. Remove `PropertyDeclOrder` parameter from the `collectPropertiesToImplement` functions. This is not necessary with `PropertyMap` becoming a `MapVector`

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM with a couple of small suggestions. Comment at: clang/include/clang/Basic/SourceManager.h:1062 +Optional F = sloc.getFile().getContentCache().OrigEntry;

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident added a comment. Ran the full clang/llvm/mlir test suite in debug mode just to be safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133823/new/ https://reviews.llvm.org/D133823 ___ cfe-

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe28b15b572b5: Add APFloat and MLIR type support for fp8 (e5m2). (authored by stellaraccident). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] e28b15b - Add APFloat and MLIR type support for fp8 (e5m2).

Author: Stella Laurenzo Date: 2022-10-04T17:18:17-07:00 New Revision: e28b15b572b58e5db4375da35745a4131858fc4c URL: https://github.com/llvm/llvm-project/commit/e28b15b572b58e5db4375da35745a4131858fc4c DIFF: https://github.com/llvm/llvm-project/commit/e28b15b572b58e5db4375da35745a4131858fc4c.dif

[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

sammccall added a comment. My first take on this was to keep track in various ways of whether GC was required (statically known at callsite, or have builder track whether symbols were overwritten). However these failed to identify a bunch of cases where the arena wasn't shrinking, and this seem

[PATCH] D135231: [clangd] Don't clone SymbolSlab::Builder arenas when finalizing.

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Sym

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 465236. bob80905 added a comment. - add new line to end of new files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135011/new/ https://reviews.llvm.org/D135011 Files: clang/docs/LanguageExtensions.rst cla

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 updated this revision to Diff 465235. bob80905 added a comment. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rba

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465233. stellaraccident marked an inline comment as done. stellaraccident added a comment. Remove break after llvm_unreachable for consistency with other switches in file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465231. stellaraccident added a comment. Switch to explicit case per comment from ctopper. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133823/new/ https://reviews.llvm.org/D133823 Files: clang/lib/

[PATCH] D133823: Add APFloat and MLIR type support for fp8 (e5m2).

stellaraccident updated this revision to Diff 465230. stellaraccident added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add fix to MicrosoftMangle.cpp that caused buildbot failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D135171: FreeBSD: enable __float128 on x86

brooks updated this revision to Diff 465223. brooks added a comment. Add a test as requested by @arichardson Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135171/new/ https://reviews.llvm.org/D135171 Files: clang/lib/Basic/Targets/OSTargets.h

[PATCH] D135224: [Clang][OpenMP] Only check value if the expression is not instantiation dependent

ABataev added a comment. Test is needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135224/new/ https://reviews.llvm.org/D135224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D135226: [clangd] Optimize Dex::generateProximityURIs().

sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: kadircet, arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Pro

[PATCH] D135224: [Clang][OpenMP] Only check value if the expression is not instantiation dependent

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Curre

[PATCH] D129156: Add -fpass-plugin option to Flang

tarunprabhu added a comment. Thanks for the review and the comments. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129156/new/ https://reviews.llvm.org/D129156 ___ cfe-commits mailing list cfe-commit

[PATCH] D129156: Add -fpass-plugin option to Flang

This revision was automatically updated to reflect the committed changes. Closed by commit rG43fe6f7cc35d: [flang] Add -fpass-plugin option to Flang frontend (authored by tarunprabhu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[clang] 43fe6f7 - [flang] Add -fpass-plugin option to Flang frontend

Author: Tarun Prabhu Date: 2022-10-04T17:02:45-06:00 New Revision: 43fe6f7cc35ded691bbc2fa844086d321e705d46 URL: https://github.com/llvm/llvm-project/commit/43fe6f7cc35ded691bbc2fa844086d321e705d46 DIFF: https://github.com/llvm/llvm-project/commit/43fe6f7cc35ded691bbc2fa844086d321e705d46.diff

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4151 + QualType T = Entity.getType(); + // FIXME: Union is unsupported. + int InitKind = T->isArrayType() ? 0 : 4; ayzhao wrote: > Hmm...it seems like as is this patch generates

[PATCH] D135142: Use TI.hasBuiltinAtomic() when setting ATOMIC_*_LOCK_FREE values. NFCI

rprichard accepted this revision. rprichard added a comment. This revision is now accepted and ready to land. It looks OK to me, but I wonder if you need someone else to accept it also. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135142/new/ http

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir created this revision. benlangmuir added reviewers: jansvoboda11, bnbarham. Herald added a subscriber: arphaman. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update `SourceManager::Con

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

sammccall added a comment. Started a thread: https://discourse.llvm.org/t/macro-performance-lexer-and-sourcemanager/65713 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D20401/new/ https://reviews.llvm.org/D20401 ___ cfe

[PATCH] D134859: [clang][Interp] Implement basic support for floating point values

dblaikie added inline comments. Comment at: clang/lib/AST/Interp/Floating.h:27-29 + template struct Repr; + template <> struct Repr<32> { using Type = float; }; + template <> struct Repr<64> { using Type = double; }; jcranmer-intel wrote: > aaron.ballman wrot

[PATCH] D130131: [HLSL] CodeGen hlsl cbuffer/tbuffer.

beanz added a reviewer: asl. beanz added a subscriber: asl. beanz added a comment. +@asl for codegen owner perspective. This LGTM too. The changes here are well isolated to HLSL, so they should have no adverse impact on other language support. @efriedma, @asl & @rjmccall any feedback? Reposit

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4151 + QualType T = Entity.getType(); + // FIXME: Union is unsupported. + int InitKind = T->isArrayType() ? 0 : 4; Hmm...it seems like as is this patch generates the correct code

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a comment. Relatedly, if we put this POD behavior query on TargetInfo, I wonder if it makes sense to move the tail padding predicate from TargetCXXABI to TargetInfo: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/TargetCXXABI.h#L282 The switch there is basical

[PATCH] D134456: [PGO] Consider parent context when weighing branches with likelyhood.

AntonBikineev added a comment. Anyone wants to take a look/stamp? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134456/new/ https://reviews.llvm.org/D134456 ___ cfe-commits mailing list cfe-commits@li

[clang] eed92a9 - [NFC] Fix warning wiht parens in assert from 1376c7

Author: Erich Keane Date: 2022-10-04T14:33:36-07:00 New Revision: eed92a99ddfc411b7b78847b8c0ca30f624d8c7d URL: https://github.com/llvm/llvm-project/commit/eed92a99ddfc411b7b78847b8c0ca30f624d8c7d DIFF: https://github.com/llvm/llvm-project/commit/eed92a99ddfc411b7b78847b8c0ca30f624d8c7d.diff L

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465165. craig.topper added a comment. Add requested comment to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISCV.h l

[PATCH] D135199: [OpenMP][C++] Allow #pragma omp simd in constexpr functions

jdoerfert created this revision. jdoerfert added reviewers: aaron.ballman, faisalv. Herald added subscribers: guansong, bollu, yaxunl. Herald added a project: All. jdoerfert requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. There is no reason (o

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

sammccall added a comment. In D134813#3834776 , @aaron.ballman wrote: > Thank you for this! I applied D135191 over > the top of my changes here and ran the tests to get all the new failures with > the changes, then I

[PATCH] D134330: [Docs] [HLSL] Add note about PCH support

beanz added inline comments. Comment at: clang/docs/HLSL/HLSLSupport.rst:98 +``HLSLExternalSemaSource`` will create new decls and use the old decls as +argument for setPreviousDecl. + We can probably generalize this to something like: ``` When precompiled headers

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:2029-2036 // The align if the field is not packed. This is to check if the attribute // was unnecessary (-Wpacked). CharUnits UnpackedFieldAlign = !DefaultsToAIXPowerAlignment ? Fiel

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465162. craig.topper added a comment. Use TT.isRISCV64() in AutoUpgrade.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 Files: clang/lib/Basic/Targets/RISC

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie updated this revision to Diff 465161. dblaikie added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 Files: clang/include/clang/Basic/DiagnosticASTKinds.td clang/include/cla

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. In D119051#3747673 , @rnk wrote: > In D119051#3747201 , @dblaikie > wrote: > >> So... my conclusion is that Clang's AArch64 appears to be correct for x86 >> as well, and we should just

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 465159. dblaikie added a comment. Remove Microsoft return ABI test, now that the Microsoft ABI implementation no longer depends on the AST isPOD property Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/ne

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie updated this revision to Diff 465158. dblaikie added a comment. rebase and fix an AST test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119051/new/ https://reviews.llvm.org/D119051 Files: clang/include/clang/Basic/LangOptions.h clang

[PATCH] D135192: Fix incorrect check for running out of source locations.

ppluzhnikov created this revision. Herald added a project: All. ppluzhnikov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. When CurrentLoadedOffset is less than TotalSize, current code will trigger unsigned overflow and will not return an

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

craig.topper updated this revision to Diff 465152. craig.topper marked 2 inline comments as done. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465151. ychen added a comment. - make corresponding change in the commandline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst clan

[PATCH] D134453: Introduce the `AlwaysIncludeTypeForNonTypeTemplateArgument` into printing policy

aaron.ballman added a comment. In D134453#3834659 , @dblaikie wrote: >>> OK, so it sounds like the printing behavior change (not necessarily with a >>> policy flag) necessary for diagnostics (make it non-ambiguous/not invalid >>> code which is what is c

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

yaxunl added inline comments. Comment at: clang/test/CodeGen/amdgcn-control-constants.c:8 + +// GFX90A: @__oclc_daz_opt = linkonce_odr hidden local_unnamed_addr addrspace(4) constant i8 0, align 1 +// GFX90A: @__oclc_wavefrontsize64 = linkonce_odr hidden local_unnamed_addr addr

[PATCH] D135115: [clang-format] update --files help description

probinson added a comment. The help text in ClangFormat.cpp for the `--files` option needs to be updated the same way. Note using `cl::value_desc("filename")` is what you need to change the meta-variable in the help output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

aaron.ballman added a comment. In D134813#3834710 , @sammccall wrote: > In D134813#3834613 , @sammccall > wrote: > >> Changing USR generation to not rely on this detail seems easier, I can take >> a stab at this

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

python3kgae added a comment. In D135011#3834739 , @bob80905 wrote: > Here is the code I used to test the machine code output: > > typedef float float4 __attribute__((ext_vector_type(4))); > > void test_builtin_elementwise_sin(float f1, float f2, do

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:1091 virtual void collectPropertiesToImplement(PropertyMap &PM, PropertyDeclOrder &PO) const {} benlangmuir wrote: > Can we use the exi

[PATCH] D133817: MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4769976c49be: MSVC ABI: Looks like even non-aarch64 uses the MSVC/

[clang] 4769976 - MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

Author: David Blaikie Date: 2022-10-04T20:19:17Z New Revision: 4769976c49be468d7629d513080e6959a25adcfe URL: https://github.com/llvm/llvm-project/commit/4769976c49be468d7629d513080e6959a25adcfe DIFF: https://github.com/llvm/llvm-project/commit/4769976c49be468d7629d513080e6959a25adcfe.diff LOG:

[PATCH] D135118: [clang/Sema] Fix non-deterministic order for certain kind of diagnostics

akyrtzi added a comment. In D135118#3833978 , @steven_wu wrote: > LGTM. > > `RemoveDecl` does become more expensive but I don't have better solution. Luckily AFAICT this is not a "hot" function. > I am also wondering if as follow up we should add an opt

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

nickdesaulniers added a comment. In D20401#3833201 , @hokein wrote: >>> Meanwhile, I think besides evaluating the high level logic in in TokenLexer >>> and how it might be improved, I think there's potentially an opportunity >>> for a "AOS vs. SOA" speed

[PATCH] D134617: [HLSL] Support register binding attribute on global variable

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2817-2818 + void MaybeParseHLSLSemantics(Declarator &D, + SourceLocation *EndLoc = nullptr) { +if (Tok.is(tok::colo

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. Here is the code I used to test the machine code output: typedef float float4 __attribute__((ext_vector_type(4))); void test_builtin_elementwise_sin(float f1, float f2, double d1, double d2, float4 vf1, float4 vf2) { f2 = __builtin_elementwise_sin(f1);

[clang] 2e1c1d6 - MSVC AArch64 ABI: Homogeneous aggregates

Author: David Blaikie Date: 2022-10-04T20:17:29Z New Revision: 2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130 URL: https://github.com/llvm/llvm-project/commit/2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130 DIFF: https://github.com/llvm/llvm-project/commit/2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130.diff LOG:

[PATCH] D134688: MSVC AArch64 ABI: Homogeneous aggregates

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e1c1d6d7287: MSVC AArch64 ABI: Homogeneous aggregates (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134688/new/ https://reviews.llv

[PATCH] D134942: [Lex] Simplify and cleanup the updateConsecutiveMacroArgTokens implementation.

nickdesaulniers added inline comments. Comment at: clang/lib/Lex/TokenLexer.cpp:1019 +// sourcelocation-against-bounds comparison. +FileID BeginFID = SM.getFileID(BeginLoc); +SourceLocation Limit = sammccall wrote: > this getFileID() call is unneccesa

[PATCH] D135115: [clang-format] update --files help description

ychen updated this revision to Diff 465134. ychen added a comment. - address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135115/new/ https://reviews.llvm.org/D135115 Files: clang/docs/ClangFormat.rst Index: clang/docs/ClangFormat.rs

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG77945a344c3d: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135062/new/ h

[clang-tools-extra] 77945a3 - [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

Author: Michał Górny Date: 2022-10-04T22:12:37+02:00 New Revision: 77945a344c3dee3f9735744c8d4151ef2cec6a8d URL: https://github.com/llvm/llvm-project/commit/77945a344c3dee3f9735744c8d4151ef2cec6a8d DIFF: https://github.com/llvm/llvm-project/commit/77945a344c3dee3f9735744c8d4151ef2cec6a8d.diff

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

sammccall added a comment. In D134813#3834613 , @sammccall wrote: > Changing USR generation to not rely on this detail seems easier, I can take a > stab at this. Seems trivial: https://reviews.llvm.org/D135191 If there are still diffs in USR tests after

[PATCH] D135062: [clang-tools-extra] [clangd] Respect llvm_shlib_dir in tests

mgorny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135062/new/ https://reviews.llvm.org/D135062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D135191: [Index] USRGeneration doesn't depend on unnamed.printName() => ''. NFC

sammccall created this revision. sammccall added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This prepares for printName() to print `

[PATCH] D135011: Add builtin_elementwise_sin and builtin_elementwise_cos

bob80905 added a comment. In D135011#3831452 , @craig.topper wrote: > Does these support scalable vector types from ARM SVE or RISC-V? I can't > remember what the rest of the __builtin_elementwise do. I ask because the > backends will probably crash fo

[PATCH] D133092: [clang] fix generation of .debug_aranges with LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rG165128989568: [clang] fix generation of .debug_aranges with LTO (authored by azat, committed by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1330

[clang] 1651289 - [clang] fix generation of .debug_aranges with LTO

Author: Azat Khuzhin Date: 2022-10-04T20:03:36Z New Revision: 16512898956857b13e566165ba9a195be81d325f URL: https://github.com/llvm/llvm-project/commit/16512898956857b13e566165ba9a195be81d325f DIFF: https://github.com/llvm/llvm-project/commit/16512898956857b13e566165ba9a195be81d325f.diff LOG:

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void added inline comments. Comment at: clang/include/clang/Driver/Options.td:1155 + NormalizedValuesScope<"LangOptions::StrictFlexArraysLevelKind">, + NormalizedValues<["Default", "OneZeroOrIncomplete", "ZeroOrIncomplete", "Incomplete"]>, HelpText<"Enable optimizations bas

[PATCH] D135107: [clang][NFC] Use enum for -fstrict-flex-arrays

void updated this revision to Diff 465129. void marked an inline comment as done. void added a comment. Use an already available context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135107/new/ https://reviews.llvm.org/D135107 Files: clang/inc

[PATCH] D135090: [Clang] fix -Wvoid-ptr-dereference for gnu89

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbfd06f2a8b: [Clang] fix -Wvoid-ptr-dereference for gnu89 (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135090/new/ https://

  1   2   3   >