[clang] 4954196 - [NFC] Add test of sized deallocation for coroutines

Author: Chuanqi Xu Date: 2022-09-06T14:44:16+08:00 New Revision: 495419628bbab1a99cfc00d0c44b877bfc8e4a14 URL: https://github.com/llvm/llvm-project/commit/495419628bbab1a99cfc00d0c44b877bfc8e4a14 DIFF: https://github.com/llvm/llvm-project/commit/495419628bbab1a99cfc00d0c44b877bfc8e4a14.diff LO

[PATCH] D133338: [clang][PowerPC] PPC64 VAArg use coerced integer type for direct aggregate fits in register

tingwang created this revision. tingwang added reviewers: uweigand, wschmidt, PowerPC. tingwang added a project: clang. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. tingwang requested review of this revision. Herald added a subscriber: cfe-commits. This is an

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

efriedma added a comment. In D132843#3771029 , @jrtc27 wrote: > In D132843#3770936 , @efriedma > wrote: > >>> There is also an issue with how to store and determine the final LTO target >>> features. For example

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

efriedma planned changes to this revision. efriedma added a comment. Just realized I forgot to add tests for va_arg. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2457 +/*IsVectorCall=*/false, /*IsRegCall=*/false); + } + rjmccall wrote: > ef

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka updated this revision to Diff 458098. vitalybuka added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16/new/ https://reviews.llvm.org/D16 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Tra

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka updated this revision to Diff 458097. vitalybuka added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D16/new/ https://reviews.llvm.org/D16 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Transform

[PATCH] D133336: [msan] Convert Msan to ModulePass

vitalybuka created this revision. Herald added subscribers: Enna1, ormris, jdoerfert, hiraditya. Herald added a project: All. vitalybuka requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. MemorySanitizerPass function pass vio

[PATCH] D133248: [clang] Fix crash upon stray coloncolon token in C2x mode

tbaeder added inline comments. Comment at: clang/include/clang/Parse/Parser.h:863 bool MightBeCXXScopeToken() { -return Tok.is(tok::identifier) || Tok.is(tok::coloncolon) || - (Tok.is(tok::annot_template_id) && -NextToken().is(tok::coloncolon)) || -

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

MaskRay added inline comments. Comment at: llvm/include/llvm/Support/CommandLine.h:2132 + + bool getSearchAsConfig() const { return SearchAsConfig; } + ExpansionContext &setSearchAsConfig(bool X) { Unused Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 458092. to268 added a comment. Fixed `DeclSpec.cpp` formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/Sema/D

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

MaskRay added a comment. > Normally a file included into configuration file by directive @file is > searched for relative the including configuration file. In some cases it > is not convenient. Sorry, I am puzzled by the description. A configuration file may specify `--option=file` and `@cfg`. C

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 458089. to268 added a comment. I have fixed my CodeGen test with the windows platform. (Linux uses an i64 for the long type instead windows is using an i32) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new

[clang] 7628f19 - [NFC] Remove invisible character in Diagnostic message and tests

Author: Chuanqi Xu Date: 2022-09-06T11:08:42+08:00 New Revision: 7628f19262e441b438a69176ec5229d8ccb96124 URL: https://github.com/llvm/llvm-project/commit/7628f19262e441b438a69176ec5229d8ccb96124 DIFF: https://github.com/llvm/llvm-project/commit/7628f19262e441b438a69176ec5229d8ccb96124.diff LO

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2457 +/*IsVectorCall=*/false, /*IsRegCall=*/false); + } + efriedma wrote: > rjmccall wrote: > > Hmm. Doesn't EC ABI lowering need to preserve this same state, or el

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1 -// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- -- -fno-delayed-template-parsing +// RUN: %check_clang_tidy %s readabilit

[PATCH] D133308: [cmake] do not set execution permission to regular files

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133308/new/ https://reviews.llvm.org/D133308 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D133087: [clang-format] [doc] Fix example of wrapping class definitions

Passw added a comment. In D133087#3769628 , @HazardyKnusperkeks wrote: > In D133087#3768928 , @Passw wrote: > >> I do not have commit access, please help to commit this change. >> Thanks. > > Please state a name

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 updated this revision to Diff 458073. felix642 added a comment. Improved readability of release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133244/new/ https://reviews.llvm.org/D133244 Files: clang-tools-extra/clang-tidy/readabi

[PATCH] D133244: [clang-tidy] Readability-container-data-pointer adds new option to ignore Containers

felix642 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/container-data-pointer.cpp:1 -// RUN: %check_clang_tidy %s readability-container-data-pointer %t -- -- -fno-delayed-template-parsing +// RUN: %check_clang_tidy %s readability-cont

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

daiyousei-qz added a comment. In D127082#3770763 , @sammccall wrote: > Sorry for the delay :-( This looks great! > > It looks like this is your first patch, so you don't have commit access. I > can land the patch for you. > Can you provide an email addre

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

davrec accepted this revision. davrec added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130308/new/ https://reviews.llvm.org/D130308 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

davrec accepted this revision. davrec added a comment. I hope I'm not stepping on any toes given the recent changes in code ownership, but I'm accepting this and D130308 because 1. They are a nice improvement to the AST that naturally follows from the earlier

[PATCH] D133329: [Driver] Add --gcc-install-dir=

MaskRay updated this revision to Diff 458065. MaskRay added a comment. improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133329/new/ https://reviews.llvm.org/D133329 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/incl

[PATCH] D133329: [Driver] Add --gcc-install-dir=

MaskRay created this revision. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This option specifies a GCC installation directory such as /usr/lib/gcc/x86_6

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

jrtc27 added a comment. In D132843#3770936 , @efriedma wrote: >> So we need to keep ABI in somewhere and read that at LTO phase, the most >> ideal place is the module flags. We already did that[6], but that comes with >> a problem is it's too late to up

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. In D132131#3771005 , @HazardyKnusperkeks wrote: > In D132131#3770170 , > @MyDeveloperDay wrote: > >> My personal preference is a new struct without Enabled > > We go for a new str

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. In D132131#3770170 , @MyDeveloperDay wrote: > My personal preference is a new struct without Enabled We go for a new struct. But why without enabled? Currently we have a boolean on/off switch `AlignTrailingComments`.

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sammccall added a comment. In D132867#3770898 , @sepavloff wrote: > It seems that compatibility issue can appear if someone use VFS for all files > but configuration one, which reside in real FS. It is inconvenient and hard > to maintain I agree, the s

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma added reviewers: rjmccall, mstorsjo, dpaoliello, rnk. efriedma added a comment. I think I'd like to continue moving forward with approximately this approach, at least for the moment. As far as I know, D132926 solves the remaining issues with translati

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

mstorsjo added inline comments. Comment at: libcxx/docs/Contributing.rst:119 + +Unless specified otherwise the ``main`` version of Clang is used. + Mordante wrote: > mstorsjo wrote: > > I don't understand this paragraph - each CI run is run through the > > confi

[PATCH] D133262: [clang] Represent __make_integer_seq as alias template in the AST

davrec accepted this revision. davrec added a comment. LGTM aside from a nit Comment at: clang/include/clang/AST/DeclTemplate.h:455 + bool isTypeAlias() const; + Add doc, e.g. "Whether this is a written or built-in type alias template." And nit: maybe move

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

efriedma added a comment. > So we need to keep ABI in somewhere and read that at LTO phase, the most > ideal place is the module flags. We already did that[6], but that comes with > a problem is it's too late to update datalayout when we start to read a > module, because LLVM will use datalayou

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

sbc100 added a comment. This change also broken emscripten in some odd ways: https://app.circleci.com/pipelines/github/emscripten-core/emscripten/23359/workflows/4080be5f-bd82-45b9-a355-3a5d4f4ef977/jobs/564543. The revert seems to have fixed it. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff added a comment. In D132867#3769791 , @sammccall wrote: > This seems like the right thing in principle, but it's still pretty scary: > > - this is going to break anyone who's using VFS != RealFS together with > config files, as we no longer sea

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTestComments.cpp:2930 + Style.ColumnLimit = 15; + EXPECT_EQ("int ab; // line\n" +"int a; // long\n" Why not verifyFormat here too and below? Repository: rG LLVM Gith

[PATCH] D133266: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

This revision was automatically updated to reflect the committed changes. MaskRay marked an inline comment as done. Closed by commit rG91d8324366f4: [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[clang] 91d8324 - [MinGW] Reject explicit non-default visibility applied to dllexport/dllimport declaration

Author: Fangrui Song Date: 2022-09-05T10:17:19-07:00 New Revision: 91d8324366f405e871aa8174ab61fc66912964dd URL: https://github.com/llvm/llvm-project/commit/91d8324366f405e871aa8174ab61fc66912964dd DIFF: https://github.com/llvm/llvm-project/commit/91d8324366f405e871aa8174ab61fc66912964dd.diff

[PATCH] D127695: WIP: clang: Implement Template Specialization Resugaring

davrec added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:534-540 + QualType TransformSubstTemplateTypeParmType(TypeLocBuilder &TLB, + SubstTemplateTypeParmTypeLoc TL) { +QualType QT = TL.getType(); +const Sub

[PATCH] D131858: [clang] Track the templated entity in type substitution.

davrec added a comment. This looks good, except for the confusion around the name `getReplacedDecl` - I would really like the public AST methods to be clearly named and documented, so please address that. Thanks for doing the performance tests. It may create some additional unique STTPTs, but

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sepavloff updated this revision to Diff 458035. sepavloff added a comment. Fix documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132867/new/ https://reviews.llvm.org/D132867 Files: clang/lib/Driver/Driver.cpp clang/unittests/Driver/T

[PATCH] D133325: [Driver] Allow search of included response files as configuration files

sepavloff created this revision. sepavloff added reviewers: rjmccall, aaron.ballman, kadircet, sammccall, jackoalan. Herald added a subscriber: hiraditya. Herald added a project: All. sepavloff requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald added project

[clang-tools-extra] 05737fa - [clangd] Trace preamble throttle time

Author: Sam McCall Date: 2022-09-05T18:34:41+02:00 New Revision: 05737fa209ba97b330739af3b00834c21b0547b7 URL: https://github.com/llvm/llvm-project/commit/05737fa209ba97b330739af3b00834c21b0547b7 DIFF: https://github.com/llvm/llvm-project/commit/05737fa209ba97b330739af3b00834c21b0547b7.diff LO

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

philnik accepted this revision as: philnik. philnik added a comment. Mostly LGTM. Just a few nits. Comment at: clang/www/hacking.html:276 + + Testing changes affecting libcxx + To make it consistent throughout Comment at: clang/www/hacki

[PATCH] D133249: [libc++] Documents details of the pre-commit CI.

Mordante added a comment. Thanks for the review comments. I'll address them in a little while. I want to wait for more review comments. Comment at: clang/www/hacking.html:302 + + For most builds, the pre-commit CI uses a recent + https://apt.llvm.org/";>nightly build of Clan

[PATCH] D127082: [clangd] Add Macro Expansion to Hover

sammccall added a comment. Sorry for the delay :-( This looks great! It looks like this is your first patch, so you don't have commit access. I can land the patch for you. Can you provide an email address for attribution? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin updated this revision to Diff 458019. yronglin added a project: Sanitizers. yronglin added a comment. Fix windows build bolt broken https://lab.llvm.org/buildbot/#/builders/127/builds/35304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

rymiel updated this revision to Diff 458012. rymiel added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Form

[PATCH] D132843: [RISCV] Ensure target features get passed to the LTO linker for RISC-V

kito-cheng added a subscriber: khchen. kito-cheng added a comment. This is dump from my mailbox, few month ago I written a offlist mail to describe about RISC-V LTO status: --- LTO for RISC-V is really kind of a long long story. @khchen has been fighting for that for a long time, but he is no

[PATCH] D133298: [clang-rename] RecursiveSymbolVisitor - visit namespace aliases and using directives

imctrading updated this revision to Diff 458010. imctrading added a comment. Fix formatting in `RecursiveSymbolVisitor.h` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133298/new/ https://reviews.llvm.org/D133298 Files: clang/include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h

[PATCH] D133308: [cmake] do not set execution permission to regular files

sinan created this revision. sinan added reviewers: MaskRay, phosek, DavidSpickett. Herald added subscribers: StephenFan, whisperity, mgorny. Herald added a reviewer: NoQ. Herald added a project: All. sinan requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald a

[PATCH] D131262: [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter

This revision was automatically updated to reflect the committed changes. Closed by commit rGa11e51e91f73: [analyzer] Track trivial copy/move constructors and initializer lists in the… (authored by isuckatcs). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[clang] a11e51e - [analyzer] Track trivial copy/move constructors and initializer lists in the BugReporter

Author: isuckatcs Date: 2022-09-05T17:06:27+02:00 New Revision: a11e51e91f73e413eb044bc0b2f2e205735618d7 URL: https://github.com/llvm/llvm-project/commit/a11e51e91f73e413eb044bc0b2f2e205735618d7 DIFF: https://github.com/llvm/llvm-project/commit/a11e51e91f73e413eb044bc0b2f2e205735618d7.diff LOG

[PATCH] D131066: [clangd] Add option to disable inlay hints for init lists when building array.

sammccall added a comment. We **have** been thinking about problems with inlay hints being verbose, and array initializers that are visible by default are clearly seen as spammy. Thanks for sending a patch. I filed https://github.com/clangd/clangd/issues/1277 about this just now and added some

[PATCH] D133236: [clang-format] Use utf-8 for JSON object load

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f4e6cfe73d8: [clang-format] Use utf-8 for JSON object load (authored by kaitingwang, committed by ldrumm). Repository: rG LLVM Github Monorepo C

[clang] 8f4e6cf - [clang-format] Use utf-8 for JSON object load

Author: Amy Wang Date: 2022-09-05T15:40:47+01:00 New Revision: 8f4e6cfe73d803697470e817845d9b94c4530ca3 URL: https://github.com/llvm/llvm-project/commit/8f4e6cfe73d803697470e817845d9b94c4530ca3 DIFF: https://github.com/llvm/llvm-project/commit/8f4e6cfe73d803697470e817845d9b94c4530ca3.diff LOG:

[PATCH] D133202: [Clang][CodeGen] Avoid __builtin_assume_aligned crash when the 1st arg is array type

yronglin added a comment. In D133202#3768770 , @vitalybuka wrote: > Broken by the patch https://lab.llvm.org/buildbot/#/builders/127/builds/35304 Thanks @vitalybuka , seems `intrin0.inl.h` have a forward declaration `__MACHINE(void * __cdecl __builtin_

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki added inline comments. Comment at: clang/lib/Format/Format.cpp:1196 LLVMStyle.AlignConsecutiveMacros = {}; + LLVMStyle.AlignConsecutiveTrailingComments = {}; + LLVMStyle.AlignConsecutiveTrailingComments.Enabled = true; MyDeveloperDay wrote: >

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki updated this revision to Diff 457987. yusuke-kadowaki marked 6 inline comments as done. yusuke-kadowaki added a comment. - Change to use verifyFormat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132131/new/ https://reviews.llvm.org

[PATCH] D133298: [clang-rename] RecursiveSymbolVisitor - visit namespace aliases and using directives

imctrading updated this revision to Diff 457978. imctrading added a comment. Fix formatting in the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133298/new/ https://reviews.llvm.org/D133298 Files: clang/include/clang/Tooling/Refactoring/RecursiveSymbolVisitor.h clang/test/cla

[clang-tools-extra] 1698799 - [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.

Author: Haojian Wu Date: 2022-09-05T15:55:29+02:00 New Revision: 16987998e6a0ad62efd4e387c18b0b9b5ef51947 URL: https://github.com/llvm/llvm-project/commit/16987998e6a0ad62efd4e387c18b0b9b5ef51947 DIFF: https://github.com/llvm/llvm-project/commit/16987998e6a0ad62efd4e387c18b0b9b5ef51947.diff LO

[PATCH] D133299: [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16987998e6a0: [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer. (authored by hokein). Repository: rG LLVM Github Mono

[PATCH] D133299: [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.

hokein updated this revision to Diff 457972. hokein marked an inline comment as done. hokein added a comment. address comment: create the ClangdServer when Opts is fully initialized. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133299/new/ https:/

[PATCH] D133236: [clang-format] Use utf-8 for JSON object load

kaitingwang added a comment. In D133236#3769784 , @ldrumm wrote: > Do you have commit access? @ldrumm I don't have commit access. Would you commit for me? Really appreciate it! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D133299: [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.

usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. Sorry I missed this. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:487-497 { // Switch caller's context with LSPServer's background context.

[clang-tools-extra] b06372a - [clangd] NFC, correct template argument type for two RetiredFlags.

Author: Haojian Wu Date: 2022-09-05T15:20:31+02:00 New Revision: b06372ae58f0c8ae61f0ba5cf6ad2e4a7615a2a4 URL: https://github.com/llvm/llvm-project/commit/b06372ae58f0c8ae61f0ba5cf6ad2e4a7615a2a4 DIFF: https://github.com/llvm/llvm-project/commit/b06372ae58f0c8ae61f0ba5cf6ad2e4a7615a2a4.diff LO

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:298 + /// Style of aligning consecutive trailing comments. + /// This option existed as ``AlignTrailingComments`` since version 3.7. + /// yusuke-kadowaki wrote: > MyDevelope

[PATCH] D132797: [clangd] Support renaming virtual methods

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:554 + Req.Subjects = {Base}; + Index.relations(Req, [&](const SymbolID &, const Symbol &Override) { +IDs.insert(Override.ID); sammccall wrote: > ilya-biryukov wrot

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. My personal preference is a new struct without Enabled Comment at: clang/lib/Format/Format.cpp:1196 LLVMStyle.AlignConsecutiveMacros = {}; + LLVMStyle.AlignConsecutiveTrailingComments = {}; + LLVMStyle.AlignConsecutiveTrailingComments.Enable

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

yusuke-kadowaki marked an inline comment as done. yusuke-kadowaki added a comment. Can we all agree with the decision whether we use the `AlignConsecutiveStyle` or introduce a new struct before I start implementing or updating the document? IMO, both are reasonable in some respects so I'd like yo

[PATCH] D133299: [clangd] Fix LineFoldingOnly flag is not propagated correctly to ClangdServer.

hokein created this revision. hokein added reviewers: usaxena95, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. The Opts.LineFoldingOn

[PATCH] D132797: [clangd] Support renaming virtual methods

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:548 +namespace { +void recursivelyInsertOverrides(const SymbolID &Base, +llvm::DenseSet &IDs, sammccall wrote: > The fact that we only need t

[PATCH] D132797: [clangd] Support renaming virtual methods

ilya-biryukov added a comment. Thanks for the patch! A drive-by comment from me, hopefully useful. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:554 + Req.Subjects = {Base}; + Index.relations(Req, [&](const SymbolID &, const Symbol &Override) { +IDs.insert(Over

[PATCH] D133298: [clang-rename] RecursiveSymbolVisitor - visit namespace aliases and using directives

imctrading created this revision. imctrading added reviewers: klimek, dcastagna, arphaman. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. imctrading requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `RecursiveSymbo

[PATCH] D132797: [clangd] Support renaming virtual methods

sammccall added a comment. Sorry for the delay, this patch is really neat! The only serious thing is it uncovers an existing bug which asserts. As a potential new crash I think we should fix that - LMK whether you feel comfortable adding that fix in here or you'd like me to do it as a separate

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. Generally LGTM. Please revisit the documentation and let's fix the style, and then we can land. In D91000#3197851 , @aaron.ballman wrote: > In terms of whether we should expose the check in C++: I think we shouldn't. > [...]

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 created this revision. to268 added reviewers: aaron.ballman, clang-language-wg, jyknight. Herald added a project: All. to268 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patches implements the `auto` keyword from the N3007

[PATCH] D116266: [SPIR-V] Add linking of separate translation units using spirv-link

bader added inline comments. Comment at: clang/docs/UsersManual.rst:3602 +Linking is done using ``spirv-link`` from `the SPIRV-Tools project +`_. Similar to other external Anastasia wrote: > bader wrote: > >

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:794 + +AlignConsecutiveMacros: AcrossEmptyLines + HazardyKnusperkeks wrote: > yusuke-kadowaki wrote: > > MyDeveloperDay wrote: > > > Should this say `AlignedConsecutuveCo

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

MyDeveloperDay added a comment. I feel this patch leave the documentation in a right state, I won’t be giving it an accept in this form. Please also mark the comments as done once addressed so we know you’ve read and fixed our requests Comment at: clang/docs/ClangFormatStyleO

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd3dd10a8b48: [clang-format] Concepts: allow identifiers after negation (authored by rymiel, committed by HazardyKnusperkeks). Repository: rG LLVM

[PATCH] D132762: [clang-format] Allow `throw` to be a keyword in front of casts

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc6e7752f8e14: [clang-format] Allow `throw` to be a keyword in front of casts (authored by rymiel, committed by HazardyKnusperkeks). Repository: rG

[PATCH] D132189: [clang-format] Don't put `noexcept` on empty line following constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf54d42abcf82: [clang-format] Don't put `noexcept` on empty line following constructor (authored by rymiel, committed by HazardyKnusperkeks). Reposi

[clang] bd3dd10 - [clang-format] Concepts: allow identifiers after negation

Author: Emilia Dreamer Date: 2022-09-05T12:35:40+02:00 New Revision: bd3dd10a8b489ce50823b4cc0049f16610adeee2 URL: https://github.com/llvm/llvm-project/commit/bd3dd10a8b489ce50823b4cc0049f16610adeee2 DIFF: https://github.com/llvm/llvm-project/commit/bd3dd10a8b489ce50823b4cc0049f16610adeee2.diff

[clang] c6e7752 - [clang-format] Allow `throw` to be a keyword in front of casts

Author: Emilia Dreamer Date: 2022-09-05T12:35:39+02:00 New Revision: c6e7752f8e144ad78aee2e56a7c901c56be360de URL: https://github.com/llvm/llvm-project/commit/c6e7752f8e144ad78aee2e56a7c901c56be360de DIFF: https://github.com/llvm/llvm-project/commit/c6e7752f8e144ad78aee2e56a7c901c56be360de.diff

[clang] f54d42a - [clang-format] Don't put `noexcept` on empty line following constructor

Author: Emilia Dreamer Date: 2022-09-05T12:35:39+02:00 New Revision: f54d42abcf82e122ed0ac4688f01c1f4da5599f2 URL: https://github.com/llvm/llvm-project/commit/f54d42abcf82e122ed0ac4688f01c1f4da5599f2 DIFF: https://github.com/llvm/llvm-project/commit/f54d42abcf82e122ed0ac4688f01c1f4da5599f2.diff

[PATCH] D132295: [clang-format] Change heuristic for locating lambda template arguments

HazardyKnusperkeks added a comment. Can you please rebase the patch, it doesn't apply anymore. Sorry for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132295/new/ https://reviews.llvm.org/D132295 _

[PATCH] D132867: [Clang] Use virtual FS in processing config files

sammccall added a comment. This seems like the right thing in principle, but it's still pretty scary: - this is going to break anyone who's using VFS != RealFS together with config files, as we no longer search the old locations - the breakage is likely to be quiet/subtle, especially if it's e.g

[PATCH] D133236: [clang-format] Use utf-8 for JSON object load

ldrumm added a comment. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133236/new/ https://reviews.llvm.org/D133236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D131763: [OpenMP] Add lit test for metadirective device arch inspired from sollve

saiislam accepted this revision. saiislam added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131763/new/ https://reviews.llvm.org/D131763 __

[PATCH] D133236: [clang-format] Use utf-8 for JSON object load

ldrumm accepted this revision. ldrumm added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133236/new/ https://reviews.llvm.org/D133236 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D126498: [clangd] Fix hover crashing on integral or enumeral casts

sammccall added a comment. Sorry about this! Landing now CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126498/new/ https://reviews.llvm.org/D126498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D133236: [Clang][Tools] Use utf-8 for JSON object load

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133236/new/ https://reviews.llvm.org/D133236 __

[clang] 5de4d97 - Driver tests: remove `REQUIRES: x86-registered-target` and set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`.

Author: Ying Yi Date: 2022-09-05T09:59:47+01:00 New Revision: 5de4d97a00b2a5d710892e96d77810784fd2cd5c URL: https://github.com/llvm/llvm-project/commit/5de4d97a00b2a5d710892e96d77810784fd2cd5c DIFF: https://github.com/llvm/llvm-project/commit/5de4d97a00b2a5d710892e96d77810784fd2cd5c.diff LOG:

[PATCH] D133197: [clang] Fix crash when parsing scanf format string with missing arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGab09043a1985: [clang] Fix crash when parsing scanf format string with missing arguments (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] ab09043 - [clang] Fix crash when parsing scanf format string with missing arguments

Author: serge-sans-paille Date: 2022-09-05T10:54:18+02:00 New Revision: ab09043a1985bfb9f1e4393a29a9d83326d306fe URL: https://github.com/llvm/llvm-project/commit/ab09043a1985bfb9f1e4393a29a9d83326d306fe DIFF: https://github.com/llvm/llvm-project/commit/ab09043a1985bfb9f1e4393a29a9d83326d306fe.d

[PATCH] D131978: [clang-format] Concepts: allow identifiers after negation

HazardyKnusperkeks added a comment. Please state a name and email for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131978/new/ https://reviews.llvm.org/D131978 ___ cfe-commits mailing list c

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

HazardyKnusperkeks added a comment. In D133087#3768928 , @Passw wrote: > I do not have commit access, please help to commit this change. > Thanks. Please state a name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1330

[PATCH] D126365: [git-clang-format] Stop ignoring changes for files with space in path

HazardyKnusperkeks added a comment. In D126365#3736864 , @Eitot wrote: > In D126365#3565891 , @curdeius > wrote: > >> @Eitot, do you need help landing this? > > I do need help. Could someone land this for me? Pl

[PATCH] D130181: [clang-tidy] Add readability-use-early-exits check

njames93 added a comment. In D130181#3769083 , @JonasToth wrote: > ... Your concerns aren't actually that important. Because the transformations only work on for binary operators, and not CXXOperatorCallExpr, it would always never do any special logic,

  1   2   >