[clang] 0f28d48 - SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

Author: H. Vetinari Date: 2022-08-25T08:36:01+02:00 New Revision: 0f28d4856630f8b5c6708069b4e35d7345838d6b URL: https://github.com/llvm/llvm-project/commit/0f28d4856630f8b5c6708069b4e35d7345838d6b DIFF: https://github.com/llvm/llvm-project/commit/0f28d4856630f8b5c6708069b4e35d7345838d6b.diff L

[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0f28d4856630: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION (authored by h-vetinari, committed by thiet

[PATCH] D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions

ychen planned changes to this revision. ychen added a comment. In D128750#3741043 , @ychen wrote: > I'll land this tomorrow if no objections. Thanks. Sorry. Before submitting, I found an unhandled case involving the constrained placeholder type. Will up

[clang] 70770a1 - Revert "[Clang] Implement P0848 (Conditionally Trivial Special Member Functions)"

Author: Roy Jacobson Date: 2022-08-25T09:11:06+03:00 New Revision: 70770a16bcfa70b2a4b38d55ab8097f9f92c2326 URL: https://github.com/llvm/llvm-project/commit/70770a16bcfa70b2a4b38d55ab8097f9f92c2326 DIFF: https://github.com/llvm/llvm-project/commit/70770a16bcfa70b2a4b38d55ab8097f9f92c2326.diff

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

njames93 accepted this revision. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/InfiniteLoopCheck.cpp:166 + } + if (const auto *Call = dyn_cast(StmtNode)) { +const Decl *Callee = Call->getMethodDecl();

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455477. inclyc added a comment. comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/FormatString.h

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455475. inclyc added a comment. Comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/FormatString.h

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455474. inclyc added a comment. Add tests for character literals I've noticed that Linus mentioned the following code triggered warning by clang. (With a little modifications shown below) Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g

[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

davidxl added inline comments. Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:606 +} else { + StaticFuncMap[NewName] = "---"; +} define a macro for the marker string. Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:6

[PATCH] D132617: [clang][deps] Minor ModuleDepCollector refactorings NFC

benlangmuir updated this revision to Diff 455468. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132617/new/ https://reviews.llvm.org/D132617 Files: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp Index:

[PATCH] D132616: [clang][deps] Remove CompilerInvocation from ModuleDeps

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8febb23a07b: [clang][deps] Remove CompilerInvocation from ModuleDeps (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132616/new/ h

[clang] e8febb2 - [clang][deps] Remove CompilerInvocation from ModuleDeps

Author: Ben Langmuir Date: 2022-08-24T19:51:12-07:00 New Revision: e8febb23a07bde8c02aee5545a0206e6f3851237 URL: https://github.com/llvm/llvm-project/commit/e8febb23a07bde8c02aee5545a0206e6f3851237 DIFF: https://github.com/llvm/llvm-project/commit/e8febb23a07bde8c02aee5545a0206e6f3851237.diff

[clang] bdc20d6 - [clang][tooling] Allow -cc1 arguments in ToolInvocation

Author: Ben Langmuir Date: 2022-08-24T19:51:12-07:00 New Revision: bdc20d61b8e4a62ea00e1eb05ba87eefaf820434 URL: https://github.com/llvm/llvm-project/commit/bdc20d61b8e4a62ea00e1eb05ba87eefaf820434 DIFF: https://github.com/llvm/llvm-project/commit/bdc20d61b8e4a62ea00e1eb05ba87eefaf820434.diff

[PATCH] D132615: [clang][tooling] Allow -cc1 arguments in ToolInvocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdc20d61b8e4: [clang][tooling] Allow -cc1 arguments in ToolInvocation (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D131388: [docs] Add "Standard C++ Modules"

ChuanqiXu updated this revision to Diff 455462. ChuanqiXu retitled this revision from "[docs] Add "C++20 Modules"" to "[docs] Add "Standard C++ Modules"". ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Replace `C++20 Modules` with `Standard C++ Modules` since @ruoso poi

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455459. inclyc added a comment. rm {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/FormatString.h c

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc updated this revision to Diff 455458. inclyc added a comment. Address comments & more tests & docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132568/new/ https://reviews.llvm.org/D132568 Files: clang/docs/ReleaseNotes.rst clang/inclu

[PATCH] D132236: [analyzer] Fix liveness of LazyCompoundVals

NoQ added a comment. So to be clear, I think your solution is probably an ok stop-gap solution. False negatives aren't that bad, I'm more worried that existing leak reports may become less understandable because they'll be reported later than necessary, which may obscure the reason why we think

[PATCH] D128314: [Clang-tidy] Fixing a bug in clang-tidy infinite-loop checker

NoQ accepted this revision. NoQ added a comment. Still looks good to me, let's commit! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128314/new/ https://reviews.llvm.org/D128314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D128401: [clang-tidy] Fixing a bug raising false alarms on static local variables in the Infinite Loop Checker

NoQ added a comment. I think let's commit. @ziqingluo-90 addressed all existing concerns and promises follow-up patches where he'll have a chance to address future concerns as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128401/new/ https://reviews.llvm.org/D128401 ___

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

HsiangKai added inline comments. Comment at: clang/test/Driver/mcmodel.c:9 // RUN: not %clang -c -mcmodel=lager %s 2>&1 | FileCheck --check-prefix=INVALID %s +// RUN: %clang -target aarch64 -### -c -mcmodel=medium %s 2>&1 | FileCheck --check-prefix=AARCH64-MEDIUM %s +// RUN: %

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Works for me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131009/new/ https://reviews.llvm.org/D131009 ___ cfe-commits mailing list cfe-commit

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

HsiangKai updated this revision to Diff 455454. HsiangKai added a comment. Make the test lines consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132538/new/ https://reviews.llvm.org/D132538 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D130513: [Flang] Add -fconvert option to swap endianness for unformatted files

peixin added a comment. This needs rebase. I failed to apply this patch due to conflict. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130513/new/ https://reviews.llvm.org/D130513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

inclyc added a comment. > Do we want to encode that in `test_promotion` in > `clang/test/Sema/format-strings.c`? Seems like tests on shorts are missing. Tests for short and char "incompatibility" could be found elsewhere in this file. format-strings.c void should_understand_small_integers(v

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

alexfh added a comment. In D128113#3746674 , @mizvekov wrote: > In D128113#3745888 , @alexfh wrote: > >> The main questions we need to answer here are: >> >> 1. is the cost of storing parameter pack substitution i

[PATCH] D131683: Diagnosing the Future Keywords

Codesbyusman added inline comments. Comment at: clang/test/Parser/static_assert.c:1 -// RUN: %clang_cc1 -fsyntax-only -std=c2x -DTEST_SPELLING -verify=c2x %s -// RUN: %clang_cc1 -fsyntax-only -std=c2x -DTEST_SPELLING -fms-compatibility -verify=c2x-ms %s +// RUN: %clang_cc1 -fsyn

[PATCH] D128619: [Clang] Implement P0848 (Conditionally Trivial Special Member Functions)

haowei added subscribers: haowei, phosek, mcgrathr. haowei added a comment. Hi, We are seeing build failures on Fuchsia build bots after this change was landed. and we suspect this patch causes clang to miscompile certain code. I filed bug https://github.com/llvm/llvm-project/issues/57351 and i

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan added a comment. In D132425#3743276 , @mcgrathr wrote: > lgtm. > You might add some comments in CGVTables.cpp about why this is done and what > the alternatives might be in the future. Done. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D132425: [clang] Do not instrument relative vtables under hwasan

leonardchan updated this revision to Diff 455423. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132425/new/ https://reviews.llvm.org/D132425 Files: clang/lib/CodeGen/CGVTables.cpp clang/lib/CodeGen/CGVTables.h clang/lib/CodeGen/ItaniumCXXABI.c

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

denik added inline comments. Comment at: clang/include/clang/Frontend/SARIFDiagnostic.h:24-26 + raw_ostream *OS; + + SarifDocumentWriter *Writer; cjdb wrote: > These can go in the private section below. In addition, I think it's worth putting a comment here abo

[PATCH] D132620: [WIP][llvm] Extend aarch64 and x86_64 elf targets to use gotpcrel relocations

leonardchan created this revision. Herald added subscribers: pengfei, hiraditya, kristof.beyls. Herald added a project: All. leonardchan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

rnk added a subscriber: ayzhao. rnk added a comment. In D119051#3747201 , @dblaikie wrote: > So... my conclusion is that Clang's AArch64 appears to be correct for x86 as > well, and we should just rename the function and use it unconditionally, > remov

[PATCH] D132236: [analyzer] Fix liveness of LazyCompoundVals

NoQ added a comment. Nice catch but I don't think this is the right solution. Symbol liveness corresponds to a concrete runtime property of the program: can the program obtain this value by executing further runtime instructions? The program cannot obtain a pointer to variable `n`, or even a po

[PATCH] D132617: [clang][deps] Minor ModuleDepCollector refactorings NFC

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM with a nit. Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:277 +MDC.DirectPrebuiltModularDeps.insert( +std::make_pair(To

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:224 + /// a preprocessor. Storage owned by \c ModularDeps. + llvm::StringMap ModuleDepsByID; + /// Directly imported prebuilt deps. jansvoboda11

[PATCH] D132616: [clang][deps] Remove CompilerInvocation from ModuleDeps

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132616/new/ https://reviews.llvm.org/D132616 __

[PATCH] D132615: [clang][tooling] Allow -cc1 arguments in ToolInvocation

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132615/new/ https://reviews.llvm.org/D132615 __

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir added a comment. In D132405#3747232 , @jansvoboda11 wrote: > I'd like to see this split into multiple patches. I can see some formatting > changes, removal of `CompilerInvocation` from `ModuleDeps`, isolated changes > to `Tooling`, etc. Tha

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

nickdesaulniers added a comment. In D132568#3746551 , @aaron.ballman wrote: > Thank you for the patch, but it'd be really helpful to me as a reviewer if > you and @nickdesaulniers could coordinate so there's only one patch trying to > address #57102 in

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:265 + PointerSumTypeMember, + PointerSumTypeMember>, + PointerSumTypeMember> samitolvanen wrote: > This fails on 32-bit architectures as `PointerEmbeddedInt` d

[PATCH] D132617: [clang][deps] Minor ModuleDepCollector refactorings NFC

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Factor module map and module file path functions out - Use a secondary

[PATCH] D132616: [clang][deps] Remove CompilerInvocation from ModuleDeps

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The invocation is only ever used to serialize cc1 arguments from, so ins

[PATCH] D132615: [clang][tooling] Allow -cc1 arguments in ToolInvocation

benlangmuir created this revision. benlangmuir added a reviewer: jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ToolInvocation is useful even if you already have a -cc1 invocation, sin

[PATCH] D132266: [Clang][SemaChecking] move %hh and %h -Wformat warnings to -Wformat-pedantic

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Prefer D132568 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132266/new/ https://reviews.llvm.org/D132266 ___

[PATCH] D132592: [Clang] Implement function attribute nouwtable

ychen updated this revision to Diff 455395. ychen added a comment. Herald added a subscriber: jdoerfert. - update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132592/new/ https://reviews.llvm.org/D132592 Files: clang/include/clang/Basic/At

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

abrahamcd updated this revision to Diff 455394. abrahamcd marked 4 inline comments as done. abrahamcd added a comment. Deleted copy/move from renderer and returned OS to reference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131632/new/ https://r

[clang] bbf19a6 - [AST] Use std::apply to pop front of tuples. NFCI.

Author: Benjamin Kramer Date: 2022-08-25T00:03:08+02:00 New Revision: bbf19a6745d5e2caa60d466c3c9fc8bc8eac3474 URL: https://github.com/llvm/llvm-project/commit/bbf19a6745d5e2caa60d466c3c9fc8bc8eac3474 DIFF: https://github.com/llvm/llvm-project/commit/bbf19a6745d5e2caa60d466c3c9fc8bc8eac3474.dif

[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

tra added a comment. > before or after this patch. That would be your call. I personally would be biased towards doing refactoring early. Once something is in place, the temptation not to fix what already works might win. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D132421: [HLSL] Support PCH for cc1 mode

python3kgae updated this revision to Diff 455389. python3kgae added a comment. Reuse decls already in PCH when initailize HLSLExternalSemaSource. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132421/new/ https://reviews.llvm.org/D132421 Files: c

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

rsmith accepted this revision. rsmith added a comment. LGTM Thank you! Comment at: clang/CODE_OWNERS.TXT:117 N: Richard Smith E: rich...@metafoo.co.uk +D: Emeritus owner Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

jhuber6 added a comment. In D132607#3747394 , @tra wrote: >> Should these be merged into a public interface via Object/OffloadBinary.h? > > I'm all for consolidating relevant code. Basically it would be a free function doing that `extractFromBuffer` does

[PATCH] D132550: Changes to code ownership in clang and clang-tidy

NoQ accepted this revision. NoQ added a comment. LGTM thanks a lot for handling this!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132550/new/ https://reviews.llvm.org/D132550 ___ cfe-commits mailing l

[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

tra added a comment. > Should these be merged into a public interface via Object/OffloadBinary.h? I'm all for consolidating relevant code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132607/new/ https://reviews.llvm.org/D132607

[PATCH] D132612: [HLSL] add asin library function

bob80905 created this revision. bob80905 added reviewers: beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change exposes the asin library funct

[PATCH] D132415: [LLDB] Add data formatter for std::coroutine_handle

This revision was automatically updated to reflect the committed changes. Closed by commit rG91389000abe8: [LLDB] Add data formatter for std::coroutine_handle (authored by avogelsgesang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132415/new/ htt

[clang] 9138900 - [LLDB] Add data formatter for std::coroutine_handle

Author: Adrian Vogelsgesang Date: 2022-08-24T14:40:53-07:00 New Revision: 91389000abe8ef5d06d98cbbefd3fa03ac7e4480 URL: https://github.com/llvm/llvm-project/commit/91389000abe8ef5d06d98cbbefd3fa03ac7e4480 DIFF: https://github.com/llvm/llvm-project/commit/91389000abe8ef5d06d98cbbefd3fa03ac7e4480

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG94e64df5763b: [clang][modules] Consider M affecting after mapping M.Private to M_Private (authored by jansvoboda11). Changed prior to commit: http

[clang] 94e64df - [clang][modules] Consider M affecting after mapping M.Private to M_Private

Author: Jan Svoboda Date: 2022-08-24T14:36:06-07:00 New Revision: 94e64df5763b49d750a9a87ecdd4a6583ad6154f URL: https://github.com/llvm/llvm-project/commit/94e64df5763b49d750a9a87ecdd4a6583ad6154f DIFF: https://github.com/llvm/llvm-project/commit/94e64df5763b49d750a9a87ecdd4a6583ad6154f.diff L

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:86-88 +if (Range.isInvalid()) { + continue; +} cjdb wrote: > It seems @aaron.ballman has finally trained me :( {meme, src=ohno} My work here is done. ;-) Repos

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

aaron.ballman added inline comments. Comment at: clang/include/clang/Frontend/SARIFDiagnosticPrinter.h:31 +class SARIFDiagnosticPrinter : public DiagnosticConsumer { + raw_ostream &OS; + IntrusiveRefCntPtr DiagOpts; cjdb wrote: > cjdb wrote: > > Please make OS

[PATCH] D132608: [CMake] Clean up CMake binary dir handling

Ericson2314 created this revision. Ericson2314 added reviewers: sebastian-ne, beanz, phosek, ldionne. Herald added subscribers: libc-commits, libcxx-commits, Enna1, bzcheeseman, pmatos, asb, ayermolo, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh

[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

jhuber6 created this revision. jhuber6 added reviewers: saiislam, JonChesterfield, yaxunl, ronlieb, tra, jdoerfert. Herald added a subscriber: mgorny. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: cl

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

jansvoboda11 added a comment. I left a couple of smaller initial comments. I'd like to see this split into multiple patches. I can see some formatting changes, removal of `CompilerInvocation` from `ModuleDeps`, isolated changes to `Tooling`, etc. That'd make it much easier to review. ===

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie added a comment. Each godbolt link shows MSVC 19.latest and clang, both in x86 and aarch64, with a reference pod and non-pod example at the start and end, and the variable test in the middle to see whether the codegen matches the pod or non-pod baselines above and below. > 1. checked

[PATCH] D132605: Add test cases

fedeBuonco created this revision. Herald added subscribers: carlosgalvezp, kbarton, nemanjai. Herald added a project: All. fedeBuonco requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https:/

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam added a comment. In D113107#3747095 , @rjmccall wrote: > Thanks, LGTM Thanks for all the reviews. There is still more work to be done :) I will push it tomorrow as it's the end of day for me and I am afraid there will be some fails that I woul

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113107/new/ https://reviews.llvm.org/D113107 ___ cfe-commits mailing list c

[PATCH] D132600: [llvm-profdata] Handle internal linkage functions in profile supplementation

xur created this revision. xur added reviewers: davidxl, tmsriram. Herald added a subscriber: wenlei. Herald added a project: All. xur requested review of this revision. Herald added a project: LLVM. This patch has the following changes: (1) Handling of internal linkage functions (static functions

[PATCH] D132589: [HLSL] Add acos library function

bob80905 updated this revision to Diff 455343. bob80905 added a comment. remove scalar types lld and ld from test since hlsl won't support them Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132589/new/ https://reviews.llvm.org/D132589 Files: cla

[PATCH] D131009: [analyzer] Fixing a bug raising false positives of stack block object leaking under ARC

ziqingluo-90 added a comment. In D131009#3744416 , @NoQ wrote: > Aha perfect, now the entire static analyzer knows how to work with these > regions! > > I have one tiny remark and I think we can commit. Thank you! I will make the change then directly c

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir updated this revision to Diff 455338. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132405/new/ https://reviews.llvm.org/D132405 Files: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h clang/include/clang/Tooling/DependencyScanning/DependencyScannin

[PATCH] D132597: remove scalar types lld and ld from test since hlsl won't support them

bob80905 created this revision. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D132597 Files: cl

[PATCH] D131718: [HLSL] Add abs library function

bogner accepted this revision. bogner added a comment. This revision is now accepted and ready to land. LGTM. Make sure you update the description from saying that this doesn't handle half because of https://llvm.org/pr57100 to saying that it fixes the bug instead. Repository: rG LLVM Github

[PATCH] D132503: Add cxx scope if needed for requires clause.

luken-google added a comment. Note that the following tests: Builtins-i386-linux :: muldc3_test.c SanitizerCommon-asan-i386-Linux :: Linux/crypt_r.cpp SanitizerCommon-asan-i386-Linux :: Posix/crypt.cpp SanitizerCommon-lsan-i386-Linux :: Linux/crypt_r.cpp SanitizerCommon-lsan-i386-Linux

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Frontend/CompilerInstance.cpp:2017 // migrate off of Foo.Private syntax. -if (!Sub && PP->getLangOpts().ImplicitModules && Name

[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

dblaikie marked an inline comment as done. dblaikie added a comment. In D119051#3724121 , @rnk wrote: > Regarding the usage of isPOD in the MSVC ABI code, we should have a routine > similar to `isTrivialForAArch64MSVC` that works for the other MSVC > ar

[PATCH] D131625: [HLSL] Entry functions require param annotation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf1327fea63: [HLSL] Entry functions require param annotation (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] bdf1327 - [HLSL] Entry functions require param annotation

Author: Chris Bieneman Date: 2022-08-24T14:35:11-05:00 New Revision: bdf1327fea632bf9736924acf59675182b528b23 URL: https://github.com/llvm/llvm-project/commit/bdf1327fea632bf9736924acf59675182b528b23 DIFF: https://github.com/llvm/llvm-project/commit/bdf1327fea632bf9736924acf59675182b528b23.diff

[PATCH] D119296: KCFI sanitizer

samitolvanen added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineInstr.h:265 + PointerSumTypeMember, + PointerSumTypeMember>, + PointerSumTypeMember> This fails on 32-bit architectures as `PointerEmbeddedInt` doesn't allow storing

[PATCH] D131632: [clang] Enable output of SARIF diagnostics

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Open comments notwithstanding, I'm happy with this patch. Thank you for working on this, it's a huge step towards getting more helpful diagnostics for C++! @aaron.ballman, @vaibhav.y, do you folks

[PATCH] D132592: Clang] Implement function attribute nouwtable

ychen created this revision. ychen added reviewers: aaron.ballman, rnk, rsmith. Herald added a project: All. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To have finer control of IR uwtable attribute generation. For target code ge

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie added a comment. In D118511#3732200 , @tstellar wrote: > @dblaikie Can you file a bug and add the 15.0.0 Release Milestone, so we > don't forget to fix this in the release branch. Yeah, sorry about the delay on this, last week was a lot on my s

[PATCH] D132589: [HLSL] Add acos library function This change exposes the acos library function for HLSL scalar types, excluding long long doubles. Acos is supported for all scalar, vector, and matri

bob80905 created this revision. bob80905 added reviewers: beanz, pow2clk. Herald added a subscriber: Anastasia. Herald added a project: All. bob80905 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...rt. Long long double support is missin

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir marked 11 inline comments as done. benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:44 + + enum CommandKind { +CK_CC1, tschuett wrote: > Why is this not an enum class? Removed

[PATCH] D132531: [AArch64] Reserve more physical registers

Carrot abandoned this revision. Carrot added a comment. Thanks for the clarification, I will propose another patch for my purpose. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132531/new/ https://reviews.llvm.org/D132531 _

[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

benlangmuir updated this revision to Diff 455315. benlangmuir added a comment. - Remove CompilerInvocation from Command and ModuleDeps. Only the arg strings are exposed now. - Simplify Command, which is now just a simple struct. - Move the logic for mutating the CompilerInvocation for the TU into

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added a comment. Thank you! I think all the invariants look right here; just some minor comments now, and then it should be ready to commit. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:403 + Builder.CreateStore(Val.second, ImagPtr, isVolatile); +} +

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov added a comment. In D128113#3745888 , @alexfh wrote: > The main questions we need to answer here are: > > 1. is the cost of storing parameter pack substitution indices while building > AST worth the benefits? > 2. is there an alternative solutio

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:2017 // migrate off of Foo.Private syntax. -if (!Sub && PP->getLangOpts().ImplicitModules && Name == "Private" && -Module == Module->getTopLevelModule()) { +if (!Sub && Na

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:2017 // migrate off of Foo.Private syntax. -if (!Sub && PP->getLangOpts().ImplicitModules && Name == "Private" && -Module == Module->getTopLevelModule()) { +if (!Sub && Na

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

paquette added inline comments. Comment at: clang/test/Driver/mcmodel.c:9 // RUN: not %clang -c -mcmodel=lager %s 2>&1 | FileCheck --check-prefix=INVALID %s +// RUN: %clang -target aarch64 -### -c -mcmodel=medium %s 2>&1 | FileCheck --check-prefix=AARCH64-MEDIUM %s +// RUN: %c

[PATCH] D132538: [AArch64] Filter out invalid code model in frontend.

paquette accepted this revision. paquette added a comment. This revision is now accepted and ready to land. Looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132538/new/ https://reviews.llvm.org/D132538

[PATCH] D132531: [AArch64] Reserve more physical registers

efriedma added a comment. > A reserved physical register doesn't mean it can't be used by > compiler/linker, it just means it can't be used by register allocator, see > the comments in TargetRegisterInfo::getReservedRegs(). The target feature to "reserve" a register is meant to be "don't use th

[PATCH] D132568: [clang][Sema] check default argument promotions for printf

aaron.ballman added a subscriber: nickdesaulniers. aaron.ballman added a comment. Thank you for the patch, but it'd be really helpful to me as a reviewer if you and @nickdesaulniers could coordinate so there's only one patch trying to address #57102 instead of two competing patches (I'm happy to

[PATCH] D132502: [clang][modules] Consider M affecting after mapping M.Private to M_Private

benlangmuir added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:2017 // migrate off of Foo.Private syntax. -if (!Sub && PP->getLangOpts().ImplicitModules && Name == "Private" && -Module == Module->getTopLevelModule()) { +if (!Sub && Nam

[PATCH] D132430: [clang][modules] Track affecting modules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG002bfdd6b119: [clang][modules] Track affecting modules (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D132430?vs=45

[clang] 002bfdd - [clang][modules] Track affecting modules

Author: Jan Svoboda Date: 2022-08-24T11:09:50-07:00 New Revision: 002bfdd6b119e3543415971fbb219768fd96f86f URL: https://github.com/llvm/llvm-project/commit/002bfdd6b119e3543415971fbb219768fd96f86f DIFF: https://github.com/llvm/llvm-project/commit/002bfdd6b119e3543415971fbb219768fd96f86f.diff L

[PATCH] D131683: Diagnosing the Future Keywords

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:384 +C2X_KEYWORD(true, BOOLSUPPORT) +C2X_KEYWORD(remove_quals, KEYC2X) + Codesbyusman wrote: > aaron.ballman wrote: > > This is techn

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mordante added a comment. In D126907#3740536 , @erichkeane wrote: > For example, this enable-modules flag isn't covered by my local check-cxx, > which I went out of my way to run on this patch locally. Unfortunately there are a lot of different options

  1   2   >