[PATCH] D126247: [clang-tidy][doc] Document readability-indentifier-naming resolution order and examples

whisperity added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst:2750-2752 +where an individual identifier can fall into several classifications. Below +is a list of the classifications supported by ``readability-identifier

[PATCH] D118034: [C++20] [Modules] Don't complain about duplicated default template argument across modules

ChuanqiXu added a comment. @rsmith @iains ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118034/new/ https://reviews.llvm.org/D118034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D113545: [C++20] [Module] Support reachable definition initially/partially

ChuanqiXu added a comment. @rsmith @iains gentle ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113545/new/ https://reviews.llvm.org/D113545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D126891: [clang-tidy] The check should ignore final classes

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang-tools-extra/docs/ReleaseNotes.rst:170 + ` involving + ``final`` classes. The check will not diagnose ``final`` marked classes, since +

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sgatev marked an inline comment as done. Closed by commit rG83232099cb5e: [clang][dataflow] Extend flow condition in the body of a for loop (authored by sgatev). Repos

[clang] 8323209 - [clang][dataflow] Extend flow condition in the body of a for loop

Author: Stanislav Gatev Date: 2022-06-20T05:48:45Z New Revision: 83232099cb5e7edd9a9bf1c5c8834282a58110e5 URL: https://github.com/llvm/llvm-project/commit/83232099cb5e7edd9a9bf1c5c8834282a58110e5 DIFF: https://github.com/llvm/llvm-project/commit/83232099cb5e7edd9a9bf1c5c8834282a58110e5.diff LO

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

sgatev marked an inline comment as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:92 + void VisitForStmt(const ForStmt *S) { +auto *Cond = S->getCond(); xazax.hun wrote: > Do we support `DoSt

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

sgatev updated this revision to Diff 438257. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128060/new/ https://reviews.llvm.org/D128060 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme added a comment. CI breakage is the usual libomp breakage and appears to be unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128097/new/ https://reviews.llvm.org/D128097 ___ cfe-commits m

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438238. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[clang] 05ff379 - [Basic] Use has_value (NFC)

Author: Kazu Hirata Date: 2022-06-19T18:59:56-07:00 New Revision: 05ff3790b31638bd4759c82b534417396d7c44b1 URL: https://github.com/llvm/llvm-project/commit/05ff3790b31638bd4759c82b534417396d7c44b1 DIFF: https://github.com/llvm/llvm-project/commit/05ff3790b31638bd4759c82b534417396d7c44b1.diff L

[clang] c7987d4 - [ADT] Use value instead of getValue() (NFC)

Author: Kazu Hirata Date: 2022-06-19T18:34:33-07:00 New Revision: c7987d49483685a29c3004c8710011a35cbb53e1 URL: https://github.com/llvm/llvm-project/commit/c7987d49483685a29c3004c8710011a35cbb53e1 DIFF: https://github.com/llvm/llvm-project/commit/c7987d49483685a29c3004c8710011a35cbb53e1.diff L

[clang] 813f487 - [ADT] Use has_value (NFC)

Author: Kazu Hirata Date: 2022-06-19T18:10:13-07:00 New Revision: 813f487228837fa4460c527e81e23fbc8fbf8198 URL: https://github.com/llvm/llvm-project/commit/813f487228837fa4460c527e81e23fbc8fbf8198 DIFF: https://github.com/llvm/llvm-project/commit/813f487228837fa4460c527e81e23fbc8fbf8198.diff L

[PATCH] D124790: [HLSL] Enable half type for hlsl.

python3kgae updated this revision to Diff 438220. python3kgae added a comment. Change CXXABI to Microsoft to match dxc behavior. The mangle name for half is "$f16@" when half is treat as native half type and "$halff@" when treat as float. And now in AST, half is still half. Only in clang codeGen

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

brad added a comment. In D128127#3594784 , @MaskRay wrote: > Then maybe this is not needed. Ok, I have had a diff sitting around for awhile but questioned it's usefulness since it has not been necessary to date. Repository: rG LLVM Github Monorepo

[PATCH] D128134: [Driver] Pass -X to ld for riscv64-fuchsia

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128134/new/ https://reviews.llvm.org/D128134 ___

[PATCH] D128127: [Driver][OpenBSD] Specify linker emulations

MaskRay added a comment. Then maybe this is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128127/new/ https://reviews.llvm.org/D128127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D128134: [Driver] Pass -X to ld for riscv64-fuchsia

MaskRay added a comment. Looks good if Fuchsia wants to match Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128134/new/ https://reviews.llvm.org/D128134 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang-tools-extra] 30c6758 - Use value_or instead of getValueOr (NFC)

Author: Kazu Hirata Date: 2022-06-19T10:34:41-07:00 New Revision: 30c675878c21be9973faabddc38ebf1b4c603b7d URL: https://github.com/llvm/llvm-project/commit/30c675878c21be9973faabddc38ebf1b4c603b7d DIFF: https://github.com/llvm/llvm-project/commit/30c675878c21be9973faabddc38ebf1b4c603b7d.diff L

[PATCH] D128142: [MemProf] Memprof profile matching and annotation

tejohnson created this revision. tejohnson added reviewers: snehasish, davidxl. Herald added subscribers: Enna1, wenlei, hiraditya, mgorny. Herald added a project: All. tejohnson requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Profile

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 updated this revision to Diff 438194. jackhong12 edited the summary of this revision. jackhong12 added a comment. Just like mentioned above, UnwrappedLineParser will split the input into multiple lines. And `MatchingParen` will be reset before annotating(code

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438195. benshi001 set the repository for this revision to rG LLVM Github Monorepo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChain

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

tschuett added a comment. There are now several JSON fragments per file? Perviously there was one fragment per file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128098/new/ https://reviews.llvm.org/D128098 __

[PATCH] D103874: [IR] Rename the shufflevector's undef mask to poison

aqjune added a comment. Herald added subscribers: jsji, kosarev. Herald added a project: All. It seems llvm/lib/Target/X86/X86ISelLowering.cpp's LowerAVXCONCAT_VECTORS is relevant to efficient lowering of `shufflevector %x, freeze(poison), mask`. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D128133: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438182. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128133/new/ https://reviews.llvm.org/D128133 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D127186: [Driver] Support linking to compiler-rt for target AVR

benshi001 updated this revision to Diff 438181. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127186/new/ https://reviews.llvm.org/D127186 Files: clang/lib/Driver/ToolChains/AVR.cpp clang/lib/Driver/ToolChains/AVR.h clang/test/Driver/Inputs/resource_dir_with_per_target_subdir/lib/

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

steakhal accepted this revision. steakhal added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrnoChecker.cpp:47 + /// Indicates if a read (load) of \c errno is allowed in a non-condition part + /// of \c if, \c

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM, good job. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400

[PATCH] D128134: [Driver] Pass -X to ld for riscv64-fuchsia

brad created this revision. brad added reviewers: MaskRay, phosek. brad added a project: clang. Herald added subscribers: sunshaoce, VincentWu, luke957, abrachet, StephenFan, vkmr, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, arichardso

[clang] 97c87c6 - [AST] Fix an unused variable warning

Author: Kazu Hirata Date: 2022-06-19T00:20:58-07:00 New Revision: 97c87c6f7cff16c582844e6308df03f9ab7c31b7 URL: https://github.com/llvm/llvm-project/commit/97c87c6f7cff16c582844e6308df03f9ab7c31b7 DIFF: https://github.com/llvm/llvm-project/commit/97c87c6f7cff16c582844e6308df03f9ab7c31b7.diff L

[clang-tools-extra] 5dd171d - [clang-tools-extra] Use value_or instead of getValueOr (NFC)

Author: Kazu Hirata Date: 2022-06-19T00:13:38-07:00 New Revision: 5dd171dcb55bddac652c18b33a0532a9a011a801 URL: https://github.com/llvm/llvm-project/commit/5dd171dcb55bddac652c18b33a0532a9a011a801 DIFF: https://github.com/llvm/llvm-project/commit/5dd171dcb55bddac652c18b33a0532a9a011a801.diff L