[PATCH] D128112: [NFC] clang: Implement tests for PR56099

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 438084. mizvekov added a comment. mizvekov published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. . Signed-off-by: Matheus Izvekov Repository

[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

mizvekov created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. mizvekov updated this revision to Diff 438089. mizvekov added a comment. mizvekov published this revision for review. mizvekov added reviewers: rsmith, v.g.vassilev. Herald added a project: clang.

[PATCH] D113107: Support of expression granularity for _Float16.

pengfei added inline comments. Comment at: clang/docs/ReleaseNotes.rst:491 +- Support for ``AVX512-FP16`` instructions has been added. +- Support for ``_Float16`` type has been added. This line doesn't need anymore. Comment at: clang/lib/Basi

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

MaskRay added inline comments. Comment at: clang/test/Driver/openbsd.c:133 +// RUN: | FileCheck -check-prefix=CHECK-RISCV64-FLAGS %s +// CHECK-RISCV64-FLAGS: "-X" It's useful to check other values like the `-m` emulation and the dynamic linker. Repository:

[PATCH] D128095: clang: fix checking parameter packs for expansion

mizvekov created this revision. Herald added a project: All. mizvekov updated this revision to Diff 438073. mizvekov retitled this revision from "clang: fix pack substitution scope in function params" to "clang: fix checking parameter packs for expansion.". mizvekov edited the summary of this revi

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8fc3d719eee7: Stop wrapping GCCAsmStmts inside StmtExprs to destruct temporaries (authored by ahatanak). Changed prior to commit: https://reviews.

[clang] 8fc3d71 - Stop wrapping GCCAsmStmts inside StmtExprs to destruct temporaries

Author: Akira Hatanaka Date: 2022-06-17T17:28:00-07:00 New Revision: 8fc3d719eee7ab41641506cbdc59f3ade0eb36e4 URL: https://github.com/llvm/llvm-project/commit/8fc3d719eee7ab41641506cbdc59f3ade0eb36e4 DIFF: https://github.com/llvm/llvm-project/commit/8fc3d719eee7ab41641506cbdc59f3ade0eb36e4.diff

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438075. brad added a comment. Fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Driver/openbsd.

[PATCH] D127207: [flang][driver] Fix support for `-x`

sunho added a comment. Hi! I'm not exactly sure what's going on. But, seems like build is failing here? https://lab.llvm.org/buildbot/#/builders/177/builds/5571 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127207/new/ https://reviews.llvm.org/D12

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438071. brad added a comment. Minus the new white space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Dr

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad updated this revision to Diff 438070. brad added a comment. Add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128109/new/ https://reviews.llvm.org/D128109 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/test/Driver/openbsd.c

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

aprantl added a comment. In D123319#3517966 , @dblaikie wrote: > In D123319#3506745 , @shafik wrote: > >> > > What does the linkage name do for your use case? Which cases are missing > linkage names/where do the

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad added a comment. I will add a test. Comment at: clang/lib/Driver/ToolChains/OpenBSD.cpp:159 + if (ToolChain.getArch() == llvm::Triple::riscv64) +CmdArgs.push_back("-X"); MaskRay wrote: > isRISCV > > If OpenBSD gets riscv32, it'd need -X, too. There

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Please add a test. Comment at: clang/lib/Driver/ToolChains/OpenBSD.cpp:159 + if (ToolChain.getArch() == llvm::Triple::riscv64) +CmdArgs.push_back("-X");

[PATCH] D128064: [Static Analyzer] Small array binding policy

NoQ added a comment. Another magic number around these parts is 4, which is our loop iteration budget. If an array is initialized by a loop with unknown bounds, it'll have 4 bindings. So I think it makes sense to reduce the default to 4 just because weird things may start happening above this t

[PATCH] D128109: [Driver] Pass -X to ld for riscv64-openbsd

brad created this revision. brad added a reviewer: MaskRay. brad added a project: clang. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, kito-cheng, simoncook, krytarowski, arichardson. H

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

NoQ added a comment. Matcher tests are written as unittests in `unittests/ASTMatchers`, I don't think you need to make an entire new check for that hmmm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128103/new/ https://reviews.llvm.org/D128103 _

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

MaskRay added inline comments. Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "output": "[[OUTPUT_ARM64:.*]]", "arguments": [{{.*}}, "-o", "[[OUTPUT_ARM64]]", {{.*}} "--target=arm64-apple-macosx12.0.0

[PATCH] D127142: [HIP] Link with clang_rt.builtins

MaskRay added a comment. In D127142#3592207 , @yaxunl wrote: > In D127142#3590874 , @yaxunl wrote: > >> In D127142#3571260 , @MaskRay >> wrote: >> >>> In D127142#3570290

[PATCH] D128103: Adds AST Matcher for ObjCStringLiteral

t-rasmud created this revision. t-rasmud added reviewers: NoQ, usama54321. Herald added subscribers: carlosgalvezp, mgorny. Herald added a project: All. t-rasmud requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D123319: Change how we handle auto return types for lambda operator() to be consistent with gcc

dblaikie added a comment. In D123319#3546535 , @dblaikie wrote: > In D123319#3532811 , @dblaikie > wrote: > >> Ping > > @aprantl thoughts on this? Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

tschuett added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128098/new/ https://reviews.llvm.org/D128098 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92c6ffa14cde: [clang][driver] Ensure we don't accumulate entries in -MJ files (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHA

[clang] 92c6ffa - [clang][driver] Ensure we don't accumulate entries in -MJ files

Author: Jan Svoboda Date: 2022-06-18T00:00:43+02:00 New Revision: 92c6ffa14cdeb3edd50b46d30c830698705db9f5 URL: https://github.com/llvm/llvm-project/commit/92c6ffa14cdeb3edd50b46d30c830698705db9f5 DIFF: https://github.com/llvm/llvm-project/commit/92c6ffa14cdeb3edd50b46d30c830698705db9f5.diff L

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

jansvoboda11 added a comment. Thanks for the review! Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "output": "[[OUTPUT_ARM64:.*]]", "arguments": [{{.*}}, "-o", "[[OUTPUT_ARM64]]", {{.*}} "--target=

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM. Comment at: clang/test/Driver/compilation_database_multiarch.c:15 // CHECK-NEXT: { "directory": "{{.*}}", "file": "{{.*}}", "o

[PATCH] D125683: [runtimes] Replace LIBCXX_ENABLE_STATIC_ABI_LIBRARY & friends by a new LIBCXX_CXX_ABI choice

ldionne added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:124 set(RUNTIMES_${target}_LIBCXX_ENABLE_SHARED OFF CACHE BOOL "") -set(RUNTIMES_${target}_LIBCXX_ENABLE_STATIC_ABI_LIBRARY ON CACHE BOOL "") set(RUNTIMES_${target}_LIBCXX_ABI_VERSION

[PATCH] D127991: [clang-repl] Remove memory leak of ASTContext/TargetMachine.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7bc00ce5cd41: [clang-repl] Remove memory leak of ASTContext/TargetMachine. (authored by sunho). Herald added a project: clang. Herald added a subscri

[clang] 7bc00ce - [clang-repl] Remove memory leak of ASTContext/TargetMachine.

Author: Sunho Kim Date: 2022-06-18T06:36:25+09:00 New Revision: 7bc00ce5cd41aad5fd0775f58c8e85a0a8d9ee56 URL: https://github.com/llvm/llvm-project/commit/7bc00ce5cd41aad5fd0775f58c8e85a0a8d9ee56 DIFF: https://github.com/llvm/llvm-project/commit/7bc00ce5cd41aad5fd0775f58c8e85a0a8d9ee56.diff LOG

[PATCH] D128031: Don't emit `-Wnullability-completeness` warnings on `weak` Objective-C properties.

mwyman added a comment. Created Github issue to track: https://github.com/llvm/llvm-project/issues/56096 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128031/new/ https://reviews.llvm.org/D128031 ___ cfe

[PATCH] D128098: [clang][driver] Ensure we don't accumulate entries in -MJ files

jansvoboda11 created this revision. jansvoboda11 added a reviewer: egorzhdan. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Previously, each job would overwrite the -MJ file. This didn't q

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. Fix for compile time regression submitted for review at https://reviews.llvm.org/D128097 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126061/new/ https://reviews.llvm.org/D126061 _

[PATCH] D128097: [Clang] Fix compile time regression caused by D126061.

mboehme created this revision. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As noted by @nikic, D126061 causes a compile time regression of about 0.5% on -O0 builds

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme added a comment. In D126061#3585681 , @nikic wrote: > FYI this change had a measurable effect on compile-time > (http://llvm-compile-time-tracker.com/compare.php?from=7acc88be0312c721bc082ed9934e381d297f4707&to=8c7b64b5ae2a09027c38db969a04fc9ddd0

[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

erichkeane added a comment. Made good progress today, but got trapped down the CheckDeducedArgs path for quite a bit longer with partial specializations. I have all of the crashes I know of 'fixed', but have a few tests that still fail for unknown reasons. Because of that, i don't have anythi

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. Thanks for taking care of this Roy and helping me out through the process! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org/D127593 ___ cfe

[PATCH] D128083: [C++20] Correctly handle constexpr/consteval explicitly defaulted special member instantiation behavior

rsmith added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:1315-1316 !FieldRec->hasConstexprDefaultConstructor() && !isUnion()) // The standard requires any in-class initializer to be a constant // expression. We consider this to be a d

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 438010. samitolvanen added a comment. Rebased after ToT member function name changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/D119296 Files: clang/docs/Control

[PATCH] D113107: Support of expression granularity for _Float16.

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { zahiraam wrote: > rjmccall wrote: > > `EmitPromoted` should

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

dcaballe added subscribers: jsetoain, dcaballe. dcaballe added a comment. Hey Bradley! Thanks for pinging us about this upcoming change! Something that my colleague @jsetoain mentioned is that these vector insert/extract intrinsics can also work on fixed-length only vectors. However, the documen

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

saiislam updated this revision to Diff 438004. saiislam added a comment. clang-formatted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128090/new/ https://reviews.llvm.org/D128090 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Dr

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2314-2315 +if (PrevToken->is(tok::r_brace) && Tok.isOneOf(tok::amp, tok::ampamp) && +PrevToken->MatchingParen && PrevToken->MatchingParen->is(TT_Unknown)) + return TT_Binary

[PATCH] D127270: [clang-format] Add space in placement new expression

HazardyKnusperkeks added a comment. Nice work adding the capability to the dump script. Comment at: clang/docs/ClangFormatStyleOptions.rst:4264 +and opening parentheses. +14 + This seems to be not entirely correct yet. :) Comment at:

[PATCH] D128090: [Clang][OpenMP] Process multi-arch compilation options given via -march

saiislam created this revision. saiislam added reviewers: jdoerfert, JonChesterfield, jhuber6, yaxunl. Herald added a subscriber: guansong. Herald added a project: All. saiislam requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clan

[PATCH] D125936: [Sema] Relax an assertion in BuildStmtExpr

rjmccall accepted this revision. rjmccall added a comment. Okay, LGTM then Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125936/new/ https://reviews.llvm.org/D125936 ___ cfe-commits mailing list cfe-comm

[PATCH] D128083: [C++20] Correctly handle constexpr/consteval explicitly defaulted special member instantiation behavior

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, clang-language-wg, jyknight. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. When instantiating a class template, if the primary class template speci

[clang] f9e4964 - Revert "wip"

Author: Chris Bieneman Date: 2022-06-17T13:36:53-05:00 New Revision: f9e49644f4875ba1807781b1224b3136fefe38e9 URL: https://github.com/llvm/llvm-project/commit/f9e49644f4875ba1807781b1224b3136fefe38e9 DIFF: https://github.com/llvm/llvm-project/commit/f9e49644f4875ba1807781b1224b3136fefe38e9.diff

[clang] 0dd243f - wip

Author: Chris Bieneman Date: 2022-06-17T13:34:21-05:00 New Revision: 0dd243fa8a4ec98d6cabbad16e6b485a093c6dea URL: https://github.com/llvm/llvm-project/commit/0dd243fa8a4ec98d6cabbad16e6b485a093c6dea DIFF: https://github.com/llvm/llvm-project/commit/0dd243fa8a4ec98d6cabbad16e6b485a093c6dea.diff

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 437980. omarahmed added a comment. Add Parse check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tool

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

scott.linder added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/TextDiagnostics.cpp:99-103 + size_t NewlinePos = PD->getShortDescription().find_first_of('\n'); + if (NewlinePos != std::string::npos) +OutStr = PD->getShortDescription().str().insert(

[PATCH] D127923: [Diagnostics] Accept newline and format diag opts on first line

scott.linder added a comment. Thank you for the patch! I will leave it to others with more knowledge of the history of diagnostics to comment on whether the premise is acceptable, but I have a few technical comments Comment at: clang/lib/Frontend/TextDiagnosticPrinter.cpp:119

[PATCH] D127643: [Static Analyzer] Structured bindings to data members

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe77ac66b8c1c: [Static Analyzer] Structured binding to data members (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG

[clang] e77ac66 - [Static Analyzer] Structured binding to data members

Author: isuckatcs Date: 2022-06-17T19:50:10+02:00 New Revision: e77ac66b8c1cf4f09f931d37749ed258f122d708 URL: https://github.com/llvm/llvm-project/commit/e77ac66b8c1cf4f09f931d37749ed258f122d708 DIFF: https://github.com/llvm/llvm-project/commit/e77ac66b8c1cf4f09f931d37749ed258f122d708.diff LOG

[PATCH] D128048: Add a new clang option "-ftime-trace-path"

jamieschmeiser requested changes to this revision. jamieschmeiser added a comment. This revision now requires changes to proceed. This is a good start. You should mention in the summary that when -c is not specified, the compiler is invoked with -o pointing at /tmp so the .json file will curren

[PATCH] D128013: [clang][dataflow] Add support for comma binary operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba53906ceff1: [clang][dataflow] Add support for comma binary operator (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] ba53906 - [clang][dataflow] Add support for comma binary operator

Author: Stanislav Gatev Date: 2022-06-17T17:48:21Z New Revision: ba53906ceff1e7979cac37ff6fdc27e976fc169a URL: https://github.com/llvm/llvm-project/commit/ba53906ceff1e7979cac37ff6fdc27e976fc169a DIFF: https://github.com/llvm/llvm-project/commit/ba53906ceff1e7979cac37ff6fdc27e976fc169a.diff LO

[PATCH] D127277: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

steakhal accepted this revision. steakhal added a comment. It feels like the parent revision is not correct. Land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127277/new/ https://reviews.llvm.org/D127277 __

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added a comment. As I understand, the default behavior for when the user didn't use `SBPO_Custom` is to add a space in placement operators based on this issue . And, at the same time, the default behavior should be `APO_Never` when we

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 437966. omarahmed marked an inline comment as not done. omarahmed added a comment. Refactor the tests and add new parsing logic for nested enums in dump_format_style.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D113107: Support of expression granularity for _Float16.

zahiraam marked 2 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/CodeGen/CGExprComplex.cpp:896 + +ComplexPairTy ComplexExprEmitter::EmitPromoted(const Expr *E) { + if (auto *BinOp = dyn_cast(E->IgnoreParens())) { rjmccall wrote: >

[PATCH] D128072: [clang-tidy] Organize test files into subdirectories by module (NFC)

LegalizeAdulthood created this revision. LegalizeAdulthood added reviewers: njames93, aaron.ballman. LegalizeAdulthood added a project: clang-tools-extra. Herald added subscribers: bzcheeseman, carlosgalvezp, abrachet, lebedev.ri, jdoerfert, arphaman, zzheng, kbarton, xazax.hun, nemanjai. Herald a

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2314-2315 +if (PrevToken->is(tok::r_brace) && Tok.isOneOf(tok::amp, tok::ampamp) && +PrevToken->MatchingParen && PrevToken->MatchingParen->is(TT_Unknown)) + return TT_BinaryOperator

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

ymandel abandoned this revision. ymandel added a comment. In D126973#3592537 , @xazax.hun wrote: > With properties moved up in the hierarchy this could be abandoned now, right? Yes, I think that would be best. Thanks for the reminder! Repository: rG

[PATCH] D126973: [clang][dataflow] Relax assumption that `AggregateStorageLocations` correspond to struct type.

xazax.hun added a comment. Herald added a subscriber: martong. With properties moved up in the hierarchy this could be abandoned now, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126973/new/ https://reviews.llvm.org/D126973 ___

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

jackhong12 added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2314-2315 +if (PrevToken->is(tok::r_brace) && Tok.isOneOf(tok::amp, tok::ampamp) && +PrevToken->MatchingParen && PrevToken->MatchingParen->is(TT_Unknown)) + return TT_BinaryOperator

[PATCH] D127898: [clang][dataflow] Find unsafe locs after fixpoint

xazax.hun added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:66 + SourceLocations Locs; + for (const CFGBlock *Block : Context->getCFG()) { +// Skip blocks that were not evaluated. While doing yet anot

[PATCH] D127509: Prefer `getCurrentFileOrBufferName` in `FrontendAction::EndSourceFile`

JohnTitor added a comment. I've re-triggered it several times but it shows the same failure, maybe they're valid? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127509/new/ https://reviews.llvm.org/D127509 _

[PATCH] D127313: [libc++] Implement P0618R0 (Deprecating )

philnik updated this revision to Diff 437951. philnik added a comment. - Try to fix CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127313/new/ https://reviews.llvm.org/D127313 Files: libcxx/docs/ReleaseNotes.rst libcxx/docs/Status/Cxx17Paper

[PATCH] D128064: [Static Analyzer] Small array binding policy

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92bf652d4074: [Static Analyzer] Small array binding policy (authored by isuckatcs). Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 92bf652 - [Static Analyzer] Small array binding policy

Author: isuckatcs Date: 2022-06-17T18:56:13+02:00 New Revision: 92bf652d40740b947de6c41fe09f282ec0530dc5 URL: https://github.com/llvm/llvm-project/commit/92bf652d40740b947de6c41fe09f282ec0530dc5 DIFF: https://github.com/llvm/llvm-project/commit/92bf652d40740b947de6c41fe09f282ec0530dc5.diff LOG

[PATCH] D128056: [clang][dataflow] Singleton pointer values for null pointers.

xazax.hun added a comment. I am wondering about the future plans regarding how pointers are represented. What will be the expected behavior when the analysis discovers that the pointer has a null value? E.g.: if (p == nullptr) { } Would we expect `p` in this case to have the same

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:92 + void VisitForStmt(const ForStmt *S) { +auto *Cond = S->getCond(); Do we support `DoStmt` or is that missing?

[PATCH] D127993: [Static Analyzer][CFG] Introducing the source array in the CFG of DecompositionDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc6b2281bfd7: [Static Analyzer][CFG] Introducing the source array in the CFG of… (authored by isuckatcs). Herald added a subscriber: cfe-commits. Ch

[clang] fc6b228 - [Static Analyzer][CFG] Introducing the source array in the CFG of DecompositionDecl

Author: isuckatcs Date: 2022-06-17T18:34:34+02:00 New Revision: fc6b2281bfd747b3e24d23e2ee8de189f741770f URL: https://github.com/llvm/llvm-project/commit/fc6b2281bfd747b3e24d23e2ee8de189f741770f DIFF: https://github.com/llvm/llvm-project/commit/fc6b2281bfd747b3e24d23e2ee8de189f741770f.diff LOG

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:1082 + // FIXME support cast from non-integers. + // E.g (char)(double)(double x) -> (char)(double x) + if (!RT->isIntegralOrEnumerationType()) --

[PATCH] D126194: [Concepts] Implement overload resolution for destructors (P0848)

royjacobson updated this revision to Diff 437940. royjacobson added a comment. Fix the AST test on windows and rebase on HEAD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126194/new/ https://reviews.llvm.org/D126194 Files: clang/docs/ReleaseNo

[PATCH] D126779: [analyzer] Fix assertion in simplifySymbolCast

martong updated this revision to Diff 437938. martong added a comment. - Rebase on dependent patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126779/new/ https://reviews.llvm.org/D126779 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp

[PATCH] D127873: [clang-format] Fix misplacemnt of `*` in declaration of pointer to struct

HazardyKnusperkeks added a comment. In D127873#3589465 , @jackhong12 wrote: > I think it's a good idea. When does `MatchingParen` bind? The value of > `PrevToken->MatchingParen` is still NULL in `determineStarAmpUsage` function. What has changed, now y

[PATCH] D128068: [analyzer] Do not emit redundant SymbolCasts

martong created this revision. martong added reviewers: steakhal, NoQ, ASDenysPetrov. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project:

[PATCH] D127277: [clang][analyzer] Fix StdLibraryFunctionsChecker 'mkdir' return value.

balazske updated this revision to Diff 437925. balazske added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127277/new/ https://reviews.llvm.org/D127277 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp

[PATCH] D125400: [clang][Analyzer] Add errno state to standard functions modeling.

balazske updated this revision to Diff 437924. balazske marked 2 inline comments as done. balazske added a comment. Small fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125400/new/ https://reviews.llvm.org/D125400 Files: clang/lib/StaticAn

[PATCH] D122150: [clang][analyzer] Add checker for bad use of 'errno'.

balazske updated this revision to Diff 437922. balazske marked 16 inline comments as done. balazske added a comment. Removed Errno_ prefix from ErrnoCheckState, documentation fixes, other small fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

sgatev updated this revision to Diff 437918. sgatev added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128060/new/ https://reviews.llvm.org/D128060 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

ymandel accepted this revision. ymandel added a comment. Mild preference for splitting into three tests, since it technically different code that's covered in each. But, up to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128060/new/ https://

[PATCH] D127142: [HIP] Link with clang_rt.builtins

yaxunl added a comment. In D127142#3590874 , @yaxunl wrote: > In D127142#3571260 , @MaskRay wrote: > >> In D127142#3570290 , @yaxunl wrote: >> >>> If I use --rtlib=compile

[PATCH] D128008: [clang][deps] Sort submodules when calculating dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a3a9a5fa0b2: [clang][deps] Sort submodules when calculating dependencies (authored by benlangmuir). Repository: rG LLVM Github Monorepo CHANGES

[clang] 4a3a9a5 - [clang][deps] Sort submodules when calculating dependencies

Author: Ben Langmuir Date: 2022-06-17T07:55:27-07:00 New Revision: 4a3a9a5fa0b2fd0e70672c35010fe2f00740f098 URL: https://github.com/llvm/llvm-project/commit/4a3a9a5fa0b2fd0e70672c35010fe2f00740f098 DIFF: https://github.com/llvm/llvm-project/commit/4a3a9a5fa0b2fd0e70672c35010fe2f00740f098.diff

[PATCH] D127690: [NFC] clang/Parser: remove dead code

mizvekov updated this revision to Diff 437906. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127690/new/ https://reviews.llvm.org/D127690 Files: clang/lib/Parse/Parser.cpp Index: clang/lib/Parse/Parser.cpp

[PATCH] D127351: clang: fix early substitution of alias templates

mizvekov updated this revision to Diff 437905. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127351/new/ https://reviews.llvm.org/D127351 Files: clang/include/clang/Sema/Template.h clang/lib/Sema/SemaTemplateIn

[PATCH] D127579: [clang][WIP] add option to keep types of ptr args for non-kernel functions in metadata

Anastasia added a comment. Btw do we have any issue tracking this failure, I am having a feeling that the translation of special types might be related to https://github.com/llvm/llvm-project/issues/55121? I am not aware at which point libclc is expected to be linked for SPIR-V but if linking h

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

beanz added a comment. In D128012#3592098 , @Anastasia wrote: > aha, are you having a lot of these types then? Ok that sounds similar problem > to OpenCL builtin functions as we had to go away from a simple header include > due to long parsing time. Ve

[clang] 1a02c96 - Revert "Revert "[clang] Dont print implicit forrange initializer""

Author: Kadir Cetinkaya Date: 2022-06-17T16:51:16+02:00 New Revision: 1a02c963e338100a3000734b91f5956da9b8c95e URL: https://github.com/llvm/llvm-project/commit/1a02c963e338100a3000734b91f5956da9b8c95e DIFF: https://github.com/llvm/llvm-project/commit/1a02c963e338100a3000734b91f5956da9b8c95e.dif

[PATCH] D128012: [HLSL] Add ExternalSemaSource & vector alias

Anastasia added a comment. In D128012#3591828 , @beanz wrote: > For just the type alias, adding it during parsing would probably work. Where > things get more complicated is we have a whole mess of other data types that > we’ll need to add too eventuall

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3577-3580 +ASSERT_THAT(Results, ElementsAre(Pair("if_branch_1", _), +

[PATCH] D128060: [clang][dataflow] Extend flow condition in the body of a for loop

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: martong, tschuett, rnkovacs. Herald added a project: All. sgatev requested review of this revision. Herald added a project: clang. Extend flow condition in the body of a for loop. Repo

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

cor3ntin created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Introduce an off-by default `-Winvalid-utf8` warning that detects

[PATCH] D127544: Add no_sanitize('hwaddress') (and 'memtag', but that's a no-op).

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The debian failures look like precommit CI is in a broken state again, but have nothing to do with your patch. Comment at: clang/lib/Sema/SemaDeclAttr.cp

[PATCH] D128056: [clang][dataflow] Singleton pointer values for null pointers.

wyt created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a project: All. wyt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a `nullptr` is assigned to a pointer variable, it is wrapped in a `Imp

[PATCH] D128049: [mlir] move SCF headers to SCF/{IR,Transforms} respectively

ftynse marked an inline comment as done. ftynse added inline comments. Comment at: mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h:13 -#ifndef MLIR_DIALECT_SCF_TRANSFORMS_H_ -#define MLIR_DIALECT_SCF_TRANSFORMS_H_ +#ifndef MLIR_DIALECT_SCF_TRANSFORMS_TRANSFORMS_H_ +#defin

[PATCH] D128049: [mlir] move SCF headers to SCF/{IR,Transforms} respectively

jpienaar accepted this revision. jpienaar added a comment. This revision is now accepted and ready to land. More consistency is good and update for downstream users mechanical, so LGTM Comment at: mlir/include/mlir/Dialect/SCF/Transforms/Transforms.h:13 -#ifndef MLIR_DIALECT_

  1   2   >