[PATCH] D127827: [clang-format][NFC] Fix braces in ClangFormat.cpp

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D127826: [Driver] Pass -X to ld for riscv*-{elf,freebsd,linux}

MaskRay created this revision. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217,

[PATCH] D127749: [clangd] Wire up compilation for style blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ecfeb4c2f45: [clangd] Wire up compilation for style blocks (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127749/new/ https://review

[clang-tools-extra] 3ecfeb4 - [clangd] Wire up compilation for style blocks

Author: Kadir Cetinkaya Date: 2022-06-15T08:15:32+02:00 New Revision: 3ecfeb4c2f45a2bf0634bc53e3d5ae9aa673f7a4 URL: https://github.com/llvm/llvm-project/commit/3ecfeb4c2f45a2bf0634bc53e3d5ae9aa673f7a4 DIFF: https://github.com/llvm/llvm-project/commit/3ecfeb4c2f45a2bf0634bc53e3d5ae9aa673f7a4.dif

[PATCH] D127270: [clang-format] Add space in placement new expression

curdeius added a comment. Does this patch really fix https://github.com/llvm/llvm-project/issues/54703? If so, please add test for it. Otherwise remove the link from the summary (and if possible handle it in another review). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D127589: [Driver][test] Make RISCV tests robust with PATH=

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. > unknown-linux-gnu-ld riscv64-unknown-linux-gnu-ld. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127589/new/ https://reviews.llvm.org/D1275

[PATCH] D126061: [clang] Reject non-declaration C++11 attributes on declarations

mboehme marked 2 inline comments as done. mboehme added a comment. Thank you @aaron.ballman and @rsmith for the careful and productive reviews! Comment at: clang/lib/Parse/ParseStmt.cpp:229 default: { +bool HaveAttrs = !(CXX11Attrs.empty() && GNUAttrs.empty()); +auto

[PATCH] D127685: [clang-format] Never analyze insert/remove braces in the same pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07b3446d7243: [clang-format] Never analyze insert/remove braces in the same pass (authored by owenpan). Repository: rG LLVM Github Monorepo CHANG

[clang] 07b3446 - [clang-format] Never analyze insert/remove braces in the same pass

Author: owenca Date: 2022-06-14T22:42:54-07:00 New Revision: 07b3446d72436c8372f50c43b45e46efe63182d9 URL: https://github.com/llvm/llvm-project/commit/07b3446d72436c8372f50c43b45e46efe63182d9 DIFF: https://github.com/llvm/llvm-project/commit/07b3446d72436c8372f50c43b45e46efe63182d9.diff LOG: [

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez updated this revision to Diff 437033. Javier-varez added a comment. Rebase on main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org/D127593 Files: clang-tools-extra/test/clang-tidy/checkers/moderniz

[PATCH] D127812: [AArch64] Function multiversioning support added.

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1086 +.. option:: -mno-fmv + This file is auto-generated. Don't touch it. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1173 return None; - case ARM::BI_B

[PATCH] D125402: [clang][diag] warn if function returns class type by-const-value

nlee updated this revision to Diff 437011. nlee added a comment. Warn if: - It is an assignment expression AND - RHS is a function call expression AND - The function returns by-const-value of a class or struct type AND - The class or struct has non-trivial move assignment operator Removed `defau

[clang] 753b915 - [Driver] Improve linking options for target AVR

Author: Ben Shi Date: 2022-06-15T02:57:31Z New Revision: 753b915167bd40375e879866c66be14b7b6a8db8 URL: https://github.com/llvm/llvm-project/commit/753b915167bd40375e879866c66be14b7b6a8db8 DIFF: https://github.com/llvm/llvm-project/commit/753b915167bd40375e879866c66be14b7b6a8db8.diff LOG: [Driv

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. I tested this patch on our windows builder and it passed as well. This patch LGTM. (I cannot click accept as the this review is already closed) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 __

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583924 , @haowei wrote: > In D126192#3583915 , @benshi001 > wrote: > >> It seems the file >> `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. In D126192#3583915 , @benshi001 wrote: > It seems the file > `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` > is missing on your machine, which I have newly created in current patch. That

[PATCH] D127771: [HIP] fix long double size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf9ee3357cec: [HIP] fix long double size (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D1

[clang] af9ee33 - [HIP] fix long double size

Author: Yaxun (Sam) Liu Date: 2022-06-14T21:57:56-04:00 New Revision: af9ee3357cec931af68a3a0bb83e82de977caa37 URL: https://github.com/llvm/llvm-project/commit/af9ee3357cec931af68a3a0bb83e82de977caa37 DIFF: https://github.com/llvm/llvm-project/commit/af9ee3357cec931af68a3a0bb83e82de977caa37.dif

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. It seems the file `/mnt/nvme_sec/SRC/llvm-project/clang/test/Driver/Inputs/basic_avr_tree/usr/bin/ld.lld` is missing on your machine, which I have newly created in current patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583886 , @haowei wrote: > Emmm, I applied your latest patch on top of > main(6e02e27536b9de25a651cfc9c2966ce471169355 > ) but I > still get a te

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

mdfazlay added inline comments. Comment at: clang/include/clang-c/Index.h:2641 */ - CXCursor_TranslationUnit = 300, + CXCursor_TranslationUnit = 350, ABataev wrote: > Does this change affect anything else in the compiler? We had to add and keep the CXCurs

[PATCH] D127454: [OpenMP] Initial parsing and sema for 'parallel masked' construct

mdfazlay updated this revision to Diff 436994. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127454/new/ https://reviews.llvm.org/D127454 Files: clang/bindings/python/clang/cindex.py clang/include/clang-c/Index.h clang/include/clang/AST/Recurs

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. Emmm, I applied your latest patch on top of main(6e02e27536b9de25a651cfc9c2966ce471169355 ) but I still get a test failure on `Clang :: Driver/avr-toolchain.c`. `Clang :: Driver/avr-ld.c` no longer fai

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

benshi001 added a comment. In D127814#3583854 , @haowei wrote: > I tested this patch on top of > https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 > (reverted in > https://github.com/llvm/llvm-project/commit/7fae15f92

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

haowei added a comment. I tested this patch on top of https://github.com/llvm/llvm-project/commit/3b6e166999bb83197c8b70468c2d371c58cf0c25 (reverted in https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad) and Clang driver tests now pass without issue. Reposit

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. In D126192#3583795 , @haowei wrote: > I already reverted the change in > https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad > . It is likely the breakage is caused by the fact that Fuchsia's C

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 updated this revision to Diff 436992. benshi001 added a reviewer: haowei. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/AVR.cpp clang/test/Dr

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. I think I have fixed in another patch https://reviews.llvm.org/D127814, could you please have a look? @haowei I have not your environment, my patch works on my ubuntu system, could you please try it on your build machine ? Repository: rG LLVM Github Monorepo CHA

[PATCH] D127814: [Driver] Force avr-ld to be default linker for target AVR

benshi001 created this revision. benshi001 added reviewers: haowei, MaskRay. Herald added subscribers: StephenFan, Jim, dylanmckay. Herald added a project: All. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, jacquesguan. Herald added a project: clang. Repositor

[PATCH] D126192: [Driver] Improve linking options for target AVR

haowei added a comment. I already reverted the change in https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad . It is likely the breakage is caused by the fact that Fuchsia's Clang by default use `lld`, see `clang/cmake/caches/Fuchsia-stage2.cmake:set(CLANG_DEFA

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

Bigcheese added a comment. In D127182#3582540 , @jansvoboda11 wrote: > Should we add a FIXME saying we need to handle other kinds of attributes? There already is one where we call `mergeInheritableAttributes`. Repository: rG LLVM Github Monorepo CH

[clang] 7fae15f - Revert "[Driver] Improve linking options for target AVR"

Author: Haowei Wu Date: 2022-06-14T17:53:46-07:00 New Revision: 7fae15f9251d3b392058e2fc84898b53619d36ad URL: https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad DIFF: https://github.com/llvm/llvm-project/commit/7fae15f9251d3b392058e2fc84898b53619d36ad.diff LOG

[PATCH] D126192: [Driver] Improve linking options for target AVR

benshi001 added a comment. I will fix it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126192/new/ https://reviews.llvm.org/D126192 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong updated this revision to Diff 436985. steplong added a comment. - Change logic for /Zc:alignedNew and /Zc:sizedDealloc - Add tests for different /std:c++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D1

[PATCH] D127807: [clang-tidy] Properly forward clang-tidy output when running tests

nicovank created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. nicovank retitled this revision from "[clang-tidy] Remove encode when outputting tool ouput running tests" to "[clang-tidy] Properly forward clang-tidy output when running tests". nicovank updated t

[PATCH] D127163: [clang] Add -fsanitize=memtag-globals (no-op).

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127163/new/ https://reviews.llvm.org/D127163 _

[PATCH] D127745: [clang][dataflow] Rename `getPointeeLoc` to `getReferentLoc` for ReferenceValue.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97d69cdaf324: [clang][dataflow] Rename `getPointeeLoc` to `getReferentLoc` for ReferenceValue. (authored by wyt, committed by gribozavr). Repository

[clang] 97d69cd - [clang][dataflow] Rename `getPointeeLoc` to `getReferentLoc` for ReferenceValue.

Author: Wei Yi Tee Date: 2022-06-15T00:53:30+02:00 New Revision: 97d69cdaf324ec520b3f7685ef05f8e207a7bd3b URL: https://github.com/llvm/llvm-project/commit/97d69cdaf324ec520b3f7685ef05f8e207a7bd3b DIFF: https://github.com/llvm/llvm-project/commit/97d69cdaf324ec520b3f7685ef05f8e207a7bd3b.diff LO

[PATCH] D126984: [clang] Add support for optimize function attribute

jdoerfert added a comment. FWIW, I think we should have these attributes as spelled here, just w/ proper pass manager integration which then requires an RFC. That said, I'm not opposed to this as an incremental step, albeit confusing until the PM support is integrated if we allow O1

[PATCH] D127803: Generate the capture for field when the field is used with implicit default.

jyu2 created this revision. jyu2 added reviewers: ABataev, jdoerfert, mikerice. jyu2 added projects: OpenMP, clang. Herald added a project: All. jyu2 requested review of this revision. Herald added a subscriber: sstefan1. This is to fix assert when field is referenced and default clause is used. T

[PATCH] D127802: [HLSL] Support HLSL vector initializers

python3kgae added inline comments. Comment at: clang/test/SemaHLSL/BuiltIns/vector-constructors-erros.hlsl:8 +void entry() { + float2 LilVec = float2(1.0, 2.0); + float2 BrokenVec = float2(1.0, 2.0, 3.0); // expected-error{{excess elements in vector initializer}} -

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

steakhal added a comment. Conflict markers fixed by 6ccc2733e72017999a94c10147a71ff595286080 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125340/new/ https://reviews.llvm.org/

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

steplong updated this revision to Diff 436954. steplong edited the summary of this revision. steplong added a comment. - Change logic to only handle empty optimization list - Fixup doc and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/n

[PATCH] D127802: [HLSL] Support HLSL vector initializers

beanz created this revision. beanz added reviewers: aaron.ballman, kuhar, python3kgae, MaskRay. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. In HLSL vectors are ext_vectors in all respects exce

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

efriedma added a comment. Maybe we should document that zero-size arrays aren't treated as flexible arrays, since that's what the zero-size array extension was originally designed for. Looks fine otherwise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llv

[PATCH] D127799: [StaticAnalyzer] Remove dead code (DO NOT COMMIT)

kazu created this revision. Herald added subscribers: abrachet, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, zzheng, szepet, baloghadamsoftware. Herald added a project: All. kazu requested review of this revision. Herald added a project: clang. Herald added a subscriber

[clang] 657e954 - [clang] Add tests for statement expression in initializers

Author: Anders Waldenborg Date: 2022-06-14T23:16:41+02:00 New Revision: 657e954939c8a7d33c40291ef3214333a1e2ca5b URL: https://github.com/llvm/llvm-project/commit/657e954939c8a7d33c40291ef3214333a1e2ca5b DIFF: https://github.com/llvm/llvm-project/commit/657e954939c8a7d33c40291ef3214333a1e2ca5b.d

[PATCH] D127201: [clang] Add tests for statement expression in initializers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG657e954939c8: [clang] Add tests for statement expression in initializers (authored by wanders). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl updated this revision to Diff 436940. mingmingl added a comment. update commit message with differential revision link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127798/new/ https://reviews.llvm.org/D127798 Files: clang/lib/Basic/T

[PATCH] D127798: [AArch64] Define __ARM_FEATURE_RCPC

mingmingl created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. mingmingl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements the definition of __ARM_FEATURE_RCPC when clang commands

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:9265-9266 + ? Context.getBitIntType(!IsMakeSigned, Context.getIntWidth(BaseType)) + : Context.getIntTypeForBitwidth(Context.getIntWidth(BaseType), + Is

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

rsmith added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5863 // FIXME: derive from "Target" ? - return WCharTy; + return IntTy; } This change seems surprising. Can you explain what's going on here? Comment at: clang/lib/AST

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

royjacobson accepted this revision. royjacobson added a comment. This revision is now accepted and ready to land. Thank you! LGTM. I see the CI still has those OpenMP failures - could you try to rebase on main to get it green? @erichkeane is this good to go? Should I ping some ABI people about t

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

mehdi_amini added inline comments. Comment at: mlir/include/mlir/Transforms/CommutativityUtils.h:211 +template +class SortCommutativeOperands : public OpRewritePattern { + using OpRewritePattern::OpRewritePattern; Can we make this not a template? This will be a

[PATCH] D127707: [Clang] Simplify unifying target features

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4a2674e21c4: [Clang] Simplify unifying target features (authored by jhuber6). Changed prior to commit: https://reviews.llvm.org/D127707?vs=436621

[clang] c4a2674 - [Clang] Simplify unifying target features

Author: Joseph Huber Date: 2022-06-14T15:58:16-04:00 New Revision: c4a2674e21c4f5ffd46f90982ce3c3d952018e66 URL: https://github.com/llvm/llvm-project/commit/c4a2674e21c4f5ffd46f90982ce3c3d952018e66 DIFF: https://github.com/llvm/llvm-project/commit/c4a2674e21c4f5ffd46f90982ce3c3d952018e66.diff

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion"

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae marked an inline comment as done. python3kgae added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:14 +// CHECK-NOT: "dx.shader"="compute" +// CHECK-SAM: } +[numthreads(1, 1, 1)] void main() { bogner wrote: > typo, should be `C

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

rnk added a subscriber: luken-google. rnk added a comment. +@luken-google Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6497 + options::OPT_fno_aligned_allocation) && +LanguageStandard == "-std=c++17") + CmdArgs.push_back("-faligned-allo

[PATCH] D124753: [HLSL] Set main as default entry.

python3kgae updated this revision to Diff 436898. python3kgae added a comment. Fix typo in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124753/new/ https://reviews.llvm.org/D124753 Files: clang/include/clang/Driver/Options.td clang/test

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">,

[PATCH] D124753: [HLSL] Set main as default entry.

bogner added inline comments. Comment at: clang/test/CodeGenHLSL/entry_default.hlsl:14 +// CHECK-NOT: "dx.shader"="compute" +// CHECK-SAM: } +[numthreads(1, 1, 1)] void main() { typo, should be `CHECK-SAME` Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">,

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

Codesbyusman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">

[clang] 6ccc273 - Update ASTImportError.h

Author: Shivam Date: 2022-06-15T00:45:07+05:30 New Revision: 6ccc2733e72017999a94c10147a71ff595286080 URL: https://github.com/llvm/llvm-project/commit/6ccc2733e72017999a94c10147a71ff595286080 DIFF: https://github.com/llvm/llvm-project/commit/6ccc2733e72017999a94c10147a71ff595286080.diff LOG: U

[clang] caf2767 - [Clang][AST] Fixed BindingDecl AST-dump for tuple like structures

Author: isuckatcs Date: 2022-06-14T21:13:04+02:00 New Revision: caf2767c47c3808538c82b6ea2b24d8e95b11ee7 URL: https://github.com/llvm/llvm-project/commit/caf2767c47c3808538c82b6ea2b24d8e95b11ee7 DIFF: https://github.com/llvm/llvm-project/commit/caf2767c47c3808538c82b6ea2b24d8e95b11ee7.diff LOG

[PATCH] D126131: [Clang][AST] BindingDecl ASTDump for tuple like structure

This revision was automatically updated to reflect the committed changes. Closed by commit rGcaf2767c47c3: [Clang][AST] Fixed BindingDecl AST-dump for tuple like structures (authored by isuckatcs). Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D127762: [Clang][AArch64] Add ACLE attributes for SME.

aaron.ballman added a comment. > This patch adds all the language-level function attributes defined in: > > https://github.com/ARM-software/acle/pull/188 This pull request has not yet been merged, so what are the chances that it gets rejected or altered? > LLVM support for these attributes will

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d637956b792: [clang][NFC][AST] rename the ImportError to ASTImportError (authored by phyBrackets). Changed prior to commit: https://reviews.llvm.org/D125340?vs=428508&id=436881#toc Repository: rG LL

[clang] 9d63795 - [clang][NFC][AST] rename the ImportError to ASTImportError

Author: phyBrackets Date: 2022-06-15T00:40:32+05:30 New Revision: 9d637956b79282aa0980e859b9128cf09a83dda6 URL: https://github.com/llvm/llvm-project/commit/9d637956b79282aa0980e859b9128cf09a83dda6 DIFF: https://github.com/llvm/llvm-project/commit/9d637956b79282aa0980e859b9128cf09a83dda6.diff L

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez marked an inline comment as done. GuillaumeGomez added a comment. Fixed @spatel's comment. Comment at: llvm/include/llvm/IR/Intrinsics.td:387 -/// GCCBuiltin - If this intrinsic exactly corresponds to a GCC builtin, this +/// ClangBuiltin - If this intrinsic ex

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

GuillaumeGomez updated this revision to Diff 436876. GuillaumeGomez added a comment. - Update #define name as well - Rename `IsGCC` function parameter into `IsClang` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org

[PATCH] D127528: [Clang] Let the linker choose shared or static libunwind unless specified

srhines added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1477 if (Args.hasArg(options::OPT_shared_libgcc)) return LibGccType::SharedLibGcc; - // The Android NDK only provides libunwind.a, not libunwind.so. phosek wrote: > mst

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

spatel added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:387 -/// GCCBuiltin - If this intrinsic exactly corresponds to a GCC builtin, this +/// ClangBuiltin - If this intrinsic exactly corresponds to a GCC builtin, this /// specifies the name of the builti

[PATCH] D117977: [cmake] Don't export `LLVM_TOOLS_INSTALL_DIR` anymore

Ericson2314 updated this revision to Diff 436874. Ericson2314 added a comment. Rebase again, to try to figure out if last round of errors were spurious Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117977/new/ https://reviews.llvm.org/D117977 File

[PATCH] D127771: [HIP] fix long double size

yaxunl added a comment. In D127771#3582640 , @tra wrote: > AFAICT, the test case you've added works fine with the compiler at HEAD: > https://cuda.godbolt.org/z/q3xYMfdeb > I guess it only shows up in assertion-enabled builds. Can you check what > happe

[PATCH] D126984: [clang] Add support for optimize function attribute

xbolva00 added a comment. Also note that there is a '#pragma GCC optimize' pragma. After this patch, it should be hard to implement it. https://gcc.gnu.org/onlinedocs/gcc/Function-Specific-Option-Pragmas.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez added a comment. Thanks again for having another look at the changes! I do not have commit access since this is my first change to LLVM. I would appreciate if you could merge it. here's my username and email: Javier Alvarez And let me know if there's anything else you'd like to mo

[PATCH] D127593: [clang] Fix trivially copyable for copy constructor and copy assignment operator

Javier-varez updated this revision to Diff 436871. Javier-varez marked 2 inline comments as done. Javier-varez added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127593/new/ https://reviews.llvm.org/D127593 File

[PATCH] D127771: [HIP] fix long double size

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. AFAICT, the test case you've added works fine with the compiler at HEAD: https://cuda.godbolt.org/z/q3xYMfdeb I guess it only shows up in assertion-enabled builds. Can you check what happens if you

[PATCH] D127528: [Clang] Let the linker choose shared or static libunwind unless specified

phosek added a subscriber: srhines. phosek added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1477 if (Args.hasArg(options::OPT_shared_libgcc)) return LibGccType::SharedLibGcc; - // The Android NDK only provides libunwind.a, not libunwind.so. -

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

steplong added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6641 // by default. if (Arg *A = Args.getLastArg(options::OPT_faligned_allocation, options::OPT_fno_aligned_allocation, There's a check here fo

[PATCH] D127641: [clang-cl][MSVC] Add default /Zc conformance arguments

steplong updated this revision to Diff 436860. steplong added a comment. Herald added a subscriber: MaskRay. - Only enable /Zc:alignedNew and /Zc:sizedDealloc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D12764

[PATCH] D126984: [clang] Add support for optimize function attribute

steplong added a comment. > I appreciate your patience while we figure out the right approach here; we > don't usually have this many false starts when working through a feature > review. :-) No worries, I appreciate the community doing the due diligence. Repository: rG LLVM Github Monorepo

[PATCH] D127771: [HIP] fix long double size

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: kosarev, kerbowa, tpr, jvesely. Herald added a project: All. yaxunl requested review of this revision. For amdgpu target long double type is the same as double type. The width and align of long double type was in

[PATCH] D126308: cmake: use llvm dir variables for clang/utils/hmaptool

dyung added a comment. In D126308#3582337 , @mizvekov wrote: > In D126308#3581240 , @dyung wrote: > >> Can you take a look? > > Hi @dyung , thanks for the report and sorry for the trouble! > Can you help me try to

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

jansvoboda11 added a comment. Should we add a FIXME saying we need to handle other kinds of attributes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127182/new/ https://reviews.llvm.org/D127182 ___ cfe-

[PATCH] D127182: [Clang][Modules] Merge availability attributes on imported decls

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127182/new/ https://reviews.llvm.org/D127182 ___ c

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion"

[PATCH] D126984: [clang] Add support for optimize function attribute

aaron.ballman added a comment. In D126984#3582508 , @steplong wrote: > I'm open to tabling this and just implementing support for an empty > optimization list for the pragma (i.e. `#pragma optimize("", on | off)`). For > our use case, at the moment, we

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

erichkeane added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function : Warning< - "all paths through this function will call itself">, + "In order to understand recursion, you must first understand recursion">,

[PATCH] D127759: [Diagnostic] Clarify -Winfinite-recursion message

aaron.ballman added reviewers: aaron.ballman, erichkeane, xgupta. aaron.ballman added a comment. Thank you for looking into this! I'm adding a few more reviewers for awareness. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:63 def warn_infinite_recursive_function

[PATCH] D126984: [clang] Add support for optimize function attribute

steplong added a comment. I'm open to tabling this and just implementing support for an empty optimization list for the pragma (i.e. `#pragma optimize("", on | off)`). For our use case, at the moment, we only see the pragma being used this way. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D127306: [analyzer] Treat system globals as mutable if they are not const

steakhal marked 3 inline comments as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/MemRegion.cpp:978 +assert(!Ty.isNull()); +if (Ty.isConstQualified() && Ty->isArithmeticType()) { // TODO: We could walk the complex types here and s

[clang] 21ff652 - [analyzer][NFC] Replace getLastArg with hasArg when applicable

Author: Balazs Benics Date: 2022-06-14T19:28:44+02:00 New Revision: 21ff652de9fc9fe7338a83e2e405aa6c5d824479 URL: https://github.com/llvm/llvm-project/commit/21ff652de9fc9fe7338a83e2e405aa6c5d824479 DIFF: https://github.com/llvm/llvm-project/commit/21ff652de9fc9fe7338a83e2e405aa6c5d824479.diff

[PATCH] D127746: [clang][dataflow] Convert `PointeeLoc` of PointerValue from reference to pointer. This allows PointeeLoc to be empty in the case of `nullptr`

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:189 public: - explicit PointerValue(StorageLocation &PointeeLoc) + explicit PointerValue(StorageLocation *PointeeLoc) : Value(Kind::Pointer), PointeeLoc(PointeeLoc) {} -

[PATCH] D115674: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18a1fc8459b7: [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES

[clang] 18a1fc8 - [CMake][compiler-rt] Provide a dedicated option for LLVM unwinder

Author: Petr Hosek Date: 2022-06-14T17:26:25Z New Revision: 18a1fc8459b7fa8ca639d53e4aa5e5f5d68e8407 URL: https://github.com/llvm/llvm-project/commit/18a1fc8459b7fa8ca639d53e4aa5e5f5d68e8407 DIFF: https://github.com/llvm/llvm-project/commit/18a1fc8459b7fa8ca639d53e4aa5e5f5d68e8407.diff LOG: [C

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays for stricter handling of flexible arrays

kees added a comment. In D126864#3582360 , @nickdesaulniers wrote: > If the GCC developers split this into two distinct flags, should we land > something we're just going to have to turn around and modify to match the new > flags/semantics they've crea

[PATCH] D127732: [analyzer][NFC] Remove unused ExprEngine::evalBinOp functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf078adc90f0: [analyzer][NFC] Remove unused ExprEngine::evalBinOp functions (authored by steakhal). Repository: rG LLVM Github Monorepo CHANGES S

  1   2   3   >