[PATCH] D121100: [clang][DebugInfo] clang should not generate DW_TAG_subprogram entry without DW_AT_name

alok abandoned this revision. alok added a comment. GNU gdb is now modified to accept functions with linkage name. commit 6f9b09edaee43ea34d34b1998fe7b844834f251a Author: Alok Kumar Sharma Date: Sun May 22 21:46:06 2022 +0530 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] b86440e - [CSKY] Fix the conflict of default fpu features and -mfpu option

Author: Zi Xuan Wu (Zeson) Date: 2022-05-23T10:44:55+08:00 New Revision: b86440ecde5c1dec5b898a3f1bc08ab9853d5ed9 URL: https://github.com/llvm/llvm-project/commit/b86440ecde5c1dec5b898a3f1bc08ab9853d5ed9 DIFF: https://github.com/llvm/llvm-project/commit/b86440ecde5c1dec5b898a3f1bc08ab9853d5ed9.

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

paulaltin added a comment. In D126138#3530172 , @salman-javed-nz wrote: > This fix is check-agnostic, so I don't think we need to add even more tests > than the two proposed here. Yes, you're right; the issue itself is check-agnostic too, I just didn't

[PATCH] D126160: [Concepts] Add an error for unsupported P0848 (destructor overloading) code

royjacobson abandoned this revision. royjacobson added a comment. I continued hacking a bit at this and I think I got a working approach to implementing P0848 (down to 6 failing tests, will probably post at least a draft tomorrow). So I'll close for now. Maybe it's still useful for backporting

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 updated this revision to Diff 431264. roberteg16 edited the summary of this revision. roberteg16 added a comment. Make clang-format not complain Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126172/new/ https://reviews.llvm.org/D126172

[PATCH] D126160: [Concepts] Add an error for unsupported P0848 (destructor overloading) code

royjacobson updated this revision to Diff 431263. royjacobson added a comment. Fix conventions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126160/new/ https://reviews.llvm.org/D126160 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D126160: [Concepts] Add an error for unsupported P0848 (destructor overloading) code

royjacobson updated this revision to Diff 431251. royjacobson added a comment. Move diagnostic into Sema, make it fire once for every class template definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126160/new/ https://reviews.llvm.org/D1

[PATCH] D126172: [clang] Fix comparison of TemplateArgument when they are of template kind

roberteg16 created this revision. roberteg16 added reviewers: Richard, smith. Herald added a project: All. roberteg16 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This diff path takes care of comparing Template{Expansion} by template dec

[clang] 202a4fd - Test more C DR conformance (part two of many)

Author: Aaron Ballman Date: 2022-05-22T13:37:30-04:00 New Revision: 202a4fde2ba92d70f1eb8760e1919b6ab19f0ced URL: https://github.com/llvm/llvm-project/commit/202a4fde2ba92d70f1eb8760e1919b6ab19f0ced DIFF: https://github.com/llvm/llvm-project/commit/202a4fde2ba92d70f1eb8760e1919b6ab19f0ced.diff

[PATCH] D124446: [clang-tidy] Add the misc-discarded-return-value check

whisperity added a comment. In D124446#3521619 , @whisperity wrote: > @aaron.ballman [...] I think I can put in a measurement job [...] I've rerun the experiment **on another computer** (compared to the results shown in the inline comments) from scratc

[PATCH] D126160: [Concepts] Add an error for unsupported P0848 (destructor overloading) code

royjacobson planned changes to this revision. royjacobson added a comment. I've thought about this a bit more and I want to move the diagnostic into SemaTemplateInstantiateDecl or somewhere close. It makes more sense because it's closer to where P0848 needs to be implemented and it will spam les

[PATCH] D126170: C++ DR2394: Const-default-constructible for members.

jyknight created this revision. jyknight added reviewers: aaron.ballman, rsmith. Herald added a project: All. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Const class members may be initialized with a defaulted default construct

[clang] 69c0af3 - CWG 1394: Incomplete types as parameters of deleted functions

Author: James Y Knight Date: 2022-05-22T10:22:13-04:00 New Revision: 69c0af3de224131cca844debd12872d4d1686800 URL: https://github.com/llvm/llvm-project/commit/69c0af3de224131cca844debd12872d4d1686800 DIFF: https://github.com/llvm/llvm-project/commit/69c0af3de224131cca844debd12872d4d1686800.diff

[PATCH] D124690: [clangd] add inlay hints for std::forward-ed parameter packs

upsj planned changes to this revision. upsj marked 15 inline comments as done. upsj added a comment. I will update this to split up the control flow into a visitor just collecting a single recursion level and the high-level mapping. A general question here would be whether we should do the resol

[PATCH] D126160: [Concepts] Add an error for unsupported P0848 (destructor overloading) code

royjacobson updated this revision to Diff 431229. royjacobson added a comment. A working version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126160/new/ https://reviews.llvm.org/D126160 Files: clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D126077: Fix stack crash in classIsDerivedFrom triggered by clang-tidy

njames93 edited reviewers, added: aaron.ballman, njames93, alexfh, LegalizeAdulthood; removed: bixia, aartbik. njames93 added a comment. Do you know of any other instances where this issue could surface? Please can you add a line to the `Improved Checks` section in `clang-tools-extra/docs/Relea

[PATCH] D54943: [clang-tidy] implement new check 'misc-const-correctness' to add 'const' to unmodified variables

njames93 added a comment. Pretty much good to go, just a few nits with the tests. Can you add CHECK-FIXES directives for all warnings if there should be a fixit. If there shouldn't be one could you either add a comment saying there shouldn't be one, or put a CHECK-FIXES-NOT directive. Repositor

[PATCH] D126162: [clang-tidy] Extend SimplifyBooleanExpr demorgan support.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz added a comment. In D126138#3529820 , @paulaltin wrote: > Thanks for preparing this revision @salman-javed-nz! > > Do you think it could be worth adding a few more test cases to cover this? It > turned out that this issue wasn't actually

[PATCH] D126138: [clang-tidy] Fix #55134 (regression introduced by 5da7c04)

salman-javed-nz updated this revision to Diff 431223. salman-javed-nz added a comment. Add another test, to test the specific code sample in the GitHub issue (check=cppcoreguidelines-pro-type-member-init). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang-tools-extra] 9d0d24e - [clang-tidy] Fix not updating storeOptions after af77b1d9901

Author: Nathan James Date: 2022-05-22T10:28:52+01:00 New Revision: 9d0d24eec44787b4a762d01866d0b9b733bee778 URL: https://github.com/llvm/llvm-project/commit/9d0d24eec44787b4a762d01866d0b9b733bee778 DIFF: https://github.com/llvm/llvm-project/commit/9d0d24eec44787b4a762d01866d0b9b733bee778.diff

[PATCH] D126123: [analyzer][NFC] MemRegion::getRegion() never returns null

steakhal added a comment. Until this point, the runtime and reports of the Clang Static Analyzer did not change on our testset; which confirms that the stack is indeed NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126123/new/ https://reviews.

[PATCH] D126157: [clang-format][NFC] Insert/remove braces in clang/lib/Format/

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Ok. So we mainly missed braces on complex conditionals. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126157/new/ https://reviews.llvm

[PATCH] D126160: [Concepts] Add an error for unsupported P0848 (destructor overloading) code

royjacobson created this revision. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We have received numeroud bug reports over P0848 not being implemented for destructors. We currently allow multiple

[PATCH] D124806: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf77b1d99016: [clang-tidy] add support for Demorgan conversions to readability-simplify-bool… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang-tools-extra] af77b1d - [clang-tidy] add support for Demorgan conversions to readability-simplify-bool-expr

Author: Nathan James Date: 2022-05-22T09:28:43+01:00 New Revision: af77b1d99016fde66edd9e72d907c03fe4511215 URL: https://github.com/llvm/llvm-project/commit/af77b1d99016fde66edd9e72d907c03fe4511215 DIFF: https://github.com/llvm/llvm-project/commit/af77b1d99016fde66edd9e72d907c03fe4511215.diff

[PATCH] D125863: [clangd] Dont mark terminating PP-directives as skipped

nridge added a comment. Potentially related issue: https://github.com/clangd/clangd/issues/773 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125863/new/ https://reviews.llvm.org/D125863 ___ cfe-commits m

[PATCH] D126158: [MLIR][GPU] Replace fdiv on fp16 with promoted (fp32) multiplication with reciprocal plus one (conditional) Newton iteration.

csigg created this revision. csigg added a reviewer: bkramer. Herald added subscribers: bzcheeseman, mattd, gchakrabarti, awarzynski, sdasgup3, asavonic, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb,

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

owenpan added a comment. In D126132#3530076 , @curdeius wrote: > LGTM. It seems it has landed already. Yeah. I pushed it by mistake. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126132/new/ https://re

[PATCH] D126132: [clang-format] Fix a crash on lambda trailing return type

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. It seems it has landed already. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126132/new/ https://reviews.llvm.org/D126132 __