[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

balazske added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:285 + return isa(S) || isa(S) || + isa(S) || isa(S) || + isa(S) || isa(S) || whisperity wrote: > Is CUDA built upon C++-specific features? It

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

nridge added a comment. I looked through this patch, and it looks good to me! I will leave the final approval to Sam though. Comment at: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp:416 +// These mocks aren't quite right - we omit shared_ptr for simplicity. +

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429619. kbobyrev added a comment. Also rebase on top of main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125468/new/ https://reviews.llvm.org/D125468 Files: clang-tools-extra/clangd/Headers.cpp clang-t

[PATCH] D125604: [FileCheck] Catch missspelled directives.

jhenderson added a comment. Code change looks good to me. Are the TODO cases where the test fails if changing them? Comment at: llvm/test/FileCheck/missspelled-directive.txt:18 + +P4_COUNT-2: foo +CHECK4: error: misspelled directive 'P4_COUNT-2:' What about `P

[PATCH] D125468: [clangd] Include Cleaner: ignore headers with IWYU export pragmas

kbobyrev updated this revision to Diff 429618. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments: the structure is a bit different but the bug is now actually removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

This revision was automatically updated to reflect the committed changes. Closed by commit rG924acb624f58: [clang] Prevent folding of non-const compound expr (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/

[clang] 924acb6 - [clang] Prevent folding of non-const compound expr

Author: serge-sans-paille Date: 2022-05-16T07:50:39+02:00 New Revision: 924acb624f58030652ecc8c07db313fde0f31395 URL: https://github.com/llvm/llvm-project/commit/924acb624f58030652ecc8c07db313fde0f31395 DIFF: https://github.com/llvm/llvm-project/commit/924acb624f58030652ecc8c07db313fde0f31395.d

[PATCH] D115187: [clangd] Expose CoawaitExpr's operand in the AST

nridge updated this revision to Diff 429611. nridge added a comment. Fix last test case and review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115187/new/ https://reviews.llvm.org/D115187 Files: clang-tools-extra/clangd/unittests/FindT

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: cfe-commits, M

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaCoroutine.cpp:1312 + + bool PromiseContainNew = [this, &PromiseType]() -> bool { +DeclarationName NewName = erichkeane wrote: > Slight preference to j

[PATCH] D125517: [Frontend] [Coroutines] Emit error when we found incompatible allocation function in promise_type

ChuanqiXu updated this revision to Diff 429595. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125517/new/ https://reviews.llvm.org/D125517 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Se

[PATCH] D125521: [Diagnostic] Warn if the size argument of memset is character literal zero

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bef90dff64f: [Diagnostic] Warn if the size argument of memset is character literal (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12

[clang] 3bef90d - [Diagnostic] Warn if the size argument of memset is character literal

Author: Chuanqi Xu Date: 2022-05-16T10:07:01+08:00 New Revision: 3bef90dff64fc717c5d5e33a4d5fb47a4566d04a URL: https://github.com/llvm/llvm-project/commit/3bef90dff64fc717c5d5e33a4d5fb47a4566d04a DIFF: https://github.com/llvm/llvm-project/commit/3bef90dff64fc717c5d5e33a4d5fb47a4566d04a.diff LO

[PATCH] D125487: [Tooling/DependencyScanning] Refactor dependency scanning to produce pre-lexed preprocessor directive tokens, instead of minimized sources

akyrtzi updated this revision to Diff 429580. akyrtzi added a comment. Fix issue where an empty '#' in a line was causing the immediately following preprocessor directive to be skipped. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125487/new/ htt

[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

rjmccall added a comment. On the one hand, I'm not sure 8M statements in a block — or 1M, for that matter — is an unreasonable implementation limit. On the other hand, this patch looks like it only changes overall memory use on 32-bit hosts, because `CompoundStmt` has a 32-bit field prior to i

[PATCH] D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

owenpan updated this revision to Diff 429560. owenpan added a reviewer: sstwcw. owenpan removed a subscriber: sstwcw. owenpan added a comment. Fixes typos and makes `KeepElseBraces` depend on `KeepIfBraces`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125626/new/ https://reviews.llvm.

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng marked an inline comment as done. pzheng added inline comments. Comment at: clang/include/clang/Driver/Options.td:6663 def _SLASH_Zc_ternary : CLIgnoredFlag<"Zc:ternary">; def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">; def _SLASH_ZH_MD5 : CLIgnoredFlag<"ZH:MD5">;

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

pzheng updated this revision to Diff 429559. pzheng added a comment. Address @thakis's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125513/new/ https://reviews.llvm.org/D125513 Files: clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D125513: [clang-cl] Add /Zc:wchar_t- option

thakis added a comment. Seems generally ok. Comment at: clang/include/clang/Driver/Options.td:6663 def _SLASH_Zc_ternary : CLIgnoredFlag<"Zc:ternary">; def _SLASH_Zc_wchar_t : CLIgnoredFlag<"Zc:wchar_t">; def _SLASH_ZH_MD5 : CLIgnoredFlag<"ZH:MD5">; Can you

[libunwind] fd86423 - Revert "[libunwind][AArch64] Add support for DWARF expression for RA_SIGN_STATE."

Author: Daniel Kiss Date: 2022-05-15T21:42:07+02:00 New Revision: fd864238fca1435cb1ceffdca0d4294cf3419ac7 URL: https://github.com/llvm/llvm-project/commit/fd864238fca1435cb1ceffdca0d4294cf3419ac7 DIFF: https://github.com/llvm/llvm-project/commit/fd864238fca1435cb1ceffdca0d4294cf3419ac7.diff L

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff added a comment. In D123952#3488638 , @aaron.ballman wrote: > Thanks for working on this! One thing that's not clear to me is what bugs > this is solving -- the test coverage only shows a change to textual AST > dumping behavior. Is this othe

[PATCH] D125635: Move NumStmts from CompoundStmtBitfields to fields of CompoundStmt

sepavloff created this revision. sepavloff added reviewers: aaron.ballman, rsmith, rjmccall. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. Number of statements in CompoundStmt is kept in a bit-field of Stmt common part. The field has 24 bi

[PATCH] D124688: [clangd] parse all make_unique-like functions in preamble

upsj added a comment. @sammccall @nridge can you give this another look? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124688/new/ https://reviews.llvm.org/D124688 ___ cfe-commits mailing list cfe-com

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw added a comment. The two parents of this revision change the same file, so the build bot says patch does not apply. Does that mean I have to submit the parent patches with less context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/

[PATCH] D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. I like it! Thanks! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:523 + /*MunchSemi=*/true, /*KeepBraces=*/true, + /*UnindentW

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw added inline comments. Comment at: clang/lib/Format/FormatTokenLexer.cpp:1105 + static const llvm::Regex VerilogToken( + "^(\'|``?|((\r?\n|\r)|[^[:space:]])*)"); + HazardyKnusperkeks wrote: > Consider a raw string, for a better reading. You m

[PATCH] D124749: [clang-format] Handle Verilog preprocessor directives

sstwcw updated this revision to Diff 429532. sstwcw added a comment. - add tests and remove __LINE__ and __FILE__ special cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124749/new/ https://reviews.llvm.org/D124749 Files: clang/lib/Format/Fo

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw marked 8 inline comments as done. sstwcw added a comment. This patch is not NFC. But there would not be change in behavior if the input is valid C as far as I know. input: #define LIST \ `ENTRY \ `ENTRY output before, note extra line: #define LIST

[PATCH] D124748: [clang-format] Fix whitespace counting stuff

sstwcw updated this revision to Diff 429530. sstwcw added a comment. - address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124748/new/ https://reviews.llvm.org/D124748 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Fo

[PATCH] D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

sstwcw added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2732 +parseBlock(/*MustBeDeclaration=*/true, AddLevels, /*MunchSemi=*/true, + /*KeepBracces=*/true, ManageWhitesmithsBraces); Repository: rG LLVM Github Mo

[PATCH] D125628: [flang][driver] Add support for generating executables on MacOSX/Darwin

awarzynski created this revision. awarzynski added reviewers: rovka, rouson, MaskRay, h-vetinari, schweitz, kiranchandramohan. Herald added a reviewer: sscalpone. Herald added subscribers: StephenFan, mehdi_amini. Herald added projects: Flang, All. awarzynski requested review of this revision. Her

[clang] f66596c - [clang][docs] Add escape code to fix missing '*' in reduction operation list

Author: Simon Pilgrim Date: 2022-05-15T12:32:11+01:00 New Revision: f66596c94f772e214fd9d96cc78f7fec17209281 URL: https://github.com/llvm/llvm-project/commit/f66596c94f772e214fd9d96cc78f7fec17209281 DIFF: https://github.com/llvm/llvm-project/commit/f66596c94f772e214fd9d96cc78f7fec17209281.diff

[PATCH] D123952: [FPEnv] Allow CompoundStmt to keep FP options

sepavloff updated this revision to Diff 429525. sepavloff added a comment. Addressed review notes - Added support in JSON node dumper, - Added support in ast-print Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123952/new/ https://reviews.llvm.org/

[PATCH] D125626: [clang-format][NFC] Don't call mightFitOnOneLine() unnecessarily

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clean up `Unwr

[PATCH] D125625: Implementation of '#pragma STDC FENV_ROUND'

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aaron.ballman, kpn, andrew.w.kaylor. Herald added a project: All. sepavloff requested review of this revision. Herald added a project: clang. This pragma is introduced by forthcoming C2x standard and can be used to set

[PATCH] D125593: [clang-format] Handle "if consteval { ... }" for RemoveBracesLLVM

This revision was automatically updated to reflect the committed changes. Closed by commit rG2cdabc032292: [clang-format] Handle "if consteval { ... }" for RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125593/n

[clang] 2cdabc0 - [clang-format] Handle "if consteval { ... }" for RemoveBracesLLVM

Author: owenca Date: 2022-05-15T01:33:44-07:00 New Revision: 2cdabc0322929a3954b63c1f29f23959e2e50278 URL: https://github.com/llvm/llvm-project/commit/2cdabc0322929a3954b63c1f29f23959e2e50278 DIFF: https://github.com/llvm/llvm-project/commit/2cdabc0322929a3954b63c1f29f23959e2e50278.diff LOG: [