[PATCH] D124996: [clang][preprocessor] Fix unsigned-ness of utf8 char literals

tbaeder added inline comments. Comment at: clang/test/Lexer/utf8-char-literal.cpp:54-56 +# if !(u8'\xff' == 0xff) +#error u8 char literal is not unsigned +# endif tahonermann wrote: > The C++ case looks good now, but the condition doesn't look right for the

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

delcypher added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:111 KEYSYCL = 0x100, +KEYCUDA = 0x200, KEYALLCXX = KEYCXX | KEYCXX11 | KEYCXX20, yaxunl wrote: > delcypher wrote: > > @yaxunl Is it intentional that

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille updated this revision to Diff 428562. serge-sans-paille added a comment. Update GCC manual quote CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/ https://reviews.llvm.org/D124038 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/constant-expression

[PATCH] D125318: [analyzer] Add UnarySymExpr

NoQ added a comment. Looks great! I suspect you'll catch a few crashes/assertion failures if you run this on real-world code, due to various parts of the static analyzer being startled by the new thing, so I really recommend doing this. Comment at: clang/include/clang/Stati

[PATCH] D125350: [RFC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 added a comment. As for the test, here is a simple code snippet: #pragma omp begin declare target device_type(nohost) void foo() { double x, y; #pragma omp atomic update x += y; } #pragma omp end declare target `sm_35` doesn't support `FAdd` with `double` type, t

[PATCH] D125350: [PoC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 added inline comments. Comment at: clang/lib/Basic/Targets/NVPTX.cpp:311 +} +return false; + } `llvm_unreachable` might be more appropriate here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D125350: [PoC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 added a comment. Feel free to add more reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125350/new/ https://reviews.llvm.org/D125350 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D125350: [PoC][Clang] Add a check if the target supports atomicrmw instruction with specific operator and type

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: mattd, gchakrabarti, asavonic, jholewinski. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cf

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:111 KEYSYCL = 0x100, +KEYCUDA = 0x200, KEYALLCXX = KEYCXX | KEYCXX11 | KEYCXX20, delcypher wrote: > @yaxunl Is it intentional that you didn't update `K

[PATCH] D125323: [RISCV] Add the passthru operand for RVV unmasked segment load IR intrinsics.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:879 + // intrinsic: (passthru0, passthru1, ..., ptr, vl) + SmallVector Operands; + for (unsigned I = 0; I < NF; ++I) Why 12? NF is at most 8 right? And then 2

[PATCH] D125203: [PowerPC] Fix PPCISD::STBRX selection issue on A2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG289236d597a2: [PowerPC] Fix PPCISD::STBRX selection issue on A2 (authored by tingwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 289236d - [PowerPC] Fix PPCISD::STBRX selection issue on A2

Author: Ting Wang Date: 2022-05-10T20:47:51-04:00 New Revision: 289236d597a228484dfd9607da6889603b9210a8 URL: https://github.com/llvm/llvm-project/commit/289236d597a228484dfd9607da6889603b9210a8 DIFF: https://github.com/llvm/llvm-project/commit/289236d597a228484dfd9607da6889603b9210a8.diff LOG

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

delcypher added inline comments. Comment at: clang/lib/Basic/IdentifierTable.cpp:111 KEYSYCL = 0x100, +KEYCUDA = 0x200, KEYALLCXX = KEYCXX | KEYCXX11 | KEYCXX20, @yaxunl Is it intentional that you didn't update `KEYALL` here? Tha

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim added inline comments. Comment at: llvm/test/tools/llvm-symbolizer/data-location.s:7 + +# CHECK: x +# CHECK-NEXT: 14572 4 jhenderson wrote: > hctim wrote: > > jhenderson wrote: > > > hctim wrote: > > > > jhenderson wrote: > > > > > It might be useful t

[PATCH] D123538: [symbolizer] Parse DW_TAG_variable DIs to show line info for globals

hctim updated this revision to Diff 428538. hctim marked an inline comment as done. hctim added a comment. (comment) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123538/new/ https://reviews.llvm.org/D123538 Files: llvm/include/llvm/DebugInfo/DI

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

porglezomp added a comment. Ah, so it'd be a test that passes pretty trivially on any bot that doesn't have a custom version of `CLANG_DEFAULT_STD_C` and `CLANG_DEFAULT_STD_CXX` like the default config, but could get caught by any other bots that do set it? What's the best way to get the compil

[PATCH] D125011: [MSVC] Add support for pragma alloc_text

steplong updated this revision to Diff 428536. steplong added a comment. - Added Sema tests - Added checking of c linkage - Changed some parsing logic in the parser handler e.g #pragma alloc_text(a, foo without the right paren is only a warning Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. **`Replying to the various comments given in this revision:`** **1. Regarding string manipulation:** > I need to look at the algorithm in more detail, but I'm not a fan of using a > string key. Concatenating strings to make compound keys is not very efficient > and

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm added a comment. > Thanks for improving the doc! Are you moving this to be used in > canonicalization next? > I think a first good step would be to make it a pattern and test it with a > pass that applies it in the greedy rewriter. I would land this first and then > try to enable thi

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:193 + } + static unsigned getHashValue(const OffloadKind &Val) { return Val * 37U; } + jhuber6 wrote: > tra wrote: > > Is there a particular reason for multiplying by

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Module &M) { + LLVMContext &C = M.getContext(); tra wrote:

[PATCH] D123812: [CUDA] Add wrapper code generation for registering CUDA images

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:351 +/// required for texture / surface / managed variables. +Function *createRegisterGlobalsFunction(Modu

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 added a comment. Thanks for the review. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:193 + } + static unsigned getHashValue(const OffloadKind &Val) { return Val * 37U; } + tra wrote: > Is there a particular reason for multiplyin

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Please add a TODO around the items that need further work, so we don't forget about them. Review comments tend to fade from memory. Comment at: clang/tools/clang-linker-wrapper/Cl

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 428520. samitolvanen added a comment. Added a test for the Clang -O2 pipeline dropping unneeded checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119296/new/ https://reviews.llvm.org/D119296 Files:

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. OK. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125165/new/ https://reviews.llvm.org/D125165 ___

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 updated this revision to Diff 428517. jhuber6 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123810/new/ https://reviews.llvm.org/D12

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

rnk added a comment. This seems reasonable, but I worry about the consequences of creating lots of unnamed global variables. What will gdb do with so many unnamed globals? What will the PDB linker do with all these unnamed globals? I can't answer these questions, and you're welcome to try and f

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. This is marked "needs revision", but I think it just needs wider review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125142/new/ https://reviews.llvm.org/D125142 ___ cfe-commits m

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:726 + + if (Error Err = executeCommands(*FatBinaryPath, CmdArgs)) +return std::move(Err); tra wrote: > We should have a way to pass extra options to fatbinary,

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

mehdi_amini added a comment. Thanks for improving the doc! Are you moving this to be used in canonicalization next? I think a first good step would be to make it a pattern and test it with a pass that applies it in the greedy rewriter. I would land this first and then try to enable this in the

[PATCH] D125340: [clang][NFC][AST] rename the ImportError to ASTImportError

phyBrackets created this revision. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. phyBrackets requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. this patch

[PATCH] D123810: [Cuda] Add initial support for wrapping CUDA images in the new driver.

tra added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:188 + static inline OffloadKind getEmptyKey() { +return static_cast(0x); + } Extend `enum OffloadKind` to include these special kinds. Com

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 428502. srishti-pm added a comment. Fixing a minor typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org/D124750 Files: clang/docs/tools/clang-formatted-files.txt mlir

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. In D124534#3504610 , @aaron.ballman wrote: > LGTM, thank you for all the hard work on this! I assume you need me to land > this on your behalf -- if so, can you let me know what name and email address > you would like me to

[PATCH] D125338: [HLSL] add -D option for dxc mode.

python3kgae created this revision. python3kgae added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter, beanz, pow2clk, aaron.ballman. Herald added subscribers: Anastasia, StephenFan. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers:

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

srishti-pm updated this revision to Diff 428498. srishti-pm added a comment. Improving the documentation of the functionality of this utility to make it more clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124750/new/ https://reviews.llvm.org

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for all the hard work on this! I assume you need me to land this on your behalf -- if so, can you let me know what name and email address you would like me to use

[PATCH] D125330: [OpenMP] Fix mangling for linear modifiers with variable stride

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0dbaef61b56f: [OpenMP] Fix mangling for linear modifiers with variable stride (authored by mikerice). Herald added a project: clang. Herald added a s

[clang] 0dbaef6 - [OpenMP] Fix mangling for linear modifiers with variable stride

Author: Mike Rice Date: 2022-05-10T14:12:44-07:00 New Revision: 0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff URL: https://github.com/llvm/llvm-project/commit/0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff DIFF: https://github.com/llvm/llvm-project/commit/0dbaef61b56f0ef0ab0cf38ea92ffc1f35bee3ff.diff LOG

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

efriedma added a comment. I think so, yes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124038/new/ https://reviews.llvm.org/D124038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D123534: [dwarf] Emit a DIGlobalVariable for constant strings.

hctim added a comment. In D123534#3489262 , @dblaikie wrote: > @rnk @aprantl @probinson: this looks plausible to me to take as a general > change to the emitted DWARF, but I'm open to ideas/suggestions if folks find > this to be too much growth for not

[clang] 0376c0f - Revert "[utils] Avoid hardcoding metadata ids in update_cc_test_checks"

Author: Jan Korous Date: 2022-05-10T14:04:19-07:00 New Revision: 0376c0f271398147b3df79ab20ffb2f375e47215 URL: https://github.com/llvm/llvm-project/commit/0376c0f271398147b3df79ab20ffb2f375e47215 DIFF: https://github.com/llvm/llvm-project/commit/0376c0f271398147b3df79ab20ffb2f375e47215.diff LO

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

jkorous added a comment. Reverting for now. Will take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123273/new/ https://reviews.llvm.org/D123273 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

serge-sans-paille added a comment. In D124038#3504371 , @efriedma wrote: > I think you're looking at old documentation? Here's what the current page > (https://gcc.gnu.org/onlinedocs/gcc/Compound-Literals.html) has to say: Indeed! I was looking at my l

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

Jake-Egan added a comment. 4 of the tests fail on AIX also: https://lab.llvm.org/buildbot/#/builders/214/builds/1207 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123273/new/ https://reviews.llvm.org/D123273 __

[clang] eadeabb - [NFC] Replace not-null and not-isa check with a not-isa_and_nonnull

Author: Erich Keane Date: 2022-05-10T13:34:07-07:00 New Revision: eadeabbe10f5096b12e488e7bd8e2292429b5e08 URL: https://github.com/llvm/llvm-project/commit/eadeabbe10f5096b12e488e7bd8e2292429b5e08 DIFF: https://github.com/llvm/llvm-project/commit/eadeabbe10f5096b12e488e7bd8e2292429b5e08.diff L

[PATCH] D124874: [clang] add -fmodule-file-home-is-cwd

rmaz updated this revision to Diff 428483. rmaz added a comment. Refactor branch into existing case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124874/new/ https://reviews.llvm.org/D124874 Files: clang/include/clang/Driver/Options.td clang/i

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

hokein marked 3 inline comments as done. hokein added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/GLR.h:125 }; -// Parse the given token stream with the GLR algorithm, and return a forest node -// of the start symbol. sammccall wr

[PATCH] D125006: [pseudo] Support parsing variant target symbols.

hokein updated this revision to Diff 428479. hokein marked 3 inline comments as done. hokein added a comment. - adress comments - rename TargetSymbol -> StartSymbol - don't use StartSymbol for "_", rename and update a few occurrences - move findNonterminal to Grammar.h since it is used in various

[PATCH] D124341: [clang-tidy][NFC] Replace many instances of std::string where a StringRef would suffice.

njames93 added a comment. In D124341#3502659 , @uabelho wrote: > Hi, > > I noticed that this patch isn't NFC. Whoops, good catch. I left in some debugging code, fixed in rGa308a55720249749

[clang-tools-extra] a308a55 - [clang-tidy] Fix unintended change left in 12cb540529e

Author: Nathan James Date: 2022-05-10T21:07:31+01:00 New Revision: a308a557202497495c10355279b5b9975bbee98e URL: https://github.com/llvm/llvm-project/commit/a308a557202497495c10355279b5b9975bbee98e DIFF: https://github.com/llvm/llvm-project/commit/a308a557202497495c10355279b5b9975bbee98e.diff

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

tstellar added a comment. In D125165#3504252 , @tra wrote: > LGTM in principle. > > Given that we're introducing a new tool dependency we may want to get a stamp > from someone dealing with build and release. > @tstellar -- do we need to change anything

[PATCH] D125333: [OpenMP] Use the new OpenMP device static library when doing LTO

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ABataev. Herald added subscribers: guansong, inglorion, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Heral

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:10 +// expected-warning@+11 {{'#elfidef' directive not found, did you mean '#elifdef'?}} +// expected-warning@+11 {{'#elfindef' directive not found, did you mean '#elifdef'?}} +// e

[PATCH] D111548: [Clang] Add the `annotate_type` attribute

rsmith added inline comments. Comment at: clang/test/SemaCXX/annotate-type.cpp:2 +// RUN: %clang_cc1 %s -std=c++17 -fsyntax-only -verify + +struct S1 { mboehme wrote: > rsmith wrote: > > mboehme wrote: > > > aaron.ballman wrote: > > > > mboehme wrote: > > > > > a

[PATCH] D125137: [clang-format] Don't remove braces if a 1-statement body would wrap

owenpan updated this revision to Diff 428468. owenpan added a comment. Added saving/restoring the children of `UnwrappedLineNode` and addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125137/new/ https://reviews.llvm.org/D125137 Files: clang/lib/Format/Unwrapp

[PATCH] D123471: [CUDA] Create offloading entries when using the new driver

jhuber6 added a comment. Is this with D123810 and D123812 good to land? It would be nice to be able to test this upstream. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123471/n

[PATCH] D124038: [clang] Prevent folding of non-const compound expr

efriedma added a comment. I think you're looking at old documentation? Here's what the current page (https://gcc.gnu.org/onlinedocs/gcc/Compound-Literals.html) has to say: In C, a compound literal designates an unnamed object with static or automatic storage duration. In C++, a compound lite

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

ken-matsui updated this revision to Diff 428471. ken-matsui added a comment. Set `AllowReplacements` to `true` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124726/new/ https://reviews.llvm.org/D124726 Files: clang/include/clang/Basic/Diagnostic

[clang] b6572ad - [NFC] Add missing 'break' in a switch case

Author: Erich Keane Date: 2022-05-10T12:48:08-07:00 New Revision: b6572ad504753c6c27ba49c2ed595a091c977dcd URL: https://github.com/llvm/llvm-project/commit/b6572ad504753c6c27ba49c2ed595a091c977dcd DIFF: https://github.com/llvm/llvm-project/commit/b6572ad504753c6c27ba49c2ed595a091c977dcd.diff L

[PATCH] D120727: [libc++] Overhaul how we select the ABI library

mstorsjo added a comment. I gave it a quick readthrough, but I don't think I can give a qualified review of the bulk of it... I noticed a couple minor details though. Comment at: libcxx/CMakeLists.txt:260 else() -set(LIBCXX_CXX_ABI_LIBNAME "default") +set(LIBCXX_CXX

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

thakis added a comment. Also fails on linux: https://lab.llvm.org/buildbot/#/builders/109/builds/38285 And on mac: http://45.33.8.238/macm1/35024/step_7.txt (On some platforms, the bot redness was masked by D124552 breaking the bots first.) But yes, please fi

[clang] 508d2b4 - [NFC]Add Missing Break in switch that we didn't notice because it was

Author: Erich Keane Date: 2022-05-10T12:27:45-07:00 New Revision: 508d2b4e13c05388a19173e5bd98ac06b9dd9b98 URL: https://github.com/llvm/llvm-project/commit/508d2b4e13c05388a19173e5bd98ac06b9dd9b98 DIFF: https://github.com/llvm/llvm-project/commit/508d2b4e13c05388a19173e5bd98ac06b9dd9b98.diff L

[PATCH] D125312: [pseudo] benchmark cleanups. NFC

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125312/new/ https://reviews.llvm.org/D125312

[PATCH] D125162: [clang-format] fix alignment w/o binpacked args

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:17286 + // BinPackArguments. + // See https://github.com/llvm/llvm-project/issues/55360 + Alignment = getLLVMStyleWithColumns(50); I'd drop that, or at least replace it

[PATCH] D124702: [MSVC] Add support for pragma function

steplong updated this revision to Diff 428456. steplong added a comment. - Changed pragma-ms-functions.c to only check that the no-builtin attributes are added to the functions - Moved pragma handler to Parser - Changed scope check to only file scope. MSVC accepts stuff like that we don't: str

[clang] 180a853 - Fix indentation in ReleaseNotes.rst

Author: Yaxun (Sam) Liu Date: 2022-05-10T14:56:28-04:00 New Revision: 180a8536cec8e5e13e86863b17982daf95f2038a URL: https://github.com/llvm/llvm-project/commit/180a8536cec8e5e13e86863b17982daf95f2038a DIFF: https://github.com/llvm/llvm-project/commit/180a8536cec8e5e13e86863b17982daf95f2038a.dif

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 added a comment. In D125165#3504252 , @tra wrote: > LGTM in principle. > > Given that we're introducing a new tool dependency we may want to get a stamp > from someone dealing with build and release. > @tstellar -- do we need to change anything

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

tra added a subscriber: tstellar. tra added a comment. LGTM in principle. Given that we're introducing a new tool dependency we may want to get a stamp from someone dealing with build and release. @tstellar -- do we need to change anything else for the new binary to ship with clang releases?

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 428450. ken-matsui added a comment. Fix the test as reviewed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

dyung added a comment. Hi @jkorous, 4 of the tests you added seem to be failing on the PS4 linux and Window buildbots, can you take a look, and revert if it might take a while to investigate? https://lab.llvm.org/buildbot/#/builders/139/builds/21573 https://lab.llvm.org/buildbot/#/builders/216/

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rGafc9d674fe5a: [CUDA][HIP] support __noinline__ as keyword (authored by yaxunl). Herald added a project: clan

[clang] afc9d67 - [CUDA][HIP] support __noinline__ as keyword

Author: Yaxun (Sam) Liu Date: 2022-05-10T14:32:27-04:00 New Revision: afc9d674fe5a14b95c50a38d8605a159c2460427 URL: https://github.com/llvm/llvm-project/commit/afc9d674fe5a14b95c50a38d8605a159c2460427 DIFF: https://github.com/llvm/llvm-project/commit/afc9d674fe5a14b95c50a38d8605a159c2460427.dif

[PATCH] D125165: [Clang] Introduce clang-offload-packager tool to bundle device files

jhuber6 updated this revision to Diff 428443. jhuber6 added a comment. Adding some extra documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125165/new/ https://reviews.llvm.org/D125165 Files: clang/docs/ClangOffloadPackager.rst clang

[PATCH] D124974: [clang] Include clang config.h in LangStandards.cpp

dexonsmith added a comment. In D124974#3494374 , @sammccall wrote: > In D124974#3494279 , @dexonsmith > wrote: > >> Can we add a test for this? > > I think the problem with testing it is that this variable comes

[PATCH] D124816: [LibTooling] use ToolFileManager to store file managers for each CWD

dexonsmith added a comment. This looks mostly correct to me, but perhaps pessimistic enough it'll regress performance unnecessarily. A few comments inline. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:169-170 ScanInstance.getFrontendOpts(

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

ken-matsui added a comment. Thank you for your review! I'm going to fix them :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 ___ cfe-commits mailing list cfe

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

ken-matsui added a comment. Thank you all so much :))) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125078/new/ https://reviews.llvm.org/D125078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D125142: [clang][auto-init] Remove -enable flag for "zero" mode

kees added a comment. In D125142#3502732 , @MaskRay wrote: > This cannot be committed as is. In particular, @rsmith's "We do not want to > create or encourage the creation of language dialects and non-portable code," > concern on > https://discourse.ll

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

tra added inline comments. Comment at: clang/test/SemaCUDA/noinline.cu:8 +__attribute__((noinline)) void fun2() { } +__attribute__((__noinline__)) void fun3() { } aaron.ballman wrote: > yaxunl wrote: > > aaron.ballman wrote: > > > yaxunl wrote: > > > > aaron.ball

[PATCH] D125178: Warn if using `elifdef` & `elifndef` in not C2x & C++2b mode

ken-matsui updated this revision to Diff 428435. ken-matsui added a comment. Fix failed tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125178/new/ https://reviews.llvm.org/D125178 Files: clang/include/clang/Basic/DiagnosticLexKinds.td cla

[PATCH] D125272: [clang] Add -fcheck-new support

heatd updated this revision to Diff 428433. heatd added a comment. Adjusted the driver code to use addOptInFlag, adjusted the test, fixed the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125272/new/ https://reviews.llvm.org/D125272 File

[clang] 0456654 - [OpenMP] Fix embedding offload code when there is no offloading toolchain

Author: Joseph Huber Date: 2022-05-10T13:33:20-04:00 New Revision: 045665423e6e893ee168368dab10469c8d3168c5 URL: https://github.com/llvm/llvm-project/commit/045665423e6e893ee168368dab10469c8d3168c5 DIFF: https://github.com/llvm/llvm-project/commit/045665423e6e893ee168368dab10469c8d3168c5.diff

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

xbolva00 added a comment. In D125078#3503921 , @cjdb wrote: > I support turning it on by default. I'm simply passing on the message. +1, I support on by default as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D124750: [MLIR] Add a utility to sort the operands of commutative ops

rriddle added a comment. +1 on all of the other comments, especially related to the use of strings. In D124750#3503607 , @Mogball wrote: > On the matter of whether this should be a canonicalization, my concern with > this is that if an operation has its

[PATCH] D123273: [utils] Avoid hardcoding metadata ids in update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce583b14b2ec: [utils] Avoid hardcoding metadata ids in update_cc_test_checks (authored by jkorous). Herald added a project: clang. Herald added a sub

[clang] ce583b1 - [utils] Avoid hardcoding metadata ids in update_cc_test_checks

Author: Jan Korous Date: 2022-05-10T10:17:45-07:00 New Revision: ce583b14b2ec37b1c168bb92020680cb452502b3 URL: https://github.com/llvm/llvm-project/commit/ce583b14b2ec37b1c168bb92020680cb452502b3 DIFF: https://github.com/llvm/llvm-project/commit/ce583b14b2ec37b1c168bb92020680cb452502b3.diff LO

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl updated this revision to Diff 428423. yaxunl marked an inline comment as done. yaxunl added a comment. make it a feature, add tests for pedantic, fix release notes and doecumentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124866/new/ https://reviews.llvm.org/D124866 Files

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

aaron.ballman added inline comments. Comment at: clang/test/SemaCUDA/noinline.cu:8 +__attribute__((noinline)) void fun2() { } +__attribute__((__noinline__)) void fun3() { } yaxunl wrote: > aaron.ballman wrote: > > yaxunl wrote: > > > aaron.ballman wrote: > > > >

[PATCH] D124866: [CUDA][HIP] support __noinline__ as keyword

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/test/SemaCUDA/noinline.cu:8 +__attribute__((noinline)) void fun2() { } +__attribute__((__noinline__)) void fun3() { } aaron.ballman wrote: > yaxunl wrote: > > aaron.ballman w

[PATCH] D124534: [clang] Add a diagnostic for line directive of a gnu extension

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/line-directive-system-headers.c:1-2 +// RUN: %clang_cc1 -std=c99 -fsyntax-only -pedantic -verify %s +// RUN: %clang_cc1 -std=c99 -fsyntax-only -pedantic -verify=system -Wsystem-headers %s +

[PATCH] D124726: Suggest typoed directives in preprocessor conditionals

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/suggest-typoed-directive.c:3 + +// id: not suggested to '#if' +// ifd: expected-warning@+11 {{invalid preprocessing directive, did you mean '#if'?}} erichkeane wrote: > aaron.bal

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3137ca80b9ef: [clangd] Support for standard inlayHint protocol (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[clang-tools-extra] 3137ca8 - [clangd] Support for standard inlayHint protocol

Author: Kadir Cetinkaya Date: 2022-05-10T18:59:15+02:00 New Revision: 3137ca80b9ef99359a4adf77512925c2edc461b9 URL: https://github.com/llvm/llvm-project/commit/3137ca80b9ef99359a4adf77512925c2edc461b9 DIFF: https://github.com/llvm/llvm-project/commit/3137ca80b9ef99359a4adf77512925c2edc461b9.dif

[PATCH] D125269: [OpenMP] Add mangling support for linear modifiers (ref, uval, val)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a02519bc504: [OpenMP] Add mangling support for linear modifiers (ref,uval,val) (authored by mikerice). Herald added a project: clang. Herald added a

[clang] 1a02519 - [OpenMP] Add mangling support for linear modifiers (ref,uval,val)

Author: Mike Rice Date: 2022-05-10T09:56:55-07:00 New Revision: 1a02519bc504a12a12ba875db29c9e5901ed9bef URL: https://github.com/llvm/llvm-project/commit/1a02519bc504a12a12ba875db29c9e5901ed9bef DIFF: https://github.com/llvm/llvm-project/commit/1a02519bc504a12a12ba875db29c9e5901ed9bef.diff LOG

[PATCH] D125078: Implement a feature to show line numbers in diagnostics

ken-matsui added a comment. Thank you :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125078/new/ https://reviews.llvm.org/D125078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D125228: [clangd] Support for standard inlayHint protocol

kadircet updated this revision to Diff 428413. kadircet added a comment. - Default initialize paddingLeft/Right - Don't serialize kind when its null - Run in vscode, seems to be working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125228/new/ htt

[PATCH] D124702: [MSVC] Add support for pragma function

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1070 +SourceLocation Loc, const llvm::SmallSetVector &Intrinsics) { + if (!CurContext->getRedeclContext()->isFileContext()) { +Diag(Loc, diag::err_pragma_intrinsic_function_scope); -

  1   2   3   >