[PATCH] D124339: [NFC][Clang][Pragma] Remove unused variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGae76eb32a598: [NFC][Clang][Pragma] Remove unused variables (authored by zsrkmyn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124339/new/ https://reviews.

[clang] ae76eb3 - [NFC][Clang][Pragma] Remove unused variables

Author: Senran Zhang Date: 2022-04-24T14:50:59+08:00 New Revision: ae76eb32a5988c1f4ebb07e7e5eb9de2b036e194 URL: https://github.com/llvm/llvm-project/commit/ae76eb32a5988c1f4ebb07e7e5eb9de2b036e194 DIFF: https://github.com/llvm/llvm-project/commit/ae76eb32a5988c1f4ebb07e7e5eb9de2b036e194.diff

[PATCH] D124339: [NFC][Clang][Pragma] Remove unused variables

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124339/new/ https://reviews.llvm.org/D124339 ___ c

[PATCH] D124339: [NFC][Clang][Pragma] Remove unused variables

zsrkmyn created this revision. Herald added a project: All. zsrkmyn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124339 Files: clang/lib/Lex/Pragma.cpp Index: clang/li

[clang] afa20af - Reverting accidental git-revert commits.

Author: Nick Kreeger Date: 2022-04-23T20:12:15-05:00 New Revision: afa20aff6ef009889f9b75a2412fea09940eaf61 URL: https://github.com/llvm/llvm-project/commit/afa20aff6ef009889f9b75a2412fea09940eaf61 DIFF: https://github.com/llvm/llvm-project/commit/afa20aff6ef009889f9b75a2412fea09940eaf61.diff

[clang] 2d80889 - Reverting accidental git-revert commits.

Author: Nick Kreeger Date: 2022-04-23T20:11:58-05:00 New Revision: 2d80889b2a9ea693355e4d3e617287591a7f573c URL: https://github.com/llvm/llvm-project/commit/2d80889b2a9ea693355e4d3e617287591a7f573c DIFF: https://github.com/llvm/llvm-project/commit/2d80889b2a9ea693355e4d3e617287591a7f573c.diff

[clang] d1b73f3 - Reverting accidental git-revert commits.

Author: Nick Kreeger Date: 2022-04-23T20:11:27-05:00 New Revision: d1b73f3412b389e2e515ee5ce9ec87c127ebcb01 URL: https://github.com/llvm/llvm-project/commit/d1b73f3412b389e2e515ee5ce9ec87c127ebcb01 DIFF: https://github.com/llvm/llvm-project/commit/d1b73f3412b389e2e515ee5ce9ec87c127ebcb01.diff

[clang] cfc2c59 - Revert "Revert "Revert "[Concepts] Fix overload resolution bug with constrained candidates"""

Author: Nick Kreeger Date: 2022-04-23T19:36:51-05:00 New Revision: cfc2c5905ec11a501cdfc9502f503ab494c200b6 URL: https://github.com/llvm/llvm-project/commit/cfc2c5905ec11a501cdfc9502f503ab494c200b6 DIFF: https://github.com/llvm/llvm-project/commit/cfc2c5905ec11a501cdfc9502f503ab494c200b6.diff

[clang] a0636b5 - Revert "Revert "[Concepts] Fix overload resolution bug with constrained candidates""

Author: Nick Kreeger Date: 2022-04-23T19:35:50-05:00 New Revision: a0636b5855f5ba1f7033670dc32c956d63baaa51 URL: https://github.com/llvm/llvm-project/commit/a0636b5855f5ba1f7033670dc32c956d63baaa51 DIFF: https://github.com/llvm/llvm-project/commit/a0636b5855f5ba1f7033670dc32c956d63baaa51.diff

[clang] f6af446 - Revert "[Concepts] Fix overload resolution bug with constrained candidates"

Author: Nick Kreeger Date: 2022-04-23T19:35:41-05:00 New Revision: f6af446b6625657b1b9046273f5b33bc1173a97c URL: https://github.com/llvm/llvm-project/commit/f6af446b6625657b1b9046273f5b33bc1173a97c DIFF: https://github.com/llvm/llvm-project/commit/f6af446b6625657b1b9046273f5b33bc1173a97c.diff

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

StailGot added a comment. In D124260#3468773 , @HazardyKnusperkeks wrote: > Hi, > > could you please reupload your patch with the full diff context? And please > add a regression test. Done! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12426

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

StailGot updated this revision to Diff 424754. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 Files: clang/lib/Format/WhitespaceManager.cpp clang/unittests/Format/FormatTestComments.cpp Index: clang/unittests/Format/FormatTestComments.cpp

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 424752. vabridgers added a comment. add back amdgcn cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst clang/include

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG807e418413a0: [Concepts] Fix overload resolution bug with constrained candidates (authored by royjacobson). Repository: rG LLVM Github Monorepo C

[clang] 807e418 - [Concepts] Fix overload resolution bug with constrained candidates

Author: Roy Jacobson Date: 2022-04-23T17:24:59-04:00 New Revision: 807e418413a0958ad1ea862093fb262673b2afa1 URL: https://github.com/llvm/llvm-project/commit/807e418413a0958ad1ea862093fb262673b2afa1 DIFF: https://github.com/llvm/llvm-project/commit/807e418413a0958ad1ea862093fb262673b2afa1.diff

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

StailGot updated this revision to Diff 424749. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 Files: clang/lib/Format/WhitespaceManager.cpp Index: clang/lib/Format/WhitespaceManager.cpp ==

[PATCH] D123182: [Concepts] Fix overload resolution bug with constrained candidates

royjacobson updated this revision to Diff 424747. royjacobson added a comment. Rebase after fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123182/new/ https://reviews.llvm.org/D123182 Files: clang/docs/ReleaseNotes.rst clang/include/clang/

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG5114db933dbf: [analyzer] Clean checker options from bool to DefaultBool (NFC) (authored by vabridgers, committed by einvbri ). Repository: rG LLVM Github Monorepo CHANGE

[clang] 5114db9 - [analyzer] Clean checker options from bool to DefaultBool (NFC)

Author: Vince Bridgers Date: 2022-04-23T14:47:29-05:00 New Revision: 5114db933dbf2507d613e50372aa62a1108f830c URL: https://github.com/llvm/llvm-project/commit/5114db933dbf2507d613e50372aa62a1108f830c DIFF: https://github.com/llvm/llvm-project/commit/5114db933dbf2507d613e50372aa62a1108f830c.diff

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

MaskRay closed this revision. MaskRay added a comment. a749e3295df4aee18a0ad723875a6501f30ac744 pushed by Aaron does not have a `Differential Revision:` line. Manual closing. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3402469 , @aaron.ballman wrote: > In D121078#3400810 , @SimplyDanny > wrote: > >> @tonic, can you please have another look? > > If @tonic has any additional feedback, we can han

[PATCH] D124292: [OpenMP] Use CUDA's non-RDC mode when LTO has whole program visibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3530c35c6609: [OpenMP] Use CUDA's non-RDC mode when LTO has whole program visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo C

[clang] 3530c35 - [OpenMP] Use CUDA's non-RDC mode when LTO has whole program visibility

Author: Joseph Huber Date: 2022-04-23T12:42:40-04:00 New Revision: 3530c35c660919b9367f1ac598abfb9a569e7606 URL: https://github.com/llvm/llvm-project/commit/3530c35c660919b9367f1ac598abfb9a569e7606 DIFF: https://github.com/llvm/llvm-project/commit/3530c35c660919b9367f1ac598abfb9a569e7606.diff

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Good stuff. Update the summary and title, and I think good to go. In addition to this, we should do something similar with the rest of the checker options and initialize them at the declar

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. Should we use PrintingPolicy.Indentation instead of 4 hardcoded in dumpRecord? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122920/new/ https://reviews.llvm.org/D122920 ___ cfe-

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

yihanaa added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:420 +auto *FD = IFD ? IFD->getAnonField() : dyn_cast(D); +if (!FD || (FD->isUnnamedBitfield() || FD->isAnonymousStructOrUnion())) + continue; erichkeane wrote: > rsmith wrote:

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

vabridgers added a comment. Hi @steakhal, I believe I've addressed the comments. Please have a look and let me know if this is what you were after. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123464/new/ https://reviews.llvm.org/D123464 _

[clang] 38822b9 - Revert "[clang] Adding Platform/Architecture Specific Resource Header Installation Targets"

Author: Ye Luo Date: 2022-04-23T09:32:53-05:00 New Revision: 38822b98fa3b9d740b9a68b0de34296205d20819 URL: https://github.com/llvm/llvm-project/commit/38822b98fa3b9d740b9a68b0de34296205d20819 DIFF: https://github.com/llvm/llvm-project/commit/38822b98fa3b9d740b9a68b0de34296205d20819.diff LOG: R

[PATCH] D123464: [analyzer] Clean checker options from bool to DefaultBool (NFC)

vabridgers updated this revision to Diff 424720. vabridgers added a comment. refactor patch to remove DefaultBool, replace with bool as suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123464/new/ https://reviews.llvm.org/D123464 Files: c

[PATCH] D123498: [clang] Adding Platform/Architecture Specific Resource Header Installation Targets

ye-luo added a comment. See https://github.com/llvm/llvm-project/issues/55002 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123498/new/ https://reviews.llvm.org/D123498 ___ cfe-commits mailing list cfe-c

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa updated this revision to Diff 424718. yihanaa added a comment. Optimize the code according to @ rsmith's suggestion, and use analyze_printf::PrintfSpecifier::fixType instead of this static DenseMap to find the printf format specifier. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121591: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9dc9b21488ee: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing… (authored by iains). Repository: rG LLVM Github Monore

[clang] 9dc9b21 - [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

Author: Iain Sandoe Date: 2022-04-23T14:43:07+01:00 New Revision: 9dc9b21488ee2bbf54e20807585a74a17a33fceb URL: https://github.com/llvm/llvm-project/commit/9dc9b21488ee2bbf54e20807585a74a17a33fceb DIFF: https://github.com/llvm/llvm-project/commit/9dc9b21488ee2bbf54e20807585a74a17a33fceb.diff L

[PATCH] D124258: [C89/C2x] Change the behavior of implicit int diagnostics

aaron.ballman added a comment. Precommit CI failures are down to just clang-format related ones. However, as with the implicit function declaration diagnostic, I expect there to be a long tail of failing tests which aren't caught by me locally or by the precommit CI bots. My plan is to track th

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2046-2048 static llvm::Value *dumpRecord(CodeGenFunction &CGF, QualType RType, LValue RecordLV, CharUnits Align, + bool dumpTypeName, llvm::Fu

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers marked an inline comment as done. vabridgers added a comment. I believe all comments have been addressed. After discussion with @steakhal, we're leaning towards removing the DefaultBool class and refactoring in favor of the language native bool type - mainly because DefaultBool doesn'

[PATCH] D122841: [analyzer] Add option for AddrSpace in core.NullDereference check

vabridgers updated this revision to Diff 424711. vabridgers added a comment. Update test cases, address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122841/new/ https://reviews.llvm.org/D122841 Files: clang/docs/analyzer/checkers.rst

[PATCH] D115103: Leak Sanitizer port to Windows

clemenswasser updated this revision to Diff 424702. clemenswasser added a comment. I have now split the lsan TestCases chages into https://reviews.llvm.org/D124322 and managed to get the lsan+asan TestCases nearly to work. The current problem is, that during the start of the `RunThread` in `StopT

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5996306c24ba: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++… (authored by iains). Repository: rG LLVM Github Monor

[clang] 5996306 - [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

Author: Iain Sandoe Date: 2022-04-23T09:50:31+01:00 New Revision: 5996306c24badac0e04c1cead1aed4b106a3bdae URL: https://github.com/llvm/llvm-project/commit/5996306c24badac0e04c1cead1aed4b106a3bdae DIFF: https://github.com/llvm/llvm-project/commit/5996306c24badac0e04c1cead1aed4b106a3bdae.diff L

[PATCH] D124320: [clang-tidy] Add createChecks method that also checks for LangaugeOptions

njames93 updated this revision to Diff 424694. njames93 added a comment. Remove unnecessary copy of LanguageOptions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124320/new/ https://reviews.llvm.org/D124320 Files: clang-tools-extra/clang-tidy/C

[PATCH] D124320: [clang-tidy] Add createChecks method that also checks for LangaugeOptions

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman, xazax.hun. Herald added a project: All. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber

[PATCH] D123787: [clang][OpenMP][DebugInfo] Debug support for TLS variables when present in OpenMP consructs

This revision was automatically updated to reflect the committed changes. Closed by commit rGa48300aee570: [clang][OpenMP][DebugInfo] Debug support for TLS variables present in OpenMP… (authored by alok). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] a48300a - [clang][OpenMP][DebugInfo] Debug support for TLS variables present in OpenMP consruct

Author: Alok Kumar Sharma Date: 2022-04-23T12:29:32+05:30 New Revision: a48300aee570f8eea4ec0b03e2d176aab648afb0 URL: https://github.com/llvm/llvm-project/commit/a48300aee570f8eea4ec0b03e2d176aab648afb0 DIFF: https://github.com/llvm/llvm-project/commit/a48300aee570f8eea4ec0b03e2d176aab648afb0.d