[clang] da62a5c - [Driver][test] Clean up riscv* tests

Author: Fangrui Song Date: 2022-03-25T23:59:31-07:00 New Revision: da62a5c6610dd2087ce2f527ca84ba43e93d5e30 URL: https://github.com/llvm/llvm-project/commit/da62a5c6610dd2087ce2f527ca84ba43e93d5e30 DIFF: https://github.com/llvm/llvm-project/commit/da62a5c6610dd2087ce2f527ca84ba43e93d5e30.diff

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:764 CmdArgs.push_back(MArchName.data()); +if (!Args.hasFlag(options::OPT_mrelax, options::OPT_mno_relax)) + CmdArgs.push_back("-mno-relax"); Avoid using the error-prone d

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan added a comment. @jrtc27, @kito-cheng Do you have any other comments ? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 ___ cfe-commits mailing lis

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 418379. StephenFan added a comment. Herald added a subscriber: MaskRay. Grammatical fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/T

[PATCH] D122460: [clang] fixed bug #54406

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:690 +// int n = a.B::m; +if (BaseExpr && isa(DC) && isa(RDecl)) { + CXXRecordDecl *SRecord = cast(DC)->getCanonicalDecl(); We don't generally cite bug numbers in the source

[clang] 392bb8c - [OpenMP] Fix AMDGPU globals test

Author: Joseph Huber Date: 2022-03-25T23:05:41-04:00 New Revision: 392bb8cf1f726207fd994b400f6bc38cb4757a05 URL: https://github.com/llvm/llvm-project/commit/392bb8cf1f726207fd994b400f6bc38cb4757a05 DIFF: https://github.com/llvm/llvm-project/commit/392bb8cf1f726207fd994b400f6bc38cb4757a05.diff

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d3550c51733: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c6d32ec6cdb: [OpenMP] Make Ctor / Dtor functions have external visibility (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 9d3550c - [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

Author: Joseph Huber Date: 2022-03-25T22:44:20-04:00 New Revision: 9d3550c5173373305c10a5a471a935be205191a2 URL: https://github.com/llvm/llvm-project/commit/9d3550c5173373305c10a5a471a935be205191a2 DIFF: https://github.com/llvm/llvm-project/commit/9d3550c5173373305c10a5a471a935be205191a2.diff

[clang] 3c6d32e - [OpenMP] Make Ctor / Dtor functions have external visibility

Author: Joseph Huber Date: 2022-03-25T22:44:17-04:00 New Revision: 3c6d32ec6cdb426d531e0a3b3aa4449ff6e4d75c URL: https://github.com/llvm/llvm-project/commit/3c6d32ec6cdb426d531e0a3b3aa4449ff6e4d75c DIFF: https://github.com/llvm/llvm-project/commit/3c6d32ec6cdb426d531e0a3b3aa4449ff6e4d75c.diff

[PATCH] D122519: [AIX] XFAIL test for lack of visibility support

Jake-Egan updated this revision to Diff 418369. Jake-Egan added a comment. Updated the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122519/new/ https://reviews.llvm.org/D122519 Files: clang/test/OpenMP/target_update_messages.cpp Inde

[PATCH] D122519: [AIX] XFAIL test for lack of visibility support

Jake-Egan created this revision. Herald added a project: All. Jake-Egan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122519 Files: clang/test/OpenMP/target_update_messag

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jhuber6 updated this revision to Diff 418365. jhuber6 added a comment. Fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122515/new/ https://reviews.llvm.org/D122515 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/amdgcn_ta

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. Herald added a subscriber: MaskRay. ping ... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

gulfem added a comment. @davidxl, I added comments in https://github.com/llvm/llvm-project/commit/ead8586645f54de16cfc6fa26028d818efc425f2 @MaskRay, I followed the style guide for nested if statements in https://github.com/llvm/llvm-project/commit/ead8586645f54de16cfc6fa26028d818efc425f2 Repo

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

NoQ added a comment. Why doesn't the AST handle this for us through implicit casts? Do we really need to duplicate type promotion logic in the static analyzer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122513/new/ https://reviews.llvm.org/D122

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

This revision was automatically updated to reflect the committed changes. Closed by commit rG34b9b1ea4874: Disable -Wmissing-prototypes for internal linkage functions that aren't… (authored by dblaikie). Changed prior to commit: https://reviews.llvm.org/D121328?vs=417989&id=418360#toc Reposito

[clang] 34b9b1e - Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"

Author: David Blaikie Date: 2022-03-25T23:53:19Z New Revision: 34b9b1ea4874b109b998d59a837f81f2f730001c URL: https://github.com/llvm/llvm-project/commit/34b9b1ea4874b109b998d59a837f81f2f730001c DIFF: https://github.com/llvm/llvm-project/commit/34b9b1ea4874b109b998d59a837f81f2f730001c.diff LOG:

[PATCH] D23934: Add a -ffixed-date-time= flag that sets the initial value of __DATE__, __TIME__, __TIMESTAMP__

appcs added a comment. In D23934#3314277 , @appcs wrote: > Hello, Will this feature be committed? Thanks! In D23934#3355355 , @emaste wrote: > The original author appears to have given up on it. Someone will nee

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 418356. void marked 2 inline comments as done. void added a comment. Move casting check into the SemaCast where it belongs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D12155

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jhuber6 updated this revision to Diff 418355. jhuber6 added a comment. Remove leftover code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122515/new/ https://reviews.llvm.org/D122515 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/Ope

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122515/new/ https://reviews.llvm.org/D122515 ___

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jhuber6 updated this revision to Diff 418354. jhuber6 added a comment. Making test better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122515/new/ https://reviews.llvm.org/D122515 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenM

[clang-tools-extra] 16eaa52 - [pseudo] Fix the wrong rule ids in ForestTest.

Author: Haojian Wu Date: 2022-03-26T00:05:37+01:00 New Revision: 16eaa5240e30af36a91db387df3c2e83e742 URL: https://github.com/llvm/llvm-project/commit/16eaa5240e30af36a91db387df3c2e83e742 DIFF: https://github.com/llvm/llvm-project/commit/16eaa5240e30af36a91db387df3c2e83e742.diff LO

[clang-tools-extra] 41e69fb - [pseudo] Add missing header guard for Forest.h

Author: Haojian Wu Date: 2022-03-25T23:51:19+01:00 New Revision: 41e69fb2453505bd42f5a6bc15369b50adebeac4 URL: https://github.com/llvm/llvm-project/commit/41e69fb2453505bd42f5a6bc15369b50adebeac4 DIFF: https://github.com/llvm/llvm-project/commit/41e69fb2453505bd42f5a6bc15369b50adebeac4.diff LO

[PATCH] D122515: [OpenMP] Add AMDGPU calling convention to ctor / dtor functions

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ronlieb. Herald added subscribers: guansong, t-tye, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: openm

[PATCH] D122513: [analyzer] Fix "RhsLoc and LhsLoc bitwidth must be same"

vabridgers created this revision. vabridgers added reviewers: NoQ, steakhal, martong. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. vabridgers requested review

[PATCH] D120956: [clang][AST matchers] new AST matcher argumentsGivenCountIs(n) that checks the actual number of arguments given in a function call

ajohnson-uoregon updated this revision to Diff 418346. ajohnson-uoregon added a comment. Fixing name of matcher and formatting, still need tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120956/new/ https://reviews.llvm.org/D120956 Files: cl

[PATCH] D122511: [clang][extract-api] Add Objective-C protocol support

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add support for Objective-C protocol declarations in ExtractAPI. Depends on D122446

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw updated this revision to Diff 418342. zixuw added a comment. No code change, amend commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122446/new/ https://reviews.llvm.org/D122446 Files: clang/include/clang/ExtractAPI/API.h cla

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 418341. ajohnson-uoregon added a comment. updating commit message of last commit to be more accurate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files:

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 418338. ajohnson-uoregon added a comment. I overloaded hasAttr and had to fix a couple CUDA tests to explicitly use the decl overload (the other tests for hasAttr did this already, so I think it was just a mistake in those tests). I also had to rem

[PATCH] D122508: [clang][NFC] Remove unused parameter in `Sema::ActOnDuplicateDefinition`.

vsapsai created this revision. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D122508 Files: clang

[clang] afaefb6 - [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

Author: Fangrui Song Date: 2022-03-25T14:56:18-07:00 New Revision: afaefb671fe12e7788d3e8de6b6193b935fbf16c URL: https://github.com/llvm/llvm-project/commit/afaefb671fe12e7788d3e8de6b6193b935fbf16c DIFF: https://github.com/llvm/llvm-project/commit/afaefb671fe12e7788d3e8de6b6193b935fbf16c.diff

[PATCH] D122444: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for LLVM_ENABLE_RUNTIMES builds

This revision was automatically updated to reflect the committed changes. MaskRay marked an inline comment as done. Closed by commit rGafaefb671fe1: [Driver][Linux] Remove D.Dir+"/../lib" from default search paths for… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 418328. paulkirth added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files: clang/docs/MisExpect.rst clang/docs/ReleaseNotes.rst clang/in

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 added a comment. In D122504#3408947 , @JonChesterfield wrote: > Nice, thanks. Wonder if we want protected visibility as well. I'm not actually sure what having protected visibility would do considering it's not applied with `-fvisibility=protec

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice, thanks. Wonder if we want protected visibility as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122504/new/ https:

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 updated this revision to Diff 418321. jhuber6 added a comment. Herald added a subscriber: jvesely. Changing approach, we should optionally use internal linkage for the ctor creation function since it's not correct to add the internal linkage attributes and then make it external. Also remov

[clang] bb9bdef - [Clang] Use pattern to match profile metadata in test.

Author: Florian Hahn Date: 2022-03-25T21:05:58Z New Revision: bb9bdef4df8a9db4f9ff4ed340cf59948f2145c7 URL: https://github.com/llvm/llvm-project/commit/bb9bdef4df8a9db4f9ff4ed340cf59948f2145c7 DIFF: https://github.com/llvm/llvm-project/commit/bb9bdef4df8a9db4f9ff4ed340cf59948f2145c7.diff LOG:

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:279 + cast_or_null(Env.getValue(*ComparisonExprLoc))) { +Env.setValue(*ComparisonExprLoc, + Env.makeAnd(*CurrentValue, Comparis

[PATCH] D122497: [clang][tests][NFC] Add filescope array initialization test

AaronLiu accepted this revision. AaronLiu added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122497/new/ https://reviews.llvm.org/D122497 __

[PATCH] D122504: [OpenMP] Make Ctor / Dtor functions have external visibility

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, JonChesterfield, ronlieb, ABataev. Herald added subscribers: asavonic, guansong, tpr, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a pr

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

li.zhe.hua marked 2 inline comments as done. li.zhe.hua added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:126-128 +template +std::enable_if_t::value, void> +assertMetadataSet(const transformer::RewriteRuleWith &) {} ymandel

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

li.zhe.hua updated this revision to Diff 418316. li.zhe.hua added a comment. Fix for comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122499/new/ https://reviews.llvm.org/D122499 Files: clang/include/clang/Tooling/Transformer/Transformer.

[PATCH] D122502: [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct

This revision was automatically updated to reflect the committed changes. Closed by commit rG89525cbf283f: [Clang] Add helper method to determine if a nonvirtual base has an entry in the… (authored by wsmoses). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 89525cb - [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct

Author: William S. Moses Date: 2022-03-25T16:32:12-04:00 New Revision: 89525cbf283f1ffeca1e007a06b29917a9eadc53 URL: https://github.com/llvm/llvm-project/commit/89525cbf283f1ffeca1e007a06b29917a9eadc53 DIFF: https://github.com/llvm/llvm-project/commit/89525cbf283f1ffeca1e007a06b29917a9eadc53.di

[PATCH] D122502: [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122502/new/ https://reviews.llvm.org/D122502 ___

[PATCH] D122503: Remove dead code in driver parsing -gsimple-template-names= options

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6aa039775891: Remove dead code in driver parsing -gsimple-template-names= options (authored by probinson). Herald added a project: clang. Repository

[clang] 6aa0397 - Remove dead code in driver parsing -gsimple-template-names= options

Author: Paul Robinson Date: 2022-03-25T13:23:24-07:00 New Revision: 6aa039775891b6eae81604bb851e72192f5a7462 URL: https://github.com/llvm/llvm-project/commit/6aa039775891b6eae81604bb851e72192f5a7462 DIFF: https://github.com/llvm/llvm-project/commit/6aa039775891b6eae81604bb851e72192f5a7462.diff

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:295 +// atom. +BoolValue &OptionalHoldsEmptyString = Env.makeAtomicBoolValue(); +return Env.makeOr(Env.makeAnd(HasValueVal, OptionalHolds

[PATCH] D122503: Remove dead code in driver parsing -gsimple-template-names= options

probinson added a subscriber: cfe-commits. probinson added a comment. +cfe-commits; that should have happened automatically? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122503/new/ https://reviews.llvm.org/D122503 ___ cfe-commits mailing li

[PATCH] D121556: [randstruct] Add randomize structure layout support

void added inline comments. Comment at: clang/include/clang/AST/Decl.h:2842 mutable unsigned CachedFieldIndex : 30; + mutable unsigned OriginalFieldIndex : 30; aaron.ballman wrote: > It's unfortunate that every field node in the AST is now going to be 4 byt

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 418307. void marked 5 inline comments as done. void added a comment. Add "err_" prefix to error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: clang/i

[PATCH] D122502: [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct

wsmoses added a comment. Polygeist is a (hopefully soon to be LLVM incubator project: https://discourse.llvm.org/t/rfc-polygeist-llvm-incubator-proposal/60890), that, among other things, is a Clang-based C/C++ frontend for MLIR. As such, we kind of expect to be built alongside clang and borrow

[PATCH] D122258: [MC][RFC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. I'm currently working on the eh_frame support in LLD itself, but will circle back to this diff in a week or so. Thanks for the feedback! Comment at: clang/unittests/Interpreter/ExceptionTests/InterpreterExceptionTest.cpp:48 +// FIXME TEST(InterpreterT

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:279 + cast_or_null(Env.getValue(*ComparisonExprLoc))) { +Env.setValue(*ComparisonExprLoc, + Env.makeAnd(*CurrentValue, Compar

[PATCH] D122502: [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct

efriedma added a comment. I'm not against this, I guess... but clang/lib/CodeGen/CGRecordLayout.h isn't an installed header; it's not clear to me how you're using this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122502/new/ https://reviews.llvm

[PATCH] D121556: [randstruct] Add randomize structure layout support

void updated this revision to Diff 418305. void added a comment. Herald added a subscriber: MaskRay. Fix how the command line flags are handled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121556/new/ https://reviews.llvm.org/D121556 Files: cl

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue &ComparisonValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = ymandel wrote: > xazax.hun wrote: > >

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue &ComparisonValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = xazax.hun wrote: > xazax.hun wrote: >

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue &ComparisonValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = xazax.hun wrote: > ymandel wrote: >

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:307 + [](Environment &Env, BoolValue &HasValueVal) -> BoolValue & { +// We can't reason about general vlaues, so we encode the constraint on +

[PATCH] D121951: [AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5

yaxunl added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9381 + M.getTarget().getTargetOpts().CodeObjectVersion != 500) { +F->addFnAttr("amdgpu-no-hostcall-ptr"); + } scott.linder wrote: > arsenm wrote: > > sameerds wrote: > > > The fr

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue &ComparisonValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc = ymandel wrote: > xazax.hun wrote: >

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Transformer/Transformer.h:126-128 +template +std::enable_if_t::value, void> +assertMetadataSet(const transformer::RewriteRuleWi

[PATCH] D122179: Serialize PragmaAssumeNonNullLoc to support preambles

dgoldman updated this revision to Diff 418301. dgoldman added a comment. Revert comment change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122179/new/ https://reviews.llvm.org/D122179 Files: clang-tools-extra/clangd/unittests/DiagnosticsTests.

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

ymandel marked 3 inline comments as done. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:270 + // needed. + BoolValue &ComparisonValue = MakeValue(Env, *HasValueVal); + auto *ComparisonExprLoc =

[PATCH] D122502: [Clang] Add helper method to determine if a nonvirtual base has an entry in the LLVM struct

wsmoses created this revision. wsmoses added reviewers: jdoerfert, ftynse, eli.friedman, stuij, ostannard. Herald added a project: All. wsmoses requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds a helper method to determine if

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

li.zhe.hua updated this revision to Diff 418295. li.zhe.hua added a comment. Fix comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122499/new/ https://reviews.llvm.org/D122499 Files: clang/include/clang/Tooling/Transformer/Transformer.h c

[clang-tools-extra] 9a3eeae - [clang-tidy] Fix the condition for building CTTestTidyModule

Author: Martin Storsjö Date: 2022-03-25T21:22:46+02:00 New Revision: 9a3eeae3218f0f8a082d8aabdf4f26e30a86170d URL: https://github.com/llvm/llvm-project/commit/9a3eeae3218f0f8a082d8aabdf4f26e30a86170d DIFF: https://github.com/llvm/llvm-project/commit/9a3eeae3218f0f8a082d8aabdf4f26e30a86170d.diff

[clang] 57ee624 - [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

Author: Sam McCall Date: 2022-03-25T20:22:01+01:00 New Revision: 57ee624d7946b4d42890709287eb71d4eb1fa2fa URL: https://github.com/llvm/llvm-project/commit/57ee624d7946b4d42890709287eb71d4eb1fa2fa DIFF: https://github.com/llvm/llvm-project/commit/57ee624d7946b4d42890709287eb71d4eb1fa2fa.diff LO

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57ee624d7946: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR (authored by sammccall). Repository: rG LLVM Github Monorepo

[clang-tools-extra] 57ee624 - [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

Author: Sam McCall Date: 2022-03-25T20:22:01+01:00 New Revision: 57ee624d7946b4d42890709287eb71d4eb1fa2fa URL: https://github.com/llvm/llvm-project/commit/57ee624d7946b4d42890709287eb71d4eb1fa2fa DIFF: https://github.com/llvm/llvm-project/commit/57ee624d7946b4d42890709287eb71d4eb1fa2fa.diff LO

[PATCH] D122499: [libTooling] Support TransformerResult in consumer callbacks

li.zhe.hua created this revision. li.zhe.hua added a reviewer: ymandel. Herald added a project: All. li.zhe.hua requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Support `TransformerResult` in the consumer callback, which allows generic code

[PATCH] D122496: [C11] Correct the resulting type for an assignment expression

cor3ntin accepted this revision. cor3ntin added a comment. Beside maybe a comment that could help understanding, I think this looks good! Comment at: clang/lib/Sema/SemaExpr.cpp:13647 // operand. - return (getLangOpts().CPlusPlus - ? LHSType : LHSType.getUnqualifie

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

mstorsjo added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:84 if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) - llvm_add_library( - CTTestTidyModule - MODULE clang-tidy/CTTestTidyModule.cpp - PLUGIN_TOOL clang-tidy - DEPENDS clang-tidy-headers) +

[PATCH] D122497: [clang][NFC] Add filescope array initialization test

cebowleratibm created this revision. cebowleratibm added a reviewer: AaronLiu. cebowleratibm added a project: clang. Herald added a project: All. cebowleratibm requested review of this revision. Herald added a subscriber: cfe-commits. This test is based on a customer-reported failure in an XL comp

[PATCH] D122496: [C11] Correct the resulting type for an assignment expression

aaron.ballman created this revision. aaron.ballman added reviewers: eli.friedman, jyknight, erichkeane, clang-language-wg. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. In C, assignment expressions result in an rvalue whose type is th

[PATCH] D121687: [clang-tidy] Don't try to build CTTestTidyModule for Windows with dylibs

jeremyd2019 added inline comments. Comment at: clang-tools-extra/test/CMakeLists.txt:84 if (NOT LLVM_INSTALL_TOOLCHAIN_ONLY) - llvm_add_library( - CTTestTidyModule - MODULE clang-tidy/CTTestTidyModule.cpp - PLUGIN_TOOL clang-tidy - DEPENDS clang-tidy-headers

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

dyung added a comment. I've reverted this change in order to get the build bots green again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117522/new/ https://reviews.llvm.org/D117522 ___ cfe-commits mai

[clang-tools-extra] cef5210 - Revert "[clang-tidy] Add modernize-macro-to-enum check"

Author: Douglas Yung Date: 2022-03-25T11:53:42-07:00 New Revision: cef52105bd4b639a76de71cc84ed8d56bdaede1d URL: https://github.com/llvm/llvm-project/commit/cef52105bd4b639a76de71cc84ed8d56bdaede1d DIFF: https://github.com/llvm/llvm-project/commit/cef52105bd4b639a76de71cc84ed8d56bdaede1d.diff

[PATCH] D122446: [clang][extract-api] Add Objective-C interface support

zixuw updated this revision to Diff 418286. zixuw added a comment. Move the `Language` fix out into a separate patch: D122495 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122446/new/ https://reviews.llvm.org/D12

[PATCH] D121763: [cmake] Provide CURRENT_TOOLS_DIR centrally, replacing CLANG_TOOLS_DIR

sammccall updated this revision to Diff 418285. sammccall added a comment. Rebase. Also update LLD since it's simple and similar to clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121763/new/ https://reviews.llvm.org/D121763 Files: clang-to

[PATCH] D122495: [clang][extract-api] Use correct language info from inputs

zixuw created this revision. Herald added a reviewer: dang. Herald added a project: All. zixuw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current way of getting the `clang::Language` from `LangOptions` does not handle Objective-C c

[PATCH] D122336: [InstrProfiling] No runtime hook for unused funcs

davidxl added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:569 + if (!containsProfilingIntrinsics(M)) { +if (!CoverageNamesVar || !NeedsRuntimeHook) { + return MadeChange; gulfem wrote: > MaskRay wrote: > > https:/

[clang] 26e201b - [Clang] Fix error in Documentation introduced by 3784e8cc [nfc].

Author: Corentin Jabot Date: 2022-03-25T19:38:36+01:00 New Revision: 26e201b7968cf12e603ef648d1be660bb23f3a08 URL: https://github.com/llvm/llvm-project/commit/26e201b7968cf12e603ef648d1be660bb23f3a08 DIFF: https://github.com/llvm/llvm-project/commit/26e201b7968cf12e603ef648d1be660bb23f3a08.diff

[PATCH] D122231: [clang][dataflow] Add support for `value_or` in a comparison.

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:142 + // `opt.value_or(nullptr) != nullptr` and `opt.value_or(0) != 0`. Ideally, + // we'd support this pattern for any expression, but the AST does not have a

[PATCH] D122494: Do not treat use of variable from attribute arguments as ODR use

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Attribute arguments are always compile-time expressions that need to be evaluated. So, it is not necessary to treat attr

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

paulkirth updated this revision to Diff 418280. paulkirth added a comment. Fix check for tolerance diagnostic since we now use GenerateArgs the same way as hotness threshold. Since it has a default value, we need to also ensure that it uses a pattern similar to other options. Repository: rG

[PATCH] D121532: [Clang] Fix Unevaluated Lambdas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3784e8ccfbda: [Clang] Fix Unevaluated Lambdas (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D121532?vs=418269&id=41827

[clang] 3784e8c - [Clang] Fix Unevaluated Lambdas

Author: Corentin Jabot Date: 2022-03-25T19:16:45+01:00 New Revision: 3784e8ccfbdaaab31f9e9c221daa59a21827 URL: https://github.com/llvm/llvm-project/commit/3784e8ccfbdaaab31f9e9c221daa59a21827 DIFF: https://github.com/llvm/llvm-project/commit/3784e8ccfbdaaab31f9e9c221daa59a21827.diff

[PATCH] D120185: [ASTMatchers] Output currently processing match and nodes on crash

njames93 added a comment. I've landed it and your build bot is happy, there was another failing buildbot so I'll keep an eye on it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120185/new/ https://reviews.llvm.org/D120185 ___

[clang] 171cdba - [Clang, TBAA] Use pattern for metadata reference in test.

Author: Florian Hahn Date: 2022-03-25T18:12:39Z New Revision: 171cdba8674f05bc9b97b6d194911292d4a73731 URL: https://github.com/llvm/llvm-project/commit/171cdba8674f05bc9b97b6d194911292d4a73731 DIFF: https://github.com/llvm/llvm-project/commit/171cdba8674f05bc9b97b6d194911292d4a73731.diff LOG:

[PATCH] D122344: [clang][driver] Disable non-functional --version option for clang -cc1

This revision was automatically updated to reflect the committed changes. Closed by commit rG35b89bc24ca5: [clang][driver] Disable non-functional --version option for clang -cc1 (authored by ekieri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1223

[clang] 35b89bc - [clang][driver] Disable non-functional --version option for clang -cc1

Author: Emil Kieri Date: 2022-03-25T19:04:27+01:00 New Revision: 35b89bc24ca58d5b3a87578f69936afb26ef3b69 URL: https://github.com/llvm/llvm-project/commit/35b89bc24ca58d5b3a87578f69936afb26ef3b69 DIFF: https://github.com/llvm/llvm-project/commit/35b89bc24ca58d5b3a87578f69936afb26ef3b69.diff LO

[PATCH] D121951: [AMDGPU][OpenCL] Add "amdgpu-no-hostcall-ptr" in Clang codegen pre-COV_5

scott.linder added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9381 + M.getTarget().getTargetOpts().CodeObjectVersion != 500) { +F->addFnAttr("amdgpu-no-hostcall-ptr"); + } arsenm wrote: > sameerds wrote: > > The frontend does not need

[PATCH] D122487: [ARM] Make testcase warning pattern match more specific

tstellar accepted this revision. tstellar added a comment. This revision is now accepted and ready to land. In D122487#3408425 , @rs wrote: > @tstellar thanks for the review. I can't really think of any other way to > test this. I'll wait till Monday if

[clang] b97f260 - Reland "[ASTMatchers] Output currently processing match and nodes on crash"

Author: Nathan James Date: 2022-03-25T17:53:58Z New Revision: b97f26083bd04ccbdd63b0c726e047496e5b847a URL: https://github.com/llvm/llvm-project/commit/b97f26083bd04ccbdd63b0c726e047496e5b847a DIFF: https://github.com/llvm/llvm-project/commit/b97f26083bd04ccbdd63b0c726e047496e5b847a.diff LOG:

[PATCH] D121591: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

iains updated this revision to Diff 418274. iains added a comment. Herald added a subscriber: MaskRay. rebased, adjusted testcases to avoid using clang++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121591/new/ https://reviews.llvm.org/D121591 F

  1   2   >