[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song updated this revision to Diff 415326. yonghong-song added a comment. - add one more _Generic test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files: clang/include/clang-c/Index.h cl

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:923 + void initializeLocal(ASTContext &Context, SourceLocation loc) {} + + QualType getInnerType() const { return getTypePtr()->getWrappedType(); } yonghong-song wrote: > aaron.b

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:923 + void initializeLocal(ASTContext &Context, SourceLocation loc) {} + + QualType getInnerType() const { return getTypePtr()->getWrappedType(); } aaron.ballman wrote: > yonghon

[PATCH] D121663: reland: [clang] Don't append the working directory to absolute paths

keith created this revision. keith added a reviewer: aprantl. Herald added a project: All. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a bug that happens when using -fdebug-prefix-map to remap an absolute path to a rela

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 415307. keith added a comment. Fix tests with dwarf 6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGen/re

[PATCH] D119409: [C++20] [Modules] Remain dynamic initializing internal-linkage variables in module interface unit

ChuanqiXu added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119409/new/ https://reviews.llvm.org/D119409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D120397: [C++20] [Modules] Make the linkage consistent for template and its specialization

ChuanqiXu added a subscriber: urnathan. ChuanqiXu added a comment. Oh, @urnathan resigned from all my patches and I don't know why. @iains @dblaikie could you help to review this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 __

[PATCH] D120540: [Driver] Enable to use C++20 modules standalone by -fcxx-modules

ChuanqiXu added a comment. @iains ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120540/new/ https://reviews.llvm.org/D120540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

ChuanqiXu added a comment. @iains ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121271/new/ https://reviews.llvm.org/D121271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

ChuanqiXu marked an inline comment as done. ChuanqiXu added a comment. @iains ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120874/new/ https://reviews.llvm.org/D120874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D121591: [C++20][Modules][Driver][HU 4/N] Add fdirectives-only mode for preprocessing output.

ChuanqiXu added a comment. Oh, I found all the series of patches looks confusing to me. Maybe due to that I lack a use experience with header unit. I really couldn't judge if it is necessary or useful. Could you elaborate more **end** use cases? For example, I could understand the sentence: >

[PATCH] D121658: Use llvm::sys::path::append to fix FIXME

ppluzhnikov abandoned this revision. ppluzhnikov added a comment. Breaks Windows tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121658/new/ https://reviews.llvm.org/D121658 ___ cfe-commits mailing

[PATCH] D121590: [C++20][Modules][Driver][HU 3/N] Handle foo.h with -fmodule-header and/or C++ invocation.

ChuanqiXu added a comment. This looks a little bit odd. Is this consistent with GCC too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121590/new/ https://reviews.llvm.org/D121590 ___ cfe-commits mailing

[PATCH] D121589: [C++20][Modules][Driver][HU 2/N] Add fmodule-header, fmodule-header=

ChuanqiXu added a comment. > It's not practical to recognise a header without any suffix so -fmodule-header=system foo isn't going to happen. May I ask the reason? It looks not so good with `-fmodule-header=system -xc++-header vector` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D121345: [RISCV] Add +experimental-zvfh extension to cover half types in vectors.

khchen added a comment. LGTM. wait @kito-cheng to approve it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121345/new/ https://reviews.llvm.org/D121345 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb22d71806b7: [clang] Fix DIFile directory root on Windows (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.ll

[clang] cb22d71 - [clang] Fix DIFile directory root on Windows

Author: Keith Smiley Date: 2022-03-14T20:07:01-07:00 New Revision: cb22d71806b784a9105803f38b2740ca6888392a URL: https://github.com/llvm/llvm-project/commit/cb22d71806b784a9105803f38b2740ca6888392a DIFF: https://github.com/llvm/llvm-project/commit/cb22d71806b784a9105803f38b2740ca6888392a.diff

[PATCH] D119788: [AArch64] Add support for -march=native for Apple M1 CPU

keith added a comment. Bump, I think I've covered everything here, let me know if not! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119788/new/ https://reviews.llvm.org/D119788 ___ cfe-commits mailing l

[PATCH] D111457: [test] Add lit helper for windows paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6541d3e979c1: [test] Add lit helper for windows paths (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D121588: [C++20][Modules][Driver][HU 1/N] Initial handling for -xc++-{system,user}-header.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Although I don't like these option names, it is more important to keep consistent with GCC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D121661: [WebAssembly] Fix names of SIMD instructions containing '_zero'

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. Herald added a project: All. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers:

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

owenpan added a comment. In D121576#3378934 , @MyDeveloperDay wrote: > I'm wondering if the presence of the comment would impact the CellCount, I > might go back and add some more unit tests for the "non rectangular" change I > made. > > So this fixes

[PATCH] D121659: [CMake][Fuchsia] Use correct architecture for iossim

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b6ff3f4f89e: [CMake][Fuchsia] Use correct architecture for iossim (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 1b6ff3f - [CMake][Fuchsia] Use correct architecture for iossim

Author: Petr Hosek Date: 2022-03-14T19:21:09-07:00 New Revision: 1b6ff3f4f89e06af17575627fba3e6d90d1abbc5 URL: https://github.com/llvm/llvm-project/commit/1b6ff3f4f89e06af17575627fba3e6d90d1abbc5 DIFF: https://github.com/llvm/llvm-project/commit/1b6ff3f4f89e06af17575627fba3e6d90d1abbc5.diff LO

[PATCH] D121576: [clang-format] Don't unwrap lines preceded by line comments

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a0cc3c58a74: [clang-format] Don't unwrap lines preceded by line comments (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121576/new/ h

[clang] 0a0cc3c - [clang-format] Don't unwrap lines preceded by line comments

Author: Owen Pan Date: 2022-03-14T19:16:29-07:00 New Revision: 0a0cc3c58a74f9574d9f4df244e3bd0a8e805945 URL: https://github.com/llvm/llvm-project/commit/0a0cc3c58a74f9574d9f4df244e3bd0a8e805945 DIFF: https://github.com/llvm/llvm-project/commit/0a0cc3c58a74f9574d9f4df244e3bd0a8e805945.diff LOG:

[PATCH] D121550: [clang-format] Fix crash on invalid requires expression

owenpan added a comment. After applying this patch, we got a different assertion failure on a bunch of files in `clang/test`, e.g.: ~/llvm-project/clang$ for f in $(find . -name \*.cpp -o -name \*.c) ; do clang-format $f > /dev/null ; done Assertion failed: (OpeningParen.is(tok::l_paren)),

[PATCH] D121659: [CMake][Fuchsia] Use correct architecture for iossim

phosek created this revision. phosek added reviewers: abrachet, haowei, leonardchan. Herald added subscribers: pengfei, kristof.beyls, mgorny. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We should be

[PATCH] D121658: Use llvm::sys::path::append to fix FIXME

ppluzhnikov created this revision. Herald added a project: All. ppluzhnikov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D121658 Files: clang/lib/Lex/HeaderSearch.cpp I

[clang] f1388b6 - [OpenMP][Fix] Fix test failing after patch

Author: Joseph Huber Date: 2022-03-14T21:51:38-04:00 New Revision: f1388b616ab83b1022cb967ab8a868cf36d83161 URL: https://github.com/llvm/llvm-project/commit/f1388b616ab83b1022cb967ab8a868cf36d83161 DIFF: https://github.com/llvm/llvm-project/commit/f1388b616ab83b1022cb967ab8a868cf36d83161.diff

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

ajohnson-uoregon added a comment. I still need to write tests but: I do have a use case for these over here: https://github.com/ajohnson-uoregon/llvm-project/blob/feature-ajohnson/clang-tools-extra/clang-rewrite/ConstructMatchers.cpp#L472 tl;dr, we'd like to match the kernel launch arguments (i

[clang] 670438e - [OpenMP][Fix] Add offloading kind to AMDGPU libraries

Author: Joseph Huber Date: 2022-03-14T21:18:19-04:00 New Revision: 670438e55dc265dc0b25567e62a6e328d91f30a0 URL: https://github.com/llvm/llvm-project/commit/670438e55dc265dc0b25567e62a6e328d91f30a0 DIFF: https://github.com/llvm/llvm-project/commit/670438e55dc265dc0b25567e62a6e328d91f30a0.diff

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith updated this revision to Diff 415292. keith added a comment. Herald added a project: All. Update subsitutions with slashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llvm.org/D111587 Files: clang/lib/CodeGen/

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith updated this revision to Diff 415291. keith marked an inline comment as done. keith added a comment. Update subsitutions with dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/ https://reviews.llvm.org/D111579 Files: clang/li

[PATCH] D111457: [test] Add lit helper for windows paths

keith updated this revision to Diff 415290. keith added a comment. Update substitutions to use dashes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111457/new/ https://reviews.llvm.org/D111457 Files: llvm/docs/CommandGuide/lit.rst llvm/docs/Te

[PATCH] D120952: [clang][AST matchers] adding submatchers under cudaKernelCallExpr to match kernel launch config

ajohnson-uoregon updated this revision to Diff 415289. ajohnson-uoregon added a comment. fixing clang-format things and adding docs; also making docs a bit more clear Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120952/new/ https://reviews.llvm.or

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yln marked an inline comment as done. Closed by commit rG9c542a5a4e1b: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO (authored by yln). Repository: rG LLV

[clang] 9c542a5 - Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

Author: Julian Lettner Date: 2022-03-14T17:51:18-07:00 New Revision: 9c542a5a4e1ba36c24e48185712779df52b7f7a6 URL: https://github.com/llvm/llvm-project/commit/9c542a5a4e1ba36c24e48185712779df52b7f7a6 DIFF: https://github.com/llvm/llvm-project/commit/9c542a5a4e1ba36c24e48185712779df52b7f7a6.diff

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln marked 2 inline comments as done. yln added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:900 + // __cxa_atexit calls to avoid emitting the deprecated __mod_term_func. + if (TM->getTargetTriple().isOSBinFormatMachO()) +addPass(createLowerGlobalDtors

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

sunfish added a comment. In D121327#3381123 , @yln wrote: > @sunfish > Hi Dan, I hope you are still happy with this change. I didn't change any > WebAssembly tests, but rather added a new IR-level test, so all existing > WebAssembly behavior should st

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon added a comment. (.. I just figured out where the 'submit' button is. My comment on 2713-2714 is from like, 5 days ago. Oops. 🙃 ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2733 +/// \endcode +AST_MATCHER_P(AttributedStmt, isAttr, attr::Kind, AttrKind) { + return llvm::any_of(Node.getAttrs(), aaron.ballman wrote: > sammccall wrote: > >

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln updated this revision to Diff 415282. yln added a comment. Report fatal error when we can, instead of never. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121327/new/ https://reviews.llvm.org/D121327 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D121653: Implement __cpuid intrinsic WIP

ayzhao created this revision. Herald added a subscriber: pengfei. Herald added a project: All. ayzhao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. cpuid implementation complete, still have a cannot compile this function yet WORK IN PROG

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

delcypher added inline comments. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1181 +unsigned Priority, const MCSymbol *KeySym) const { + // TODO(yln): Remove -lower-global-dtors-via-cxa-atexit fallback flag + // (LowerGlobalDtorsViaCxaAtExit) and issue a fa

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln added a comment. @sunfish Hi Dan, I hope you are still happy with this change. I didn't change any WebAssembly tests, but rather added a new IR-level test, so all existing WebAssembly behavior should stay the same. Let me know if you have any concerns. Repository: rG LLVM Github Mono

[PATCH] D120934: [OpenMP][NFC] Refactor new driver to be more general

This revision was automatically updated to reflect the committed changes. Closed by commit rG23d885b3a2e8: [OpenMP][NFC] Refactor new driver to be more general (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120934/new/ https://

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f89769cd775: [Clang] Add offload kind to embedded offload object (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D120288: [OpenMP] Implement dense map info for device file

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG06b336c4cd2c: [OpenMP] Implement dense map info for device file (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D120270: [OpenMP] Try to embed offloading objects after codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rG806bbc49dc07: [OpenMP] Try to embed offloading objects after codegen (authored by jhuber6). Herald added a project: All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 06b336c - [OpenMP] Implement dense map info for device file

Author: Joseph Huber Date: 2022-03-14T20:08:26-04:00 New Revision: 06b336c4cd2c91e0dec877cca1303eddaeb4ef79 URL: https://github.com/llvm/llvm-project/commit/06b336c4cd2c91e0dec877cca1303eddaeb4ef79 DIFF: https://github.com/llvm/llvm-project/commit/06b336c4cd2c91e0dec877cca1303eddaeb4ef79.diff

[clang] 23d885b - [OpenMP][NFC] Refactor new driver to be more general

Author: Joseph Huber Date: 2022-03-14T20:08:29-04:00 New Revision: 23d885b3a2e8a1e0c22cfcbccec410865e7653c9 URL: https://github.com/llvm/llvm-project/commit/23d885b3a2e8a1e0c22cfcbccec410865e7653c9 DIFF: https://github.com/llvm/llvm-project/commit/23d885b3a2e8a1e0c22cfcbccec410865e7653c9.diff

[clang] 9f89769 - [Clang] Add offload kind to embedded offload object

Author: Joseph Huber Date: 2022-03-14T20:08:27-04:00 New Revision: 9f89769cd775ce6dc27cad0fbfdd94bf94bc8f99 URL: https://github.com/llvm/llvm-project/commit/9f89769cd775ce6dc27cad0fbfdd94bf94bc8f99 DIFF: https://github.com/llvm/llvm-project/commit/9f89769cd775ce6dc27cad0fbfdd94bf94bc8f99.diff

[clang] 806bbc4 - [OpenMP] Try to embed offloading objects after codegen

Author: Joseph Huber Date: 2022-03-14T20:08:24-04:00 New Revision: 806bbc49dc07465eddc883b09d48dd93fb64d147 URL: https://github.com/llvm/llvm-project/commit/806bbc49dc07465eddc883b09d48dd93fb64d147 DIFF: https://github.com/llvm/llvm-project/commit/806bbc49dc07465eddc883b09d48dd93fb64d147.diff

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln marked an inline comment as done. yln added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:900 + // __cxa_atexit calls to avoid emitting the deprecated __mod_term_func. + if (TM->getTargetTriple().isOSBinFormatMachO()) +addPass(createLowerGlobalDtors

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

yln updated this revision to Diff 415273. yln added a comment. Herald added subscribers: cfe-commits, ormris. Herald added a project: clang. Add support for an escape hatch to fallback to the old behavior: via Clang driver flag (`-fregister-global-dtors-with-atexit`) or llc / code generation flag

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGen/debug-prefix-map.c:7 +// RUN: %clang -g -fdebug-prefix-map=%p=%{fssrcroot}UNLIKELY_PATH%{fssep}empty -S -c %s -emit-llvm -o - | FileCh

[PATCH] D111457: [test] Add lit helper for windows paths

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable, though I'm not a fan of the variable names - they seem a bit difficult to read due to no separation (e.g., `%fs-src-root` or `%fs_src_root` vs `%fssrcroot`) Repository:

[PATCH] D120271: [Clang] Add offload kind to embedded offload object

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. Adjust commit message. LG, we can address outstanding comments for different encodings as we go. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 56e7d6b - [Clang] noinline stmt attribute - emit warnings rather than errors

Author: Dávid Bolvanský Date: 2022-03-14T23:40:17+01:00 New Revision: 56e7d6bd444cef8d879adc35dcf461cb4d2ed6d5 URL: https://github.com/llvm/llvm-project/commit/56e7d6bd444cef8d879adc35dcf461cb4d2ed6d5 DIFF: https://github.com/llvm/llvm-project/commit/56e7d6bd444cef8d879adc35dcf461cb4d2ed6d5.dif

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

royjacobson updated this revision to Diff 415251. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121646/new/ https://reviews.llvm.org/D121646 Files: clang/lib/Sema/SemaOverload.cpp clang/test/SemaTemplate/concepts.cpp Index: clang/test/SemaTemp

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

royjacobson added a comment. In D121646#3380893 , @erichkeane wrote: > This seems acceptable to me. Though, I wonder if > `getTemplateArgumentBindingsText` should produce the leading space, that way > we could just pass the result of it directly, rathe

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

erichkeane added a comment. This seems acceptable to me. Though, I wonder if `getTemplateArgumentBindingsText` should produce the leading space, that way we could just pass the result of it directly, rather than have to create a SmallString everywhere. WDYT? Comment at: cla

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

jyknight added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D121646: [Concepts] Fix an assertion failure while diagnosing constrained function candidates

royjacobson created this revision. royjacobson added a reviewer: erichkeane. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See: https://github.com/llvm/llvm-project/issues/54379 I tried to see if

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNMENT_ADDR]], align 8 - // CHECK-NEXT:

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 415240. cor3ntin added a comment. clamg-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

lebedev.ri added a reviewer: lebedev.ri. lebedev.ri added inline comments. Comment at: clang/test/CodeGen/catch-alignment-assumption-attribute-alloc_align-on-function-variable.cpp:55 // CHECK-NEXT:%[[ALIGNMENT_RELOADED:.*]] = load i64, i64* %[[ALIGNME

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin added a comment. In D121532#3380580 , @shafik wrote: > Can you add a test to `ASTImpoterTest.cpp` that checks that we import the > `LambdaDependencyKind` correctly? Sure, if we agree that the direction is sufficiently palatable (I'm not convin

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 added a comment. In D121629#3380191 , @durin42 wrote: > In D121629#3380175 , @lebedev.ri > wrote: > >> Please can you pose the next patch itself? >> I suspect that propagation should simply not be done wh

[PATCH] D119271: clang: emit allocalign to LLVM for alloc_align attributes

durin42 retitled this revision from "CGCall: also emit LLVM `allocalign` attribute when handling AllocAlign" to "clang: emit allocalign to LLVM for alloc_align attributes". durin42 edited the summary of this revision. durin42 updated this revision to Diff 415230. Herald added a project: All. Rep

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 updated this revision to Diff 415226. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121629/new/ https://reviews.llvm.org/D121629 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGen/catch-alignm

[clang] a717e9d - [AttrDocs] try to fix build

Author: Dávid Bolvanský Date: 2022-03-14T22:19:55+01:00 New Revision: a717e9d47e64682bf45e6a998d11d76f47454f12 URL: https://github.com/llvm/llvm-project/commit/a717e9d47e64682bf45e6a998d11d76f47454f12 DIFF: https://github.com/llvm/llvm-project/commit/a717e9d47e64682bf45e6a998d11d76f47454f12.dif

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

shafik added a comment. Can you add a test to `ASTImpoterTest.cpp` that checks that we import the `LambdaDependencyKind` correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 ___

[PATCH] D120717: [Clang] always_inline statement attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG003c0b9307bc: [Clang] always_inline statement attribute (authored by xbolva00). Herald added a project: clang. Herald added a subscriber: cfe-commit

[clang] 003c0b9 - [Clang] always_inline statement attribute

Author: Dávid Bolvanský Date: 2022-03-14T21:45:31+01:00 New Revision: 003c0b9307bc52605fc93c599dfe36849839ded5 URL: https://github.com/llvm/llvm-project/commit/003c0b9307bc52605fc93c599dfe36849839ded5 DIFF: https://github.com/llvm/llvm-project/commit/003c0b9307bc52605fc93c599dfe36849839ded5.dif

[PATCH] D121637: [PowerPC] Fix EmitPPCBuiltinExpr to emit arguments once

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Herald added a project: All. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch refactors `EmitPPCBuiltinExpr` in `CGBuiltin.cpp` to remove t

[PATCH] D119477: Ignore FullExpr when traversing cast sub-expressions

kimgr added a comment. @aaron.ballman Friendly Monday ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119477/new/ https://reviews.llvm.org/D119477 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D119476: Generalize and harmonize sub-expression traversal

kimgr added a comment. @aaron.ballman Friendly Monday ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119476/new/ https://reviews.llvm.org/D119476 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan updated this revision to Diff 415199. egorzhdan added a comment. - Only allow one attribute syntax style per directive - Adjust documentation - Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.l

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

egorzhdan added a comment. In D121283#3379225 , @aaron.ballman wrote: > As a thought experiment, would it make sense to lift the restriction on the > number of attributes allowed in a pragma, but not allow multiple attribute > specifiers? I think this

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

ymandel accepted this revision. ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:264 + +[](const CXXMemberCallExpr *E, LatticeTransferState &State) { +assignOptionalValue(*E->getImplicitObjec

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Might be worth adding a release note for it (does this close any bugs in the bug database? If so, it'd be worth mentioning those in the commit message and release note).

[PATCH] D121532: [Clang][WIP] Fix Unevaluated Lambdas

cor3ntin updated this revision to Diff 415187. cor3ntin added a comment. Remove prior attempt at fixing this bug (good catch Aaron!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121532/new/ https://reviews.llvm.org/D121532 Files: clang/include/

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added inline comments. Comment at: clang/test/SemaTemplate/concepts.cpp:63 template concept C = true; - template requires C typename U> struct X {}; // expected-error {{requires 'class'}} expected-error 0+{{}} + template requires C typename U> struct X {}; tem

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane added a comment. Comment based on @rsmith and EWG reflector feedback as to where this should be checked. Comment at: clang/test/SemaTemplate/concepts.cpp:63 template concept C = true; - template requires C typename U> struct X {}; // expected-error {{requires '

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:118 +/// function will be 2. +int countOptionalWrappers(const ASTContext &ASTCtx, QualType Type) { + if (!IsOptionalType(Type)) Nit: some of th

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MatchSwitch.h:146 + std::vector> + Actions; Nit: looks like we need to repeat the action type. Should we restore the using above? Repository: rG LLVM Github Monorep

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

sgatev marked 2 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:264 + +[](const CXXMemberCallExpr *E, LatticeTransferState &State) { +assignOptionalValue(*E->getImpli

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/TypeLoc.h:923 + void initializeLocal(ASTContext &Context, SourceLocation loc) {} + + QualType getInnerType() const { return getTypePtr()->getWrappedType(); } yonghong-song wrote: > aaron.b

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

sgatev updated this revision to Diff 415178. sgatev marked 2 inline comments as done. sgatev added a comment. Add a FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121602/new/ https://reviews.llvm.org/D121602 Files: clang/include/clang/Anal

[PATCH] D114382: [clang] Fix wrong -Wunused-local-typedef warning within a template function

krisb added inline comments. Comment at: clang/test/SemaCXX/warn-unused-local-typedef.cpp:246 + typedef int Int; // no-diag + typedef char Char; // expected-warning {{unused typedef 'Char'}} + Int m; krisb wrote: > Quuxplusone wrote: > > I haven't

[PATCH] D121602: [clang][dataflow] Model the behavior of non-standard optional constructors

sgatev updated this revision to Diff 415177. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121602/new/ https://reviews.llvm.org/D121602 Files: clang/in

[PATCH] D121512: [Support] Change zlib::compress to return void

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG407c721ceb93: [Support] Change zlib::compress to return void (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 407c721 - [Support] Change zlib::compress to return void

Author: Fangrui Song Date: 2022-03-14T11:38:04-07:00 New Revision: 407c721ceb93863b2cb3851a6aa7686f31657e6b URL: https://github.com/llvm/llvm-project/commit/407c721ceb93863b2cb3851a6aa7686f31657e6b DIFF: https://github.com/llvm/llvm-project/commit/407c721ceb93863b2cb3851a6aa7686f31657e6b.diff

[PATCH] D121629: clang: also check alloc_alignment claims in return

durin42 added a comment. In D121629#3380175 , @lebedev.ri wrote: > Please can you pose the next patch itself? > I suspect that propagation should simply not be done when sanitizer is > enabled. I'm working on the next patch. Sadly we can't omit `alloca

  1   2   3   >