[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-09 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for your patience. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

2022-03-09 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D121177#3371695 , @vsapsai wrote: > Thanks for the review, Chuanqi! I believe you were touching recently > `isSameEntity`. Do you have any concerns about using > `StructuralEquivalenceContext` instead of `isSameEntity`? I'v

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 414277. pengfei added a comment. Remove outdated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:679 + !llvm::isPowerOf2_32(OutSize)) +targetDiag(OutputExpr->getExprLoc(), diag::err_store_value_to_reg); + jyu2 wrote: > Error message is not very clear to me. I think we

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei updated this revision to Diff 414276. pengfei added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @aaron.ballman @erichkeane Hopefully I addressed your comments. Could you take a look again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 ___

[PATCH] D121352: [clang-format] Handle "// clang-format off" for RemoveBracesLLVM

2022-03-09 Thread Owen Pan via Phabricator via cfe-commits
owenpan created this revision. owenpan added reviewers: MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository:

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

2022-03-09 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai added a comment. Thanks for the review, Chuanqi! I believe you were touching recently `isSameEntity`. Do you have any concerns about using `StructuralEquivalenceContext` instead of `isSameEntity`? I've decided to go with `StructuralEquivalenceContext` because at this point we are still

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 414267. yonghong-song added a comment. - use BTFTypeTagAttr instead of Attr in PropertiesBase.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files: clang/

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 414263. yonghong-song added a comment. - further clang-format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files: clang/include/clang-c/Index.h cl

[clang] 89c94c2 - [clang][Driver] Get darwin -Xarch_ working for subtypes, again.

2022-03-09 Thread Ahmed Bougacha via cfe-commits
Author: Ahmed Bougacha Date: 2022-03-09T18:21:45-08:00 New Revision: 89c94c242c7ddcc700aba6af7243dcac7a9a4ef2 URL: https://github.com/llvm/llvm-project/commit/89c94c242c7ddcc700aba6af7243dcac7a9a4ef2 DIFF: https://github.com/llvm/llvm-project/commit/89c94c242c7ddcc700aba6af7243dcac7a9a4ef2.diff

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

2022-03-09 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu added a comment. In D118352#3371425 , @h-vetinari wrote: > Something must have gone wrong... communication-wise... as @urnathan seems to > have abandoned (resp. resigned from) all modules PRs. Hope any > misunderstandings or grievances can be

[PATCH] D121302: [HIP] Fix -fno-gpu-sanitize

2022-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda9a70313d60: [HIP] Fix -fno-gpu-sanitize (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] da9a703 - [HIP] Fix -fno-gpu-sanitize

2022-03-09 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2022-03-09T20:58:50-05:00 New Revision: da9a70313d60572c1e1e630ecf2dad7a0fa5d7ff URL: https://github.com/llvm/llvm-project/commit/da9a70313d60572c1e1e630ecf2dad7a0fa5d7ff DIFF: https://github.com/llvm/llvm-project/commit/da9a70313d60572c1e1e630ecf2dad7a0fa5d7ff.dif

[PATCH] D120132: [HIP] Fix HIP include path

2022-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6730b44480fc: [HIP] Fix HIP include path (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120132/new/ http

[clang] 6730b44 - [HIP] Fix HIP include path

2022-03-09 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2022-03-09T20:57:27-05:00 New Revision: 6730b44480fcce18bfbbae0c46719250e9eae425 URL: https://github.com/llvm/llvm-project/commit/6730b44480fcce18bfbbae0c46719250e9eae425 DIFF: https://github.com/llvm/llvm-project/commit/6730b44480fcce18bfbbae0c46719250e9eae425.dif

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

2022-03-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei added a comment. In D120610#3348997 , @dblaikie wrote: > This should include a test - and could you describe more about where this > issue came up/what motivated the change? Sure, sorry for the delay as I just got back to this today. I sent the f

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 414252. yonghong-song added a comment. - clang-format fix - change variable names to be llvm compliant. - remove Attr from BTFTagAttributedTypeLoc as it can be retrieved from the BTFTagAttributedType - Also transform the attribute in TreeTransform - add

[PATCH] D120610: [DebugInfo] Include DW_TAG_skeleton_unit when looking for parent UnitDie

2022-03-09 Thread Wenlei He via Phabricator via cfe-commits
wenlei updated this revision to Diff 414251. wenlei added a comment. Herald added projects: clang, All. Herald added a subscriber: cfe-commits. Add test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120610/new/ https://reviews.llvm.org/D12061

[clang] 9abeb80 - [Driver][OpenBSD] Disable unwind tables on Arm

2022-03-09 Thread Brad Smith via cfe-commits
Author: Brad Smith Date: 2022-03-09T20:33:16-05:00 New Revision: 9abeb80e80d0f2e9dd7603491d33fa0683a33ac1 URL: https://github.com/llvm/llvm-project/commit/9abeb80e80d0f2e9dd7603491d33fa0683a33ac1 DIFF: https://github.com/llvm/llvm-project/commit/9abeb80e80d0f2e9dd7603491d33fa0683a33ac1.diff LO

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

2022-03-09 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai marked 2 inline comments as done. vsapsai added a comment. `check-lldb` has the following tests failing lldb-shell :: Expr/TestIRMemoryMap.test lldb-shell :: Process/TestEnvironment.test lldb-shell :: Register/x86-64-gp-read.test lldb-shell :: Register/x86-64-read.test lldb-shel

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

2022-03-09 Thread Volodymyr Sapsai via Phabricator via cfe-commits
vsapsai updated this revision to Diff 414244. vsapsai added a comment. Add a comment and an assertion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121176/new/ https://reviews.llvm.org/D121176 Files: clang/lib/AST/ASTStructuralEquivalence.cpp

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

2022-03-09 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth added a comment. MisExpect was originally intended to be quite strict, so that developers would audit their code and re-evaluate the correctness of their annotations,or if they were needed at all. I think I'm still of a mind that getting flagged by MisExpect indicates that a differen

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

2022-03-09 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Please also consider https://github.com/llvm/llvm-project/issues/46534 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 ___ cfe-commits

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

2022-03-09 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth marked 6 inline comments as done. paulkirth added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:1203 + if (CodeGenOpts.MisExpect) { +Ctx.setMisExpectWarningRequested(true); tejohnson wrote: > Out of curiosity, since I am less f

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

2022-03-09 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. I'm fine with reverting if you think this is the best solution. I just would like to conclude soon so I can make the final release candidate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

2022-03-09 Thread H. Vetinari via Phabricator via cfe-commits
h-vetinari added a comment. Something must have gone wrong... communication-wise... as @urnathan seems to have abandoned (resp. resigned from) all modules PRs. Hope any misunderstandings or grievances can be worked out! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

2022-03-09 Thread Paul Kirth via Phabricator via cfe-commits
paulkirth updated this revision to Diff 414230. paulkirth added a comment. Consolodate common code, clarify documentation, and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115907/new/ https://reviews.llvm.org/D115907 Files: cla

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

2022-03-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Thanks Aaron, and my apologies for being easily frustrated. In D121233#3370992 , @aaron.ballman wrote: > 2. The layout of clang-tools-extra in terms of test directories is > problematic and it'd sure be nice if someday someon

[PATCH] D120527: [OpaquePtr][AArch64] Use elementtype on ldxr/stxr

2022-03-09 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 414225. aeubanks added a comment. Herald added a project: All. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120527/new/ https://reviews.llvm.org/D120527 Files: clang/lib/CodeGen/CGBuiltin.

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @aaron.ballman Thanks for the review! I will address all your comments and will also add tests with `_Generic` and `__attribute__((overloadable))`. Comment at: clang/include/clang/AST/Type.h:4797 + + BTFTagAttributedType(QualType canon, QualType

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

2022-03-09 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120936/new/ https://reviews.llvm.org/D120936

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

2022-03-09 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 414222. zequanwu marked 2 inline comments as done. zequanwu added a comment. Refactor. Add a test for `namespace A __attribute__((availability(macos, introduced=10.15))) {`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-09 Thread sstwcw via Phabricator via cfe-commits
sstwcw added a comment. Any more problems with this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

2022-03-09 Thread Zahira Ammarguellat via Phabricator via cfe-commits
zahiraam updated this revision to Diff 414216. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/eval-method-fast-math.c Inde

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

2022-03-09 Thread Manoj Gupta via Phabricator via cfe-commits
manojgupta added a comment. For the background, we had hit this in Chrome OS when building bluetooth code. This is the one of structs hitting the issue where the warning got promoted to an error: typedef struct { private: static std::string AppendCapability(std::string& result, bool append,

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

2022-03-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2733 +/// \endcode +AST_MATCHER_P(AttributedStmt, isAttr, attr::Kind, AttrKind) { + return llvm::any_of(Node.getAttrs(), This definitely seems more like `hasAttr` than `is

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

2022-03-09 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:192 "}")); + EXPECT_EQ("#define M(x) x##x\n" +"namespace A M(x) {\n" curdeius wrote: > zequanwu wrote: > > zequanwu wrote: > > > cur

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

2022-03-09 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:72 -Tok = FirstNSTok; -while (Tok && !Tok->is(tok::l_brace)) { +bool IsPrevColoncolon = false; +bool HasColoncolon = false; Nit: Personally, I'd put these

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

2022-03-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie created this revision. dblaikie added reviewers: aaron.ballman, rsmith, denik, deansturtevant. Herald added a project: All. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some functions can end up non-externally visible d

[clang] 85ee1d3 - Revert "Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static""

2022-03-09 Thread David Blaikie via cfe-commits
Author: David Blaikie Date: 2022-03-09T21:12:56Z New Revision: 85ee1d3ca1d06b6bd3477515b8d0c72c8df7c069 URL: https://github.com/llvm/llvm-project/commit/85ee1d3ca1d06b6bd3477515b8d0c72c8df7c069 DIFF: https://github.com/llvm/llvm-project/commit/85ee1d3ca1d06b6bd3477515b8d0c72c8df7c069.diff LOG:

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

2022-03-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. In D121233#3370821 , @sammccall wrote: > In D121233#3370177 , @aaron.ballman > wrote: > >> I agreed based on the understanding that the new cod

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

2022-03-09 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D118511#3369114 , @tbaeder wrote: > Hey @dblaikie, seems like this has never been pushed? Yeah, was holding off on this because it looked like maybe there was still outstanding work on the nuance/precise nature of the ABI ch

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

2022-03-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D121233#3370177 , @aaron.ballman wrote: > I agreed based on the understanding that the new code would follow the > existing conventions, so perhaps the agreement was a bit premature. But, I'm > honestly pretty surprised at

[PATCH] D120132: [HIP] Fix HIP include path

2022-03-09 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. I still don't quite understand your reluctance to use `AddClangSystemIncludeArgs` for adding HIP path, but if this change works for HIP, I'm fine with it. Also, thank you for fixing the issue with

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

2022-03-09 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:192 "}")); + EXPECT_EQ("#define M(x) x##x\n" +"namespace A M(x) {\n" zequanwu wrote: > curdeius wrote: > > MyDeveloperDay wrote: > >

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

2022-03-09 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu updated this revision to Diff 414149. zequanwu marked an inline comment as done. zequanwu added a comment. Add a test for `namespace A B {`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121269/new/ https://reviews.llvm.org/D121269 Files:

[PATCH] D120573: [OpenMP] Support runtime user conditions in metadirective

2022-03-09 Thread Giorgis Georgakoudis via Phabricator via cfe-commits
ggeorgakoudis updated this revision to Diff 414139. ggeorgakoudis added a comment. Herald added subscribers: kbarton, nemanjai. Fix tentative parsing reverting Fix device codegen for metadirectives Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12057

[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

2022-03-09 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. In D121294#3370132 , @MattDevereau wrote: > In D121294#3370085 , @sdesmalen > wrote: > >> This is mis

[PATCH] D119479: [clang][extract-api] Add global record support

2022-03-09 Thread Juergen Ributzka via Phabricator via cfe-commits
ributzka added inline comments. Comment at: clang/include/clang/SymbolGraph/AvailabilityInfo.h:31 + bool Unavailable{false}; + bool UnconditionallyDeprecated{false}; + We also need unconditionally unavailable. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

2022-03-09 Thread Steven Wu via Phabricator via cfe-commits
steven_wu added a comment. In D118352#3368922 , @ChuanqiXu wrote: > In D118352#3368919 , @phosek wrote: > >> We're also seeing this issue on our Mac bots, is it possible to revert it? > > I've reverted it. Since t

[PATCH] D121303: [clang][deps] Don't prune search paths used by dependencies

2022-03-09 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When pruning header search paths (to reduce the number of mod

[PATCH] D121302: [HIP] Fix -fno-gpu-sanitize

2022-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Fix a typo about -fno-gpu-sanitize handling and disable warnings when -fno-gpu-sanitize is specified. https://reviews.llvm.org/D121302 Files: clang/lib/Driver/Too

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

2022-03-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D121233#3370110 , @sammccall wrote: > I understand where you're coming from. But I think agreeing to move the code > was premature if it means either: > > - following all the precedents in clang-tools-extra, or > - takin

[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

2022-03-09 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau added a comment. In D121294#3370085 , @sdesmalen wrote: > This is missing tests for svundef, svrdffr, svsetffr and svpfalse? @sdesmalen Only svcnt and svptrue cause the crash. This might be because of extra values added by the `[IsAppendSVA

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-09 Thread Jennifer Yu via Phabricator via cfe-commits
jyu2 added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:679 + !llvm::isPowerOf2_32(OutSize)) +targetDiag(OutputExpr->getExprLoc(), diag::err_store_value_to_reg); + Error message is not very clear to me. I think we should create mo

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thanks for this! One thing I noticed is that we seem to be lacking a lot of Sema tests for the changes now that this is a type attribute. Of particular interest to me would be cases using `_Generic` and `__attribute__((overloadable))` to demonstrate what kind of t

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

2022-03-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. I understand where you're coming from. But I think agreeing to move the code was premature if it means either: - following all the precedents in clang-tools-extra, or - taking on the political burden of getting these changed for all projects. Based on previous interac

[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

2022-03-09 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added a comment. This is missing tests for svundef, svrdffr, svsetffr and svpfalse? Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/negative/acle_sve_svptrue.c:2 +// REQUIRES: aarch64-registered-target + +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -targe

[PATCH] D121295: [clang][deps] Modules don't contribute to search path usage

2022-03-09 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. To reduce the number of modules we build in explicit builds (

[PATCH] D121294: [AArch64][SVE][Clang] Fix crash for incorrect svptrue and svcnt parameters

2022-03-09 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau created this revision. MattDevereau added reviewers: peterwaller-arm, paulwalker-arm, DavidTruby. Herald added subscribers: ctetreau, psnobl, kristof.beyls, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. MattDevereau requested review of this revision. Herald

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

2022-03-09 Thread Andrzej Warzynski via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38101b4e95aa: [flang][driver] Add support for -S and implement -c/

[clang] 38101b4 - [flang][driver] Add support for -S and implement -c/-emit-obj

2022-03-09 Thread Andrzej Warzynski via cfe-commits
Author: Andrzej Warzynski Date: 2022-03-09T15:48:09Z New Revision: 38101b4e95aa4983b7acf1e6351309db9ce5761b URL: https://github.com/llvm/llvm-project/commit/38101b4e95aa4983b7acf1e6351309db9ce5761b DIFF: https://github.com/llvm/llvm-project/commit/38101b4e95aa4983b7acf1e6351309db9ce5761b.diff

[PATCH] D120132: [HIP] Fix HIP include path

2022-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I found a simple fix. Use -idirafter instead of -isystem-internal. It is still system include path but will be added after all other system include paths. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120132/new/ https://reviews.llvm.org/D120132 ___

[clang] 3dd7877 - Revert "[clang][dataflow] Move dataflow testing support out of unittests"

2022-03-09 Thread Stanislav Gatev via cfe-commits
Author: Stanislav Gatev Date: 2022-03-09T15:38:51Z New Revision: 3dd7877b27dcd0d2b8e0d3a3ac156390248fe612 URL: https://github.com/llvm/llvm-project/commit/3dd7877b27dcd0d2b8e0d3a3ac156390248fe612 DIFF: https://github.com/llvm/llvm-project/commit/3dd7877b27dcd0d2b8e0d3a3ac156390248fe612.diff LO

[PATCH] D120132: [HIP] Fix HIP include path

2022-03-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 414100. yaxunl added a comment. use -idirafter to include HIP include path CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120132/new/ https://reviews.llvm.org/D120132 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/hip-include-pat

[PATCH] D121285: [clang][dataflow] Move dataflow testing support out of unittests

2022-03-09 Thread Stanislav Gatev via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG26bbde2612b2: [clang][dataflow] Move dataflow testing support out of unittests (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES

[clang] 26bbde2 - [clang][dataflow] Move dataflow testing support out of unittests

2022-03-09 Thread Stanislav Gatev via cfe-commits
Author: Stanislav Gatev Date: 2022-03-09T15:31:02Z New Revision: 26bbde2612b2042c3a8a31aed7f45e065c3dd413 URL: https://github.com/llvm/llvm-project/commit/26bbde2612b2042c3a8a31aed7f45e065c3dd413 DIFF: https://github.com/llvm/llvm-project/commit/26bbde2612b2042c3a8a31aed7f45e065c3dd413.diff LO

[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

2022-03-09 Thread Eric Schweitz via Phabricator via cfe-commits
schweitz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120568/new/ https://reviews.llvm.org/D120568 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D121285: [clang][dataflow] Move dataflow testing support out of unittests

2022-03-09 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 414094. sgatev added a comment. Move NoopAnalysis.h to clang/include/clang/Analysis/FlowSensitive/Testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121285/new/ https://reviews.llvm.org/D121285 Files: cla

[PATCH] D121286: [clangd] Test against path insensitivity

2022-03-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestFS.cpp:76 #ifdef _WIN32 - return "C:\\clangd-test"; + // On windows paths are insensitive, simulate that behaviour by toggling + // capitalization for drive-letter on each call. --

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

2022-03-09 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. In D119609#3369816 , @erichkeane wrote: > The commit message isn't quite accurate, we're prohibiting it in ALL default > arguments. Yeah, I just realize this issue after changing the message. >>> I just realized that something

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

2022-03-09 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:192-211 + EXPECT_EQ("#define M(x) x##x\n" +"namespace A M(x) {\n" +"int i;\n" +"int j;\n" +"}// namespace A M(x)", +fi

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

2022-03-09 Thread Balázs Benics via Phabricator via cfe-commits
steakhal added a comment. What I wanted is to highlight the relationship between the `bugprone-shared-ptr-array-mismatch` check and the `cert-mem51` rule. I thought these aliases are the _programmatic_ way of encoding this relationship, but I understand that it might be a false advertisement giv

[PATCH] D121269: [clang-format] Fix namespace format when the name is followed by a macro

2022-03-09 Thread Nico Weber via Phabricator via cfe-commits
thakis resigned from this revision. thakis added a comment. (deferring to MyDeveloperDay and curdeius) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121269/new/ https://reviews.llvm.org/D121269 ___ cfe-c

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

2022-03-09 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe5ccd6680198: [clang][sema] Enable first-class bool support for C2x (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https:/

[clang] e5ccd66 - [clang][sema] Enable first-class bool support for C2x

2022-03-09 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2022-03-09T15:04:24+01:00 New Revision: e5ccd668019888de2704ae670da88a7be8cf7e0f URL: https://github.com/llvm/llvm-project/commit/e5ccd668019888de2704ae670da88a7be8cf7e0f DIFF: https://github.com/llvm/llvm-project/commit/e5ccd668019888de2704ae670da88a7be8cf7e0f.diff LO

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

2022-03-09 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. The commit message isn't quite accurate, we're prohibiting it in ALL default arguments. >> I just realized that something is not very clear here. Should we prohibit >> expression statements in all default arguments or just in lambda and >> templates? I wonder how gc

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-09 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. 1 comment, otherwise LGTM. I'd like @aaron.ballman to take a look once you've got the attribute transforming as well though. Comment at: clang/lib/Sema/TreeTransform.h:6876 + + BTFTypeTagAttr *Attr = oldType->getAttr(); + QualType result = TL.get

[PATCH] D121286: [clangd] Test against path insensitivity

2022-03-09 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo h

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

2022-03-09 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. This looks fine to me, though we should wait for @rnk to decide whether the warning is sufficient for him. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120936/new/ https://reviews.llvm.org/D120936

[PATCH] D121119: [clang][SVE] Add support for bitwise operators on SVE types

2022-03-09 Thread Peter Waller via Phabricator via cfe-commits
peterwaller-arm added a comment. Looking reasonable to me, one comment. Comment at: clang/lib/Sema/SemaExpr.cpp:10404 + SourceLocation Loc, + bool IsArithmetic) { QualType LHSType = LHS.get()

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

2022-03-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D121233#3369736 , @sammccall wrote: > In D121233#3369657 , @aaron.ballman > wrote: > >> Thank you for working on this! I have a few thoughts on the renaming, but >> otherwise st

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

2022-03-09 Thread Whisperity via Phabricator via cfe-commits
whisperity added a comment. I have some concerns about this. While it is now clear to me that the //partial//ness refers to partial coverage of the guideline rule, it is indeed very, very partial. **MEM51-CPP** as of now lists **9** cases of non-compliant examples, from which `std::shared_ptr =

[PATCH] D121285: [clang][dataflow] Move dataflow testing support out of unittests

2022-03-09 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev updated this revision to Diff 414074. sgatev added a comment. Update top level comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121285/new/ https://reviews.llvm.org/D121285 Files: clang/include/clang/Analysis/FlowSensitive/Testing/D

[PATCH] D121285: [clang][dataflow] Move dataflow testing support out of unittests

2022-03-09 Thread Stanislav Gatev via Phabricator via cfe-commits
sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: tschuett, steakhal, rnkovacs, mgorny. Herald added a project: All. sgatev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Heral

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

2022-03-09 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. In D121233#3369657 , @aaron.ballman wrote: > Thank you for working on this! I have a few thoughts on the renaming, but > otherwise strongly support the direction here. > >> clang/lib/Tooling/Syntax/Pseudo/* => clang-

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

2022-03-09 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. Nit: This is not an NFC change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121214/new/ https://reviews.llvm.org/D121214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

2022-03-09 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D120824#3369563 , @balazske wrote: > > I think that the problem may be related to the fact that the in-class > initializer is not used by the code in the "To" AST (in > //ctu-cxxdefaultinitexpr.cpp// the problem is with `

[PATCH] D107141: [Inline-asm] Add diagnosts for unsupported inline assembly arguments

2022-03-09 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. Ping @jyu2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107141/new/ https://reviews.llvm.org/D107141 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

2022-03-09 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan updated this revision to Diff 414068. egorzhdan added a comment. Remove unused include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121283/new/ https://reviews.llvm.org/D121283 Files: clang/include/clang/Basic/AttrSubjectMatchRules.h

[PATCH] D121283: [Clang] Support multiple attributes in a single pragma

2022-03-09 Thread Egor Zhdan via Phabricator via cfe-commits
egorzhdan created this revision. egorzhdan added a reviewer: arphaman. Herald added a subscriber: jdoerfert. Herald added a project: All. egorzhdan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds support for multiple attributes in

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

2022-03-09 Thread Balázs Benics via Phabricator via cfe-commits
steakhal updated this revision to Diff 414065. steakhal added a comment. Herald added a subscriber: carlosgalvezp. Register the checker with the alias name :D CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121214/new/ https://reviews.llvm.org/D121214 Files: clang-tools-extra/clang-tid

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

2022-03-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Headers/stdbool.c:2 +// RUN: %clang_cc1 -fgnuc-version=4.2.1 -std=c11 -E -dM %s 2>&1 | FileCheck --check-prefix=CHECK-C11 %s +// R

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

2022-03-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Thank you for working on this! I have a few thoughts on the renaming, but otherwise strongly support the direction here. > clang/lib/Tooling/Syntax/Pseudo/* => clang-tools-extra/pseudo/lib/* The usual naming conventions in clang-tools-extra is to use the

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

2022-03-09 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. In D121078#3368424 , @tonic wrote: > In D121078#3367950 , @aaron.ballman > wrote: > >> I've added comments to the few places I'd like to see a

[clang] d258196 - [clang] ScalarExprEmitter::VisitCastExpr - use castAs<> instead of getAs<> to avoid dereference of nullptr

2022-03-09 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2022-03-09T11:40:37Z New Revision: d258196f5fddf510e785be68da803d5feae56855 URL: https://github.com/llvm/llvm-project/commit/d258196f5fddf510e785be68da803d5feae56855 DIFF: https://github.com/llvm/llvm-project/commit/d258196f5fddf510e785be68da803d5feae56855.diff LOG:

[clang] a157d83 - [clang] Environment::createValueUnlessSelfReferential - use castAs<> instead of getAs<> to avoid dereference of nullptr

2022-03-09 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2022-03-09T11:40:37Z New Revision: a157d839c52077001f234ce5c8b0cbc05fbb429c URL: https://github.com/llvm/llvm-project/commit/a157d839c52077001f234ce5c8b0cbc05fbb429c DIFF: https://github.com/llvm/llvm-project/commit/a157d839c52077001f234ce5c8b0cbc05fbb429c.diff LOG:

[clang] 8d09311 - [clang] Sema::ActOnModuleImport - remove superfluous nullptr test

2022-03-09 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2022-03-09T11:40:36Z New Revision: 8d0931114f2df30c23b4eb1380185063f4684851 URL: https://github.com/llvm/llvm-project/commit/8d0931114f2df30c23b4eb1380185063f4684851 DIFF: https://github.com/llvm/llvm-project/commit/8d0931114f2df30c23b4eb1380185063f4684851.diff LOG:

[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

2022-03-09 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. I think that the problem may be related to the fact that the in-class initializer is not used by the code in the "To" AST (in //ctu-cxxdefaultinitexpr.cpp// the problem is with `QMultiHash::d` field). Probably the expression node in the field is set only if it is used

  1   2   >