[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

ChuanqiXu added a comment. In D121096#3369277 , @iains wrote: > In D121096#3368996 , @ChuanqiXu > wrote: > >> BTW, all the tests uses ``clang_cc1`. How should the users do with `clang`? >> Could them use `-Xclan

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

iains added a comment. In D121096#3368996 , @ChuanqiXu wrote: > BTW, all the tests uses ``clang_cc1`. How should the users do with `clang`? > Could them use `-Xclang` only? The driver changes are in separate patches (they will make the same user-facing

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

MyDeveloperDay added a comment. Please wait for the other reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121269/new/ https://reviews.llvm.org/D121269 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

MyDeveloperDay accepted this revision. MyDeveloperDay added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:104 + } + if (!FirstNSTok->is(tok::coloncolon)) { +NameFinished =

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:104 + } + if (!FirstNSTok->is(tok::coloncolon)) { +Name

[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban closed this revision. yrouban added a comment. Closed by commit https://reviews.llvm.org/rG7fb39fb6d6665cd469557b43eb205cc32b0a7ac3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 __

[clang-tools-extra] c8a3572 - [clangd] Make dexp command line options sticky

Author: Yevgeny Rouban Date: 2022-03-09T13:00:25+07:00 New Revision: c8a35727fe7cdb06bf2a081356c36a5159598e9f URL: https://github.com/llvm/llvm-project/commit/c8a35727fe7cdb06bf2a081356c36a5159598e9f DIFF: https://github.com/llvm/llvm-project/commit/c8a35727fe7cdb06bf2a081356c36a5159598e9f.diff

[clang-tools-extra] 81f8df0 - [clangd] Make dexp command line options sticky

Author: Yevgeny Rouban Date: 2022-03-09T12:59:49+07:00 New Revision: 81f8df0c83c6a4476f5bffa6947c0e78a94138a7 URL: https://github.com/llvm/llvm-project/commit/81f8df0c83c6a4476f5bffa6947c0e78a94138a7 DIFF: https://github.com/llvm/llvm-project/commit/81f8df0c83c6a4476f5bffa6947c0e78a94138a7.diff

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tbaeder added a comment. Hey @dblaikie, seems like this has never been pushed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 ___ cfe-commits mailing list cfe-

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 414005. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 Files: clang/docs/ReleaseNotes.rst clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Headers/stdbool.h clang/test/Headers/stdbool.c clang/t

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder marked 3 inline comments as done. tbaeder added a comment. In D120244#3368216 , @aaron.ballman wrote: > Precommit CI is failing: > > Failed Tests (1): > > Clang :: Headers/stdbool.c Heh, I guess I need to make a habit of running the tests also

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire added a comment. I just realized that something is not very clear here. Should we prohibit expression statements in all default arguments or just in lambda and templates? I wonder how gcc folks think about it as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D119609: [Clang][Sema] Prohibit expression statement in lambda default argument

junaire updated this revision to Diff 413997. junaire added a comment. - Make sure Parser can diagnostic remaining error after the expr statement. - Prohibit expression statement in template argument - Add more tests - Better diagnostic message Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1240 - FieldDecl *Field1, FieldDecl *Field2) { - const auto *Owner2 = cast(Field2->getDeclContext()); By the way, the alternative to intro

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song updated this revision to Diff 413995. yonghong-song added a comment. - add a pch test to test serialization with btf_type_tag. - simplify the code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

ChuanqiXu added a comment. BTW, all the tests uses ``clang_cc1`. How should the users do with `clang`? Could them use `-Xclang` only? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121096/new/ https://reviews.llvm.org/D121096 _

[PATCH] D121096: [C++20][Modules][HU 2/5] Support searching Header Units in user or system search paths.

ChuanqiXu added inline comments. Comment at: clang/include/clang/Frontend/FrontendOptions.h:157 + unsigned HeaderUnit : 3; + unsigned Header : 1; I prefer `IsHeader` Comment at: clang/include/clang/Frontend/FrontendOptions.h:252 + bool isH

[PATCH] D121269: [clang-format] Fix namepsace format when the name is after by a macro

zequanwu created this revision. zequanwu added reviewers: thakis, MyDeveloperDay, owenpan, klimek, sammccall. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Example: $ cat a.cpp namespace my_names

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 413992. zixuw added a comment. Plug clangSymbolGraph into clangFrontendTools Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 Files: clang/include/clang/AST/RawComment

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

efriedma added a comment. In D120936#3368566 , @rnk wrote: > I wasn't able to find any history for why `void*` was special here. As far as I can tell, nobody ever thought `void*` was special. The check was an attempt to restrict dubious conversions whi

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

ChuanqiXu added a comment. I don't know about ObjC. Comments on style/name only. Comment at: clang/include/clang/Serialization/ASTReader.h:1110 + template + using DuplicateDecls = std::pair; + How about change the name to: ``` template using DuplicateO

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

efriedma updated this revision to Diff 413989. efriedma added a comment. Added warning. This roughly matches the corresponding MSVC warning, as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120936/new/ https://reviews.llvm.org/

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

ChuanqiXu added a comment. In D118352#3368919 , @phosek wrote: > We're also seeing this issue on our Mac bots, is it possible to revert it? I've reverted it. Since this is the new feature, I think it wouldn't so hurry to land it. BTW, I think it would b

[clang] 845f0bb - Revert "[clang][ABI] New C++20 module mangling scheme"

Author: Chuanqi Xu Date: 2022-03-09T10:15:15+08:00 New Revision: 845f0bb5fac7479b27e5327c8787ac111e9ad610 URL: https://github.com/llvm/llvm-project/commit/845f0bb5fac7479b27e5327c8787ac111e9ad610 DIFF: https://github.com/llvm/llvm-project/commit/845f0bb5fac7479b27e5327c8787ac111e9ad610.diff LO

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

phosek added a comment. We're also seeing this issue on our Mac bots, is it possible to revert it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 ___ cfe-commi

[PATCH] D115907: [misexpect] Re-implement MisExpect Diagnostics

tejohnson added inline comments. Herald added a project: All. Comment at: clang/include/clang/Basic/CodeGenOptions.def:172 CODEGENOPT(NoWarn, 1, 0) ///< Set when -Wa,--no-warn is enabled. +CODEGENOPT(MisExpect , 1, 0) ///< Set -Wmisexpect is enabled CODEGENO

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

Bigcheese added inline comments. Comment at: clang/lib/Lex/ModuleMap.cpp:2355 +parseModuleMembers(); + } +} bruno wrote: > Too many curly braces? This is correct. It closes the block on line 2353. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119601: [analyzer] Refactor makeNull to makeNullWithWidth (NFC)

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h:378 +type = type->isReferenceType() + ? Context.getPointerType(type->getPointeeType()) + : type; How do you discover the po

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:115 + // optional::has_value + .CaseOf(isOptionalMemberCallWithName("has_value"), + transferOptionalHasV

[PATCH] D121259: [clang] Fix CodeGenAction for LLVM IR MemBuffers

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3dae59b9dfb: [clang] Fix CodeGenAction for LLVM IR MemBuffers (authored by RSenApps, committed by dcastagna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] b3dae59 - [clang] Fix CodeGenAction for LLVM IR MemBuffers

Author: Ryan Senanayake Date: 2022-03-09T00:39:48Z New Revision: b3dae59b9dfb579d396bd97ca1b5a16529daac75 URL: https://github.com/llvm/llvm-project/commit/b3dae59b9dfb579d396bd97ca1b5a16529daac75 DIFF: https://github.com/llvm/llvm-project/commit/b3dae59b9dfb579d396bd97ca1b5a16529daac75.diff LO

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

vsapsai added a comment. Thanks for the reviews! I'm going to address the comments, `check-lldb`, check tests failing on Debian. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1971 +return false; + unsigned SlotsToCheck = NumArgs > 0 ? NumArgs : 1; + for (unsigne

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 413967. zixuw added a comment. Fix reference to vtable of ExtractAPIAction from clang/FrontendTools/ExecuteCompilerInstance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. Wait that's just a current linking issue on `main`, I suppose not specific to shared lib builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119479/new/ https://reviews.llvm.org/D119479 ___

[PATCH] D121259: [clang] Fix CodeGenAction for LLVM IR MemBuffers

dcastagna added a comment. I'll land it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121259/new/ https://reviews.llvm.org/D121259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D120949: [clang][AST matchers] adding attributedStmt AST matcher

ajohnson-uoregon updated this revision to Diff 413962. ajohnson-uoregon added a comment. Figuring out git-clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120949/new/ https://reviews.llvm.org/D120949 Files: clang/docs/LibASTMatchersRef

[PATCH] D121259: [clang] Fix CodeGenAction for LLVM IR MemBuffers

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Congrats on your first patch! Can Daniele or Shangwu land this for you, or do you need me to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1212

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

rnk added a comment. I remember writing up feedback on this patch, but it's gone now, oh well. I wasn't able to find any history for why `void*` was special here. I see that MSVC doesn't warn when converting from `__unaligned int*` to `int*`, but that seems dangerous. Our team has an active fea

[PATCH] D121259: [clang] Fix CodeGenAction for LLVM IR MemBuffers

RSenApps created this revision. RSenApps added reviewers: jlebar, mkuper, dcastagna, shangwuyao. Herald added a project: All. RSenApps requested review of this revision. Herald added a project: clang. Replaces use of getCurrentFile with getCurrentFileOrBufferName in CodeGenAction. This avoids an a

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw added a comment. I've moved things around to resolve the cycle, but sadly it seems that shared lib builds are already broken and I could not test it: Linking CXX shared library lib/libLLVMTransformUtils.dylib FAILED: lib/libLLVMTransformUtils.dylib : Undefined symbols for arc

[PATCH] D119479: [clang][extract-api] Add global record support

zixuw updated this revision to Diff 413947. zixuw added a comment. Herald added a project: All. Move ExtractAPIConsumer which references clangIndex USR generation methods out of clangFrontend to resolve a cycle between clangFrontend and clangIndex when building shared libs. Repository: rG LL

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3367950 , @aaron.ballman wrote: > In D121078#3367289 , @tonic wrote: > >> In D121078#3366825 , >> @aaron.ballman wrote: >> >>> In D1210

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam added inline comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1600 +} else { + OS << getTUFPEvalMethod(); + // __FLT_EVAL_METHOD__ expands to a simple numeric value. andrew.w.kaylor wrote: > It looks like you've got tabs in the code

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

zahiraam updated this revision to Diff 413936. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121122/new/ https://reviews.llvm.org/D121122 Files: clang/lib/Lex/PPMacroExpansion.cpp clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaAttr.cpp clang

[PATCH] D121176: [ASTStructuralEquivalence] Add support for comparing ObjCCategoryDecl.

a_sidorin added a comment. Hi Volodymyr, Unfortunately, I'm not familiar with Objective-C and its frontend but I have a question. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:1989 + ++ParamT1, ++ParamT2) { +if (!IsStructurallyEquivalent(Context, *ParamT1, *

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

xazax.hun added a comment. In D120992#3368118 , @NoQ wrote: > I guess there's the usual direction that I occasionally suggest: develop a > way to verify that all possible paths were explored during symbolic execution > (`CoreEngine::hasWorkRemaining()`

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. Precommit CI is failing: Failed Tests (1): Clang :: Headers/stdbool.c Comment at: clang/lib/Headers/stdbool.h:18 +#warning \ +"the header is deprecated in C2x. bool, t

[PATCH] D121097: [C++20][Modules][HU 3/5] Emit module macros for header units.

iains updated this revision to Diff 413913. iains added a comment. updated to remove a single-use variable. Having some difficulty in reproducing the CI fails outside the harness, however the code setting the removed variable could have faulted if there was no macro data for the identifier. Se

[PATCH] D121245: [clang][parser] Allow GNU attributes before namespace identifier

ArcsinX created this revision. ArcsinX added reviewers: aaron.ballman, rsmith. Herald added a subscriber: jdoerfert. Herald added a project: All. ArcsinX requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC supports: - `namespace identifie

[PATCH] D120992: [analyzer] ReverseNull: New checker to warn for pointer value conditions, if the pointer value is unconditionally non-null

NoQ added a comment. I guess there's the usual direction that I occasionally suggest: develop a way to verify that all possible paths were explored during symbolic execution (`CoreEngine::hasWorkRemaining()` on steroids), then do most of the work in `checkEndAnalysis`. We also already have `al

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

tstellar added a comment. Herald added a project: All. Should we backport this to the release/14.x branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118511/new/ https://reviews.llvm.org/D118511 ___ c

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: owenpan wrote: > cjdb wrote: > > owenpan wrote: > > > Do we still n

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In D121078#3367289 , @tonic wrote: > In D121078#3366825 , @aaron.ballman > wrote: >

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

This revision was automatically updated to reflect the committed changes. Closed by commit rG8321579b2830: [flang][driver] Add support for `-debug-dump-pft` (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121198/new/ https://

[clang] 8321579 - [flang][driver] Add support for `-debug-dump-pft`

Author: Andrzej Warzynski Date: 2022-03-08T19:21:58Z New Revision: 8321579b2830d1475a69306a02b61789f8ca3cf7 URL: https://github.com/llvm/llvm-project/commit/8321579b2830d1475a69306a02b61789f8ca3cf7 DIFF: https://github.com/llvm/llvm-project/commit/8321579b2830d1475a69306a02b61789f8ca3cf7.diff

[PATCH] D119910: [clang][debug] port clang-cl /JMC flag to ELF

ychen added a comment. In D119910#3364920 , @ychen wrote: > In D119910#3364892 , @thakis wrote: > >> Looks like this breaks tests on mac and win: >> http://45.33.8.238/win/54551/step_7.txt >> http://45.33.8.238/ma

[PATCH] D120936: [Sema][Windows] Don't special-case void* in __unaligned conversions.

erichkeane added a comment. I don't particularly understand this qualifier, is this something that perhaps @rnk could take a look at? Comment at: clang/test/SemaCXX/MicrosoftExtensions.cpp:88 __unaligned B_unaligned *p3 = 0; - int p4 = foo_unaligned(p3); + int p4 = foo_u

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall added a comment. Herald added a subscriber: ormris. @hokein I talked about making some headers private, but realized that change really is unrelated, and would be confusing to mix in here. This is awkward to review. I think the main things to check: - whether the intended renames (see

[PATCH] D121198: [flang][driver] Add support for `-debug-dump-pft`

clementval accepted this revision. clementval added a comment. In D121198#3366774 , @awarzynski wrote: > In D121198#3366741 , @clementval > wrote: > >> I’m not sure this is a feature we want to expose in the mai

[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

sammccall created this revision. sammccall added reviewers: hokein, aaron.ballman. Herald added a subscriber: mgorny. Herald added a project: All. sammccall requested review of this revision. Herald added subscribers: cfe-commits, alextsao1999. Herald added projects: clang, clang-tools-extra. This

[PATCH] D121122: Set FLT_EVAL_METHOD to -1 when fast-math is enabled.

andrew.w.kaylor added a comment. The fix for the eval_method crash should be moved to a separate patch. Otherwise, this looks good. I have only minor comments. Comment at: clang/lib/Lex/PPMacroExpansion.cpp:1600 +} else { + OS << getTUFPEvalMethod(); + // __FLT_E

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song added a comment. @erichkeane Just posted a patch to address your comments. Could you take a look? I will try to add more tests, esp. serialization and libclang. If you have any suggestions in these two areas (as I am not familiar with them), it would be great! Repository: rG L

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

yonghong-song updated this revision to Diff 413861. yonghong-song added a comment. - address @erichkeane comments - further TODO: add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120296/new/ https://reviews.llvm.org/D120296 Files: cl

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:20 +/// +/// FIXME: Consider separating the models from the unchecked acce

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.h:20 +/// +/// FIXME: Consider separating the models from the unchecked access analysis. +class UncheckedOptionalAccessModel ymandel wrote: >

[PATCH] D119530: [RISCV] Add combination crypto extensions in ISAInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG550b2eaaa6e4: [RISCV] Add combination crypto extensions in ISAInfo (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 550b2ea - [RISCV] Add combination crypto extensions in ISAInfo

Author: eopXD Date: 2022-03-08T09:52:38-08:00 New Revision: 550b2eaaa6e402ce664fe55c038e5fe387258af7 URL: https://github.com/llvm/llvm-project/commit/550b2eaaa6e402ce664fe55c038e5fe387258af7 DIFF: https://github.com/llvm/llvm-project/commit/550b2eaaa6e402ce664fe55c038e5fe387258af7.diff LOG: [R

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

whisperity added a comment. Is "partial aliasing" a new notion? Or... is the alias not partial, but the coverage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121214/new/ https://reviews.llvm.org/D121214 _

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

sgatev updated this revision to Diff 413852. sgatev marked 2 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121197/new/ https://reviews.llvm.org/D121197 Files: clang/i

[PATCH] D121153: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in CGBuiltin.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG9bb8c80beaa0: [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in (authored by ahatanak). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121153/new

[clang] 9bb8c80 - [NFC][Clang][OpaquePtr] Remove calls to Address::deprecated in

Author: Akira Hatanaka Date: 2022-03-08T09:45:15-08:00 New Revision: 9bb8c80beaa0da12ae29913faa45db2add152be7 URL: https://github.com/llvm/llvm-project/commit/9bb8c80beaa0da12ae29913faa45db2add152be7 DIFF: https://github.com/llvm/llvm-project/commit/9bb8c80beaa0da12ae29913faa45db2add152be7.diff

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5255 + const auto *PVD = dyn_cast( + (dyn_cast( + (dyn_cast(Arg->IgnoreParens()))->getSubExpr())) sfertile wrote: > I find these l

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

ZarkoCA updated this revision to Diff 413818. ZarkoCA added a comment. - Restructured checks - fixed comment - removed unnecessary parameter passed to function - slightly reworded summary of patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350

[PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

tonic added a comment. In D121078#3366825 , @aaron.ballman wrote: > In D121078#3366025 , @tonic wrote: > >> In D121078#3365542 , @SimplyDanny >> wrote: >> >>> In D121078

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/Forest.h:30 +// A node in a forest. +class ForestNode { +public: sammccall wrote: > I wonder if we should put these in a namespace `forest::Node` rather than > giving them the

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct is passed to a function

sfertile added a comment. Thanks for the updates Zarko. I think we are almost there. Comment at: clang/lib/Sema/SemaChecking.cpp:5242 +// Here we try to get information about the alignment of the struct member +// from the struct passed to the caller function.We only warn when

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the reviews! I've committed in 1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121211/new/ https:

[clang] 1c55f05 - Properly diagnose constant evaluation issues at TU scope

Author: Aaron Ballman Date: 2022-03-08T10:19:15-05:00 New Revision: 1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3 URL: https://github.com/llvm/llvm-project/commit/1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3 DIFF: https://github.com/llvm/llvm-project/commit/1c55f05c6a6b58f8cc7b15a37e79753fb8abe3e3.diff

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b7941ad7c89: [clang][driver] Fix float128 diagnostics with glibc >= 2.32 (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121209/new/ h

[clang] 5b7941a - [clang][driver] Fix float128 diagnostics with glibc >= 2.32

Author: Timm Bäder Date: 2022-03-08T15:49:01+01:00 New Revision: 5b7941ad7c893b4bb019e3c96b760b0f2670ccfc URL: https://github.com/llvm/llvm-project/commit/5b7941ad7c893b4bb019e3c96b760b0f2670ccfc DIFF: https://github.com/llvm/llvm-project/commit/5b7941ad7c893b4bb019e3c96b760b0f2670ccfc.diff LO

[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

steakhal created this revision. steakhal added reviewers: whisperity, aaron.ballman. Herald added subscribers: jeroen.dobbelaere, martong, rnkovacs, xazax.hun. Herald added a project: All. steakhal requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscrib

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

thakis added a comment. (also, please don't land unused code -- land those functions when you land their callers) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.llvm.org/D118352 _

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman updated this revision to Diff 413793. aaron.ballman added a comment. Added a comment and an additional test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121211/new/ https://reviews.llvm.org/D121211 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/ParseAST.cpp

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/29650/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118352/new/ https://reviews.ll

[PATCH] D121197: [clang][dataflow] Add analysis that detects unsafe accesses to optionals

ymandel added a comment. Maybe add explanation to the patch description for move of `TestingSupport.h`? Also, mention that this just a core implementation, and fuller support is coming? Comment at: clang/include/clang/Analysis/FlowSensitive/Models/UncheckedOptionalAccessMod

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. There is already an evaluation context created in Sema but it's never popped back. And because we rely heavily on there always being at least one evaluation context (`ExprEvalContexts.back

[PATCH] D121150: [pseudo][WIP] Implement a GLR parser.

hokein updated this revision to Diff 413788. hokein added a comment. fix a subtle bug where we might leave an unremoved node in the reduce path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121150/new/ https://reviews.llvm.org/D121150 Files: cl

[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

This revision was automatically updated to reflect the committed changes. Closed by commit rG21e16ab6b8dd: [clang][ABI] New C++20 module mangling scheme (authored by urnathan). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 21e16ab - [clang][ABI] New C++20 module mangling scheme

Author: Nathan Sidwell Date: 2022-03-08T06:21:50-08:00 New Revision: 21e16ab6b8ddaccb70d2344bb35419e214a32ec9 URL: https://github.com/llvm/llvm-project/commit/21e16ab6b8ddaccb70d2344bb35419e214a32ec9 DIFF: https://github.com/llvm/llvm-project/commit/21e16ab6b8ddaccb70d2344bb35419e214a32ec9.diff

[PATCH] D120770: [C2x] Implement literal suffixes for _BitInt

aaron.ballman added a comment. If there aren't additional review comments, I plan to land this tomorrow. Any comments that come in after that are ones I'm happy to address post-commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120770/new/ https://reviews.llvm.org/D120770 _

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

qiucf accepted this revision. qiucf added a comment. This revision is now accepted and ready to land. LGTM, thanks for the catch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121209/new/ https://reviews.llvm.org/D121209 __

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

aaron.ballman created this revision. aaron.ballman added reviewers: cor3ntin, erichkeane, bruno, rsmith. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: clang. We were not creating an evaluation context for the TU scope, so we never popped an

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/Headers/stdbool.h:16 /* Don't define bool, true, and false in C++, except as a GNU extension. */ #ifndef __cplusplus #define bool _Bool aaron.ballman wrote: > We're

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

tbaeder updated this revision to Diff 413782. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120244/new/ https://reviews.llvm.org/D120244 Files: clang/docs/ReleaseNotes.rst clang/lib/Frontend/CompilerInvocation.cpp clang/lib/Headers/stdbool.h clang/test/Headers/stdbool.c clang/t

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

erichkeane added a comment. Also, please update the commit-message/title to better reflect the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119609/new/ https://reviews.llvm.org/D119609 ___ cfe-c

[PATCH] D119609: [Clang][Sema] Don't act on ReturnStmt when parsing the lambda declarator.

erichkeane added inline comments. Comment at: clang/test/Sema/err-expr-stmt-in-default-arg.cpp:19 + return bar(l); +} junaire wrote: > erichkeane wrote: > > For completeness, I'd like to see an > > in-function-defined-struct-member-function test here as well. >

[PATCH] D121206: [AARCH64] ssbs should be enabled by default for cortex-x1c

DavidSpickett added inline comments. Comment at: clang/test/Preprocessor/aarch64-target-features.c:288 // CHECK-MCPU-CORTEX-A73: "-cc1"{{.*}} "-triple" "aarch64{{.*}}" "-target-feature" "+v8a" "-target-feature" "+fp-armv8" "-target-feature" "+neon" "-target-feature" "+crc" "-t

[PATCH] D121209: [clang][driver] Fix float128 diagnostics with glibc >= 2.32

tbaeder created this revision. tbaeder added reviewers: qiucf, jsji, kbarton. Herald added a subscriber: nemanjai. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As explained in https://reviews.llvm.org

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 413774. StephenFan added a comment. Address @kito-cheng 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D120244: [clang][sema] Enable first-class bool support for C2x

aaron.ballman added a comment. In D120244#3362215 , @tbaeder wrote: > Thanks for the links to the papers. What's the best way of updating > https://clang.llvm.org/c_status.html#c2x with the new papers? I update that page from the WG14 editor's report (o

  1   2   >