[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. How does this handle cases with multiple assignments in one statement, and can tests be added to demonstrate the behaviour. Foo += Bar <<= 5; Int Baz = 5; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ htt

[PATCH] D120888: [clang] Stop dragging a EndLoc around when parsing attributes

2022-03-05 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 413276. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120888/new/ https://reviews.llvm.org/D120888 Files: clang/include/clang/Parse/Parser.h clang/include/clang/Sema/DeclSpec.h clang/lib/Parse/ParseDecl.cpp clang/lib/Parse/ParseDeclCXX.cpp

[clang] 17a6806 - [Clang] Use = default(NFC)

2022-03-05 Thread Jun Zhang via cfe-commits
Author: Jun Zhang Date: 2022-03-06T14:25:22+08:00 New Revision: 17a68065c378da74805e4e1b9a5b78cc9f83e580 URL: https://github.com/llvm/llvm-project/commit/17a68065c378da74805e4e1b9a5b78cc9f83e580 DIFF: https://github.com/llvm/llvm-project/commit/17a68065c378da74805e4e1b9a5b78cc9f83e580.diff LOG

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread sstwcw via Phabricator via cfe-commits
sstwcw marked 5 inline comments as done. sstwcw added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:16800 + Alignment)); +} + HazardyKnusperkeks wrote: > Can you test it with `AlignConsecutiveDeclarations`? Do you mean like

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413271. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.c

[PATCH] D121063: [AST] Make the last element in the linked list null

2022-03-05 Thread Bill Wendling via Phabricator via cfe-commits
void created this revision. void added reviewers: erichkeane, aaron.ballman, urnathan. Herald added a project: All. void requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The last element in a linked list should point to null, so that we can

[PATCH] D120857: WIP [randstruct] Create basis for unit test module

2022-03-05 Thread Bill Wendling via Phabricator via cfe-commits
void updated this revision to Diff 413260. void added a comment. Update with coding style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120857/new/ https://reviews.llvm.org/D120857 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added a comment. Only some small things, I think we are nearly done and this is a great change. Comment at: clang/include/clang/Format/Format.h:139-140 + /// + /// They can also be read as a whole for compatibility. The choices + /// are: + /// - None ---

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread sstwcw via Phabricator via cfe-commits
sstwcw updated this revision to Diff 413251. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119599/new/ https://reviews.llvm.org/D119599 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.c

[PATCH] D121042: [clang-format] Handle goto labels for RemoveBracesLLVM

2022-03-05 Thread Owen Pan via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG28b76b1e23bb: [clang-format] Handle goto labels for RemoveBracesLLVM (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121042/new/ https:

[clang] 28b76b1 - [clang-format] Handle goto labels for RemoveBracesLLVM

2022-03-05 Thread via cfe-commits
Author: owenca Date: 2022-03-05T12:46:57-08:00 New Revision: 28b76b1e23bb25ed333183361705841ff8f77574 URL: https://github.com/llvm/llvm-project/commit/28b76b1e23bb25ed333183361705841ff8f77574 DIFF: https://github.com/llvm/llvm-project/commit/28b76b1e23bb25ed333183361705841ff8f77574.diff LOG: [

[clang] e44bbed - Make ParsedAttrInfo and subclasses use constexpr construction

2022-03-05 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2022-03-05T20:37:21+01:00 New Revision: e44bbedb3261e918dcbd77d271dcdf0c89a41ce0 URL: https://github.com/llvm/llvm-project/commit/e44bbedb3261e918dcbd77d271dcdf0c89a41ce0 DIFF: https://github.com/llvm/llvm-project/commit/e44bbedb3261e918dcbd77d271dcdf0c89a41ce0.dif

[clang] 14af99d - [OpenCL] Turn global vector into static array. NFCI.

2022-03-05 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2022-03-05T19:16:28+01:00 New Revision: 14af99d375b6c47e4b5ec457fb1f1f02b71a8566 URL: https://github.com/llvm/llvm-project/commit/14af99d375b6c47e4b5ec457fb1f1f02b71a8566 DIFF: https://github.com/llvm/llvm-project/commit/14af99d375b6c47e4b5ec457fb1f1f02b71a8566.dif

[PATCH] D114231: [clang][docs][dataflow] Added an introduction to dataflow analysis

2022-03-05 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added a comment. > Did you add somewhere what dependency we need in order to build the > documentation now as mine is having problems with "recommonmark" I didn't change the documentation because recommonmark is not a new dependency for llvm-project, llvm/docs was depending on it bef

[PATCH] D120710: [clang-format] QualifierOrder does not reorder template arguments

2022-03-05 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG28bb040ded83: [clang-format] QualifierOrder does not reorder template arguments (authored by MyDeveloperDay). Changed prior to commit: https://rev

[clang] 28bb040 - [clang-format] QualifierOrder does not reorder template arguments

2022-03-05 Thread via cfe-commits
Author: mydeveloperday Date: 2022-03-05T18:08:25Z New Revision: 28bb040ded83b7cffdd6e6102080ccbe7935dbfe URL: https://github.com/llvm/llvm-project/commit/28bb040ded83b7cffdd6e6102080ccbe7935dbfe DIFF: https://github.com/llvm/llvm-project/commit/28bb040ded83b7cffdd6e6102080ccbe7935dbfe.diff LOG

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-05 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song added a comment. @aaron.ballman @erichkeane Just updated the patch with a new implementation, which added a new BTFTagAttributedType instead of reusing existing AttributedType. It is quite complicated and various parts of clang are touched. I mostly just followed what AttributedTy

[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

2022-03-05 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 413219. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added subscribers: dexonsmith, arphaman, martong. Herald added a project: All. - Create a separate type BTFTagAttributed instead of using Attributed type ba

[clang] a887b95 - [clang-format] Turn global COperatorsFollowingVar vector into a switch

2022-03-05 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2022-03-05T18:00:16+01:00 New Revision: a887b95edf34117b0274e5c9443ef6afa58b058a URL: https://github.com/llvm/llvm-project/commit/a887b95edf34117b0274e5c9443ef6afa58b058a DIFF: https://github.com/llvm/llvm-project/commit/a887b95edf34117b0274e5c9443ef6afa58b058a.dif

[PATCH] D121049: [Clang][VE] Add vector load intrinsics

2022-03-05 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 created this revision. kaz7 added reviewers: simoll, efocht. kaz7 added a project: clang. Herald added a subscriber: mgorny. Herald added a project: All. kaz7 requested review of this revision. Herald added a subscriber: cfe-commits. Add vector load intrinsic instructions for VE. Repository

[PATCH] D121019: [clang-tools-extra] Document clang tidy unit tests target

2022-03-05 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/Contributing.rst:367 +You can build the Clang Tidy unit tests by building the ``ClangTidyTests`` target. +Test targets in LLVM and Clang are excluded from the "build all" style action of -

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

2022-03-05 Thread ksyx via Phabricator via cfe-commits
ksyx updated this revision to Diff 413212. ksyx added a comment. Fix patch apply failed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c llvm/lib/Support/RISCVISAInfo

[PATCH] D103313: [RISCV][Clang] Implement support for zmmul-experimental

2022-03-05 Thread ksyx via Phabricator via cfe-commits
ksyx updated this revision to Diff 413211. ksyx added a comment. Herald added a subscriber: jdoerfert. Rebase and adapt to new ISAInfo module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103313/new/ https://reviews.llvm.org/D103313 Files: clang/lib/Basic/Targets/RISCV.cpp clang/t

[PATCH] D119599: [clang-format] Add option to align compound assignments like `+=`

2022-03-05 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/docs/tools/dump_format_style.py:293 state = State.InNestedStruct - field_type, field_name = re.match(r'([<>:\w(,\s)]+)\s+(\w+);', line).groups() + field_type, field_name = re.match(r'([<>:\w

[PATCH] D121045: [Analyzer][Refactor] Removed the duplicating of a if statement having same condition

2022-03-05 Thread Shivam Rajput via Phabricator via cfe-commits
phyBrackets created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. phyBrackets requested review of this revision. Herald added a projec

[PATCH] D119172: [pseudo] Implement LRGraph

2022-03-05 Thread Alex Tsao via Phabricator via cfe-commits
alextsao1999 added inline comments. Herald added a project: All. Comment at: clang/include/clang/Tooling/Syntax/Pseudo/LRGraph.h:96 + uint8_t DotPos = 0; + uint8_t RuleLength = 0; // the length of rule body. +}; Can we add LookaheadSymbol here to implement LR(1

[clang] fda7d02 - [NFC][Clang] Fix a couple of typos

2022-03-05 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2022-03-05T09:45:04+01:00 New Revision: fda7d029e52dcfb090ae97adf1c3d98121da6d98 URL: https://github.com/llvm/llvm-project/commit/fda7d029e52dcfb090ae97adf1c3d98121da6d98 DIFF: https://github.com/llvm/llvm-project/commit/fda7d029e52dcfb090ae97adf1c3d98121da6d98.diff

[PATCH] D121042: [clang-format] Handle goto labels for RemoveBracesLLVM

2022-03-05 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121042/new/ https://reviews.llvm.org/D121042