[PATCH] D118527: [X86] Promote default mtune from generic to sandybridge

pengfei added a comment. In D118527#3281488 , @craig.topper wrote: > I believe the design here was supposed to be that "generic" would be updated > in X86.td on an ongoing basis to be more modern. So that if users pass > -mtune=generic it would evolve

[PATCH] D118527: [X86] Promote default mtune from generic to sandybridge

craig.topper added a comment. I believe the design here was supposed to be that "generic" would be updated in X86.td on an ongoing basis to be more modern. So that if users pass -mtune=generic it would evolve over time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void added a comment. Hey, y'all! I've finished the initial part of this feature. I compiled a Linux kernel with it, and it booted via qemu. Please give it a go and let me know what you think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/

[PATCH] D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules.

peixin added a comment. When I investigated the edge cases you mentioned in D116292 . Found one unsupported case as follows #include #include using namespace std; void func(unsigned long long lb, unsigned long long ub, unsigned long long step) {

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

void updated this revision to Diff 404236. void added a comment. Move the zeroing of registers to before the pop instructions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 Files: clang/include/clang/

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

alextsao1999 marked 2 inline comments as done. alextsao1999 added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3209 +} else + D.Diag(clang::diag::err_invalid_ssp_buffer_size); } compnerd wrote: > Please consistently u

[PATCH] D118527: [X86] Promote default mtune from generic to sandybridge

pengfei created this revision. pengfei added reviewers: craig.topper, spatel, erichkeane, RKSimon, andrew.w.kaylor. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We use `x86-64` as default target-cpu for a long time. It may be ob

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai added a comment. @akyrtzi I believe you were working on the code responsible for decl contexts at some point. I'm not sure you'll be able to review the change. Can you recommend someone else knowledgeable with this code? Repository: rC Clang CHANGES SINCE LAST ACTION https://revie

[PATCH] D118525: [modules] Merge ObjC interface ivars with anonymous types.

vsapsai created this revision. vsapsai added reviewers: ahatanak, rsmith. vsapsai added a project: clang-modules. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Without the fix ivars with anonymous types can trigger errors like > error: 'TestClass::structIvar' fro

[PATCH] D118311: [Clang][ModuleMap] Add conditional parsing via requires block declaration

vsapsai added a comment. Haven't really checked the code, at the moment thinking about various failure modes. Cases that aren't tested but I suspect are valid ones: - empty block, i.e., `requires cplusplus {}` - nested blocks. Is it possible to reference external module map from `requires` blo

[PATCH] D118518: [clang][NFC] Change some ->getType()->isPlaceholderType() to just ->hasPlaceholderType()

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118518/new/ https://reviews.llvm.org/D118518

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:191 + } + void setContext(const ASTContext &Ctx) { CurContext = &Ctx; } + void clearContext() { CurContext = nullptr; } Please separate with newline.

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

LegalizeAdulthood accepted this revision. LegalizeAdulthood added a comment. This revision is now accepted and ready to land. LGTM with a few whitespace nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118520/new/ https://reviews.llvm.org/D11852

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:181 + } + void onResultEntry(StringRef CheckName, + const ast_matchers::BoundNodes &BoundNodes) { blank line before `onResultEn

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp:201 +} // namespace clang ClangTidyError::ClangTidyError(StringRef CheckName, ClangTidyError::Level DiagLevel, Inser

[PATCH] D118520: [clang-tidy] Output currently processing check and nodes on crash

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, JonasToth, LegalizeAdulthood. Herald added subscribers: carlosgalvezp, xazax.hun. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Create a

[clang-tools-extra] 93cf964 - Add 'clangd' prefix to remote index proto targets

Author: Sam McCall Date: 2022-01-29T02:20:52+01:00 New Revision: 93cf9640fa3890aa3a4af8c4bd7c07322548b5e8 URL: https://github.com/llvm/llvm-project/commit/93cf9640fa3890aa3a4af8c4bd7c07322548b5e8 DIFF: https://github.com/llvm/llvm-project/commit/93cf9640fa3890aa3a4af8c4bd7c07322548b5e8.diff LO

[PATCH] D118519: [clang-tidy] Organize the release notes a little better

LegalizeAdulthood created this revision. LegalizeAdulthood added a project: clang-tools-extra. Herald added a subscriber: xazax.hun. LegalizeAdulthood requested review of this revision. - Sort new checks by check name - Sort changes to existing checks by check name - Link check names to the check'

[PATCH] D118518: [clang][NFC] Change some ->getType()->isPlaceholderType() to just ->hasPlaceholderType()

Quuxplusone created this revision. Quuxplusone added reviewers: ChuanqiXu, urnathan, efriedma, kazu. Quuxplusone added a project: clang. Quuxplusone requested review of this revision. Herald added a subscriber: cfe-commits. While trying to figure out https://github.com/llvm/llvm-project/issues/529

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham marked 5 inline comments as done. bnbarham added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:575 +/// instead> +/// 'redirecting-with': keith wrote: > bnbarham wrote: > > keith wrote: > > > I think `red

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham updated this revision to Diff 404194. bnbarham added a comment. Updated to address Keith's comments. Added an error for an invalid redirect kind as well as when both `redirect-with` and `fallthrough` are given. Also added tests for these cases. Repository: rG LLVM Github Monorepo C

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); +

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield updated this revision to Diff 404193. JonChesterfield added a comment. - set rpath after libomptarget, reads better than between the two -l flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D11

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

bc-lee added a comment. For the Chromium side issue is https://crbug.com/1259122. Also I opened LLVM issue https://github.com/llvm/llvm-project/issues/53477. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117924/new/ https://reviews.llvm.org/D11792

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404190. ZarkoCA added a comment. Addressed some of the comments: - Applied code cleanup per suggestions - Used `CharUnits` instead of hard coded values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

sbc100 added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:448 +addSystemInclude(DriverArgs, CC1Args, + getDriver().SysRoot + "/include/c++/11"); +break; Where does `11` come from here? Do other drivers hard

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith added inline comments. Comment at: clang/test/lit.cfg.py:60 +if platform.system() == 'Windows': +root_sep = 'C:\\' +else: compnerd wrote: > This isn't really a separator, this is the root itself. I think that it > makes sense to name it accordingly.

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

dschuff added a comment. I haven't reviewed this yet, but since we got one of these before and never merged it (https://reviews.llvm.org/D101464) we should probably land one of these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117888/new/ http

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield added a comment. Slightly stalled on testing - I'd like to emit the object and feed it to readelf, something like: `// RUN: %clang %s -o %t && llvm-readelf --dynamic-table %t | FileCheck %s --check-prefixes=CHECK` which errors with cannot find -lomp. I feel there should be a lin

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24f88f57de58: [OpenMP] Accept shortened triples for -Xopenmp-target= (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] 24f88f5 - [OpenMP] Accept shortened triples for -Xopenmp-target=

Author: Joseph Huber Date: 2022-01-28T18:22:17-05:00 New Revision: 24f88f57de588817bd21e799e2ac1069c025674c URL: https://github.com/llvm/llvm-project/commit/24f88f57de588817bd21e799e2ac1069c025674c DIFF: https://github.com/llvm/llvm-project/commit/24f88f57de588817bd21e799e2ac1069c025674c.diff

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

jkorous added a comment. I verified locally that reverting this patch fixes the build. Reverted in fad7e491a0770ac4336934030ac67d77e7af5520 to unblock Green Dragon, etc. @aaron.ballman Please take a look when you get a chance.

[clang] fad7e49 - Revert "Add BITINT_MAXWIDTH support"

Author: Jan Korous Date: 2022-01-28T15:18:49-08:00 New Revision: fad7e491a0770ac4336934030ac67d77e7af5520 URL: https://github.com/llvm/llvm-project/commit/fad7e491a0770ac4336934030ac67d77e7af5520 DIFF: https://github.com/llvm/llvm-project/commit/fad7e491a0770ac4336934030ac67d77e7af5520.diff LO

[clang-tools-extra] 99217fa - [clang-tidy] Recognize labelled statements when simplifying boolean exprs

Author: Richard Date: 2022-01-28T16:09:46-07:00 New Revision: 99217fa8a027a893a9b2f46ed315ec4cab850e3d URL: https://github.com/llvm/llvm-project/commit/99217fa8a027a893a9b2f46ed315ec4cab850e3d DIFF: https://github.com/llvm/llvm-project/commit/99217fa8a027a893a9b2f46ed315ec4cab850e3d.diff LOG:

[PATCH] D56303: [clang-tidy] Recognize labelled statements when simplifying boolean exprs

This revision was automatically updated to reflect the committed changes. Closed by commit rG99217fa8a027: [clang-tidy] Recognize labelled statements when simplifying boolean exprs (authored by LegalizeAdulthood). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

rastogishubham added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:2271-2274 + const TargetInfo &TI = getASTContext().getTargetInfo(); + if (NumBits > TI.getMaxBitIntWidth()) { Diag(Loc, diag::err_bit_int_max_size) +<< IsUnsigned << TI.getMaxBitIntWidth(

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

jkorous added a comment. @aaron.ballman I believe this change broke the build starting with: https://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/26915/ /Users/buildslave/jenkins/workspace/clang-stage1-cmake-RA-incremental/llvm-project/clang/include/clang/Basic/Diagnostic.h:

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fc1261ef375: [Driver] Remove -fno-experimental-new-pass-manager (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 5fc1261 - [Driver] Remove -fno-experimental-new-pass-manager

Author: Fangrui Song Date: 2022-01-28T14:58:26-08:00 New Revision: 5fc1261ef37549484e9eb9edc90477d713d8223f URL: https://github.com/llvm/llvm-project/commit/5fc1261ef37549484e9eb9edc90477d713d8223f DIFF: https://github.com/llvm/llvm-project/commit/5fc1261ef37549484e9eb9edc90477d713d8223f.diff

[PATCH] D117137: [Driver] Add CUDA support for --offload param

jlebar added a comment. Pushed for Daniele: To github.com:llvm/llvm-project.git 99d2582164c4..6eb826567af0 main -> main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117137/new/ https://reviews.llvm.org/D117137 ___

[PATCH] D117137: [Driver] Add CUDA support for --offload param

This revision was automatically updated to reflect the committed changes. Closed by commit rG6eb826567af0: [Driver] Add CUDA support for --offload param (authored by dcastagna, committed by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11713

[clang] 6eb8265 - [Driver] Add CUDA support for --offload param

Author: Daniele Castagna Date: 2022-01-28T14:50:39-08:00 New Revision: 6eb826567af03c2b43cda78836b1065e12df84e4 URL: https://github.com/llvm/llvm-project/commit/6eb826567af03c2b43cda78836b1065e12df84e4 DIFF: https://github.com/llvm/llvm-project/commit/6eb826567af03c2b43cda78836b1065e12df84e4.di

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

MaskRay closed this revision. MaskRay added a comment. Closed by 8ba9c794feb30cd969b9776c39873def10c51bff . If the commit message contained `Differential Revision:`, the differential would be closely automatically when you pus

[clang] 354ec4a - [AttrDocs] Fix docs for the sycl_special_class attribute after D114483

Author: Fangrui Song Date: 2022-01-28T14:30:49-08:00 New Revision: 354ec4af749ccd910a1cffc5e9cce2bb93239b9b URL: https://github.com/llvm/llvm-project/commit/354ec4af749ccd910a1cffc5e9cce2bb93239b9b DIFF: https://github.com/llvm/llvm-project/commit/354ec4af749ccd910a1cffc5e9cce2bb93239b9b.diff

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

dblaikie added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1895 + Target.isPS4() || Target.isOSDarwin())) || + D->hasAttr(); dblaikie wrote: > rsmith wrote: > > Would it make sense to wa

[PATCH] D118511: Add a warning for not packing non-POD members in packed structs

dblaikie created this revision. dblaikie added a reviewer: rsmith. dblaikie requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D118511 Files: clang/include/clang/Basic/Diagnost

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay updated this revision to Diff 404164. MaskRay added a comment. Mention -flegacy-pass-manager as a makeshift for 14.0.0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118313/new/ https://reviews.llvm.org/D118313 Files: clang/docs/ReleaseNo

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

nikic added inline comments. Comment at: clang/docs/ReleaseNotes.rst:112 + pass manager for the optimization pipeline was deprecated in 13.0.0 and will + be removed after 14.0.0. Would be good to mention `-flegacy-pass-manager` as the alternative here. Repo

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay updated this revision to Diff 404163. MaskRay added a comment. Add -fno-experimental-new-pass-manager to `Removed Compiler Flags` in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118313/new/ https://reviews.llvm.org/D118313

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118495/new/ https://reviews.llvm.org/D118495 ___

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

MaskRay added a comment. In D118313#3280822 , @aeubanks wrote: > I think this is fine, it gives clang users another chance to report new PM > blockers Yes. Thanks for accepting this before 14.0.0 branching:) Repository: rG LLVM Github Monorepo CHAN

[PATCH] D118313: [Driver] Remove -fno-experimental-new-pass-manager

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. I think this is fine, it gives clang users another chance to report new PM blockers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118313/new

[PATCH] D118297: [clang] add Diag -Wasm-volatile for implied volatile asm stmts

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:31 +def warn_asm_volatile_goto : Warning<"volatile qualifier implied by goto">, InGroup; +def warn_asm_volatile : Warning<"volatile qualifier implied by lack of outputs">, InGro

[PATCH] D91607: [clang][Sparc] Fix __builtin_extract_return_addr etc.

efriedma added a comment. Testcase? Do you need to ptrtoint/inttoptr? I would expect that the address is an `i8*`, so you can just GEP an appropriate number of bytes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91607/new/ https://reviews.llvm.

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

keith added inline comments. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:575 +/// instead> +/// 'redirecting-with': bnbarham wrote: > keith wrote: > > I think `redirecting-with` is fine, and I can't come up with something > > b

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield updated this revision to Diff 404156. JonChesterfield added a comment. Herald added a subscriber: dang. - Now with commandline argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 File

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Format/FormatToken.h:125 +/// Sorted Operators that can follow a C variable. +static const std::vector COperatorsFollowingVar = { --

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef ParamName,

[PATCH] D118475: [clang-format] Fix misaligned trailing comments in the presence of an empty block comment.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64df51624f08: [clang-format] Fix misaligned trailing comments in the presence of an empty… (authored by curdeius). Repository: rG LLVM Github Mono

[clang] 64df516 - [clang-format] Fix misaligned trailing comments in the presence of an empty block comment.

Author: Marek Kurdej Date: 2022-01-28T22:28:48+01:00 New Revision: 64df51624f08f3b8d7370f820ab3545b1de98a0e URL: https://github.com/llvm/llvm-project/commit/64df51624f08f3b8d7370f820ab3545b1de98a0e DIFF: https://github.com/llvm/llvm-project/commit/64df51624f08f3b8d7370f820ab3545b1de98a0e.diff

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

bnbarham added a comment. Thanks for taking a look at that @keith, I appreciate it :)! I'll make those changes today hopefully. Comment at: llvm/include/llvm/Support/VirtualFileSystem.h:575 +/// instead> +/// 'redirecting-with': keith wrot

[PATCH] D117376: Remove reference type when checking const structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbe2147db054e: Remove reference type when checking const structs (authored by rtrieu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] be2147d - Remove reference type when checking const structs

Author: Weverything Date: 2022-01-28T13:08:58-08:00 New Revision: be2147db054ec096199d1251bfab9065c7e0f29b URL: https://github.com/llvm/llvm-project/commit/be2147db054ec096199d1251bfab9065c7e0f29b DIFF: https://github.com/llvm/llvm-project/commit/be2147db054ec096199d1251bfab9065c7e0f29b.diff L

[PATCH] D118153: [CUDA][HIP] Do not treat host var address as constant in device compilation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8428c75da1ab: [CUDA][HIP] Do not treat host var address as constant in device compilation (authored by yaxunl). Herald added a project: clang. Repos

[clang] 8428c75 - [CUDA][HIP] Do not treat host var address as constant in device compilation

Author: Yaxun (Sam) Liu Date: 2022-01-28T16:04:52-05:00 New Revision: 8428c75da1ab3149292c255057173cb502729d92 URL: https://github.com/llvm/llvm-project/commit/8428c75da1ab3149292c255057173cb502729d92 DIFF: https://github.com/llvm/llvm-project/commit/8428c75da1ab3149292c255057173cb502729d92.dif

[PATCH] D118370: [clang-tidy] bugprone-signal-handler: Message improvement and code refactoring.

LegalizeAdulthood added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SignalHandlerCheck.cpp:146 + if (!HandlerDecl->hasBody()) { +checkFunction(HandlerDecl, HandlerExpr); return; Can we put `(void) checkFunction(...)` here to make

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

jhuber6 updated this revision to Diff 404136. jhuber6 added a comment. Adding test and shared function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118495/new/ https://reviews.llvm.org/D118495 Files: clang/include/clang/Driver/ToolChain.h cl

[PATCH] D117924: [compiler_rt] Add a seperate runtime for Mac Catalyst

thakis added a comment. In D117924#3274425 , @bc-lee wrote: > It may not be appropriate to add other runtime libraries specifically for Mac > Catalyst. However, currently `lld` does not allow linking with dynamic > libraries with different types of buil

[PATCH] D117937: [VFS] Add a "redirecting-with" field to overlays

keith accepted this revision. keith added a comment. This revision is now accepted and ready to land. I'm definitely not a VFS expert, but I do think this is much nicer than trying to do the other workarounds with multiple VFSs that you described, I left some minor comments, I reviewed carefully

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the reviews! I've commit in 86797fdb6f51d32f285e48b6d3e0fc5b8b852734 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117238/new/ https:

[clang] 86797fd - Add BITINT_MAXWIDTH support

Author: Aaron Ballman Date: 2022-01-28T15:04:29-05:00 New Revision: 86797fdb6f51d32f285e48b6d3e0fc5b8b852734 URL: https://github.com/llvm/llvm-project/commit/86797fdb6f51d32f285e48b6d3e0fc5b8b852734 DIFF: https://github.com/llvm/llvm-project/commit/86797fdb6f51d32f285e48b6d3e0fc5b8b852734.diff

[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:119-121 +if (!RootToken.Next) { + return true; +} Drop Braces Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:122

[clang] edf7e02 - [clang][NFC] Fix Typo

Author: Jacob Lambert Date: 2022-01-28T11:55:46-08:00 New Revision: edf7e026a8b4df5df7febaef126888f1ce65ebf6 URL: https://github.com/llvm/llvm-project/commit/edf7e026a8b4df5df7febaef126888f1ce65ebf6 DIFF: https://github.com/llvm/llvm-project/commit/edf7e026a8b4df5df7febaef126888f1ce65ebf6.diff

[PATCH] D118363: clang-format: [JS] sort import aliases.

HazardyKnusperkeks added a comment. There should have been an entry in the `ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118363/new/ https://reviews.llvm.org/D118363 ___ cfe-commits m

[PATCH] D109977: LLVM Driver Multicall tool

beanz updated this revision to Diff 404114. beanz added a comment. Adding support for multiple subcommands mapping to the same entry. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977 Files: clang/cmake/m

[PATCH] D117238: [C2x] Add BITINT_MAXWIDTH support

jyknight accepted this revision. jyknight added a comment. No additional comments, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117238/new/ https://reviews.llvm.org/D117238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D118050: [analyzer] Different address spaces cannot overlap

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:728 +const MemRegion *R = loc.castAs().getRegion(); +if (const auto *SR = dyn_cast(R)) { + QualType Ty = SR->getSymbol()->getType(); That's a pretty big "if".

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield added a comment. My plan is to feed executables to readelf -d. Commandline problems seem to be solvable by clean builds between changes, slow but feasible. Might upset the incremental buildbot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D118493: [WIP]Set rpath on openmp executables

jdoerfert added a comment. Can we test this somehow? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118493/new/ https://reviews.llvm.org/D118493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

jdoerfert added a comment. and test pls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118495/new/ https://reviews.llvm.org/D118495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D117616: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG277123376ce0: GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs (authored by dblaikie). Repository: rG LLVM Github Mo

[clang] 2771233 - GCC ABI Compatibility: Preserve alignment of non-pod members in packed structs

Author: David Blaikie Date: 2022-01-28T11:04:20-08:00 New Revision: 277123376ce08c98b07c154bf83e4092a5d4d3c6 URL: https://github.com/llvm/llvm-project/commit/277123376ce08c98b07c154bf83e4092a5d4d3c6 DIFF: https://github.com/llvm/llvm-project/commit/277123376ce08c98b07c154bf83e4092a5d4d3c6.diff

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12693-12695 void CheckArgAlignment(SourceLocation Loc, NamedDecl *FDecl, - StringRef ParamName, QualType ArgTy, QualType ParamTy); + StringRef Para

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei added a comment. Ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101759/new/ https://reviews.llvm.org/D101759 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

JonChesterfield added a comment. Do we have this same expansion logic in two places now? If so, probably want to factor it out to a function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118495/new/ https://reviews.llvm.org/D118495 __

[PATCH] D118350: [Clang][Sema][AIX][PowerPC] Emit byval alignment warning only when struct member is passed to a function

ZarkoCA updated this revision to Diff 404090. ZarkoCA added a comment. Addressing comments: - Change comment before checkArgAlignment() - Add missing RUN lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118350/new/ https://reviews.llvm.org/D118

[PATCH] D118495: [OpenMP] Accept shortened triples for -Xopenmp-target=

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch builds on the change

[PATCH] D109977: LLVM Driver Multicall tool

beanz added a comment. Sorry for disappearing on this. I'm working right now on adding support for multi-entry tools (like objcopy). I'll get an update in today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D1

[clang] 27ee911 - [AIX][clang] include_next through clang provided float.h

Author: David Tenty Date: 2022-01-28T13:27:10-05:00 New Revision: 27ee91162dd3f01d692e8f092903dd79f4e54348 URL: https://github.com/llvm/llvm-project/commit/27ee91162dd3f01d692e8f092903dd79f4e54348 DIFF: https://github.com/llvm/llvm-project/commit/27ee91162dd3f01d692e8f092903dd79f4e54348.diff L

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27ee91162dd3: [AIX][clang] include_next through clang provided float.h (authored by daltenty). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D117935: [AIX][clang] include_next through clang provided float.h

daltenty updated this revision to Diff 404083. daltenty added a comment. Use more unique macro name CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117935/new/ https://reviews.llvm.org/D117935 Files: clang/lib/Headers/float.h clang/test/Headers/Inputs/include/float.h clang/test/Hea

[PATCH] D101759: [PowerPC] Scalar IBM MASS library conversion pass

masoud.ataei marked 7 inline comments as done. masoud.ataei added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:386 + if (TM.getOptLevel() == CodeGenOpt::Aggressive){ +setOperationAction(ISD::FSIN , MVT::f64, Custom); +setOperationAction(ISD::F

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 404076. RKSimon added a comment. fix cut+paste typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Users

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield added a comment. Testing manually looks good, provided there's no command line argument involved. -rpath even composes sanely, so doing this plus passing -Wl,rpath= results in multiple embedded rpaths. At a loss as to why changing Options.td is working so poorly, though it may b

[PATCH] D118493: [WIP]Set rpath on openmp executables

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, jhuber6, tianshilei1992, ye-luo. Herald added subscribers: guansong, yaxunl. JonChesterfield requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Openmp

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

stella.stamenova added inline comments. Comment at: lldb/docs/resources/build.rst:296 - $ cmake -G "Visual Studio 15 2017 Win64" -Thost=x64 + $ cmake -G "Visual Studio 16 2019" -A x64 -T host=x64 -Thost=x64 You accidentally added `-T host=x64` twice now

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG760e69223d83: [NFC][AIX]Disable new pcm tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[clang] 760e692 - [NFC][AIX]Disable new pcm tests on AIX

Author: Steven Wan Date: 2022-01-28T12:39:09-05:00 New Revision: 760e69223d83860ed4758f86a0de4686a8d51fd7 URL: https://github.com/llvm/llvm-project/commit/760e69223d83860ed4758f86a0de4686a8d51fd7 DIFF: https://github.com/llvm/llvm-project/commit/760e69223d83860ed4758f86a0de4686a8d51fd7.diff LO

[PATCH] D109977: LLVM Driver Multicall tool

MaskRay added a comment. Ping @beanz Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109977/new/ https://reviews.llvm.org/D109977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D116542: [OpenMP] Add a flag for embedding a file into the module

jhuber6 updated this revision to Diff 404047. jhuber6 added a comment. Changing the name to be the section name. This ensures that if the sections get merged we will get a linker error without failing silently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

  1   2   >