[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/InefficientArrayTraversalCheck.cpp:59 + // TODO: Add support for x [+-]= 1 and x = x [+-] 1 + hasIncrement(unaryOperator(hasUnaryOperand(ToDecl), +

[PATCH] D116824: [clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, Thanks. Don't know how I missed this one last time round. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116824/new/ https://reviews.ll

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

njames93 created this revision. njames93 added reviewers: alexfh, aaron.ballman. Herald added subscribers: carlosgalvezp, kristof.beyls, xazax.hun, mgorny. njames93 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Adds a check th

LLVM build master will be restarted soon

Hello, LLVM build master will be restarted at 9 PM PST. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D116865: [OpenMP][FIX] Emit debug declares only if debug info is available

This revision was automatically updated to reflect the committed changes. Closed by commit rG37639b72a17b: [OpenMP][FIX] Emit debug declares only if debug info is available (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116865

[clang] 37639b7 - [OpenMP][FIX] Emit debug declares only if debug info is available

Author: Johannes Doerfert Date: 2022-01-08T17:01:19-06:00 New Revision: 37639b72a17be443e7f73e906554f8bbd0dbf271 URL: https://github.com/llvm/llvm-project/commit/37639b72a17be443e7f73e906554f8bbd0dbf271 DIFF: https://github.com/llvm/llvm-project/commit/37639b72a17be443e7f73e906554f8bbd0dbf271.d

[PATCH] D116865: [OpenMP][FIX] Emit debug declares only if debug info is available

ye-luo added a comment. Confirm that #52938 is fixed by this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116865/new/ https://reviews.llvm.org/D116865 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

atmnpatel updated this revision to Diff 398370. atmnpatel added a comment. - Fixed lifetime issue around ffi_call - Addressed comments The existing x86 plugin uses ffi, so this does as well, no explicit benefit in doing so. Is it worth keeping? Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

belkiss updated this revision to Diff 398369. belkiss added a comment. Use static_cast/reinterpret_cast instead of C-casts This will also retry the CI, apparently fuzzer-finalstats.test is flaky Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/n

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398366. Ericson2314 added a comment. Make sure possibly exposed modules have their own `include(GNUInstallDirs)`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Fi

[PATCH] D116856: [docs] Fix documentation of -fno-strict-float-cast-overflow after D115804.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb4cb4668b04: [docs] Fix documentation of -fno-strict-float-cast-overflow after D115804. (authored by craig.topper). Repository: rG LLVM Github Mo

[clang] db4cb46 - [docs] Fix documentation of -fno-strict-float-cast-overflow after D115804.

Author: Craig Topper Date: 2022-01-08T12:12:44-08:00 New Revision: db4cb4668b046ae988914ae49105ff3cc0bc9d92 URL: https://github.com/llvm/llvm-project/commit/db4cb4668b046ae988914ae49105ff3cc0bc9d92 DIFF: https://github.com/llvm/llvm-project/commit/db4cb4668b046ae988914ae49105ff3cc0bc9d92.diff

[PATCH] D116865: [OpenMP][FIX] Emit debug declares only if debug info is available

jdoerfert updated this revision to Diff 398358. jdoerfert added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116865/new/ https://reviews.llvm.org/D116865 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/test/OpenMP/debu

[clang] d1b127b - [clang] Remove unused forward declarations (NFC)

Author: Kazu Hirata Date: 2022-01-08T11:56:40-08:00 New Revision: d1b127b5b747a1c10409825c400da9bbfac70f2d URL: https://github.com/llvm/llvm-project/commit/d1b127b5b747a1c10409825c400da9bbfac70f2d DIFF: https://github.com/llvm/llvm-project/commit/d1b127b5b747a1c10409825c400da9bbfac70f2d.diff L

[PATCH] D116865: [OpenMP][FIX] Emit debug declares only if debug info is available

jdoerfert created this revision. jdoerfert added reviewers: ye-luo, JonChesterfield, jhuber6. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. The `EmitDeclareOfAutoVariab

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

JonChesterfield added inline comments. Comment at: clang/include/clang/Driver/Options.td:948 def libomptarget_nvptx_bc_path_EQ : Joined<["--"], "libomptarget-nvptx-bc-path=">, Group, HelpText<"Path to libomptarget-nvptx bitcode library">; def dD : Flag<["-"], "dD">, Group,

[PATCH] D96248: [OpenMP][AMDGPU] Add support for linking libomptarget bitcode

jdoerfert reopened this revision. jdoerfert added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Driver/Options.td:948 def libomptarget_nvptx_bc_path_EQ : Joined<["--"], "libomptarget-nvptx-bc-path=">, Group, HelpText<"Path

[PATCH] D116722: [clang] Verify ssp buffer size is a valid integer

alextsao1999 updated this revision to Diff 398354. alextsao1999 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116722/new/ https://reviews.llvm.org/D116722 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

belkiss updated this revision to Diff 398351. belkiss added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://reviews.llvm.org/D116861 Files: clang/lib/CodeGen/CGExprCXX.cpp compiler-rt/test/ubsan/TestCa

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:442 +if (PrimaryCheckValue != Value) { + std::cout << "Alias check \"" << CheckName.str() << "\" of \"" +<< PrimaryCheckName.str() << "\""

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

belkiss updated this revision to Diff 398350. belkiss added a comment. Squash commits, for some reason update dropped the first commit (first time using arcanist...). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://reviews.llvm.o

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

belkiss updated this revision to Diff 398346. belkiss added a comment. Disable the test in ubsan-msan and ubsan-tsan since they also override global new, causing link error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116861/new/ https://reviews

[PATCH] D114317: [clang-tidy][WIP] Do not run perfect alias checks

Jeroen added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:442 +if (PrimaryCheckValue != Value) { + std::cout << "Alias check \"" << CheckName.str() << "\" of \"" +<< PrimaryCheckName.str() << "\"" I'

[PATCH] D116638: [clang-format] Fix ignoring JavaScriptWrapImport when ColumnWidth: 0

stasm added a comment. The reporter of issue 52935 here. Thanks, @andmis, for your work. Thinking about the `ColumnLimit: 0` and `JavaScriptWrapImports: false` case, it seems that there are two issues in the current implementation that could

[PATCH] D116833: [clang] Introduce support for disabling warnings in system macros

carlosgalvezp updated this revision to Diff 398339. carlosgalvezp retitled this revision from "[clang][Sema] Introduce support for disabling warnings in system macros" to "[clang] Introduce support for disabling warnings in system macros". carlosgalvezp added a comment. Herald added a subscriber:

[clang] 6ee589e - [CGObjCMac] Use castAs<> instead of getAs<> to avoid dereference of nullptr inside BuildRCBlockVarRecordLayout

Author: Simon Pilgrim Date: 2022-01-08T16:18:55Z New Revision: 6ee589e2f563a2a5c91f9aeb2762f092dd197e32 URL: https://github.com/llvm/llvm-project/commit/6ee589e2f563a2a5c91f9aeb2762f092dd197e32 DIFF: https://github.com/llvm/llvm-project/commit/6ee589e2f563a2a5c91f9aeb2762f092dd197e32.diff LOG:

[PATCH] D116861: [UBSan] Fix incorrect alignment reported when global new returns an offset pointer

belkiss created this revision. belkiss requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers: Sanitizers, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116861 Files: clang/lib/CodeGen/CGExprCXX.cpp compiler-rt/tes

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei updated this revision to Diff 398335. pengfei added a comment. Missed one unittest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115942/new/ https://reviews.llvm.org/D115942 Files: clang/lib/Basic/Targets/X86.h clang/test/CodeGen/targ

[clang] 06e9733 - [CGExpr] Use castAs<> instead of getAs<> to avoid dereference of nullptr

Author: Simon Pilgrim Date: 2022-01-08T14:26:09Z New Revision: 06e9733fec8ddafb4c830853c198204def8a091a URL: https://github.com/llvm/llvm-project/commit/06e9733fec8ddafb4c830853c198204def8a091a DIFF: https://github.com/llvm/llvm-project/commit/06e9733fec8ddafb4c830853c198204def8a091a.diff LOG:

[PATCH] D115942: [X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC

pengfei updated this revision to Diff 398334. pengfei added a comment. Herald added a subscriber: dexonsmith. > However, do we need to make changes to `llvm::UpgradeDataLayoutString`? > Otherwise, I believe old bitcode for MSVC targets will no longer be able to > be loaded for LTO. Makes sense.

[PATCH] D116859: Fix for: clang-format: break added to macro define with ColumnLimit: 0

futuarmo created this revision. futuarmo added reviewers: djasper, MyDeveloperDay. futuarmo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix for #49164 issue. Alse added test for this c

[PATCH] D116833: [clang][Sema] Introduce support for disabling warnings in system macros

carlosgalvezp updated this revision to Diff 398325. carlosgalvezp added a comment. Keep 80 char limit in .td file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116833/new/ https://reviews.llvm.org/D116833 Files: clang/include/clang/Basic/Diagno

[PATCH] D116833: [clang][Sema] Introduce support for disabling warnings in system macros

carlosgalvezp added a comment. Updated according to your feedback, let me know what you think! I've run `ninja check-clang` successfully, let me know if there's any other test I should run. Personally I think this `ShowInSystemMacro` should be OFF by default (to be consistent with `ShowInSystem

[PATCH] D116833: [clang][Sema] Introduce support for disabling warnings in system macros

carlosgalvezp updated this revision to Diff 398324. carlosgalvezp retitled this revision from "[clang][Sema] Disable -Wc++20-designator in system macros" to "[clang][Sema] Introduce support for disabling warnings in system macros". carlosgalvezp edited the summary of this revision. carlosgalvezp

[PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 398318. Ericson2314 added a comment. Rebase on top of fixed polly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.llvm.org/D99484 Files: clang-tools-extra/clang-doc/tool/CMakeLis

[PATCH] D116856: [docs] Fix documentation of -fno-strict-float-cast-overflow after D115804.

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116856/new/ https://reviews.llvm.org/D116856 ___ c