[PATCH] D116370: [clang][dataflow] Add multi-variable constant propagation example.

sgatev accepted this revision. sgatev added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/MultiVarConstantPropagationTest.cpp:171-173 + Vars[Var] = (E->EvaluateAsInt(R, Context) && R.Val.isInt()) + ? ValueLattice(R.Val.getInt().get

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG with a nit, thanks! Comment at: clang-tools-extra/clangd/Headers.h:330 + static inline clang::clangd::stdlib::Header getEmptyKey() { +return clang::clangd::stdlib

[PATCH] D116521: [llvm][clang][cmake] Factor out config prefix finding logic

Ericson2314 updated this revision to Diff 397010. Ericson2314 added a comment. Fix arg order error in Clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116521/new/ https://reviews.llvm.org/D116521 Files: clang/CMakeLists.txt clang/cmake/modu

[PATCH] D116521: [llvm][clang][cmake] Factor out config prefix finding logic

Ericson2314 created this revision. Ericson2314 added reviewers: mstorsjo, beanz. Herald added a subscriber: mgorny. Ericson2314 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. See the docs in the new function for details.

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood updated this revision to Diff 397004. LegalizeAdulthood added a comment. Improve matching when the first matcher matches multiple times, but the 2nd matcher doesn't match at first. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116518/new/ https://reviews.llvm.org/D1165

[PATCH] D116518: [ast-matchers] Add hasSubstatementSequence matcher

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: klimek. LegalizeAdulthood added a project: clang. LegalizeAdulthood requested review of this revision. This allows the matching of two specific statements in sequence within a compound statement. For instance `if (x) ret

[PATCH] D115456: Implement on-demand TLS initialization for Microsoft CXX ABI

majnemer added a comment. This is looking great! Just a few more questions. What is the behavior with something like: thread_local int x = 2; int f() { return x; } I'm wondering if we need to move this logic

[PATCH] D114425: [clang] Add __builtin_bswap128

majnemer added a comment. OOC, how hard would it be to generalize this builtin a little? It is nice that we have builtins like `__builtin_add_overflow` which do the right thing regardless of their input. It seems like it would be nice if we started to expose more intrinsics which did the right

[PATCH] D116514: [clangd] Add code action to generate a constructor for a C++ class

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository:

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall updated this revision to Diff 396978. sammccall added a comment. Oops, revert wrong patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116502/new/ https://reviews.llvm.org/D116502 Files: clang-tools-extra/clangd/CMakeLists.txt clang

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall updated this revision to Diff 396977. sammccall added a comment. [clangd] Add code action to generate a constructor for a C++ class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116502/new/ https://reviews.llvm.org/D116502 Files: clan

[PATCH] D116513: [clang-tidy] Fix bugs in misc-unused-parameters for Constructors calls site

mehdi_amini created this revision. mehdi_amini added a reviewer: Eugene.Zelenko. Herald added subscribers: carlosgalvezp, xazax.hun. mehdi_amini requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. These weren't tracked and so weren'

[PATCH] D116512: [clang-tidy] Limit non-Strict mode to public functions

mehdi_amini created this revision. mehdi_amini added a reviewer: Eugene.Zelenko. Herald added subscribers: carlosgalvezp, xazax.hun. mehdi_amini requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The rational to avoid applying the

[PATCH] D116342: [clang][AST] Fix crash when printing error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe27b5f937138: [clang][AST] Fix crash when printing error (authored by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] e27b5f9 - [clang][AST] Fix crash when printing error

Author: Ellis Hoag Date: 2022-01-02T18:03:42-08:00 New Revision: e27b5f9371382952eb5482ad151bb6fcb4cd0d7c URL: https://github.com/llvm/llvm-project/commit/e27b5f9371382952eb5482ad151bb6fcb4cd0d7c DIFF: https://github.com/llvm/llvm-project/commit/e27b5f9371382952eb5482ad151bb6fcb4cd0d7c.diff LO

[PATCH] D116511: [clang-cl] Support the /HOTPATCH flag

aganea created this revision. aganea added reviewers: amccarth, craig.topper, hans, rnk, stefan_reinalter. Herald added subscribers: ormris, dexonsmith, dang, pengfei, hiraditya. aganea requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cf

[PATCH] D116509: [Builtins] Add missing the macro 'y' description in comments

Jim created this revision. Jim requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116509 Files: clang/include/clang/Basic/Builtins.def Index: clang/include/clang/Basic/Built

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

mehdi_amini added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unused-parameters.rst:25 + + void a(int ) { /*some code that doesn't use `i`*/ } + jpienaar wrote: > OOC why the extra space after the type? The space is in the origina

[PATCH] D116488: Add a misc-unused-parameters.CommentOutUnusedParameters to clang-tidy

jpienaar added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-unused-parameters.rst:25 + + void a(int ) { /*some code that doesn't use `i`*/ } + OOC why the extra space after the type? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik updated this revision to Diff 396960. philnik added a comment. - Rebased - Error if `__int128` is not supported Should it be tested that the compiler errors when calling `__builtin_bswap128` with __int128 not available? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116503: [clang] Add arguments for silencing unused argument warnings for some but not all arguments

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, sepavloff, phosek, MaskRay. Herald added a subscriber: dang. mstorsjo requested review of this revision. Herald added a project: clang. When passing a set of flags to configure defaults for a specific target (similar to the c

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:141 ^^ +- Added a setting ``bugprone-assert-side-effect.FunctionExceptions`` for + a comma-separated list of the names of functions or methods to be considered -

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

sammccall updated this revision to Diff 396954. sammccall added a comment. Rebase on D116502 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116490/new/ https://reviews.llvm.org/D116490 Files: clang-tools-extra/c

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:141 ^^ +- Added a setting ``bugprone-assert-side-effect.FunctionExceptions`` for + a comma-separated list of the names of functions or methods to be considered

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall updated this revision to Diff 396953. sammccall added a comment. Fix stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116502/new/ https://reviews.llvm.org/D116502 Files: clang-tools-extra/clangd/CMakeLists.txt clang-tools-

[PATCH] D116502: [clangd] Helper for determining member insertion point.

sammccall created this revision. sammccall added a reviewer: dgoldman. Herald added subscribers: usaxena95, kadircet, arphaman, mgorny. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. To be used

[PATCH] D114425: [clang] Add __builtin_bswap128

craig.topper added a comment. In D114425#3216531 , @Quuxplusone wrote: > In D114425#3216490 , @craig.topper > wrote: > >> In D114425#3216231 , @philnik >> wrote: >> >>>

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8877c5ccc0e: [clang] [MinGW] Pass --no-demangle through to the mingw linker (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES

[clang] a8877c5 - [clang] [MinGW] Pass --no-demangle through to the mingw linker

Author: Martin Storsjö Date: 2022-01-03T00:22:40+02:00 New Revision: a8877c5ccc0e05495d60f1669d47826e60f373b8 URL: https://github.com/llvm/llvm-project/commit/a8877c5ccc0e05495d60f1669d47826e60f373b8 DIFF: https://github.com/llvm/llvm-project/commit/a8877c5ccc0e05495d60f1669d47826e60f373b8.diff

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

sammccall updated this revision to Diff 396950. sammccall added a comment. oops, and the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116490/new/ https://reviews.llvm.org/D116490 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-

[PATCH] D116490: [clangd] Code action to declare missing move/copy constructor/assignment

sammccall updated this revision to Diff 396949. sammccall added a comment. Oops, forgot the implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116490/new/ https://reviews.llvm.org/D116490 Files: clang-tools-extra/clangd/ParsedAST.cpp

[PATCH] D114425: [clang] Add __builtin_bswap128

Quuxplusone added a comment. In D114425#3216490 , @craig.topper wrote: > In D114425#3216231 , @philnik wrote: > >> In D114425#3209794 , @craig.topper >> wrote: >> >>> Wh

[PATCH] D114425: [clang] Add __builtin_bswap128

craig.topper added a comment. In D114425#3216231 , @philnik wrote: > In D114425#3209794 , @craig.topper > wrote: > >> What does the builtin due if __int128 isn't supported? Even though the type >> isn't legal th

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

carlosgalvezp added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:141 ^^ +- Added a setting ``bugprone-assert-side-effect.FunctionExceptions`` for + a comma-separated list of the names of functions or methods to be considered -

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161

[PATCH] D115943: [clang] Mixed coroutine namespaces

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb50fea47b6c4: [clang] Allow using std::coroutine_traits in std::experimental (authored by urnathan). Herald added a project: clang. Herald added a s

[clang] b50fea4 - [clang] Allow using std::coroutine_traits in std::experimental

Author: Nathan Sidwell Date: 2022-01-02T15:48:16-05:00 New Revision: b50fea47b6c454581fce89af359f3afe5154986c URL: https://github.com/llvm/llvm-project/commit/b50fea47b6c454581fce89af359f3afe5154986c DIFF: https://github.com/llvm/llvm-project/commit/b50fea47b6c454581fce89af359f3afe5154986c.diff

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood added a comment. In D7982#3216332 , @Eugene.Zelenko wrote: > Functionality-wise this check is superseded by Include What You Use > . That's not part of clang-tidy and has it'

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

LegalizeAdulthood updated this revision to Diff 396941. LegalizeAdulthood added a comment. Move included headers to clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include Stub out included headers to isolate from system headers Run test for C++98 or later CHANGES SINCE

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

MaskRay accepted this revision. MaskRay added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114064/new/ https://reviews.llvm.org/D114064 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] d677a7c - [clang] Remove redundant member initialization (NFC)

Author: Kazu Hirata Date: 2022-01-02T10:20:23-08:00 New Revision: d677a7cb056b17145a50ec8ca2ab6d5f4c494749 URL: https://github.com/llvm/llvm-project/commit/d677a7cb056b17145a50ec8ca2ab6d5f4c494749 DIFF: https://github.com/llvm/llvm-project/commit/d677a7cb056b17145a50ec8ca2ab6d5f4c494749.diff L

[PATCH] D116494: [clang-format] spacesRequiredBetween is not honouring clang-format off/on

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116494/new/ https://reviews.llvm.org/D116494 ___ cfe-commits mailing list cfe-comm

[PATCH] D116164: [clang] More informative mixed namespace diagnostics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f09786e079: [clang] More informative mixed namespace diagnostics (authored by urnathan). Herald added a project: clang. Herald added a subscriber:

[clang] d4f0978 - [clang] More informative mixed namespace diagnostics

Author: Nathan Sidwell Date: 2022-01-02T12:23:13-05:00 New Revision: d4f09786e079361eba1ade1e351be8771d016f29 URL: https://github.com/llvm/llvm-project/commit/d4f09786e079361eba1ade1e351be8771d016f29 DIFF: https://github.com/llvm/llvm-project/commit/d4f09786e079361eba1ade1e351be8771d016f29.diff

[PATCH] D116328: [ast-matchers] Add hasSubstatement() traversal matcher for caseStmt(), defaultStmt(), labelStmt()

LegalizeAdulthood updated this revision to Diff 396933. LegalizeAdulthood added a comment. Document the new matcher in the clang release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116328/new/ https://reviews.llvm.org/D116328 Files: clang/docs/LibASTMatchersReference.html c

[PATCH] D7982: Add readability-duplicate-include check to clang-tidy

Eugene.Zelenko added a comment. Functionality-wise this check is superseded by Include What You Use . Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-duplicate-include.rst:6 + +Looks for duplicate

[PATCH] D116385: [clangd] Code action for creating an ObjC initializer

sammccall added a comment. This looks like a useful feature, I had been thinking about adding the equivalent for C++... High level feedback: - this should generate both the declaration and definition - i doubt the interaction around subsetting fields is going to be satisfying - don't spend comp

[PATCH] D7982: Add readability-duplicate-include check to clang-tidy

LegalizeAdulthood updated this revision to Diff 396932. LegalizeAdulthood added a comment. Herald added a subscriber: carlosgalvezp. Herald added a project: clang-tools-extra. Revive review with updated diff on top-of-tree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D116494: [clang-format] spacesRequiredBetween is not honouring clang-format off/on

MyDeveloperDay updated this revision to Diff 396929. MyDeveloperDay added a comment. Switch to verifyFormat in the tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116494/new/ https://reviews.llvm.org/D116494 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/Form

[PATCH] D116494: [clang-format] spacesRequiredBetween is not honouring clang-format off/on

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: curdeius, HazardyKnusperkeks, owenpan, lahwaacz. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://github.com/llvm/llvm-project/issues/52881 It seems that clang-format

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis updated this revision to Diff 396927. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 Files: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.h clang-too

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:141 ^^ +- Added a setting ``bugprone-assert-side-effect.FunctionExceptions`` for + a comma-separated list of the names of functions or methods to be considered

[PATCH] D116314: [clang-format] Add style to separate definition blocks

ksyx updated this revision to Diff 396926. ksyx added a comment. Add release note entry. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. In D114425#3216233 , @xbolva00 wrote: > int num = …; > > __builtin_bswap64(num); // works, no error > __builtin_bswap128(num); // should work as well > > Highly likely this case works already with ur patch, so it would be great to

[PATCH] D116314: [clang-format] Add style to separate definition blocks

MyDeveloperDay added a comment. Can you add a release note to docs/ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116314/new/ https://reviews.llvm.org/D116314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 updated this revision to Diff 396872. Ericson2314 added a comment. 1. Updating D100810 : [llvm] Use `GNUInstallDirs` to support custom installation dirs # 2. Enter a brief description of the changes included in this update. 3. The first line is used

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

mstorsjo added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS})

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Mark some old threads done. Comment at: llvm/cmake/modules/CMakeLists.txt:3 -set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cmake/llvm) +set(LLVM_INSTALL_PACKAGE_DIR lib${LLVM_LIBDIR_SUFFIX}/cma

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM, could you add a release note into docs/ReleaseNotes.rst? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https:/

[PATCH] D114425: [clang] Add __builtin_bswap128

xbolva00 added a comment. int num = …; __builtin_bswap64(num); // works, no error __builtin_bswap128(num); // should work as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 _

[PATCH] D114425: [clang] Add __builtin_bswap128

philnik added a comment. In D114425#3209794 , @craig.topper wrote: > What does the builtin due if __int128 isn't supported? Even though the type > isn't legal the builtin can still be called with a narrower type that would > be implicitly converted. Do

[PATCH] D116283: [clang-format] Add an option to add a space between operator overloading and opening parentheses

rajatbajpai updated this revision to Diff 396922. rajatbajpai added a comment. Incorporated review comments. 1. Added Check Parse test case for //SpaceBeforeParensOptions//. 2. Renamed the option to //AfterOverloadedOperator//. 3. Added operator overloading instantiation scenario in the unit test

[PATCH] D116485: [clang][MinGW] Explicitly ignore `-fPIC` & friends

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbeeb136abcb: [clang][MinGW] Explicitly ignore `-fPIC` & friends (authored by zero9178). Changed prior to commit: https://reviews.llvm.org/D116485

[clang] dbeeb13 - [clang][MinGW] Explicitly ignore `-fPIC` & friends

Author: Markus Böck Date: 2022-01-02T12:06:54+01:00 New Revision: dbeeb136abcb03eaa85e2ee47a5169f5298e8944 URL: https://github.com/llvm/llvm-project/commit/dbeeb136abcb03eaa85e2ee47a5169f5298e8944 DIFF: https://github.com/llvm/llvm-project/commit/dbeeb136abcb03eaa85e2ee47a5169f5298e8944.diff L

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

mstorsjo added a comment. In D114064#3216147 , @Ericson2314 wrote: > Not sure what the exact division of labor is between the GNU and MinGW > backends, but assuming there is no way to share this between them the patch > looks good. Yeah. Also at this

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis added a comment. In D116478#3216082 , @Eugene.Zelenko wrote: > Please mention new option in Release Notes (in changes in existing checks > section). Done CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.ll

[PATCH] D116478: [clang-tidy] A comma-separated list of the names of functions or methods to be considered as not having side-effects

zinovy.nis updated this revision to Diff 396914. zinovy.nis added a comment. Updated release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116478/new/ https://reviews.llvm.org/D116478 Files: clang-tools-extra/clang-tidy/bugprone/AssertSideEffectCheck.cpp clang-tools-extra/cl

[PATCH] D116485: [clang][MinGW] Explicitly ignore `-fPIC` & friends

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks. The fact that GCC used to emit a non-fatal warning for this option, but no longer does, probably is the key deciding factor here. Repository: rG LLVM Github Monorepo CHAN