[PATCH] D114621: [clangd] Show parameters for construct.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1065 + if (Parameters && !Parameters->empty()) { +Output.addParagraph().appendText("Parameters: "); kadircet wrote: > it's a subtle invarian

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 updated this revision to Diff 390143. lh123 added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114621/new/ https://reviews.llvm.org/D114621 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/u

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin added a comment. In D112881#3155200 , @gchatelet wrote: > LGTM once tests are passing. Maybe wait a bit for a comment from > @aaron.ballman . Thanks @gchatelet. Happy to wait for @aaron.ballman to comment. CHANGES SINCE LAST ACTION https:/

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin added a comment. Thanks for your help @salman-javed-nz. > Build is failing because you don't have a CHECK-MESSAGES-DISABLED line > anywhere in the file. > You could change // DISABLED: to // CHECK-MESSAGES-DISABLED-NOT: and check > for the absence of the check warning. Instead of doi

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 390136. paulaltin added a comment. Fixing column number. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp clang-tool

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

thakis added a comment. In D112287#3146956 , @comanea wrote: > I believe there is an issue that this change introduced. It is described > here. https://bugs.llvm.org/show_bug.cgi?id=52473 > If anyone could provide some insight, it would be much appreciat

[PATCH] D114660: [clang] Fix -Wreturn-type false positive in @try statements

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. After 04f30795f16638 , -Wreturn-type has an effect on functions that contain @try/@catch statements. CheckFallThrough() was

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 390131. paulaltin added a comment. Fixing syntax error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp clang-tools

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 390129. paulaltin added a comment. Fixing bad diff formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp clan

[PATCH] D105177: [clangd] Implemented indexing of standard library

nridge added a comment. What is the status of this -- is it ready to be merged? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105177/new/ https://reviews.llvm.org/D105177 ___ cfe-commits mailing list cfe

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 390127. paulaltin added a comment. Fixing bad diff formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp clan

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

paulaltin updated this revision to Diff 390126. paulaltin added a comment. Add a CHECK-MESSAGES-DISABLED test in an attempt to fix pre-merge checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 Files: clang-tools-extra/clang-tidy/cppcoreg

[PATCH] D113795: Comment Sema: Eliminate or factor out DeclInfo inspection (NFC)

aaronpuchert added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:135-137 + if (const auto *VD = dyn_cast(ThisDeclInfo->CurrentDecl)) +if (VD->getType()->isFunctionPointerType()) + return; Something might be wrong here anyway: th

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. This needs a test like `clang/test/Driver/linux-ld.c` `CHECK-MUSL-PPC`. Use `ninja check-clang-driver` to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

mstorsjo added a comment. In D114651#3156374 , @zero9178 wrote: > Is the deviation from MSVC behaviour here intentional? MSVC flags allow both > using a `/` as well as `-` as prefix. That means Both `-Wall` and `/Wall` are > accepted by MSVC as well as

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

steakhal added a comment. In D113753#3156270 , @bjope wrote: > This seem to cause some weird results. > > Given this input: > > bar(short k) { > k++; > for (short f = 0; f < k; f++) > ; > (long)k << 16; > } > > we get > > > clang

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

zero9178 added a comment. Is the deviation from MSVC behaviour here intentional? MSVC flags allow both using a `/` as well as `-` as prefix. That means Both `-Wall` and `/Wall` are accepted by MSVC as well as clang-cl and in both compilers currently lead to ALL warnings being emitted. So this p

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall updated this revision to Diff 390101. sammccall marked 6 inline comments as done. sammccall edited the summary of this revision. sammccall added a comment. Herald added a subscriber: carlosgalvezp. - Address review comments, make the type class much more concrete - upgrade clang-tools-ex

[PATCH] D114251: [AST] Add a sugar type for types found via UsingDecl

sammccall marked 7 inline comments as done. sammccall added a comment. Thanks a lot for the comments, very helpful. The next revision is much narrower: it'll only sugar exactly the type associated with a UsingShadowDecl. It no longer wraps the underlying type. I've added fixes for all the clang-t

[PATCH] D114653: [OPENMP]Fix error emission for dependent expressions in iterators for depend clauses.

ABataev created this revision. ABataev added reviewers: jdoerfert, mikerice. Herald added subscribers: guansong, yaxunl. ABataev requested review of this revision. Herald added a subscriber: sstefan1. Herald added a project: clang. Need to postpone analysis for addressable lvalue in a depend claus

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 390094. gandhi21299 added a comment. applied clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114553/new/ https://reviews.llvm.org/D114553 Files: clang/include/clang/AST/Expr.h clang/include/

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek added a comment. Noticed I should have waiting with the renaming of the file until the review is done :( Sorry for the extra confusion. Comment at: clang/lib/Format/MacroUnexpander.cpp:77 + // stream, we need to continue the unexpansion until we find the right token +

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

gandhi21299 updated this revision to Diff 390093. gandhi21299 added a comment. addressed feedback including - correction of function signatures - checking for order combinations - correcting expected store atomic instruction - using predefined macros for memory order Repository: rG LLVM Githu

[PATCH] D113753: [Analyzer][Core] Better simplification in SimpleSValBuilder::evalBinOpNN

bjope added a comment. This seem to cause some weird results. Given this input: bar(short k) { k++; for (short f = 0; f < k; f++) ; (long)k << 16; } we get > clang --analyze --target=x86_64 'bbi-63538.c' bbi-63538.c:5:11: warning: The result of the left shift is unde

[PATCH] D114651: [clang-cl] Expose -Wall to clang-cl by unaliasing -Wall, keeping /Wall as alias to -Weverything

saudi created this revision. saudi added reviewers: rnk, hans. saudi added a project: clang. Herald added subscribers: jeroen.dobbelaere, dang. saudi requested review of this revision. Herald added a subscriber: cfe-commits. Currently, for clang-cl, `-Wall` is treated identically as `/Wall` and is

[PATCH] D114649: [libc++] Implement not-yet-voted LWG3436

ldionne added a comment. @rsmith I suspect that enabling array placement new properly will be more complicated than this, but this simple change solved my immediate issue. Please let me know if that's insufficient. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D114649: [libc++] Implement not-yet-voted LWG3436

ldionne created this revision. ldionne added a reviewer: rsmith. ldionne requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. LWG3436 adds support for array types in construct_at. That is ne

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-container-contains.cpp:189 +// NO-WARNING. +// CHECK-FIXES: if (MyMap.count(0)) +return nullptr; whisperity wrote: > If a fix is not generated, wh

[PATCH] D112646: [clang-tidy] Add `readability-container-contains` check

avogelsgesang updated this revision to Diff 390085. avogelsgesang marked 7 inline comments as done. avogelsgesang added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112646/new/ https://reviews.llvm.org/D112646 F

[PATCH] D114522: [clangd] Add desugared type to hover

kadircet added a comment. > My main remaining concern is just that this will trigger too often when > there's no confusion over types, and clutter the display. > Some common cases I'm worried about: > > - std::string -> basic_string. Maybe we should special-case this to > hide the aka? > - int64

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 390082. RKSimon added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/UsersMa

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not MS

[PATCH] D114621: [clangd] Show parameters for construct.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:1065 + if (Parameters && !Parameters->empty()) { +Output.addParagraph().appendText("Parameters: "); it's a subtle invariant that we only have parameters for functions (which has

[PATCH] D112420: [clang][ARM] PACBTI-M assembly support

labrinea accepted this revision. labrinea added a comment. This revision is now accepted and ready to land. Looks like you've addressed Oliver's comments. I don't have any new suggestions from my end. Just make sure you've removed the test xfail before merging. Comment at: cla

[PATCH] D114553: [HIP] Add atomic load, atomic store and atomic cmpxchng_weak builtin support in HIP-clang

yaxunl added inline comments. Comment at: clang/test/CodeGenCUDA/atomic-ops.cu:14 +// CHECK: load atomic i32, i32* {{%[0-9]+}} syncscope("singlethread-one-as") monotonic, align 4 +// CHECK: store i32 {{%[0-9]+}}, i32* %{{.*}}, align 4 +// CHECK: cmpxchg weak i32* {{%[0-9]+}}, i3

[PATCH] D88299: [clang-format] Add MacroUnexpander.

klimek updated this revision to Diff 390057. klimek marked 49 inline comments as done. klimek added a comment. Work in review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88299/new/ https://reviews.llvm.org/D88299 Files: clang/lib/For

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG34cc210aa8af: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to… (authored by kbobyrev). Repository: rG LLVM Github Mo

[clang-tools-extra] 34cc210 - [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

Author: Kirill Bobyrev Date: 2021-11-26T16:20:48+01:00 New Revision: 34cc210aa8af2fd33598e5559d0f5b51f9423dd6 URL: https://github.com/llvm/llvm-project/commit/34cc210aa8af2fd33598e5559d0f5b51f9423dd6 DIFF: https://github.com/llvm/llvm-project/commit/34cc210aa8af2fd33598e5559d0f5b51f9423dd6.diff

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 390052. kbobyrev added a comment. Add some docs for the helper function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114623/new/ https://reviews.llvm.org/D114623 Files: clang-tools-extra/clangd/IncludeCle

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev updated this revision to Diff 390051. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114623/new/ https://reviews.llvm.org/D114623 Files: clang-

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

balazske marked 5 inline comments as done. balazske added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:19-20 The check assumes that any user-defined ``operator new`` is either ``noexcept`` or may throw an excepti

[PATCH] D114602: [clang-tidy][docs][NFC] Improve documentation of bugprone-unhandled-exception-at-new

balazske updated this revision to Diff 390048. balazske added a comment. Apply of review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114602/new/ https://reviews.llvm.org/D114602 Files: clang-tools-extra/docs/clang-tidy/checks/bugpro

[PATCH] D114256: [clang-tidy] Fix crashing altera-struct-pack-align on invalid RecordDecls

steakhal added a comment. I plan to commit this stack on Monday. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114256/new/ https://reviews.llvm.org/D114256 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D114522: [clangd] Add desugared type to hover

sammccall added a comment. This looks pretty good in terms of behavior, some impl comments but we should land this. My main remaining concern is just that this will trigger too often when there's no confusion over types, and clutter the display. Some common cases I'm worried about: - std::stri

[PATCH] D113558: [clang-tidy] Fix cppcoreguidelines-virtual-base-class-destructor in macros

steakhal added a comment. In D113558#3154967 , @whisperity wrote: > I'm not sure if it is a good idea to merge things on a Friday, but I am > comfortable with this, let's get the check crash less. I've run this on a few projects and it did not introduc

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

jhenderson added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 16 2019" -T LLVM .. Maybe make this VS2022 instead, to help it last longer? Comment at

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon created this revision. RKSimon added reviewers: rnk, aaron.ballman, zturner, jhenderson, Meinersbur, jansvoboda11, gbedwell. Herald added subscribers: dexonsmith, mstorsjo, mgorny. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev added a comment. Thanks Gábor and Dmitri! Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:48 +/// Type-erased base class for dataflow analyses built on a single lattice type. +class DataflowAnalysisDynamic { +public: xazax.hun

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 390034. sgatev added a comment. Minor tweaks to documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ https://reviews.llvm.org/D114234 Files: clang/include/clang/Analysis/FlowSensitive/Data

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added a comment. > Sorry for forgetting about this one. Hopefully I can still help now by > disagreeing with Kadir and creating an awkward stalemate instead. Haha, always welcome! > Partly because the ordering isn't some weird coincidence (see below) Right, I suppose it makes sense wh

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:54-55 const NestedNameSpecifier *Right) { - llvm::FoldingSetNodeID LeftID, RightID; - Left->Profile(LeftID); - Right->Profile(Righ

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal updated this revision to Diff 390032. steakhal marked 3 inline comments as done. steakhal added a comment. Fixing nits: renaming variables, etc. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114622/new/ https://reviews.llvm.org/D114622 Files: clang-tools-extra/clang-tidy/bug

[PATCH] D114234: [clang][dataflow] Add base types for building dataflow analyses

sgatev updated this revision to Diff 390029. sgatev marked 3 inline comments as done. sgatev added a comment. Replace "Dynamic" with "TypeErased" in the names of types and their members. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114234/new/ htt

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd0ca5a0eaa1: [clangd] Record information about non self-contained headers in IncludeStructure (authored by kbobyrev). Repository: rG LLVM Github

[clang-tools-extra] cd0ca5a - [clangd] Record information about non self-contained headers in IncludeStructure

Author: Kirill Bobyrev Date: 2021-11-26T14:12:54+01:00 New Revision: cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c URL: https://github.com/llvm/llvm-project/commit/cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c DIFF: https://github.com/llvm/llvm-project/commit/cd0ca5a0eaa1b75b445e82753ea093bbb8e7e85c.diff

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + sammccall wrote: > kbobyrev wrote: > > sammccall wrote: > > > could consider `friend class RecordHe

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 390024. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Get rid of the setter in IncludeStructure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D11437

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal updated this revision to Diff 390023. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114622/new/ https://reviews.llvm.org/D114622 Files: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp c

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal added a comment. In D114622#3155605 , @whisperity wrote: > I haven't looked at the patch in detail yet, but I know I've run into the > issue this aims to fix when developing a Tidy check! > > There is a `// NOLINTNEXTLINE(misc-redundant-express

[PATCH] D112421: [clang][ARM] PACBTI-M frontend support

stuij updated this revision to Diff 390021. stuij added a comment. addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112421/new/ https://reviews.llvm.org/D112421 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td c

[PATCH] D114197: [clang-tidy] Fix false positives involving type aliases in `misc-unconventional-assign-operator` check

whisperity added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/misc-unconventional-assign-operator.cpp:151 + using Alias3 = TemplateTypeAlias; + Alias3 &operator=(int) { return *this; } +}; This is a no-warn due to the parameter being

[clang] 97e504c - [clang][deps] NFC: Extract function

Author: Jan Svoboda Date: 2021-11-26T14:01:24+01:00 New Revision: 97e504cff956b7120da9bd932644b00a853ee68a URL: https://github.com/llvm/llvm-project/commit/97e504cff956b7120da9bd932644b00a853ee68a DIFF: https://github.com/llvm/llvm-project/commit/97e504cff956b7120da9bd932644b00a853ee68a.diff L

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:54-55 const NestedNameSpecifier *Right) { - llvm::FoldingSetNodeID LeftID, RightID; - Left->Profile(LeftID); - Right->Profile(Ri

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + kbobyrev wrote: > sammccall wrote: > > could consider `friend class RecordHeaders`, either is ugly

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

sammccall added a comment. Didn't really address this part > But I don't think it matters in the long run especially when we want to > handle different types of pragmas in the future > So I'd suggest just building a side table information That's a more general approach for sure. But it does see

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa3b099b68c0c: [Docs] Removed /Zd flag still mentioned in documentation (authored by BHUMITRAM, committed by xgupta). Repository: rG LLVM Github Mo

[clang] a3b099b - [Docs] Removed /Zd flag still mentioned in documentation

Author: Bhumitram Kumar Date: 2021-11-26T18:08:06+05:30 New Revision: a3b099b68c0c156aa8ed9ec81c5dfdf150c6329c URL: https://github.com/llvm/llvm-project/commit/a3b099b68c0c156aa8ed9ec81c5dfdf150c6329c DIFF: https://github.com/llvm/llvm-project/commit/a3b099b68c0c156aa8ed9ec81c5dfdf150c6329c.dif

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114632/new/ https://reviews.llvm.org/D114632 __

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

whisperity added a comment. I haven't looked at the patch in detail yet, but I know I've run into the issue this aims to fix when developing a Tidy check! There is a `// NOLINTNEXTLINE(misc-redundant-expression)` directive in the source file `clang-tools-extra/clang-tidy/bugprone/EasilySwappab

[PATCH] D114632: [Docs] Removed /Zd flag still mentioned in documentation

BHUMITRAM created this revision. BHUMITRAM added reviewers: aaron.ballman, xgupta. BHUMITRAM requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D93458 removed the /Zd flag as MSVC doesn't support that syntax. Instead

[PATCH] D114602: [clang-tidy] Improve documentation of bugprone-unhandled-exception-at-new [NFC]

whisperity added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst:8-10 Calls to ``new`` can throw exceptions of type ``std::bad_alloc`` that should be handled by the code. Alternatively, the nonthrowing form of ``new

[libunwind] 632acec - [libunwind][ARM] Handle end of stack during unwind

Author: Daniel Kiss Date: 2021-11-26T13:26:49+01:00 New Revision: 632acec73776c4d6f7073d6de04ed6b8bfd36e6d URL: https://github.com/llvm/llvm-project/commit/632acec73776c4d6f7073d6de04ed6b8bfd36e6d DIFF: https://github.com/llvm/llvm-project/commit/632acec73776c4d6f7073d6de04ed6b8bfd36e6d.diff L

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

This revision was automatically updated to reflect the committed changes. Closed by commit rG632acec73776: [libunwind][ARM] Handle end of stack during unwind (authored by danielkiss). Herald added projects: libc++abi, libunwind. Herald added 1 blocking reviewer(s): libc++abi. Repository: rG LLV

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + sammccall wrote: > could consider `friend class RecordHeaders`, either is ugly, up to you That was

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

sammccall added a comment. Sorry for forgetting about this one. Hopefully I can still help now by disagreeing with Kadir and creating an awkward stalemate instead. I agree that the ownership situation is ugly, but I think a single object here is still simpler. Partly because the ordering isn't

[PATCH] D114072: [clangd] Record IWYU pragma keep in the IncludeStructure

kadircet added a comment. It's annoying that we see comments and inclusion directives out-of-order, we can try fixing it on the parser side (I think it is incidental that these are issued in that order currently, they are eagerly trying to generate a fix/diagnostic for tokens after a pp-directi

[PATCH] D114533: LLVM IR should allow bitcast between address spaces with the same size.

skc7 updated this revision to Diff 389983. skc7 added a comment. Updated diff with changes suggested by jrtc27 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114533/new/ https://reviews.llvm.org/D114533 Files: clang/lib/CodeGen/CGAtomic.cpp llvm/docs/LangRef.rst llvm/include/llvm/

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with a couple of readability things Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:259 +for (const FileEntry *FE = SM.getFileEntryForID(ID); + I

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. In D109856#3155235 , @danielkiss wrote: > In D109856#3154763 , @mstorsjo > wrote: > >> Looks reasonable

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/Headers.h:167 + void recordNonSelfContained(HeaderID ID) { NonSelfContained.insert(ID); } + could consi

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

steakhal added a comment. I see. Simplification is always good. Let's measure and compare the runtime characteristics before moving forward. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:2226 + // + // Empirical measurements show that if we rel

[clang] 12eafd9 - [clang][deps] NFC: Clean up wording (ignored vs minimized)

Author: Jan Svoboda Date: 2021-11-26T12:18:37+01:00 New Revision: 12eafd944e0ffccae93402ddbe2855beb7a939ff URL: https://github.com/llvm/llvm-project/commit/12eafd944e0ffccae93402ddbe2855beb7a939ff DIFF: https://github.com/llvm/llvm-project/commit/12eafd944e0ffccae93402ddbe2855beb7a939ff.diff L

[clang] d8a3538 - [clang][deps] NFC: Remove else after early return

Author: Jan Svoboda Date: 2021-11-26T12:18:37+01:00 New Revision: d8a35387881bf408c19deeba7b5e3648dbbf467c URL: https://github.com/llvm/llvm-project/commit/d8a35387881bf408c19deeba7b5e3648dbbf467c DIFF: https://github.com/llvm/llvm-project/commit/d8a35387881bf408c19deeba7b5e3648dbbf467c.diff L

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

steakhal added a comment. In D103317#3155191 , @martong wrote: >> Please repeat the measurement for `openssl`. There must have been some >> interference in the memory consumption. Aside from that the results look >> great. > > I did. Average memory usag

[PATCH] D114623: [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. When a symbol comes f

[PATCH] D114522: [clangd] Add desugared type to hover

lh123 updated this revision to Diff 389968. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114522/new/ https://reviews.llvm.org/D114522 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h clang-tools-extra/clangd/unittest

[PATCH] D114622: [clang-tidy][analyzer] Fix false-positive in IdenticalExprChecker and misc-redundant-expression

steakhal created this revision. steakhal added reviewers: aaron.ballman, alexfh, hokein, courbet, NoQ, xazax.hun, martong, whisperity, davrec. Herald added subscribers: carlosgalvezp, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsof

[PATCH] D114621: [clangd] Show parameters for construct.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. lh123 added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. lh123 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Show parameters for construct.

[PATCH] D109856: [libunwind][ARM] Handle end of stack during unwind

danielkiss added a comment. In D109856#3154763 , @mstorsjo wrote: > Looks reasonable I think. Is this a deficiency in the EHABI implementation > only, i.e. this aspect works as it should in the regular dwarf implementation? Yes, it works on dwarf alread

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

gchatelet added a comment. LGTM once tests are passing. Maybe wait a bit for a comment from @aaron.ballman . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 ___ cfe-commits mailing list cfe-commits@

[PATCH] D103317: [Analyzer][Core] Make SValBuilder to better simplify svals with 3 symbols in the tree

martong added a comment. > Please repeat the measurement for `openssl`. There must have been some > interference in the memory consumption. Aside from that the results look > great. I did. Average memory usage is unaffected. F20722167: svalbuilder_improvements_openssl.png

[PATCH] D114619: [Analyzer][solver] Do not remove the simplified symbol from the eq class

martong created this revision. martong added a reviewer: steakhal. Herald added subscribers: manas, ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. martong requested review of

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-narrowingintegertofloatingpoint-option.cpp:12 + // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:14: warning: narrowing conversion from 'unsigned long l

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389953. kbobyrev added a comment. Get the changes back to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-tools-extra/clangd/CodeComplete.

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389952. kbobyrev added a comment. Change base to D114370 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114370/new/ https://reviews.llvm.org/D114370 Files: clang-tools-ext

[PATCH] D112881: [clang-tidy] Allow disabling integer to floating-point narrowing conversions for cppcoreguidelines-narrowing-conversions

salman-javed-nz added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narrowing-conversions-narrowingintegertofloatingpoint-option.cpp:12 + // CHECK-MESSAGES-DEFAULT: :[[@LINE-1]]:14: warning: narrowing conversion from 'unsigned long l

[PATCH] D114609: [clang] Fix crash on broken parameter declarators

This revision was automatically updated to reflect the committed changes. kadircet marked 2 inline comments as done. Closed by commit rGd026f2f7c688: [clang] Fix crash on broken parameter declarators (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D114609?vs=389851&id=

[clang] d026f2f - [clang] Fix crash on broken parameter declarators

Author: Kadir Cetinkaya Date: 2021-11-26T10:56:54+01:00 New Revision: d026f2f7c688b326eae429286a06bf4080c8b527 URL: https://github.com/llvm/llvm-project/commit/d026f2f7c688b326eae429286a06bf4080c8b527 DIFF: https://github.com/llvm/llvm-project/commit/d026f2f7c688b326eae429286a06bf4080c8b527.dif

[PATCH] D114579: [clang-tidy] Exempt _MSVC_EXECUTION_CHARACTER_SET from cppcoreguidelines-macro-usage

lebedev.ri resigned from this revision. lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp:40 const MacroDirective *MD) override { if (SM.isWrittenInBuiltinFile(MD->getLocation()) ||

[PATCH] D114370: [clangd] Record information about non self-contained headers in IncludeStructure

kbobyrev updated this revision to Diff 389950. kbobyrev added a comment. [clangd] IncludeCleaner: Attribute symbols from non self-contained headers to their parents When a symbol comes from the non self-contained header, we recursively uplift the file we consider used to the first includer that

  1   2   >