[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

sammccall added a comment. Thanks Christian! Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112996/new/ https://reviews.llvm.org/D112996 ___ cfe-commits mailing list cfe-commits@lists

[clang-tools-extra] 63667c1 - [clangd] Trace per-token time in clangd --check

Author: Sam McCall Date: 2021-11-10T08:22:48+01:00 New Revision: 63667c1896e11a4b2c389c681a2413e2d5a6b594 URL: https://github.com/llvm/llvm-project/commit/63667c1896e11a4b2c389c681a2413e2d5a6b594 DIFF: https://github.com/llvm/llvm-project/commit/63667c1896e11a4b2c389c681a2413e2d5a6b594.diff LO

[PATCH] D112996: [CodeCompletion] Generally consider header files without extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7500a4ef7bd: [CodeCompletion] Generally consider header files without extension (authored by ckandeler, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] f7500a4 - [CodeCompletion] Generally consider header files without extension

Author: Christian Kandeler Date: 2021-11-10T08:22:48+01:00 New Revision: f7500a4ef7bd7820b42e1b934392bb2566083b27 URL: https://github.com/llvm/llvm-project/commit/f7500a4ef7bd7820b42e1b934392bb2566083b27 DIFF: https://github.com/llvm/llvm-project/commit/f7500a4ef7bd7820b42e1b934392bb2566083b27.

[PATCH] D113523: Add toggling for -fnew-infallible/-fno-new-infallible

modimo updated this revision to Diff 386059. modimo added a comment. Add driver test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113523/new/ https://reviews.llvm.org/D113523 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang

[PATCH] D113450: [clang-tidy] Fix llvm-header-guard so that it works with Windows paths

salman-javed-nz added a comment. @aaron.ballman - I've added the unit test for UNC path as you suggested. Since you've already given the LGTM, I assume you don't need to see the patch again, so I have gone ahead with the commit. Anyway, I'll be around to address any problems if they crop up. R

[PATCH] D113450: [clang-tidy] Fix llvm-header-guard so that it works with Windows paths

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4f6f1c9369e: [clang-tidy] Fix llvm-header-guard so that it works with Windows paths (authored by salman-javed-nz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] b4f6f1c - [clang-tidy] Fix llvm-header-guard so that it works with Windows paths

Author: Salman Javed Date: 2021-11-10T18:35:57+13:00 New Revision: b4f6f1c9369ec4bb1c10852283a8c7e8c39e1a8d URL: https://github.com/llvm/llvm-project/commit/b4f6f1c9369ec4bb1c10852283a8c7e8c39e1a8d DIFF: https://github.com/llvm/llvm-project/commit/b4f6f1c9369ec4bb1c10852283a8c7e8c39e1a8d.diff

[clang] 770ddf5 - Fix unused variable warning in release build

Author: Jorge Gorbe Moya Date: 2021-11-09T19:48:42-08:00 New Revision: 770ddf599d28e8b0aef38166bed899b0194f4d8b URL: https://github.com/llvm/llvm-project/commit/770ddf599d28e8b0aef38166bed899b0194f4d8b DIFF: https://github.com/llvm/llvm-project/commit/770ddf599d28e8b0aef38166bed899b0194f4d8b.di

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

salman-javed-nz updated this revision to Diff 386047. salman-javed-nz added a comment. Revert to using simple string literals. I was being too clever for my own good with the Twine. I think this should no longer cause ASan issues. WDYT? This was meant to be a simple patch, so sorry for all the t

[PATCH] D113538: OpenMP: Start calling setTargetAttributes for generated kernels

arsenm created this revision. arsenm added reviewers: jdoerfert, JonChesterfield, ronlieb, gregrodgers. Herald added subscribers: guansong, yaxunl, jvesely. arsenm requested review of this revision. Herald added subscribers: sstefan1, wdng. This wasn't setting any of the attributes the target woul

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b9a85d10ac7: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 3b9a85d - [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

Author: hsmahesha Date: 2021-11-10T08:45:21+05:30 New Revision: 3b9a85d10ac7a073c95b35adca379281ac6ecbcb URL: https://github.com/llvm/llvm-project/commit/3b9a85d10ac7a073c95b35adca379281ac6ecbcb DIFF: https://github.com/llvm/llvm-project/commit/3b9a85d10ac7a073c95b35adca379281ac6ecbcb.diff LOG

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm added a comment. Thanks @rnk and @yaxunl . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D113168: [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

This revision was automatically updated to reflect the committed changes. Closed by commit rG7352f42cdc3c: [clang-tblgen] Fix non-determinism in generating… (authored by ikudrin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113168/new/ https://rev

[PATCH] D113477: [clang-tblgen] Fix non-determinism in generating AttributeReference.rst

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b7ea8e62921: [clang-tblgen] Fix non-determinism in generating AttributeReference.rst (authored by ikudrin). Repository: rG LLVM Github Monorepo

[clang] 7352f42 - [clang-tblgen] Fix non-determinism in generating AttrSubMatchRulesParserStringSwitches.inc

Author: Igor Kudrin Date: 2021-11-10T10:08:06+07:00 New Revision: 7352f42cdc3c44038408edcdc4eb9890546020eb URL: https://github.com/llvm/llvm-project/commit/7352f42cdc3c44038408edcdc4eb9890546020eb DIFF: https://github.com/llvm/llvm-project/commit/7352f42cdc3c44038408edcdc4eb9890546020eb.diff L

[clang] 5b7ea8e - [clang-tblgen] Fix non-determinism in generating AttributeReference.rst

Author: Igor Kudrin Date: 2021-11-10T10:08:07+07:00 New Revision: 5b7ea8e62921e53fdea73d948eb0d48c071d4b73 URL: https://github.com/llvm/llvm-project/commit/5b7ea8e62921e53fdea73d948eb0d48c071d4b73 DIFF: https://github.com/llvm/llvm-project/commit/5b7ea8e62921e53fdea73d948eb0d48c071d4b73.diff L

[PATCH] D113425: gcc extension # NNN directive lines

aaronpuchert added inline comments. Comment at: clang/docs/LanguageExtensions.rst:4058 + +* ``1`:` Push the current source file name onto the include stack and + enter a new file. urnathan wrote: > aaronpuchert wrote: > > Produces > > > > ``` > > /home/buildbot

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Oh, OK. If this is not the direction the community want, we might not go on this direction. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113391/new/ https://reviews.llvm.org/D113391 _

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

andrew.w.kaylor added inline comments. Comment at: clang/test/CodeGen/ffp-model.c:4 +// RUN: | FileCheck %s \ +// RUN: --check-prefixes=CHECK,CHECK-FAST --strict-whitespace + Why did you add the strict-whitespace option? Comment at: clang/test/

[PATCH] D113529: [asan] Minimal fix for PR52382

vitalybuka created this revision. Herald added a subscriber: ormris. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Alternative to a55c4ec1cee7683d9095327d9d33e7137ec25292

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3145-3148 + else { +assert(Left.is(TT_RequiresExpression)); +return Style.SpaceBeforeParensOptions.AfterRequiresExpression; + } Nit: remove `else`. Reposito

[PATCH] D113523: Add toggling for -fnew-infallible/-fno-new-infallible

bruno added a comment. Hi @modimo, can you also add a driver test to check (`clang/test/Driver/...`) that nothing is added to cc1 cmdline when `-fno-new-infallible` is used or take precendence? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113523/

[PATCH] D107994: Making the code compliant to the documentation about Floating Point support default values for C/C++. FPP-MODEL=PRECISE enables FFP-CONTRACT (FMA is enabled).

zahiraam updated this revision to Diff 386014. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107994/new/ https://reviews.llvm.org/D107994 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D113517: Correct handling of the 'throw()' exception specifier in C++17.

rsmith added a comment. What's the motivation for this change? I believe the current behavior is still conforming: `set_unexpected` is no longer (officially) part of the standard library (though it still exists as a zombie name), and the default `unexpected` handler calls `terminate`, so callin

[PATCH] D113425: gcc extension # NNN directive lines

urnathan marked an inline comment as done. urnathan added inline comments. Comment at: clang/docs/LanguageExtensions.rst:4058 + +* ``1`:` Push the current source file name onto the include stack and + enter a new file. aaronpuchert wrote: > Produces > > ``` > /

[PATCH] D113523: Add toggling for -fnew-infallible/-fno-new-infallible

modimo updated this revision to Diff 385996. modimo added a comment. Remove whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113523/new/ https://reviews.llvm.org/D113523 Files: clang/docs/ClangCommandLineReference.rst clang/incl

[clang] da979f6 - [clang] Fix restructured markup

Author: Nathan Sidwell Date: 2021-11-09T18:41:22-05:00 New Revision: da979f6cf82111d58285a96bce1febd486d65b34 URL: https://github.com/llvm/llvm-project/commit/da979f6cf82111d58285a96bce1febd486d65b34 DIFF: https://github.com/llvm/llvm-project/commit/da979f6cf82111d58285a96bce1febd486d65b34.diff

[PATCH] D113523: Add toggling for -fnew-infallible/-fno-new-infallible

modimo created this revision. Herald added subscribers: hoy, wenlei, lxfind, dang. modimo requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.ll

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

rnk added a comment. In D112492#3119892 , @tra wrote: > Yes, we do need to merge identical functions with **identical names** for > templates. > > The comdat-folding issue is different. IIUIC, it allows merging two functions > with identical code and **

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

nikic accepted this revision. nikic added a comment. LGTM as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113304/new/ https://reviews.llvm.org/D113304 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D112890: headers: optionalise some generated resource headers

jrtc27 added a comment. And I don't see any AArch64 or ARM maintainers ACKing this. You haven't even tagged any as reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890 _

[PATCH] D112663: [clang-repl] Allow Interpreter::getSymbolAddress to take a mangled name.

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Interpreter/Interpreter.h:72 + + ///\returns the \c JITTargetAddress of a \c GlobalDecl. This interface uses + /// the CodeGenModule's i

[PATCH] D112890: headers: optionalise some generated resource headers

jrtc27 added a comment. This change seems pretty counter to Clang's ability to spit out IR for anything regardless of what backends you have. The right fix should be to shrink the headers, not mask the problem by changing the principles of how Clang works. Repository: rG LLVM Github Monorepo

[PATCH] D112890: headers: optionalise some generated resource headers

MaskRay added a comment. But thanks for the work: people not enabling RISCV should not incur so much overhead. I hope that RISC-V vector contributors can really bear the cost in mind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ http

[PATCH] D113451: [PowerPC] [Clang] Enable Intel intrinsics support on FreeBSD

adalava updated this revision to Diff 385985. adalava added a comment. fix style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113451/new/ https://reviews.llvm.org/D113451 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Driver/Driver.cpp cl

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

tra added a comment. Yes, we do need to merge identical functions with **identical names** for templates. The comdat-folding issue is different. IIUIC, it allows merging two functions with identical code and **different names**, into one function with two names. That will break CUDA as we do n

[PATCH] D112890: headers: optionalise some generated resource headers

MaskRay added a comment. I remember that `NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py` needs to be the first line... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890 ___

[PATCH] D113304: [NewPM] Only invalidate modified functions' analyses in CGSCC passes + turn on eagerly invalidate analyses

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. LGTM, but please wait to see if @nikic has additional comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113304/new/ https://reviews.ll

[PATCH] D111463: [OpenMP] Remove doing assumption propagation in the front end.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b5c3e591d74: [OpenMP] Remove doing assumption propagation in the front end. (authored by jhuber6). Changed prior to commit: https://reviews.llvm.

[clang] 4b5c3e5 - [OpenMP] Remove doing assumption propagation in the front end.

Author: Joseph Huber Date: 2021-11-09T17:39:24-05:00 New Revision: 4b5c3e591d74f0f5810608b45ede58f3d489e14d URL: https://github.com/llvm/llvm-project/commit/4b5c3e591d74f0f5810608b45ede58f3d489e14d DIFF: https://github.com/llvm/llvm-project/commit/4b5c3e591d74f0f5810608b45ede58f3d489e14d.diff

[PATCH] D113447: [sancov] add tracing for loads and store

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7f3a4f4fa14: [sancov] add tracing for loads and store (authored by kcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

yaxunl added a comment. I think probably it is necessary to merge linkonce_odr symbols for them to work properly. Consider the following testcase: // a.cu template __global__ void foo(T x) {} void test1() { foo<<<1,1>>>(1); } // b.cu template __global__ void foo(T x)

[PATCH] D113518: [clang] Create delegating constructors even in templates

fwolff created this revision. fwolff added reviewers: rsmith, dblaikie, carlosgalvezp. fwolff added a project: clang. Herald added subscribers: kbarton, nemanjai. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Herald added a project: clang-tools-extra. This fixes

[PATCH] D113517: Correct handling of the 'throw()' exception specifier in C++17.

jyknight created this revision. jyknight added a reviewer: aaron.ballman. jyknight requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Per C++17 [except.spec], 'throw()' has become equivalent to 'noexcept', and should therefore call std::termin

[clang] 50082e1 - Fix test after aee49255074fd4ef38d97e6e70cbfbf2f9fd0fa7.

Author: James Y Knight Date: 2021-11-09T16:59:45-05:00 New Revision: 50082e1882ae7fe101e563c5e18a27e0804d517b URL: https://github.com/llvm/llvm-project/commit/50082e1882ae7fe101e563c5e18a27e0804d517b DIFF: https://github.com/llvm/llvm-project/commit/50082e1882ae7fe101e563c5e18a27e0804d517b.diff

[PATCH] D113352: [clang] Run LLVM Verifier in modes without CodeGen too

This revision was automatically updated to reflect the committed changes. Closed by commit rG9efce0baee4b: [clang] Run LLVM Verifier in modes without CodeGen too (authored by ibookstein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113352/new/ htt

[clang] 9efce0b - [clang] Run LLVM Verifier in modes without CodeGen too

Author: Itay Bookstein Date: 2021-11-09T23:57:13+02:00 New Revision: 9efce0baee4bdda9d824716668ac3d3027bfa318 URL: https://github.com/llvm/llvm-project/commit/9efce0baee4bdda9d824716668ac3d3027bfa318 DIFF: https://github.com/llvm/llvm-project/commit/9efce0baee4bdda9d824716668ac3d3027bfa318.diff

[PATCH] D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b1fd19357be: [CodeGen] Diagnose and reject non-function ifunc resolvers (authored by ibookstein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rGce91540beeff: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen (authored by ibookstein). Changed prior to commit: https://reviews.llvm.org/D113431?vs=385923&id=385966#toc Repository: rG

[PATCH] D113504: [clang][test][NFC] clang-format attr-ifunc.c test

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f04f7d816f3: [clang][test][NFC] clang-format attr-ifunc.c test (authored by ibookstein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113504/new/ https://

[clang] 3b1fd19 - [CodeGen] Diagnose and reject non-function ifunc resolvers

Author: Itay Bookstein Date: 2021-11-09T23:51:36+02:00 New Revision: 3b1fd19357be50cec8a5be8660806e0e02e84aa1 URL: https://github.com/llvm/llvm-project/commit/3b1fd19357be50cec8a5be8660806e0e02e84aa1 DIFF: https://github.com/llvm/llvm-project/commit/3b1fd19357be50cec8a5be8660806e0e02e84aa1.diff

[clang] ce91540 - [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

Author: Itay Bookstein Date: 2021-11-09T23:51:29+02:00 New Revision: ce91540beeff08ddef826c0819fbaabfd4aefc86 URL: https://github.com/llvm/llvm-project/commit/ce91540beeff08ddef826c0819fbaabfd4aefc86 DIFF: https://github.com/llvm/llvm-project/commit/ce91540beeff08ddef826c0819fbaabfd4aefc86.diff

[clang] 4f04f7d - [clang][test][NFC] clang-format attr-ifunc.c test

Author: Itay Bookstein Date: 2021-11-09T23:51:22+02:00 New Revision: 4f04f7d816f3cb5c83c87fdf0468f8090ea9e44d URL: https://github.com/llvm/llvm-project/commit/4f04f7d816f3cb5c83c87fdf0468f8090ea9e44d DIFF: https://github.com/llvm/llvm-project/commit/4f04f7d816f3cb5c83c87fdf0468f8090ea9e44d.diff

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

ibookstein added a comment. Right; well, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113431/new/ https://reviews.llvm.org/D113431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D113425: gcc extension # NNN directive lines

aaronpuchert added inline comments. Comment at: clang/docs/LanguageExtensions.rst:4058 + +* ``1`:` Push the current source file name onto the include stack and + enter a new file. Produces ``` /home/buildbot/llvm-build-dir/clang-sphinx-docs/llvm/build/tools/cla

[PATCH] D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers

ibookstein added a comment. Yeah, it's real ugly from a CFE/LLVM separation POV. I also can't avoid seeing it as a duplication of the verifier's logic. But emitting diagnoses is better than asserting/crashing... For the recursion, maybe an equivalent of `getAliaseeObject` on `GlobalDecl`-s coul

[PATCH] D112914: Misleading identifier detection

serge-sans-paille added a comment. In D112914#3119704 , @thakis wrote: > The test seems to trigger an assert: http://45.33.8.238/linux/60293/step_9.txt > > Please take a look! It's getting late here: Reverted, I'll have a look tomorrow. Repository: r

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D113431#3119716 , @ibookstein wrote: > If you meant fusing the clang-format commit with this one, doing it in the > same commit results in

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

ibookstein added a comment. If you meant fusing the clang-format commit with this one, doing it in the same commit results in git no longer detecting the connection between them (similarity too low), so it loses the history. When searching I found a recommendation

[PATCH] D113491: [HIP] Fix device stub name for Windows

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:975-976 + llvm::SmallString<128> Buf; + mangleSourceName((llvm::Twine("__device_stub__") + II->getName()) + .toStri

[PATCH] D112914: Misleading identifier detection

thakis added a comment. The test seems to trigger an assert: http://45.33.8.238/linux/60293/step_9.txt Please take a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112914/new/ https://reviews.llvm.org/D112914

[PATCH] D111266: Comment AST: Add support for variable templates

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG63ef0e17e288: Comment AST: Add support for variable templates (authored by aaronpuchert). Changed pri

[PATCH] D111264: Comment AST: Declare function pointer variables as functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d6382430066: Comment AST: Declare function pointer variables as functions (authored by aaronpuchert). Changed prior to commit: https://reviews.ll

[clang] 63ef0e1 - Comment AST: Add support for variable templates

Author: Aaron Puchert Date: 2021-11-09T22:30:09+01:00 New Revision: 63ef0e17e28827eae53133b3467bdac7d9729318 URL: https://github.com/llvm/llvm-project/commit/63ef0e17e28827eae53133b3467bdac7d9729318 DIFF: https://github.com/llvm/llvm-project/commit/63ef0e17e28827eae53133b3467bdac7d9729318.diff

[clang] 4d63824 - Comment AST: Declare function pointer variables as functions

Author: Aaron Puchert Date: 2021-11-09T22:30:08+01:00 New Revision: 4d6382430066465774f6f696ea3f4c402da1d705 URL: https://github.com/llvm/llvm-project/commit/4d6382430066465774f6f696ea3f4c402da1d705 DIFF: https://github.com/llvm/llvm-project/commit/4d6382430066465774f6f696ea3f4c402da1d705.diff

[PATCH] D111262: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

This revision was automatically updated to reflect the committed changes. aaronpuchert marked an inline comment as done. Closed by commit rG3506e42ab67e: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHA

[clang] 3506e42 - Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

Author: Aaron Puchert Date: 2021-11-09T22:30:08+01:00 New Revision: 3506e42ab67eef41a1f27e180e7c552a27bb URL: https://github.com/llvm/llvm-project/commit/3506e42ab67eef41a1f27e180e7c552a27bb DIFF: https://github.com/llvm/llvm-project/commit/3506e42ab67eef41a1f27e180e7c552a27bb.diff

[PATCH] D111264: Comment AST: Declare function pointer variables as functions

aaronpuchert added a comment. In D111264#3115104 , @gribozavr2 wrote: > I feel uneasy about claiming that variable decls of function type are > FunctionKind for the purposes of comment parsing (even doing it for typedefs > is questionable). It seems li

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added a comment. Ping. `clang-format` is the only check failing as of now (attempting to reformat the `` links in doc comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109701/new/ https://reviews.llvm.org/D109701

[PATCH] D113474: [clang] Don't crash on an incomplete-type base specifier in template context.

This revision was automatically updated to reflect the committed changes. Closed by commit rG603c1a62f859: [clang] Don't crash on an incomplete-type base specifier in template context. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 603c1a6 - [clang] Don't crash on an incomplete-type base specifier in template context.

Author: Haojian Wu Date: 2021-11-09T22:17:47+01:00 New Revision: 603c1a62f8595f70c3e96ecbec8976d411c0cc08 URL: https://github.com/llvm/llvm-project/commit/603c1a62f8595f70c3e96ecbec8976d411c0cc08 DIFF: https://github.com/llvm/llvm-project/commit/603c1a62f8595f70c3e96ecbec8976d411c0cc08.diff LO

[PATCH] D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers

MaskRay accepted this revision. MaskRay added a comment. I assume that dancing with GlobalValue makes this difficult to implement in lib/Sema. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/ https://reviews.llvm.org/D112868

[PATCH] D113320: [clang-format] Address fixme

This revision was automatically updated to reflect the committed changes. Closed by commit rG66336056911e: [clang-format] Address fixme (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113320/new/ https://reviews.llvm.

[clang] 6facafe - [clang-format] Refactor SpaceBeforeParens to add options

Author: C. Rayroud Date: 2021-11-09T21:51:45+01:00 New Revision: 6facafe7da59eb02e8c1519670b503efda2f4b58 URL: https://github.com/llvm/llvm-project/commit/6facafe7da59eb02e8c1519670b503efda2f4b58 DIFF: https://github.com/llvm/llvm-project/commit/6facafe7da59eb02e8c1519670b503efda2f4b58.diff LO

[clang] 6633605 - [clang-format] Address fixme

Author: Björn Schäpers Date: 2021-11-09T21:51:44+01:00 New Revision: 66336056911ec1377837ebfe323814521f78d367 URL: https://github.com/llvm/llvm-project/commit/66336056911ec1377837ebfe323814521f78d367 DIFF: https://github.com/llvm/llvm-project/commit/66336056911ec1377837ebfe323814521f78d367.diff

[PATCH] D111262: Comment AST: Factor out function type extraction in DeclInfo::fill (NFC)

aaronpuchert marked an inline comment as done. aaronpuchert added a comment. Thanks for the review! Comment at: clang/lib/AST/Comment.cpp:337 + if (Kind == TypedefKind) +Kind = FunctionKind; ParamVars = FTL.getParams(); gribozavr2 wrote: > P

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

asavonic added a comment. > @asavonic I spoke offline with @erichkeane. I was mistaken. There are only 2 > error diagnostics generated (upstream) after this patch. The additional > diagnostic generated at `bar ` after your patch is correct. We just need to > remove the third diagnostic downstre

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

Quuxplusone added a comment. > I don't know enough about libc++ to feel comfortable making those changes > yet. For example, does libc++ need to work with other compilers than Clang > (compilers which might give diagnostics if you fail to use ATOMIC_VAR_INIT in > some language mode)? The deprec

[PATCH] D113490: [NFC] Let Microsoft mangler accept GlobalDecl

rnk added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:47 + if (auto *CD = dyn_cast(DC)) +GD = GlobalDecl(CD, Ctor_Complete); + else if (auto *DD = dyn_cast(DC)) I would prefer if you passed Ctor_Base and Dtor_Base here. I believe MSVC mo

[PATCH] D113428: [AIX] Define WCHAR_T_TYPE as unsigned int on 64-bit AIX for wchar.c test

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113428/new/ https://reviews.llvm.org/D113428 __

[PATCH] D113507: [clang-tidy] Include constructor initializers in `bugprone-exception-escape` check

fwolff created this revision. fwolff added reviewers: alexfh, aaron.ballman. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#52435. Repository: rG LLVM Gith

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

erichkeane added a comment. I've got no problem with this, but it could just as easily have happened in the other review. Is there a reason not to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113431/new/ https://reviews.llvm.org/D113431 __

[PATCH] D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers

ibookstein updated this revision to Diff 385926. ibookstein added a comment. rebase fix after adding parent NFC commits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/ https://reviews.llvm.org/D112868 Files: clang/lib/CodeGen/CodeGenMo

[PATCH] D113505: [NFC] Inclusive language: replace masterPort with mainPort

quinnp created this revision. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [NFC] This patch replaces `masterPort` with `mainPort` in these testcases. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113505 Files

[PATCH] D113504: [clang][test][NFC] clang-format attr-ifunc.c test

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This is something you can do as review-after-commit if you wish in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113504/new/

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

ibookstein updated this revision to Diff 385923. ibookstein added a comment. add parent clang-format commit to pass CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113431/new/ https://reviews.llvm.org/D113431 Files: clang/test/CodeGen/attr-ifun

[PATCH] D113504: [clang][test][NFC] clang-format attr-ifunc.c test

ibookstein created this revision. ibookstein added reviewers: erichkeane, aaron.ballman. ibookstein requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Itay Bookstein Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D98895: [X86][clang] Disable long double type for -mno-x87 option

eandrews added a comment. In D98895#3119027 , @asavonic wrote: > In D98895#3118821 , @eandrews wrote: > >> This patch causes a regression. >> >> To reproduce - `clang -cc1 -fsycl-is-device -triple spir64 test.cpp` >

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I believe you have addressed John's comments, and I think the IR changes mainly affect AMDGPU users, so I don't think this will be too disruptive. Sorry about the delay, there's a bit of a bys

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

rnk added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4290-4293 - // Do not set COMDAT attribute for CUDA/HIP stub functions to prevent - // them being "merged" by the COMDAT Folding linker optimization. - if (D.hasAttr()) -return false; --

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM (nit the clang-format check) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 __

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

rnk added a subscriber: zequanwu. rnk added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4290-4293 - // Do not set COMDAT attribute for CUDA/HIP stub functions to prevent - // them being "merged" by the COMDAT Folding linker optimization. - if (D.hasAttr())

[PATCH] D113391: [Modules] Don't support clang module and c++20 module at the same time

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. The ideal situation here would be to have a single semantic model that is a superset of the various combinations of behaviors we want. Further entrenching Clang modules and C++20 mod

[clang-tools-extra] 74add1b - Revert "[clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)"

Author: Jorge Gorbe Moya Date: 2021-11-09T11:28:48-08:00 New Revision: 74add1b6d6d377ab2cdce26699cf798110817e42 URL: https://github.com/llvm/llvm-project/commit/74add1b6d6d377ab2cdce26699cf798110817e42 DIFF: https://github.com/llvm/llvm-project/commit/74add1b6d6d377ab2cdce26699cf798110817e42.di

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

salman-javed-nz added a comment. In D113472#3119292 , @jgorbe wrote: > This change is causing asan errors when running the clang-tidy checks under > ASan, most likely because of the reason akuegel pointed out in his comment. > I'm going to revert the pa

[PATCH] D113472: [clang-tidy] Fix lint warning in ClangTidyDiagnosticConsumer.cpp (NFC)

jgorbe added a comment. This change is causing asan errors when running the clang-tidy checks under ASan, most likely because of the reason akuegel pointed out in his comment. I'm going to revert the patch to unbreak HEAD until the problem can be fixed. Repository: rG LLVM Github Monorepo C

[PATCH] D113447: [sancov] add tracing for loads and store

morehouse accepted this revision. morehouse added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113447/new/ https://reviews.llvm.org/D113447 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D112492: [CUDA][HIP] Allow comdat for kernels

tra added subscribers: kpyzhov, rnk. tra added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4290-4293 - // Do not set COMDAT attribute for CUDA/HIP stub functions to prevent - // them being "merged" by the COMDAT Folding linker optimization. - if (D.hasAttr

  1   2   3   >