[PATCH] D99487: [CodeGen] Port basic block sections from ELF to COFF

2021-10-31 Thread TaoPan via Phabricator via cfe-commits
TaoPan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99487/new/ https://reviews.llvm.org/D99487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D112906: [PowerPC] Emit warning for ieeelongdouble on older GNU toolchain

2021-10-31 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf created this revision. qiucf added reviewers: PowerPC, jsji, nemanjai, shchenz. Herald added a subscriber: kbarton. qiucf requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D112401: [Clang] Mutate printf bulitin names under IEEE128 on PPC64

2021-10-31 Thread Qiu Chaofan via Phabricator via cfe-commits
qiucf updated this revision to Diff 383715. qiucf added a comment. Add `nexttoward` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112401/new/ https://reviews.llvm.org/D112401 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/math-builtins-long.c clang/test/CodeGen/ppc64-f

[clang] 848812a - [Verifier] Add verification logic for GlobalIFuncs

2021-10-31 Thread Fangrui Song via cfe-commits
Author: Itay Bookstein Date: 2021-10-31T20:00:57-07:00 New Revision: 848812a55e530517191ed0f4f15c0c60752ea9c4 URL: https://github.com/llvm/llvm-project/commit/848812a55e530517191ed0f4f15c0c60752ea9c4 DIFF: https://github.com/llvm/llvm-project/commit/848812a55e530517191ed0f4f15c0c60752ea9c4.diff

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

2021-10-31 Thread Fangrui Song via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG848812a55e53: [Verifier] Add verification logic for GlobalIFuncs (authored by ibookstein, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D112903: [C++20] [Module] Fix front end crashes when trying to export a type out of a module

2021-10-31 Thread Chuanqi Xu via Phabricator via cfe-commits
ChuanqiXu created this revision. ChuanqiXu added reviewers: rsmith, aaron.ballman. ChuanqiXu added a project: clang. ChuanqiXu requested review of this revision. Herald added a subscriber: cfe-commits. This fixes https://bugs.llvm.org/show_bug.cgi?id=47116. According to https://eel.is/c++draft/mo

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

2021-10-31 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe updated this revision to Diff 383702. FreddyYe added a comment. clang-formats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112777/new/ https://reviews.llvm.org/D112777 Files: clang/lib/Headers/avx512fp16intrin.h clang/lib/Headers/av

[PATCH] D112777: [X86][FP16] add alias for *_fmul_pch intrinsics

2021-10-31 Thread Freddy, Ye via Phabricator via cfe-commits
FreddyYe added a comment. In D112777#3095847 , @pengfei wrote: >> *_mul_pch is to align with *_mul_ps annd *_mul_pd > > And *_mul_ph? Yes. Corrected in summary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D112890: headers: optionalise some generated resource headers

2021-10-31 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. In D112890#3099256 , @tschuett wrote: > If I understand you correctly, I would need to pass something ala `-target > riscv-xx` to enable `__riscv_vector`. However, this is impossible because > the risk target is disabled. So I

[PATCH] D112890: headers: optionalise some generated resource headers

2021-10-31 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. In D112890#3099258 , @etcwilde wrote: > Right, the header is only necessary when you're targeting riscv, so if > compiling for riscv isn't supported by the compiler noted in the > `LLVM_TARGETS_TO_BUILD`, you don't need it and

[PATCH] D112890: headers: optionalise some generated resource headers

2021-10-31 Thread Evan Wilde via Phabricator via cfe-commits
etcwilde added a comment. Right, the header is only necessary when you're targeting riscv, so if compiling for riscv isn't supported by the compiler noted in the `LLVM_TARGETS_TO_BUILD`, you don't need it and can't use it anyway. This is separate from the host platform that the compiler is runni

[PATCH] D112890: headers: optionalise some generated resource headers

2021-10-31 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. If I understand you correctly, I would need to pass something ala `-target riscv-xx` to enable `__riscv_vector`. However, this is impossible because the risk target is disabled. So I thing it is save what you are doing. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D112890: headers: optionalise some generated resource headers

2021-10-31 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd added a comment. In D112890#3099208 , @tschuett wrote: > I am undecided between this may break something and I cannot use the risc-v > headers on an x86 machine. This fundamentally cannot break something outside of the RISC-V //target//, it is

[PATCH] D112768: [ARM] implement support for TLS register based stack protector

2021-10-31 Thread Peter Smith via Phabricator via cfe-commits
peter.smith added a reviewer: ostannard. peter.smith added a comment. Adding ostannard to reviewers list. I'm going to be on vacation next week and Oliver is more familiar with this area than I am. To prevent the option in Clang for targets that don't support Thumb2 it may be worth looking into

[PATCH] D112890: headers: optionalise some generated resource headers

2021-10-31 Thread Thorsten via Phabricator via cfe-commits
tschuett added a comment. I am undecided between this may break something and I cannot use the risc-v headers on an x86 machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890 __

[PATCH] D112890: headers: optionalise some generated resource headers

2021-10-31 Thread Evan Wilde via Phabricator via cfe-commits
etcwilde added a comment. This makes sense to me. It doesn't make sense to spend the time generating files that will never get used, nor spend the space for storing them. `riscv_vector.h` in particular is quite large, coming in at just under 10M, and there are two of them showing up in my build

[PATCH] D112890: headers: optionalise some generated resource headers

2021-10-31 Thread Saleem Abdulrasool via Phabricator via cfe-commits
compnerd created this revision. compnerd added a reviewer: craig.topper. Herald added subscribers: luke957, luismarques, s.egerton, PkmX, simoncook, kristof.beyls, mgorny. compnerd requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This split

[PATCH] D112868: [Sema] Diagnose and reject non-function ifunc resolvers

2021-10-31 Thread Itay Bookstein via Phabricator via cfe-commits
ibookstein updated this revision to Diff 383661. ibookstein added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112868/new/ https://reviews.llvm.org/D112868 Files: clang/lib/CodeGen/CodeGenModule.cpp clang/test/Sema/att

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

2021-10-31 Thread Itay Bookstein via Phabricator via cfe-commits
ibookstein added a comment. Could you commit this on my behalf? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112349/new/ https://reviews.llvm.org/D112349 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D111509: [clang] use getCommonSugar in an assortment of places

2021-10-31 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 383656. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines-narro

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

2021-10-31 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 383653. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type

[PATCH] D112887: [clang-format] [PR52228] clang-format csharp inconsistant nested namespace indentation

2021-10-31 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 383652. MyDeveloperDay added reviewers: jbcoe, exv, lunasorcery. MyDeveloperDay added a comment. Add a new more tests Remove unneeded include (adding C# Reviewers) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112887/new/ https://reviews.llv

[PATCH] D112887: [clang-format] [PR52228] clang-format csharp inconsistant nested namespace indentation

2021-10-31 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=52228 For multilevel namespaces in C# get their content i

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

2021-10-31 Thread Yueh-Ting Chen via Phabricator via cfe-commits
eopXD updated this revision to Diff 383647. eopXD added a comment. Set `ExperimentalExtensionVersionCheck=true` for RISCVISAInfo::parseArchString in `RISCVAsmParser.cpp` Add version numbers for test case in `attribute-arch.s` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h