[PATCH] D112235: [HIP][OpenMP] Fix assertion in deferred diag due to incomplete class definition

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Minor grammar nit with a comment, but otherwise LGTM. Comment at: clang/test/OpenMP/deferred-diags.cpp:40 +// Test deleting object with incomplete class definition does n

[clang-tools-extra] 4ba9d9c - Use StringRef::contains (NFC)

Author: Kazu Hirata Date: 2021-10-23T20:41:46-07:00 New Revision: 4ba9d9c84f4ce05eec341dc5f2d1c95934ab3d2c URL: https://github.com/llvm/llvm-project/commit/4ba9d9c84f4ce05eec341dc5f2d1c95934ab3d2c DIFF: https://github.com/llvm/llvm-project/commit/4ba9d9c84f4ce05eec341dc5f2d1c95934ab3d2c.diff L

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen: a dyn_cast -> cast instance + clang-tidy fixes

bondhugula added a comment. Gentle ping to reviewers @tra @yaxunl on this NFC PR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112284/new/ https://reviews.llvm.org/D112284 ___ cfe-commits mailing list c

[PATCH] D109557: Adds a BlockIndent option to AlignAfterOpenBracket

csmulhern updated this revision to Diff 381765. csmulhern added a comment. Absent feedback, I have gone ahead and added a BlockIndent option to AlignAfterOpenBracket. Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ h

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

salman-javed-nz added a comment. In D112356#3082218 , @Quuxplusone wrote: > Definitely an improvement! I looked at all the changed places and found some > more improvements you can make. I don't need to see this again, though. Thanks for the suggestion

[PATCH] D105447: [analyzer] Allow cmake options to be passed to satest container

manas added a comment. Gentle ping! I think landing it will make collecting analyzer information easier (in terms of faster build) as more (appropriate) cmake options can be passed via cmdline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105447/

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. Based on the information from debugger, the logs show RangeSets `[0, 255]` and `[INT_MIN, 0]` from different types are causing the failure. I tried producing a compact test case

[PATCH] D111457: [clang][test] Add lit helper for windows paths

mstorsjo added a comment. In D111457#3073726 , @keith wrote: > In D111457#3066508 , @mstorsjo > wrote: > >> Wouldn't this one also be solved pretty much the same, but differently, by >> changing `if (llvm::sys::

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein updated this revision to Diff 381760. ibookstein edited the summary of this revision. ibookstein added a comment. Herald added a subscriber: nemanjai. Added check to BitcodeReader, fixed clang tests, hoisted logic to shared static function on GlobalIFunc. Repository: rG LLVM Github

[clang] a709787 - Add support of the next Ubuntu (Ubuntu 22.04 - Jammy Jellyfish)

Author: Sylvestre Ledru Date: 2021-10-23T23:55:50+02:00 New Revision: a709787cd988aaca847995bd08cc9348c9c6c956 URL: https://github.com/llvm/llvm-project/commit/a709787cd988aaca847995bd08cc9348c9c6c956 DIFF: https://github.com/llvm/llvm-project/commit/a709787cd988aaca847995bd08cc9348c9c6c956.dif

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

steakhal added a comment. In D106102#3081178 , @bjope wrote: > I get failures after having merged this patch: > [...] > Here is the crash.c input F19785350: crash.c > > > I see lots of these. Probably worth a revert.

[clang] f9db6a4 - Revert "[analyzer][solver] Introduce reasoning for not equal to operator"

Author: Balazs Benics Date: 2021-10-23T21:01:59+02:00 New Revision: f9db6a44eb37fe4c97521e033ff2e30e9558d86a URL: https://github.com/llvm/llvm-project/commit/f9db6a44eb37fe4c97521e033ff2e30e9558d86a DIFF: https://github.com/llvm/llvm-project/commit/f9db6a44eb37fe4c97521e033ff2e30e9558d86a.diff

[PATCH] D77776: [Driver] Default to libc++ on FreeBSD

myfreeweb added a comment. Herald added a subscriber: pengfei. It's been over a year and no solutions have been merged! The problem just popped up again in Firefox after a pull. With clang 13.0, and the discussion above was before 11.0 release >_< Can someone commit something already?! Reposi

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein added a comment. Because this commit changes an existing binary bitcode file, and because that file specifically tests backwards compatibility, does that mean I need to avoid changing it and instead add a backwards compatibility fix to the BitcodeReader? (Something like always bitcas

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein updated this revision to Diff 381754. ibookstein added a comment. Now using arcanist because commit includes change to binary file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112349/new/ https://reviews.llvm.org/D112349 Files: clan

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein updated this revision to Diff 381751. ibookstein added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112349/new/ https://reviews.llvm.org/D112349 Files: clang/lib/CodeGen/CodeGenModule.cpp llvm/lib/IR/Globals.cpp llvm/lib/IR/Verifier.cpp llvm/test/A

[PATCH] D112367: [Clang][AST] Temporarily undefine IBAction/IBOutlet ObjC macros in attribute headers

gAlfonso-bit created this revision. gAlfonso-bit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Taken from a downstream fork: https://github.com/apple/llvm-project/pull/3461/files. IBAction and IBOutlet are defined when compiling with Ob

[PATCH] D108694: [WIP][RISCV] Add the zvl extension according to the v1.0-rc2 spec

eopXD updated this revision to Diff 381747. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108694/new/ https://reviews.llvm.org/D108694 Files: clang/lib/Basic/Targets/RISCV.cpp clang/test/Driver/riscv-arch.c cla

[PATCH] D112359: [NFC][RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381745. eopXD added a comment. Remove debug code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGe

[PATCH] D112359: [NFC][RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381744. eopXD added a comment. Minor update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGen/RIS

[PATCH] D112359: [NFC][RISCV] Unify depedency check and extension implication parsing logics

eopXD updated this revision to Diff 381742. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112359/new/ https://reviews.llvm.org/D112359 Files: clang/test/CodeGen/RISCV/riscv-metadata.c clang/test/CodeGen/RISCV/ris

[clang] d8e4170 - Ensure newlines at the end of files (NFC)

Author: Kazu Hirata Date: 2021-10-23T08:45:29-07:00 New Revision: d8e4170b0a1431edee939efc16b60b409affcb4d URL: https://github.com/llvm/llvm-project/commit/d8e4170b0a1431edee939efc16b60b409affcb4d DIFF: https://github.com/llvm/llvm-project/commit/d8e4170b0a1431edee939efc16b60b409affcb4d.diff L

[clang-tools-extra] d8e4170 - Ensure newlines at the end of files (NFC)

Author: Kazu Hirata Date: 2021-10-23T08:45:29-07:00 New Revision: d8e4170b0a1431edee939efc16b60b409affcb4d URL: https://github.com/llvm/llvm-project/commit/d8e4170b0a1431edee939efc16b60b409affcb4d DIFF: https://github.com/llvm/llvm-project/commit/d8e4170b0a1431edee939efc16b60b409affcb4d.diff L

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

Quuxplusone added a comment. Definitely an improvement! I looked at all the changed places and found some more improvements you can make. I don't need to see this again, though. The only disimprovement I found was "Jaro–Winkler" becoming "Jaro-Winkler". Comment at: clang-tool

[PATCH] D109215: [RISCV] Fix arch string parsing for multi-character extensions

eopXD updated this revision to Diff 381738. eopXD added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix test case fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109215/new/ https://reviews.llvm.org/D109215

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0-rc1 spec

eopXD updated this revision to Diff 381737. eopXD added a comment. Herald added subscribers: cfe-commits, achieveartificialintelligence, jdoerfert. Herald added a project: clang. Address comments and add macro in clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

ibookstein updated this revision to Diff 381735. ibookstein set the repository for this revision to rG LLVM Github Monorepo. ibookstein added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed type verification to look at the resolver operand rather than the

[PATCH] D111992: [MLIR][OpenMP] Added omp.atomic.read and omp.atomic.write

shraiysh added a comment. In D111992#3080308 , @kiranchandramohan wrote: > LGTM. > > My preference is the following one. If you agree then please make the change, > otherwise, you can keep it as is. Also, wait a couple of days to see whether > others h

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

salman-javed-nz added a comment. In D112356#3082084 , @carlosgalvezp wrote: > Awesome @salman-javed-nz , thanks for fixing the docs! May I ask how did you > create these "smaller commits"? It's very nice to click on each of them and > see only what cha

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

carlosgalvezp added a comment. Awesome @salman-javed-nz , thanks for fixing the docs! May I ask how did you create these "smaller commits"? It's very nice to click on each of them and see only what changed. I believe I followed your same procedure (use the "Update Revision" thingy) but it alway

[PATCH] D112257: [www] Fix Ninja build instructions on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5348355ee66: [www] Fix Ninja build instructions on Windows (authored by triplef, committed by xgupta). Repository: rG LLVM Github Monorepo CHANG

[clang] c534835 - [www] Fix Ninja build instructions on Windows

Author: Frederik Seiffert Date: 2021-10-23T16:09:04+05:30 New Revision: c5348355ee66fbfc97e0dbb0234398792c4b68d9 URL: https://github.com/llvm/llvm-project/commit/c5348355ee66fbfc97e0dbb0234398792c4b68d9 DIFF: https://github.com/llvm/llvm-project/commit/c5348355ee66fbfc97e0dbb0234398792c4b68d9.d

[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

eopXD created this revision. eopXD added reviewers: kito.cheng, craig.topper. Herald added subscribers: achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5de69e16ea9a: [clang-tidy] Tidy up spelling, grammar, and inconsistencies in documentation… (authored by salman-javed-nz, committed by kazu). Repos

[clang-tools-extra] 5de69e1 - [clang-tidy] Tidy up spelling, grammar, and inconsistencies in documentation (NFC)

Author: Salman Javed Date: 2021-10-23T00:07:36-07:00 New Revision: 5de69e16ea9ab916401f4a8390fff91f18bbba2a URL: https://github.com/llvm/llvm-project/commit/5de69e16ea9ab916401f4a8390fff91f18bbba2a DIFF: https://github.com/llvm/llvm-project/commit/5de69e16ea9ab916401f4a8390fff91f18bbba2a.diff