[PATCH] D110257: [CFE][Codegen] Do not break the contiguity of static allocas.

hsmhsm updated this revision to Diff 375789. hsmhsm added a comment. Fix review comments by @jdoerfert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/C

[PATCH] D110676: [CFE][Codegen] Update auto-generated check lines for few GPU lit tests

hsmhsm updated this revision to Diff 375788. hsmhsm added a comment. Only update lit tests which undergo changes within https://reviews.llvm.org/D110257 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110676/new/ https://reviews.llvm.org/D110676 Fi

[PATCH] D108822: [python bindings] Add missing cursor kind in Clang Python's bindings.

teerytko added a comment. What is the process / schedule to get this change in? I am facing the same problem with llvm 12 and python bindings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108822/new/ https://reviews.llvm.org/D108822

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

Conanap updated this revision to Diff 375780. Conanap marked an inline comment as done. Conanap added a comment. Updated correct version of the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109902/new/ https://reviews.llvm.org/D109902 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay updated this revision to Diff 375778. MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: luismarques, s.egerton, PkmX, atanasyan, simoncook, arichardson, sdardis. Support Debian -m32 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375775. expnkx added a comment. clang format + clang tidy all clang tests pass locally. flang is bugged. Do not know why flang cannot find llvm-jxx CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files:

[PATCH] D110655: [OpenMP] Apply OpenMP assumptions to applicable call sites

jhuber6 updated this revision to Diff 375773. jhuber6 added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110655/new/ https://reviews.llvm.org/D110655 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGStmt.cpp clan

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:336-337 + for (auto &F : getModule()->functions()) { +if (const Decl *FD = Gen->GetDeclForMangledName(F.getName())) { + auto Loc = FD->getASTContext().getFullLoc(FD->getLocatio

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

vsapsai updated this revision to Diff 375771. vsapsai added a comment. Rebase and add a test case with `always_inline`. Interaction between `always_inline` function and `testAccessBitField` has revealed that we cannot avoid having expressions referencing decls from "wrong" module. So returning a

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

aeubanks added a comment. In D110673#3029253 , @dblaikie wrote: > It'd be good to understand/document (maybe document in the form of a test if > possible) how downstream users are relying on this - perhaps it's not a valid > reliance and we shouldn't ma

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

dblaikie added a comment. It'd be good to understand/document (maybe document in the form of a test if possible) how downstream users are relying on this - perhaps it's not a valid reliance and we shouldn't maintain compatibility? Maybe it is and we should ensure some test coverage of the sort

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. On top on this Diff, with the following patch, `ninja check-clang-driver` passes. We may consider dropping the normalized triple code. --- i/clang/lib/Driver/ToolChain.cpp +++ w/clang/lib/Driver/ToolChain.cpp @@ -494,6 +494,7 @@ std::string ToolChain::getRuntimePat

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. > You mean when you build runtimes with the host compiler and then use them > with Clang (i.e. by using -DLLVM_ENABLE_PROJECTS="clang;lld;libcx")? This has > been discussed several times on llvm-dev in the past, ideally nobody should > be using this mode because there's

[PATCH] D110671: [AIX] Enable PGO without LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e48951c736c: [AIX] Enable PGO without LTO (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang] 1e48951 - [AIX] Enable PGO without LTO

Author: Jinsong Ji Date: 2021-09-29T02:00:11Z New Revision: 1e48951c736cb346df34605fc42a39ef6c349b29 URL: https://github.com/llvm/llvm-project/commit/1e48951c736cb346df34605fc42a39ef6c349b29 DIFF: https://github.com/llvm/llvm-project/commit/1e48951c736cb346df34605fc42a39ef6c349b29.diff LOG: [A

[PATCH] D110673: [clang] Don't modify OptRemark if the argument is not relevant

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A followup to D110201 . For example, we'd set OptimizationRemarkMissed's Regex to '.*' when encountering -Rpass. Th

[PATCH] D106191: [clang] Option control afn flag

nemanjai added a comment. Added @jansvoboda11 to the review as it appears he was the one that added the original option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106191/new/ https://reviews.llvm.org/D106191 __

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375758. expnkx added a comment. fixing clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/lib/AST/RecordLayoutBuilder.cpp Index: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3029147 , @MaskRay wrote: > In D110663#3029146 , @phosek wrote: > >> In D110663#3029124 , @MaskRay >> wrote: >> >>> In D110663#3029088

[PATCH] D106959: [PowerPC] swdiv builtins for XL compatibility

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Please note in the commit message that this is simply a wrapper for a floating point divide. XL provided this builtin because it doesn't produce software estimates by default at `-Of

[PATCH] D109178: [PowerPC] Disable vector types when not supported by subtarget features

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109178/new/ https://reviews.llvm.org/D109178 __

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3029146 , @phosek wrote: > In D110663#3029124 , @MaskRay wrote: > >> In D110663#3029088 , @phosek wrote: >> >>> The reason I removed th

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3029124 , @MaskRay wrote: > In D110663#3029088 , @phosek wrote: > >> The reason I removed this behavior in D101194 >> , aside from extra overhe

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. I'd actually want to get rid of the function `Linux::getMultiarchTriple`, when all Debian Clang use `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=*-linux-gnu` instead of `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=*-{unknown,pc}-linux-gnu` In D110663#3029131

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

jrtc27 added a comment. In D110663#3029124 , @MaskRay wrote: > In D110663#3029088 , @phosek wrote: > >> The reason I removed this behavior in D101194 >> , aside from extra overhe

[PATCH] D110653: [PowerPC] The builtins load8r and store8r are Power 7 plus.

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110653/new/ https://reviews.llvm.org/D110653 __

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3029088 , @phosek wrote: > The reason I removed this behavior in D101194 > , aside from extra overhead introduced by > the extra checks, is that we've seen cases where people would h

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. A potential solution would be to reintroduce the portion D101194 which would let each driver control the triple spelling (by overriding `getMultiarchTriple`. On Linux, including Debian, that logic is already implemented in https://gith

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

smeenai added a comment. In D110663#3029076 , @MaskRay wrote: > Prefer unnormalized over normalized (@smeenai) To be clear, I wasn't advocating for one ordering over the other, just pointing out the similarity to the prior state of things :) @phosek wou

[PATCH] D110671: [AIX] Enable PGO without LTO

jsji created this revision. jsji added reviewers: PowerPC, Whitney. Herald added subscribers: wenlei, inglorion. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On AIX, we relied on LTO to merge the csects for profiling data/counter se

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay updated this revision to Diff 375753. MaskRay added a comment. fix getRuntimePath test libclang_rt.builtins.a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 Files: clang/lib/Driver/ToolChain.cp

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. The reason I removed this behavior in D101194 , aside from extra overhead introduced by the extra checks, is that we've seen cases where people would have both paths on their system which lead to difficult to diagnose issues where Clang

[PATCH] D110422: [AIX] Change the linkage of profiling counter/data to be private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25c30324e953: [AIX] Change the linkage of profiling counter/data to be private (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 25c3032 - [AIX] Change the linkage of profiling counter/data to be private

Author: Jinsong Ji Date: 2021-09-29T00:47:25Z New Revision: 25c30324e953c1c0011d1ab7529991db5c6ba741 URL: https://github.com/llvm/llvm-project/commit/25c30324e953c1c0011d1ab7529991db5c6ba741 DIFF: https://github.com/llvm/llvm-project/commit/25c30324e953c1c0011d1ab7529991db5c6ba741.diff LOG: [A

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay updated this revision to Diff 375751. MaskRay marked an inline comment as done. MaskRay retitled this revision from "[Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path" to "[Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtim

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis updated this revision to Diff 375750. thakis added a comment. tweak CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 Files: clang/include/clang/Basic/CLWarnings.h clang/include/clang/Driver/Options.td clang/lib/Basic/CLWarnings.cpp

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis updated this revision to Diff 375749. thakis added a comment. some clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110668/new/ https://reviews.llvm.org/D110668 Files: clang/include/clang/Basic/CLWarnings.h clang/include/clang/Driver/Options.td clang/lib/Basic/CL

[PATCH] D110670: [Sema] Allow comparisons between different ms ptr size address space types.

akhuang created this revision. akhuang added a reviewer: aaron.ballman. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We're currently using address spaces to implement __ptr32/__ptr64 attributes; this patch fixes a bug where clang

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis added a comment. In D102107#3028386 , @ronlieb wrote: > i backed up to your reverted patch, and applied this one. > I see some new errors > > libomptarget :: amdgcn-amd-amdhsa :: mapping/declare_mapper_target.cpp > libomptarget :: amdgcn

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

jrtc27 added a comment. NB: summary has x86_64-known rather than x86_64-unknown in a couple of places Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-co

[PATCH] D110276: Clean up large copies of binaries copied into temp directories in tests

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd87bdc272ba4: Clean up large copies of binaries copied into temp directories in tests (authored by tejohnson). Repository: rG LLVM Github Monorepo

[clang] d87bdc2 - Clean up large copies of binaries copied into temp directories in tests

Author: Teresa Johnson Date: 2021-09-28T17:04:09-07:00 New Revision: d87bdc272ba47b7d9109ff5c7191454ab2ae6fcb URL: https://github.com/llvm/llvm-project/commit/d87bdc272ba47b7d9109ff5c7191454ab2ae6fcb DIFF: https://github.com/llvm/llvm-project/commit/d87bdc272ba47b7d9109ff5c7191454ab2ae6fcb.diff

[PATCH] D110364: [clang] Rework dontcall attributes

aeubanks added a comment. In D110364#3028995 , @thakis wrote: > Looks like this breaks tests on windows: > http://45.33.8.238/win/46089/step_7.txt > > Please take a look, and revert for now if it takes a while to fix. Should be fixed with 2d56fbf6cd16bb

[clang] 2d56fbf - [test] Specify triple in backend-attribute-error-warning.cpp

Author: Arthur Eubanks Date: 2021-09-28T17:00:10-07:00 New Revision: 2d56fbf6cd16bb7d2ae6c726b37d2096b9bdcd5a URL: https://github.com/llvm/llvm-project/commit/2d56fbf6cd16bb7d2ae6c726b37d2096b9bdcd5a DIFF: https://github.com/llvm/llvm-project/commit/2d56fbf6cd16bb7d2ae6c726b37d2096b9bdcd5a.diff

[PATCH] D109902: [PowerPC] Improved codegen related to xscvdpsxws/xscvdpuxws

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. I really don't understand what happened now. It seems that you have simply reverted to an older version of this patch. The test case appears to not have been pre-committed any lo

[PATCH] D110364: [clang] Rework dontcall attributes

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/46089/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110364/new/ https://reviews.l

[PATCH] D106550: [PowerPC] Allow MMA built-ins to accept restrict and volatile qualified pointers

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106550/new/ https://reviews.llvm.org/D106550 __

[clang-tools-extra] 5cf0606 - [clang] Let PPCallbacks::PragmaWarning() pass specifier as enum instead of string

Author: Nico Weber Date: 2021-09-28T19:47:27-04:00 New Revision: 5cf0606140974b7560490778725c134eb35f0cc7 URL: https://github.com/llvm/llvm-project/commit/5cf0606140974b7560490778725c134eb35f0cc7 DIFF: https://github.com/llvm/llvm-project/commit/5cf0606140974b7560490778725c134eb35f0cc7.diff LO

[PATCH] D110635: [clang] Let PPCallbacks::PragmaWarning() pass specifier as enum instead of string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5cf060614097: [clang] Let PPCallbacks::PragmaWarning() pass specifier as enum instead of… (authored by thakis). Repository: rG LLVM Github Monorep

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added a comment. Herald added a subscriber: achieveartificialintelligence. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 ___ cfe-commits maili

[PATCH] D110668: [clang-cl] Accept `#pragma warning(disable : N)` for some N

thakis created this revision. thakis added a reviewer: hans. thakis added a project: clang. Herald added subscribers: dexonsmith, dang, mgorny. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. clang-cl maps /wd to -Wno-flags for a

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y added inline comments. Comment at: clang/include/clang/Basic/Sarif.h:95 +// +/// Since every in clang artifact MUST have a location (there being no nested +/// artifacts), the creation method \ref SarifArtifact::create requires a aaron.ballman wrote: >

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

vaibhav.y updated this revision to Diff 375734. vaibhav.y marked 34 inline comments as done. vaibhav.y added a comment. Address comments from upstream review: - Mark anonymous functions static, improve documentation - Coding style fixes - Use Ref types as they are intended (as non-owning lightwei

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

lebedev.ri added a comment. This doesn't help the world-breaking D107799 on debian for me. I don't know if this stands on it's own. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.o

[PATCH] D110665: [clang] Don't use the AST to display backend diagnostics

aeubanks created this revision. aeubanks added reviewers: dblaikie, rnk. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We keep a map from function name to source location so we don't have to do it via looking up a source location

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

smeenai added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:494 + std::string Ret(P); + // When LLVM_DEFAULT_TARGET_TRIPLE uses Debian multiarch style + // "x86_64-linux-gnu" (no vendor part), use the unnormalized This is effectively reverting th

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa36227cb2b6a: fixes bug #51926 where dangling comma caused overrun (authored by feg208). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] a36227c - fixes bug #51926 where dangling comma caused overrun

Author: Fred Grim Date: 2021-09-28T15:59:37-07:00 New Revision: a36227cb2b6a14fc30bfd303328d1d1abb632010 URL: https://github.com/llvm/llvm-project/commit/a36227cb2b6a14fc30bfd303328d1d1abb632010 DIFF: https://github.com/llvm/llvm-project/commit/a36227cb2b6a14fc30bfd303328d1d1abb632010.diff LOG

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers updated this revision to Diff 375727. vabridgers added a comment. improve test cases per @martong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 Files: clang/lib/StaticAnalyzer/Core/Store.cp

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

vabridgers added a comment. @martong, Thanks for yes for sure! I'll post an update soon with a few minor test improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110625/new/ https://reviews.llvm.org/D110625 ___

[clang] aa53785 - Reland [clang] Rework dontcall attributes

Author: Arthur Eubanks Date: 2021-09-28T15:31:30-07:00 New Revision: aa53785f23b2b89a9a423af131697b1f7c92869f URL: https://github.com/llvm/llvm-project/commit/aa53785f23b2b89a9a423af131697b1f7c92869f DIFF: https://github.com/llvm/llvm-project/commit/aa53785f23b2b89a9a423af131697b1f7c92869f.diff

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

MaskRay added a comment. In D110663#3028811 , @sylvestre.ledru wrote: > just to make sure I understand, it will also update the install or "just" the > dumpmachine option ? If `LLVM_DEFAULT_TARGET_TRIPLE` is `x86_64-linux-gnu, `clang -dumpmachine` will

[PATCH] D110422: [AIX] Change the linkage of profiling counter/data to be private

jsji added a comment. @MaskRay Thank you so much for your review and discussion! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 ___ cfe-commits mailing list cf

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

MaskRay updated this revision to Diff 375722. MaskRay added a comment. add missing file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 Files: clang/lib/Driver/ToolChain.cpp clang/test/Driver/Inputs/

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375720. expnkx added a comment. it should first update the field and then test no_unique_address CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/lib/AST/RecordLayoutBuilder.cpp Index: clang

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

sylvestre.ledru added a comment. just to make sure I understand, it will also update the install or "just" the dumpmachine option ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path

MaskRay created this revision. MaskRay added reviewers: phosek, sylvestre.ledru. Herald added a subscriber: pengfei. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is needed when config.guess is removed (D109837

[PATCH] D110422: [AIX] Change the linkage of profiling counter/data to be private

jsji updated this revision to Diff 375716. jsji added a comment. Remove empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/test/Profile/cxx-templates.cpp llvm/lib/Transforms/Inst

[PATCH] D109625: [compiler-rt] Ensure required deps for tests targets are actually built

leonardchan updated this revision to Diff 375713. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109625/new/ https://reviews.llvm.org/D109625 Files: compiler-rt/test/CMakeLists.txt Index: compiler-rt/test/CMakeLists.txt ==

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

beanz updated this revision to Diff 375711. beanz added a comment. Updating so that the warning doesn't fire on an empty initializer list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110656/new/ https://reviews.llvm.org/D110656 Files: clang/in

[PATCH] D110422: [AIX] Change the linkage of profiling counter/data to be private

jsji updated this revision to Diff 375709. jsji added a comment. Split the Driver changes to another patch, also fixed the duplicate code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/te

[clang] 7833d20 - Revert "[clang] Rework dontcall attributes"

Author: Arthur Eubanks Date: 2021-09-28T14:49:27-07:00 New Revision: 7833d20f1fd575fac89ce76822ffd561a40552e5 URL: https://github.com/llvm/llvm-project/commit/7833d20f1fd575fac89ce76822ffd561a40552e5 DIFF: https://github.com/llvm/llvm-project/commit/7833d20f1fd575fac89ce76822ffd561a40552e5.diff

[PATCH] D110280: [modules] Fix IRGen assertion on accessing ObjC ivar inside a method.

vsapsai added a comment. In D110280#3016911 , @rjmccall wrote: > Hmm. It sounds like we misbehave if we're working with a non-canonical ivar. > While it does seem preferable in general for lookups done after merging > modules to return the canonical i

[clang] b69a2c8 - Revert "[test] Pin some RUN lines in optimization-remark.c to new PM"

Author: Arthur Eubanks Date: 2021-09-28T14:42:37-07:00 New Revision: b69a2c8eeca1fee26283ca4c2f99c787aabba067 URL: https://github.com/llvm/llvm-project/commit/b69a2c8eeca1fee26283ca4c2f99c787aabba067 DIFF: https://github.com/llvm/llvm-project/commit/b69a2c8eeca1fee26283ca4c2f99c787aabba067.diff

[clang] 952f030 - [test] Pin some RUN lines in optimization-remark.c to new PM

Author: Arthur Eubanks Date: 2021-09-28T14:29:33-07:00 New Revision: 952f030fe6ade193ead8f23a7654cf8d2c7aa3df URL: https://github.com/llvm/llvm-project/commit/952f030fe6ade193ead8f23a7654cf8d2c7aa3df DIFF: https://github.com/llvm/llvm-project/commit/952f030fe6ade193ead8f23a7654cf8d2c7aa3df.diff

[PATCH] D110364: [clang] Rework dontcall attributes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2943071e2ee0: [clang] Rework dontcall attributes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[clang] 2943071 - [clang] Rework dontcall attributes

Author: Arthur Eubanks Date: 2021-09-28T14:21:10-07:00 New Revision: 2943071e2ee0c7f31f34062a44d12aeb0e3a66fd URL: https://github.com/llvm/llvm-project/commit/2943071e2ee0c7f31f34062a44d12aeb0e3a66fd DIFF: https://github.com/llvm/llvm-project/commit/2943071e2ee0c7f31f34062a44d12aeb0e3a66fd.diff

[PATCH] D110656: [clang][Sema] Warn on uninitialized array elments

beanz created this revision. beanz added reviewers: aaron.ballman, rsmith, RKSimon, dexonsmith. beanz requested review of this revision. Herald added a project: clang. When defining a statically sized array with explicit array initializers, having a warning for uninitialized members is nice. This

[PATCH] D110364: [clang] Rework dontcall attributes

aeubanks updated this revision to Diff 375698. aeubanks added a comment. DRY Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110364/new/ https://reviews.llvm.org/D110364 Files: clang/lib/CodeGen/CodeGenAction.cpp clang/lib/CodeGen/CodeGenModule.

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz added a comment. F19296441: nolintbeginend.cpp.tmp.cpp.msg You can see in the attached file, that when I ran the unit test on a x86_64 Windows 10 PC, the diagnostic from `error_in_include.inc` is printed at the end. However, on this this clang

[PATCH] D110655: [OpenMP] Apply OpenMP assumptions to applicable call sites

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds OpenMP assumption attributes to call sites in a

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added a comment. I still think the description can be rephrased to be shorter and clearer, and am not very sure this workaround should be added. But I will take a vacation and be back after one week and don't want to appear that I am blocking this change. So LGTM once you decrease the n

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

feg208 added a comment. Absolutely in agreement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110481/new/ https://reviews.llvm.org/D110481 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas added a comment. The pre-merge checks fail due to the patch being unable to get applied. The troubleshooting suggest to update the patch via `arc diff ```git merge-base HEAD origin``` --update D106102` an

[PATCH] D110653: [PowerPC] The builtins load8r and store8r are Power 7 plus.

stefanp created this revision. stefanp added reviewers: nemanjai, lei. Herald added subscribers: shchenz, kbarton, hiraditya. stefanp requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. This patch makes sure that the builtins __builtin_ppc

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375690. expnkx added a comment. I cannot find out where to add attribute that starts with msvc::x. I am just applying this "potential" patch to the clang upstream. In the future we can just remove TargetItaniumCXXABI attr in the clang table gen file witho

[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

salman-javed-nz updated this revision to Diff 375685. salman-javed-nz added a comment. Resolving build error due to failed unit test. On some build bots, the clang-tidy diagnostics coming from `error_in_include.inc` get printed BEFORE all other diagnostics, REGARDLESS of the location of the `#i

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 375689. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Ana

[PATCH] D110422: [AIX] Enable PGO without LTO

jsji updated this revision to Diff 375688. jsji marked an inline comment as done. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110422/new/ https://reviews.llvm.org/D110422 Files: clang/lib/Driver/ToolChai

[PATCH] D110481: fixes bug #51926 where dangling comma caused overrun

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D110481#3027289 , @feg208 wrote: > By one other bug I mean an entirely separate bug that I will handle in a > separate PR.

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. And on Windows: http://45.33.8.238/win/46077/summary.html ! Thanks for pointing those. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 _

[PATCH] D106102: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 375682. manas added a comment. Move method to a specialized template for VisitBinaryOperator Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106102/new/ https://reviews.llvm.org/D106102 Files: clang/lib/StaticAn

[PATCH] D110422: [AIX] Enable PGO without LTO

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:865 + // Due to the current limitation of binder, the duplicate weak symbols in the + // same csect won't be discarded. When there are duplicate weak symbols, "D

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

erichkeane updated this revision to Diff 375680. erichkeane added a comment. Moments after my last comment, i figured out the scope issue, which makes the names in the template-template-parameter parameter-list in scope for this requires clause. I don't think it makes SENSE that this is the cas

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis: fine on OSX: http://45.33.8.238/macm1/18808/summary.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D109967 ___ cfe-com

[PATCH] D109967: Simplify handling of builtin with inline redefinition

serge-sans-paille added a comment. @thakis if rG1ecb1bc3e214 doesn't work, I'll revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109967/new/ https://reviews.llvm.org/D1099

[clang] 1ecb1bc - Fix memcpy-nobuiltin.c test case

Author: serge-sans-paille Date: 2021-09-28T21:55:42+02:00 New Revision: 1ecb1bc3e214c8da53a7fda14f428786441109d7 URL: https://github.com/llvm/llvm-project/commit/1ecb1bc3e214c8da53a7fda14f428786441109d7 DIFF: https://github.com/llvm/llvm-project/commit/1ecb1bc3e214c8da53a7fda14f428786441109d7.d

[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

saiislam updated this revision to Diff 375672. saiislam added a comment. fixed nvptx test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105191/new/ https://reviews.llvm.org/D105191 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp clang/lib/

[PATCH] D110625: [analyzer] canonicalize special case of structure/pointer deref

martong added a comment. Thanks Vince! Nice work! Do you think it would be worth to have a test that checks the equality of a double pointer and a bi-dimensional array? Something like: void struct_pointer_canon(struct s **ps) { struct s ss = **ps; clang_analyzer_eval(&(ps[0][0].v) ==

  1   2   3   >