[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

uabelho added a comment. Hi @ychen, A whole bunch of libcxx testcases fail for me when I run with this patch: Failed Tests (90): libc++ :: libcxx/gdb/gdb_pretty_printer_test.sh.cpp libc++ :: std/numerics/rand/rand.adapt/rand.adapt.ibits/assign.pass.cpp libc++ :: std/numerics/rand/r

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. The corresponding clang codegen and llvm implementation: https://reviews.llvm.org/D110129 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110127/new/ https://reviews.llvm.org/D110127 __

[PATCH] D110129: [DebugInfo] Support typedef with btf_tag attributes

yonghong-song created this revision. yonghong-song added a reviewer: dblaikie. yonghong-song added a project: debug-info. Herald added subscribers: dexonsmith, ormris, hiraditya. yonghong-song requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-comm

[PATCH] D110128: [Driver] Correctly handle static C++ standard library

phosek created this revision. phosek added reviewers: MaskRay, mcgrathr. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When statically linking C++ standard library, we shouldn't add -Bdynamic after including the library on the link

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously, btf_tag attribute supports record, field, gl

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge updated this revision to Diff 373782. nridge added a comment. address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110051/new/ https://reviews.llvm.org/D110051 Files: clang-tools-extra/clangd/InlayHints.cpp clang-tools-extra/clangd

[PATCH] D110051: [clangd] Deduplicate inlay hints

nridge added a comment. In D110051#3009378 , @kadircet wrote: > I am not aware of how the intersecting hints are handled in the > implementation on the client side nor in the proposal today. After this patch > we might still produce them if for whatever

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur added a comment. This fixed the builder: http://meinersbur.de:8011/#/builders/76/builds/803 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 ___ cfe-c

[PATCH] D109632: [clang] de-duplicate methods from AST files

vsapsai added a comment. Looks like in `METHOD_POOL` we don't need the transitive closure for performance reasons. And we are kinda trying to store only data the module owns > // Only write this selector if it's not in an existing AST or something > // changed. But even if a single method i

[PATCH] D110044: Print nullptr_t namespace qualified within std::

dblaikie updated this revision to Diff 373768. dblaikie added a comment. Add debug info test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110044/new/ https://reviews.llvm.org/D110044 Files: clang/lib/AST/Type.cpp clang/test/AST/ast-dump-

[PATCH] D110123: [Proof of concept] Serialize fewer transitive methods in `METHOD_POOL`.

vsapsai created this revision. Herald added a subscriber: ributzka. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We are already making an effort to skip selectors that have methods only from other modules. But in edge cases we ke

[PATCH] D110044: Print nullptr_t namespace qualified within std::

dblaikie added a comment. In D110044#3009201 , @aaron.ballman wrote: >> This improves diagnostic (& important to me, DWARF) accuracy > > FWIW, I don't think the diagnostic particularly needs more accuracy here -- I > think users know what `nullptr_t` ty

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +StackSize)); tianshilei1992 wrote: > Do we wan

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:1057 + + Bld.restoreIP(OMPBuilder.createTargetInit(Bld, IsSPMD, requiresFullRuntime(), +StackSize)); Do we want to check somewh

[PATCH] D109967: Simplify handling of builtin with inline redefinition

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/memcpy-inline-builtin.c:1 +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -S -emit-llvm -o - %s -disable-llvm-passes | FileCheck %s +// nickdesaulniers wrote: > Would `-emit-codegen-only` b

[PATCH] D109967: Simplify handling of builtin with inline redefinition

nickdesaulniers added a comment. Please amend the bug description to link to: - https://bugs.llvm.org/show_bug.cgi?id=50322 - https://lore.kernel.org/lkml/20210822075122.864511-17-keesc...@chromium.org/ (You can do `git commit --amend; arc diff --verbatim` to have `arc` update the patch descrip

[PATCH] D109967: Simplify handling of builtin with inline redefinition

nickdesaulniers added a comment. Thanks for the patch! Please fix the lint checks. `git-clang-format HEAD~` should help, and IIRC there is a git hook when using `arc diff` (though maybe that requires one time setup? I seem to have an `.arclint` file in my `llvm-projects` checkout.

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ggeorgakoudis updated this revision to Diff 373755. ggeorgakoudis added a comment. Fix for clang-tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102107/new/ https://reviews.llvm.org/D102107 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang

[clang] 60ab686 - [clang] Fix a few more comment typos to cycle bots

Author: Nico Weber Date: 2021-09-20T20:06:03-04:00 New Revision: 60ab6861ed13e4f1e2729f8add6366a7be223d80 URL: https://github.com/llvm/llvm-project/commit/60ab6861ed13e4f1e2729f8add6366a7be223d80 DIFF: https://github.com/llvm/llvm-project/commit/60ab6861ed13e4f1e2729f8add6366a7be223d80.diff LO

[PATCH] D110116: [Clang] Ignore BTFTag attr if used as a type attribute

yonghong-song created this revision. yonghong-song added a reviewer: aaron.ballman. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, linux kernel has a __user attribute ([1]) defined as __attribute__((noderef, add

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra updated this revision to Diff 373747. tra edited the summary of this revision. tra added a comment. cosmetic cleanups. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://reviews.llvm.org/D110089 Files: clang/include/clang/Basi

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra added a comment. Here's expanded and formatted version of the header: https://gist.github.com/Artem-B/ec4290809650f5092d61d6dafa6b0131 It may help to see what's going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110089/new/ https://review

[clang] bde305b - [clang] Fix a few comment more typos to cycle bots

Author: Nico Weber Date: 2021-09-20T19:42:49-04:00 New Revision: bde305baf631004b8d00081f11e62b33e1665e45 URL: https://github.com/llvm/llvm-project/commit/bde305baf631004b8d00081f11e62b33e1665e45 DIFF: https://github.com/llvm/llvm-project/commit/bde305baf631004b8d00081f11e62b33e1665e45.diff LO

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

jhuber6 added a comment. In D110108#3010861 , @jdoerfert wrote: > The runtime code is missing, right? Yes, was going to make that a separate patch, also need to fix the LLVM tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D110108: [OpenMP] Add clang option to change device RTL stack size

jdoerfert added a comment. The runtime code is missing, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110108/new/ https://reviews.llvm.org/D110108 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian added a comment. I followed https://reviews.llvm.org/rGb7b9fdc114c1f9c788da914dac5c343277805446 for this, hope it's right, ptal Thomas. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110111/new/ https://reviews.llvm.org/D110111 ___

[PATCH] D110111: [WebAssembly] Add relaxed-simd feature

ngzhian created this revision. ngzhian added a reviewer: tlively. Herald added subscribers: dang, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. ngzhian requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. This currently only de

[clang] f119170 - [clang] Fix a few comment typos to cycle bots

Author: Nico Weber Date: 2021-09-20T18:48:34-04:00 New Revision: f11917057923bce7f9c04282b4a3b15ef0aad0d6 URL: https://github.com/llvm/llvm-project/commit/f11917057923bce7f9c04282b4a3b15ef0aad0d6 DIFF: https://github.com/llvm/llvm-project/commit/f11917057923bce7f9c04282b4a3b15ef0aad0d6.diff LO

[PATCH] D109710: [PowerPC] Add range checks for P10 Vector Builtins

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:1414 // CHECK-LE: ret <4 x float> return vec_splati_ins(vfa, 0, 1.0f); } Need to add a testcase where param `b` to `vec_splati_ins(a,b,c)` is not 0 or 1. Repository: rG

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern marked an inline comment as done. csmulhern added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:22414 + + EXPECT_EQ("int a = (int)b;", format("int a = (\n" + "int\n" csmulhern wrote: > MyDev

[PATCH] D109557: Adds a BreakBeforeClosingParen option

csmulhern updated this revision to Diff 373711. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109557/new/ https://reviews.llvm.org/D109557 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Conti

[clang] 96d3319 - Sema: relax va_start checking further for Windows AArch64

Author: Saleem Abdulrasool Date: 2021-09-20T21:23:33Z New Revision: 96d3319d6f024b17ac725d9595548acc4787003c URL: https://github.com/llvm/llvm-project/commit/96d3319d6f024b17ac725d9595548acc4787003c DIFF: https://github.com/llvm/llvm-project/commit/96d3319d6f024b17ac725d9595548acc4787003c.diff

[PATCH] D109437: [PowerPC] FP compare and test XL compat builtins.

lei added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3518 +// valid. The argument must be either a 'float' or a 'double'. +bool Sema::CheckPPCTestDataClassType(CallExpr *TheCall) { + QualType ArgType = TheCall->getArg(0)->getType(); I don't thi

[PATCH] D108823: [PowerPC] Mark splat immediate instructions as rematerializable

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Thx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108823/new/ https://reviews.llvm.org/D108823

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

thakis added a comment. Thanks, reverted in 9197834535364efff505580ef940ad41cd293275 for now. Here's a shorter cmake invocation that repros it: `cmake -GNinja -DCLANG_ENABLE_STATIC_ANALYZER=OFF ../llvm-project/llvm '-DLLVM_E

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS MaskRay wrote: > anirudhp wrote: > > MaskRay wrote: > > > If you add so man

[clang] 9197834 - Revert "Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source"

Author: Nico Weber Date: 2021-09-20T16:18:03-04:00 New Revision: 9197834535364efff505580ef940ad41cd293275 URL: https://github.com/llvm/llvm-project/commit/9197834535364efff505580ef940ad41cd293275 DIFF: https://github.com/llvm/llvm-project/commit/9197834535364efff505580ef940ad41cd293275.diff LO

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

MaskRay added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS anirudhp wrote: > MaskRay wrote: > > If you add so many RUN lines at once,

[PATCH] D110041: [clang] Use portable "#!/usr/bin/env bash" shebang for tools and utils.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110041/new/ https://reviews.llvm.org/D110041 ___

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

arichardson added a comment. In D109611#3010353 , @thakis wrote: > This breaks the build for us: > > Running cmake -GNinja -DCMAKE_BUILD_TYPE=Release > -DLLVM_ENABLE_ASSERTIONS=ON > '-DLLVM_ENABLE_PROJECTS=clang;compiler-rt;lld;chrometools;clang-tools

[PATCH] D109611: Fix CLANG_ENABLE_STATIC_ANALYZER=OFF building all analyzer source

thakis added a comment. This breaks the build for us: Running cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON '-DLLVM_ENABLE_PROJECTS=clang;compiler-rt;lld;chrometools;clang-tools-extra' -DLLVM_CHECK_ENABLED_PROJECTS=OFF '-DLLVM_TARGETS_TO_BUILD=AArch64;ARM;Mips;PowerPC;

[PATCH] D110029: [OpenMP][Offloading] Use bitset to indicate execution mode instead of value

tianshilei1992 updated this revision to Diff 373696. tianshilei1992 added a comment. Herald added a subscriber: mgorny. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110029/new/ https://reviews.llvm.org/D110029 Files: clang/lib/Code

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110083/new/ https://reviews.llvm.org/D110083 __

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added a comment. Really nice! No attributes in there, do you think it would be difficult to add them? We can definitely do that in another change to move this one forward. Comment at: clang/include/clang/Format/Format.h:1863-1864 + /// \warning + /// ``Q

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/docs/ClangOffloadBundler.rst:296 + * Their target triple are the same + * Their GPUArch are the same yaxunl wrote: > This does not match our final view of compatibility

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

arphaman added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake:509 set(DARWIN_macho_embedded_LIBRARY_OUTPUT_DIR - ${COMPILER_RT_OUTPUT_DIR}/lib/macho_embedded) + ${COMPILER_RT_OUTPUT_LIBRARY_DIR}/macho_embedded) set(DARWIN_ma

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

yaxunl added inline comments. Comment at: clang/docs/ClangOffloadBundler.rst:296 + * Their target triple are the same + * Their GPUArch are the same This does not match our final view of compatibility. Is this intentional? Thanks. Repository: rG LLVM Githu

[PATCH] D91944: OpenMP 5.0 metadirective

uweigand added a comment. In D91944#3009868 , @cchen wrote: > The SystemZ issue is due to the fact that we assumed that `device(cpu)` > should be evaluated to true and `device(gpu)` should be evaluated to false in > the test so the test should be fixed b

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373681. MyDeveloperDay added a comment. Remove debug code Tidy a few comments Remove Qualifier Order defaults (must be specified for Custom) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: cl

[PATCH] D110092: [clang][NFC] encapsulate global method list in GlobalMethodPool

rmaz updated this revision to Diff 373675. rmaz added a comment. remove unnecessary empty check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110092/new/ https://reviews.llvm.org/D110092 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Se

[PATCH] D110092: [clang][NFC] encapsulate global method list in GlobalMethodPool

rmaz created this revision. rmaz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change moves the `addMethodToGlobalList` function to be a private member function of the `GlobalMethodPool` class. This is a preparatory step to allow for

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

lei accepted this revision. lei added a comment. LGTM. Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109780/new/ https://reviews.llvm.org/D109780 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

lei accepted this revision as: lei. lei added a comment. LTGM Thx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109996/new/ https://reviews.llvm.org/D109996 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

lei added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:566-569 + if (llvm::find(FeaturesVec, "+pcrel") != FeaturesVec.end()) { +Diags.Report(diag::err_opt_not_valid_without_opt) << "-mpcrel" + <

[PATCH] D110089: [CUDA] Implement experimental support for texture lookups.

tra created this revision. tra added reviewers: jlebar, yaxunl, hliao. Herald added subscribers: bixia, mgorny. Herald added a reviewer: a.sidorin. tra requested review of this revision. Herald added a project: clang. The patch Implements support for testure lookups (mostly) in a header file. The

[PATCH] D109780: [PowerPC] Add range check for vec_genpcvm builtins

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109780/new/ https://reviews.llvm.org/D109780 _

[PATCH] D109996: [PowerPC] Fix signature of lxvp and stxvp builtins

Conanap accepted this revision as: Conanap. Conanap added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109996/new/ https://reviews.llvm.org/D109996 _

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373657. MyDeveloperDay added a comment. Missed dump_format_style.py update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

MyDeveloperDay updated this revision to Diff 373656. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. - Resolve the final issue I had regarding overlapping replacements (was adding double spaces between keywords), - Add ability to add a warning into the documentati

[PATCH] D109652: [PowerPC] Restrict various P10 options to P10 only.

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109652/new/ https://reviews.llvm.org/D109652 _

[PATCH] D103938: Diagnose -Wunused-value based on CFG reachability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63e0d038fc20: Diagnose -Wunused-value based on CFG reachability (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 63e0d03 - Diagnose -Wunused-value based on CFG reachability

Author: Yuanfang Chen Date: 2021-09-20T10:43:34-07:00 New Revision: 63e0d038fc20c894a3d541effa1bc2b1fdea37b9 URL: https://github.com/llvm/llvm-project/commit/63e0d038fc20c894a3d541effa1bc2b1fdea37b9 DIFF: https://github.com/llvm/llvm-project/commit/63e0d038fc20c894a3d541effa1bc2b1fdea37b9.diff

[PATCH] D110084: [PowerPC] Support for vector bool int128 on vector comparison builtins

Conanap created this revision. Conanap added reviewers: PowerPC, saghir, nemanjai. Conanap added projects: PowerPC, clang, LLVM. Herald added a subscriber: kbarton. Conanap requested review of this revision. This patch implements support for the type `vector bool int128` for arguments on vector co

[PATCH] D110083: [clang-offload-bundler][docs][NFC] Add archive unbundling documentation

saiislam created this revision. saiislam added reviewers: yaxunl, jdoerfert, grokos. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add documentation of unbundling of heterogeneous device archives to create device specific archive

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. The SystemZ issue is due to the fact that we assumed that `device(cpu)` should be evaluated to true and `device(gpu)` should be evaluated to false in the test so the test should be fixed by specifying the triple. (https://github.com/llvm/llvm-project/commit/3679d2001c87f3

[clang] a077271 - Revert code change of D63497 & D74399 for riscv64-*-linux GCC detection

Author: Fangrui Song Date: 2021-09-20T10:28:32-07:00 New Revision: a07727199db0525e9d2df41e466a2a1611b3c8e1 URL: https://github.com/llvm/llvm-project/commit/a07727199db0525e9d2df41e466a2a1611b3c8e1 DIFF: https://github.com/llvm/llvm-project/commit/a07727199db0525e9d2df41e466a2a1611b3c8e1.diff

[clang] 3679d20 - [NCF][OpenMP] Fix metadirective test on SystemZ

Author: cchen Date: 2021-09-20T12:22:54-05:00 New Revision: 3679d2001c87f37101e7f20c646b21e97d8a0867 URL: https://github.com/llvm/llvm-project/commit/3679d2001c87f37101e7f20c646b21e97d8a0867 DIFF: https://github.com/llvm/llvm-project/commit/3679d2001c87f37101e7f20c646b21e97d8a0867.diff LOG: [N

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

richkadel added a comment. I don't know if this is helpful or not, but we ran into a problem, recently, on Fuchsia when upgrading Clang (I believe to LLVM 14), and realized that the LLVM tools from Clang's version of LLVM were in compatible with the Rust profraw files. Since you're probably usi

[PATCH] D91944: OpenMP 5.0 metadirective

cchen added a comment. In D91944#3009003 , @uweigand wrote: > Looks like this was committed again, breaking the SystemZ build bots once > again: > https://lab.llvm.org/buildbot/#/builders/94/builds/5661 I'm going to fix this issue now. Repository: rG

[PATCH] D104285: [analyzer] Retrieve a value from list initialization of constant array declaration in a global scope.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1692-1694 +const bool IsOneDimensionalArray = +!isa(CAT->getElementType()); +if (IsOneDimensionalArray) { martong wrote: > aaron

[PATCH] D109818: [HIPSPV] Convert HIP kernels to SPIR-V kernels

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109818/new/ https://reviews.llvm.org/D109818 __

[PATCH] D109800: [clang] don't mark as Elidable CXXConstruct expressions used in NRVO

mizvekov updated this revision to Diff 373618. mizvekov added a comment. typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109800/new/ https://reviews.llvm.org/D109800 Files: clang/include/clang/Sema/Initialization.h clang/lib/AST/ExprConsta

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

aaronpuchert added a comment. In D106713#3009542 , @tstellar wrote: > @aaronpuchert Can you file a bug? Done: https://bugs.llvm.org/show_bug.cgi?id=51913. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1067

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:1434-1436 +bool addMethod(ObjCMethodDecl *Method) { + return AddedMethods.insert(Method).second; +} rmaz wrote: > rmaz wrote: > > dexonsmith wrote: > > > Hmm, I was imagini

[PATCH] D109632: [clang] de-duplicate methods from AST files

dexonsmith added a comment. In D109632#3007615 , @vsapsai wrote: > I don't remember for sure but I don't think there is a consistent policy > about a module storing transitive data or only data it owns. I suspect we > might be using both approaches and

[PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#3008426 , @dblaikie wrote: > Thanks for the suggestions/details, @dexonsmith - I've posted to llvm-dev > here: https://groups.google.com/g/llvm-dev/c/m9UVRhzJvh4/m/qdd_SyPuCQAJ and > will wait for some follow-up (

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

tstellar added a comment. @aaronpuchert Can you file a bug? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106713/new/ https://reviews.llvm.org/D106713 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG227673398c2d: [X86] Always check the size of SourceTy before getting the next type (authored by pengfei). Repository: rG LLVM Github Monorepo CHA

[clang] 2276733 - [X86] Always check the size of SourceTy before getting the next type

Author: Wang, Pengfei Date: 2021-09-20T23:34:19+08:00 New Revision: 227673398c2d93d9db02fe5fdb1af10a74251995 URL: https://github.com/llvm/llvm-project/commit/227673398c2d93d9db02fe5fdb1af10a74251995 DIFF: https://github.com/llvm/llvm-project/commit/227673398c2d93d9db02fe5fdb1af10a74251995.diff

[clang] 5b47256 - [X86] Add test to show the effect caused by D109607. NFC

Author: Wang, Pengfei Date: 2021-09-20T23:34:18+08:00 New Revision: 5b47256fa5402a5f7f06513b0d168746d4c46df2 URL: https://github.com/llvm/llvm-project/commit/5b47256fa5402a5f7f06513b0d168746d4c46df2 DIFF: https://github.com/llvm/llvm-project/commit/5b47256fa5402a5f7f06513b0d168746d4c46df2.diff

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei added a comment. In D109607#3009412 , @Meinersbur wrote: > In D109607#3009377 , @pengfei wrote: > >> In D109607#3008486 , @Meinersbur >> wrote: >> >>> However, m

[PATCH] D109424: [OpenCL] Supports atomics in C++ for OpenCL 2021

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG228dd20c3f1e: [OpenCL] Supports atomics in C++ for OpenCL 2021 (authored by Topotuna). Changed prior to commit: https://reviews.llvm.org/D109424?v

[clang] 228dd20 - [OpenCL] Supports atomics in C++ for OpenCL 2021

Author: Justas Janickas Date: 2021-09-20T16:24:30+01:00 New Revision: 228dd20c3f1e619193c68b288e0d5e8525c3a618 URL: https://github.com/llvm/llvm-project/commit/228dd20c3f1e619193c68b288e0d5e8525c3a618 DIFF: https://github.com/llvm/llvm-project/commit/228dd20c3f1e619193c68b288e0d5e8525c3a618.dif

[PATCH] D109894: [clangd] Bail-out when an empty compile flag is encountered

This revision was automatically updated to reflect the committed changes. Closed by commit rG444a5f304f6c: [clangd] Bail-out when an empty compile flag is encountered (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109894/new/

[clang-tools-extra] 444a5f3 - [clangd] Bail-out when an empty compile flag is encountered

Author: Kadir Cetinkaya Date: 2021-09-20T16:51:56+02:00 New Revision: 444a5f304f6c2c332f18392d2458d74664e98498 URL: https://github.com/llvm/llvm-project/commit/444a5f304f6c2c332f18392d2458d74664e98498 DIFF: https://github.com/llvm/llvm-project/commit/444a5f304f6c2c332f18392d2458d74664e98498.dif

[PATCH] D91948: [WIP][analyzer][doc] Add Container- and IteratorModeling developer docs

martong added a comment. Herald added a subscriber: manas. Nice work! Comment at: clang/docs/analyzer/developer-docs/ContainerModeling.rst:125 +The begin and end symbols are conjured and are completely unrelated to the region of +the container. For each region we store the onl

[PATCH] D109362: [SystemZ][z/OS] Add GOFF Support to the DataLayout

anirudhp added inline comments. Comment at: clang/test/CodeGen/target-data.c:256 +// RUN: %clang_cc1 -triple s390x-none-zos -o - -emit-llvm %s | \ +// RUN: FileCheck %s -check-prefix=ZOS MaskRay wrote: > If you add so many RUN lines at once, please use unittest

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 ___

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

Meinersbur added a comment. In D109607#3009377 , @pengfei wrote: > In D109607#3008486 , @Meinersbur > wrote: > >> However, my other one that is connected to lab.llvm.org has failed as well >> and should have sen

[PATCH] D110032: [analyzer] Move docs of SmartPtr to correct subcategory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5dee50111c13: [analyzer] Move docs of SmartPtr to correct subcategory (authored by RedDocMD). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] 5dee501 - [analyzer] Move docs of SmartPtr to correct subcategory

Author: Deep Majumder Date: 2021-09-20T20:13:04+05:30 New Revision: 5dee50111c13bbc4480401e2eaa67f6bca1b480a URL: https://github.com/llvm/llvm-project/commit/5dee50111c13bbc4480401e2eaa67f6bca1b480a DIFF: https://github.com/llvm/llvm-project/commit/5dee50111c13bbc4480401e2eaa67f6bca1b480a.diff

[PATCH] D106713: Thread safety analysis: Warn when demoting locks on back edges

aaronpuchert added a subscriber: tstellar. aaronpuchert added a comment. In D106713#3009130 , @aaron.ballman wrote: > In D106713#3007878 , @aaronpuchert > wrote: > >> @aaron.ballman, since this is reintroducing

[PATCH] D110051: [clangd] Deduplicate inlay hints

kadircet added a comment. I am not aware of how the intersecting hints are handled in the implementation on the client side nor in the proposal today. After this patch we might still produce them if for whatever reason there are different kinds of hints for the same range. Is this OK? ==

[PATCH] D109607: [X86] Refactor GetSSETypeAtOffset to fix pr51813

pengfei added a comment. In D109607#3008486 , @Meinersbur wrote: > However, my other one that is connected to lab.llvm.org has failed as well > and should have sent an email: > https://lab.llvm.org/buildbot/#/builders/102/builds/2722. Unfortunately it

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

pengfei added inline comments. Comment at: clang/test/CodeGen/X86/va-arg-sse.c:2 // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py // RUN: %clang_cc1 %s -O2 -emit-llvm -o - -triple x86_64-unknown-unknown | FileCheck %s Meinersbur

[PATCH] D110037: [X86] Always check the size of SourceTy before getting the next type

pengfei updated this revision to Diff 373581. pengfei marked 2 inline comments as done. pengfei added a comment. Address review comments. Thanks Roman and Michael. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/

[PATCH] D109883: [Analysis] Add support for vscale in computeKnownBitsFromOperator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf988f680649a: [Analysis] Add support for vscale in computeKnownBitsFromOperator (authored by david-arm). Herald added a project: clang. Herald added

[clang] f988f68 - [Analysis] Add support for vscale in computeKnownBitsFromOperator

Author: David Sherwood Date: 2021-09-20T15:01:59+01:00 New Revision: f988f680649ad38806897e7aa75e95e9fda88ffd URL: https://github.com/llvm/llvm-project/commit/f988f680649ad38806897e7aa75e95e9fda88ffd DIFF: https://github.com/llvm/llvm-project/commit/f988f680649ad38806897e7aa75e95e9fda88ffd.diff

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D103938#3007708 , @ychen wrote: > In D103938#3006540 , @aaron.ballman > wrote: > >> There w

  1   2   >