[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

Conanap added a comment. do we need an IR -> ASM test case as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106757/new/ https://reviews.llvm.org/D106757 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility

Conanap added inline comments. Comment at: clang/lib/Headers/altivec.h:3151 +#else +#define __vec_ldrmb __builtin_vsx_ldrmb +#define __vec_strmb __builtin_vsx_strmb I believe the preference is to have this defined in `clang/lib/Basic/Targets/PPC.cpp` under `defi

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 361487. MarcusJohnson91 edited the summary of this revision. MarcusJohnson91 added a comment. Added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753 Files: llvm/include/llvm/Support/ConvertU

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 updated this revision to Diff 361485. MarcusJohnson91 added a comment. Added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106753/new/ https://reviews.llvm.org/D106753 Files: llvm/include/llvm/Support/ConvertUTF.h llvm/lib/Support/ConvertUTFWrapper.cpp llvm/

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc < %s -mtriple=riscv64 -align-loops=32 | F

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

luismarques added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc < %s -mtriple=riscv64 -align-loops=32

[PATCH] D106733: [clang/darwin] Pass libclang_rt.profile last on linker command

MaskRay added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106733/new/ https://reviews.llvm.org/D106733 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

MaskRay added inline comments. Comment at: clang/test/LibClang/lit.local.cfg:1 + +config.substitutions.append(('%libclang', os.path.join(config.clang_lib_dir, 'libclang.so'))) delete blank line Comment at: clang/test/LibClang/symbols.test:2 +#

[PATCH] D106732: Support macro deprecation #pragma clang deprecated

beanz updated this revision to Diff 361480. beanz added a comment. Updating comment about remaining bits. Rather than subtracting one, I re-added up the bits. The bitfield is now at 40 bits, so it only has 24 bits remaining (someone please check my math). Repository: rG LLVM Github Monorepo

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc

[PATCH] D106737: DRAFT - [clang] [hexagon] Add resource include dir

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Thanks for the patch. This makes the behavior closer to Linux.cpp . Request changes to clear my queue before a test is added... Comment at: clang/lib/Driver/Tool

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc < %s -mtriple=riscv64 -align-loops=32 | Fi

[PATCH] D106756: Added l16/l32 length modifiers for char16_t/char32_t

MarcusJohnson91 created this revision. MarcusJohnson91 added reviewers: aaron.ballman, efriedma. MarcusJohnson91 added a project: clang. MarcusJohnson91 requested review of this revision. Split from D103426 Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D106755: Extended format string checking to wprintf/wscanf

MarcusJohnson91 created this revision. Herald added a subscriber: martong. Herald added a reviewer: aaron.ballman. MarcusJohnson91 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Split from D103426

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay marked 2 inline comments as done. MaskRay added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc

[PATCH] D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String

MarcusJohnson91 created this revision. MarcusJohnson91 added a project: clang. Herald added subscribers: dexonsmith, hiraditya. MarcusJohnson91 requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Split from D103426

[PATCH] D106585: Fix clang debug info irgen of i128 enums

dblaikie accepted this revision. dblaikie added a comment. Preserving existing behavior sounds OK - maybe some comment about that it might be good to remove so the next person who looks at it knows there's something not-quite-fully-reasoned here (& the comment about GCC's representation choice

[PATCH] D106721: [AArch64] Implemnt MSVC __mulh and __umulh builtins and corresponding IR level intrinsics

efriedma added a comment. We won't call compiler-rt for i128 multiply on aarch64. It's not worthwhile under any circumstances. Pattern-matching 64/64->128 multiply in SelectionDAG legalization has been reliable in practice, as far as I know. And even it misses due to weird behavior in instco

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

efriedma added a comment. This should split into three patches: 1. The ConvertUTFWrapper patch. 2. The patch to add format warnings for wprintf/wscanf/etc. 3. The patch to add the %l16/%l32 format modifiers. Comment at: clang/lib/AST/Expr.cpp:1091 + if (llvm::convertUTF32

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay added a comment. In D106701#2902544 , @dblaikie wrote: > In D106701#2901656 , @MaskRay wrote: > >> In D106701#2901639 , @efriedma >> wrote: >> >>> Can we hook thi

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

jrtc27 added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc < %s -mtriple=riscv64 -align-loops=32 | Fi

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

craig.topper added a comment. In D106701#2902544 , @dblaikie wrote: > In D106701#2901656 , @MaskRay wrote: > >> In D106701#2901639 , @efriedma >> wrote: >> >>> Can we hoo

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay added inline comments. Comment at: llvm/test/CodeGen/RISCV/loop-alignment.ll:3-4 +; RUN: llc < %s -mtriple=riscv64 | FileCheck %s +; RUN: llc < %s -mtriple=riscv64 -align-loops=16 | FileCheck %s -check-prefix=ALIGN_16 +; RUN: llc < %s -mtriple=riscv64 -align-loops=32 | F

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

dblaikie added a comment. In D106701#2901656 , @MaskRay wrote: > In D106701#2901639 , @efriedma > wrote: > >> Can we hook this up to a LLVM IR function attribute, instead of making it a >> codegen flag? > > The

[PATCH] D106746: [OpenMPOpt] Expand SPMDization with guarding

ggeorgakoudis updated this revision to Diff 361468. ggeorgakoudis added a comment. Code cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106746/new/ https://reviews.llvm.org/D106746 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp llvm/inc

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

MaskRay updated this revision to Diff 361467. MaskRay marked 2 inline comments as done. MaskRay added a comment. comments. add a test/CodeGen test. add HelpText. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106701/new/ https://reviews.llvm.org/D10

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 updated this revision to Diff 361466. MarcusJohnson91 added a comment. Full context diff after squashing all the commits together CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103426/new/ https://reviews.llvm.org/D103426 Files: clang-tools-extra/clang-tidy/boost/UseTo

[PATCH] D106748: [OpenCL] Add support of __opencl_c_pipes feature macro.

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 'pipe' keyword is introduced in OpenCL C 2.0: so do checks fo

[PATCH] D106746: [OpenMPOpt][WIP] Expand SPMDization with guarding

ggeorgakoudis updated this revision to Diff 361456. ggeorgakoudis added a comment. Update for sensible access to __kmpc_is_spmd_guarded_exec_mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106746/new/ https://reviews.llvm.org/D106746 Files: c

[PATCH] D106701: [clang] Add -falign-loops=N where N is a power of 2

luismarques added a comment. LGTM. I'll let someone familiar with the old option explicitly approve it. Comment at: clang/test/Driver/falign-loops.c:6-7 +// RUN: %clang -### -falign-loops=5 %s 2>&1 | FileCheck %s --check-prefix=CHECK-5 +// RUN: %clang -### -falign-loops=8 %s 2

[PATCH] D106746: [OpenMPOpt][WIP] Expand SPMDIzation with guarding

ggeorgakoudis created this revision. Herald added subscribers: ormris, guansong, hiraditya, yaxunl. ggeorgakoudis requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added subscribers: llvm-commits, ope

[clang] 05ae303 - [clang][patch] Remove test artifact before running test for consistent results

Author: Melanie Blower Date: 2021-07-24T07:55:10-04:00 New Revision: 05ae3035554aab083ea1ba721284c950cf25d158 URL: https://github.com/llvm/llvm-project/commit/05ae3035554aab083ea1ba721284c950cf25d158 DIFF: https://github.com/llvm/llvm-project/commit/05ae3035554aab083ea1ba721284c950cf25d158.diff

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

t-tye added a comment. In D106339#2890258 , @ldionne wrote: > What's the benefit of having docx documentation? We generate HTML > documentation, which ends up in the website, and that seems strictly superior > to generating docx. What do you need it for

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

t-tye updated this revision to Diff 361407. t-tye added a comment. Factor out documentation and CMake file changes unrelated to adding DOCX support to D106736 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106339/

[PATCH] D106339: Add support to generate Sphinx DOCX documentation

t-tye updated this revision to Diff 361402. t-tye added a comment. Split change for clang makefile to elimnate Sphinx warnings of missing .rst fies when building man pages into D106734 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

cor3ntin added inline comments. Comment at: clang/test/Parser/cxx2a-concepts-requires-expr.cpp:152-153 +}; +bool r42 = requires(typename S::type i) { + requires requires(typename S::type i) { requires true; }; +}; Quuxplusone wrote: > `s/int/T/` otherwise you mi

[PATCH] D106252: Make simple requirements starting with requires ill-formed in in requirement body

cor3ntin updated this revision to Diff 361416. cor3ntin added a comment. - Fix typos - remove the tests about typenames (don't pass yet) - Mark as partial until P2092 is implemented Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review