[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:693 +let Name = op # eew64 # "_v", IRName = op, IRNameMask = op # "_mask", +RequiredExtensions = ["Xlen64"] in { +def: RVVBuiltin<"v", "vPCe" # eew64_type # "U

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

craig.topper added a comment. In D106518#2895613 , @jacquesguan wrote: > In D106518#2895445 , @craig.topper > wrote: > >> Why do they need to be disabled? Doesn’t the spec define them to truncate? > > In the 1.0

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jacquesguan added a comment. In D106518#2895445 , @craig.topper wrote: > Why do they need to be disabled? Doesn’t the spec define them to truncate? In the 1.0-rc1, 18.2: The V extension supports all vector load and store instructions (Section Vector Lo

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG599b2f00370e: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion (authored by junparser). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 599b2f0 - [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

Author: Jun Ma Date: 2021-07-22T13:55:08+08:00 New Revision: 599b2f00370ee79e812d2776f2af57fae36d02e9 URL: https://github.com/llvm/llvm-project/commit/599b2f00370ee79e812d2776f2af57fae36d02e9 DIFF: https://github.com/llvm/llvm-project/commit/599b2f00370ee79e812d2776f2af57fae36d02e9.diff LOG: [

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail updated this revision to Diff 360699. lkail added a comment. Herald added a project: LLVM. Discussed with @jsji about the details of codegen and inspect XL's codegen at different opt level, add an `opt` test from jinsong to demonstrate the store can be eliminated. Repository: rG LLVM G

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

hubert.reinterpretcast added a comment. In D106371#2894736 , @anjankgk wrote: > Anjan Kumar Guttahalli Krishna > > Thank you! I running a build with this now -- I'll check its status in the morning. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106333/new/ https://reviews.llvm.org/D106333 ___

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

jrtc27 added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:555 +defvar Xlen32EEWList = [["8", "(Log2EEW:3)"], +["16", "(Log2EEW:4)"], Ignoring whether the change is actually correct, this should be capitalised as

[PATCH] D106518: [RISCV] Disable EEW=64 for index values when XLEN=32.

craig.topper added a comment. Why do they need to be disabled? Doesn’t the spec define them to truncate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106518/new/ https://reviews.llvm.org/D106518 ___ cfe

[PATCH] D106333: [AArch64][SVE] Handle svbool_t VLST <-> VLAT/GNUT conversion

junparser updated this revision to Diff 360690. junparser added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106333/new/ https://reviews.llvm.org/D106333 Files: clang/lib/AST/ASTContext.cpp clang/lib/Sema/SemaChec

[PATCH] D106516: to run test only

chh updated this revision to Diff 360688. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106516/new/ https://reviews.llvm.org/D106516 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang/include/clang/ASTMatchers/ASTMatchFinder.h clang/include/clang/Frontend/MultiplexConsumer.h

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

lkail added a comment. In D106344#2894755 , @jsji wrote: > Doesn't look good enough to me, the assembly code sequence generated is not > clean enough. I'm assuming you mean the second `stdcx.`, that looks like a historical issue which exists for 13yrs

[PATCH] D106516: to run test only

chh created this revision. chh requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. DO NOT SUBMIT. Only to run tests. https://reviews.llvm.org/D106516 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp Index: clang-tools-extra/

[PATCH] D103873: [Clang][RISCV] Implement vsoxseg and vsuxseg.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG698f288fa16c: [Clang][RISCV] Implement vsoxseg and vsuxseg. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D103809: [Clang][RISCV] Implement vloxseg and vluxseg.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1c55033ea16f: [Clang][RISCV] Implement vloxseg and vluxseg. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D103796: [Clang][RISCV] Implement vlsseg.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa9de8f7a5391: [Clang][RISCV] Implement vlsseg. (authored by HsiangKai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 754eb1c - [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

Author: Joseph Huber Date: 2021-07-21T20:56:21-04:00 New Revision: 754eb1c210d865234292df7a983636e2ff49e2c8 URL: https://github.com/llvm/llvm-project/commit/754eb1c210d865234292df7a983636e2ff49e2c8 DIFF: https://github.com/llvm/llvm-project/commit/754eb1c210d865234292df7a983636e2ff49e2c8.diff

[PATCH] D106496: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG754eb1c210d8: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size (authored by jhuber6). Changed prior to commit: https://r

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:409 +// analysis. +// This is so we don't need to plumb TargetTriple all the way to here. +if (mightUseStackSafetyAnalysis(Disab

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov updated this revision to Diff 360660. mizvekov added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105951/new/ https://reviews.llvm.org/D105951 Files: clang/include/clang/Sema/Sema.h clang/lib/Frontend/InitPreprocess

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td:25 +defvar TAIL_AGNOSTIC = 0; +defvar TAIL_UNDISTURBED = 1; Why are these the opposite polarity of what's in C? Repository: rG LLVM Github Monorepo CHANGES S

[clang-tools-extra] a46c63c - Fix assigned-but-unused (except in an assert) warning with a void cast

Author: David Blaikie Date: 2021-07-21T17:12:22-07:00 New Revision: a46c63c878a9e82ac2646926bb3d8237293ad15d URL: https://github.com/llvm/llvm-project/commit/a46c63c878a9e82ac2646926bb3d8237293ad15d DIFF: https://github.com/llvm/llvm-project/commit/a46c63c878a9e82ac2646926bb3d8237293ad15d.diff

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 360656. tstellar added a comment. Add missing file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: clang/test/CMakeLists.txt clang/test/LibClang/lit.loca

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 360654. tstellar added a comment. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: clang/test/CMakeLists.txt clang/test/LibClang/lit.loc

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1, setTraversalScope

chh updated this revision to Diff 360651. chh edited the summary of this revision. chh added a comment. Add one more skip-headers-2.cpp test, which shows desired check at a top-level Decl but not at nested Decl. Checking locations of only top-level Decls will miss the opportunity to skip nested

[PATCH] D98709: [clang-tidy] New feature --skip-headers, part 1, skip Decls

chh updated this revision to Diff 360649. chh edited the summary of this revision. chh added a comment. Add one more skip-headers-2.cpp test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98709/new/ https://reviews.llvm.org/D98709 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp c

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 360648. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-cod

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 360647. Ericson2314 added a comment. rebase, fixing conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt lib

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 360646. Ericson2314 added a comment. Rebase, fixing conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt lib

[PATCH] D105320: [CodeView] Saturate values bigger than supported by APInt.

mizvekov updated this revision to Diff 360645. mizvekov added a comment. - Really `git add` the test case this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105320/new/ https://reviews.llvm.org/D105320 Files: clang/lib/CodeGen/CGDebugInfo.

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

lattner added a comment. > cat f.c void x() { asm("bogus"); } > clang f.c f.c:3:7: error: invalid instruction mnemonic 'bogus' asm("bogus"); ^ :1:2: note: instantiated into assembly here bogus ^ 1 error generated. Repository: rG LLVM G

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8af333cf1a77: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8 (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 8af333c - [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

Author: Thomas Lively Date: 2021-07-21T16:45:54-07:00 New Revision: 8af333cf1a77f72ed3ccf14afa96a4f8f12e40c4 URL: https://github.com/llvm/llvm-project/commit/8af333cf1a77f72ed3ccf14afa96a4f8f12e40c4 DIFF: https://github.com/llvm/llvm-project/commit/8af333cf1a77f72ed3ccf14afa96a4f8f12e40c4.diff

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

lattner added a comment. The usecase for this is to get good diagnostics out of the integrated assembler. Try doing something like: `asm("bogus");`, GCC would produce an error pointing to the generated .s file. Clang should point to the C file (including macros expanded etc). Repository:

[PATCH] D105320: [CodeView] Skip emitting values bigger than supported by APInt.

mizvekov updated this revision to Diff 360643. mizvekov edited the summary of this revision. mizvekov added a comment. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. - Fixes more issues. - Add test cases. - Add some FIXME notes. Repository: rG LLVM Github Mon

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

tlively added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/simd-unsupported.ll:13 ; CHECK-LABEL: ctlz_v16i8: -; CHECK: i32.clz +; CHECK: i8x16.popcnt declare <16 x i8> @llvm.ctlz.v16i8(<16 x i8>, i1) aheejin wrote: > Aren't these now... "supported

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/WebAssembly/simd-unsupported.ll:13 ; CHECK-LABEL: ctlz_v16i8: -; CHECK: i32.clz +; CHECK: i8x16.popcnt declare <16 x i8> @llvm.ctlz.v16i

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

lei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:116 BUILTIN(__builtin_ppc_fres, "ff", "") +BUILTIN(__builtin_ppc_stbcx, "icD*i", "") maybe move this up to where `__builtin_ppc_stdcx` is defined. To match what you did in `PPC.

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

mizvekov added a comment. In D105951#2894888 , @STL_MSFT wrote: > FYI, we merged https://github.com/microsoft/STL/pull/2025 fixing the 2 > affected `return _Istr;` occurrences in `` and `` for VS > 2022 17.0 Preview 4. If you find any other affected ret

[PATCH] D106500: [WebAssembly] Remove clang builtins for extract_lane and replace_lane

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb7efcab7dd9: [WebAssembly] Remove clang builtins for extract_lane and replace_lane (authored by tlively). Repository: rG LLVM Github Monorepo CH

[clang] db7efca - [WebAssembly] Remove clang builtins for extract_lane and replace_lane

Author: Thomas Lively Date: 2021-07-21T16:11:00-07:00 New Revision: db7efcab7dd9c969179a86fb27149743a0f1f491 URL: https://github.com/llvm/llvm-project/commit/db7efcab7dd9c969179a86fb27149743a0f1f491 DIFF: https://github.com/llvm/llvm-project/commit/db7efcab7dd9c969179a86fb27149743a0f1f491.diff

[PATCH] D106506: [WebAssembly] Replace @llvm.wasm.popcnt with @llvm.ctpop.v16i8

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. U

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. Realized it's probably a good idea to add an opt out flag (counterpart to fuse-ctor-homing). Also, maybe in a separate patch, maybe should make these clang flags instead of cc1 flags- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D105951: [clang] P2266 implicit moves STL workaround

STL_MSFT added a comment. FYI, we merged https://github.com/microsoft/STL/pull/2025 fixing the 2 affected `return _Istr;` occurrences in `` and `` for VS 2022 17.0 Preview 4. If you find any other affected return statements, please let us know ASAP (as the VS release process locks down the rele

[PATCH] D106504: [OpenCL] Change default standard version to CL1.2

Anastasia created this revision. Anastasia added reviewers: svenvh, azabaznov. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. As suggested in RFC: https://lists.llvm.org/pipermail/cfe-dev/2021-June/068318.html set default version OpenCL C to 1.2. This me

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); fmayer wrote: > vitalybuka wr

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 360623. fmayer added a comment. more flag parsing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwas

[PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360621. akhuang added a comment. Herald added a subscriber: dang. Add an opt out flag: fno-use-ctor-homing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files: cl

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 360615. samitolvanen added a comment. This revision is now accepted and ready to land. As we only care about fixing inline assembly references, mangled names are not that important in the first place. This version skips any functions that have unusual cha

[PATCH] D105092: [PoC][RISCV] Add the tail policy argument to builtins/intrinsics.

craig.topper added a comment. Does lowerRISCVVMachineInstrToMCInst in RISCVMCInstLower.cpp need to know to skip the policy op? Comment at: llvm/lib/Target/RISCV/RISCVInsertVSETVLI.cpp:405 if (RISCVII::hasVLOp(TSFlags)) { const MachineOperand &VLOp = MI.getOperand(MI.ge

[PATCH] D106496: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106496/new/ https://reviews.llvm.org/D106496

[PATCH] D106500: [WebAssembly] Remove clang builtins for extract_lane and replace_lane

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: wingo, ecnelises, sunfish, jgravelle-google, sbc100. tlively requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These builtins were added to ca

[PATCH] D106344: [PowerPC] Implement XL compatible behavior of __compare_and_swap

jsji added a comment. Doesn't look like good enough to me, the code sequence generated is not clean enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106344/new/ https://reviews.llvm.org/D106344 __

[PATCH] D106496: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

jhuber6 updated this revision to Diff 360610. jhuber6 added a comment. Fixing free shared expecting the incorrect number of args. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106496/new/ https://reviews.llvm.org/D106496 Files: clang/lib/CodeGen

[PATCH] D106371: [AIX] Generate large code model relocations when mcmodel=medium on AIX

anjankgk added a comment. Anjan Kumar Guttahalli Krishna Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106371/new/ https://reviews.llvm.org/D106371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a72580a548d: [clang][Sema] removes -Wfree-nonheap-object reference param false positive (authored by cjdb). Changed prior to commit: https://revi

[clang] 9a72580 - [clang][Sema] removes -Wfree-nonheap-object reference param false positive

Author: Christopher Di Bella Date: 2021-07-21T21:30:16Z New Revision: 9a72580a548da8008dca479ec50e4eb75e56db71 URL: https://github.com/llvm/llvm-project/commit/9a72580a548da8008dca479ec50e4eb75e56db71 DIFF: https://github.com/llvm/llvm-project/commit/9a72580a548da8008dca479ec50e4eb75e56db71.dif

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:279 +The number of constituent arrays must equal the number rows in the matrix type M and the number of elements +in each constituent array must equal the number of columns in the matrix type. + -

[PATCH] D106496: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

jdoerfert added inline comments. Comment at: llvm/test/Transforms/OpenMP/remove_globalization.ll:41 ; CHECK-NEXT:[[TMP0:%.*]] = alloca i8, i64 4, align 1 +; CHECK-NEXT:call void @__kmpc_free_shared(i8* nocapture [[TMP0]], i64 noundef 4) #[[ATTR0]] ; CHECK-NEXT:ret

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); vitalybuka wrote: > Why not j

[PATCH] D106496: [OpenMP] Change `__kmpc_free_shared` to include the paired allocation size

jhuber6 created this revision. jhuber6 added a reviewer: jdoerfert. Herald added subscribers: guansong, hiraditya, yaxunl. jhuber6 requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, sstefan1. Herald added projects: clang, OpenMP, LLVM. This patc

[PATCH] D105594: cmake: Allow shared libraries to customize the soname using LLVM_ABI_REVISION

serge-sans-paille added inline comments. Comment at: clang/tools/clang-shlib/CMakeLists.txt:2 +# In the main branch, LLVM_ABI_REVISION should always be 0. In the release +# branches, this should be incremented before each release candidate every +# time the ABI of libclang-cpp.s

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:410 +Dummy.setArch(Triple::aarch64); +if (shouldUseStackSafetyAnalysis(Dummy, DisableOptimization)) + AU.addRequired(); Why not just: ``` if (!Di

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

dexonsmith added a comment. In D105491#2893632 , @simon_tatham wrote: > In D105491#2891860 , @dexonsmith > wrote: > >> although it'd be good to get someone more involved in lib/CodeGen to take a >> quick look /

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 360577. ABataev added a comment. Herald added subscribers: openmp-commits, sstefan1. Herald added a project: OpenMP. Added runtime test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 360573. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2893672 , @MyDeveloperDay wrote: > This feels like there is some overlap with D93938: [clang-format] Fixed > AfterEnum handling Yeah that may be, but it is stale for over

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

sammccall added a comment. In D106394#2893457 , @ldionne wrote: > In D106394#2892832 , @sammccall > wrote: > >> Eventually this seems like a reasonable thing to want for user code. What >> are your motivations f

[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

MaskRay added a comment. @davidxl @vsk 😃 I am happy to postpone this after 13.0.0 is branched - so that we can adjust the format while only bumping the version once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104556/new/ https://reviews.llvm.o

[PATCH] D106484: [PowerPC] Add PowerPC "__stbcx" builtin and intrinsic for XL compatibility

NeHuang created this revision. NeHuang added reviewers: nemanjai, PowerPC. NeHuang added a project: LLVM. Herald added subscribers: shchenz, kbarton, hiraditya. NeHuang requested review of this revision. Herald added a project: clang. Herald added subscribers: llvm-commits, cfe-commits. This patch

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev added a comment. In D99350#2894305 , @jdoerfert wrote: > I don't understand why the cast makes ptxas happy, can you include a test in > the runtime so we can make sure that stays that way and is not some ptxas > artifact. After all, we still poin

[clang] 9643d11 - [clang][sema] NFC, include DarwinSDKInfo header instead of using the forward reference

Author: Alex Lorenz Date: 2021-07-21T12:46:52-07:00 New Revision: 9643d11e1d7f918c0e5184c9488935720d591c90 URL: https://github.com/llvm/llvm-project/commit/9643d11e1d7f918c0e5184c9488935720d591c90 DIFF: https://github.com/llvm/llvm-project/commit/9643d11e1d7f918c0e5184c9488935720d591c90.diff L

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 360563. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_code

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

jdoerfert added a comment. I don't understand why the cast makes ptxas happy, can you include a test in the runtime so we can make sure that stays that way and is not some ptxas artifact. After all, we still point to a shared memory symbol from global memory which doesn't make too much sense.

[PATCH] D106069: [HIP] Add test with_fopenmp.hip

This revision was automatically updated to reflect the committed changes. Closed by commit rTd9107edc1a4e: [HIP] Add test with_fopenmp.hip (authored by yaxunl). Repository: rT test-suite CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106069/new/ https://reviews.llvm.org/D106069 Files:

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 360558. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 360553. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D106070: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb5f100fe4ca: [HIP] Remove workaround in __clang_hip_runtime_wrapper.h (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Gi

[clang] db5f100 - [HIP] Remove workaround in __clang_hip_runtime_wrapper.h

Author: Yaxun (Sam) Liu Date: 2021-07-21T15:16:28-04:00 New Revision: db5f100fe4ca252d7f392659e7da5dba10331ae7 URL: https://github.com/llvm/llvm-project/commit/db5f100fe4ca252d7f392659e7da5dba10331ae7 DIFF: https://github.com/llvm/llvm-project/commit/db5f100fe4ca252d7f392659e7da5dba10331ae7.dif

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai added inline comments. Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:818 +// performance. +RecordDecl *Canon = static_cast(RD->getCanonicalDecl()); +if (RD == Canon || Canon->getODRHash() == RD->getODRHash()) During investigation of a

[PATCH] D105257: [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb26ba9da8ae: [clang][darwin] add support for remapping macOS availability to Mac Catalyst… (authored by arphaman). Changed prior to commit: https

[clang] eb26ba9 - [clang][darwin] add support for remapping macOS availability to Mac Catalyst availability

Author: Alex Lorenz Date: 2021-07-21T11:32:25-07:00 New Revision: eb26ba9da8aeab8ecc1209034912f9f12a945128 URL: https://github.com/llvm/llvm-project/commit/eb26ba9da8aeab8ecc1209034912f9f12a945128 DIFF: https://github.com/llvm/llvm-project/commit/eb26ba9da8aeab8ecc1209034912f9f12a945128.diff L

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb added a comment. In D106394#2893681 , @Quuxplusone wrote: > If IWYU has already developed a de facto standard for this information, I > would recommend libc++ just use it (perhaps with no changes needed in clang > at all). This would have the bene

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4577-4583 + // If we have a complex type and the base type is smaller than 8 bytes, + // the ABI calls for the real and imaginary parts to be right-adjusted + // in separate doublewords. However, Clang

[PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 ___ cfe-commits mailing lis

[PATCH] D106393: [PowerPC][AIX] Add support for varargs for complex types on AIX

ZarkoCA updated this revision to Diff 360535. ZarkoCA added a comment. - Fix comment to also describe what happens in 32bit mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106393/new/ https://reviews.llvm.org/D106393 Files: clang/lib/CodeGen/

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a subscriber: aaron.ballman. mibintc added a comment. @aaron.ballman suggested I may have made a mistake adding the new option, I'll look there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95159/new/ https://reviews.llvm.org/D95159

[PATCH] D106005: [Docs] Define matrix initialisation in MatrixTypes documentation

SaurabhJha updated this revision to Diff 360524. SaurabhJha added a comment. Updated docs to address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106005/new/ https://reviews.llvm.org/D106005 Files: clang/docs/MatrixTypes.rst Index: c

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} MaskRay wrote: > tstellar wrote: > > MaskRay wrote: > > > What does this do? > > > > > >

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

MaskRay added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} tstellar wrote: > MaskRay wrote: > > What does this do? > > > > A hard-coded list cannot

[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

cjdb updated this revision to Diff 360519. cjdb added a comment. - renames files - makes it possible for `#pragma GCC system_header` to come after includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106394/new/ https://reviews.llvm.org/D106394

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. cstdlib test header contains // amdgcn already provides definition of fabs #ifndef __AMDGCN__ float fabs(float __x) { return __builtin_fabs(__x); } #endif If I delete or invert the ifndef > $HOME/llvm-build/llvm/lib/clang/13.0.0/include/__clang_hip_cmath

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar added inline comments. Comment at: clang/tools/libclang/CMakeLists.txt:82 + +if (LLVM_EXPORTED_SYMBOL_FILE) + add_custom_command(OUTPUT ${LLVM_EXPORTED_SYMBOL_FILE} MaskRay wrote: > What does this do? > > A hard-coded list cannot catch up with the real

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

tstellar updated this revision to Diff 360517. tstellar marked 3 inline comments as done. tstellar added a comment. Address some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 Files: c

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen added inline comments. Comment at: clang/test/Sema/i-c-e.c:77-78 + // expected-warning {{expression result unused}} +int comma3[(1, 2)]; // expected-warning {{variable length array folded to constant array as an extension}} \ + /

[PATCH] D103938: Diagnose -Wunused-value in constant evaluation context

ychen updated this revision to Diff 360514. ychen marked an inline comment as done. ychen added a comment. - fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103938/new/ https://reviews.llvm.org/D103938 Files: clang/include/clang/Sema/S

[PATCH] D101526: [analyzer][StdLibraryFunctionsChecker] Add NoteTags for applied arg constraints

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:857 +if (BR.isInteresting(ArgSVal)) + OS << Msg; + })); Szelethus wrote: > steakhal wrote: > > Ah, there is a slight issue. >

[PATCH] D105462: [X86] Add CRC32 feature.

hjl.tools added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:159 + // Enable CRC32 if SSE4.2 is enabled. + // NOTE: In conformance with GCC behavior, CRC32 is still available even if + // it's explicitly disabled. craig.topper wrote: > hjl.tool

[PATCH] D95159: [ASTReader] Allow controlling separately whether validation should be disabled for a PCH vs a module file

mibintc added a comment. The newly added test case clang/test/Index/preamble-reparse-changed-module.m is failing on the patch that I'm trying to commit, https://reviews.llvm.org/D93769 Actually the result of the test is a bit flaky, when I build the Debug version on Linux, running ninja check-c

  1   2   >