[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:69 +def sub_lo : SubRegIndex<32>; +def sub_hi : SubRegIndex<32, 32>; Jim wrote: > luismarques wrote: > > jrtc27 wrote: > > > This assumes RV32, and is not clear it applies to regi

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

tstellar added a comment. In D104714#2872826 , @tstellar wrote: > It looks like this patch breaks the > utils/update_cc_test_checks/check-globals.test on stand-alone builds of > clang, because it hard codes lit to lit.py in the llvm source tree. I thin

[PATCH] D105873: Fix utils/update_cc_test_checks/check-globals.test on stand-alone builds

tstellar created this revision. tstellar added a reviewer: jdenny. Herald added a subscriber: mgorny. tstellar requested review of this revision. Herald added a project: clang. We want to use LLVM_EXTERNAL_LIT if defined for the %lit substitution. Repository: rG LLVM Github Monorepo https://r

[PATCH] D105254: [RISCV] Support machine constraint "S"

kito-cheng added a comment. RISC-V GCC site has update the document for 'S'. https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=18a463bb666cc8f3421589e7641ec617acb84741 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105254/new/ https://reviews.llvm.org/

[PATCH] D98710: [clang-tidy] New feature --skip-headers, part 1

chh added a comment. Sam, the revision summary is updated. Could you review it again? The new summary would clarify a few points: - This --skip-headers is a new feature, not just a transparent run-time saving. It should be used carefully with header-filter and system-headers, and similarly han

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20176bc7dd3f: [clang] Refactor AST printing tests to share more infrastructure (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES

[clang] 20176bc - [clang] Refactor AST printing tests to share more infrastructure

Author: Nathan Ridge Date: 2021-07-13T01:48:30-04:00 New Revision: 20176bc7dd3f431db4c3d59b51a9f53d52190c82 URL: https://github.com/llvm/llvm-project/commit/20176bc7dd3f431db4c3d59b51a9f53d52190c82 DIFF: https://github.com/llvm/llvm-project/commit/20176bc7dd3f431db4c3d59b51a9f53d52190c82.diff

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

nridge added a comment. Will building with this option just prevent linking the clang-tidy checks into clangd, or will it also prevent building them in the first place? In my experience, it's the building that's the primary compile time expense, so if the intention is to address https://github.

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

Jim added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:69 +def sub_lo : SubRegIndex<32>; +def sub_hi : SubRegIndex<32, 32>; luismarques wrote: > jrtc27 wrote: > > This assumes RV32, and is not clear it applies to register pairs > What

[PATCH] D105869: [Driver] fix PowerPC SPE musl dynamic linker name

pattop created this revision. Herald added subscribers: steven.zhang, shchenz, nemanjai. pattop requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Musl treats PowerPC SPE as a soft-float target (as the PowerPC SPE ABI is soft-float compatible)

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:3004 +} else if (CGM.getTriple().isOSAIX()) + // On AIX, all thread_local vars will have init routines regardless of + // whether they are const-initialized or not. Since

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

khchen added inline comments. Comment at: clang/test/Driver/riscv-abi.c:68 -// RUN: %clang -target riscv64-unknown-elf %s -### -o %t.o -march=rv64d -mabi=lp64d 2>&1 \ +// RUN: %clang -target riscv64-unknown-elf %s -### -o %t.o -march=rv64ifd -mabi=lp64d 2>&1 \ // RUN: | Fi

[PATCH] D105565: [analyzer] Print time taken to analyze each function

This revision was automatically updated to reflect the committed changes. Closed by commit rGcad9b7f708e2: [analyzer] Print time taken to analyze each function (authored by RithikSharma). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://rev

[clang] cad9b7f - [analyzer] Print time taken to analyze each function

Author: SharmaRithik Date: 2021-07-13T04:52:47Z New Revision: cad9b7f708e2b2d19d7890494980c5e427d6d4ea URL: https://github.com/llvm/llvm-project/commit/cad9b7f708e2b2d19d7890494980c5e427d6d4ea DIFF: https://github.com/llvm/llvm-project/commit/cad9b7f708e2b2d19d7890494980c5e427d6d4ea.diff LOG:

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:42 + // keep entries in canonical order of extension. + typedef std::map + OrderedExtensionMap; craig.topper wrote: > Could this be a sorted vector? Would require a good

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. Looks great, thanks for reusing the reusables! Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2260-2261 + InterestingSymbols.erase(sym); + if (const auto *meta = dyn_cast(sym)) +markNotInteresting(meta->getRegion()); +} You

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 358130. kito-cheng added a comment. Changes: - Using RISCVISAInfo in riscv::getRISCVABI - Allow rv32e for -march. - Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https:/

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

NoQ added a comment. This is amazing, great progress! I added the parent revision because it didn't compile on pre-merge checks otherwise. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:801 +// must be a superset of, but not necessarily equal to ExitOwner

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb updated this revision to Diff 358127. cjdb marked 6 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102728/new/ https://reviews.llvm.org/D102728 Files: clang/lib/Sema/SemaChe

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 __

[PATCH] D105001: [Clang][RISCV] Support half-precision floating point for RVV intrinsics.

khchen added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vfadd.c:13 +// ASM-NOT: warning #include HsiangKai wrote: > craig.topper wrote: > > Do you plan to bring back the ASM check for all tests? > No, I will remove it. Thi

[PATCH] D103527: [Clang][RISCV] Implement vlseg and vlsegff.

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:836 + clang::CharUnits Align = + CGM.getNaturalTypeAlignment(getContext().getSizeType()); + llvm::Value *V; I don't think this alignment is correct. A vin

[PATCH] D104714: [UpdateCCTestChecks] Support --check-globals

tstellar added a comment. It looks like this patch breaks the utils/update_cc_test_checks/check-globals.test on stand-alone builds of clang, because it hard codes lit to lit.py in the llvm source tree. I think it should using the lit passed to -DLLVM_EXTERNAL_LIT= (if that option was specified

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

Meinersbur added a comment. ping It would be nice if we could get this into clang 13 since the ccache part detects support for `-fnormalize-whitespace` when detecting clang 13+. Probing the compiler for whether it supports `-fnormalize-whitespace` on every run would be prohibitively expensive.

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

kkwli0 added a comment. Is the diff from HEAD? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D105014: added some example code for llvm::Expected

dblaikie added subscribers: lhames, dblaikie. dblaikie added a comment. +@lhames for context as the author/owner of `llvm::Error` and associated things. Perhaps it'd be handy to have some descriptions of the problems you encountered, @kuhnel, and how you went about trying to resolve them, to hel

[PATCH] D105858: opencl-c.h: add 3.0 optional extension support for a few more bits

airlied created this revision. airlied added a project: clang. Herald added subscribers: ldrumm, Anastasia, yaxunl. airlied requested review of this revision. Herald added a subscriber: cfe-commits. These 3 are fairly simple, pipes, workgroups and subgroups. Repository: rG LLVM Github Monorepo

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3255-3256 +def warn_not_xl_compatible +: Warning<"requested alignment of arguments 16 bytes or greater is not" + " compatible wit

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:3003-3010 +} else if (CGM.getTriple().isOSAIX()) + // On AIX, all thread_local vars will have init routines regardless of + // whether they are const-initialized or not. S

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51fc742ce716: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm (authored by MaskRay). Repository: rG LLVM Github Monorepo CHAN

[clang] 51fc742 - [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

Author: Fangrui Song Date: 2021-07-12T15:46:20-07:00 New Revision: 51fc742ce716a09359f4f87ffe3876cb7ff9479d URL: https://github.com/llvm/llvm-project/commit/51fc742ce716a09359f4f87ffe3876cb7ff9479d DIFF: https://github.com/llvm/llvm-project/commit/51fc742ce716a09359f4f87ffe3876cb7ff9479d.diff

[PATCH] D105660: [PowerPC][AIX] Add warning when alignment is incompatible with XL

ZarkoCA updated this revision to Diff 358087. ZarkoCA added a comment. - Warning should only apply to members of struct - Re-word warning slightly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105660/new/ https://reviews.llvm.org/D105660 Files:

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

dblaikie accepted this revision. dblaikie added a comment. Sure, sounds OK. Please make the corresponding change to llc and revert the other patch after this one & the llc one are done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105835/new/ htt

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2872080 , @jroelofs wrote: >> compiler-rt depends on a libc, typically newlib, which then depends on your >> compiler > > The builtins should only depend on compiler-provided headers, and not on the > rest of libc. Agree

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

osandov accepted this revision. osandov added a comment. This revision is now accepted and ready to land. That's fair enough. I don't know if I'm qualified to review this, but this I think this is a better solution than my fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

arichardson added a comment. In D98113#2872080 , @jroelofs wrote: >> compiler-rt depends on a libc, typically newlib, which then depends on your >> compiler > > The builtins should only depend on compiler-provided headers, and not on the > rest of libc.

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

MaskRay added a comment. In D105835#2872393 , @osandov wrote: > I tested my reproducer and it also fixes it, thanks. Should it be an error to > specify `-fno-dwarf-directory-asm` together with `-gdwarf-5`, since that > produces incorrect results? I tho

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

osandov added a comment. I tested my reproducer and it also fixes it, thanks. Should it be an error to specify `-fno-dwarf-directory-asm` together with `-gdwarf-5`, since that produces incorrect results? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

MaskRay added a comment. In D105835#2872362 , @dblaikie wrote: > Not sure I quite follow - is this an alternative to/replacement for D105662 > ? Is the intent to revert D105662 > after

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

dblaikie added a comment. Not sure I quite follow - is this an alternative to/replacement for D105662 ? Is the intent to revert D105662 after this (D105835 ) (& some corresponding change to ll

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

nemanjai added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-pwr8.c:1 +// RUN: %clang_cc1 -triple powerpc64-unknown-unknown -emit-llvm %s \ +// RUN: -target-cpu pwr8 -o - | FileCheck %s -check-prefix=CHECK-PWR8 Oh, I believe you're missi

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105834/new/ https://reviews.llvm.org/D105834 __

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 __

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks reasonable to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105457/new/ https://reviews.llvm.org/D105457

[PATCH] D105035: [clang] Document llvm options controlling pragma unroll

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fe058dbe49b: [clang] Document llvm options controlling pragma unroll (authored by yaxunl). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CH

[clang] 8fe058d - [clang] Document llvm options controlling pragma unroll

Author: Yaxun (Sam) Liu Date: 2021-07-12T16:42:50-04:00 New Revision: 8fe058dbe49b060c85f490ece2268c32b0fad7c8 URL: https://github.com/llvm/llvm-project/commit/8fe058dbe49b060c85f490ece2268c32b0fad7c8 DIFF: https://github.com/llvm/llvm-project/commit/8fe058dbe49b060c85f490ece2268c32b0fad7c8.dif

[PATCH] D105365: [Lexer] Fix bug in `makeFileCharRange` called on split tokens.

ymandel added a comment. Gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105365/new/ https://reviews.llvm.org/D105365 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

clayborg requested changes to this revision. clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1305 + + // If a function has an auto return type we need to find the defintion since + // that will have the deduced return typ

[PATCH] D105703: [hwasan] Use stack safety analysis.

eugenis added a comment. The analysis should not run at -O0. Otherwise, LGTM. What kind of code size improvement do you see? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 ___

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0ec812023b43: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove… (authored by flx). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10573

[clang-tools-extra] 0ec8120 - [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

Author: Felix Berger Date: 2021-07-12T16:23:04-04:00 New Revision: 0ec812023b43992810499b04222348fdbdb41ef2 URL: https://github.com/llvm/llvm-project/commit/0ec812023b43992810499b04222348fdbdb41ef2 DIFF: https://github.com/llvm/llvm-project/commit/0ec812023b43992810499b04222348fdbdb41ef2.diff

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 358049. quinnp added a comment. Addressing review comments. Using an early exit for SemaFeatureCheck and combining the 3 test cases into 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://revi

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jroelofs added a comment. > compiler-rt depends on a libc, typically newlib, which then depends on your > compiler The builtins should only depend on compiler-provided headers, and not on the rest of libc. Agreed re: the rest of compiler-rt. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jroelofs added a comment. Why do you want to ship the builtins as part of your sysroot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 ___ cfe-commits mailing li

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358043. fmayer added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-saf

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra added inline comments. Comment at: clang/test/CodeGen/builtins-nvptx-mma.py:35-38 +def make_mma_ops(geoms, types_a, types_b, types_c, types_d, b1ops=None): ops = [] + if b1ops is None: +b1ops = [""] steffenlarsen wrote: > Default initializers that us

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-multiply.ll:9 +; RUN: llc -verify-machineinstrs -mtriple=powerpc64-unknown-aix \ +; RUN: -mcpu=pwr9 < %s | FileCheck %s --check-prefix=CHECK-64 + amyk wrote: > Does it ma

[PATCH] D105384: [NVPTX, CUDA] Add .and.popc variant of the b1 MMA instruction.

tra updated this revision to Diff 358041. tra marked an inline comment as done. tra edited the summary of this revision. tra added a comment. Addressed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105384/new/ https://reviews.llvm.

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added a comment. Need to merge with https://reviews.llvm.org/D105501 changes once approved for pwr9 (or later processor) only sema checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://reviews.llvm.org/D102875 __

[PATCH] D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

This revision was automatically updated to reflect the committed changes. Closed by commit rG798fe3c774a1: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign. (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105635/new/

[clang] 798fe3c - [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

Author: Steven Wan Date: 2021-07-12T15:31:15-04:00 New Revision: 798fe3c774a1af75c8735933ded749fa62f39594 URL: https://github.com/llvm/llvm-project/commit/798fe3c774a1af75c8735933ded749fa62f39594 DIFF: https://github.com/llvm/llvm-project/commit/798fe3c774a1af75c8735933ded749fa62f39594.diff LO

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4790 +llvm::Value *Arg2 = llvm::ConstantExpr::getBitCast( +cast(dtor.getCallee()), FpTy); +CGF.EmitNounwindRuntimeCall(AtExit, {Arg1, Arg2}); The functio

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

nemanjai added a comment. The testing is a bit overkill. A single test case with run lines for `-mcpu=pwr7-10` and a single prefix for each should suffice. For each prefix, just check for `+/-` for all the features you expect. The triples can be randomly distributed across the 4 run lines. And

[PATCH] D105835: [Driver] Let -fno-integrated-as -gdwarf-5 use -fdwarf-directory-asm

MaskRay created this revision. MaskRay added reviewers: debug-info, dblaikie, osandov. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. While GNU as only allows the directory form of the .file directive for DWARF v5, the integrated p

[PATCH] D105834: [PowerPC] Semachecking for XL compat builtin icbt

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is in a series of patches to provide builtins for compatibility with the XL compiler. Thi

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

flx updated this revision to Diff 358010. flx marked 2 inline comments as done. flx added a comment. Invert end of string logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105734/new/ https://reviews.llvm.org/D105734 Files: clang-tools-extra/

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_u_f64x2_i32x4, "V4UiV2d", "nc", "simd128"

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

lei added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3278 + StringRef DiagArg = "") { + if (!S.Context.getTargetInfo().hasFeature(FeatureToCheck)) { +if (!DiagArg.empty()) { may I suggest early exit instead? ```

[PATCH] D105526: opencl-c.h: CL3.0 generic address space

airlied updated this revision to Diff 358005. airlied added a comment. full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105526/new/ https://reviews.llvm.org/D105526 Files: clang/lib/Headers/opencl-c.h Index: clang/lib/Headers/opencl-c.h ==

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think this looks good, thanks for fixing this! I believe there should be a few more tests for all the corner cases we can run into here (those tests can all be just Python AP

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 358004. quinnp added a comment. Adding tests for each of the features Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/include/clang/Basic/DiagnosticSema

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:50 + size_t Offset = std::strcspn(TextAfter, "\n"); + return Loc.getLocWithOff

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

flx marked 2 inline comments as done. flx added a comment. Thanks for the review! Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyInitialization.cpp:51 + if (Tok && !Invalid) { +size_t Offset = std::strcspn(TextAfter, "\n"); +auto PastNewLine = Stm

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

flx updated this revision to Diff 357993. flx added a comment. Make offset operations safer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105734/new/ https://reviews.llvm.org/D105734 Files: clang-tools-extra/clang-tidy/performance/UnnecessaryCo

[PATCH] D103395: PR45879: Keep evaluated expression in LValue object

sepavloff updated this revision to Diff 357988. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103395/new/ https://reviews.llvm.org/D103395 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/consta

[clang] cbabfc6 - [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

Author: Thomas Lively Date: 2021-07-12T10:32:18-07:00 New Revision: cbabfc63b1be274316552d3eaaf7b2ad88c4c073 URL: https://github.com/llvm/llvm-project/commit/cbabfc63b1be274316552d3eaaf7b2ad88c4c073 DIFF: https://github.com/llvm/llvm-project/commit/cbabfc63b1be274316552d3eaaf7b2ad88c4c073.diff

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcbabfc63b1be: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2 (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively added inline comments. Comment at: clang/include/clang/Basic/BuiltinsWebAssembly.def:192-193 TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_s_f64x2_i32x4, "V4iV2d", "nc", "simd128") TARGET_BUILTIN(__builtin_wasm_trunc_sat_zero_u_f64x2_i32x4, "V4UiV2d", "nc", "simd128"

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively updated this revision to Diff 357983. tlively added a comment. - Check types of splats as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105755/new/ https://reviews.llvm.org/D105755 Files: clang/include/clang/Basic/BuiltinsWebAssembl

[PATCH] D105254: [RISCV] Support machine constraint "S"

MaskRay added a comment. In D105254#2871278 , @luismarques wrote: > In D105254#2852489 , @luismarques > wrote: > >> Makes sense. Let's wait for the GCC Bugzilla feedback. > > With 'S' now documented on the GNU s

[PATCH] D104381: [analyzer] Added a test case for PR46264

ASDenysPetrov added a comment. @NoQ Just a ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104381/new/ https://reviews.llvm.org/D104381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D104420: thread_local support for AIX

jamieschmeiser updated this revision to Diff 357970. jamieschmeiser added a comment. Respond to review comments: Update to tests to create common LINUX/AIX portions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104420/new/ https://reviews.llvm.org/D104420 Files: clang/lib/CodeGen/

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: compiler-rt/docs/BuildingCompilerRT.rst:12-22 +The instructions on this page are aimed at vendors who ship Compiler-RT as part of an +operating system distribution, a toolchain or simila

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

Ericson2314 marked an inline comment as done. Ericson2314 added inline comments. Comment at: compiler-rt/cmake/base-config-ix.cmake:97 + else() +set(temp_path "${temp_path}/${current_segment}") + endif() phosek wrote: > This isn't set before so it should be

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx

Ericson2314 updated this revision to Diff 357969. Ericson2314 added a comment. Herald added projects: clang, libc++, libc++abi, libunwind. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Herald added a reviewer: libc++abi. Herald added a reviewer: libunwind.

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @vsavchenko I've updated the summary. I hope, I addressed your question. Currently, this patch has some issues and may not fully reflect the summary. I'll update it soon(not without your suggestions). Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. In D105439#2871429 , @Quuxplusone wrote: > Given that the goal is to get `include-what-you-use` to stop suggesting that > users `#include <__detail/fooimpl.h>` when what they want is spelled > ``, I think what's desired here (if a

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

Quuxplusone added a comment. Given that the goal is to get `include-what-you-use` to stop suggesting that users `#include <__detail/fooimpl.h>` when what they want is spelled ``, I think what's desired here (if anything) would be a pragma targeted at `include-what-you-use` (and other tools). Ba

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rGef49d925e2a7: [PowerPC] Implement trap and conversion builtins for XL compatibility (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1036

[clang] ef49d92 - [PowerPC] Implement trap and conversion builtins for XL compatibility

Author: Albion Fung Date: 2021-07-12T11:04:17-05:00 New Revision: ef49d925e2a788248473b847a0e51835c6ca854f URL: https://github.com/llvm/llvm-project/commit/ef49d925e2a788248473b847a0e51835c6ca854f DIFF: https://github.com/llvm/llvm-project/commit/ef49d925e2a788248473b847a0e51835c6ca854f.diff L

[PATCH] D105439: [clang] protects users from relying on libc++ detail headers

cjdb added a comment. Ping @aaron.ballman and @ldionne Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105439/new/ https://reviews.llvm.org/D105439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D105666: [PowerPC] [Altivec] Use signed comparison for vec_all_* and vec_any_* interfaces that compare vector bool types with vector signed types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2071ce9d4559: [Altivec] Use signed comparison for vec_all_* and vec_any_* interfaces (authored by bmahjour). Repository: rG LLVM Github Monorepo

[clang] 2071ce9 - [Altivec] Use signed comparison for vec_all_* and vec_any_* interfaces

Author: Bardia Mahjour Date: 2021-07-12T11:41:16-04:00 New Revision: 2071ce9d4559d444a065d78248a7381bf121b766 URL: https://github.com/llvm/llvm-project/commit/2071ce9d4559d444a065d78248a7381bf121b766 DIFF: https://github.com/llvm/llvm-project/commit/2071ce9d4559d444a065d78248a7381bf121b766.diff

[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr

RedDocMD created this revision. RedDocMD added reviewers: NoQ, vsavchenko, xazax.hun, teemperor. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. RedDocMD requested review of this re

[PATCH] D105254: [RISCV] Support machine constraint "S"

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. In D105254#2852489 , @luismarques wrote: > Makes sense. Let's wait for the GCC Bugzilla feedback. With 'S' now documented on the GNU side,

[PATCH] D105819: [analyzer] MallocChecker: Add a visitor to leave a note on functions that could have, but did not change ownership on leaked memory

Szelethus created this revision. Szelethus added reviewers: NoQ, vsavchenko, steakhal, martong, ASDenysPetrov. Szelethus added a project: clang. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity,

[clang] 11b47c1 - Reland "[clang-repl] Implement partial translation units and error recovery."

Author: Vassil Vassilev Date: 2021-07-12T15:21:22Z New Revision: 11b47c103a36371576711cae1f7527c26f78efb5 URL: https://github.com/llvm/llvm-project/commit/11b47c103a36371576711cae1f7527c26f78efb5 DIFF: https://github.com/llvm/llvm-project/commit/11b47c103a36371576711cae1f7527c26f78efb5.diff LO

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

balazske updated this revision to Diff 357947. balazske added a comment. Using the new symbol "uninterestingness" feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104925/new/ https://reviews.llvm.org/D104925 Files: clang/lib/StaticAnalyzer

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added a comment. In D77491#2870291 , @jdoerfert wrote: > First: > Do I assume right this this feature was simply disabled without any plan to: > > - inform the authors (me) > - update the documentation > - re-enable support eventually or provide alt

  1   2   >