[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

efriedma added a comment. The part I'm confused about is that you're forcing it to use "*r". At the IR level, LLVM handles something like `call void asm sideeffect "#$0", "r"([8 x i64] %c)` fine. You'll have to do a bit of work to teach clang to emit that, but it shouldn't be that hard. I th

[PATCH] D105263: [X86] AVX512FP16 instructions enabling 1/6

pengfei added inline comments. Comment at: clang/lib/Headers/avx512vlfp16intrin.h:74 +static __inline__ __m256h __DEFAULT_FN_ATTRS256 _mm256_abs_ph(__m256h __A) { + return (__m256h)_mm256_and_epi32(_mm256_set1_epi32(0x7FFF7FFF), (__m256i)__A); +} craig.topper w

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

nemanjai added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1535 - def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx">, - Intrinsic<[llvm_i64_ty], [llvm_ptr_ty], [IntrNoMem]>; } lkail wrote: > Just curious, compi

[PATCH] D105675: [WebAssembly] Custom combines for f64x2.promote_low_f32x4

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe5220104d070: [WebAssembly] Custom combines for f64x2.promote_low_f32x4 (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] e522010 - [WebAssembly] Custom combines for f64x2.promote_low_f32x4

Author: Thomas Lively Date: 2021-07-09T18:59:29-07:00 New Revision: e5220104d0708e02f2faaacc091189fb3e47e30c URL: https://github.com/llvm/llvm-project/commit/e5220104d0708e02f2faaacc091189fb3e47e30c DIFF: https://github.com/llvm/llvm-project/commit/e5220104d0708e02f2faaacc091189fb3e47e30c.diff

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

lkail added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1535 - def int_ppc_ldarx : GCCBuiltin<"__builtin_ppc_ldarx">, - Intrinsic<[llvm_i64_ty], [llvm_ptr_ty], [IntrNoMem]>; } Just curious, compiler optimizes the

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357684. Conanap added a comment. Fixed more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/b

[PATCH] D105755: [WebAssembly] Custom combines for f32x4.demote_zero_f64x2

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357681. Conanap added a comment. Added modifier to $1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/bu

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

sunfish added inline comments. Comment at: llvm/test/CodeGen/WebAssembly/varargs.ll:5 -target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128" -target triple = "wasm32-unknown-unknown" +target triple = "wasm32-unknown-emscripten" It appears this change means t

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357680. Conanap added a comment. Update test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/built

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. LDARX and LWARX sometimes gets optimized out by the compiler when it i

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGac02baab48c2: WebAssembly: Update datalayout to match fp128 ABI change (authored by dschuff). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[clang] ac02baa - WebAssembly: Update datalayout to match fp128 ABI change

Author: Derek Schuff Date: 2021-07-09T16:51:36-07:00 New Revision: ac02baab48c2ff512e40140e2fe6845d2b6a636f URL: https://github.com/llvm/llvm-project/commit/ac02baab48c2ff512e40140e2fe6845d2b6a636f DIFF: https://github.com/llvm/llvm-project/commit/ac02baab48c2ff512e40140e2fe6845d2b6a636f.diff

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added inline comments. Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif jdoerfert wrote: > estewart08 wrote: > > JonChesterfield wrote: > > > jdoerfert wrote: > > > > That se

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:175 +if (T.isOSEmscripten()) + resetDataLayout("e-m:e-p:32:32-i64:64-f128:64-n32:64-S128-ni:1"); +else kripken wrote: > Should this not be > > resetDataLayout("e-m:e-p:

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff updated this revision to Diff 357665. dschuff added a comment. - fix wasm64 copypasta Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105749/new/ https://reviews.llvm.org/D105749 Files: clang/lib/Basic/Targets/WebAssembly.h llvm/lib/Targ

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

kripken added inline comments. Comment at: clang/lib/Basic/Targets/WebAssembly.h:175 +if (T.isOSEmscripten()) + resetDataLayout("e-m:e-p:32:32-i64:64-f128:64-n32:64-S128-ni:1"); +else Should this not be resetDataLayout("e-m:e-p:64:64-i64:64-f128:64-

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff added a reviewer: sbc100. dschuff added a comment. This fix should go in ASAP (or else we should revert d1a96e906cc03a95cfd41a1f22bdda92651250c7 ) to fix the mismatch between LLVM and clang. Repository: rG LLVM Git

[PATCH] D105749: WebAssembly: Update datalayout to match fp128 ABI change

dschuff created this revision. dschuff added a reviewer: azakai. Herald added subscribers: sunfish, hiraditya, jgravelle-google, sbc100. dschuff requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added projects: clang, LLVM. This fix goes along with d1a96e906

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

jdoerfert added inline comments. Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif estewart08 wrote: > JonChesterfield wrote: > > jdoerfert wrote: > > > That seems to be fundamentally broken

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Give this a bit for other reviewers (it is afterall friday afternoon in the US:)), but this seems like an improvement to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

lebedev.ri updated this revision to Diff 357648. lebedev.ri marked 2 inline comments as done. lebedev.ri edited the summary of this revision. lebedev.ri added a comment. In D105728#2868281 , @erichkeane wrote: > This seems logical to me. The comment nee

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

erichkeane added a comment. This seems logical to me. The comment needs some love, so I made my best suggestion. Comment at: clang/lib/CodeGen/CGExpr.cpp:1855 +// If this is a simple volatile store to a null pointer (and said null +// pointre is not defined), then we

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 357644. quinnp added a comment. Parameterizing the ppc builtin arch sema error. This change is made assuming that the SemaFeatureCheck will be used by other builtins in the future. SemaFeatureCheck is commented to avoid an unused function error when building

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 357642. Ericson2314 added a comment. Rebased, fixed unintersting conflicts, organized docs better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/t

[clang] ccb1026 - [HIP] Move std headers after device malloc/free

Author: Aaron En Ye Shi Date: 2021-07-09T21:20:16Z New Revision: ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc URL: https://github.com/llvm/llvm-project/commit/ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc DIFF: https://github.com/llvm/llvm-project/commit/ccb10266f56bc34123eb7741c6ebcd5ba8ed3dcc.diff LO

[PATCH] D105707: [HIP] Move std headers after device malloc/free

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccb10266f56b: [HIP] Move std headers after device malloc/free (authored by ashi1). Herald added a project: clang. Herald added a subscriber: cfe-comm

[PATCH] D105737: Implement delimited escape sequences.

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a proposed C++ paper (P2290R1) that has not been accepted yet \x{} \u{} and \o{} are accepted in all languages mode in characters

[PATCH] D105734: [clang-tidy] performance-unnecessary-copy-initialization: Do not remove comments on new lines.

flx created this revision. flx added reviewers: ymandel, aaron.ballman, hokein. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. When deleting the copy assignment statement because copied

[PATCH] D95182: [clang][Fuchsia] Turn on Relative VTables for Fuchsia

leonardchan abandoned this revision. leonardchan added a comment. Abandoned since D102374 landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95182/new/ https://reviews.llvm.org/D95182 _

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang updated this revision to Diff 357626. NeHuang added a comment. Remove entry check in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105194/new/ https://reviews.llvm.org/D105194 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:3356 + case PPC::BI__builtin_ppc_maddld: +return SemaFeatureCheck(*this, TheCall, "power9-vector", +diag::err_ppc_builtin_only_on_pwr9); amyk wrote: > This

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang updated this revision to Diff 357625. NeHuang marked 3 inline comments as done. NeHuang added a comment. Address review comments on test case and remove change not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102875/new/ https://re

[PATCH] D99436: [OPENMP]Fix PR49366: crash on VLAs in task untied regions.

ABataev updated this revision to Diff 357616. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99436/new/ https://reviews.llvm.org/D99436 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/

[PATCH] D99350: [OPENMP]Fix PR49649: The introduction of $ref globals is not always valid.

ABataev updated this revision to Diff 357613. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99350/new/ https://reviews.llvm.org/D99350 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/declare_targe

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

lebedev.ri created this revision. lebedev.ri added reviewers: rjmccall, erichkeane, rsmith, thakis, jdoerfert. lebedev.ri added a project: LLVM. Herald added a subscriber: jfb. lebedev.ri requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We h

[PATCH] D105297: [OPENMP]Fix PR50347: Mapping of global scope deep object fails.

ABataev updated this revision to Diff 357612. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105297/new/ https://reviews.llvm.org/D105297 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/target_code

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

vitalybuka added a subscriber: kcc. vitalybuka added a comment. Why do we need this? I thought the plan to have instrumentation with better callbacks which will be small and close to efficiency to inlined instrumentation. In this case we will make it default and can avoid another frontend switc

[PATCH] D105727: [clang-tidy] performance-unnecessary-copy-initialization: Disable structured bindings.

flx created this revision. flx added reviewers: aaron.ballman, ymandel, gribozavr2. Herald added a subscriber: xazax.hun. flx requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Structured bindings can currently trigger the check an

[PATCH] D105151: [OPENMP]Fix PR50733: unexpected final value of list-item in linear clause in loop construct.

ABataev updated this revision to Diff 357608. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105151/new/ https://reviews.llvm.org/D105151 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/for_linear_codegen.

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

steveire added a comment. In D69764#2867109 , @MyDeveloperDay wrote: > In D69764#2863648 , @owenpan wrote: > >> Has this been tested against a large code base? It also needs an unqualified >> LGTM before it can be

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab8989ab8710: [OPENMP]Fix overlapped mapping for dereferenced pointer members. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES

[clang] ab8989a - [OPENMP]Fix overlapped mapping for dereferenced pointer members.

Author: Alexey Bataev Date: 2021-07-09T12:51:26-07:00 New Revision: ab8989ab8710c693e83edbccf221746c897c835f URL: https://github.com/llvm/llvm-project/commit/ab8989ab8710c693e83edbccf221746c897c835f DIFF: https://github.com/llvm/llvm-project/commit/ab8989ab8710c693e83edbccf221746c897c835f.diff

[PATCH] D105501: [PowerPC] Power ISA features for Semachecking

quinnp updated this revision to Diff 357604. quinnp added a comment. Feature is now working correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105501/new/ https://reviews.llvm.org/D105501 Files: clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

abhinavgaba accepted this revision. abhinavgaba added a comment. Thanks for the fix, Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105562/new/ https://reviews.llvm.org/D105562 ___ cfe-commits mai

[PATCH] D105726: Added fsanitize-address-instrument-via-callback, which controls if address sanitizer will always use a callback.

kstoimenov created this revision. kstoimenov added reviewers: kda, vitalybuka. Herald added a subscriber: dang. kstoimenov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Summary This option can be used to reduce the size of the binary. The

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. In D105637#2867602 , @NoQ wrote: > You could define your own diagnostic consumer in the unittest and intercept > all the notes. (you can find an example of this in D94476 ) (I can't believe I haven'

[PATCH] D105553: [analyzer][NFC] Split the main logic of NoStoreFuncVisitor to an abstract NoStateChangeVisitor class

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. This looks perfectly sensible to me. In the mailing list I seem to have made a mistake about how this works: we don't explicitly scan the AST for potential statements that could cause a state chang

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

estewart08 added inline comments. Comment at: clang/test/Headers/Inputs/include/cstdlib:29 float fabs(float __x) { return __builtin_fabs(__x); } +#endif JonChesterfield wrote: > jdoerfert wrote: > > That seems to be fundamentally broken then, but let's see, ma

[clang] 768e3af - PR51034: Debug Info: Remove 'prototyped' from K&R function declarations

Author: David Blaikie Date: 2021-07-09T12:07:36-07:00 New Revision: 768e3af6345a532d383205049679aaaccca26628 URL: https://github.com/llvm/llvm-project/commit/768e3af6345a532d383205049679aaaccca26628 DIFF: https://github.com/llvm/llvm-project/commit/768e3af6345a532d383205049679aaaccca26628.diff

[PATCH] D105681: [clangd] Add platform triple (host & target) to version info

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! only printing the target when they differ makes a lot of sense! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105681/new/ https

[clang] ff8b1b1 - Reapply [IR] Don't mark mustprogress as type attribute

Author: Nikita Popov Date: 2021-07-09T20:57:44+02:00 New Revision: ff8b1b1b9caef57046bda1ca36c95f0e03527c6e URL: https://github.com/llvm/llvm-project/commit/ff8b1b1b9caef57046bda1ca36c95f0e03527c6e DIFF: https://github.com/llvm/llvm-project/commit/ff8b1b1b9caef57046bda1ca36c95f0e03527c6e.diff

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92dcb1d2db8c: [Clang] Introduce Swift async calling convention. (authored by varungandhi-apple). Changed prior to commit: https://reviews.llvm.org

[clang] 92dcb1d - [Clang] Introduce Swift async calling convention.

Author: Varun Gandhi Date: 2021-07-09T11:50:10-07:00 New Revision: 92dcb1d2db8c4de48df0af806dca631523cd4169 URL: https://github.com/llvm/llvm-project/commit/92dcb1d2db8c4de48df0af806dca631523cd4169 DIFF: https://github.com/llvm/llvm-project/commit/92dcb1d2db8c4de48df0af806dca631523cd4169.diff

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added a comment. In D105564#2867717 , @probinson wrote: >> Currently when we have a member function that has an auto return type and >> the definition is out of line we generate two DWARF DIE. >> One for the declaration and a second one for the de

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

probinson added a comment. > Currently when we have a member function that has an auto return type and the > definition is out of line we generate two DWARF DIE. > One for the declaration and a second one for the definition, the definition > holds the deduced type but does not contain a DW_AT_na

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2867670 , @josemonsalve2 wrote: > In D102107#2867417 , @ABataev wrote: > >> In D102107#2867382 , @jdoerfert >> wrote: >> >>> In D1021

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik added a comment. @aprantl after your comments and discussion offline I changed my approach to do this lookup using the symbol table and it worked out. The main issue with the first approach was that gcc would also have to be updated in order for them to change their approach to generatin

[PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

shafik updated this revision to Diff 357578. shafik added reviewers: jingham, jasonmolenda. shafik added a comment. Changing approach based on Adrian's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105564/new/ https://reviews.llvm.org/D105564 Files: lldb/source/Plugins/Expr

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

josemonsalve2 added a comment. In D102107#2867417 , @ABataev wrote: > In D102107#2867382 , @jdoerfert > wrote: > >> In D102107#2832740 , @ABataev >> wrote: >> >>> In D10

[PATCH] D103465: [OpaquePtr] Track pointee types in Clang

jyknight added inline comments. Comment at: clang/lib/CodeGen/Address.h:26 llvm::Value *Pointer; + llvm::Type *PointeeType; CharUnits Alignment; erichkeane wrote: > I think this will still end up being a problem when we try to look into the > type for mul

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2867441 , @ASDenysPetrov wrote: > @vsavchenko > >> Why did you write it this way!? > > I want the map contains only valid constraints at any time, so we can easely > get them without traversing with all variants in

[PATCH] D105635: [PowerPC][AIX] Fix Zero-width bit fields wrt MaxFieldAlign.

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM but I have a strong preference that `clang/test/Layout/aix-packed-bitfields.c` be committed separately if my understanding is right. Comment at: clang/test/Layout/ai

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1241 + // Find the first constraint and exit the loop. + RSPtr = getConstraint(State, S); +} vsavchenko wrote: > Why do you get associated cons

[PATCH] D105695: [clang][tooling] Accept Clang invocations with "-fno-integrated-as"

dexonsmith added inline comments. Comment at: clang/lib/Tooling/Tooling.cpp:119-122 + if (isa(A)) { +ExternalAssembler = true; +break; + } Seems like this could (unexpectedly?) let through a command with multiple `-cc1`s (if I'm reading

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ added a comment. In D105637#2864684 , @balazske wrote: > Could not make a simple test for the change. This file F17831281: > BugReportInterestingnessTest.cpp is what > I could do, but it prints the needed text to

[PATCH] D105091: [RISCV] Pass -u to linker correctly.

MaskRay added inline comments. Comment at: clang/test/Driver/riscv-args.c:5 // RUN: %clang -### -target riscv32 \ // RUN: --gcc-toolchain= -Xlinker --defsym=FOO=10 -T a.lds %s 2>&1 \ // RUN: | FileCheck -check-prefix=CHECK-LD %s kito-cheng wrote: > MaskRay

[PATCH] D105421: [analyzer] Handle << operator for std::unique_ptr

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Great, thanks! Comment at: clang/test/Analysis/smart-ptr.cpp:472-474 + // We are testing the fact that in our modelling of + // operator<<(basic_ostream &, const unique_ptr &) +

[PATCH] D105191: [Clang][OpenMP] Add support for Static Device Libraries

grokos added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1689 + : "lib" + libname + "-" + archname + "-" + gpuname, + "a"); + "a" --> ".a" (add a dot) Comment at: clang/lib/Driver/ToolC

[PATCH] D105049: [NFC] Remove extra semicolons in clang/lib/APINotes/APINotesFormat.h

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Thanks for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105049/new/ https://reviews.llvm.org/D105049

[PATCH] D105708: [analyzer][NFC] Display the correct function name even in crash dumps

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Amazing, thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105708/new/ https://reviews.llvm.org/D105708 ___

[PATCH] D101037: [clang-tidy] Change shebang from python to python3

keith added a comment. Doesn't seem like anything changed on the mailing list side, should we land this now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101037/new/ https://reviews.llvm.org/D101037 __

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @vsavchenko > Why did you write it this way!? I want the map contains only valid constraints at any time, so we can easely get them without traversing with all variants intersecting with each other. I'm gonna move `updateExistingConstraints ` logic to `VisitSymbo

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

ABataev added a comment. In D102107#2867382 , @jdoerfert wrote: > In D102107#2832740 , @ABataev wrote: > >> In D102107#2832286 , @jdoerfert >> wrote: >> >>> In D102107#28

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

ldionne added a comment. In D104500#2865917 , @mizvekov wrote: > Well I thought that meant exactly that libc++ does not support C++98, it only > works on clang because it provides so much of C++11 as an extension. > > I did not remove this just on my own

[PATCH] D102107: [OpenMP] Codegen aggregate for outlined function captures

jdoerfert added a comment. In D102107#2832740 , @ABataev wrote: > In D102107#2832286 , @jdoerfert > wrote: > >> In D102107#2824581 , @ABataev >> wrote: >> >>> In D102107

[PATCH] D104975: Implement P1949

cor3ntin added a comment. In D104975#2842425 , @jfb wrote: > It would be more user-friendly to say which character is not allowed in the > diagnostic. Agreed, done! > Do we need to have a backward-compatible flag to preserve the old behavior, > or do

[PATCH] D105127: Implement P1401R5

cor3ntin updated this revision to Diff 357536. cor3ntin added a comment. Fix test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cla

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1388 +//===--===// +//New constraint handler +//===--

[PATCH] D105708: [analyzer][NFC] Display the correct function name even in crash dumps

steakhal created this revision. steakhal added reviewers: NoQ, vsavchenko, martong, Szelethus, ASDenysPetrov. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. steakhal requested review of this revision. He

[PATCH] D105562: [OPENMP]Fix overlapped mapping for dereferenced pointer members.

ABataev updated this revision to Diff 357532. ABataev added a comment. Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Rebase + added runtime test intended to be fixed by the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 97c675d - Revert "Revert "Temporarily do not drop volatile stores before unreachable""

Author: Nico Weber Date: 2021-07-09T11:44:34-04:00 New Revision: 97c675d3d43fe02a0ff0a8350d79344c845758af URL: https://github.com/llvm/llvm-project/commit/97c675d3d43fe02a0ff0a8350d79344c845758af DIFF: https://github.com/llvm/llvm-project/commit/97c675d3d43fe02a0ff0a8350d79344c845758af.diff LO

[PATCH] D105693: [analyzer][solver][NFC] Refactor how we detect (dis)equalities

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:687 /// A small helper structure representing symbolic equality. /// This is

[PATCH] D105692: [analyzer][solver][NFC] Introduce ConstraintAssignor

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. Generally it looks okay to me. However, I have a question: In `SimpleSValBuilder::evalBinOpNN` we do infer values to symbols. E.g. if we have an expression `y / x` and `y` is known to be `0`

[PATCH] D94098: [Clang][AArch64] Inline assembly support for the ACLE type 'data512_t'.

labrinea added a comment. In D94098#2865372 , @efriedma wrote: > I'm confused what your goal here is, exactly. The point of allowing 512-bit > inline asm operands is presumably to allow writing efficient code involving > inline asm... but you're intenti

[PATCH] D103986: [PowerPC] Floating Point Builtins for XL Compat.

quinnp updated this revision to Diff 357516. quinnp added a comment. Adressing some review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103986/new/ https://reviews.llvm.org/D103986 Files: clang/include/clang/Basic/BuiltinsPPC.def cl

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2867136 , @ASDenysPetrov wrote: > @vsavchenko > >> I still want to hear a good explanation why is it done this way. Here `c` >> is mapped to `(char)x`, and we have `[-10, 10]` directly associated with it, >> but

[PATCH] D105127: Implement P1401R5

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oops, I chanted the magic incantation but forgot to press the button. LGTM again. ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D105127: Implement P1401R5

aaron.ballman added a comment. This LGTM aside from a small nit, but you should wait a bit to land in case other reviewers have comments. Comment at: clang/test/CXX/stmt.stmt/stmt.select/stmt.if/p2.cpp:42-43 + +struct S { +} s; void f() { This looks like it

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2867104 , @ASDenysPetrov wrote: > Generally, with this patch we kinda have several constraints for each cast of > a single symbol. And we shall care for all of that constraints and timely > update them (if possibl

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. @vsavchenko > I still want to hear a good explanation why is it done this way. Here `c` is > mapped to `(char)x`, and we have `[-10, 10]` directly associated with it, but > we also have `(short)x` associated with `[8, 8]`. Why can't > `VisitSymbolCast` look up

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz added a comment. OK, I think we've got it now :-) I kept the original crash test in the change, but I'm not sure if it's appropriate anymore. Let me know if you think I should remove it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/

[PATCH] D105478: [clang] Make CXXRecrdDecl invalid if it contains any undeduced fields.

adamcz updated this revision to Diff 357511. adamcz added a comment. Fix a more generic case of invalid static initializer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105478/new/ https://reviews.llvm.org/D105478 Files: clang/lib/Parse/ParseDec

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. In D69764#2863648 , @owenpan wrote: > Has this been tested against a large code base? It also needs an unqualified > LGTM before it can be merged. D105701: [clang-format] test revision (NOT FOR COMMIT) to demonstrate east/

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. Generally, with this patch we kinda have several constraints for each cast of a single symbol. And we shall care for all of that constraints and timely update them (if possible). For instance, we have `int x` and met casts of this symbol in code: int x; (char)

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. In D103096#2867021 , @ASDenysPetrov wrote: > In D103096#2866730 , @vsavchenko > wrote: > >> In D103096#2866704 , >> @ASDenysPetrov wrote: >>

[PATCH] D105477: [AIX] Define __LONGDOUBLE64 macro

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. The change made me think we should add the negative test with -mlong-double-128, but then I thought we should probably make that an error until we've sorted through the AIX binar

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added a comment. In D103096#2866730 , @vsavchenko wrote: > In D103096#2866704 , @ASDenysPetrov > wrote: > >> @vsavchenko > > That's not the question I'm asking. Why do you need to set constraints

[PATCH] D105127: Implement P1401R5

cor3ntin marked 5 inline comments as done. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:1491 +def err_constexpr_if_condition_expression_is_not_constant : Error< + "constexpr if condition is not a constant expression convertible to

  1   2   >