[PATCH] D105003: [Analyzer] Improve report of "indeterminate file position" condition (alpha.unix.Stream).

2021-06-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske created this revision. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. balazske requested review of this revisio

[PATCH] D104925: [Analyzer] Improve report of file read at end-of-file condition.

2021-06-27 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 354791. balazske added a comment. Add checker name to commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104925/new/ https://reviews.llvm.org/D104925 Files: clang/lib/StaticAnalyzer/Checkers/Stre

[PATCH] D104616: [analyzer][WIP] Model comparision methods of std::unique_ptr

2021-06-27 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:351-352 + case OO_##Name: \ +BinOpIt = BinOps.find(Spelling); \ +UnOpIt

[PATCH] D104601: [Preprocessor] Implement -fnormalize-whitespace.

2021-06-27 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. In D104601#2842686 , @dblaikie wrote: > One other thing: This wouldn't be usable when using debug info, presumably, > because it'd refer to the wrong lines, etc. This is considered in the ccache patch

[PATCH] D102756: [clang-repl] Tell the LLJIT the exact target triple we use.

2021-06-27 Thread Vassil Vassilev via Phabricator via cfe-commits
v.g.vassilev closed this revision. v.g.vassilev added a comment. Landed in 49f9532165f0cc0485a7da84662ebf63d155652c Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102756/new/ https://reviews.ll

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

2021-06-27 Thread Brian Cain via Phabricator via cfe-commits
bcain added a comment. Should I clang format the headers? I prefer keeping the historical formatting intact. But if the submission should conform then I suppose I'll just accept the wrapped text suggested by clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D104991: [PowerPC] Add XL Compat fetch builtins

2021-06-27 Thread Jinsong Ji via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGeb237ffca821: [PowerPC] Add XL Compat fetch builtins (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104991/new/ https://reviews.llvm.org/

[clang] eb237ff - [PowerPC] Add XL Compat fetch builtins

2021-06-27 Thread Jinsong Ji via cfe-commits
Author: Jinsong Ji Date: 2021-06-28T02:52:32Z New Revision: eb237ffca821839374574b2195c865765ebf5d09 URL: https://github.com/llvm/llvm-project/commit/eb237ffca821839374574b2195c865765ebf5d09 DIFF: https://github.com/llvm/llvm-project/commit/eb237ffca821839374574b2195c865765ebf5d09.diff LOG: [P

[clang] 2ddca68 - Tag sanitize-coverage-old-pm.c unsupported on arm 32 bit

2021-06-27 Thread Muhammad Omair Javaid via cfe-commits
Author: Muhammad Omair Javaid Date: 2021-06-28T07:19:11+05:00 New Revision: 2ddca686ee8fd73d4b6630b60794be82caa4c311 URL: https://github.com/llvm/llvm-project/commit/2ddca686ee8fd73d4b6630b60794be82caa4c311 DIFF: https://github.com/llvm/llvm-project/commit/2ddca686ee8fd73d4b6630b60794be82caa4c3

[PATCH] D104991: [PowerPC] Add XL Compat fetch builtins

2021-06-27 Thread Kai Luo via Phabricator via cfe-commits
lkail accepted this revision. lkail added a comment. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104991/new/ https://reviews.llvm.org/D104991 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D104852: [AArch64][SVEIntrinsicOpts] Convect cntb/h/w/d to vscale intrinsic or constant.

2021-06-27 Thread JunMa via Phabricator via cfe-commits
junparser added a comment. @sdesmalen @david-arm @paulwalker-arm kindly ping~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104852/new/ https://reviews.llvm.org/D104852 ___ cfe-commits mailing list cfe-c

[clang] 3a6599b - Remove XFAIL flag from sanitize-coverage-old-pm.c

2021-06-27 Thread Muhammad Omair Javaid via cfe-commits
Author: Muhammad Omair Javaid Date: 2021-06-28T03:38:08+05:00 New Revision: 3a6599b7bd0fe4fe579e0abd9bd882ea964dd627 URL: https://github.com/llvm/llvm-project/commit/3a6599b7bd0fe4fe579e0abd9bd882ea964dd627 DIFF: https://github.com/llvm/llvm-project/commit/3a6599b7bd0fe4fe579e0abd9bd882ea964dd6

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

2021-06-27 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov added a comment. Thank you again @sberg. I have talked to the MSVC STL maintainers. They would be open to a pull request for fixing this. The repo can be found at https://github.com/microsoft/STL Be my guest if you want to submit that fix yourself. If not, I can probably do it in the ne

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

2021-06-27 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 354776. mizvekov added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/cl

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

2021-06-27 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov marked 2 inline comments as done. mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3544 -// taking an rvalue reference. -if (cast(FD)->getRefQualifier() != RQ_RValue) - break; If there was a `IsDiagnosticsC

[PATCH] D104500: [clang] Apply P1825 as Defect Report from C++11 up to C++20.

2021-06-27 Thread Matheus Izvekov via Phabricator via cfe-commits
mizvekov updated this revision to Diff 354773. mizvekov added a comment. This introduces two new test cases that cover the bug fixed by the previous diff: - The one suggested by rsmith in the comments above. - Another one that shows that when both const and non-const lvref conversion operators

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

2021-06-27 Thread Vincent LE GARREC via Phabricator via cfe-commits
bansan added a comment. Right, this is my first patch. I based this one on https://reviews.llvm.org/D28334 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://reviews.llvm.org/D104981 ___

[PATCH] D104952: [hexagon] Add {hvx,}hexagon_{protos,circ_brev...}

2021-06-27 Thread Brian Cain via Phabricator via cfe-commits
bcain updated this revision to Diff 354758. bcain added a comment. Add hexagon_types.h and additional test cases. Updated existing test case to use types defined in hexagon_types.h. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104952/new/ https:

[PATCH] D104991: [PowerPC] Add XL Compat fetch builtins

2021-06-27 Thread Jinsong Ji via Phabricator via cfe-commits
jsji created this revision. jsji added reviewers: PowerPC, w2yehia, lkail, shchenz, Whitney. Herald added subscribers: jfb, kbarton, nemanjai. jsji requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prototype unsigned int __fetch_and_add (vola

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

2021-06-27 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. @catskul can we now Abandon this revision seeing as D104096: [Clang-Format] Add ReferenceAlignment directive is landed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90238/new/ htt

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

2021-06-27 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe5a8f230c765: [clang-format] Fix the issue that empty lines being removed at the beginning of… (authored by darwin, committed by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] e5a8f23 - [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

2021-06-27 Thread via cfe-commits
Author: Darwin Xu Date: 2021-06-27T15:59:21+01:00 New Revision: e5a8f230c765aebff34221cb3e084316496fc08e URL: https://github.com/llvm/llvm-project/commit/e5a8f230c765aebff34221cb3e084316496fc08e DIFF: https://github.com/llvm/llvm-project/commit/e5a8f230c765aebff34221cb3e084316496fc08e.diff LOG

[PATCH] D104981: [clang-tidy] Add -line-filter to run-clang-tidy.py

2021-06-27 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added reviewers: njames93, kbobyrev. xgupta added a comment. Assuming this is your first patch, I add two reviewers for this patch who touch this file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104981/new/ https://reviews.llvm.org/D1049

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

2021-06-27 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1270 !startsExternCBlock(*PreviousLine)) Newlines = 1; Nit:I do think at some point we need to have some sort of option for controlling these empty lines,

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

2021-06-27 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104388/new/ https://reviews.llvm.org/D104388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

2021-06-27 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D104900#2842540 , @darwin wrote: > Sorry I haven't had a chance to look at this bug before it has closed. But I > do have a question: > > I observed that this code are formatted incorrectly by the same config: > > llv

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

2021-06-27 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:431 +bool DeclFilter::skipLocation(SourceLocation Location) { + // do not skip non-file locations + if (!Location.isValid()) sammccall wrote: > this comment didn't match the next

[PATCH] D98710: [clang-tidy] Add --skip-headers, part 1 (use setTraversalScope)

2021-06-27 Thread Chih-Hung Hsieh via Phabricator via cfe-commits
chh updated this revision to Diff 354737. chh marked 7 inline comments as done. chh added a comment. update some comments and sync again with the latest clang/llvm source CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98710/new/ https://reviews.llvm.org/D98710 Files: clang-tools-extra

[PATCH] D104790: [x86] fix mm*_undefined* intrinsics to use arbitrary frozen bit pattern

2021-06-27 Thread Juneyoung Lee via Phabricator via cfe-commits
aqjune added a comment. In D104790#2842523 , @nikic wrote: > Is this actually better in any meaningful way? InstCombine will turn `freeze > poison` into `zeroinitializer`, and until then this is just a completely > opaque value. I think to correctly em