[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas added a comment. The diff fixes all invalid assertion issues and also reasons about the cases where Min > Max. One thing which is stuck for me is the case where Min <= Max but it overflows. I could reason about that in this way: 1. If one of Min/Max overflows while the other doesn't then

[PATCH] D103440: [WIP][analyzer] Introduce range-based reasoning for addition operator

manas updated this revision to Diff 353168. manas added a comment. Reason about cases where Min > Max Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103440/new/ https://reviews.llvm.org/D103440 Files: clang/lib/StaticAnalyzer/Core/RangeConstraint

[PATCH] D104550: [analyzer] Implement getType for SVal

NoQ added a comment. Excellent! This utility is the first step on a lot of paths such as: - Asserting that all expressions' values are of the right type. I expect this to uncover a lot of ridiculous mutually cancelling bugs. - Modeling extents of RegionStore bindings - they're simply widths of t

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. In D103750#2827566 , @RedDocMD wrote: > Do you want the new failing test to be marked //expected to fail//? The line of thinking here is that tests are just something that gives us a signal when the behavior changes. They don't nece

[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards from C++11 up to C++20.

mizvekov updated this revision to Diff 353155. mizvekov added a comment. format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/c

[PATCH] D103855: [clang] Exclude function pointers on DefaultedComparisonAnalyzer

lhames added a comment. Disregard 80f30a6b855b : I messed up a copy-paste of a commit message. That was for https://reviews.llvm.org/D104480. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards from C++11 up to C++20.

mizvekov updated this revision to Diff 353151. mizvekov added a comment. Don't apply implicit moves to C++98, and add tests which demonstrate incompatibilities this would cause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://rev

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 353150. vlovich marked an inline comment as done. vlovich added a comment. Fix clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 Files: clang/docs/

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. I think you can go ahead & commit it for me. I don't know when I'll get commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102706/new/ https://reviews.llvm.org/D102706 ___ cfe-commits mailing list cfe-commi

[PATCH] D99810: [ifs] Prepare llvm-ifs for elfabi/ifs merging.

phosek accepted this revision. phosek added a comment. LGTM Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:70 + } + llvm_unreachable("unknown bitwidth"); +} This shouldn't be needed. Comment at: llvm/lib/InterfaceStub/IFSStub.cpp:82 + } +

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

thakis added a comment. FWIW https://lab.llvm.org/buildbot/#/builders/123 has been red for several days after this landed too (eg https://lab.llvm.org/buildbot/#/builders/123/builds/4545) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ h

[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards up to C++20.

mizvekov added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:58-60 A1 test1(A1 &&a) { - return a; // cxx11_17-error {{call to deleted constructor of 'test_implicitly_movable_rvalue_ref::A1'}} + return a; } mizvekov wr

[PATCH] D104500: [clang] Apply P1825 as Defect Report for all C++ standards up to C++20.

mizvekov updated this revision to Diff 353132. mizvekov added a comment. lint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/cla

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

dblaikie added a comment. In D104342#2828193 , @nickdesaulniers wrote: > In D104342#2827847 , @dblaikie > wrote: > >> Another thing you might want to check is linkonce_odr functions - I guess >> you'll get an a

[PATCH] D104500: DRAFT: [clang] Apply P1825 as DR for all modes below C++20.

mizvekov updated this revision to Diff 353127. mizvekov added a comment. rip out warn_return_std_move completely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Basic/Diagnos

[PATCH] D103615: [Clang] Add option for vector compare compatibility.

stefanp updated this revision to Diff 353126. stefanp added a comment. Moved if statement out of switch and added the Default=Mixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103615/new/ https://reviews.llvm.org/D103615 Files: clang/include/

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. In D88666#2828306 , @thakis wrote: > We also see check-all timeout recently (fairly consistently), see > https://bugs.chromium.org/p/chromium/issues/detail?id=1221702 > > Since Stella reported problems with this too, I sp

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

thakis added a comment. We also see check-all timeout recently (fairly consistently), see https://bugs.chromium.org/p/chromium/issues/detail?id=1221702 Since Stella reported problems with this too, I speculatively reverted it (and follow-ups) in fb32de9e97af0921242a021e30020ffacf7aa6e2

[clang] fb32de9 - Re-Revert "DirectoryWatcher: add an implementation for Windows"

Author: Nico Weber Date: 2021-06-18T18:51:41-04:00 New Revision: fb32de9e97af0921242a021e30020ffacf7aa6e2 URL: https://github.com/llvm/llvm-project/commit/fb32de9e97af0921242a021e30020ffacf7aa6e2 DIFF: https://github.com/llvm/llvm-project/commit/fb32de9e97af0921242a021e30020ffacf7aa6e2.diff LO

[PATCH] D104475: [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to noprofile

nickdesaulniers added a comment. rG817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d follow up based on reports of test failure on mac. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1044

[clang] 8172183 - Whitespace fixes for

Author: Nick Desaulniers Date: 2021-06-18T15:09:18-07:00 New Revision: 817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d URL: https://github.com/llvm/llvm-project/commit/817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d DIFF: https://github.com/llvm/llvm-project/commit/817218336aa3e3c0ca422ae00f8d8ca41b8fbd6d.di

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers updated this revision to Diff 353110. nickdesaulniers added a comment. - git add the Linker test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104342/new/ https://reviews.llvm.org/D104342 Files: clang/lib/CodeGen/CodeGenFunction

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers added a comment. In D104342#2827847 , @dblaikie wrote: > Another thing you might want to check is linkonce_odr functions - I guess > you'll get an arbitrary choice between two linkonce_odr functions under LTO > where they have different

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats added a comment. In D104494#2827708 , @gbalats wrote: > In D104494#2827639 , @vitalybuka > wrote: > >> https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this >> patch > > Looking in

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers updated this revision to Diff 353102. nickdesaulniers added a comment. - fix lint, add linker test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104342/new/ https://reviews.llvm.org/D104342 Files: clang/lib/CodeGen/CodeGenFunctio

[PATCH] D104475: [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to noprofile

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG193e41c98712: [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to… (authored by nickdesaulniers). Repository: rG LLVM Github

[clang] 193e41c - [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to noprofile

Author: Nick Desaulniers Date: 2021-06-18T13:42:32-07:00 New Revision: 193e41c987127aad86d0380df83e67a85266f1f1 URL: https://github.com/llvm/llvm-project/commit/193e41c987127aad86d0380df83e67a85266f1f1 DIFF: https://github.com/llvm/llvm-project/commit/193e41c987127aad86d0380df83e67a85266f1f1.di

[PATCH] D104561: [NFC][compiler-rt][hwasan] Move hwasanThreadList().CreateCurrentThread() into InitThreads

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7999e73caef: [NFC][compiler-rt][hwasan] Move hwasanThreadList().CreateCurrentThread() into… (authored by leonardchan). Repository: rG LLVM Github

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai added inline comments. Comment at: clang/lib/AST/DeclCXX.cpp:487 // Only calculate hash on first call of getODRHash per record. - ODRHash Hash; + class ODRHash Hash; Hash.AddCXXRecordDecl(getDefinition()); rsmith wrote: > I think this change is no

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

vsapsai updated this revision to Diff 353081. vsapsai marked an inline comment as done. vsapsai added a comment. Rebase on top of "main" and address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/

[PATCH] D104566: [UpdateCCTestChecks] Fix --replace-value-regex across RUN lines

jdenny created this revision. jdenny added reviewers: arichardson, ggeorgakoudis, jdoerfert, MaskRay, mtrofin, greened. jdenny requested review of this revision. Herald added a subscriber: sstefan1. Herald added projects: clang, LLVM. Without this patch, llvm/utils/update_cc_test_checks.py fails

[PATCH] D104475: [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to noprofile

phosek accepted this revision. phosek added a comment. LGTM I'm happy to see that the `noprofile` LLVM attribute is useful in other contexts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104475/new/ https://reviews.llvm.org/D104475 _

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

vitalybuka added inline comments. Comment at: clang/docs/AddressSanitizer.rst:143 + +AddressSanitizer (``-fsanitize=address``) can optionally detect stack use after +return problems. Maybe -fsanitize=address is reduntant here, we are already in the -fsanitize=ad

[PATCH] D103958: [WIP] Support MustControl conditional control attribute

nickdesaulniers added a comment. FWIW, LWN recently published summary of some of the recent discussions on LKML: https://lwn.net/SubscriberLink/860037/aca06acfafce7937/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103958/new/ https://reviews.llv

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

vitalybuka accepted this revision. vitalybuka added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/AddressSanitizer.rst:17-19 +* Use-after-return (clang flag ``-fsanitize-address-use-after-return=(never|runtime|always)`` default: ``runt

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9585-9587 +assert(getContext().hasSameType(FirstField->getType(), +SecondField->getType())); + rsmith wrote: > bruno wrote: > > rsmith wrote: >

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdd5da9dec61: [clang-tidy] performance-unnecessary-copy-initialization: Directly examine the… (authored by flx). Changed prior to commit: https:/

[clang-tools-extra] bdd5da9 - [clang-tidy] performance-unnecessary-copy-initialization: Directly examine the initializing var's initializer.

Author: Felix Berger Date: 2021-06-18T15:25:17-04:00 New Revision: bdd5da9dec61072f693726d9ed2a94c78e431ba2 URL: https://github.com/llvm/llvm-project/commit/bdd5da9dec61072f693726d9ed2a94c78e431ba2 DIFF: https://github.com/llvm/llvm-project/commit/bdd5da9dec61072f693726d9ed2a94c78e431ba2.diff

[PATCH] D104475: [Clang][Codegen] Add GNU function attribute 'no_profile' and lower it to noprofile

nickdesaulniers updated this revision to Diff 353074. nickdesaulniers added a comment. - rename test, add __has_attribute unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104475/new/ https://reviews.llvm.org/D104475 Files: clang/include/c

[PATCH] D100118: [clang] Add support for new builtin __arithmetic_fence to control floating point optimization, and new clang option fprotect-parens

mibintc added a comment. Reply to @joerg proposing new wording for the option description Comment at: clang/docs/UsersManual.rst:1484 + Where unsafe floating point optimizations are enabled, this option + determines whether the optimizer honors parentheses when floating-poi

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

MaskRay added inline comments. Comment at: clang/test/CodeGen/fprofile.c:1 +// RUN: %clang_cc1 -fprofile-instrument=llvm -disable-llvm-passes \ +// RUN: -emit-llvm -o - %s | FileCheck %s no_profile may be a better test name. Repository: rG LLVM Github Monor

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

MaskRay accepted this revision. MaskRay added a subscriber: marxin. MaskRay added a comment. LG. @marxin FYI the GNU-style function attribute `no_profile` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104475/new/ https://reviews.llvm.org/D104475

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

MaskRay added a comment. In D104475#2825841 , @nickdesaulniers wrote: > In D104475#2825795 , @MaskRay wrote: > >> In D104475#2825772 , >> @nickdesaulniers wrote: >> >>>

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds OK to me. Another thing you might want to check is linkonce_odr functions - I guess you'll get an arbitrary choice between two linkonce_odr functions under LTO where they have diff

[PATCH] D103434: [analyzer] Allow visitors to run callbacks on completion

RedDocMD abandoned this revision. RedDocMD added a comment. I am closing this since it has been addressed much better by the patches from @vsavchenko. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103434/new/ https://reviews.llvm.org/D103434

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD updated this revision to Diff 353068. RedDocMD added a comment. Some more refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104300/new/ https://reviews.llvm.org/D104300 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

RedDocMD marked 5 inline comments as done. RedDocMD added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:435 + void markNotInteresting(SymbolRef sym); + xazax.hun wrote: > Bikeshedding: I wonder if we prefer `Un

[PATCH] D104491: [Docs][Clang][Attr] mark no_stack_protector+no_sanitize GCC compatible

aaron.ballman added a comment. In D104491#2827730 , @nickdesaulniers wrote: > ah, ok, then if this isn't a quick cleanup, I don't really care about this. I took a quick look at ClangAttrEmitter.cpp, and it looks like the only change that is needed is w

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/Attr.td:1975 + let Spellings = [Clang<"no_profile">]; + let Subjects = SubjectList<[Function]>; + let Documentati

[PATCH] D104500: DRAFT: [clang] Apply P1825 as DR for all modes below C++20.

mizvekov added a comment. In D104500#2827629 , @lebedev.ri wrote: > Patch is missing description Yes sorry for the noise, I do that sometimes just to let the bots test my patch before it is fully ready for review. If you have any tips for me so I can u

[PATCH] D104561: [NFC][compiler-rt][hwasan] Move hwasanThreadList().CreateCurrentThread() into InitThreads

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, vitalybuka, eugenis. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. Once D104553

[PATCH] D103021: [clang-tidy] performance-unnecessary-copy-initialization: Search whole function body for variable initializations.

flx updated this revision to Diff 353064. flx marked 2 inline comments as done. flx added a comment. Renamed initializer matcher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103021/new/ https://reviews.llvm.org/D103021 Files: clang-tools-extra

[PATCH] D104491: [Docs][Clang][Attr] mark no_stack_protector+no_sanitize GCC compatible

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. ah, ok, then if this isn't a quick cleanup, I don't really care about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104491/new/ https://reviews.llvm.org/D104491 __

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1975 + let Spellings = [Clang<"no_profile">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [NoProfileDocs]; aaron.ballman wrote: > Should this also be suppo

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

nickdesaulniers updated this revision to Diff 353061. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - add hyphen to docs, add boilerplate test to check Subjects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1044

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats added a comment. In D104494#2827639 , @vitalybuka wrote: > https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this > patch Looking into this. I missed (due to the "\\" in the expression) updating this: https://github.com/ll

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

vitalybuka added a comment. https://lab.llvm.org/buildbot/#/builders/37/builds/4620 looks broken by this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104494/new/ https://reviews.llvm.org/D104494

[PATCH] D104500: DRAFT: [clang] Apply P1825 as DR for all modes below C++20.

lebedev.ri added a comment. Patch is missing description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D101775: Fix for Bug 50033 - -fno-temp-file is not respected when creating a pch in clang 12

dexonsmith closed this revision. dexonsmith added a comment. I pushed this as 05d0f1a8ea012a6b7b8ea65893ec4121106444b5  last night, but I just realized I forgot to include the link to the review :(. Closing manually. Reposit

[PATCH] D104553: [compiler-rt][hwasan] Add InitState options to thread initialization

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr, vitalybuka, eugenis. leonardchan added a project: Sanitizers. Herald added a subscriber: dberris. leonardchan requested review of this revision. Herald added a subscriber: Sanitizers. Similar to `InitOptions` in asan

[PATCH] D104500: DRAFT: [clang] Apply P1825 as DR for all modes below C++20.

Quuxplusone added inline comments. Comment at: clang/test/CXX/class/class.init/class.copy.elision/p3.cpp:58-60 A1 test1(A1 &&a) { - return a; // cxx11_17-error {{call to deleted constructor of 'test_implicitly_movable_rvalue_ref::A1'}} + return a; } Personal

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

xazax.hun added a comment. In D103750#2827566 , @RedDocMD wrote: > Do you want the new failing test to be marked //expected to fail//? I usually just add the wrong expectation to make the test pass and add a TODO comment that explains why is this wrong

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. In D103750#2825823 , @xazax.hun wrote: > I believe there are a couple of comments that are done but not marked > accordingly. > I agree with Artem, if we could craft code that fails due to not calling > ctors, we should probab

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD updated this revision to Diff 353048. RedDocMD added a comment. Little changes, a failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103750/new/ https://reviews.llvm.org/D103750 Files: clang/include/clang/StaticAnalyzer/Core/Pat

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD added a comment. In D103750#2825342 , @NoQ wrote: > In D103750#2823741 , @RedDocMD > wrote: > >> I would suppose that constructor calls are properly handled. (ie, member >> constructors are called prope

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG88d93923e665: [compiler-rt][hwasan] Move Thread::Init into hwasan_linux.cpp (authored by leonardchan). Repository: rG L

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

RedDocMD marked an inline comment as done. RedDocMD added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:3 +// RUN: -analyzer-checker=core,cplusplus.Move,alpha.cplusplus.SmartPtr\ +// RUN: -analyzer-config cplusplus.SmartPtrModeling:ModelSmartPtrDer

[PATCH] D104392: [HIP] Add support functions for C++ polymorphic types

scchan updated this revision to Diff 353041. scchan added a comment. Minor clean up in the hip-header.hip test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104392/new/ https://reviews.llvm.org/D104392 Files: clang/lib/Headers/__clang_hip_runtim

[PATCH] D104124: [IR] Simplify createReplacementInstr

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104124/new/ https://reviews.llvm.org/D104124 __

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

klausler added a comment. In D103612#2827458 , @awarzynski wrote: > In D103612#2827444 , @klausler > wrote: > >>> The default behaviour is to always decorate unparsed typed expression with >>> e.g. their KIND.

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

awarzynski added a comment. In D103612#2827444 , @klausler wrote: >> The default behaviour is to always decorate unparsed typed expression with >> e.g. their KIND. The new flag can be used to turn this off, so that the >> generated output uses valid For

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko added a comment. Hey folks! I was thinking that this method can be quite handy. I think it would be great to have another pair of eyes (but more would be better) to look into this and: - Suggest other test cases to add - See if I missed any "typed" values from the hierarchy - See if

[PATCH] D104392: [HIP] Add support functions for C++ polymorphic types

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! pls remove the extra line when committing. Comment at: clang/test/Headers/hip-header.hip:88 } + extrac line Repository: rG LLVM Github Mon

[PATCH] D103612: [flang][driver] Add `-funparse-typed-exprs-as-fortran`

klausler added a comment. > The default behaviour is to always decorate unparsed typed expression with > e.g. their KIND. The new flag can be used to turn this off, so that the > generated output uses valid Fortran syntax and can be fed to another Fortran > compiler. The output of Expr::AsFort

[PATCH] D104550: [analyzer] Implement getType for SVal

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun, martong, steakhal, Szelethus, ASDenysPetrov, manas, RedDocMD. Herald added subscribers: dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, mgorny. vsavchenko requested review of this r

[PATCH] D104392: [HIP] Add support functions for C++ polymorphic types

scchan updated this revision to Diff 353035. scchan added a comment. Adding test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104392/new/ https://reviews.llvm.org/D104392 Files: clang/lib/Headers/__clang_hip_runtime_wrapper.h clang/test/Heade

[PATCH] D103612: [flang][driver] Add `-fno-unparse-typed-exprs`

awarzynski updated this revision to Diff 353032. awarzynski added a comment. Refine the semantics after some discussion offline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103612/new/ https://reviews.llvm.org/D103612 Files: clang/include/clang

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. I wasn't able to reproduce this locally by running *just* the DirectoryWatcher tests. I'm not running all of the clang tests repeatedly to see if I can get a repro that way. The online tests appear to always hang either in the InitialScanAsync or InvalidatedWa

[PATCH] D103426: Clang: Extend format string checking to wprintf/wscanf

MarcusJohnson91 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103426/new/ https://reviews.llvm.org/D103426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918 + // from the index, we reduce the noise in all the other completion scopes. + if (llvm::isa(&ND)) +return false; Seems like we should also ignore ObjCCategoryImplDec

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

kadircet created this revision. kadircet added a reviewer: dgoldman. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. They are already provided by Sem

[PATCH] D104500: DRAFT: [clang] Apply P1825 as DR for all modes below C++20.

mizvekov updated this revision to Diff 353009. mizvekov added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaStmt.cpp cl

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGced6b204d18e: [clang] Implement P2266 Simpler implicit move (authored by mizvekov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] ced6b20 - [clang] Implement P2266 Simpler implicit move

Author: Matheus Izvekov Date: 2021-06-18T17:08:59+02:00 New Revision: ced6b204d18e6eed611f8ebf27122ec19147ea7a URL: https://github.com/llvm/llvm-project/commit/ced6b204d18e6eed611f8ebf27122ec19147ea7a DIFF: https://github.com/llvm/llvm-project/commit/ced6b204d18e6eed611f8ebf27122ec19147ea7a.dif

[PATCH] D104539: [Sema][SVE] Properly match builtin ID when using aux target

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104539/new/ https://reviews.llvm.org/D104539

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

jansvoboda11 added a comment. In D103930#2825181 , @dexonsmith wrote: > In D103930#2820725 , @bruno wrote: > >> Thanks for working on this, comments inline. @vsapsai @jansvoboda11 >> @dexonsmith any headermap re

[PATCH] D104465: [clang][deps] Prevent PCH validation failures by padding minimized files

jansvoboda11 added a comment. Thanks for sharing your ideas! I've left my initial thoughts below, but I want to revisit this and think about it some more. In D104465#2825343 , @dexonsmith wrote: > I'm not sure this is the right approach. > > - Don't PC

[PATCH] D104539: [Sema][SVE] Properly match builtin ID when using aux target

bsmith created this revision. bsmith added reviewers: paulwalker-arm, peterwaller-arm, joechrisellis, sdesmalen. Herald added subscribers: psnobl, tschuett. Herald added a reviewer: efriedma. Herald added a reviewer: aaron.ballman. bsmith requested review of this revision. Herald added a reviewer:

[PATCH] D104536: WIP: [clang][deps] Avoid minimizing PCH input files

jansvoboda11 created this revision. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch avoid minimizing input files that contributed to a PCH or its modules. This prevents the implicit modular build to fail on unexpect

[PATCH] D103849: Fix undeduced type when instanciating template member

serge-sans-paille added a comment. @rsmith : any opinion on that one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103849/new/ https://reviews.llvm.org/D103849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl()

vsavchenko added a comment. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103025/new/ https://reviews.llvm.org/D103025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl()

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc2ef1955609: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl() (authored by tomasz-kaminski-sonarsource, committed by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] cc2ef19 - [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl()

Author: Tomasz Kamiński Date: 2021-06-18T16:32:19+03:00 New Revision: cc2ef195560999d0690a8d8805ea811270e38f26 URL: https://github.com/llvm/llvm-project/commit/cc2ef195560999d0690a8d8805ea811270e38f26 DIFF: https://github.com/llvm/llvm-project/commit/cc2ef195560999d0690a8d8805ea811270e38f26.dif

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

chrish_ericsson_atx added inline comments. Comment at: clang/include/clang/AST/Expr.h:4961 + /// - `nullptr` for invalid index (`i < 0` or `i >= array_size`). + const Expr *getExprForConstArrayByRawIndex(int64_t Idx) const; + I think in most (all?) other method

[PATCH] D103025: [analyzer] Handle NTTP invocation in CallContext.getCalleeDecl()

tomasz-kaminski-sonarsource added a comment. For the author information use: Tomasz Kamiński tomasz.kamin...@sonarsource.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103025/new/ https://reviews.llvm.org/D103025 ___

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 352985. mizvekov added a comment. fix ctidy warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D104442: [libclang] Fix error handler in translateSourceLocation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd569a11b585: [libclang] Fix error handler in translateSourceLocation. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104442/new/

[clang] fd569a1 - [libclang] Fix error handler in translateSourceLocation.

Author: Simon Tatham Date: 2021-06-18T13:43:14+01:00 New Revision: fd569a11b585d13cdceac2d890c2beda0fa5f0eb URL: https://github.com/llvm/llvm-project/commit/fd569a11b585d13cdceac2d890c2beda0fa5f0eb DIFF: https://github.com/llvm/llvm-project/commit/fd569a11b585d13cdceac2d890c2beda0fa5f0eb.diff

[PATCH] D97204: [RFC] Clang 64-bit source locations

simon_tatham added a comment. Thanks to @miyuki for repeating the previous benchmark with this version of the patch (and on the same machine as before, which was better than I could have done). The revised results now have the memory usage increase (compared to 32-bit SourceLocation) in the re

[PATCH] D103702: [AArch64][SVE] Wire up vscale_range attribute to SVE min/max vector queries

paulwalker-arm accepted this revision. paulwalker-arm added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64Subtarget.cpp:350-352 unsigned AArch64Subtarget::getMaxSVEVectorSizeInBits() const { assert(HasSVE && "Tried to get SVE vector length without SVE support!")

  1   2   >