[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I think this patch is good to go as long as other folks are happy. I'm glad that uninterestingness is becoming a thing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added inline comments. Comment at: clang/lib/CodeGen/CGCoroutine.cpp:437-475 +void emitDynamicAlignedDealloc(CodeGenFunction &CGF, + llvm::BasicBlock *AlignedFreeBB, + llvm::CallInst *CoroFree) { + llvm::CallInst

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 352908. ychen marked 2 inline comments as done. ychen added a comment. - Not use `void *` in EmitBuiltinAlignTo signature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915

[clang] 6aaf4fa - Bring our handling of -Wframe-larger-than more in line with GCC.

Author: Richard Smith Date: 2021-06-17T20:29:13-07:00 New Revision: 6aaf4fa2885600b0e31042071ad06f78218ab0f2 URL: https://github.com/llvm/llvm-project/commit/6aaf4fa2885600b0e31042071ad06f78218ab0f2 DIFF: https://github.com/llvm/llvm-project/commit/6aaf4fa2885600b0e31042071ad06f78218ab0f2.diff

[PATCH] D104505: [HIP] Defer operator overloading errors

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall, rsmith. yaxunl requested review of this revision. nvcc does not diagnose overloading resolution diagnostics if it happens in functions not emitted, e.g., if a device function calls a host function, it is not diagnosed in host com

[PATCH] D104350: [clang][AST] Make `getLocalOrImportedSubmoduleID` work with const `Module*`. NFC.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104350/new/ https://reviews.llvm.org/D104350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352898. andrewjcg added a comment. capitalize param Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/Inp

[PATCH] D104500: DRAFT: [clang] Apply P1825 as DR for all modes below C++20.

mizvekov updated this revision to Diff 352894. mizvekov added a comment. set parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104500/new/ https://reviews.llvm.org/D104500 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema

[PATCH] D104500: DRAFT: [clang] Apply P1825 as DR for all modes below C++20.

mizvekov created this revision. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Matheus Izvekov Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D104500 Files: clang/include/clang/Sema/Sema.h c

[clang] 05d0f1a - Frontend: Respect -fno-temp-file when creating a PCH

Author: Zachary Henkel Date: 2021-06-17T18:34:10-07:00 New Revision: 05d0f1a8ea012a6b7b8ea65893ec4121106444b5 URL: https://github.com/llvm/llvm-project/commit/05d0f1a8ea012a6b7b8ea65893ec4121106444b5 DIFF: https://github.com/llvm/llvm-project/commit/05d0f1a8ea012a6b7b8ea65893ec4121106444b5.diff

[PATCH] D104299: Handle interactions between reserved identifier and user-defined suffixes

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks good. Just some minor comments. Comment at: clang/include/clang/Sema/Sema.h:4132 + bool checkLiteralOperatorId(const CXXScopeSpec &SS, const UnqualifiedId &Id,

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

gbalats marked an inline comment as done. gbalats added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1134 + Asm.replace(Pos, 1, Suffix + "@"); +} GV->getParent()->setModuleInlineAsm(Asm); stephan.yichao.zhao

[PATCH] D104350: [clang][AST] Make `getLocalOrImportedSubmoduleID` work with const `Module*`. NFC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG722c51473c7a: [clang][AST] Make `getLocalOrImportedSubmoduleID` work with const `Module*`. (authored by vsapsai). Repository: rG LLVM Github Mono

[clang] 722c514 - [clang][AST] Make `getLocalOrImportedSubmoduleID` work with const `Module*`. NFC.

Author: Volodymyr Sapsai Date: 2021-06-17T17:29:12-07:00 New Revision: 722c51473c7a3bfe13d929734615a3b46d44c09a URL: https://github.com/llvm/llvm-project/commit/722c51473c7a3bfe13d929734615a3b46d44c09a DIFF: https://github.com/llvm/llvm-project/commit/722c51473c7a3bfe13d929734615a3b46d44c09a.di

[PATCH] D104387: [clang-cl] Implement /external:I, /external:env, and EXTERNAL_INCLUDE support (PR36003)

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. That's a good argument. lgtm. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:1273 + +if (include_var) { + StringRef(*include_var) Why not keep the

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

stephan.yichao.zhao added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:1134 + Asm.replace(Pos, 1, Suffix + "@"); +} GV->getParent()->setModuleInlineAsm(Asm); Based on http://web.mit.edu/rhel-doc/3/rhel-as-en

[PATCH] D104494: [dfsan] Replace dfs$ prefix with .dfsan suffix

kcc added a comment. Yey, great idea! :) (I am not reviewing the code; but the change looks straightforward) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104494/new/ https://reviews.llvm.org/D104494 __

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

xazax.hun added a comment. We probably did not update this PR with the discussions we had offline. Basically we had a bug with a sink node due to calling into a destructor of `unique_ptr`. The catch is that the ctor was evalcalled, so the store did not have the correct bindings. Thus, after inl

[PATCH] D104300: [analyzer] Handle std::swap for std::unique_ptr

xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:435 + void markNotInteresting(SymbolRef sym); + Bikeshedding: I wonder if we prefer `Uninteresting` to `NotInteresting`. Or alternatively, if we wa

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

nickdesaulniers added a comment. In D104475#2825795 , @MaskRay wrote: > In D104475#2825772 , > @nickdesaulniers wrote: > >> In D104475#2825711 , @MaskRay >> wrote: >> >>

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

xazax.hun added a comment. I believe there are a couple of comments that are done but not marked accordingly. I agree with Artem, if we could craft code that fails due to not calling ctors, we should probably include them in the tests, even if they don't reflect the desired behavior they are a

[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

ahatanak added a comment. I think these places have to be fixed too: https://github.com/llvm/llvm-project/blob/bf9f21a28be171dc500cc68b4cb1fcd3fc33f229/clang/lib/CodeGen/CGBuiltin.cpp#L1705 https://github.com/llvm/llvm-project/blob/bf9f21a28be171dc500cc68b4cb1fcd3fc33f229/clang/lib/CodeGen/CGNonTr

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

amccarth added a comment. In D88666#2825557 , @stella.stamenova wrote: > One thing we've run into in the past is that running some of these tests **on > a drive other than the OS drive** can cause weird failure. I am not sure if > that may be the case h

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

MaskRay added a comment. In D104475#2825772 , @nickdesaulniers wrote: > In D104475#2825711 , @MaskRay wrote: > >> So if we don't want to offer guarantee for IR/C/C++ attributes, we can >> document that users may

[PATCH] D104465: [clang][deps] Prevent PCH validation failures by padding minimized files

dexonsmith added a comment. In D104465#2825343 , @dexonsmith wrote: > A few other ideas: > > 1. Disable PCH validation when minimizing. (Is that less robust than your > current workaround? If so, can you explain why?) > 2. Use the original PCH header in

[PATCH] D104381: [analyzer] Added a test case for PR46264

ASDenysPetrov added a comment. @NoQ: > I guess there might be some value in building an older Clang from around when > the bug was reported so that to see if the crash was indeed there and we're > not just reproducing it wrong. It would also allow us to understand where we > fixed it through b

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

melver added a comment. In D104475#2825772 , @nickdesaulniers wrote: > In D104475#2825711 , @MaskRay wrote: > >> So if we don't want to offer guarantee for IR/C/C++ attributes, we can >> document that users may

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

nickdesaulniers added a comment. In D104475#2825711 , @MaskRay wrote: > So if we don't want to offer guarantee for IR/C/C++ attributes, we can > document that users may need to additionally specify > `__attribute__((noinline))` to suppress inlining. I

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

melver added a comment. In D104475#2825711 , @MaskRay wrote: > In D104475#2825666 , @melver wrote: > >> In D104475#2825297 , @MaskRay >> wrote: >> >>> Should `no_profile`

[PATCH] D99810: [ifs] Prepare llvm-ifs for elfabi/ifs merging.

haowei marked an inline comment as done. haowei added inline comments. Comment at: llvm/include/llvm/InterfaceStub/ELFObjHandler.h:25 namespace elfabi { phosek wrote: > Shouldn't this be in namespace `ifs`? This was renamed to ifs in D100139. Rename it here

[PATCH] D104491: [Docs][Clang][Attr] mark no_stack_protector+no_sanitize GCC compatible

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, melver. Herald added a reviewer: aaron.ballman. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GCC has supported the function attributes __attrib

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 352851. ASDenysPetrov added a comment. Updated. Removed `F` as flag. Replaced `goto` with closure. Detailed comments and fixed typos. @vsavchenko made changes according your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

MaskRay added a comment. In D104475#2825666 , @melver wrote: > In D104475#2825297 , @MaskRay wrote: > >> Should `no_profile` specify the inlining behavior? Though `no_sanitize_*` >> don't specify that, either. >

[PATCH] D104155: Add documentation for -fsanitize-address-use-after-return.

kda updated this revision to Diff 352849. kda marked an inline comment as done. kda added a comment. Herald added a subscriber: dang. - Responding to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104155/new/ https://reviews.llvm.org/D1041

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

bruno added a comment. @dexonsmith and @jansvoboda11 thanks for the fast reply and the extra testing. Comment at: clang/lib/Lex/HeaderSearch.cpp:421 + auto FixupSearchPathAndFindUsableModule = + [&](auto file) -> Optional { if (SearchPath) { Can you

[PATCH] D104248: [compiler-rt][hwasan] Refactor Thread::Init

leonardchan added a comment. Will submit around end of day if there's no more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104248/new/ https://reviews.llvm.org/D104248 ___ cfe-commits mailing

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

nickdesaulniers updated this revision to Diff 352844. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - fix td files and test CHECKs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104475/new/ https://reviews.llvm.o

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

melver added a comment. In D104475#2825297 , @MaskRay wrote: > Should `no_profile` specify the inlining behavior? Though `no_sanitize_*` > don't specify that, either. I think it's somehow implicit, but I can't quite say how. There are some tests that c

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

dexonsmith added a comment. Another thing to consider: a client that wants the minimized source to be "no bigger than" the original source can use the original source if it ends up growing. For example, https://reviews.llvm.org/D104462 could check the resulting size, and just return the origina

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers updated this revision to Diff 352841. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - verifier checks, inliner test, use base 10 radix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104342/new/ ht

[PATCH] D104351: [HeaderSearch] Use `isImport` only for imported headers and not for `#pragma once`.

vsapsai added a comment. In D104351#2824505 , @jansvoboda11 wrote: > This seems reasonable on first look. Can you add a test that demonstrates the > problem this patch solves? There is no externally observable change that can be tested, I'm only making

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

dblaikie added a comment. In D104342#2825357 , @nickdesaulniers wrote: > In D104342#2820811 , @dblaikie > wrote: > >> what're the rules about module level attributes like this? For instance: >> Does this affect

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Nice trick! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D9352

[PATCH] D104462: [clang][lex] Add minimizer option to pad the output to the input size

arphaman added a comment. I agree with Duncan, it would be good to avoid modifying the existing test cases if possible Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104462/new/ https://reviews.llvm.org/D104462

[PATCH] D104424: [Sema] Fix for PR50741

abhinavgaba added a comment. Thanks for fixing this, @chrish_ericsson_atx! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104424/new/ https://reviews.llvm.org/D104424 ___ cfe-commits mailing list cfe-comm

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

dexonsmith added inline comments. Comment at: clang/lib/AST/Decl.cpp:4585 + + ASTContext &Ctx=getASTContext(); + if (Ctx.getLangOpts().DumpRecordLayoutsComplete) { Nit: please add whitespace around `=`. (Have you run git-clang-format? That should fix this.)

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. This is the best I can do from the online builds. I'll try and repro locally as well: FAIL: Clang-Unit :: DirectoryWatcher/./DirectoryWatcherTests.exe/DirectoryWatcherTest.InitialScanAsync (75980 of 75980) TEST 'Clang-Unit :: Director

[PATCH] D104484: [clang] Add cc1 option for dumping layout for all complete types

daltenty created this revision. Herald added subscribers: dexonsmith, dang. daltenty requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds an option which, in addition to dumping the record layout as is done by -fdump-record-layo

[PATCH] D103855: [clang] Exclude function pointers on DefaultedComparisonAnalyzer

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, let's go with this for now. Discussion in WG21 seems to be heading towards removing the builtin candidates for `operator<=>`, `operator<`, `operator<=`, `operator>`, and `operator>=` f

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

samitolvanen updated this revision to Diff 352825. samitolvanen added a comment. Moved the test to llvm/test/Transforms/ThinLTOBitcodeWriter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104058/new/ https://reviews.llvm.org/D104058 Files: llvm/

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

dexonsmith added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:27 +#define FOO +// This include will fail if modules weren't used. The include name itself +// doesn't exist and relies on the header map to remap it to the real header. ---

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers added inline comments. Comment at: llvm/lib/CodeGen/PrologEpilogInserter.cpp:282 +.getValueAsString() +.getAsInteger(0, Threshold); if (StackSize > Threshold) { nickdesaulniers wrote: > dblaikie wrote: > > I guess the 0 value he

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352824. andrewjcg added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Modules/Inputs/i

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:27 +#define FOO +// This include will fail if modules weren't used. The include name itself +// doesn't exist and relies on the header map to remap it to the real header.

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg added inline comments. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:27 +#define FOO +// This include will fail if modules weren't used. The include name itself +// doesn't exist and relies on the header map to remap it to the real header.

[PATCH] D104350: [clang][AST] Make `getLocalOrImportedSubmoduleID` work with const `Module*`. NFC.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104350/new/ https://reviews.llvm.org/D104350 __

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 352821. mizvekov added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp clang/lib/Sema

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 352818. mizvekov added a comment. - Change block capture NRVO semantics to match P2266 in C++2b mode. - Update cxx_status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/n

[PATCH] D104462: [clang][lex] Add minimizer option to pad the output to the input size

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. I'm not sure D104465 (the motivation for this patch) is the right approach, but we can have that discussion over there.

[PATCH] D104342: [IR] convert warn-stack-size from module attr to fn attr

nickdesaulniers added a comment. In D104342#2820811 , @dblaikie wrote: > what're the rules about module level attributes like this? For instance: Does > this affect/hinder inlining (if the attributes don't match between the caller > and callee)? Other s

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-compare-64bit-only.c:8 +// RUN: not %clang_cc1 -triple powerpc-unknown-aix \ +// RUN: -emit-llvm %s -o - -target-cpu pwr9 2>&1 | FileCheck %s -check-prefix=CHECK-32 + `-check-prefi

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-compare-64bit-only.c:6 +// RUN: %clang_cc1 -triple powerpc64-unknown-aix \ +// RUN: -emit-llvm %s -o - -target-cpu pwr9 | FileCheck %s --check-prefix=CHECK-64 +// RUN: not %clang_cc1 -triple powerp

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

void added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1974 +def NoProfileFunction : InheritableAttr { + let Spellings = [GCC<"no_profile">]; + let Subjects = SubjectList<[Function]>; Is this an attribute that exists in GCC? I couldn't find i

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 352810. ychen added a comment. - Rebase correctly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeGen/CGCoroutine

[PATCH] D104465: [clang][deps] Prevent PCH validation failures by padding minimized files

dexonsmith added a comment. > This patch fixes dependency scanning of a TU with prebuilt modular/PCH > dependencies. > > Such modules/PCH might have been built using non-minimized files, while > dependency scanner does use the minimized versions of source files. Implicit > build doesn't like th

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added a comment. In D103750#2823741 , @RedDocMD wrote: > I would suppose that constructor calls are properly handled. (ie, member > constructors are called properly). Do the above tests pass when your new `evalCall` modeling is enabled? Repository

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. In D88666#2825300 , @compnerd wrote: > Interesting, are the logs from the runs available? I have run the test > ~1 times locally and its been stable. Perhaps the logs can show what is > going on. Unfortunately, no

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

compnerd added a comment. Interesting, are the logs from the runs available? I have run the test ~1 times locally and its been stable. Perhaps the logs can show what is going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88666/new/ https

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

MaskRay added a comment. Should `no_profile` specify the inlining behavior? Though `no_sanitize_*` don't specify that, either. As I commented on https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80223 , the Linux kernel specifies `noinline` so the exact inlining behavior doesn't matter. #define n

[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

stella.stamenova added a comment. We still occasionally (every couple of runs) see these tests hang on Windows in both Debug and Release. Unfortunately, I don't have access to the machines running the tests to debug the tests while they are hanging and I haven't had a chance to try to reproduce

[PATCH] D104253: [Clang][Codegen] emit noprofile IR Fn Attr for no_instrument_function Fn Attr

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Jotting down driver to front end flag translations: -fprofile-generate -> -fprofile-instrument=llvm -fprofile-instr-generate -> -fprofile-instrument=clang -fcs-profile-generate -> -fprofile-instrument=csllvm -fprofile-arcs

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

dexonsmith added a comment. > This patch ensures the output of source minimizer is never larger than the > input. This property will be handy in a follow up patch that makes it > possible to pad the minimized output to the size of the original input. I suppose when I wrote first wrote this I wa

[PATCH] D103750: [analyzer] Handle std::make_unique for SmartPtrModeling

NoQ added inline comments. Comment at: clang/test/Analysis/smart-ptr-text-output.cpp:3 +// RUN: -analyzer-checker=core,cplusplus.Move,alpha.cplusplus.SmartPtr\ +// RUN: -analyzer-config cplusplus.SmartPtrModeling:ModelSmartPtrDereference=true\ +// RUN: -analyzer-output=text -

[PATCH] D104475: [Clang][Codegen] emit noprofile IR Fn Attr for new Fn Attr no_profile

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, melver, void, davidxl, vsk, phosek. Herald added a reviewer: aaron.ballman. Herald added subscribers: wenlei, jdoerfert. nickdesaulniers requested review of this revision. Herald added a project: clang. Herald added a

[PATCH] D104381: [analyzer] Added a test case for PR46264

NoQ added a comment. Thanks! I guess there might be some value in building an older Clang from around when the bug was reported so that to see if the crash was indeed there and we're not just reproducing it wrong. It would also allow us to understand where we fixed it through bisecting. But I

[PATCH] D103936: [compiler-rt][hwasan] Define fuchsia implementations of required hwasan functions

leonardchan added a comment. *ping* Anything else that should be updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103936/new/ https://reviews.llvm.org/D103936 ___ cfe-commits mailing list cfe-commi

[PATCH] D103544: [compiler-rt][Fuchsia] Disable interceptors while enabling new/delete replacements

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103544/new/ https://reviews.llvm.org/D103544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D99381: [compiler-rt][hwasan] Add Fuchsia-specific sanitizer platform limits

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99381/new/ https://reviews.llvm.org/D99381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

dexonsmith added a subscriber: arphaman. dexonsmith added a comment. In D103930#2820725 , @bruno wrote: > Thanks for working on this, comments inline. @vsapsai @jansvoboda11 > @dexonsmith any headermap related concerns on your side? @jansvoboda11, I thi

[PATCH] D104285: [analyzer] Retrieve value by direct index from list initialization of constant array declaration.

chrish_ericsson_atx added a comment. In D104285#2823305 , @chrish_ericsson_atx wrote: > I'm not sure about whether or not this patch would only work for constant > arrays with initializer lists. If it does only work for such arrays, then I > wonder wh

[PATCH] D104198: [Matrix] Add documentation for compound assignment and type conversion of matrix types

SaurabhJha updated this revision to Diff 352783. SaurabhJha added a comment. Address comment: replace scalar variables by values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104198/new/ https://reviews.llvm.org/D104198 Files: clang/docs/Languag

[PATCH] D104314: [AIX] Remove --as-needed passing into aix linker

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e2aee8d3bab: [AIX] Remove --as-needed passing into aix linker (authored by jasonliu). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] 4e2aee8 - [AIX] Remove --as-needed passing into aix linker

Author: jasonliu Date: 2021-06-17T17:16:41Z New Revision: 4e2aee8d3bab6010420d9be96480f1d8ae0f35c1 URL: https://github.com/llvm/llvm-project/commit/4e2aee8d3bab6010420d9be96480f1d8ae0f35c1 DIFF: https://github.com/llvm/llvm-project/commit/4e2aee8d3bab6010420d9be96480f1d8ae0f35c1.diff LOG: [AIX

[PATCH] D101976: [OpenMP] Unified entry point for SPMD & generic kernels in the device RTL

jdoerfert updated this revision to Diff 352776. jdoerfert added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101976/new/ https://reviews.llvm.org/D101976 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/CodeGen/C

[PATCH] D104311: [clang] Fix a race condition in the build of clangInterpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG734d688fbce8: [clang] Fix a race condition in the build of clangInterpreter (authored by stella.stamenova). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104

[clang] 734d688 - [clang] Fix a race condition in the build of clangInterpreter

Author: Stella Stamenova Date: 2021-06-17T10:03:33-07:00 New Revision: 734d688fbce8a453aa61764b9b5a43b26455dc0d URL: https://github.com/llvm/llvm-project/commit/734d688fbce8a453aa61764b9b5a43b26455dc0d DIFF: https://github.com/llvm/llvm-project/commit/734d688fbce8a453aa61764b9b5a43b26455dc0d.di

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352773. MyDeveloperDay added a comment. JSON strings can't be split when the line is too long like c++ strings CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 Files: clang/docs/ClangFormat.rst cla

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski marked 5 inline comments as done. skirkovski added a comment. Rebased and fixed warning. My local compiler was yelling at me for adding a default case to switch which already covers everything. For the commit: Author: Seraphime Kirkovski email: skirkovski at vmware.com Repository:

[PATCH] D104376: [clangd] Correct SelectionTree behavior around anonymous field access.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:71 + // so we reduce its range to match the CXXConstructExpr. + // (It's not clear that changing the clang AST would be correct in general). + if (const auto *ME = N.get()) { h

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

skirkovski updated this revision to Diff 352753. skirkovski added a comment. Rebase and fix warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/thinlto-cfi-icall-static-inline-asm.c:3 + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm-bc -flto=thin -fsanitize=cfi-icall -f

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352750. MyDeveloperDay added a comment. Missing new test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D93528 Files: clang/docs/ClangFormat.rst clang/docs/ClangFormatStyleOptions.rst clang/inclu

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

MyDeveloperDay updated this revision to Diff 352744. MyDeveloperDay added a comment. I have reworked this patch to utilise the fact that clang-format can format a JSON object in javascript reasonably well. This technique adds for JSON files only a replacement to the front of the JSON transformi

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

andrewjcg updated this revision to Diff 352740. andrewjcg added a comment. fix sed for windows test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103930/new/ https://reviews.llvm.org/D103930 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Mod

[PATCH] D103962: [C++4OpenCL] Fix qualifiers check on binding references to temporaries

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Yes it seems the only situation where the check would evaluate to a different value with and without your patch is when we have `RefRelationship == Sema::Ref_Related` as false whil

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

predator5047 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D103930: [clang][HeaderSearch] Fix implicit module when using header maps

jansvoboda11 added a comment. I don't have any comments regarding header maps. Comment at: clang/test/Modules/implicit-module-header-maps.cpp:17 +// +// RUN: sed -e "s:OUTPUTS_DIR:%t:g" %S/Inputs/implicit-module-header-maps/b.hmap.json > %t/hmap.json +// RUN: %hmaptool write %

[PATCH] D104459: [clang][lex] Ensure minimizer output is never larger than input

jansvoboda11 updated this revision to Diff 352726. jansvoboda11 added a comment. Fix assert wording Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104459/new/ https://reviews.llvm.org/D104459 Files: clang/lib/Lex/DependencyDirectivesSourceMinimiz

[PATCH] D104465: [clang][deps] Prevent PCH validation failures by padding minimized files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes dependency scanning of a TU with prebuilt modular/PCH dependen

[PATCH] D103191: [OpenCL] Add support of __opencl_c_program_scope_global_variables feature macro

azabaznov updated this revision to Diff 352723. azabaznov added a comment. Restructured test, added comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103191/new/ https://reviews.llvm.org/D103191 Files: clang/include/clang/Basic/OpenCLOption

  1   2   >