[PATCH] D102064: Parse vector bool when stdbool.h and altivec.h are included

Andreas-Krebbel added a comment. > But looking at the GCC sources, it seems we actually intended to support this > use as well, there's just a bug. Given that, I think I'd be fine with > adding this to LLVM -- I'll make sure the GCC bug gets fixed as well. I've fixed the GCC issue now: https

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

This revision was automatically updated to reflect the committed changes. Closed by commit rG95423c7c990d: [clang][driver] Treat -flto=[auto,jobserver] as -flto (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https:/

[clang] 95423c7 - [clang][driver] Treat -flto=[auto, jobserver] as -flto

Author: Timm Bäder Date: 2021-05-21T08:38:41+02:00 New Revision: 95423c7c990d9100deb0056bd9738717cb2bcf2d URL: https://github.com/llvm/llvm-project/commit/95423c7c990d9100deb0056bd9738717cb2bcf2d DIFF: https://github.com/llvm/llvm-project/commit/95423c7c990d9100deb0056bd9738717cb2bcf2d.diff LO

[PATCH] D52524: Add -Wpoison-system-directories warning

manojgupta added a comment. An earlier version did check for library directories [1]. I am not exactly sure why was it removed, maybe it didn't work. So if anyone is willing to test that, please apply the diff and try. [1] Diff https://reviews.llvm.org/D52524?id=215958 CHANGES SINCE LAST ACTI

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

modimo added a comment. In D102820#2772184 , @bruno wrote: > Sounds reasonable to me! Can you double check whether this attribute gets > correctly serialized/deserialized in face of `CXXNewExpr`? An example of how > to test that would be in `clang/test/

[PATCH] D102814: [AIX] Print printable byte list as quoted string

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGedf4d69d3888: [AIX] Print printable byte list as quoted string (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] edf4d69 - [AIX] Print printable byte list as quoted string

Author: Jinsong Ji Date: 2021-05-21T02:37:55Z New Revision: edf4d69d3888d99187ac28cfcd96a93b41623896 URL: https://github.com/llvm/llvm-project/commit/edf4d69d3888d99187ac28cfcd96a93b41623896 DIFF: https://github.com/llvm/llvm-project/commit/edf4d69d3888d99187ac28cfcd96a93b41623896.diff LOG: [A

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346907. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include/llvm/M

[PATCH] D101601: [SelectionDAG] Make fast and linearize visible by clang -pre-RA-sched

TaoPan added inline comments. Comment at: clang/test/CodeGen/pre-ra-sched.c:1-2 +// RUN: %clang %s -mllvm -pre-RA-sched=fast -c -o - | FileCheck %s +// RUN: %clang %s -mllvm -pre-RA-sched=linearize -c -o - | FileCheck %s + hubert.reinterpretcast wrote: > hubert.r

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. In D101793#2772461 , @weiwang wrote: > Thanks for the approval! > > Just want to understand the list of "decls to check for deferred diagnostics" > better, where are these decls coming from? And why do they need to be checked > f

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

bruno accepted this revision. bruno added a reviewer: rsmith. bruno added a comment. This revision is now accepted and ready to land. Thanks for adding the tests. LGTM after some remaining nitpick. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:11632 + // As with enum-decls, we ig

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:757-760 +bool HaveSanitizeCoverage = +CGM.getCodeGenOpts().SanitizeCoverageType || +CGM.getCodeGenOpts().SanitizeCoverageIndirectCalls || +

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. Thanks for the approval! Just want to understand the list of "decls to check for deferred diagnostics" better, where are these decls coming from? And why do they need to be checked for warnings? I see decls from libc are in the list, but I have no idea why are they sel

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang updated this revision to Diff 346882. akhuang added a comment. Change to using TempFiles Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102736/new/ https://reviews.llvm.org/D102736 Files: clang/include/clang/Frontend/CompilerInstance.h

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang marked 2 inline comments as done. akhuang added a comment. In D102736#2769747 , @akhuang wrote: > In D102736#2769358 , @amccarth > wrote: > >> At some point, the duplicate handle must be closed. I don't

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6b8320c0a63: [clang][AST] Improve AST Reader/Writer memory footprint (authored by weiwang). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] e6b8320 - [clang][AST] Improve AST Reader/Writer memory footprint

Author: Wei Wang Date: 2021-05-20T15:34:29-07:00 New Revision: e6b8320c0a634ba60c82693c6631ea90fb2988a6 URL: https://github.com/llvm/llvm-project/commit/e6b8320c0a634ba60c82693c6631ea90fb2988a6 DIFF: https://github.com/llvm/llvm-project/commit/e6b8320c0a634ba60c82693c6631ea90fb2988a6.diff LOG:

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 346870. vlovich added a comment. Fixed missing _ after the hyperlink to the KJ link in the Style options documentation. I'm assuming that's required formatting for hyperlinks by what renders the markdown. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich updated this revision to Diff 346869. vlovich added a comment. Herald added a subscriber: mgrang. Review response - Add examples to documentation + links to KJ style guide. - Add better header doc - Add more test cases - Add release notes - Note current "problem" test with a TODO (corner

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101793/new/ https://reviews.llvm.org/D101793 __

[PATCH] D102772: [SanitizeCoverage] Add support for NoSanitizeCoverage function attribute

morehouse accepted this revision. morehouse added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102772/new/ https://reviews.llvm.org/D102772 _

[PATCH] D102879: rdar://77307290 (Disable retain-count tracking for references to OSMetaClass)

georgi_igna created this revision. georgi_igna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102879 Files: clang/lib/Analysis/RetainSummaryManager.cpp clang/test/Analys

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang updated this revision to Diff 346866. weiwang added a comment. make both ASTReader::DeclsToCheckForDeferredDiags and Sema::DeclsToCheckForDeferredDiags SmallSetVector Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101793/new/ https://review

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 added a comment. Generally LGTM. Some nits. Comment at: clang/include/clang/Driver/Options.td:2331 PosFlag, NegFlag, BothFlags<[NoArgumentUnused, HelpHidden]>>; -def fopenmp_cuda_parallel_target_regions : Flag<["-"], "fopenmp-cuda-parallel-target-regions">,

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 346864. vlovich marked an inline comment as done. vlovich added a comment. Updated release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[PATCH] D102730: [clang-format] Support custom If macros

vlovich marked an inline comment as done. vlovich added inline comments. Comment at: clang/include/clang/Format/Format.h:2098 + /// + /// For example: KJ_IF_MAYBE. + std::vector IfMacros; HazardyKnusperkeks wrote: > vlovich wrote: > > Should I put a hyperlink

[PATCH] D102730: [clang-format] Support custom If macros

vlovich updated this revision to Diff 346863. vlovich added a comment. Review response: - Added additional tests. - Added `KJ_IF_MAYBE` to default `IfMacros`. - Added links to KJ documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102812/new/ https://reviews.llvm.org/D102812 __

[PATCH] D102782: Add support for Warning Flag "-Wstack-usage="

bruno added a comment. Overall looks good, sounds like it's failing tests though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102782/new/ https://reviews.llvm.org/D102782 ___ cfe-commits mailing list c

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. > verifyFormat("test() {\n" > > " ([]() -> {\n" > "int b = 32;\n" > "return 3;\n" > " }).foo();\n" > "}", > Style); > > There you have parenthesis around the lambda, how about without? > Maybe just something like > > std::sort(v.begin(), v.end(),

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D102876: Fix tmp files being left on Windows builds.

akhuang created this revision. Herald added subscribers: dexonsmith, hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang writes object files by first writing to a .tmp file and then renaming to the fi

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo updated this revision to Diff 346856. mstorsjo added a comment. Updated to allow mismatches and just picking the value that is set last on the command line - what do you think of this version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

mstorsjo added a comment. In D102812#2770821 , @DavidSpickett wrote: > Given that using both options currently crashes clang (therefore no one is > relying on this yet) and GCC doesn't have `-mimplicit-it` I think what you > have is actually the best w

[PATCH] D102875: [PowerPC] Add PowerPC compare and multiply related builtins and instrinsics for XL compatibility

NeHuang created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. NeHuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This is patch is in a series of patches to provide builtins for compat

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

bruno added a comment. Sounds reasonable to me! Can you double check whether this attribute gets correctly serialized/deserialized in face of `CXXNewExpr`? An example of how to test that would be in `clang/test/PCH/cxx-method.cpp`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102820/n

[PATCH] D102814: [AIX] Print printable byte list as quoted string

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM with minor comments; thanks! Comment at: llvm/include/llvm/MC/MCAsmInfo.h:268-270 + /// This directive allows emission of an ascii strin

[clang] 4cb4256 - [CUDA][HIP] Fix device variables used by host

Author: Yaxun (Sam) Liu Date: 2021-05-20T17:04:29-04:00 New Revision: 4cb42564ec4b56ef7eb4758bfa4ddf844a163687 URL: https://github.com/llvm/llvm-project/commit/4cb42564ec4b56ef7eb4758bfa4ddf844a163687 DIFF: https://github.com/llvm/llvm-project/commit/4cb42564ec4b56ef7eb4758bfa4ddf844a163687.dif

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4cb42564ec4b: [CUDA][HIP] Fix device variables used by host (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo updated this revision to Diff 346850. mstorsjo added a comment. Update another affected testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102873/new/ https://reviews.llvm.org/D102873 Files: clang/lib/Driver/ToolChains/MinGW.cpp

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdccf5c7dfb9e: [M68k] Support for inline asm operands w/ simple constraints (authored by myhsu). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] dccf5c7 - [M68k] Support for inline asm operands w/ simple constraints

Author: Min-Yih Hsu Date: 2021-05-20T14:00:09-07:00 New Revision: dccf5c7dfb9e68f8750947f5c10ad3227cd92b50 URL: https://github.com/llvm/llvm-project/commit/dccf5c7dfb9e68f8750947f5c10ad3227cd92b50 DIFF: https://github.com/llvm/llvm-project/commit/dccf5c7dfb9e68f8750947f5c10ad3227cd92b50.diff L

[PATCH] D102805: [M68k] Allow user to preserve certain registers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe620bea21199: [M68k] Allow user to preserve certain registers (authored by myhsu). Changed prior to commit: https://reviews.llvm.org/D102805?vs=34

[clang] e620bea - [M68k] Allow user to preserve certain registers

Author: Min-Yih Hsu Date: 2021-05-20T13:57:22-07:00 New Revision: e620bea21199791513f3193a71b819b20a707ab1 URL: https://github.com/llvm/llvm-project/commit/e620bea21199791513f3193a71b819b20a707ab1 DIFF: https://github.com/llvm/llvm-project/commit/e620bea21199791513f3193a71b819b20a707ab1.diff L

[PATCH] D102873: [clang] [MinGW] Fix gcc version detection/picking

mstorsjo created this revision. mstorsjo added a reviewer: rnk. mstorsjo requested review of this revision. Herald added a project: clang. Actually compare each version to the version of the last chosen one. There's no guarantee that the added test case does showcase the previous issue (it depend

[PATCH] D102820: [Clang] Check for returns_nonnull when deciding to add allocation null checks

modimo added a subscriber: urnathan. modimo added a comment. Discussing with @urnathan this makes more sense for the BE to handle when optimizing by eliding the generated null check. Confirmed this is indeed the case so removing the generation in the FE isn't really needed. CHANGES SINCE LAST

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. In D101793#2772033 , @weiwang wrote: > In D101793#2772021 , @yaxunl wrote: > >> In D101793#2769297 , @weiwang >> wrote: >> >>> Tried to make `Sema

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. I've verified that Tensorflow still builds with this patch and that the patch does fix the regressions we've seen. If you could land this patch soon, that would be appreciated. CHANGES SINCE

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

weiwang added a comment. In D101793#2772021 , @yaxunl wrote: > In D101793#2769297 , @weiwang wrote: > >> Tried to make `Sema::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. >> The heap RSS did drop signifi

[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

georgi_igna updated this revision to Diff 346838. georgi_igna added a comment. some files were missing in the previous patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 Files: clang/lib/Analysis/RetainSummaryManager.cpp clang/test/Anal

[PATCH] D101793: [clang][AST] Improve AST Reader/Writer memory footprint

yaxunl added a comment. In D101793#2769297 , @weiwang wrote: > Tried to make `Sema::DeclsToCheckForDeferredDiags` `llvm::SmallSetVector`. > The heap RSS did drop significantly (from peak 100GB to 59GB) , but not as > good as the current fix (peak 26GB),

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb12b0ae11f: [WebAssembly] Warn on exception spec for Emscripten EH (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791/new/ https:

[clang] 3eb12b0 - [WebAssembly] Warn on exception spec for Emscripten EH

Author: Heejin Ahn Date: 2021-05-20T13:00:20-07:00 New Revision: 3eb12b0ae11fe23dc06e55e526fb45e460f72f1e URL: https://github.com/llvm/llvm-project/commit/3eb12b0ae11fe23dc06e55e526fb45e460f72f1e DIFF: https://github.com/llvm/llvm-project/commit/3eb12b0ae11fe23dc06e55e526fb45e460f72f1e.diff LO

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl updated this revision to Diff 346831. yaxunl marked 3 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102801/new/ https://reviews.llvm.org/D102801 Files: clang/include/clang/Sema/Sema.h clang/lib/Code

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12066 + enum CUDAVariableTarget { +CVT_Device, /// Device only tra wrote: > Wasn't there another kind, where the variable is emitted on the

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1008 + for (const unsigned char C : Data) { +if (!isPrint(C)) + return false; jsji wrote: > This still need some slight change to deal with the ending 0 so that we can > handle .stri

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346830. jsji added a comment. Update .string handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat marked 3 inline comments as done. super_concat added a comment. @hans, could you land this for me? I do not have commit access. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-co

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. I created https://reviews.llvm.org/D102861 to make changes to the failing LNT tests. Hoping to push this commit after the test changes in D102862 are approved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

mibintc added a comment. In D74436#2190566 , @lebedev.ri wrote: > In D74436#2190492 , @lebedev.ri > wrote: > >> <...> > > And by codegen changes i mostly mean newly-set/now-unset fp fast-math > instruction flags.

[PATCH] D102863: [analyzer] RetainCountChecker: Disable tracking for references to OSMetaClass.

NoQ added a comment. Please upload the actual change you want to make in the llvm.org main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102863/new/ https://reviews.llvm.org/D102863 ___ cfe-commi

[PATCH] D102863: rdar://77307290 (Disable retain-count tracking for references to OSMetaClass)

georgi_igna created this revision. georgi_igna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. OSMetaClass does not use reference-counting. We should ignore references to OSMetaClass in class RetainSummaryManager. Repository: rG LLVM G

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 346817. RedDocMD added a comment. Removed un-necessary includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAnalyzer/Checkers/SmartPtr.h

[PATCH] D102860: [clang][deps] NFC: Remove the `module-deps-to-rsp.py` utility

georgi_igna created this revision. georgi_igna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was upstreamed in https://reviews.llvm.org/D102495 and put into `clang/utils`. Merge commit 'b99b18eb59ed' from apple/main into internal/m

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:141-163 +auto bugReportOnGet = [&](const Expr *E) -> auto { + if (const auto *MCE = llvm::dyn_cast(E)) { +const auto *Method = MCE->getMethodDecl(); +

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD updated this revision to Diff 346808. RedDocMD marked 10 inline comments as done. RedDocMD added a comment. Code clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97183/new/ https://reviews.llvm.org/D97183 Files: clang/lib/StaticAn

[PATCH] D102791: [WebAssembly] Warn on exception spec for Emscripten EH

dschuff accepted this revision. dschuff added a comment. Got it, this makes sense to me too. And since it can be turned off, I'm not too worried about annoying users. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102791/new/ https://reviews.llvm.o

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1008 + for (const unsigned char C : Data) { +if (!isPrint(C)) + return false; This still need some slight change to deal with the ending 0 so that we can handle .string. Repository

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

tra added a comment. In D102801#2771664 , @yaxunl wrote: > In the updated patch I have a simpler solution which is easier to explain to > the users. Basically we classify variables by how they are emitted: device > side only, host side only, both sides

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers updated this revision to Diff 346800. nickdesaulniers added a comment. - fix lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102742/new/ https://reviews.llvm.org/D102742 Files: clang/include/clang/Driver/Options.td clang/li

[PATCH] D102818: [PGO] Don't reference functions unless value profiling is enabled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f20ac9595c8: [PGO] Don't reference functions unless value profiling is enabled (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 8f20ac9 - [PGO] Don't reference functions unless value profiling is enabled

Author: Reid Kleckner Date: 2021-05-20T11:09:24-07:00 New Revision: 8f20ac9595c8b279641dace6f212b8a9673b24e4 URL: https://github.com/llvm/llvm-project/commit/8f20ac9595c8b279641dace6f212b8a9673b24e4 DIFF: https://github.com/llvm/llvm-project/commit/8f20ac9595c8b279641dace6f212b8a9673b24e4.diff

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D102801#2769619 , @tra wrote: > Tentative LGTM as we need it to fix the regression soon. > > Summoning @rsmith for the 'big picture' opinion. > While the patch may fix this particular re

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D102801#2769936 , @tra wrote: > This patch does not appear to fix the second regression introduced by the > D102237 . > > Trying to compile the followin

[PATCH] D102517: [clang] Add support for the "abstract" contextual keyword of MSVC

rnk added a comment. @hans, can you review this? I am trying to offload clang reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102517/new/ https://reviews.llvm.org/D102517 ___ cfe-commits mailing l

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

vitalybuka requested changes to this revision. vitalybuka added a comment. This revision now requires changes to proceed. So I will hide it from "Ready to Review" list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.

[PATCH] D102801: [CUDA][HIP] Fix device variables used by host

yaxunl updated this revision to Diff 346796. yaxunl retitled this revision from "[CUDA][HIP] Fix implicit constant variable" to "[CUDA][HIP] Fix device variables used by host". yaxunl edited the summary of this revision. yaxunl added a comment. Fix the other regression CHANGES SINCE LAST ACTION

[PATCH] D102812: [clang] Don't pass multiple backend options if mixing -mimplicit-it and -Wa,-mimplicit-it

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2369 -static bool AddARMImplicitITArgs(const ArgList &Args, ArgStringList &CmdArgs, +static bool CheckARMImplicitITArg(StringRef Value) { + return Value == "always" || Value == "never" || Value ==

[PATCH] D102814: [AIX] Print printable byte list as quoted string

jsji updated this revision to Diff 346794. jsji added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102814/new/ https://reviews.llvm.org/D102814 Files: clang/test/CodeGenCXX/debug-info-byval.cpp llvm/include/llvm/M

[PATCH] D101479: [Driver] Support libc++ in MSVC

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, sorry for the delay, this fell off the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101479/new/ https://reviews.llvm.org/D101479

[PATCH] D20401: [Lexer] Don't merge macro args from different macro files

vsk added a comment. In D20401#2770059 , @nickdesaulniers wrote: > I know this was sped up slightly in 3339c568c43e4644f02289e5edfc78c860f19c9f, > but this change makes `updateConsecutiveMacroArgTokens` the hottest function > in clang in a bottom up pro

[PATCH] D102853: [OpenCL] Align definition of __IMAGE_SUPPORT__ feature macro with OpenCL version and __opencl_c_images feature macro definition

azabaznov created this revision. azabaznov added reviewers: Anastasia, svenvh. Herald added subscribers: ldrumm, yaxunl. azabaznov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D102818: [PGO] Don't reference functions unless value profiling is enabled

vsk accepted this revision. vsk added a comment. Thanks, lgtm as well. On Darwin, the __llvm_prf_data section is marked with S_ATTR_LIVE_SUPPORT to allow the linker to dead strip functions even if they are pointed-to by a profd global. Removing the reference altogether should yield even better

[PATCH] D102818: [PGO] Don't reference functions unless value profiling is enabled

rnk added a comment. Thanks! I'll wait to see if I can get an ack from the Apple folks who indicated that they are using frontend PGO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102818/new/ https://reviews.llvm.org/D102818

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 ___ cfe-commits mailing list cfe-com

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

This revision was automatically updated to reflect the committed changes. Closed by commit rG136ced498ba8: When vector is found as a type or non-type id, check if it is really the… (authored by jamieschmeiser). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[clang] 136ced4 - When vector is found as a type or non-type id, check if it is really the altivec vector token.

Author: Jamie Schmeiser Date: 2021-05-20T12:39:04-04:00 New Revision: 136ced498ba84f6b6126051626e319f18ba740f5 URL: https://github.com/llvm/llvm-project/commit/136ced498ba84f6b6126051626e319f18ba740f5 DIFF: https://github.com/llvm/llvm-project/commit/136ced498ba84f6b6126051626e319f18ba740f5.dif

[PATCH] D102756: [clang-repl] Tell the LLJIT the exact target triple we use.

lhames accepted this revision. lhames added a comment. This revision is now accepted and ready to land. LGTM. :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102756/new/ https://reviews.llvm.org/D102756 ___ cfe-commit

[PATCH] D102623: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d574a110440: [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z} (authored by peterwaller-arm). Repository: rG LLVM Github Monorepo CHA

[clang] 2d574a1 - [CodeGen][AArch64][SVE] Canonicalize intrinsic rdffr{ => _z}

Author: Peter Waller Date: 2021-05-20T16:22:50Z New Revision: 2d574a110440597eefe1b2a8b6144e4e89c21d05 URL: https://github.com/llvm/llvm-project/commit/2d574a110440597eefe1b2a8b6144e4e89c21d05 DIFF: https://github.com/llvm/llvm-project/commit/2d574a110440597eefe1b2a8b6144e4e89c21d05.diff LOG:

[PATCH] D102850: [C++4OpenCL] Allow address space conversion in reinterpret_cast

olestrohm created this revision. olestrohm added reviewers: Anastasia, svenvh. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. This fixes the prioritization of address spaces when choos

[PATCH] D102849: [flang][driver] Add support for the "-init-only" option

stuartellis created this revision. Herald added a reviewer: sscalpone. Herald added a subscriber: dang. Herald added a reviewer: awarzynski. stuartellis requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding the -init-only option and corres

[PATCH] D98798: Produce warning for performing pointer arithmetic on a null pointer.

jamieschmeiser updated this revision to Diff 346751. jamieschmeiser added a comment. Fix formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98798/new/ https://reviews.llvm.org/D98798 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td clang/inc

[clang] beb5a3a - Correct some thread safety analysis diagnostics; NFC.

Author: Aaron Ballman Date: 2021-05-20T11:30:21-04:00 New Revision: beb5a3a298a1bb2687b421cb960d36a5e9b3ad43 URL: https://github.com/llvm/llvm-project/commit/beb5a3a298a1bb2687b421cb960d36a5e9b3ad43 DIFF: https://github.com/llvm/llvm-project/commit/beb5a3a298a1bb2687b421cb960d36a5e9b3ad43.diff

[PATCH] D100546: [ARM][AArch64] SLSHardening: make non-comdat thunks possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. danielkiss marked an inline comment as done. Closed by commit rG801ab71032e1: [ARM][AArch64] SLSHardening: make non-comdat thunks possible (authored by danielkiss). Her

[clang] 801ab71 - [ARM][AArch64] SLSHardening: make non-comdat thunks possible

Author: Daniel Kiss Date: 2021-05-20T17:07:05+02:00 New Revision: 801ab71032e157eb7bcd38efeb6486742a7c53bb URL: https://github.com/llvm/llvm-project/commit/801ab71032e157eb7bcd38efeb6486742a7c53bb DIFF: https://github.com/llvm/llvm-project/commit/801ab71032e157eb7bcd38efeb6486742a7c53bb.diff L

[PATCH] D102689: [C++4OpenCL] Allow address space conversion in reinterpret_cast

Anastasia added a comment. Just to move the discussion from https://reviews.llvm.org/D101519 here. First of all I think this change should not be OpenCL specific i.e. there is not reason to do something different from C++ in general. Embedded C doesn't regulate the conversions between non-poin

[PATCH] D100991: Fix parsing of vector keyword in presence of conflicting uses.

ZarkoCA accepted this revision. ZarkoCA added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100991/new/ https://reviews.llvm.org/D100991 ___ cfe-commits mailing list cf

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

tbaeder updated this revision to Diff 346737. tbaeder added a comment. Use `hasFlag()` instead of `hasArg()` in Driver.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102479/new/ https://reviews.llvm.org/D102479 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/Driver

[PATCH] D99455: [AST] Store regular ValueDecl* in BindingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c2ec96e5f9: [AST] Store regular ValueDecl* in BindingDecl (NFC) (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE L

  1   2   >