[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

pengfei added inline comments. Comment at: clang/test/Sema/x86-no-x87.c:48-61 +void assign2() { + struct st_long_double st; +#ifndef NOERROR + // expected-error@+2{{long double is not supported on this target}} +#endif + st.ld = 0.42; +} These seems pass with

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu added inline comments. Comment at: clang/lib/Basic/Targets/M68k.cpp:145 case 'd': // data register - case 'f': // floating point register info.setAllowsRegister(); nickdesaulniers wrote: > did you mean to drop support for `'f'`? To drop it for now.

[PATCH] D102585: [M68k] Support inline asm operands w/ simple constraints

myhsu updated this revision to Diff 346338. myhsu marked 2 inline comments as done. myhsu added a comment. Fixed lint warning and added more test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102585/new/ https://reviews.llvm.org/D102585 Files: clang/lib/Basic/Targets/M68k.cpp

[PATCH] D102543: [Scudo] Make -fsanitize=scudo use standalone. Migrate tests.

vitalybuka added inline comments. Comment at: compiler-rt/test/scudo/standalone/CMakeLists.txt:13-14 + string(TOLOWER "-${arch}" SCUDO_STANDALONE_TEST_CONFIG_SUFFIX) + get_test_cc_for_arch(${arch} SCUDO_STANDALONE_TEST_TARGET_CC + SCUDO_STANDALONE_TEST_TAR

[clang] 0c509db - [NewPM] Add options to PrintPassInstrumentation

Author: Arthur Eubanks Date: 2021-05-18T20:59:35-07:00 New Revision: 0c509dbc7e29cbd03f161513b8d335f768c7cc2b URL: https://github.com/llvm/llvm-project/commit/0c509dbc7e29cbd03f161513b8d335f768c7cc2b DIFF: https://github.com/llvm/llvm-project/commit/0c509dbc7e29cbd03f161513b8d335f768c7cc2b.diff

[PATCH] D102196: [NewPM] Add options to PrintPassInstrumentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0c509dbc7e29: [NewPM] Add options to PrintPassInstrumentation (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] b5a80a0 - [CMake] Update Cmake cache file for Win to ARM Linux cross builds. NFC

Author: Vladimir Vereschaka Date: 2021-05-18T20:29:16-07:00 New Revision: b5a80a0f370ca218d935991fe2bec0d19ca3ba51 URL: https://github.com/llvm/llvm-project/commit/b5a80a0f370ca218d935991fe2bec0d19ca3ba51 DIFF: https://github.com/llvm/llvm-project/commit/b5a80a0f370ca218d935991fe2bec0d19ca3ba51

[PATCH] D102715: [AIX] Fix LIT failure on native aix

hubert.reinterpretcast added a comment. From the comment, it seems the code as-is fails to test the property intended. It seems we want this: struct packed_chars { char a : 8, b : 8, c : 8, d : 4; char e : 8 __attribute__((packed)); char f : 4, g : 8, h : 8, i : 8; }; extern in

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

dblaikie added a comment. Thanks for following up on this. - Probably best to commit the revert of the workarounds as a separate follow-up commit, but I appreciate seeing them here to understand that this patch addresses them - Comment at: clang/lib/Sema/SemaChecking.cpp:104

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Obviously needs work/cleanup, changes to x86, and tests, but posting for early feedback about module level attributes vs function level attributes, or possibly something else. I tested this quickly with thin LTO

[PATCH] D102742: [IR] make stack-protector-guard-* flags into module attrs

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, pcc, xiangzhangllvm. Herald added subscribers: dexonsmith, hiraditya, kristof.beyls. nickdesaulniers requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-co

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. Here's a slightly simpler reproducer: https://godbolt.org/z/85EsxnPPM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102237/new/ https://reviews.llvm.org/D102237 ___ cfe-commits maili

[PATCH] D102736: Fix tmp files being left on Windows builds.

aganea added a comment. In D102736#2767516 , @amccarth wrote: > I seem to recall some thrashing on this topic a few months ago. If I'm > remembering correctly, setting the disposition to delete temporary files on > Windows was causing problems with Rus

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

NoQ added a comment. In D102696#2766765 , @martong wrote: > In D102696#2766337 , @NoQ wrote: > >> Ok so the state has enough constraints. It's enough to know that `$x + $y == >> 0` and `$y == 0` in order to deduc

[PATCH] D102736: Fix tmp files being left on Windows builds.

amccarth added a comment. I'll have to dig into my archived email tomorrow. I seem to recall some thrashing on this topic a few months ago. If I'm remembering correctly, setting the disposition to delete temporary files on Windows was causing problems with Rust builds because you can't always

[PATCH] D102736: Fix tmp files being left on Windows builds.

rnk added a subscriber: jansvoboda11. rnk added a comment. For other reviewers, I know Duncan, @dexonsmith, has also spent some time working on the clang output file management APIs. And @jansvoboda11 as well, I think. Comment at: clang/lib/Frontend/CompilerInstance.cpp:720 +

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L updated this revision to Diff 346308. Xiangling_L added a comment. Add comments to the block; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102715/new/ https://reviews.llvm.org/D102715 Files: clang/test/Sema/struct-packed-align.c Index: clang/test/Sema/struct-packed-ali

[PATCH] D102736: Fix tmp files being left on Windows builds.

aganea added a comment. Do you think the existing crash tests can be modified to validate that .tmp files are deleted indeed? Comment at: clang/lib/Frontend/CompilerInstance.cpp:829 +Binary ? llvm::sys::fs::OF_None : llvm::sys::fs::OF_Text; +// Use OF_Delete on Win

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. Here's one example reproducer: https://godbolt.org/z/77M596W89 It's rather hairy, but should be usable for further debugging. There are no CUDA attributes anywhere in sight, but we do end up emitting a host-only constructor for `o_u` which calls `strlen`. Repository: rG

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:872 // using stdin. + void *FileHandle = nullptr; +#ifdef _WIN32 I'm saving the windows HANDLE here instead of using `fd` because for some reason calling `_get_osfhandle(fd)`

[PATCH] D100252: [clang] Fix for "Bug 27113 - MSVC-compat __identifier implementation incomplete"

super_concat added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100252/new/ https://reviews.llvm.org/D100252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D102736: Fix tmp files being left on Windows builds.

akhuang created this revision. akhuang added reviewers: rnk, aganea, amccarth. Herald added subscribers: dexonsmith, hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang writes object files by first wri

LLVM buildmaster will be restarted tonight

Hello everyone, LLVM buildmaster will be restarted at 8PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D92024: [clang] Implement P0692R1 from C++20 (access checking on specializations and instantiations)

aorlov updated this revision to Diff 346289. aorlov added a comment. Simplified the solution. Replaced RemoveDiagnosticsFromPool with SuppressAccessChecks. @krisb, please, look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92024/new/ https://revi

[PATCH] D102730: [clang-format] Support custom If macros

vlovich added inline comments. Comment at: clang/include/clang/Format/Format.h:2098 + /// + /// For example: KJ_IF_MAYBE. + std::vector IfMacros; Should I put a hyperlink to https://github.com/capnproto/capnproto/blob/master/kjdoc/tour.md#maybes? Repository

[PATCH] D102730: [clang-format] Support custom If macros

vlovich created this revision. vlovich added reviewers: curdeius, MyDeveloperDay, HazardyKnusperkeks. vlovich added a project: clang-format. vlovich requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like with ForEachMacros, support user to pr

[PATCH] D102728: [clang][Sema] removes -Wfree-nonheap-object reference param false positive

cjdb created this revision. cjdb added reviewers: gbiv, manojgupta, aaron.ballman. Herald added a reviewer: george.burgess.iv. Herald added subscribers: dcaballe, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-j

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

AndreyChurbanov added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346 +// link node as successor of all nodes in the prev_set if any +npredecessors += +__kmp_depnode_link_successor(gtid, thread, task, node, prev_set); -

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. In D102237#2767131 , @yaxunl wrote: > > It would be interesting to know what kind of variables are emitted. I'm still reducing the failure. I'll send you a reproducer once I have it. > Would you like the change reverted? We ha

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

yaxunl added a comment. In D102237#2767052 , @tra wrote: > Sam, this patch has apparently triggered some unwanted side effects. I'm > still reducing the failures to something that could be used for debugging, > but the rough symptoms are: > > We now end

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

jasonliu added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4964 if (!RawTriple.isOSDarwin() && !RawTriple.isNVPTX() && - !RawTriple.isAMDGPU() && !RawTriple.isOSAIX()) + !RawTriple.isAMDGPU()) CmdArgs.push_back("-mconstructor-aliases"); --

[PATCH] D98895: [X86][Draft] Disable long double type for -mno-x87 option

asavonic added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98895/new/ https://reviews.llvm.org/D98895 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D102306: Add gfx1034

kzhuravl added inline comments. Comment at: llvm/include/llvm/BinaryFormat/ELF.h:737 EF_AMDGPU_MACH_AMDGCN_GFX1033 = 0x039, + EF_AMDGPU_MACH_AMDGCN_GFX1034 = 0x03e, EF_AMDGPU_MACH_AMDGCN_GFX602= 0x03a, For future reference, MACH values

[PATCH] D102724: Revert "[AIX] Avoid structor alias; die before bad alias codegen"

Jake-Egan created this revision. Jake-Egan added reviewers: cebowleratibm, jasonliu, sfertile, daltenty, DiggerLin, hubert.reinterpretcast. Herald added subscribers: jeroen.dobbelaere, nemanjai. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribe

[PATCH] D102237: [CUDA][HIP] Fix non-ODR-use of static device variable

tra added a comment. Sam, this patch has apparently triggered some unwanted side effects. I'm still reducing the failures to something that could be used for debugging, but the rough symptoms are: We now end up emitting the code for the host-only static member functions of instantiated class t

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102723/new/ https://reviews.llvm.org/D102723 __

[PATCH] D102723: [HIP] Tighten checks in hip-include-path.hip test case

bjope created this revision. bjope added reviewers: yaxunl, tra, zhuhan0. bjope requested review of this revision. Herald added a project: clang. The checks (both positive and negative checks) in the test case hip-include-path.hip could mistakenly end up matching the string "clang" from the Instal

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr)

[PATCH] D102105: [OpenMP][NFC] Refactor cc tests for implicit simd check

ggeorgakoudis updated this revision to Diff 346255. ggeorgakoudis added a comment. Update for correct implicit checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102105/new/ https://reviews.llvm.org/D102105 Files: clang/test/OpenMP/cancel_code

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. In D102706#2766680 , @HazardyKnusperkeks wrote: > Maybe a bit more test cases with smaller lambdas? Or without the outer > parenthesis? I'm not sure I understand this comment. Which test case are you referring to by "or withou

[PATCH] D102715: [AIX] Fix LIT failure on native aix

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, sfertile, jasonliu, daltenty. Xiangling_L requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2766141 , @uweigand wrote: > In D96033#2765954 , @v.g.vassilev > wrote: > >> @hubert.reinterpretcast, thanks for the feedback. I have created a patch as >> discussed -- http

[PATCH] D102714: [clang-tidy] Fix a crash on invalid code for memset-usage check.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. hokein requested review of this revision. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102714 Files: clang-tools-extra/clang-ti

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

urnathan added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

ggeorgakoudis added a comment. In D101849#2766411 , @mikerice wrote: > In D101849#2764825 , @ABataev wrote: > >> No, it is not required. Most probably, needed to simplify test checks, >> nothing else. > > Thanks.

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

martong added a comment. In D102696#2766337 , @NoQ wrote: > Ok so the state has enough constraints. It's enough to know that `$x + $y == > 0` and `$y == 0` in order to deduce that `$x + 0 == 0`. But you're saying > that we don't know how to infer it s

[PATCH] D102688: [clang-repl] Better match the underlying architecture.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dd5ef01ef13: [clang-repl] Better match the underlying architecture. (authored by v.g.vassilev). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 8dd5ef0 - [clang-repl] Better match the underlying architecture.

Author: Vassil Vassilev Date: 2021-05-18T19:14:33Z New Revision: 8dd5ef01ef13e402784bba47f7a24175f5f00325 URL: https://github.com/llvm/llvm-project/commit/8dd5ef01ef13e402784bba47f7a24175f5f00325 DIFF: https://github.com/llvm/llvm-project/commit/8dd5ef01ef13e402784bba47f7a24175f5f00325.diff LO

[PATCH] D101974: [Utils][WIP] Refactor script for cc tests

ggeorgakoudis updated this revision to Diff 346235. ggeorgakoudis added a comment. Update correction for implicit simd checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101974/new/ https://reviews.llvm.org/D101974 Files: clang/utils/refactor_

[PATCH] D99235: [HIP] Change to code object v4

gregrodgers added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:116 + if (getOrCheckAMDGPUCodeObjectVersion(C.getDriver(), Args) >= 4) +OffloadKind = OffloadKind + "v4"; for (const auto &II : Inputs) { yaxunl wrote: > tra wrote: > > We

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. Maybe a bit more test cases with smaller lambdas? Or without the outer parenthesis? Comment at: clang/include/clang/Format/Format.h:2456 + enum LambdaBodyIndentationKind : unsigned char { +/// Align lambda body relative to the lambda si

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

jdoerfert added a comment. In D101849#2766411 , @mikerice wrote: > In D101849#2764825 , @ABataev wrote: > >> No, it is not required. Most probably, needed to simplify test checks, >> nothing else. > > Thanks. I'

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich added a comment. I'm not 100% certain if the implementation is absolutely correct. For example, the `#define A` test case is broken (the closing brace is on the wrong line). Additionally, the `pop_back` feels weird but seems to fix all the other cases to make the closing brace aligned p

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

vlovich created this revision. vlovich added reviewers: MyDeveloperDay, curdeius. vlovich added a project: clang-format. vlovich requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently the lambda body indents relative to where the lambda

[PATCH] D102273: [analyzer] LoopUnrolling: fix crash when a loop counter is captured in a lambda by reference

NoQ added a comment. I've just been patching up clang-tidy's infinite loop checker and the problem sounds s similar. Maybe we should move clang-tidy's alias analysis into `libAnalysis` and re-use it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D102568: [Driver] Delete -mimplicit-it=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2919222d8017: [Driver] Delete -mimplicit-it= (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[clang] 2919222 - [Driver] Delete -mimplicit-it=

Author: Fangrui Song Date: 2021-05-18T10:57:24-07:00 New Revision: 2919222d8017f2425a85765b95e4b7c6f8e70ca4 URL: https://github.com/llvm/llvm-project/commit/2919222d8017f2425a85765b95e4b7c6f8e70ca4 DIFF: https://github.com/llvm/llvm-project/commit/2919222d8017f2425a85765b95e4b7c6f8e70ca4.diff

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. In D96033#2766372 , @v.g.vassilev wrote: > In D96033#2766332 , @phosek wrote: > >> We've started seeing `LLVM ERROR: out of memory` on our 2-stage LTO Linux >> builders after this change la

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Oof. Accurate! > // Would it be more elegant to create the emitting checkers tag here? Mind > that this is a checker that houses many others. I think the checkers should have a right to attach cu

[PATCH] D101849: [OpenMP][NFC] Refactor Clang OpenMP tests using update_cc_test_checks

mikerice added a comment. In D101849#2764825 , @ABataev wrote: > No, it is not required. Most probably, needed to simplify test checks, > nothing else. Thanks. I'd like to remove the "REQUIRES: x86-registered-target", the -O1 for CHECK6,10, and regene

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. In D96033#2766332 , @phosek wrote: > We've started seeing `LLVM ERROR: out of memory` on our 2-stage LTO Linux > builders after this change landed. It looks like linking `clang-repl` always > fails on our bot, but I've also

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

NoQ added a comment. Ok so the state has enough constraints. It's enough to know that `$x + $y == 0` and `$y == 0` in order to deduce that `$x + 0 == 0`. But you're saying that we don't know how to infer it so instead of making us able to infer it let's make us ask the solver easier questions.

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

phosek added a comment. We've started seeing `LLVM ERROR: out of memory` on our 2-stage LTO Linux builders after this change landed. It looks like linking `clang-repl` always fails on our bot, but I've also seen OOM when linking `ClangCodeGenTests` and `FrontendTests`. Do you have any idea why

[PATCH] D101777: [clang] p1099 1/5: [NFC] Break out BaseUsingDecl from UsingDecl

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) -return ToUsingOrErr.takeError(); + Expected ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr)

[PATCH] D102479: [clang][driver] Treat unkonwn -flto= values as -flto

steven_wu added a comment. I don't think current implementation is the best idea. I think is better to make the gcc compatible LTO value to be a clang Driver only option, give them an option name, and handle them separately in driver to invoke correct fullLTO cc1 command, so that: - The value

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman added a comment. In D102261#2766240 , @thakis wrote: > Looks like this breaks tests on macOS: > http://45.33.8.238/macm1/9739/step_7.txt > http://45.33.8.238/mac/31615/step_7.txt > > Please take a look, and please revert for now if it takes

[clang] ccbac06 - Speculatively fix failing tests from 6381664580080f015bc0c2ec647853f697cf744a

Author: Aaron Ballman Date: 2021-05-18T12:44:58-04:00 New Revision: ccbac06a072b86ea3b46479e478a1abee8520ef8 URL: https://github.com/llvm/llvm-project/commit/ccbac06a072b86ea3b46479e478a1abee8520ef8 DIFF: https://github.com/llvm/llvm-project/commit/ccbac06a072b86ea3b46479e478a1abee8520ef8.diff

[PATCH] D102696: [Analyzer] Find constraints that are directly attached to a BinOp

martong created this revision. martong added reviewers: steakhal, NoQ, vsavchenko. Herald added subscribers: ASDenysPetrov, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. marton

[PATCH] D102261: Introduce SYCL 2020 mode

thakis added a comment. Looks like this breaks tests on macOS: http://45.33.8.238/macm1/9739/step_7.txt http://45.33.8.238/mac/31615/step_7.txt Please take a look, and please revert for now if it takes a while to fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://re

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8998a8aa97f8: [clang-offload-bundler] Add sections and set section flags using one llvm… (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] 8998a8a - [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

Author: Sergey Dmitriev Date: 2021-05-18T08:44:41-07:00 New Revision: 8998a8aa97f81c758403615ec897ce79c1ccdcad URL: https://github.com/llvm/llvm-project/commit/8998a8aa97f81c758403615ec897ce79c1ccdcad DIFF: https://github.com/llvm/llvm-project/commit/8998a8aa97f81c758403615ec897ce79c1ccdcad.dif

[PATCH] D101986: [InstSimplify] Remove redundant {insert,extract}_vector intrinsic chains

paulwalker-arm added inline comments. Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5741-5747 +// (insert_vector _, (extract_vector X, 0), 0) -> X +unsigned IdxN = cast(Idx)->getZExtValue(); +Value *X = nullptr; +if (match(SubVec, m_Intrinsic( +

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

uweigand added a comment. In D96033#2765954 , @v.g.vassilev wrote: > @hubert.reinterpretcast, thanks for the feedback. I have created a patch as > discussed -- https://reviews.llvm.org/D102688 > > @uweigand, thanks for reaching out. I believe the patch a

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske added a comment. This change in itself is not enough to support `BindingDecl`. The tests pass but the resulting AST is not correct because `DecompositionDecl` is not imported yet. Still no visible problem happens, the `DecompositionDecl` is just visited and imported as a `VarDecl`. The

[PATCH] D99675: RFC [llvm][clang] Create new intrinsic llvm.arith.fence to control FP optimization at expression level

kpn added a comment. In D99675#2696327 , @pengfei wrote: > In D99675#2695424 , @kpn wrote: > >> What changes are needed for a backend, and what happens if they aren't done? > > As far as I understand it, backend doe

[PATCH] D102261: Introduce SYCL 2020 mode

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks for the review! I've commit in 6381664580080f015bc0c2ec647853f697cf744a . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://rev

[clang] 6381664 - Introduce SYCL 2020 mode

Author: Aaron Ballman Date: 2021-05-18T10:34:14-04:00 New Revision: 6381664580080f015bc0c2ec647853f697cf744a URL: https://github.com/llvm/llvm-project/commit/6381664580080f015bc0c2ec647853f697cf744a DIFF: https://github.com/llvm/llvm-project/commit/6381664580080f015bc0c2ec647853f697cf744a.diff

[PATCH] D102688: [clang-repl] Better match the underlying architecture.

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. This revision is now accepted and ready to land. LGTM; thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102688/new/ https://reviews.llvm.org/D102688 _

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

jansvoboda11 accepted this revision. jansvoboda11 added a comment. This revision is now accepted and ready to land. LGTM provided the output file stays the same. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 _

[PATCH] D102492: [clang][AST] Add support for BindingDecl to ASTImporter.

balazske updated this revision to Diff 346169. balazske added a comment. Improved the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102492/new/ https://reviews.llvm.org/D102492 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/AST

[PATCH] D102654: [DebugInfo][test] Check specific func name to ignore codegen differences

This revision was automatically updated to reflect the committed changes. jsji marked an inline comment as done. Closed by commit rG7d6449322ecb: [DebugInfo][test] Check specific func name to ignore codegen differences (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 7d64493 - [DebugInfo][test] Check specific func name to ignore codegen differences

Author: Jinsong Ji Date: 2021-05-18T14:03:27Z New Revision: 7d6449322ecba2fa34090ca8ed610328febee108 URL: https://github.com/llvm/llvm-project/commit/7d6449322ecba2fa34090ca8ed610328febee108 DIFF: https://github.com/llvm/llvm-project/commit/7d6449322ecba2fa34090ca8ed610328febee108.diff LOG: [D

[PATCH] D102689: [C++4OpenCL] Allow address space conversion in reinterpret_cast

olestrohm created this revision. olestrohm added reviewers: Anastasia, rjmccall. olestrohm added a project: clang. Herald added subscribers: ldrumm, yaxunl. olestrohm requested review of this revision. Herald added a subscriber: cfe-commits. Allow converting between types with different address sp

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

v.g.vassilev added a comment. @hubert.reinterpretcast, thanks for the feedback. I have created a patch as discussed -- https://reviews.llvm.org/D102688 @uweigand, thanks for reaching out. I believe the patch above should fix your setup. Could you confirm? Repository: rG LLVM Github Monorepo

[PATCH] D102688: [clang-repl] Better match the underlying architecture.

v.g.vassilev created this revision. v.g.vassilev added reviewers: hubert.reinterpretcast, uweigand. v.g.vassilev requested review of this revision. In cases where `-fno-integrated-as` is specified we should overwrite the `EmitAssembly` action as well. We also should rely on the target triple fro

[PATCH] D102238: [TableGen] [Clang] Clean up arm_mve.td file

Paul-C-Anagnostopoulos added a comment. Could I get an LGTM on this? I have removed the spurious comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102238/new/ https://reviews.llvm.org/D102238 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D28080: [Docs][OpenCL] Added OpenCL feature description to user manual.

bader closed this revision. bader added a comment. Herald added subscribers: ebevhan, arphaman. Closed by https://reviews.llvm.org/rG18e165f50d8c1ab3afe7098dc00557d5f1a43cfa. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28080/new/ https://reviews.llvm.org/D28080 __

[PATCH] D102261: Introduce SYCL 2020 mode

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Sorry for the delay. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102261/new/ https://reviews.llvm.org/D102261 ___ cfe-commit

[PATCH] D102683: [analyzer] Check the checker name, rather than the ProgramPointTag when silencing a checker

Szelethus added a comment. While I still see checker silencing as a solution to a problem that shouldn't exist, I'm unsure about the amount of tedious and invasive work required to make the underlying infrastructure elegant just for the sake of it being elegant. Most notably, checker silencing

[PATCH] D102670: [clang-offload-bundler] Add sections and set section flags using one llvm-objcopy invocation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102670/new/ https://reviews.llvm.org/D102670 ___

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

protze.joachim added inline comments. Comment at: openmp/runtime/src/kmp_taskdeps.cpp:344-346 +// link node as successor of all nodes in the prev_set if any +npredecessors += +__kmp_depnode_link_successor(gtid, thread, task, node, prev_set); --

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

uweigand added a comment. Looks like this is also failing on s390x: error: Added modules have incompatible data layouts: E-m:e-i1:8:16-i8:8:16-i64:64-f128:64-a:8:16-n32:64 (module) vs E-m:e-i1:8:16-i8:8:16-i64:64-f128:64-v128:64-a:8:16-n32:64 (jit) The problem here is that on s390x we use a

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:4654 + + return ImportUsingShadowDecls(D, ToUsingEnum); } martong wrote: > Could it work if you imported the shadow declarations **before** creating the > `UsingEnumDecl`? I yes, then th

[PATCH] D102241: [clang] p1099 4/5: using enum EnumTag

urnathan updated this revision to Diff 346107. urnathan added a comment. updating to reset dependency graph and coax build bot into working CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102241/new/ https://reviews.llvm.org/D102241 Files: clang-tools-extra/clangd/FindTarget.cpp clan

[PATCH] D100276: [clang] p1099 3/5: using Enum::member

urnathan added a comment. good, it appears the patch bot fail is fixed -- it seems unhappy with non-tree-like dependency graphs, and tries to apply each reachable patch as many times as it is reachable :( The data race failure seems entirely unconnected with this patch -- please correct me if I

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ab513cd3e06: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 2ab513c - [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Author: Alexey Bader Date: 2021-05-18T10:27:35+03:00 New Revision: 2ab513cd3e0648806db7ed1f8170ad4a3d4e7749 URL: https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749 DIFF: https://github.com/llvm/llvm-project/commit/2ab513cd3e0648806db7ed1f8170ad4a3d4e7749.diff

[PATCH] D102643: [analyzer][Z3][NFC] Use GTEST_SKIP instead of hacks

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Cheers! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102643/new/ https://reviews.llvm.org/D102643 ___ cfe-commits mailing list cfe-

[PATCH] D102149: [analyzer][ctu] Allow loading invocation list from a compilation database automatically detected from the ctu-dir

OikawaKirie added a comment. In D102149#2765402 , @martong wrote: > Thank you @OikawaKirie for working on this many CTU related patches! I am > going to find time for a thorough review and going to pursue @gamesh411 as > well to do the same! On the othe

[PATCH] D102248: [C++4OpenCL] Fix initialization of __constant constructors without arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG642d2f000b26: [OpenCL] Fix initialization of __constant constructors without arguments (authored by olestrohm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

  1   2   >