[PATCH] D97265: [clang] Allow clang-check to customize analyzer output file or dir name

OikawaKirie added a comment. ping @sammccall again Do I need to add other reviewers if you are busy doing your job? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97265/new/ https://reviews.llvm.org/D97265 ___ cfe-commits mailing list cfe-com

[PATCH] D101143: [RISCV] [1/2] Add IR intrinsic for Zbe extension

LevyHsu updated this revision to Diff 340322. LevyHsu marked an inline comment as done. LevyHsu added a comment. 1. llvm/lib/Target/RISCV/RISCVInstrInfoB.td - Format fix: Aligned SDT*** for: riscv_bcompress riscv_bcompressw riscv_bdecompress riscv_bdecompressw Reposi

[clang] e6131f7 - [Clang] Fixup for D100611

Author: Hsiangkai Wang Date: 2021-04-25T09:41:19+08:00 New Revision: e6131f7ee54e1660be519fc7172fbbbc2b4da803 URL: https://github.com/llvm/llvm-project/commit/e6131f7ee54e1660be519fc7172fbbbc2b4da803 DIFF: https://github.com/llvm/llvm-project/commit/e6131f7ee54e1660be519fc7172fbbbc2b4da803.diff

[PATCH] D101194: [Driver] Push multiarch path setup to individual drivers

phosek added a comment. In D101194#2714206 , @MaskRay wrote: >> Different platforms use different rules for multiarch triples so it's >> difficult to provide a single method for all platforms. > > Guess this is a Linux/Hurd/Fuchsia specific thing. I don'

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG108864397d26: [Clang] Add clang attribute `clang_builtin_alias`. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D10061

[clang] 1088643 - [Clang] Add clang attribute `clang_builtin_alias`.

Author: Hsiangkai Wang Date: 2021-04-25T08:49:19+08:00 New Revision: 108864397d2639267f417cabc7f248431437 URL: https://github.com/llvm/llvm-project/commit/108864397d2639267f417cabc7f248431437 DIFF: https://github.com/llvm/llvm-project/commit/108864397d2639267f417cabc7f248431437.diff

[PATCH] D101192: Add support for #elifdef and #elifndef

dexonsmith added a comment. I reviewed the source minimizer sections, and the code looks correct. It'd probably be good to have unit tests in clang/unittests/Lex/DependencyDirectivesSourceMinimizerTest.cpp for the incremental changes. - Do the new constructs stick around in the minimized sourc

[PATCH] D101239: Enable IgnoreArray flag in pro-type-member-init rule

h-joo created this revision. h-joo added a reviewer: alexfh. h-joo added a project: clang-tools-extra. Herald added subscribers: kbarton, nemanjai. h-joo requested review of this revision. Herald added a subscriber: cfe-commits. The flag used to exist but wasn't implemented. Fixes b/47288

[PATCH] D101212: [AST][JSON] Fix null ptr crash dumping TemplateTemplateParmDecl

aaron.ballman closed this revision. aaron.ballman added a comment. In D101212#2714697 , @dtolnay wrote: > Yes, could you please commit for me? This is my first contribution. Please > attribute to David Tolnay . I've committed on your behalf in 967ebad12

[clang] 967ebad - Fix null ptr crash dumping TemplateTemplateParmDecl

Author: David Tolnay Date: 2021-04-24T12:28:10-04:00 New Revision: 967ebad12521f3187014a722804c27a75d44e649 URL: https://github.com/llvm/llvm-project/commit/967ebad12521f3187014a722804c27a75d44e649 DIFF: https://github.com/llvm/llvm-project/commit/967ebad12521f3187014a722804c27a75d44e649.diff

[PATCH] D101236: [ASTImporter] Import definitions required for layout of [[no_unique_address]] from LLDB

jankratochvil created this revision. jankratochvil added reviewers: teemperor, shafik, dblaikie. jankratochvil added a project: clang. Herald added a subscriber: martong. Herald added a reviewer: a.sidorin. jankratochvil requested review of this revision. When LLDB needs to use `[[no_unique_addres

[PATCH] D101212: [AST][JSON] Fix null ptr crash dumping TemplateTemplateParmDecl

dtolnay added a comment. Yes, could you please commit for me? This is my first contribution. Please attribute to David Tolnay . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101212/new/ https://reviews.llvm.org/D101212 ___

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a small nit with the documentation wording. Comment at: clang/include/clang/Basic/AttrDocs.td:5704 + +This attribute is deprecated. Use clang_builtin_alias instead. }]; I'd

[PATCH] D69498: IR: Invert convergent attribute handling

sameerds added a comment. In D69498#2712706 , @nhaehnle wrote: > In D69498#2711396 , @foad wrote: > >> I don't have much to add to the conversation except to point out that this >> definition defines `noconvergent`

[PATCH] D101212: [AST][JSON] Fix null ptr crash dumping TemplateTemplateParmDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the fix! Do you need me to commit on your behalf? If so, what email address and name would you like me to use for attribution? Repository: rG LLVM Github M

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman added inline comments. Comment at: clang/lib/Lex/PPDirectives.cpp:621 +if (CondInfo.FoundElse) +Diag(Tok, diag::pp_err_elif_after_else) << (IsElifDef ? 1 : 2); + erichkeane wrote: > As you know, I'm a giant fan of using enums for

[PATCH] D101192: Add support for #elifdef and #elifndef

aaron.ballman updated this revision to Diff 340283. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101192/new/ https://reviews.llvm.org/D101192 Files: clang/include/clang/B

[clang] d29a53d - [Clang] Added heading to doc for malloc attribute

Author: Dávid Bolvanský Date: 2021-04-24T15:35:16+02:00 New Revision: d29a53d9cabcb37621b793c5bf44076e75b8db88 URL: https://github.com/llvm/llvm-project/commit/d29a53d9cabcb37621b793c5bf44076e75b8db88 DIFF: https://github.com/llvm/llvm-project/commit/d29a53d9cabcb37621b793c5bf44076e75b8db88.dif

[clang] c68f929 - [Clang] Added doc for malloc attribute

Author: Dávid Bolvanský Date: 2021-04-24T15:27:48+02:00 New Revision: c68f92983600196e33e8abfbcd1aa19235f34c8d URL: https://github.com/llvm/llvm-project/commit/c68f92983600196e33e8abfbcd1aa19235f34c8d DIFF: https://github.com/llvm/llvm-project/commit/c68f92983600196e33e8abfbcd1aa19235f34c8d.dif

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

xbolva00 added a comment. In D100879#2714431 , @dmgreen wrote: > Hello. Nice idea. Unfortunately this blocks tail folding, making codesize a > bit bigger: https://godbolt.org/z/rncPvbh8d > I'm guessing it shouldn't? But the attribute isn't handled somewh

[PATCH] D98726: [analyzer] Enabling MallocChecker to take up after SmartPtrModelling

RedDocMD added a comment. F16456099: 2021-04-24_733x821.png As you can see here, the bug note is attached in the second case (please refer to my previous comment), but somehow, it doesn't finally show up as a bug. Weird. Repository: rG LLVM Github Monorep

[PATCH] D100879: [Clang] Propagate guaranteed alignment for malloc and others

dmgreen added a comment. Hello. Nice idea. Unfortunately this blocks tail folding, making codesize a bit bigger: https://godbolt.org/z/rncPvbh8d I'm guessing it shouldn't? But the attribute isn't handled somewhere along the way. Any ideas where? Repository: rG LLVM Github Monorepo CHANGES S