[PATCH] D100347: Fix the const overload of IgnoreExprNodes

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Thanks for the fix! Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D10034

LLVM buildmaster will be restarted soon

Hello everyone, LLVM buildmaster will be restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100361: [Driver] Make the findVCToolChainViaEnvironment case-insensitive

ArturGainullin created this revision. ArturGainullin added reviewers: rnk, hamzasood. ArturGainullin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. PATH usage on Windows is case-insensitive. There could be situations when toolchain path ca

[PATCH] D99708: [X86] Enable compilation of user interrupt handlers.

LuoYuanke accepted this revision. LuoYuanke added a comment. This revision is now accepted and ready to land. LGTM. But wait one or two days to see if there is more comments from Craig and HJ. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99708/new/ https://reviews.llvm.org/D99708 ___

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3150-3153 + // If we got a non-deduced auto ReturnType, we are in a dependent context and + // there is no point in allowing copy elision since we won't have it deduced + // by the point the VardDecl is inst

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337035. ThePhD marked an inline comment as done. Herald added subscribers: aheejin, dschuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 Files: clang/docs/LanguageExtensions.rst clang/lib/Frontend/Ini

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3150-3153 + // If we got a non-deduced auto ReturnType, we are in a dependent context and + // there is no point in allowing copy elision since we won't have it deduced + // by the point the VardDecl is in

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2683632 , @morehouse wrote: > Also, the descriptions states: > >> Divide the corpus into n parts according to size. > > Is it really according to size? IIUC when there are multiple worker > processes, any new coverage

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD marked an inline comment as done. ThePhD added a comment. In D100346#2684705 , @rsmith wrote: > Exposing this information seems fine to me. I think it'd be more useful to > expose it in a way the preprocessor can inspect ... The reason it's done

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337024. ThePhD added a comment. The tests check for macros in strict byte-value "alphabetical" order. We also need documentation, as was suggested!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ htt

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3150-3153 + // If we got a non-deduced auto ReturnType, we are in a dependent context and + // there is no point in allowing copy elision since we won't have it deduced + // by the point the VardDecl is in

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

rsmith added a comment. Exposing this information seems fine to me. I think it'd be more useful to expose it in a way the preprocessor can inspect, but it's hard to see how to do that without requiring us to invent identifier-shaped names for all encodings, and perhaps we shouldn't be in the bu

[PATCH] D100085: [X86] Support -march=rocketlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3fc1fe8db830: [X86] Support -march=rocketlake (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2683622 , @morehouse wrote: > Thanks for sharing your data. Took a quick look and seems promising. > > I would like to try this on FuzzBench before accepting the patch though. > FuzzBench has a very nice experimental

[PATCH] D99696: [clang] NRVO: Improvements and handling of more cases.

rsmith added inline comments. Comment at: clang/include/clang/Sema/Sema.h:4728 - enum CopyElisionSemanticsKind { -CES_Strict = 0, -CES_AllowParameters = 1, -CES_AllowDifferentTypes = 2, -CES_AllowExceptionVariables = 4, -CES_AllowRValueReferenceType = 8, -

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

Jim added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1217 +defm vmv_x : RVVOp0BuiltinSet<"vmv_x_s", "csil", + [["s", "ve", "ev"], +["s", "UvUe", "UeUv"]]>; Inden

[PATCH] D100085: [X86] Support -march=rocketlake

skan accepted this revision. skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SG

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SGX. s

[PATCH] D100161: Redistribute energy for Corpus

gtt1995 added a comment. In D100161#2683632 , @morehouse wrote: > Also, the descriptions states: > >> Divide the corpus into n parts according to size. > > Is it really according to size? IIUC when there are multiple worker > processes, any new coverage

[PATCH] D100085: [X86] Support -march=rocketlake

skan added inline comments. Comment at: llvm/lib/Support/X86TargetParser.cpp:176 FeaturesBroadwell | FeatureAES | FeatureCLFLUSHOPT | FeatureXSAVEC | FeatureXSAVES | FeatureSGX; // SkylakeServer inherits all SkylakeClient features except SGX. Shouldn't

[PATCH] D99005: [clang] Implement P2266 Simpler implicit move

mizvekov updated this revision to Diff 337009. mizvekov added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99005/new/ https://reviews.llvm.org/D99005 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD updated this revision to Diff 337008. ThePhD added a comment. Fixes formatting derps in the pre-linter check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100346/new/ https://reviews.llvm.org/D100346 Files: clang/lib/Frontend/InitPreproc

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

rsmith added a comment. In D99790#2681487 , @lebedev.ri wrote: > I think it should be fixed in `CodeGenVTables::maybeEmitThunk()`, likely in > `arrangeGlobalDeclaration()`. > Or is this wrong on the AST level, too? The AST-level `ThunkInfo` doesn't track

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. Hi, (Last call for review!!) Is there any more comments? This review has lasted for more than a year now. I believe I had addressed or answered all questions and concerns. Thank all reviewers' precious feedbacks. For late comers, again (1) Original llvm-dev [RFC] discuss

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:603-604 + ReturnStmt *R = cast(St); + R->setRetValue(IgnoreImplicitAsWritten(R->getRetValue())); + Expr *Ex = R->getRetValue(); + while (!isa(Ex)) { I think this would be clearer, assuming

[PATCH] D99949: [AMDGPU][OpenMP] Add amdgpu-arch tool to list AMD GPUs installed

JonChesterfield added a comment. New tests look good to me, thanks. Comment at: clang/include/clang/Driver/Options.td:922 +def amdgpu_arch_tool_EQ : Joined<["--"], "amdgpu-arch-tool=">, Group, + HelpText<"Path to amdgpu_arch tool, used for detecting AMD GPU arch in the system

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 336985. lebedev.ri added a comment. Hardcode triple/target in tests, should fix 32-bit CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new/ https://reviews.llvm.org/D93822 Files: clang-tools-extra

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27dfcd978edc: [clang-tidy] Add include to misc-uniqueptr-reset-release (authored by njames93). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d updated this revision to Diff 336983. d added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100347/new/ https://reviews.llvm.org/D100347 Files: clang/include/clang/AST/IgnoreExpr.h Index: clang/include/clang/AST/IgnoreExpr.

[clang-tools-extra] 27dfcd9 - [clang-tidy] Add include to misc-uniqueptr-reset-release

Author: Nathan James Date: 2021-04-12T23:32:15+01:00 New Revision: 27dfcd978edc94b4b46218b12a3dfbcdc47ae4c8 URL: https://github.com/llvm/llvm-project/commit/27dfcd978edc94b4b46218b12a3dfbcdc47ae4c8 DIFF: https://github.com/llvm/llvm-project/commit/27dfcd978edc94b4b46218b12a3dfbcdc47ae4c8.diff

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

njames93 updated this revision to Diff 336982. njames93 added a comment. Add store options method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97683/new/ https://reviews.llvm.org/D97683 Files: clang-tools-extra/clang-tidy/misc/UniqueptrResetRe

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri updated this revision to Diff 336981. lebedev.ri marked 4 inline comments as done. lebedev.ri added a comment. @aaron.ballman thank you for taking a look! Addressed all review notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

lebedev.ri added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:130 + StringRef TyAsString = + IndexExprType->isSignedIntegerType() ? "ssize_t" : "size_t"; + aaron.ballman wrote: > aaron.b

[PATCH] D100347: Fix the const overload of IgnoreExprNodes

d created this revision. d requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The existing code causes an infinite recursion. This is likely an oversight of commit c0e5e3fbfa504c37

[PATCH] D100346: [Clang] String Literal and Wide String Literal Encoding from the Preprocessor

ThePhD created this revision. ThePhD added a reviewer: aaron.ballman. ThePhD added a project: clang. ThePhD requested review of this revision. Herald added a subscriber: cfe-commits. **//Short version://** Please let us know the encoding that the compiler chooses for it's implementation-defined,

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

JonChesterfield added a comment. Interesting. Reduction across lanes in warp? If so, this is probably a way to handle the last step reduction for openmp reductions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100124/new/ https://reviews.llvm.org/D100124 __

[clang-tools-extra] c2ad7c2 - Revert "[clangd] Provide a way to disable external index"

Author: Sterling Augustine Date: 2021-04-12T14:39:13-07:00 New Revision: c2ad7c23707cece995ee9070283a72c4afc8c0fe URL: https://github.com/llvm/llvm-project/commit/c2ad7c23707cece995ee9070283a72c4afc8c0fe DIFF: https://github.com/llvm/llvm-project/commit/c2ad7c23707cece995ee9070283a72c4afc8c0fe.

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers accepted this revision. nickdesaulniers added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/Function.h:156 + static Function *createWithDefaultAttr(FunctionType *Ty, LinkageTypes Linkage, +

[PATCH] D100343: [AST][NFC] Remove temporary ASTTU file from Introspection generation.

njames93 updated this revision to Diff 336960. njames93 added a comment. Add new line at the end of remapped file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100343/new/ https://reviews.llvm.org/D100343 Files: clang/lib/Tooling/CMakeLists.txt

[PATCH] D100343: [AST][NFC] Remove temporary ASTTU file from Introspection generation.

njames93 created this revision. njames93 added a reviewer: steveire. Herald added a subscriber: mgorny. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can use the Preprocessor to remap this file, cleaning up the cmake code. R

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers added a comment. In D100251#2684083 , @MaskRay wrote: > In D100251#2684074 , > @nickdesaulniers wrote: > >>> -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame >>> while >>>

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

MaskRay added a comment. In D100251#2684074 , @nickdesaulniers wrote: >> -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame >> while >> -fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address >> produces .eh_frame. >

[PATCH] D100251: [IR][sanitizer] Set nounwind on module ctor/dtor, additionally set uwtable if -fasynchronous-unwind-tables

nickdesaulniers added a comment. > -fno-exceptions -fno-asynchronous-unwind-tables -g produces .debug_frame > while > -fno-exceptions -fno-asynchronous-unwind-tables -g -fsanitize=address > produces .eh_frame. Does this patch change that behavior? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100124: [Clang][NVPTX] Add NVPTX intrinsics and builtins for CUDA PTX redux.sync instructions

tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:460-468 +TARGET_BUILTIN(__nvvm_redux_sync_add_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_min_s32, "SiSii", "", SM_80) +TARGET_BUILTIN(__nvvm_redux_sync_max_s32, "SiSii", "", SM_80)

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

This revision was automatically updated to reflect the committed changes. Closed by commit rG7dd606889925: [clang-rename] Handle designated initializers. (authored by dcastagna, committed by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1003

[clang] 7dd6068 - [clang-rename] Handle designated initializers.

Author: Daniele Castagna Date: 2021-04-12T13:15:14-07:00 New Revision: 7dd60688992526bb7ee0c7846e9abd591fc3e297 URL: https://github.com/llvm/llvm-project/commit/7dd60688992526bb7ee0c7846e9abd591fc3e297 DIFF: https://github.com/llvm/llvm-project/commit/7dd60688992526bb7ee0c7846e9abd591fc3e297.di

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

mkuper added a comment. I defer to Justin, he knows AST much better than I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 ___ cfe-commits mailing list cfe-

[PATCH] D100057: Remove warning "suggest braces" for aggregate initialization of an empty class with an aggregate base class.

rsmith accepted this revision. rsmith added a comment. Thanks, I think this makes sense as a generalization of the existing "idiomatic aggregate initialization" rule. Some suggested cleanups but otherwise LGTM. Comment at: clang/lib/Sema/SemaInit.cpp:1001 /// the braces in ag

[PATCH] D93822: [clang-tidy] Add check for implicit widening of multiplication result

aaron.ballman added a comment. FWIW, it looks like tests are still failing on Windows according to the CI pipeline. Comment at: clang-tools-extra/clang-tidy/bugprone/ImplicitWideningOfMultiplicationResultCheck.cpp:126 + QualType SizeTy = IndexExprType->isSignedIntegerType()

[clang] 661cc71 - [PassManager][PhaseOrdering] lower expects before running simplifyCFG

Author: Sanjay Patel Date: 2021-04-12T15:07:53-04:00 New Revision: 661cc71a1c50081389d73b2baae02f51df670ba1 URL: https://github.com/llvm/llvm-project/commit/661cc71a1c50081389d73b2baae02f51df670ba1 DIFF: https://github.com/llvm/llvm-project/commit/661cc71a1c50081389d73b2baae02f51df670ba1.diff

[PATCH] D100197: Enable creation of large response file on z/OS

This revision was automatically updated to reflect the committed changes. Closed by commit rG06c8b29d23ac: Enable creation of large response file on z/OS (authored by SeanP, committed by abhina.sreeskantharajan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 06c8b29 - Enable creation of large response file on z/OS

Author: Sean Perry Date: 2021-04-12T15:06:05-04:00 New Revision: 06c8b29d23ac2e3a44f2a2f3af85b15dc8aab3c2 URL: https://github.com/llvm/llvm-project/commit/06c8b29d23ac2e3a44f2a2f3af85b15dc8aab3c2 DIFF: https://github.com/llvm/llvm-project/commit/06c8b29d23ac2e3a44f2a2f3af85b15dc8aab3c2.diff LO

[PATCH] D99580: [CLANG] [DebugInfo] Convert File name to native format

amccarth added a comment. Sorry, I think I've lost track of some context while I was on vacation. I don't understand why several of the tests are now unsupported on Windows. Some of those seem like important tests. If canonicalizing the file names to the platform's native style creates new t

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna added a comment. Thank you Justin. I'm happy with this now that I finally managed to get rid of the lint errors. Let's wait for Micheal's opinion or until tomorrow and then we can push it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1003

[PATCH] D99903: [Clang][Sema] better -Wcast-function-type diagnose for pointer parameters and parameters with cv-qualifiers

ychen added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99903/new/ https://reviews.llvm.org/D99903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

Re: [PATCH] D100310: Add field designated initializers logic in Tooling/Rename

I guess you need me or Michael to push this. Happy to do so once you're happy with it. On Mon, Apr 12, 2021 at 11:33 AM Daniele Castagna via Phabricator < revi...@reviews.llvm.org> wrote: > dcastagna updated this revision to Diff 336912. > dcastagna added a comment. > > clang-format again > > >

[clang-tools-extra] fc1e146 - Fix documentation typo.

Author: Richard Smith Date: 2021-04-12T11:39:08-07:00 New Revision: fc1e146e4412334d6c70173c345a698a01b122b8 URL: https://github.com/llvm/llvm-project/commit/fc1e146e4412334d6c70173c345a698a01b122b8 DIFF: https://github.com/llvm/llvm-project/commit/fc1e146e4412334d6c70173c345a698a01b122b8.diff

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna updated this revision to Diff 336912. dcastagna added a comment. clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactoring/RecursiveSymb

[PATCH] D99568: [clang][invocation] Fix copy constructor, add copy assignment to CompilerInvocation

dexonsmith added a comment. In D99568#2682815 , @jansvoboda11 wrote: > Ping. Thanks for the ping; I'd completely missed your follow-up. Just fixing AnalyzerOptions for now sounds great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D100187: [OPENMP]Fix PR49115: Incorrect results for scan directive.

ABataev updated this revision to Diff 336909. ABataev added a comment. Rebase + fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100187/new/ https://reviews.llvm.org/D100187 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema/SemaOpenM

[PATCH] D99732: [AST] Pick last tentative definition as the acting definition

pestctrl added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99732/new/ https://reviews.llvm.org/D99732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk added a comment. In D100148#2683748 , @glaubitz wrote: > Understood. However, I'm not really sure what else we need. Do we just take > the architecture definition from here to pass the proper flags to the > compiler or do we also need to add > so

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. In D100148#2683710 , @hvdijk wrote: > In D100148#2683325 , @glaubitz > wrote: > >> Hi! Can we get this patch merged as-is or do we need anything else? > > Sorry, miscommunication. I was

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:488 (A == LangAS::opencl_global && (B == LangAS::opencl_global_device || B == LangAS::opencl_global_host)) ||

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

hvdijk added a comment. In D100148#2683325 , @glaubitz wrote: > Hi! Can we get this patch merged as-is or do we need anything else? Sorry, miscommunication. I was thinking you could use this to update D99988 to actually

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna updated this revision to Diff 336900. dcastagna added a comment. Actually run git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactoring/Re

[PATCH] D67586: Replace uses of std::iterator with explicit using

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a92aff721f4: Replace uses of std::iterator with explicit using (authored by hamzasood, committed by MaskRay). Herald added a project: clang. Herald

[clang] 0a92aff - Replace uses of std::iterator with explicit using

Author: Hamza Sood Date: 2021-04-12T10:47:14-07:00 New Revision: 0a92aff721f43406691e38a0965fd0c917121d09 URL: https://github.com/llvm/llvm-project/commit/0a92aff721f43406691e38a0965fd0c917121d09 DIFF: https://github.com/llvm/llvm-project/commit/0a92aff721f43406691e38a0965fd0c917121d09.diff LO

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman marked an inline comment as done. haberman added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:697-699 + } else if (VD && dyn_cast(VD->getType())) { +// Call is: obj->*method_ptr or obj.*method_ptr +const auto *MPT = VD->getType()->castAs(); -

[PATCH] D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls.

haberman updated this revision to Diff 336894. haberman added a comment. - Switch to isa<> for type check. - Merge branch 'main' into musttail Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99517/new/ https://reviews.llvm.org/D99517 Files: clang/

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a comment. Also, the descriptions states: > Divide the corpus into n parts according to size. Is it really according to size? IIUC when there are multiple worker processes, any new coverage they have simply gets appended to `Files`. So `Files` is not necessarily sorted by siz

[PATCH] D100161: Redistribute energy for Corpus

morehouse added a subscriber: metzman. morehouse added a comment. Thanks for sharing your data. Took a quick look and seems promising. I would like to try this on FuzzBench before accepting the patch though. FuzzBench has a very nice experimental framework for evaluating changes like this. >

[PATCH] D99790: [CGCall] Annotate `this` argument with alignment

sanwou01 added a comment. +1 on eagerly awaiting a fix. a 3% regression on astar (AArch64, LTO) bisects to @lebedev.ri 's revert: https://reviews.llvm.org/rG6270b3a1eafaba4279e021418c5a2c5a35abc002 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100266/new/ https://reviews.llvm.org/D100266 ___

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna updated this revision to Diff 336878. dcastagna added a comment. Fixed clang-format pre-merge lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactori

[PATCH] D100085: [X86] Support -march=rocketlake

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100085/new/ https://reviews.llvm.org/D100085 ___

[clang-tools-extra] 8883cb3 - Fix nits.

Author: Alexander Kornienko Date: 2021-04-12T18:46:13+02:00 New Revision: 8883cb3e4004aebddf9bd0f92ea47ba897397794 URL: https://github.com/llvm/llvm-project/commit/8883cb3e4004aebddf9bd0f92ea47ba897397794 DIFF: https://github.com/llvm/llvm-project/commit/8883cb3e4004aebddf9bd0f92ea47ba897397794

[clang-tools-extra] 8a944d8 - [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

Author: Jens Massberg Date: 2021-04-12T18:46:12+02:00 New Revision: 8a944d82cd14001a92ef088229041ee0fb1fd1e6 URL: https://github.com/llvm/llvm-project/commit/8a944d82cd14001a92ef088229041ee0fb1fd1e6 DIFF: https://github.com/llvm/llvm-project/commit/8a944d82cd14001a92ef088229041ee0fb1fd1e6.diff

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8a944d82cd14: [clang-tidy] Add option to ignore macros in readability-function-cognitive… (authored by massberg, committed by alexfh). Repository:

[PATCH] D100136: Allow applying attributes to subset of allowed subjects.

This revision was automatically updated to reflect the committed changes. Closed by commit rG38cf112a6bc8: Allow applying attributes to subset of allowed subjects. (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100136/new/ https://

[clang] 38cf112 - Allow applying attributes to subset of allowed subjects.

Author: Artem Belevich Date: 2021-04-12T09:33:33-07:00 New Revision: 38cf112a6bc8502ff8cce6ef524cf04c07f90f96 URL: https://github.com/llvm/llvm-project/commit/38cf112a6bc8502ff8cce6ef524cf04c07f90f96 DIFF: https://github.com/llvm/llvm-project/commit/38cf112a6bc8502ff8cce6ef524cf04c07f90f96.diff

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

alexfh accepted this revision. alexfh added a comment. LG with a couple of nits. Comment at: clang-tools-extra/clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:230 + explicit FunctionASTVisitor(const bool IgnoreMacros) + : IgnoreMacros(IgnoreMacros){}; + -

[PATCH] D100148: [Driver] Fix compiler-rt lookup for x32

glaubitz added a comment. Hi! Can we get this patch merged as-is or do we need anything else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100148/new/ https://reviews.llvm.org/D100148 ___ cfe-commits ma

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson requested changes to this revision. tejohnson added a comment. This revision now requires changes to proceed. To do what I suggested in the prior comment, you'd probably want to add a new index-wide flag (since we don't read IR in the thin link). See for example how EnableSplitLTOUnit

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I can't argue with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 ___

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg marked an inline comment as done. massberg added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-function-cognitive-complexity.rst:31 + any macro arguments are ignored, even if they should count to the complexity. + Default is `fal

[PATCH] D99683: [HIP] Support ThinLTO

tejohnson added a comment. In D99683#2677357 , @yaxunl wrote: > Any other concerns? Thanks. I have some concerns around the fragility of this, for the reasons I mentioned earlier where it may not always be able to import everything needed. > We will doc

[PATCH] D100282: [Coroutines] Move CoroEarly pass to before AlwaysInliner

lxfind updated this revision to Diff 336850. lxfind added a comment. Set the attributes in Clang instead of CoroEarly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100282/new/ https://reviews.llvm.org/D100282 Files: clang/lib/CodeGen/CGCoroutine

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 336848. massberg added a comment. Add note that the new IgnoreMarcos options isn't guaranteed to be forward compatible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/ https://reviews.llvm.org/D98070

[PATCH] D100294: [AArch64][SVE] Fix dup/dupq intrinsics for C++.

kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100294/new/ https://reviews.llvm.org/D100294

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

dcastagna created this revision. Herald added a subscriber: jfb. dcastagna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang Tooling, and more specifically Refactoring/Rename, have support code to extract source locations given a Unifie

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

DavidSpickett added a subscriber: omjavaid. DavidSpickett added a comment. Ah, @omjavaid already put in a fix. I think you can just reland the change now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99250/new/ https://reviews.llvm.org/D99250 ___

[PATCH] D97196: [clang-tidy] Add new check 'bugprone-unhandled-exception-at-new'.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnhandledExceptionAtNewCheck.cpp:28-30 +// Generic catch handler should match anything. +if (CatchS->getCaughtType().isNull()) + return true; I think this should

[PATCH] D97683: [clang-tidy] Add include to misc-uniqueptr-reset-release

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97683/new/ https://reviews.llvm.org/D97683 __

[PATCH] D100266: [RISCV][Clang] Add vmv and vfmv series intrinsic functions.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1001 +["x", "Uv", "UvUe"]]>; +} Jim wrote: > I am not sure that indent is needed inside let expression. In some cases, it > don't have inden

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/test/CodeGenSYCL/address-space-parameter-conversions.cpp:80 + // Ensure that we still get 3 different template instantiations. + tmpl(GLOB); + // CHECK-DAG: [[GLOB_LOAD4:%[a-zA-Z0-9]+]] = load i32 addrspace(1)*, i32 addrspace

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. K, thx. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-function-cognitive-complexity.rst:31 + any macro arguments are ignored, even if they shoul

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:493 + // Default is a superset of SYCL address spaces. + (A == LangAS::Default && +(B == LangAS::sycl_private || B == LangAS::sycl_local || bader wrote: >

[clang-tools-extra] 63bc9e4 - [clangd] Provide a way to disable external index

Author: Kadir Cetinkaya Date: 2021-04-12T16:43:23+02:00 New Revision: 63bc9e443502ab6def2dec0b5ffe64a522f801cc URL: https://github.com/llvm/llvm-project/commit/63bc9e443502ab6def2dec0b5ffe64a522f801cc DIFF: https://github.com/llvm/llvm-project/commit/63bc9e443502ab6def2dec0b5ffe64a522f801cc.dif

[PATCH] D98070: [clang-tidy] Add option to ignore macros in readability-function-cognitive-complexity check.

massberg updated this revision to Diff 336831. massberg added a comment. Add test with global IgnoreMacros=true and readability-function-cognitive-complexity.IgnoreMacros unset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98070/new/ https://revi

  1   2   >