[PATCH] D98388: [RISCV][Clang] Add RVV vle/vse intrinsic functions.

rogfer01 added a comment. Overall LGTM. Thanks @khchen! Comment at: clang/include/clang/Basic/riscv_vector.td:175 + // builtin to C/C++. It is parameter of the unmasked version without VL + // operand. + list PermuteOperands = []; Not sure if we want to clar

[PATCH] D96404: [Android] Default to --rtlib=compiler-rt

smeenai added a comment. Hilariously enough, this breaks building compiler-rt itself inside LLVM's runtime builds setup for us. The runtimes build setup builds clang and then uses the just-built clang to build compiler-rt. That build fails to link since my just-built clang doesn't have compiler

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

courbet added a comment. In D97854#2617097 , @scanon wrote: > Is there a mechanism to instruct the sanitizer to ignore a specific > expression or function? From a cursory reading, I am mildly concerned about a > deluge of false positives from primitives

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + sbc100 wrote: > hubert.reinterpretcast wrote: > > curdeius wrote: > > > hubert.reinterpretcast wrote: > > > > curdeius wrote: > > > > > curdeiu

[PATCH] D98379: [RISCV] Add additional checking to tablgen RISCVVEmitter requested in D95016.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9773cad51939: [RISCV] Add additional checking to tablgen RISCVVEmitter requested in D95016. (authored by craig.topper). Changed prior to commit: h

[clang] 9773cad - [RISCV] Add additional checking to tablgen RISCVVEmitter requested in D95016.

Author: Craig Topper Date: 2021-03-10T19:46:25-08:00 New Revision: 9773cad51939d3980d841876d77064eb7a11002f URL: https://github.com/llvm/llvm-project/commit/9773cad51939d3980d841876d77064eb7a11002f DIFF: https://github.com/llvm/llvm-project/commit/9773cad51939d3980d841876d77064eb7a11002f.diff

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

NoQ added a comment. > Actually many cases don't need to know an exact original type. In all cases we're supposed to have an original type, whether we need it or not. Simply because we're simulating a typed language. If we don't have it it's a bug. > Some cases can extract the type from `SVal`

[PATCH] D98379: [RISCV] Add additional checking to tablgen RISCVVEmitter requested in D95016.

craig.topper updated this revision to Diff 329807. craig.topper added a comment. Turn some llvm_unreachables into fatal errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98379/new/ https://reviews.llvm.org/D98379 Files: clang/utils/TableGen/R

[PATCH] D98364: [clangd] Use ref counted strings throughout for File Contents

sammccall added a comment. Avoiding copies seems nice, but this makes some interfaces more awkward. Do you have any measurements that some of these copies matter? (The dirty FS changes avoided coping all the dirty buffers at once, but it seems like these changes will mostly save ~1 file copy pe

[PATCH] D98379: [RISCV] Add additional checking to tablgen RISCVVEmitter requested in D95016.

jrtc27 accepted this revision. jrtc27 added a comment. This revision is now accepted and ready to land. Any TableGen backend error that's a real message and not an assertion failure with a backtrace is a win in my books :) Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:627

[PATCH] D98377: [clangd] Show padding following a field on field hover.

sammccall updated this revision to Diff 329805. sammccall added a comment. Stop reporting offset for fields in a union, too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98377/new/ https://reviews.llvm.org/D98377 Files: clang-tools-extra/clangd/

[PATCH] D98379: [RISCV] Add additional checking to tablgen RISCVVEmitter requested in D95016.

craig.topper created this revision. craig.topper added reviewers: jrtc27, khchen. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217,

[PATCH] D98377: [clangd] Show padding following a field on field hover.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:105 + HI.Size = 1; + HI.Padding = 15; + HI.AccessSpecifier = "public"; njames93 wrote: > Does it make any sense to include the padding for union

[PATCH] D98377: [clangd] Show padding following a field on field hover.

njames93 added inline comments. Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:105 + HI.Size = 1; + HI.Padding = 15; + HI.AccessSpecifier = "public"; Does it make any sense to include the padding for union fields? Reposito

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm updated this revision to Diff 329799. stelios-arm marked 2 inline comments as done. stelios-arm added a comment. Addressed the comments made by @SjoerdMeijer and @dmgreen. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98264/new/ https://reviews.llvm.org/D98264 Files: clan

[PATCH] D98375: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG70af0bf6fe46: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag (authored by leonardchan). Repository: rG LLVM Github Monorepo

[clang] 70af0bf - [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag

Author: Leonard Chan Date: 2021-03-10T16:28:40-08:00 New Revision: 70af0bf6fe462cc16a2e56657d20eeed126d41d0 URL: https://github.com/llvm/llvm-project/commit/70af0bf6fe462cc16a2e56657d20eeed126d41d0 DIFF: https://github.com/llvm/llvm-project/commit/70af0bf6fe462cc16a2e56657d20eeed126d41d0.diff

[PATCH] D46443: [libc++] Add missing cstdalign header

sbc100 added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > curdeius wrote: > > hubert.reinterpretcast wrote: > > > curdeius wrote: > > > > curdeius wrote: > > > > > hubert.reinterpretcas

[PATCH] D98264: [AArch64] Implement __rndr, __rndrrs intrinsics

stelios-arm marked 4 inline comments as done. stelios-arm added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:363 + if (HasRandGen) +Builder.defineMacro("__ARM_FEATURE_RNG", "1"); SjoerdMeijer wrote: > Where/when is `HasRandGen` set? Oh,

[PATCH] D98377: [clangd] Show padding following a field on field hover.

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. This displays as: `Size: 4 byte

[PATCH] D98375: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98375/new/ https://reviews.llvm.org/D98375 ___ c

[PATCH] D97085: [OpenMP] libomp: implement OpenMP 5.1 inoutset task dependence type

protze.joachim added a comment. Can you add the inoutset case to the ompt code as well? omp-tools.h already defines `ompt_dependence_type_inoutset`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97085/new/ https://reviews.llvm.org/D97085

[PATCH] D98375: [clang][Driver] Expose -fexperimental-relative-c++-abi-vtables flag

leonardchan created this revision. leonardchan added reviewers: phosek, mcgrathr. leonardchan added a project: clang. leonardchan requested review of this revision. Initially, this flag was meant to only be used through cc1 and not directly through the clang driver. However, we accidentally ended

[clang] 774b707 - Revert "Workaround a -Wmisleading-indentation warning"

Author: Stephen Kelly Date: 2021-03-10T23:35:41Z New Revision: 774b707564e1eed8fec5b5874d0aa82628de0651 URL: https://github.com/llvm/llvm-project/commit/774b707564e1eed8fec5b5874d0aa82628de0651 DIFF: https://github.com/llvm/llvm-project/commit/774b707564e1eed8fec5b5874d0aa82628de0651.diff LOG:

[clang] 14050dd - Revert "[AST] Add generator for source location introspection"

Author: Stephen Kelly Date: 2021-03-10T23:36:06Z New Revision: 14050ddc4080beb7a9143340be37ec05890cd537 URL: https://github.com/llvm/llvm-project/commit/14050ddc4080beb7a9143340be37ec05890cd537 DIFF: https://github.com/llvm/llvm-project/commit/14050ddc4080beb7a9143340be37ec05890cd537.diff LOG:

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis added a comment. In D97068#2617751 , @jroelofs wrote: > In D97068#2617642 , @ggeorgakoudis > wrote: > >> Add triple to avoid spurious failures in tests > > They're not really spurious, right... Doesn'

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis added a comment. In D97107#2617897 , @thakis wrote: > This breaks check-llvm on linux and mac: > http://45.33.8.238/linux/41398/step_12.txt > http://45.33.8.238/macm1/5291/step_10.txt > http://lab.llvm.org:8011/#/builders/109 > (and on my loc

[clang] 5c22e2b - Workaround a -Wmisleading-indentation warning

Author: Stephen Kelly Date: 2021-03-10T23:12:31Z New Revision: 5c22e2bec008760cc7078d8d14382ef4762c5d54 URL: https://github.com/llvm/llvm-project/commit/5c22e2bec008760cc7078d8d14382ef4762c5d54 DIFF: https://github.com/llvm/llvm-project/commit/5c22e2bec008760cc7078d8d14382ef4762c5d54.diff LOG:

[clang] ecf6897 - Revert "Replace func name with regex in update_cc_test_checks"

Author: Giorgis Georgakoudis Date: 2021-03-10T15:05:35-08:00 New Revision: ecf68972fd020cee80c5503bbe0f2028a184c8f3 URL: https://github.com/llvm/llvm-project/commit/ecf68972fd020cee80c5503bbe0f2028a184c8f3 DIFF: https://github.com/llvm/llvm-project/commit/ecf68972fd020cee80c5503bbe0f2028a184c8f

[clang] a89ac0d - Update __is_unsigned builtin to match the Standard.

Author: zoecarver Date: 2021-03-10T15:00:26-08:00 New Revision: a89ac0dd185d72607d4ee1356467fffc48711c9a URL: https://github.com/llvm/llvm-project/commit/a89ac0dd185d72607d4ee1356467fffc48711c9a DIFF: https://github.com/llvm/llvm-project/commit/a89ac0dd185d72607d4ee1356467fffc48711c9a.diff LOG

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa89ac0dd185d: Update __is_unsigned builtin to match the Standard. (authored by zoecarver). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D46443: [libc++] Add missing cstdalign header

hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > hubert.reinterpretcast wrote: > > curdeius wrote: > > > curdeius wrote: > > > > hubert.reinterpretcast wrote: > > > > > sbc10

[PATCH] D98242: [clangd] Store system relative includes as verbatim

sammccall added a comment. I measured this as a mild (3%) increase in preamble indexing time when working on clangd itself, more details in D98329 This regression could be more significant with a long include search path, so I'd like to avoid adding this withou

[PATCH] D93164: [AST] Add generator for source location introspection

steveire added a comment. @thakis Presumably you'll have to update the GN build now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 ___ cfe-commits mailing list

[PATCH] D98329: [clangd] Add cache for FID to Header mappings

sammccall added a comment. Some performance measurements... (workload is PreambleCallback for clangd/XRefs.cpp in sync mode with a fixed baseline of 99b01cf28db9db1a3ec0e25367bd325b7aca6d43 , opt build without asserts) baseli

[PATCH] D93164: [AST] Add generator for source location introspection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd627a27d264b: [AST] Add generator for source location introspection (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/

[clang] d627a27 - [AST] Add generator for source location introspection

Author: Stephen Kelly Date: 2021-03-10T22:38:39Z New Revision: d627a27d264b47eda3f15f086ff419dfe053ebf7 URL: https://github.com/llvm/llvm-project/commit/d627a27d264b47eda3f15f086ff419dfe053ebf7 DIFF: https://github.com/llvm/llvm-project/commit/d627a27d264b47eda3f15f086ff419dfe053ebf7.diff LOG:

[PATCH] D93164: [AST] Add generator for source location introspection

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. nit: A few reformat hints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164

[PATCH] D93164: [AST] Add generator for source location introspection

steveire marked 9 inline comments as done. steveire added inline comments. Comment at: clang/lib/Tooling/CMakeLists.txt:99 + NodeIntrospection.cpp + NodeIntrospection.inc Tooling.cpp njames93 wrote: > This shouldn't appear in the source list. We need to tell

[PATCH] D98371: [clangd] Group filename calculations in SymbolCollector, and cache mroe.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Also give CanonicalIncludes a less powerf

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

thakis added a comment. This breaks check-llvm on linux and mac: http://45.33.8.238/linux/41398/step_12.txt http://45.33.8.238/macm1/5291/step_10.txt http://lab.llvm.org:8011/#/builders/109 (and on my local build too) Please take a look, and please revert for now if it takes a while to fix. Rep

[PATCH] D97955: [clang-tidy] Refactor loop-convert to bring most of the checking into matchers

njames93 updated this revision to Diff 329765. njames93 marked an inline comment as done. njames93 added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97955/new/ https://reviews.llvm.org/D97955 Files: clang-tools-extra/clang-t

[PATCH] D97955: [clang-tidy] Refactor loop-convert to bring most of the checking into matchers

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:859 const auto *LoopVar = Nodes.getNodeAs(InitVarName); - const auto *EndVar = Nodes.getNodeAs(EndVarName); - - // If the loop c

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

jrtc27 added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:58-62 + bool IsPointer = false; + // IsConstant indices are "int", but have the constant expression. + bool IsImmediate = false; + // const qualifier. + bool IsConstant = false;

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM. I think we can address any remaining issues post-commit. I'd like to see us start adding the intrinsics that use this. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver updated this revision to Diff 329761. zoecarver added a comment. - Fix review comments: add colon, reflow line, and fix typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98104/new/ https://reviews.llvm.org/D98104 Files: clang/docs/La

[PATCH] D98104: Update __is_unsigned builtin to match the Standard.

zoecarver added a comment. Sorry for the delay in updating. All review comments have been addressed. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98104/new/ https://reviews.llvm.org/D98104 ___

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

rjmccall added inline comments. Comment at: clang/docs/MatrixTypes.rst:127 +is only supported for expression ``M1 / S1``, where ``M1`` is of matrix type +and ``S1`` is of a real type. You don't need to be so formal in this paragraph, because you're about to get

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 329759. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D98214: [clang-format] Fix aligning with linebreaks

HazardyKnusperkeks updated this revision to Diff 329755. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. - Addressed comments - Fixed handling of continued string literals when aligning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov added a comment. In D96090#261 , @steakhal wrote: > You could still pass a default constructed QualType at each callsite. We can try. At least it will be like this is a hack for the particular cases then, that will emphesys to pay atten

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf58d6a1f922: Replace func name with regex in update_cc_test_checks (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] bf58d6a - Replace func name with regex in update_cc_test_checks

Author: Giorgis Georgakoudis Date: 2021-03-10T12:57:35-08:00 New Revision: bf58d6a1f92244c797a280d318a56d7d3fc4a704 URL: https://github.com/llvm/llvm-project/commit/bf58d6a1f92244c797a280d318a56d7d3fc4a704 DIFF: https://github.com/llvm/llvm-project/commit/bf58d6a1f92244c797a280d318a56d7d3fc4a70

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

jroelofs added a comment. In D97068#2617642 , @ggeorgakoudis wrote: > Add triple to avoid spurious failures in tests They're not really spurious, right... Doesn't this mean that `utils/update_cc_test_checks.py` is now broken for people who develop on a

[PATCH] D97107: Replace func name with regex in update_cc_test_checks

ggeorgakoudis updated this revision to Diff 329747. ggeorgakoudis added a comment. Add triple in test to avoid spurious failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97107/new/ https://reviews.llvm.org/D97107 Files: clang/test/utils/upd

[PATCH] D97955: [clang-tidy] Refactor loop-convert to bring most of the checking into matchers

steveire added a comment. Good progress! This check also implements its own `StmtAncestorASTVisitor` which should probably be removed in favor of the `ParentMapContext` eventually (not in this patch). Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:118

[PATCH] D97687: [SEH] Fix capture of this in lambda functions

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97687/new/ https://reviews.llvm.org/D97687 ___ cfe-com

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 329737. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 added a comment. Thank you so much for this experiment @awarzynski . I will modify the code accordingly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97080/new/ https://reviews.llvm.org/D97080 ___ cfe-commits mailing list cfe-com

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa2abe2259c2d: Run non-filechecked commands in update_cc_test_checks.py (authored by ggeorgakoudis). Repository: rG LLVM Github Monorepo CHANGES S

[clang] a2abe22 - Run non-filechecked commands in update_cc_test_checks.py

Author: Giorgis Georgakoudis Date: 2021-03-10T12:25:35-08:00 New Revision: a2abe2259c2d5b8c494f3513b840adf1572b21bc URL: https://github.com/llvm/llvm-project/commit/a2abe2259c2d5b8c494f3513b840adf1572b21bc DIFF: https://github.com/llvm/llvm-project/commit/a2abe2259c2d5b8c494f3513b840adf1572b21b

[PATCH] D93164: [AST] Add generator for source location introspection

steveire updated this revision to Diff 329735. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/include/clang/Tooling/NodeIntrospection.h clang/lib/Tooling/C

[PATCH] D97068: Run non-filechecked commands in update_cc_test_checks.py

ggeorgakoudis updated this revision to Diff 329734. ggeorgakoudis added a comment. Add triple to avoid spurious failures in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97068/new/ https://reviews.llvm.org/D97068 Files: clang/test/utils/up

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:16134 if (Subtarget.hasPrefixInstrs()) { - // With prefixed instructions, we can materialize anything that can be - // represented with a 32-bit immediate, not just positive zero. -

[PATCH] D98237: [clang-format] Option for empty lines after an access modifier.

HazardyKnusperkeks added a comment. Please also add an entry in the `clang/doc/ReleaseNotes.rst`. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:1284 (!PreviousLine->InPPDirective || !RootToken.HasUnescapedNewline)) -Newlines = std::min(1u, Newlines); +N

[PATCH] D98061: [InstrProfiling] Generate runtime hook for ELF platforms

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks for the detailed explanation of the -fprofile-list workflow; given the difference constraints, this patch lgtm. Please document the divergent behavior re: no .profraw file when #counters == 0

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

awarzynski added a comment. In D97080#2613628 , @awarzynski wrote: > **Question**: What are the semantics for this flag in `gfortran`? Is the path > specified with `-fintrinsics-module-path` _prepended_ or _appended_ to the > default search path? I beli

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

vsk added a comment. In D98135#2615492 , @MaskRay wrote: > LG, but I hope an OpenMP expert can take a look. Perhaps @vsk can comment on > where the tests should be improved (currently we hardly have any > `@llvm.instrprof.increment` IR test for clang -fp

[PATCH] D96850: [clang] Add -ffinite-loops & -fno-finite-loops options.

fhahn abandoned this revision. fhahn added a comment. those have been picked onto 12.x Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96850/new/ https://reviews.llvm.org/D96850 ___ cfe-commits mailing lis

[PATCH] D93938: [clang-format] Fixed AfterEnum handling

HazardyKnusperkeks added a comment. In D93938#2616044 , @atirit wrote: > In D93938#2614825 , > @HazardyKnusperkeks wrote: > >> If the bugs are (very) similar, I could live with one fix for both. >> Otherwise you s

[PATCH] D98364: [clangd] Use ref counted strings throughout for File Contents

njames93 added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:195-198 void addDocument(PathRef File, StringRef Contents, llvm::StringRef Version = "null", WantDiagnostics WD = WantDiagnostics::Auto,

[PATCH] D98364: [clangd] Use ref counted strings throughout for File Contents

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman, javed.absar. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

NoQ added a comment. > I can see that it adds many visitors to the `BugReport` passed to it. Yes and some of these visitors will call `trackExpressionValue()` again in their `Visit...()` functions which corresponds to adding visitors in the middle of visitation which is arguably the most intere

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

everton.constantino added inline comments. Comment at: clang/test/CodeGen/matrix-type-operators.c:303 } +// CHECK-LABEL: @divide_double_matrix_scalar_float( fhahn wrote: > everton.constantino wrote: > > Shouldn't a test for half floating point be added here as

[PATCH] D98363: [Sema] Fold VLA types in compound literals to constant arrays.

efriedma created this revision. efriedma added reviewers: rsmith, erik.pilkington, aaron.ballman. efriedma requested review of this revision. Herald added a project: clang. Similar to variables with an initializer, this is never valid in standard C, so we can safely constant-fold as an extension.

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

Gerolf added a comment. Nice! This is a straightforward extension with minor code clean-up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97857/new/ https://reviews.llvm.org/D97857 ___ cfe-commits mailin

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98135/new/ https://reviews.llvm.org/D98135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind added a comment. In D98135#2617448 , @ABataev wrote: > In D98135#2617446 , @lxfind wrote: > >> In D98135#2617432 , @ABataev wrote: >> >>> There is a problem. We actual

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

cchen accepted this revision. cchen added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98358/new/ https://reviews.llvm.org/D98358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

beanz added a comment. This should not impact the Apple Clang releases since those are always clean builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98291/new/ https://reviews.llvm.org/D98291 ___ c

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. In D98135#2617446 , @lxfind wrote: > In D98135#2617432 , @ABataev wrote: > >> There is a problem. We actually do not emit `S` here directly, instead, we >> use `CodeGen` lambdas, which may

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind added a comment. In D98135#2617432 , @ABataev wrote: > There is a problem. We actually do not emit `S` here directly, instead, we > use `CodeGen` lambdas, which may not be equal to `S`, in some cases `S` is > `nullptr` here. It may result in not q

[PATCH] D97183: [analyzer] Add NoteTag for smart-ptr get()

RedDocMD added a comment. @NoQ, looking through the source code of `trackExpressionValue` I can see that it adds many visitors to the `BugReport` passed to it. That I believe is the recursive attachment of visitors you described above. So, as far as I understood, I have to make changes in this f

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

ABataev added a comment. There is a problem. We actually do not emit `S` here directly, instead, we use `CodeGen` lambdas, which may not be equal to `S`, in some cases `S` is `nullptr` here. It may result in not quite accurate results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D94622: [clang-tidy] add concurrency-async-no-new-threads

segoon added a comment. It seems that the related file structure (IOW, "separated coroutine code and non-coroutine code" rule) is indeed specific to Yandex.Taxi. I asked multiple developers in different companies and no one could confirm they align with the rule. The checks in the current form

[PATCH] D94355: [Passes] Add relative lookup table converter pass

leonardchan added a comment. One thing that just occurred to me: do we also perhaps want to hide this behind a flag? Right now it's being added to various default optimization pipelines, so some users might be surprised if they suddenly see their lookup tables change (either compiler or user ge

[PATCH] D96280: [clang][cli] Round-trip the whole CompilerInvocation

alanphipps added a comment. In D96280#2611651 , @alanphipps wrote: > We also encounter a build failure on the Mac related to above but in a > different file: > clang/lib/CodeGen/CGStmtOpenMP.cpp:1916:3: error: too few template arguments > for class templ

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

alanphipps added a comment. In D94973#2617304 , @Meinersbur wrote: > Is is that same problem that D98265 > addresses? Yes, that appears to be the same. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D98358: [OpenMP] Restore backwards compatibility for libomptarget

jhuber6 updated this revision to Diff 329709. jhuber6 added a comment. Updating tests and adding the new function to the exports. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98358/new/ https://reviews.llvm.org/D98358 Files: clang/lib/CodeGen/C

[PATCH] D97872: [clang] Don't assert in EmitAggregateCopy on trivial_abi types

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8227f06b335: [clang] Don't assert in EmitAggregateCopy on trivial_abi types (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97872/new/

[clang] c8227f0 - [clang] Don't assert in EmitAggregateCopy on trivial_abi types

Author: Arthur Eubanks Date: 2021-03-10T10:16:06-08:00 New Revision: c8227f06b3356cdc9cc757ddfb59a6d8ad89 URL: https://github.com/llvm/llvm-project/commit/c8227f06b3356cdc9cc757ddfb59a6d8ad89 DIFF: https://github.com/llvm/llvm-project/commit/c8227f06b3356cdc9cc757ddfb59a6d8ad89.diff

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. Is is that same problem that D98265 addresses? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94973/new/ https://reviews.llvm.org/D94973 ___ c

[PATCH] D98193: [CUDA][HIP] Allow non-ODR use of host var in device

tra added a reviewer: rsmith. tra added a subscriber: rsmith. tra added a comment. LGTM I've added @rsmith to double check that we're handling it correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98193/new/ https://reviews.llvm.org/D98193 ___

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

delcypher added a comment. In D98291#2616865 , @kubamracek wrote: > Looks good! > > By the way, Apple Clang releases also build compiler-rt this way, so it would > be worth checking with @arphaman that he's okay with the change. @kubamracek @arphaman Ah

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

ASDenysPetrov updated this revision to Diff 329699. ASDenysPetrov edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96090/new/ https://reviews.llvm.org/D96090 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValBuilder.h clang/include/cla

[PATCH] D98291: [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa159f91c8d06: [compiler-rt] Fix stale incremental builds when using… (authored by delcypher). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added a comment. In D89909#2606180 , @Anastasia wrote: > In D89909#2600859 , @aaron.ballman > wrote: > >> Just a few minor nits from me, but I'm mostly wondering: where are we at >> with this and are there s

[clang] a159f91 - [compiler-rt] Fix stale incremental builds when using `LLVM_BUILD_EXTERNAL_COMPILER_RT=ON`.

Author: Dan Liew Date: 2021-03-10T09:42:24-08:00 New Revision: a159f91c8d068cae660a200868b7fc28fcbcd3ff URL: https://github.com/llvm/llvm-project/commit/a159f91c8d068cae660a200868b7fc28fcbcd3ff DIFF: https://github.com/llvm/llvm-project/commit/a159f91c8d068cae660a200868b7fc28fcbcd3ff.diff LOG:

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

alanphipps added a comment. Hello! I am seeing a downstream build failure on Mac as a result of your changes: clang/lib/CodeGen/CGStmtOpenMP.cpp:1916:3: error: too few template arguments for class template 'SmallVector' SmallVector EffectiveArgs; ^ clang/include/clang/Basic/LLVM.h:35:42

[PATCH] D98135: [OpenMP][InstrProfiling] Fix a missing instr profiling counter

lxfind added a comment. Thanks. I am landing it. But feel free to comment here if anything isn't right. @ABataev Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98135/new/ https://reviews.llvm.org/D98135

  1   2   3   >