[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng updated this revision to Diff 328040. kito-cheng added a comment. Minor clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97916/new/ https://reviews.llvm.org/D97916 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clan

[PATCH] D97916: [Driver][RISCV] Support parsing multi-lib config from GCC.

kito-cheng created this revision. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, niosHD, sabuasal, simoncook, johnrusso,

[PATCH] D97912: [doc] Document that __fp16 will apply default argument promotion rule.

kito-cheng added a comment. Update SUMMARY, first version I just incorrectly said ACLE didn't clarify the default argument promotion rule, but I found that in ABI spec later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97912/new/ https://reviews

[PATCH] D92815: [PowerPC] [Clang] Enable float128 feature on VSX targets

steven.zhang accepted this revision. steven.zhang added a comment. LGTM now. But please hold on for at least one week to see if @nemanjai has concern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92815/new/ https://reviews.llvm.org/D92815 __

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen added a comment. I didn't add any new tests. Instead, added checks for the new code sequence: 1. check that `llvm.assume` is there to make sure the adjusted address is correctly aligned. 2. check that `llvm.coro.align` and the associated instructions are there to over-allocate heap memory

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen updated this revision to Diff 328036. ychen added a comment. Herald added a subscriber: jdoerfert. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97915/new/ https://reviews.llvm.org/D97915 Files: clang/lib/CodeGen/CGBuiltin.cpp c

[PATCH] D97915: [Coroutines] Handle overaligned frame allocation

ychen created this revision. ychen added reviewers: rjmccall, lxfind, GorNishanov. Herald added a subscriber: hiraditya. ychen requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. by over-allocating and emitting `alignTo` code

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cf

[PATCH] D97912: [doc] Document that __fp16 will apply default argument promotion rule.

kito-cheng created this revision. kito-cheng requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ACLE didn't specify the default argument promotion rule on __fp16, but the current implementation both on GCC and clang are applied default argumen

[PATCH] D93377: [Clang] Add __ibm128 type to represent ppc_fp128

qiucf added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2245 + case tok::kw___ibm128: +DS.SetTypeSpecType(DeclSpec::TST_ibm128, Loc, PrevSpec, DiagID, Policy); +break; hubert.reinterpretcast wrote: > qiucf wrote: > > hubert.reinterpretc

[PATCH] D97759: [doc] Fix description of _Float16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb46a1b129f68: [doc] Fix description of _Float16 (authored by Kito Cheng ). Herald added a subscriber: cfe-commits. Changed pr

[clang] b46a1b1 - [doc] Fix description of _Float16

Author: Kito Cheng Date: 2021-03-04T14:17:54+08:00 New Revision: b46a1b129f684a230dd680341d198d8b11731812 URL: https://github.com/llvm/llvm-project/commit/b46a1b129f684a230dd680341d198d8b11731812 DIFF: https://github.com/llvm/llvm-project/commit/b46a1b129f684a230dd680341d198d8b11731812.diff LO

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Module.h:97 + /// Called by auxilary threads as diagnostics encountered to generate fixes. + /// So this can be called concurrently from multiple threads. If a module This seems too special

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

sammccall added a comment. Will the fixes/actions this enables really be available synchronously? AFAIK the only reasons we attach fixes to diagnostics are: - because clang fixes are generated at parse time and need to be stored somewhere - for the benefit of embedders that need the fix content

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks (both for the patch and bearing with me :D), LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.org/

[PATCH] D97548: [clangd] Introduce client state invalidation

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdServer.h:78 + +/// Called when server triggers a state change without client requesting it. +/// For example a p

[libclc] 21427b8 - libclc: Add clspv target to libclc

Author: Alan Baker Date: 2021-03-04T00:19:10-05:00 New Revision: 21427b8eb8e773789bdb4cd8911bee6631910a37 URL: https://github.com/llvm/llvm-project/commit/21427b8eb8e773789bdb4cd8911bee6631910a37 DIFF: https://github.com/llvm/llvm-project/commit/21427b8eb8e773789bdb4cd8911bee6631910a37.diff LO

[PATCH] D97548: [clangd] Introduce client state invalidation

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97548/new/ https://reviews.llvm.org/D97548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D97555: [clangd] Add diagnostic augmentation hook to Modules

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97555/new/ https://reviews.llvm.org/D97555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D96245: [clangd] Propagate CodeActions in addition to Fixes for diagnostics

kadircet added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96245/new/ https://reviews.llvm.org/D96245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D96709: Add Windows ehcont section support (/guard:ehcont).

This revision was automatically updated to reflect the committed changes. Closed by commit rGe7e67c930ae5: Add Windows ehcont section support (/guard:ehcont). (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96709/new/ https://re

[clang] e7e67c9 - Add Windows ehcont section support (/guard:ehcont).

Author: Wang, Pengfei Date: 2021-03-04T11:47:29+08:00 New Revision: e7e67c930ae59151affcd57bd49d650e4dac3468 URL: https://github.com/llvm/llvm-project/commit/e7e67c930ae59151affcd57bd49d650e4dac3468 DIFF: https://github.com/llvm/llvm-project/commit/e7e67c930ae59151affcd57bd49d650e4dac3468.diff

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

plotfi added a comment. @jkorous thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97878/new/ https://reviews.llvm.org/D97878 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

plotfi accepted this revision. plotfi added a comment. This revision is now accepted and ready to land. This makes sense to me. I approve. Can we move the 3/60 seconds number to a const int value set somewhere higher up in the file as a global with a comment explaining this as well? Repository

[PATCH] D97669: [clang][AVR] Add avr-libc/include to clang system include paths

benshi001 added a comment. Although the bug can be avoided via "-I /usr/lib/avr/include" in clang's command line option, I expect clang to have the save behaviour as avr-gcc. And for avr-gcc, `avr-gcc a.c -mmcu=xxx` will automatically include avr-libc's header files and link avr-libc's lib.

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

NoQ added a comment. So, like, I think it's a start. You introduced a single source of truth for casting `SVal`s and it's good. But i'm worried about our API surface. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:539 -SVal SValBuilder::evalCast(SVal V, QualType C

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

MaskRay added a subscriber: aaron.ballman. MaskRay added a comment. This is motivated by Linux kernel folks' confusion on `--gcc-toolchain` https://lore.kernel.org/linux-kbuild/20210303230708.l6pbk5o5nc2qa...@google.com/ (it confused me, even if I had stared at this piece code a few times before!

[PATCH] D97902: [Driver] Clarify --gcc-toolchain

MaskRay created this revision. MaskRay added reviewers: nathanchance, nickdesaulniers. Herald added subscribers: jansvoboda11, dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. And add tests: when both --prefix(-B) and --gcc-too

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7229 + case Builtin::BI__builtin_isfinite: +Invert = true; +LLVM_FALLTHROUGH; What are these variants all about...? CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D96090: [analyzer] Replace StoreManager::CastRetrievedVal with SValBuilder::evalCast

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:539 -SVal SValBuilder::evalCast(SVal V, QualType CastTy, QualType OriginalTy) { - CastTy = Context.getCanonicalType(CastTy); - OriginalTy = Context.getCanonicalType(OriginalTy); - if (CastTy

[PATCH] D97901: [SystemZ] Test for infinity in testFPKind().

jonpa created this revision. jonpa added reviewers: uweigand, thopre. jonpa requested review of this revision. Recognize __builtin_isinf and BI__builtin_isfinite (and a few other builtin opcodes for finite checks) in testFPKind(). TDC can check for infinity, and for finite with an inversion of t

[PATCH] D95799: [analyzer] Symbolicate float values with integral casting

NoQ added a comment. > tiny patch IIUC this is roughly the first time ever when `SValBuilder` starts emitting symbols of float type. This is a huge change with an almost unlimited scope of unexpected side effects and very rigorous testing is required to understand the actual effect of this pat

[PATCH] D96586: [analyzer][CTU][NFC] Add an extra regression test

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > `-analyzer-opt-analyze-headers` I'm actually shocked that we provide such option at all. And that it's the first option in the list in `scan-build --help`. And that I haven't noticed it until now

[PATCH] D97896: [Clang][RISCV][RFC] Add byval parameter attribute?

luismarques created this revision. luismarques added reviewers: asb, mundaym. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng

[PATCH] D97699: [analyzer] Add InvalidPtrChecker

NoQ added a comment. CERT rules are typically very vague and don't map nicely into specific static analysis algorithms. A lot of CERT rules flag valid code as well as bugs. I want you to explain what *exactly* does the checker checks (say, in the form of a state machine, i.e. what //sequences o

[PATCH] D97826: [RISCV] Make use of the required features in BuiltinInfo to store that V extension builtins require 'experimental-v'.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG201ebf211f97: [RISCV] Make use of the required features in BuiltinInfo to store that V… (authored by craig.topper). Changed prior to commit: https

[clang] 201ebf2 - [RISCV] Make use of the required features in BuiltinInfo to store that V extension builtins require 'experimental-v'.

Author: Craig Topper Date: 2021-03-03T16:24:08-08:00 New Revision: 201ebf211f9772ef19abac82170b9b06fe2ccf2b URL: https://github.com/llvm/llvm-project/commit/201ebf211f9772ef19abac82170b9b06fe2ccf2b DIFF: https://github.com/llvm/llvm-project/commit/201ebf211f9772ef19abac82170b9b06fe2ccf2b.diff

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

MaskRay added a comment. Thanks. This looks just looks me untested and likely uneeded logic. My notes about --gcc-toolchain= and --prefix (-B) https://lore.kernel.org/linux-kbuild/20210303230708.l6pbk5o5nc2qa...@google.com/ In the presence of --gcc-toolchain= (even if it equals `$prefix/usr`),

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

manojgupta added a comment. Thanks @MaskRay for this clean up. I can't speak for all of Gentoo but please give me a couple of days to at least test this on Chrome OS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97894/new/ https://reviews.llvm.or

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG584cb67d2df3: [IRSymTab] Set FB_used on llvm.compiler.used symbols (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D97755

[clang] 584cb67 - [IRSymTab] Set FB_used on llvm.compiler.used symbols

Author: Fangrui Song Date: 2021-03-03T16:22:30-08:00 New Revision: 584cb67d2df32163efe61cfa58b3c798ee5b6b5c URL: https://github.com/llvm/llvm-project/commit/584cb67d2df32163efe61cfa58b3c798ee5b6b5c DIFF: https://github.com/llvm/llvm-project/commit/584cb67d2df32163efe61cfa58b3c798ee5b6b5c.diff

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

MaskRay updated this revision to Diff 327958. MaskRay edited the summary of this revision. MaskRay added a comment. Add llvm-nm checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97755/new/ https://reviews.llvm.org/D97755 Files: clang/test/Cod

[PATCH] D97823: [AIX] Update default arch on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b274ed49960: [AIX] Update default arch on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm with change suggested below. Thanks! Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:10 + +//--- a.c +const char *ref() { MaskRay wrote: > te

[clang] 0b274ed - [AIX] Update default arch on AIX

Author: Steven Wan Date: 2021-03-03T19:07:43-05:00 New Revision: 0b274ed499603d30694c0b995252ab014609acf9 URL: https://github.com/llvm/llvm-project/commit/0b274ed499603d30694c0b995252ab014609acf9 DIFF: https://github.com/llvm/llvm-project/commit/0b274ed499603d30694c0b995252ab014609acf9.diff LO

[PATCH] D97894: [Driver] Drop $sysroot/usr special case from Gentoo gcc-config detection

MaskRay created this revision. MaskRay added reviewers: mgorny, manojgupta. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97894 Files: clang/lib/Driver/ToolChains

[PATCH] D97388: [analyzer] Replace StoreManager::evalIntegralCast with SValBuilder::evalCast

NoQ added a comment. That's definitely an improvement for our API surface. I think this is good but like @steakhal said I recommend running on a large codebase looking for potential regressions because this code is (still) very much spaghetti and hard to reason about. CHANGES SINCE LAST ACTIO

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp:877-879 + std::tie(IsZero, IsNotZero) = + getStateManager().getConstraintManager().isSymValWithinOrOutsideRange( + State, SE, Zero, Zero); What was wr

[PATCH] D97826: [RISCV] Make use of the required features in BuiltinInfo to store that V extension builtins require 'experimental-v'.

HsiangKai accepted this revision. HsiangKai added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97826/new/ https://reviews.llvm.org/D97826 __

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

MaskRay added inline comments. Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:10 + +//--- a.c +const char *ref() { tejohnson wrote: > Is this other file needed for the test? This is test the limitation. If we fix the tracking for inline asm references (thi

[PATCH] D97457: [flang][driver] Add `-fdebug-dump-parsing-log`

ashermancinelli added a comment. It //is// unintuitive to me that we are mixing feature and action flags, however I don't have a better suggestion. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97457/new/ https://reviews.llvm.org/D97457 ___

[PATCH] D97512: [clang] removes check against integral-to-pointer conversion...

cjdb added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:10326 + !isa( + Cast->getSubExpr()->IgnoreImplicitAsWritten()->IgnoreParens())) +return; thakis wrote: > cjdb wrote: > > cjdb wrote: > > > aaron.ballman wrote: > > > > I'm n

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

tejohnson added inline comments. Comment at: clang/test/CodeGen/thinlto-inline-asm2.c:10 + +//--- a.c +const char *ref() { Is this other file needed for the test? Comment at: llvm/test/ThinLTO/X86/asm.ll:11 +; NM-NOT: {{.}} +; NM: -

[PATCH] D97889: [clang-tidy] Fix assert in modernize-loop-convert

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added subscribers: usaxena95, kadircet, xazax.hun. njames93 requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. I'm unable to figure out a reproducti

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

Meinersbur added a comment. In D94973#2591493 , @jdenny wrote: >> I even think that representing semantic information alongside of syntax is >> one of the principles of Clang's AST. > > Interesting. Is that documented somewhere? https://clang.llvm.org/d

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau updated this revision to Diff 327923. qchateau added a comment. fix bad arc diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97417/new/ https://reviews.llvm.org/D97417 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau updated this revision to Diff 327922. qchateau added a comment. rebase on main, fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97417/new/ https://reviews.llvm.org/D97417 Files: clang-tools-extra/clangd/TUScheduler.cpp In

[PATCH] D97805: [clang-query] Add option to enable only displaying main file matches

njames93 updated this revision to Diff 327921. njames93 added a comment. Change default match mode to include all files. Update so the prompt to switch match mode is only displayed once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97805/new/ http

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia added a comment. In D96771#2574638 , @awarzynski wrote: > In D96771#2571855 , @Anastasia wrote: > >> This is only the initial patch and for the moment the primary goal is to >> remove the need for the fla

[PATCH] D97687: [SEH] Fix capture of this in lambda functions

ogoffart added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97687/new/ https://reviews.llvm.org/D97687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.attachedcall' instead of explicitly emitting retainRV or claimRV calls in the IR

fhahn added a comment. In D92808#2600245 , @hans wrote: > Reverted in > https://github.com/llvm/llvm-project/commit/0a5dd067181dac2a8882a139ea3bd19bdea5fa44 > until this can be fixed. Thanks! I pushed a fix for the issue in 75805dce5ff8

[PATCH] D96771: [OpenCL] Add distinct file extension for C++ for OpenCL

Anastasia updated this revision to Diff 327915. Anastasia added a comment. Herald added subscribers: kbarton, nemanjai. - Renamed extensions to `cppcl` as it was more popular in RFC - Minimized number of changes in driver setup - Changed file extension in all C++ for OpenCL tests CHANGES SINCE L

[PATCH] D96033: [clang-repl] Land initial infrastructure for incremental parsing

rsmith added inline comments. Comment at: clang/test/Interpreter/execute.c:1 +// RUN: cat %s | clang-repl | FileCheck %s + Presumably here (and in all the interpreter tests) we will need to check that we configured Clang and LLVM so that they can actually JIT co

[PATCH] D97755: [IRSymTab] Set FB_used on llvm.compiler.used symbols

MaskRay updated this revision to Diff 327909. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a clang/test/CodeGen/ test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97755/new/ https://reviews.ll

[clang] eec7f8f - [WebAssembly] Add missing default cases in switch statements

Author: Soumi Manna Date: 2021-03-03T13:15:23-08:00 New Revision: eec7f8f7b1226be422a76542cb403d02538f453a URL: https://github.com/llvm/llvm-project/commit/eec7f8f7b1226be422a76542cb403d02538f453a DIFF: https://github.com/llvm/llvm-project/commit/eec7f8f7b1226be422a76542cb403d02538f453a.diff L

[PATCH] D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 327898. DiggerLin added a comment. modify a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89986/new/ https://reviews.llvm.org/D89986 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D96709: Add Windows ehcont section support (/guard:ehcont).

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/MSVC.cpp:499 CmdArgs.push_back("-guard:cf-"); +} else if (GuardArgs.equals_lower("ehcont")) { + CmdArgs.push_back("/guard:ehcont"); pengfei wrote: > rnk wrote: > > This is gone now

[PATCH] D97824: [ObjC][ARC] Don't add operand bundle `clang.arc.attachedcall` to a call if the call already has the operand bundle

ahatanak updated this revision to Diff 327888. ahatanak added a comment. Emit a call to `@llvm.objc.retain` instead of a call to `@llvm.objc.retainAutoreleasedReturnValue`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97824/new/ https://reviews.l

[PATCH] D97878: [DirectoryWatcher] Increase timeout to make test less flaky

smeenai created this revision. smeenai added reviewers: jkorous, arphaman, akyrtzi, gribozavr. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We've observed this test being significantly flaky on our Mac CI machines when we're runn

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

dschuff accepted this revision. dschuff added a comment. I agree this is a good approach, and I also like that it's smaller and simpler. In the future we can revisit whether following this particular Itanium convention buys us anything useful or not. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D97824: [ObjC][ARC] Don't add operand bundle `clang.arc.attachedcall` to a call if the call already has the operand bundle

ahatanak planned changes to this revision. ahatanak added a comment. On second thought, I think we should emit a call to `@llvm.objc.retain` instead of a call to `@llvm.objc.retainAutoreleasedReturnValue`. I think we might want to remove ARC optimizer's code that converts calls to `@llvm.objc.r

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2d7374a0c680: [Coverage] Emit gap region between statements if first statements contains… (authored by zequanwu). Repository: rG LLVM Github Monor

[clang] 2d7374a - [Coverage] Emit gap region between statements if first statements contains terminate statements.

Author: Zequan Wu Date: 2021-03-03T11:25:49-08:00 New Revision: 2d7374a0c680f96bdcdb3d05034a93bf145d140f URL: https://github.com/llvm/llvm-project/commit/2d7374a0c680f96bdcdb3d05034a93bf145d140f DIFF: https://github.com/llvm/llvm-project/commit/2d7374a0c680f96bdcdb3d05034a93bf145d140f.diff LOG

[PATCH] D97617: [clangd] ObjC fixes for semantic highlighting and xref highlights

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d2fba8ddb90: [clangd] ObjC fixes for semantic highlighting and xref highlights (authored by sammccall). Repository: rG LLVM Github Monorepo CHAN

[clang-tools-extra] 7d2fba8 - [clangd] ObjC fixes for semantic highlighting and xref highlights

Author: Sam McCall Date: 2021-03-03T20:16:08+01:00 New Revision: 7d2fba8ddb90cf018d9cfc852b68e4584b15678e URL: https://github.com/llvm/llvm-project/commit/7d2fba8ddb90cf018d9cfc852b68e4584b15678e DIFF: https://github.com/llvm/llvm-project/commit/7d2fba8ddb90cf018d9cfc852b68e4584b15678e.diff LO

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

zequanwu added a comment. Thanks for reviewing. Comment at: clang/test/CoverageMapping/switch.cpp:62 default: // CHECK-NEXT: File 0, [[@LINE]]:3 -> [[@LINE+1]]:10 = #4 break; // CHECK-NEXT: Branch,File 0, [[@LINE-1]]:3 -> [[@LINE-1]]:10 = #4, (#0 - #4

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

zequanwu updated this revision to Diff 327859. zequanwu added a comment. use itanium abi in terminate-statements.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97101/new/ https://reviews.llvm.org/D97101 Files: clang/lib/CodeGen/CoverageMappin

[PATCH] D97819: [CMake] Enable Polly for Fuchsia toolchain build

Meinersbur added a comment. As a contributor to Polly, this makes me happy to see ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97819/new/ https://reviews.llvm.org/D97819 ___ cfe-commits mailing list

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX updated this revision to Diff 327853. ArcsinX added a comment. - use URIs as keys - create the file list from the keys Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.org/D97535 Files: clang-tools-extra/clan

[PATCH] D97834: [WebAssembly] Disable uses of __clang_call_terminate

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. Nice, this actually looks like a good simplification in addition to fixing the specific problem. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4650 + // Itanium ABI cal

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. So, what could be the futur of that patch? Would that be okay to merge with a `target_abi` Clang attribute? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 ___

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I don't think we have any tests that explicitly use valgrind and testing with valgrind enabled is an optional thing. I would be fine landing this as-is without a test case if it

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

aaron.ballman added a comment. Just a few minor nits from me, but I'm mostly wondering: where are we at with this and are there still substantive changes required? (I looked through the comments, but there's a lot of back-and-forth since Oct and I'm not certain what's holding the patch back cur

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

martong added a comment. In D97849#2600300 , @teemperor wrote: > We can (and do) run LIT tests under valgrind, so if you have a test that > triggers this valgrind error then that seems like the way to go. I don't > think the test has to deterministically

[PATCH] D97849: [AST][PCH][ASTImporter] Fix UB caused by uninited SwitchStmt member

martong added a comment. In D97849#2600220 , @steakhal wrote: > In D97849#2600201 , @aaron.ballman > wrote: > >> This looks reasonable to me (good catch!), but is there a way for us to add >> a regression test for

[PATCH] D97874: [analyzer] Improve SVal cast from integer to bool using known RangeSet

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: steakhal, NoQ, xazax.hun, vsavchenko, Eugene.Zelenko. ASDenysPetrov added a project: clang. Herald added subscribers: martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftw

[PATCH] D97872: [clang] Don't assert in EmitAggregateCopy on trivial_abi types

aeubanks created this revision. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes PR42961. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97872 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGenC

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap updated this revision to Diff 327839. Conanap added a comment. Updated 2 test cases and some nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h lld/ELF/Driver.cpp lld/ELF/Options.td lld/ELF/Thunks.cpp

[PATCH] D97871: Update diagnostic groups for pre-compat warnings

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. As a follow-up to D95691 , add new diagnostic groups named `pre-c++N-compat` to replace the old di

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. I tested this with `FLANG_BUILD_NEW_DRIVER` set to`On` and `Off` - all works fine. It's been a tricky patch @arnamoy10 , thank you for all the effort! I believe that you've addressed a

[PATCH] D97101: [Coverage] Emit gap region between statements if first statements contains terminate statements.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, this looks great. Comment at: clang/test/CoverageMapping/switch.cpp:62 default: // CHECK-NEXT: File 0, [[@LINE]]:3 -> [[@LINE+1]]:10 = #4 break; /

[PATCH] D97823: Update default arch on AIX

stevewan updated this revision to Diff 327825. stevewan added a comment. Reflect varible is unused in its name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97823/new/ https://reviews.llvm.org/D97823 Files: clang/lib/Driver/ToolChains/CommonArg

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

Anastasia added a comment. If possible to add a fragment of what is generated it would be great! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97869/new/ https://reviews.llvm.org/D97869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D97058: [OpenCL] Refactor diagnostic for OpenCL extension/feature

Anastasia added a comment. In D97058#2600160 , @azabaznov wrote: > Check 'isEnabled' is now private: it is used only for non-core or > non-optional core features; > creation of implicit type definitions is guarder with extension support > check; minor re

[PATCH] D97869: [OpenCL][Draft] Add OpenCL builtin test generator

svenvh created this revision. svenvh added reviewers: Anastasia, azabaznov. Herald added subscribers: jfb, yaxunl. svenvh requested review of this revision. Add a new clang-tblgen flag `-gen-clang-opencl-builtin-tests` that generates a .cl file containing calls to every builtin function defined in

[PATCH] D97823: Update default arch on AIX

jsji accepted this revision. jsji added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); stevewan wrote: > jsji wrote: > > `micro`

[PATCH] D97857: [Matrix] Add support for matrix-by-scalar division.

everton.constantino added inline comments. Comment at: clang/test/CodeGen/matrix-type-operators.c:303 } +// CHECK-LABEL: @divide_double_matrix_scalar_float( Shouldn't a test for half floating point be added here as well? Repository: rG LLVM Github Monorep

[PATCH] D97823: Update default arch on AIX

stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:403 +if (T.isOSAIX()) { + unsigned major, minor, micro; + T.getOSVersion(major, minor, micro); jsji wrote: > `micro` unsed. Sorry I missed this comment. I agree t

[PATCH] D95745: Support unwinding from inline assembly

cynecx added a comment. Weekly ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95745/new/ https://reviews.llvm.org/D95745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D97854: [RFC][nsan] A Floating-point numerical sanitizer.

courbet added a comment. When bootstrapping LLVM with nsan, there are only a few issues. Several of them stem from using `double` to measure elapsed time in seconds: We measure start time, end time, and subtract them. The resulting error depends on the arbitrary magnitude of the time since epoc

  1   2   >