[PATCH] D14982: ARM v8.1a adds Advanced SIMD instructions for Rounding Double Multiply Add/Subtract.

pengbins added inline comments. Herald added a subscriber: kristof.beyls. Comment at: cfe/trunk/include/clang/Basic/arm_neon.td:377 +def OP_QRDMLAH : Op<(call "vqadd", $p0, (call "vqrdmulh", $p1, $p2))>; +def OP_QRDMLSH : Op<(call "vqsub", $p0, (call "vqrdmulh", $p1, $p2))>; +def

[PATCH] D97375: [clang][cli] Add MarshallingInfoEnum multiclass

This revision was automatically updated to reflect the committed changes. Closed by commit rG88e45f00c156: [clang][cli] Add MarshallingInfoEnum multiclass (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97375/new/ https://r

[clang] 88e45f0 - [clang][cli] Add MarshallingInfoEnum multiclass

Author: Jan Svoboda Date: 2021-02-25T08:47:18+01:00 New Revision: 88e45f00c156170ed562bbacad3b2a21633c0f7a URL: https://github.com/llvm/llvm-project/commit/88e45f00c156170ed562bbacad3b2a21633c0f7a DIFF: https://github.com/llvm/llvm-project/commit/88e45f00c156170ed562bbacad3b2a21633c0f7a.diff L

[PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

ychen created this revision. ychen added reviewers: MaskRay, rnk, tejohnson, qcolombet, anemet. Herald added subscribers: dexonsmith, kerbowa, hiraditya, nhaehnle, jvesely. ychen requested review of this revision. Herald added projects: clang, LLDB, LLVM. Herald added subscribers: llvm-commits, lld

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay abandoned this revision. MaskRay added a comment. Thanks folks for review. Folks are more happy with approach 1 on https://lists.llvm.org/pipermail/llvm-dev/2021-February/148760.html , so I am abandoning this. I have copied the documentation and tests to D97447

[PATCH] D97447: Add GNU attribute 'retain'

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, rjmccall, rnk, rsmith. Herald added a subscriber: pengfei. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For ELF targets, GCC 11 will set SHF_GNU_RETAIN on the

[PATCH] D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal

MaskRay created this revision. MaskRay added reviewers: aaron.ballman, rjmccall, rnk, rsmith. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An global value in the `llvm.used` list does not have GC root semantics on ELF targets. T

[PATCH] D97445: [clang][sema] Ignore xor-used-as-pow if both sides are macros

tbaeder created this revision. tbaeder added reviewers: xbolva00, aaron.ballman. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I've read both https://reviews.llvm.org/D63423 and https://reviews.llvm.org/D66397, but I think both o

[PATCH] D96944: [RecoveryAST] Add design doc to clang internal manual.

This revision was automatically updated to reflect the committed changes. Closed by commit rG77a8589e5d2f: [clang][RecoveryAST] Add design doc to clang internal manual. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96944/new/ h

[clang] 77a8589 - [clang][RecoveryAST] Add design doc to clang internal manual.

Author: Haojian Wu Date: 2021-02-25T08:22:49+01:00 New Revision: 77a8589e5d2f1b3886a9831ae8468f97741991e7 URL: https://github.com/llvm/llvm-project/commit/77a8589e5d2f1b3886a9831ae8468f97741991e7 DIFF: https://github.com/llvm/llvm-project/commit/77a8589e5d2f1b3886a9831ae8468f97741991e7.diff LO

[PATCH] D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist

vitalybuka added a comment. Could you please rebase the patch onto D96974 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96203/new/ https://reviews.llvm.org/D96203 ___ cf

[PATCH] D97273: OpenMP: Fix object clobbering issue when using save-temps

This revision was automatically updated to reflect the committed changes. Closed by commit rG99951aa68da3: OpenMP: Fix object clobbering issue when using save-temps (authored by pdhaliwal). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97273/new/ ht

[clang] 99951aa - OpenMP: Fix object clobbering issue when using save-temps

Author: Pushpinder Singh Date: 2021-02-25T00:50:51-05:00 New Revision: 99951aa68da3c85ba03edf977cd9b22458aae6ca URL: https://github.com/llvm/llvm-project/commit/99951aa68da3c85ba03edf977cd9b22458aae6ca DIFF: https://github.com/llvm/llvm-project/commit/99951aa68da3c85ba03edf977cd9b22458aae6ca.di

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

rjmccall added a comment. Please add some C++ tests, just in case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/ https://reviews.llvm.org/D95984 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org/D95561 _

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

rjmccall added a comment. Okay, seems fine to me. Comment at: clang/lib/CodeGen/CGStmt.cpp:1156 + CallingConv::CC_SwiftAsync)) { +auto CI = cast(&Builder.GetInsertBlock()->back()); +CI->setTailCallKind(llvm::CallInst::TCK_Tail); Hmm. I guess t

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

aeubanks added a comment. not exactly sure how to test this... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97437/new/ https://reviews.llvm.org/D97437 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D97437: Rewrite MSVC toolchain discovery with VFS

aeubanks created this revision. aeubanks added reviewers: rnk, thakis, amccarth. Herald added subscribers: usaxena95, kadircet. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. This fixes an issue where the toolchain d

[PATCH] D97433: [Driver] Create -ffile-compilation-dir alias

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97433/new/ https://reviews.llvm.org/D97433 __

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

pengfei added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:311 + Value *ResElt = B.CreateAdd(EltC, SubVecR); + Value *NewVecC = B.CreateInsertElement(VecCPhi, ResElt, IdxC); + Value *NewVecD = B.CreateInsertElement(VecDPhi, ResElt, IdxC);

[PATCH] D97433: [Driver] Create -ffile-compilation-dir alias

phosek updated this revision to Diff 326269. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97433/new/ https://reviews.llvm.org/D97433 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Driver/ToolChain

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added inline comments. Comment at: llvm/lib/Transforms/Utils/RelLookupTableGenerator.cpp:76-77 + + /// If lookup table has more than one user, + /// do not generate a relative lookup table. + if (!GlobalVar.hasOneUser()) leonardchan wrote: > What's the

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

phosek added a comment. I realized recently that `-fcoverage-{prefix-map,compilation-dir}` is a more accurate name but I'd be interested in your opinion, I don't feel too strongly about this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97434/new

[PATCH] D97434: [Driver] Rename -fprofile-{prefix-map,compilation-dir} to -fcoverage-{prefix-map,compilation-dir}

phosek created this revision. phosek added reviewers: vsk, davidxl, keith. Herald added subscribers: jansvoboda11, dexonsmith, dang. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These flags affect coverage mapping (-fcoverage-mapp

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. In D94355#2572553 , @leonardchan wrote: > It looks like you have everything setup for running on the new PM, but it > doesn't look like the pass is added anywhere in the new PM pipeline. Thank you very much for pointing that out @

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem added a comment. > Thanks for pushing this forward! I think this will be a nice transformation > once all the details are worked out. Thank you very much for all of your wonderful constructive feedback! I learned much more about LLVM and IR internals. Appreciate all your help! Reposito

[PATCH] D94355: [Passes] Add relative lookup table converter pass

gulfem marked 17 inline comments as done. gulfem added inline comments. Comment at: clang/test/CodeGen/switch-to-lookup-table.c:2 +// Check switch to lookup optimization in fPIC and fno-PIC mode +// RUN: %clang_cc1 %s -triple=aarch64-unknown-fuchsia -O2 -fno-PIC -S -emit-llvm -o

[PATCH] D93594: [X86] Pass to transform amx intrinsics to scalar operation.

yubing added inline comments. Comment at: llvm/lib/Target/X86/X86LowerAMXIntrinsics.cpp:311 + Value *ResElt = B.CreateAdd(EltC, SubVecR); + Value *NewVecC = B.CreateInsertElement(VecCPhi, ResElt, IdxC); + Value *NewVecD = B.CreateInsertElement(VecDPhi, ResElt, IdxC); -

[PATCH] D94355: [Passes] Add relative lookup table generator pass

gulfem updated this revision to Diff 326265. gulfem added a comment. Herald added subscribers: wenlei, nikic, kerbowa, steven_wu, nhaehnle, jvesely. - Rename the pass to RelLookupTableConverter to be consistent - Addressed reviewers' feedback - Added tests for user-defined lookup tables and hidden

[PATCH] D94640: adds more checks to -Wfree-nonheap-object

cjdb updated this revision to Diff 326261. cjdb added a comment. applies @aaron.ballman's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94640/new/ https://reviews.llvm.org/D94640 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

This revision was automatically updated to reflect the committed changes. Closed by commit rGb950de5c13ef: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11 (authored by nullptr.cpp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[clang] b950de5 - [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

Author: Yang Fan Date: 2021-02-25T10:17:09+08:00 New Revision: b950de5c13ef2171c0457a413c3b06aa31047938 URL: https://github.com/llvm/llvm-project/commit/b950de5c13ef2171c0457a413c3b06aa31047938 DIFF: https://github.com/llvm/llvm-project/commit/b950de5c13ef2171c0457a413c3b06aa31047938.diff LOG:

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

nullptr.cpp added a comment. In D97364#2586171 , @aaronpuchert wrote: > I assume you need someone to land this for you? I can do it by myself, I have the commit access now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D97433: [Driver] Create -ffile-compilation-dir alias

phosek created this revision. phosek added reviewers: MaskRay, rnk. Herald added subscribers: jansvoboda11, dang. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We introduce -ffile-compilation-dir shorthand to avoid having to set -f

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

nomanous added a comment. Ping @rsmith @dblaikie @MaskRay @haowei @Xiangling_L @lebedev.ri Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing

[PATCH] D97340: [HIP] Support Spack packages

yaxunl updated this revision to Diff 326254. yaxunl marked 3 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97340/new/ https://reviews.llvm.org/D97340 Files: clang/include/clang/Driver/Options.td clang/lib/

[PATCH] D97340: [HIP] Support Spack packages

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:25-31 +// Look for sub-directory starts with Prefix under Path. If there is one and +// only one matching sub-directory found, append the sub-directory to Pat

[PATCH] D97358: [X86] Support amx-bf16 intrinsic.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4bc7c8631ad6: [X86] Support amx-bf16 intrinsic. (authored by LiuChen3). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] 4bc7c86 - [X86] Support amx-bf16 intrinsic.

Author: Liu, Chen3 Date: 2021-02-25T09:06:48+08:00 New Revision: 4bc7c8631ad62487a290dd4b7791848b67635787 URL: https://github.com/llvm/llvm-project/commit/4bc7c8631ad62487a290dd4b7791848b67635787 DIFF: https://github.com/llvm/llvm-project/commit/4bc7c8631ad62487a290dd4b7791848b67635787.diff LO

[PATCH] D97386: update AMDGPU _Float16 support in clang doc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG392fd3f1bf9f: update AMDGPU _Float16 support in clang doc (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang] 392fd3f - update AMDGPU _Float16 support in clang doc

Author: Yaxun (Sam) Liu Date: 2021-02-24T19:46:23-05:00 New Revision: 392fd3f1bf9f925942b385d8b99fb662d5739a83 URL: https://github.com/llvm/llvm-project/commit/392fd3f1bf9f925942b385d8b99fb662d5739a83 DIFF: https://github.com/llvm/llvm-project/commit/392fd3f1bf9f925942b385d8b99fb662d5739a83.dif

[PATCH] D97204: [RFC] Clang 64-bit source locations

akyrtzi added a comment. In D97204#2586111 , @rsmith wrote: > Can we avoid a libclang ABI break if we don't allow the use of 64-bit source > locations for builds with 32-bit pointers? To @rsmith's point, the simplest option may be to avoid building libcl

[clang] 7c926fe - Improve attribute documentation for nodebug on typedefs

Author: David Blaikie Date: 2021-02-24T16:25:37-08:00 New Revision: 7c926fee930012f9ec19cdaab23b7e154a3845ba URL: https://github.com/llvm/llvm-project/commit/7c926fee930012f9ec19cdaab23b7e154a3845ba DIFF: https://github.com/llvm/llvm-project/commit/7c926fee930012f9ec19cdaab23b7e154a3845ba.diff

[PATCH] D97080: [flang][driver] Add -fintrinsic-modules-path option

arnamoy10 updated this revision to Diff 326234. arnamoy10 edited the summary of this revision. arnamoy10 added a comment. Addressing comments, by separating the search directories from `fintrinsic-modules-path` in a separate variables. Also added dummy modules for the test case, as using `%llvm

[PATCH] D94973: [clang][OpenMP] Use OpenMPIRBuilder for workshare loops.

jdenny added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:8326-8331 +template +StmtResult +TreeTransform::TransformOMPCanonicalLoop(OMPCanonicalLoop *L) { + llvm_unreachable("OMPCanonicalLoop must be handled by the " + "OMPExecutableDirective th

[PATCH] D96835: [HIP] Support device sanitizer

Conanap added a comment. Hello, One of our PowerPC buildbots is failing because it is named `lld-multistage`, which matches with this CHECK-NOT in `clang/test/Driver/hip-sanitize-options.hip`: `;CHECK-NOT: {{"[^"]*lld[^"]*".* ".*hip.bc"}}`. I've created a patch and if you could review it that'

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. In D97411#2586055 , @rnk wrote: > I expected nodebug already applied to types, even though the documentation > says it only affects variables and functions. We should update the docs. Now that I think about it more, the only thi

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

This revision was automatically updated to reflect the committed changes. yaxunl marked 6 inline comments as done. Closed by commit rG47acdec1dd5d: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc (authored by yaxunl). Herald added a project: clang. Changed prior to

[clang] 47acdec - [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

Author: Yaxun (Sam) Liu Date: 2021-02-24T18:23:45-05:00 New Revision: 47acdec1dd5d6d4c279727a97313c586c20e9c6f URL: https://github.com/llvm/llvm-project/commit/47acdec1dd5d6d4c279727a97313c586c20e9c6f DIFF: https://github.com/llvm/llvm-project/commit/47acdec1dd5d6d4c279727a97313c586c20e9c6f.dif

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

zequanwu updated this revision to Diff 326222. zequanwu marked 2 inline comments as done. zequanwu added a comment. Add a doc example and CodeGen testcase about `not_tail_called` being applied to method override in a derived class. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

aaronpuchert accepted this revision. aaronpuchert added a comment. I assume you need someone to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97364/new/ https://reviews.llvm.org/D97364 ___

[PATCH] D97204: [RFC] Clang 64-bit source locations

rsmith added a comment. Thanks for doing this! The 8-9% memory hit is better than I'd feared, but still seems uncomfortably large. I've left comments on a couple of places where I think we could substantially reduce this. The performance regression seems large enough that people will notice, bu

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

rnk added a comment. I expected nodebug already applied to types, even though the documentation says it only affects variables and functions. We should update the docs. I think if we already have `nodebug` spelling, we don't need to make something general with modes. The "always emit" use case

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f1b832331e3: Reland "[Driver][Windows] Support per-target runtimes dir layout for profile… (authored by zero9178). Repository: rG LLVM Github Mon

[clang] 9f1b832 - Reland "[Driver][Windows] Support per-target runtimes dir layout for profile instr generate"

Author: Markus Böck Date: 2021-02-24T23:40:20+01:00 New Revision: 9f1b832331e350426f7f2f8cc30ab8ba991f5884 URL: https://github.com/llvm/llvm-project/commit/9f1b832331e350426f7f2f8cc30ab8ba991f5884 DIFF: https://github.com/llvm/llvm-project/commit/9f1b832331e350426f7f2f8cc30ab8ba991f5884.diff L

[PATCH] D97417: [clangd] use a compatible preamble for the first AST built

qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Keep a store of the

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96638/new/ https://reviews.llvm.org/D96638 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D95984: [CodeGen] Fix codegen for __attribute__((swiftasynccall)).

varungandhi-apple updated this revision to Diff 326203. varungandhi-apple added a comment. Generate tail call when doing codegen for return statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95984/new/ https://reviews.llvm.org/D95984 Files:

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 326200. zero9178 added a comment. Avoid going through the library directories, checking for the existence of a runtime library, twice by having getCompilerRTBasename call getCompilerRT and simply extract the filename component. To allow other ToolChains to

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

aganea added inline comments. Comment at: clang/tools/driver/driver.cpp:349 "source, and associated run script.\n"); - SmallVector argv(argv_, argv_ + argc_); + SmallVector ArgValues(Argv, Argv + Argc); What about just `Args`? "Values

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

dblaikie added a comment. Generally OK with this, as it seemed the libc++ issue might be a bit thorny to solve. Though I'd like to hear from libc++ maintainers about how they feel to ensure they're comfortable adding this attribute in the interim (or if this might be a motivation to fix libc++

[PATCH] D97094: [Driver] Print process statistics report on CC_PRINT_PROC_STAT env variable.

aganea added a comment. Thanks for the update @vvereschaka ! Just a few minor things and it should be good to go. Also please use `git diff -U9` next time to add context to the patch. Comment at: clang/docs/UsersManual.rst:783 It is possible to specify this option witho

[PATCH] D95561: [Clang] Introduce Swift async calling convention.

varungandhi-apple updated this revision to Diff 326194. varungandhi-apple added a comment. Address review feedback; remove centralized target check for CC_SwiftAsync. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95561/new/ https://reviews.llvm.org

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

rnk added a comment. To help bikeshed the name, I can imagine a few other use cases: - an attribute to suppress type info emission, never emit full type info for this type (similar to nodebug / artificial attributes for functions) -- this could help optimize debug info size - an attribute to al

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

rnk added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:468-469 // Check for runtime files in the new layout without the architecture first. - std::string CRTBasename = - buildCompilerRTBasename(*this, Args, Component, Type, /*AddArch=*/false); - for (cons

[PATCH] D65696: Implements CWG 2082 Referring to parameters in unevaluated operands of default arguments

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:143-148 + /// CheckDefaultArgumentVisitorODR - C++ [dcl.fct.default] Traverses + /// the default argument of a parameter to determine whether it + /// contains ODR violations. These violations cannot be c

[PATCH] D97411: [DebugInfo] Add an attribute to force type info to be emitted for types that are required to be complete.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie, rsmith. Herald added a reviewer: aaron.ballman. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was motivated by the fact that constructor type homing (debu

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. Something we should probably check is the interaction between -save-temps and whether we are trying to compile a single file or an executable, e.g. the difference between clang and clang -c. If trying to compile foo.c directly to an executable, -save-temps shoul

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; rnk wrote: > aaron.ballman wrote: > > rnk wrote: > > > aaron.ballman wrote: > > > > Quuxplusone wrote

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 marked an inline comment as done. zero9178 added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:468-469 // Check for runtime files in the new layout without the architecture first. - std::string CRTBasename = - buildCompilerRTBasename(*this, Args, C

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

zero9178 updated this revision to Diff 326178. zero9178 added a comment. Addressed one of the reviewer requests and also uploaded additional files part of the patch that were accidently left out. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96638/new/ https://reviews.llvm.org/D96638

[PATCH] D96638: [Driver][Windows] Support per-target runtimes dir layout for profile instr generate

rnk added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:446 case ToolChain::FT_Shared: -Suffix = TT.isOSWindows() - ? (TT.isWindowsGNUEnvironment() ? ".dll.a" : ".lib") +Suffix = Triple.isOSWindows() + ? (Triple.isWindowsGN

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847

[PATCH] D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function.

rnk added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4109 - [[clang::not_tail_called]] int foo2() override; -}; }]; aaron.ballman wrote: > rnk wrote: > > aaron.ballman wrote: > > > Quuxplusone wrote: > > > > aaron.ballman wrote

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

haampie added a comment. I don't have commit access, would be great if you could do that for me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D95119: Prefer /usr/bin/env xxx over /usr/bin/xxx where xxx = perl, python, awk

JDevlieghere added a comment. In D95119#2584709 , @haampie wrote: > Should this be merged? Do you have commit access? If not I can land this for you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95119/new/ https://reviews.llvm.org/D95119

[PATCH] D97123: [clangd] Support FixIts that use InsertFromRange instead of inserting raw text

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:555 +auto Insert = Lexer::getSourceText(FixIt.InsertFromRange, M, L, &Invalid); +if (!Invalid) + Result.newText = Insert.str(); njames93 wrote: > kadircet wrote: > >

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. @steakhal, could you please review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D92195: [OPENMP50]Mapping of the subcomponents with the 'default' mappers.

ABataev updated this revision to Diff 326144. ABataev added a comment. Fixes and updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92195/new/ https://reviews.llvm.org/D92195 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/CodeGen/C

[PATCH] D97340: [HIP] Support Spack packages

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:25-31 +// Look for sub-directory starts with Prefix under Path. If there is one and +// only one matching sub-directory found, append the sub-directory to Path. If +// there is no matching sub-directory

[PATCH] D97400: [clang][NFC] Remove unnecessary string copies in CustomDiagInfo

njames93 created this revision. njames93 added reviewers: rsmith, aaron.ballman. njames93 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Lookup the map using a string ref and store indexed diag info using a StringRef to the map. It may be

[PATCH] D96847: [clang][cli] Store additional optimization remarks info

jansvoboda11 added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96847/new/ https://reviews.llvm.org/D96847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D97327: [NFC] Switch to auto marshalling infrastructure for `-fsanitize-address-destructor-kind=` flag.

jansvoboda11 accepted this revision. jansvoboda11 added a comment. LGTM. If you don't get around committing this today, please rebase this on top of D97375 that I'm going to commit tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D96572: [Clang][ASan] Introduce `-fsanitize-address-destructor-kind=` driver & frontend option.

jansvoboda11 added a comment. > @jansvoboda11 Thanks. If it's okay with you I'll make the change to use the > new marshalling infrastructure in a separate patch > (https://reviews.llvm.org/D97327) because I may need to back port this patch > to an older LLVM branch. That's fine by me. Reposi

[PATCH] D97226: [clangd] Show hex value of numeric constants

kadircet accepted this revision. kadircet added a comment. still lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97226/new/ https://reviews.llvm.org/D97226 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs updated this revision to Diff 326126. jroelofs added a comment. Mark section invalid if the target doesn't like how it's spelled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97233/new/ https://reviews.llvm.org/D97233 Files: clang/incl

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

svenvh added inline comments. Comment at: clang/docs/OpenCLSupport.rst:196 +If an extension adds the functionality that does not modify standard language +parsing it should not require clang source code modifications. Most commonly +such extensions add functionality via libraries

[PATCH] D97273: OpenMP: Fix object clobbering issue when using save-temps

JonChesterfield added a comment. Works everywhere we have tried it. Fundamentally it renames a temporary file, so shouldn't break much. Will be great to have -save-temps working for nvptx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97273/new/ h

[PATCH] D97273: OpenMP: Fix object clobbering issue when using save-temps

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM, assuming it doesn't break support the reasoning makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97273/new/ https://review

[PATCH] D96838: Add GNU attribute 'retain'

MaskRay added a comment. We have two implementation choices. 1. Lift the source language restriction (it is currently discouraged) on llvm.compiler.used, let llvm.used use `SHF_GNU_RETAIN` on ELF, and change `__attribute__((used))` to use llvm.compiler.used on ELF. 2. Don't touch the backend se

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:192 CC1Args.push_back("-fcuda-is-device"); - CC1Args.push_back("-emit-llvm-bc"); vaguely interesting that `-emit-llvm` here appears to generate the same code as

[PATCH] D96769: [OpenMP][AMDGPU] Skip backend and assemble phases for amdgcn

JonChesterfield added a comment. Replacing `CC1Args.push_back("-emit-llvm-bc");` with `CC1Args.push_back("-emit-llvm-bc");` as suggested on the call does not work. This hook is downstream of the clang driver, so all it does under save temps is lead to `clang -E -emit-llvm`, which generated llvm

[PATCH] D96838: Add GNU attribute 'retain'

probinson added a comment. Aha; attribute `used` *by itself* is not sufficient to preserve sections in the output. But the `__start_/__stop_` symbols implicitly create a reference to each of the named sections, and that implicit reference can preserve them in the output (assuming gc roots etc)

[PATCH] D97072: [OpenCL][Docs] Add guidelines for adding new extensions and features

mantognini added a comment. Some minor comments. Comment at: clang/docs/OpenCLSupport.rst:197 +parsing it should not require clang source code modifications. Most commonly +such extensions add functionality via libraries (by adding new non-native +types or functions) parsed reg

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen updated this revision to Diff 326107. khchen marked 2 inline comments as done. khchen added a comment. address https://reviews.llvm.org/D95016?id=324197#inline-912573 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95016/new/ https://reviews.l

[PATCH] D97233: Support `#pragma clang section` directives on MachO targets

jroelofs added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:304 + if (llvm::Error E = Context.getTargetInfo().isValidSectionSpecifier(SecName)) +Diag(PragmaLoc, diag::err_pragma_section_invalid_for_target) t.p.northover wrote: > Shouldn't this

[PATCH] D88220: [C++20] P1825R0: More implicit moves

amccarth added a comment. The option is used in the wild, but not as widely as I first believed. We've already fixed a couple projects that were using it. I think the Release Note is the right solution. Thanks for doing that. I withdraw my suggestion to allow and ignore. Repository: rG

[PATCH] D97361: [clang-tidy] Add misc-redundant-using check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantUsingCheck.cpp:23 + Finder->addMatcher( + usingDecl(isExpansionInMainFile()).bind("using-declaration"), this); + Finder->addMatcher( Why restrict these to main file only

[PATCH] D97364: [docs] Add a release note for the removing of -Wreturn-std-move-in-c++11

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97364/new/ https://reviews.llvm.org/D97364

[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

khchen added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:899 +// (operand) in ProtoSeq. ProtoSeq[0] is output operand. +SmallVector ProtoSeq; +const StringRef Primaries("evwqom0ztc"); craig.topper wrote: > I think this is somet

  1   2   >