[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 324875. zoecarver added a comment. - * Format with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361 Files: clang/include/clang/Basic/AttrDocs.td clan

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver added a comment. Sorry for the delay in updating. @ahatanak let me know if you've found another way to break this patch :P Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92361/new/ https://reviews.llvm.org/D92361

[PATCH] D92361: [trivial-abi] Support types without a copy or move constructor.

zoecarver updated this revision to Diff 324874. zoecarver added a comment. - Fix the case where an object inherits from two objects, one with a deleted copy constructor and the other with a deleted move constructor. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D96803: EntryExitInstrumenter: Move to a module pass and enable at all optimization levels (PR49143)

aeubanks added a comment. In D96803#2571316 , @zatrazz wrote: > In D96803#2569436 , @aeubanks wrote: > >> In D96803#2568179 , @zatrazz wrote: >> >>> In D96803#2566322

[PATCH] D96835: [HIP] Support device sanitizer

This revision was automatically updated to reflect the committed changes. yaxunl marked 3 inline comments as done. Closed by commit rG51ade31e6789: [HIP] Support device sanitizer (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D96835?vs=324

[clang] 51ade31 - [HIP] Support device sanitizer

Author: Yaxun (Sam) Liu Date: 2021-02-18T23:30:25-05:00 New Revision: 51ade31e67897bbd6f363f26d9110ec4d6ddaa7f URL: https://github.com/llvm/llvm-project/commit/51ade31e67897bbd6f363f26d9110ec4d6ddaa7f DIFF: https://github.com/llvm/llvm-project/commit/51ade31e67897bbd6f363f26d9110ec4d6ddaa7f.dif

[clang] bdf6fbc - PR49239: Don't take shortcuts when constant evaluating in 'warn on UB'

Author: Richard Smith Date: 2021-02-18T18:31:08-08:00 New Revision: bdf6fbc939646b52af61c0bae7335623a8be59f4 URL: https://github.com/llvm/llvm-project/commit/bdf6fbc939646b52af61c0bae7335623a8be59f4 DIFF: https://github.com/llvm/llvm-project/commit/bdf6fbc939646b52af61c0bae7335623a8be59f4.diff

[PATCH] D96195: [HIP] Fix managed variable linkage

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:1017 + +void CGNVCUDARuntime::transformManagedVars() { + for (auto &&Info : DeviceVars) { tra wrote: > A comment about how exactly we're transformin

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

shafik added a comment. Herald added a subscriber: JDevlieghere. Reverted the changes because I missed the clangd test suite and don't know how long it will take to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96807/new/ https://reviews.llvm

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

tra marked an inline comment as done. tra added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:744 #pragma pop_macro("PTX70") #pragma pop_macro("PTX71") yaxunl wrote: > need to pop PTX72 ? Good catch. Done. Repository: rG LLVM Gith

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

tra updated this revision to Diff 324829. tra added a comment. pop the macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/test/CodeGen/builtin

[PATCH] D96195: [HIP] Fix managed variable linkage

tra added inline comments. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:1017 + +void CGNVCUDARuntime::transformManagedVars() { + for (auto &&Info : DeviceVars) { A comment about how exactly we're transforming the vars would be helpful. Comment a

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9+ for OpenMP offloading on NVPTX target

tianshilei1992 added a comment. According to D97012 , if we want to completely drop CUDA version, it should be CUDA 9.2. Do we want to change the minimum version to CUDA 9.2? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D96807: Modify TypePrinter to differentiate between anonymous struct and unnamed struct

This revision was automatically updated to reflect the committed changes. shafik marked an inline comment as done. Closed by commit rGecb90b55454e: Modify TypePrinter to differentiate between anonymous struct and unnamed struct (authored by shafik). Herald added projects: clang, LLDB. Repository:

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

yaxunl added inline comments. Comment at: clang/include/clang/Basic/BuiltinsNVPTX.def:744 #pragma pop_macro("PTX70") #pragma pop_macro("PTX71") need to pop PTX72 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:1229-1235 +static void buildLambdaThisCaptureFixit(Sema &Sema, LambdaScopeInfo *LSI) { + SourceLocation DiagLoc = LSI->IntroducerRange.getEnd(); + assert(!LSI->isCXXThisCaptured()); + Sema.Diag(DiagLoc,

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 324823. njames93 added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96975/new/ https://reviews.llvm.org/D96975 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/

[PATCH] D97000: [clang] Increase the bitness of data length in ASTDeclContextNameLookup

rsmith added a comment. Thanks for the diagnosis and the patch! We spend a significant amount of our AST file size on these lookup tables, so I think the extra two bytes per lookup entry is best avoided if possible. We also have the same problem for other on-disk hash tables. I went ahead and

[clang] e0589d7 - Switch to using LEB encoding for key and data lengths in on-disk hash

Author: Richard Smith Date: 2021-02-18T17:19:01-08:00 New Revision: e0589d70fb8e29842fab228df716f73b378710a6 URL: https://github.com/llvm/llvm-project/commit/e0589d70fb8e29842fab228df716f73b378710a6 DIFF: https://github.com/llvm/llvm-project/commit/e0589d70fb8e29842fab228df716f73b378710a6.diff

[clang] 3cd70fc - Detect diagnostic groups that are defined in multiple 'def's.

Author: Richard Smith Date: 2021-02-18T17:19:01-08:00 New Revision: 3cd70fc59d2a1a907d14bbf3f2dfe53d2c2be9d1 URL: https://github.com/llvm/llvm-project/commit/3cd70fc59d2a1a907d14bbf3f2dfe53d2c2be9d1 DIFF: https://github.com/llvm/llvm-project/commit/3cd70fc59d2a1a907d14bbf3f2dfe53d2c2be9d1.diff

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

tra updated this revision to Diff 324812. tra edited the summary of this revision. tra added a comment. Updated the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97009/new/ https://reviews.llvm.org/D97009 Files: clang/include/clang/Basic/B

[PATCH] D97009: [CUDA] fix builtin constraints for PTX 7.2

tra created this revision. tra added a reviewer: yaxunl. Herald added subscribers: bixia, jholewinski. tra requested review of this revision. Herald added a project: clang. This fixes build issues w/ CUDA-11 introduced by https://reviews.llvm.org/D95974 Repository: rG LLVM Github Monorepo htt

[PATCH] D96195: [HIP] Fix managed variable linkage

yaxunl updated this revision to Diff 324806. yaxunl added a comment. keep managed var in llvm.compiler.used since they need runtime handling even if they are not used in device code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96195/new/ https://reviews.llvm.org/D96195 Files: clan

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9+ for OpenMP offloading on NVPTX target

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 ___

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

vitalybuka requested changes to this revision. vitalybuka added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/SanitizerBlacklist.cpp:15 #include "clang/Basic/FileManager.h" +#include "clang/Basic/NoSanitizeList.h" #include "clang/Ba

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9+ for OpenMP offloading on NVPTX target

grokos added a comment. This change makes much sense. In fact, CUDA 8 was so problematic for use with the nvptx runtime that (if memory serves me well) we declared it unsupported. So essentially this patch drops support for CUDA version 7 (and lower), which is already six years old. If the othe

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9+ for OpenMP offloading on NVPTX target

tianshilei1992 added a comment. In D97003#2573090 , @jdoerfert wrote: > Could you include the simplifications this allows in the openmp subfolder? If > it's too much put it in a child revision. I prefer to split them as most of changes are in OpenMP. R

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9+ for OpenMP offloading on NVPTX target

jdoerfert added a comment. Could you include the simplifications this allows in the openmp subfolder? If it's too much put it in a child revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97003/new/ https://reviews.llvm.org/D97003 __

[PATCH] D97003: [Clang][OpenMP] Require CUDA 9+ for OpenMP offloading on NVPTX target

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, JonChesterfield, ABataev, grokos. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. In curren

[PATCH] D96971: Allow but ignore `-Wreturn-std-move-in-c++11`

amccarth abandoned this revision. amccarth added a comment. Fair enough. I'm continuing the whack-a-mole game for the Chromium third-parties. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96971/new/ https://reviews.llvm.org/D96971 ___ cfe-c

[PATCH] D88220: [C++20] P1825R0: More implicit moves

aaronpuchert added a subscriber: aaron.ballman. aaronpuchert added a comment. In D88220#2571911 , @amccarth wrote: > Would anyone object to allowing the option but silently ignoring it, at least > for a transition period? No objection from me. > Was the

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

arnamoy10 updated this revision to Diff 324785. arnamoy10 marked an inline comment as not done. arnamoy10 added a comment. - Rewritten the test cases - Moved `flarge-sizes` to a standalone test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96344/new/ https://reviews.llvm.org/D963

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

rsmith added a comment. @rnk / @thakis Can you take a look at this and see if you're happy with this "defining `assert` implicitly defines `static_assert`" approach? Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:427-429 +def warn_cxx_static_assert_in_c : Warnin

[PATCH] D97001: [Coverage] Normalize compilation dir as well

phosek created this revision. phosek added a reviewer: vsk. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches debug info behavior. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D97001 Files: clang/li

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. Got it. Copy a file can be tricky. Compile one more can be easily done in cmake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https:

[PATCH] D97000: [clang] Increase the bitness of data length in ASTDeclContextNameLookup

danlark created this revision. danlark added a reviewer: rsmith. danlark requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We faced the assert of too many declarations for serialized lookup for a very generated C++ target. We think moving th

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

dexonsmith added inline comments. Comment at: clang/lib/Basic/SanitizerBlacklist.cpp:15 #include "clang/Basic/FileManager.h" +#include "clang/Basic/NoSanitizeList.h" #include "clang/Basic/SanitizerSpecialCaseList.h" vitalybuka wrote: > Own header should go firs

[PATCH] D96974: [clang][patch] Inclusive language, modify filename SanitizerBlacklist.h to NoSanitizeList.h

vitalybuka accepted this revision. vitalybuka added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Basic/SanitizerBlacklist.cpp:15 #include "clang/Basic/FileManager.h" +#include "clang/Basic/NoSanitizeList.h" #include "clang/Basic/Sanit

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5fbd1a333aa1: [Coverage] Store compilation dir separately in coverage mapping (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 5fbd1a3 - [Coverage] Store compilation dir separately in coverage mapping

Author: Petr Hosek Date: 2021-02-18T14:34:39-08:00 New Revision: 5fbd1a333aa1a0b70903d036b98ea56c51ae5224 URL: https://github.com/llvm/llvm-project/commit/5fbd1a333aa1a0b70903d036b98ea56c51ae5224 DIFF: https://github.com/llvm/llvm-project/commit/5fbd1a333aa1a0b70903d036b98ea56c51ae5224.diff LO

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

ahatanak added a comment. OK, I se the other patch is using the bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89903/new/ https://reviews.llvm.org/D89903 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D89903: [CodeGen] Crash instead of generating broken code with self-capturing __block var

ahatanak added a comment. `VarDecl` has a bit (`EscapingByref`) that indicates whether the `__block` variable is captured by an escaping block. Can that information be used to avoid pre-moving to the heap? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324759. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/lib/CodeGen/Cov

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324755. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Driver/Options.td clang/lib/CodeGen/Cov

[clang] fc97a63 - Move a second variable only used in an assert into the assert.

Author: Sterling Augustine Date: 2021-02-18T13:26:07-08:00 New Revision: fc97a63db0d3488ce6c422a9545f8b0268760918 URL: https://github.com/llvm/llvm-project/commit/fc97a63db0d3488ce6c422a9545f8b0268760918 DIFF: https://github.com/llvm/llvm-project/commit/fc97a63db0d3488ce6c422a9545f8b0268760918.

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

saugustine added a comment. This commit introduced an unused variable warning when built without asserts. (CoverageMappingGen.cpp:984) I have fixed it with rG4544a63b7705 . Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 4544a63 - Move variable only used in an assert into the assert.

Author: Sterling Augustine Date: 2021-02-18T13:04:58-08:00 New Revision: 4544a63b77056212af341722b2e04471a8ec0be6 URL: https://github.com/llvm/llvm-project/commit/4544a63b77056212af341722b2e04471a8ec0be6 DIFF: https://github.com/llvm/llvm-project/commit/4544a63b77056212af341722b2e04471a8ec0be6.

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

thakis added a comment. In D96816#2572589 , @dexonsmith wrote: > In D96816#2572552 , @ahatanak wrote: > >> I still don't understand why the test was failing, but did we have to bump >> the version because a new Lan

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

thakis added a comment. Thanks for the revert! FWIW the failure repros for me locally if I just do `ninja check-clang` (as long as I have the aarch64 target enabled, which it is by default in the cmake build). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

dexonsmith added a comment. In D96816#2572552 , @ahatanak wrote: > I still don't understand why the test was failing, but did we have to bump > the version because a new LangOpt (`EncodeCXXClassTemplateSpec`) was added? Here are the RUN lines: // RUN:

[PATCH] D96975: [Sema] Add some basic lambda capture fix-its

njames93 updated this revision to Diff 324741. njames93 added a comment. Remove default capture by value fixit if 'this' is explicitly captured pre c++20. Fix default capture insertion loc to be at the start of the capture list. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D96456: [ThinLTO, NewPM] Register sanitizers with OptimizerLastPassBuilderHook

vitalybuka added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1070-1071 +// ThinLTOIndexFile is provideds so we must be in ThinLTO PostLink. +// For -O0 ThinLTO PreLink does basic optimization and triggers +// OptimizerLastEPCallbacks. Po

[PATCH] D95017: [clang-format] Add case aware include sorting.

PragmaNull added a comment. In D95017#2572238 , @curdeius wrote: > Do you have an idea for better names? > I see that e.g. MS documentation uses ascending order and case-sensitive > order. I'm okay with the names, it just seems to me that they are revers

[clang] 0ec32f1 - Revert "[AArch64] Adding Neon Polynomial vadd Intrinsics"

Author: Pengxuan Zheng Date: 2021-02-18T12:38:16-08:00 New Revision: 0ec32f132643fa8a949e5a29a71f7729b329476a URL: https://github.com/llvm/llvm-project/commit/0ec32f132643fa8a949e5a29a71f7729b329476a DIFF: https://github.com/llvm/llvm-project/commit/0ec32f132643fa8a949e5a29a71f7729b329476a.diff

[PATCH] D94355: [Passes] Add relative lookup table generator pass

leonardchan added a comment. It looks like you have everything setup for running on the new PM, but it doesn't look like the pass is added anywhere in the new PM pipeline. Unfortunately, I don't *think* there's anything in the new PM that acts as a "default pipeline that gets added to all other

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak added a comment. I still don't understand why the test was failing, but did we have to bump the version because a new LangOpt (`EncodeCXXClassTemplateSpec`) was added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96816/new/ https://revie

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

thakis added a comment. In D96816#2572431 , @thakis wrote: > See maybe also https://reviews.llvm.org/D73202 . Do we need to bump > serialization::VERSION_MINOR ? I gave that a try in http://reviews.llvm.org/rG063236646849564094f5fcfc947ad36dba0efedb . L

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

thakis added a comment. In D96816#2572431 , @thakis wrote: > See maybe also https://reviews.llvm.org/D73202 . Do we need to bump > serialization::VERSION_MINOR ? I gave Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97ec8fa5bb07: [Coverage] Store compilation dir separately in coverage mapping (authored by phosek). Changed prior to commit: https://reviews.llvm.

[clang] 97ec8fa - [Coverage] Store compilation dir separately in coverage mapping

Author: Petr Hosek Date: 2021-02-18T12:27:42-08:00 New Revision: 97ec8fa5bb07e3f5bf25ddcb216b545cd3d03b65 URL: https://github.com/llvm/llvm-project/commit/97ec8fa5bb07e3f5bf25ddcb216b545cd3d03b65 DIFF: https://github.com/llvm/llvm-project/commit/97ec8fa5bb07e3f5bf25ddcb216b545cd3d03b65.diff LO

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

phosek updated this revision to Diff 324733. phosek edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95753/new/ https://reviews.llvm.org/D95753 Files: clang/include/clang/Basic/CodeGenOptions.h clang/include/cla

[clang] 0632366 - [clang] bump VERSION_MAJOR

Author: Nico Weber Date: 2021-02-18T15:23:24-05:00 New Revision: 063236646849564094f5fcfc947ad36dba0efedb URL: https://github.com/llvm/llvm-project/commit/063236646849564094f5fcfc947ad36dba0efedb DIFF: https://github.com/llvm/llvm-project/commit/063236646849564094f5fcfc947ad36dba0efedb.diff LO

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

ye-luo requested changes to this revision. ye-luo added a comment. This revision now requires changes to proceed. Let user to copy the bc file is not feasible. Handle this in CMake please. libomptarget-nvptx-unknown.bc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D96884: [flang][driver] Add more -fdebug options

awarzynski added a comment. I've just realized that for `-fdebug-parsing-log` we need to set `Fortran::parser::instrumentedParse`. I don't see a good place for that just yet. It's probably best extracting that option into a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

thakis added a comment. Looks like this breaks check-clang: http://45.33.8.238/win/33493/step_7.txt Please take a look, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://reviews.llvm.or

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

thakis added a comment. See maybe also https://reviews.llvm.org/D73202 . Do we need to bump serialization::VERSION_MINOR ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96816/new/ https://reviews.llvm.org/D96816 __

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

thakis added a comment. #3 0x778ee662 in __GI___assert_fail (assertion=0x90165c "idx < size()", file=0xc60efe "../../llvm/include/llvm/ADT/SmallVector.h", line=281, function=0xa8780d "llvm::SmallVectorTemplateCommon::const_reference llvm::SmallVectorTemplateCommon::opera

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

tskeith added inline comments. Comment at: flang/test/Flang-Driver/fdefault.f90:10 +! RUN: not %flang-new -fsyntax-only -fdefault-double-8 %s 2>&1 | FileCheck %s --check-prefix=DOUBLE +! RUN: mkdir -p %t/dir-flang-new && %flang-new -fsyntax-only -module-dir %t/dir-flang-new -f

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

thakis added a comment. I ssh'd into one of the failing boxes and ran the failing command without piping it into filecheck. Here's the output: thakis@dotc:~/src/llvm-project$ env CINDEXTEST_EDITING=1 CINDEXTEST_EXECUTE_COMMAND="cp /usr/local/google/home/thakis/src/llvm-project/clang/test/Ind

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added a comment. Landed at https://github.com/llvm/llvm-project/commit/d83511dd26ca8d0dd5be6302ad7b55de05cedab2 (forgot to add the differential revision line). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm

[clang] d83511d - [Coverage] Emit gap region after conditions when macro is present.

Author: Zequan Wu Date: 2021-02-18T11:41:04-08:00 New Revision: d83511dd26ca8d0dd5be6302ad7b55de05cedab2 URL: https://github.com/llvm/llvm-project/commit/d83511dd26ca8d0dd5be6302ad7b55de05cedab2 DIFF: https://github.com/llvm/llvm-project/commit/d83511dd26ca8d0dd5be6302ad7b55de05cedab2.diff LOG

[PATCH] D96825: [AArch64] Adding Neon Polynomial vadd Intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9645059c5de: [AArch64] Adding Neon Polynomial vadd Intrinsics (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96825/new/ https://review

[clang] d964505 - [AArch64] Adding Neon Polynomial vadd Intrinsics

Author: Pengxuan Zheng Date: 2021-02-18T11:33:24-08:00 New Revision: d9645059c5deeacf264bea0cf50eab459cf8e5bb URL: https://github.com/llvm/llvm-project/commit/d9645059c5deeacf264bea0cf50eab459cf8e5bb DIFF: https://github.com/llvm/llvm-project/commit/d9645059c5deeacf264bea0cf50eab459cf8e5bb.diff

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:928 + +class SHA512H_pattern + : Pat<(v2i64 (OpNode (v2i64 V128:$Vd), (v2i64 V128:$Vn), (v2i64 V128:$Vm))), DavidSpickett wrote: > This is unused. a good catch thank you

[PATCH] D96381: [AArch64] Adding SHA3 Intrinsics support

rsanthir.quic updated this revision to Diff 324711. rsanthir.quic marked 3 inline comments as done. rsanthir.quic added a comment. Minor corrections and removed unused code, also added complete testing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96381/new/ https://reviews.llvm.org/D96

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

vsk accepted this revision. vsk added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm.org/D85176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2243 Reflow = true; if (ContentStartColumn + RemainingTokenColumns > ColumnLimit) { LLVM_DEBUG(l

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski added inline comments. Comment at: flang/test/Flang-Driver/fdefault.f90:10 +! RUN: not %flang-new -fsyntax-only -fdefault-double-8 %s 2>&1 | FileCheck %s --check-prefix=DOUBLE +! RUN: mkdir -p %t/dir-flang-new && %flang-new -fsyntax-only -module-dir %t/dir-flang-new

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu added inline comments. Comment at: clang/test/CoverageMapping/if.cpp:10 +void foo() {// CHECK-NEXT: Gap,File 0, [[@LINE+1]]:21 -> [[@LINE+1]]:22 = #2 if (int j = true ? nop() // CHECK-NEXT: [[@LINE]]:22 -> [[@LINE]]:27 = #2

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

zequanwu updated this revision to Diff 324710. zequanwu marked 2 inline comments as done. zequanwu added a comment. - Added regression test. - Assert `getIncludeOrExpansionLoc(AfterLoc)` is valid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

ahatanak added a comment. In D96816#2572218 , @thakis wrote: > Very cool change, I wanted something like this for a long time :) > > It seems to break Index/preamble-reparse-changed-module.m on some platforms: > http://45.33.8.238/linux/39727/step_7.txt >

[PATCH] D96971: Allow but ignore `-Wreturn-std-move-in-c++11`

Quuxplusone accepted this revision. Quuxplusone added a comment. This revision is now accepted and ready to land. FWIW, no particular comment from me. I agree with everything @thakis said. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96971/new/ https://reviews.llvm.org/D96971

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

tskeith added inline comments. Comment at: flang/test/Flang-Driver/fdefault.f90:4 + +! REQUIRES: new-flang-driver + Can't this work with the f18 driver too? That's the best way to ensure they are consistent. Comment at: flang/test/Flang-Driver

[PATCH] D85176: [Coverage] Emit gap region after conditions when macro is present.

vsk added a comment. Could you check in the reproducer program (`void p`) as a regression test? Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:995 + +AfterLoc = getPreciseTokenLocEnd(getIncludeOrExpansionLoc(AfterLoc)); +assert(AfterLoc.isValid()); ---

[PATCH] D95017: [clang-format] Add case aware include sorting.

curdeius added a comment. Do you have an idea for better names? I see that e.g. MS documentation uses ascending order and case-sensitive order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 __

[PATCH] D96971: Allow but ignore `-Wreturn-std-move-in-c++11`

thakis added a comment. Since the fix for this seems to be "just remove the flag", and since the flag can be removed while on the old clang version without problems, it's possible to migrate to the new way without having to do this at the same time as a compiler update already. So I'm not sure

[PATCH] D95396: Improve static_assert/_Static_assert diagnostics

aaron.ballman updated this revision to Diff 324707. aaron.ballman added a comment. Updated based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95396/new/ https://reviews.llvm.org/D95396 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Bas

[PATCH] D96568: [CFE, SystemZ] Emit s390.tdc instrincic for __builtin_isnan in Constrained FP mode.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe57bd1ff4fb6: [CFE, SystemZ] New target hook testFPKind() for checks of FP values. (authored by jonpa). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] e57bd1f - [CFE, SystemZ] New target hook testFPKind() for checks of FP values.

Author: Jonas Paulsson Date: 2021-02-18T12:36:46-06:00 New Revision: e57bd1ff4fb65208cb3060b62e1c48aa0aac623f URL: https://github.com/llvm/llvm-project/commit/e57bd1ff4fb65208cb3060b62e1c48aa0aac623f DIFF: https://github.com/llvm/llvm-project/commit/e57bd1ff4fb65208cb3060b62e1c48aa0aac623f.diff

[PATCH] D96816: [ObjC] Encode pointers to C++ classes as "^v" if the encoded string would otherwise include template specialization types

thakis added a comment. Very cool change, I wanted something like this for a long time :) It seems to break Index/preamble-reparse-changed-module.m on some platforms: http://45.33.8.238/linux/39727/step_7.txt http://45.33.8.238/macm1/3788/step_6.txt Does the failure make sense to you? Reposit

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

JonChesterfield added a comment. Which tests? Choosing a file to duplicate with the unknown.bc name is left separate. This just adds code to look for that file if the first choice failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ h

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD added a comment. @vsavchenko, does it look okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96976/new/ https://reviews.llvm.org/D96976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member

RedDocMD created this revision. RedDocMD added reviewers: vsavchenko, NoQ, dcoughlin. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. RedDocMD requested review of this revision.

[PATCH] D96835: [HIP] Support device sanitizer

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:1185 +ToolChain::getHIPDeviceLibs(const ArgList &DriverArgs) const { + return llvm::SmallVector(); +} tra wrote: > Nit: It could be just `return {}`

[PATCH] D95246: [test] Use host platform specific error message substitution in lit tests

ASDenysPetrov added a comment. @abhina.sreeskantharajan > Can you share the output of > > sysconfig.get_platform() Sure, >>> sysconfig.get_platform() 'win32' >>> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95246/new/ https://reviews.ll

[PATCH] D96344: [flang][driver] Add options for -fdefault* and -flarge-sizes

awarzynski added inline comments. Comment at: flang/test/Flang-Driver/fdefault.f90:1 +! Ensure argument -fdefault* works as expected. +! TODO: Add checks when actual codegen is possible for this family I think that this test is a great improvement compared to wha

[PATCH] D96877: [libomptarget] Try a fallback devicertl if the preferred one is missing

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM. Please also update the test(s) before commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96877/new/ https://reviews.llv

[PATCH] D85176: [Coverage] Enable emitting gap area between macros

zequanwu updated this revision to Diff 324695. zequanwu added a comment. Tested on clange stage2 build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85176/new/ https://reviews.llvm.org/D85176 Files: clang/lib/CodeGen/CoverageMappingGen.cpp cl

[PATCH] D96835: [HIP] Support device sanitizer

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. LGTM with few minor nits. Comment at: clang/lib/Driver/ToolChain.cpp:1185 +ToolChain::getHIPDeviceLibs(const ArgList &DriverArgs) const { + return llvm::SmallVector(); +} --

  1   2   3   >