[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Is there a test with indentation within a namespace? If not maybe you should add one. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:613 + // settings. This allows the format to back up one level in those cases. + if (!AddLevel && Na

[PATCH] D94955: [clang-format] Treat ForEachMacros as loops

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. LGTM per se. But, as it's a somehow a breaking change, I'd rather wait for release 12 branch before landing to main, so that folks have time to veto before release 13. Please upd

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 317766. timwoj added a comment. Fixing diff to look at the right commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 Files: clang/lib/Format/UnwrappedLineFormatter.

[PATCH] D94500: Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

timwoj updated this revision to Diff 317765. timwoj added a comment. Updates from review: - Fixed handling of IndentCaseLabels - Fixed indentation of namespace braces - Replaced bool argument to addUnwrappedLine with an enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer added a comment. I'll work on fixing the unit tests. Thought they ran with check-cpang-format but I was obviously wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 _

[PATCH] D95017: [clang-format] add case aware include sorting

kentsommer created this revision. kentsommer requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Adds an option to [clang-format] which sorts headers in an alphabetical manner using case only for tie-breakers. The options is off by default i

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 abandoned this revision. tianshilei1992 added a comment. Let's use LLVM intrinsics for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.llvm.org/D94884 ___ cfe

[PATCH] D91303: [clang-tidy] readability-container-size-empty: simplify implementation

alexfh added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-container-size-empty.cpp:480-482 -// CHECK-MESSAGES: :[[@LINE-1]]:24: warning: the 'empty' method should be used -// CHECK-MESSAGES: :101:18: note: method 'Lazy'::empty() defined her

[PATCH] D91303: [clang-tidy] readability-container-size-empty: simplify implementation

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91303/new/ https://reviews.llvm.org/D91303 ___ cfe

[PATCH] D94732: [CUDA] Normalize handling of defauled dtor.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:15162-15170 + bool SkipDtorChecks = VD->getType()->isArrayType(); + + // CUDA: Skip destructor checks for host-only variables during device-side + // compilation + SkipDtorChecks |= + (LangOpts.CUDA

[PATCH] D95012: [WebAssembly] Prototype new f64x2 conversions

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: wingo, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. tlively requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good! Might be worth some comments explaining why it's being done this way (probably good to have some details wherever we're making these changes to cope with CV's need for distinc

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

JonChesterfield added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2307 + // Only alphanumeric and underscore is allowed in -cuid option. + if (auto *A = Args.getLastArg(OPT_cuid_EQ)) { +const char *V = A->getValue(); Why this limi

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317728. akhuang added a comment. Update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-in

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-gline-tables-only-codeview.cpp:30-32 + // CHECK: !DISubprogram(name: "operator()", scope: ![[LAMBDA:[0-9]+]] + // CHECK: ![[LAMBDA]] = !DICompositeType(tag: DW_TAG_class_type, + // CHECK-SAME:

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

JonChesterfield added subscribers: jdoerfert, JonChesterfield. JonChesterfield added a reviewer: jdoerfert. JonChesterfield added a comment. @jdoerfert this may be a candidate for deriving names of extracted target regions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95007/new/ https:

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-gline-tables-only-codeview.cpp:30-32 + // CHECK: !DISubprogram(name: "operator()", scope: ![[LAMBDA:[0-9]+]] + // CHECK: ![[LAMBDA]] = !DICompositeType(tag: DW_TAG_class_type, + // CHECK-SAME:

[PATCH] D93264: [CSSPGO] Introducing distribution factor for pseudo probe.

hoy updated this revision to Diff 317726. hoy marked an inline comment as done. hoy added a comment. Addressing Wei's feedbacks. Also prorating indirect callsite target count annotation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93264/new/ htt

[PATCH] D93095: Introduce -Wreserved-identifier

rsmith added inline comments. Comment at: clang/lib/Sema/Sema.cpp:2421-2428 +// Perform a lookup at TUScope. If it succeeds, we're at global scope and a +// single '_' is enough to be reserved. +LookupResult IdentifierLookup(*this, II, SourceLocation(), +

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only, except to differentiate + // between lambdas. + if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda()) dbla

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317718. akhuang marked an inline comment as done. akhuang added a comment. Add check for CodeView Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files: clang/lib/Cod

[PATCH] D93978: [clangd] DefineOutline doesn't require implementation file being saved

njames93 planned changes to this revision. njames93 added a comment. I've decided I much prefer the implementation in D94554 , So once thats cleaned up and split up, I'll merge changes in here with there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D89441: [xray] Honor xray-never function-instrument attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68a1f09107a4: [xray] Honor xray-never function-instrument attribute (authored by ianlevesque). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

dexonsmith added a comment. It would be great if you could split the `--` support out into a separate patch to commit ahead of time, but I left a couple of comments since I was taking a look. Comment at: clang/lib/Tooling/Tooling.cpp:438-440 for (StringRef Arg : Args)

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl updated this revision to Diff 317712. yaxunl edited the summary of this revision. yaxunl added a comment. separate CUID patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85223/new/ https://reviews.llvm.org/D85223 Files: clang/lib/AST/ASTContext.cpp clang/lib/CodeGen/CGCUD

[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. Herald added subscribers: dexonsmith, dang. yaxunl requested review of this revision. This patch added a distinct CUID for each input file, which is represented by InputAction. clang initially creates an InputAction for each inp

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

cebowleratibm added inline comments. Comment at: clang/test/CodeGen/altivec.c:1 // RUN: %clang_cc1 -target-feature +altivec -triple powerpc-unknown-unknown -emit-llvm %s -o - | FileCheck %s --check-prefixes=CHECK,CHECK-BE // RUN: %clang_cc1 -target-feature +altivec -triple pow

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

steveire updated this revision to Diff 317709. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94865/new/ https://reviews.llvm.org/D94865 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/ASTMatc

[PATCH] D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds

steveire added inline comments. Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:948 + return {}; +auto VM = Arg.Value.getMatcher(); +if (VM.hasTypedMatcher(NK)) { aaron.ballman wrote: > Note, this is an example of why use of `auto

[PATCH] D94879: Implement dynamic mapAnyOf in terms of ASTNodeKinds

steveire updated this revision to Diff 317705. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94879/new/ https://reviews.llvm.org/D94879 Files: clang/lib/ASTMatchers/Dynamic/Marshallers.h Index: clang/lib/ASTMat

[PATCH] D94878: Make it possible to store a ASTNodeKind in VariantValue

steveire updated this revision to Diff 317704. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94878/new/ https://reviews.llvm.org/D94878 Files: clang/include/clang/ASTMatchers/Dynamic/VariantValue.h clang/lib/AS

[PATCH] D94877: Add API to retrieve a clade kind from ASTNodeKind

This revision was automatically updated to reflect the committed changes. Closed by commit rG0cd0eb6e0a81: Add API to retrieve a clade kind from ASTNodeKind (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94877?vs=317226&id=317703#toc Repository: rG LLVM Github

[clang] 0cd0eb6 - Add API to retrieve a clade kind from ASTNodeKind

Author: Stephen Kelly Date: 2021-01-19T22:51:30Z New Revision: 0cd0eb6e0a8133ec86d884c1bbc9c3cbd1769c0b URL: https://github.com/llvm/llvm-project/commit/0cd0eb6e0a8133ec86d884c1bbc9c3cbd1769c0b DIFF: https://github.com/llvm/llvm-project/commit/0cd0eb6e0a8133ec86d884c1bbc9c3cbd1769c0b.diff LOG:

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

dblaikie added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only, except to differentiate + // between lambdas. + if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda()) rnk

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

cebowleratibm accepted this revision. cebowleratibm added a comment. This revision is now accepted and ready to land. Minor suggestion to keep and remap some of the diagnostic cases. Comment at: clang/test/CodeGen/altivec.c:13 // RUN: not %clang -S -emit-llvm -maltivec -target

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang updated this revision to Diff 317701. akhuang added a comment. Remove lambda change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95001/new/ https://reviews.llvm.org/D95001 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX

[PATCH] D94876: Remove TypedMatcherOps from VariantValue

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d112a8eda9d: Remove TypedMatcherOps from VariantValue (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94876/new/ https://reviews.

[clang] 8d112a8 - Remove TypedMatcherOps from VariantValue

Author: Stephen Kelly Date: 2021-01-19T22:39:58Z New Revision: 8d112a8eda9d78bc4c97cf7bc9e133afae7b6eed URL: https://github.com/llvm/llvm-project/commit/8d112a8eda9d78bc4c97cf7bc9e133afae7b6eed DIFF: https://github.com/llvm/llvm-project/commit/8d112a8eda9d78bc4c97cf7bc9e133afae7b6eed.diff LOG:

[clang] 18e093f - [msabi] Mangle a template argument referring to array-to-pointer decay

Author: Richard Smith Date: 2021-01-19T14:38:07-08:00 New Revision: 18e093faf726d15f210ab4917142beec51848258 URL: https://github.com/llvm/llvm-project/commit/18e093faf726d15f210ab4917142beec51848258 DIFF: https://github.com/llvm/llvm-project/commit/18e093faf726d15f210ab4917142beec51848258.diff

[PATCH] D94957: [clang][cli] Port more options to new parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94957/new/ https://reviews.llvm.org/D94957

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1050-1052 + // Don't include a linkage name in line tables only, except to differentiate + // between lambdas. + if (CGM.getCodeGenOpts().hasReducedDebugInfo() || RD->isLambda()) We discu

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added a comment. Welcome back, hope you had a good time off. Thanks for the review! Comment at: clang/lib/APINotes/APINotesWriter.cpp:35 + bool SwiftImportAsMember = false; +#endif + martong wrote: > compnerd wrote: > > Please ignore this `#if`-defed

[PATCH] D95002: [RISCV] Update B extension version to 0.93.

craig.topper created this revision. craig.topper added reviewers: asb, luismarques, frasercrmck, lewis-revill, simoncook, PaoloS, kito-cheng. Herald added subscribers: NickHung, evandro, apazos, sameer.abuasal, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tra added a comment. In D94884#2508000 , @JonChesterfield wrote: > I won't object too strongly, as ultimately I don't care about cuda, but I > view intertwining the two implementations as technical debt. +1 A lot of CUDA-releated headers are not intende

[PATCH] D94864: [ASTMatchers] Re-order the internals to allow another use-case

This revision was automatically updated to reflect the committed changes. Closed by commit rGecf696641e6c: [ASTMatchers] Allow use of mapAnyOf in more contexts (authored by stephenkelly). Changed prior to commit: https://reviews.llvm.org/D94864?vs=317175&id=317690#toc Repository: rG LLVM Git

[clang] ecf6966 - [ASTMatchers] Allow use of mapAnyOf in more contexts

Author: Stephen Kelly Date: 2021-01-19T22:10:09Z New Revision: ecf696641e6ce4b22e8c8ea3c7476b9c1f0f200b URL: https://github.com/llvm/llvm-project/commit/ecf696641e6ce4b22e8c8ea3c7476b9c1f0f200b DIFF: https://github.com/llvm/llvm-project/commit/ecf696641e6ce4b22e8c8ea3c7476b9c1f0f200b.diff LOG:

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 added a comment. In D94884#2508000 , @JonChesterfield wrote: > Note that a cuda-free openmp devicertl compilation doesn't require this > patch, or any other pieces of cuda headers. Yes, we can write all code with CUDA built-in or others i

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

dexonsmith added a comment. In D94472#2507361 , @jansvoboda11 wrote: > Thanks for putting your time into the comment, @dexonsmith. > > I agree that adding a `-round-trip-args` flag to enable/disable > round-tripping is more sensible than hard-coding it v

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

JonChesterfield added a comment. I don't think introducing everything from the cuda namespace into openmp nvptx offloading is a feature. Inevitably people will call threadIdx.x instead of the openmp or clang equivalent, and this will mask missing functionality in openmp. I won't object too stro

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

HazardyKnusperkeks updated this revision to Diff 317679. HazardyKnusperkeks added a comment. Found and fixed the case when no `BasedOnStyle` apart from `InheritParentConfig` is used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93844/new/ https:/

[PATCH] D95001: [CodeView] Emit function types in -gline-tables-only.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. akhuang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds function types to further differentiate between FUNC_IDs in -gline-tables-only. Size increase o

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

JonChesterfield added a comment. Nice! Thank you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94871/new/ https://reviews.llvm.org/D94871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D93095: Introduce -Wreserved-identifier

serge-sans-paille updated this revision to Diff 317677. serge-sans-paille added a comment. As suggested by @aaron.ballman base the detection of top-level-ness on `Sema::LookupName` to avoid re-implementing the wheel. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93095/new/ https://revi

[clang] ce24bb0 - [ASTMatchers] NFC Rearrange declarations to allow more arg adapting

Author: Stephen Kelly Date: 2021-01-19T21:32:42Z New Revision: ce24bb0eddab12460a01e4d91faa435f2fc84bb6 URL: https://github.com/llvm/llvm-project/commit/ce24bb0eddab12460a01e4d91faa435f2fc84bb6 DIFF: https://github.com/llvm/llvm-project/commit/ce24bb0eddab12460a01e4d91faa435f2fc84bb6.diff LOG:

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM for `__clang_cuda_builtin_vars.h`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.llvm.org/D94884

[PATCH] D94820: Support for instrumenting only selected files or functions

davidxl added inline comments. Comment at: clang/docs/SourceBasedCodeCoverage.rst:77 +the files and functions specified in ``file.list`` will be instrumented. The +option can be specified multiple times to pass multiple files: + perhaps documenting how compiler

[PATCH] D94814: [HIP] Support `__managed__` attribute

tra added a comment. Presumably, `__managed__` variables would have to be memory-mapped into the host address space. Comment at: clang/lib/CodeGen/CGCUDANV.cpp:391 + SmallVector, 8> WorkList; + for (auto &&UU : Var->uses()) { +WorkList.push_back({UU.getUser()});

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

yaxunl added a comment. In D85223#2507518 , @tra wrote: > I'd propose splitting the patch into two. One with the addition of CUID and > the other that changes the way we havdle static vars. > CUID is useful on its own and is relatively uncontroversial. >

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

jgreenhalgh added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1087 FeatureNEON, + FeatureOutlineAtomics, FeaturePerfMon, t.p.northover wrote: > ilinpv wrote: > > t.p.northover wro

[PATCH] D94865: [ASTMatchers] Add callOrConstruct matcher

steveire added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867 +extern const internal::MapAnyOfMatcher +callOrConstruct; + aaron.ballman wrote: > I'm not super keen on this name. It's certainly descriptive, but I do wonder > i

[PATCH] D94333: [Inliner] Change inline remark format and update ReplayInlineAdvisor to use it

wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:412 + + Remark << ";"; } modimo wrote: > wenlei wrote: > > nit: any special reason for adding this? doesn't seem consistent with other > > remarks we have. > If you grab the remark o

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 updated this revision to Diff 317664. tianshilei1992 added a comment. Renamed the macro and undef it after use Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.llvm.org/D94884 Files: clang/lib/Headers/__cla

[clang] da98651 - Revert "DR2064: decltype(E) is only a dependent type if E is type-dependent, not

Author: Richard Smith Date: 2021-01-19T12:48:40-08:00 New Revision: da986511fb9da1a46a0ca4dba2e49e2426036303 URL: https://github.com/llvm/llvm-project/commit/da986511fb9da1a46a0ca4dba2e49e2426036303 DIFF: https://github.com/llvm/llvm-project/commit/da986511fb9da1a46a0ca4dba2e49e2426036303.diff

[clang] 5a684b7 - Ensure we don't strip the ConstantExpr carrying a non-type template

Author: Richard Smith Date: 2021-01-19T12:48:39-08:00 New Revision: 5a684b70dc74f9f671f8eb61993a25769ec68117 URL: https://github.com/llvm/llvm-project/commit/5a684b70dc74f9f671f8eb61993a25769ec68117 DIFF: https://github.com/llvm/llvm-project/commit/5a684b70dc74f9f671f8eb61993a25769ec68117.diff

[PATCH] D91261: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb272698de790: [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives. (authored by ABataev). Changed prior to commit: https://review

[clang] b272698 - [OPENMP]Do not use OMP_MAP_TARGET_PARAM for data movement directives.

Author: Alexey Bataev Date: 2021-01-19T12:41:15-08:00 New Revision: b272698de790d6603db7992c0c0ad6446b7a52b8 URL: https://github.com/llvm/llvm-project/commit/b272698de790d6603db7992c0c0ad6446b7a52b8 DIFF: https://github.com/llvm/llvm-project/commit/b272698de790d6603db7992c0c0ad6446b7a52b8.diff

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:31 +#ifdef __OPENMP_NVPTX__ +#define DEVICE +#else You should use `__` prefix to avoid unintentional clashes with user-defined macros. `__DEVICE__` ? Comment

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

dim added a comment. @sylvestre.ledru removed the minor version from the binary (on purpose, I think?) in rGa8b717fda42294d1c8e1f05d71280503e5839f14 : commit a8b717fda42294d1c8e1f05d71280503e5839f14 Author: Sylvestre Ledru

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:40 +#ifdef __cplusplus #define __CUDA_DEVICE_BUILTIN(FIELD, INTRINSIC) \ tra wrote:

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tianshilei1992 updated this revision to Diff 317647. tianshilei1992 added a comment. Refined the patch to make it only work in C++ mode. In C mode everything is unchanged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94884/new/ https://reviews.ll

[PATCH] D94854: [Clang] Fix SwiftCallingConv's aggregate lowering for _Atomic(_Bool).

varungandhi-apple abandoned this revision. varungandhi-apple added a comment. Closing this in favor of a Swift-side fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94854/new/ https://reviews.llvm.org/D94854 _

[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

leonardchan added a comment. In D93668#2492081 , @phosek wrote: > I agree that if we want to allow selecting C++ ABI only, a flag like > `-fc++abi=` with some additional checks to disallow invalid combinations is > better. The question is whether we want

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, ParentName, LineNum)) + initializeTargetRegionEntryInfo(

[PATCH] D90188: Add support for attribute 'using_if_exists'

Quuxplusone added inline comments. Comment at: clang/test/SemaCXX/using-if-exists.cpp:11 + +using NotNS::x UIE; // expected-error{{use of undeclared identifier 'NotNS'}} +} // test_basic Do you also have a test for `using NS::NotNS::x UIE;`? (Both of these `NotNS

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

tianshilei1992 marked 6 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:2944-2947 +// This could happen if the device compilation is invoked standalone. +if (!hasTargetRegionEntryInfo(DeviceID, FileID, Paren

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added a comment. (I didn't mean to submit the last comment before I finished the review, sorry) It looks like you've chosen to treat this as a DR that we should apply under all standards. Have you investigated whether it causes compatibility problems? It does look like it'd be painfu

[PATCH] D85223: [CUDA][HIP] Support accessing static device variable in host code for -fgpu-rdc

tra added a comment. I'd propose splitting the patch into two. One with the addition of CUID and the other that changes the way we havdle static vars. CUID is useful on its own and is relatively uncontroversial. Externalizing static vars is a more interesting issue and I'm not sure what's the b

[PATCH] D94871: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

This revision was automatically updated to reflect the committed changes. Closed by commit rG82e537a9d28a: [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program… (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] 82e537a - [Clang][OpenMP] Fixed an issue that clang crashed when compiling OpenMP program in device only mode without host IR

Author: Shilei Tian Date: 2021-01-19T14:18:42-05:00 New Revision: 82e537a9d28a2c18bd1637e2eac0e0af658ed829 URL: https://github.com/llvm/llvm-project/commit/82e537a9d28a2c18bd1637e2eac0e0af658ed829 DIFF: https://github.com/llvm/llvm-project/commit/82e537a9d28a2c18bd1637e2eac0e0af658ed829.diff L

[clang] e678656 - Add bounds checking assertions to APValue, NFC

Author: Reid Kleckner Date: 2021-01-19T11:15:02-08:00 New Revision: e678656625a3e2b6a5f2849f4a6f7612ceeaed07 URL: https://github.com/llvm/llvm-project/commit/e678656625a3e2b6a5f2849f4a6f7612ceeaed07 DIFF: https://github.com/llvm/llvm-project/commit/e678656625a3e2b6a5f2849f4a6f7612ceeaed07.diff

[clang] 6f69f2e - Consider ASan messages interesting for creduce

Author: Reid Kleckner Date: 2021-01-19T11:15:02-08:00 New Revision: 6f69f2ed61ae805df496fc86ef22e7685573d556 URL: https://github.com/llvm/llvm-project/commit/6f69f2ed61ae805df496fc86ef22e7685573d556 DIFF: https://github.com/llvm/llvm-project/commit/6f69f2ed61ae805df496fc86ef22e7685573d556.diff

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rjmccall added a comment. How does this new rule work if we find overlapping but non-equal sets of declarations in different subobjects? I'm sure you can get that with `using` declarations. Comment at: clang/include/clang/AST/CXXInheritance.h:77 - CXXBasePath() = default;

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGCleanup.cpp:1341 + llvm::FunctionCallee SehCppScope = + CGM.CreateRuntimeFunction(FTy, "llvm.seh.scope.begin"); + EmitSehScope(*this, SehCppScope); We generally prefer to get intrinsic functio

[clang] 987760b - [www] Fix background color in table cell.

Author: Richard Smith Date: 2021-01-19T11:04:31-08:00 New Revision: 987760b463c1303121fff8197c4ebc66b61f0616 URL: https://github.com/llvm/llvm-project/commit/987760b463c1303121fff8197c4ebc66b61f0616 DIFF: https://github.com/llvm/llvm-project/commit/987760b463c1303121fff8197c4ebc66b61f0616.diff

[PATCH] D93585: [AArch64] Enable out-of-line atomics by default.

t.p.northover added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64.td:1087 FeatureNEON, + FeatureOutlineAtomics, FeaturePerfMon, ilinpv wrote: > t.p.northover wrote: > > I think this st

[PATCH] D94884: [Clang][OpenMP] Include header for CUDA builtin vars into OpenMP wrapper header

tra added inline comments. Comment at: clang/lib/Headers/__clang_cuda_builtin_vars.h:40 +#ifdef __cplusplus #define __CUDA_DEVICE_BUILTIN(FIELD, INTRINSIC) \ Perhaps we should move all C++-related code under `#ifdef __cplusplus`

[PATCH] D94599: [clang][Tooling] Get rid of a hack in SymbolOccurrences, NFCI

miyuki updated this revision to Diff 317627. miyuki edited the summary of this revision. miyuki added a comment. Added `static_assert`s that check that `SourceRange` and `SourceLocation` are trivially destructible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D94987: DR39: Perform ambiguous subobject checks for class member access as part of object argument conversion, not as part of name lookup.

rsmith created this revision. rsmith added a reviewer: rjmccall. rsmith requested review of this revision. Herald added a project: clang. Under C++ core issue 39, the rules for class-scope name lookup were reworked so that name lookup no longer concerns itself with whether the names were found in

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG17846ed5af4a: [clangd] Use ASTSignals in Heuristics CC Ranking. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang-tools-extra] 17846ed - [clangd] Use ASTSignals in Heuristics CC Ranking.

Author: Utkarsh Saxena Date: 2021-01-19T19:48:42+01:00 New Revision: 17846ed5af4a83334ef7d07f0b4a9d525e6ec0db URL: https://github.com/llvm/llvm-project/commit/17846ed5af4a83334ef7d07f0b4a9d525e6ec0db DIFF: https://github.com/llvm/llvm-project/commit/17846ed5af4a83334ef7d07f0b4a9d525e6ec0db.diff

[PATCH] D94986: Remove requirement for -maltivec to be used when using -mabi=vec-extabi or -mabi=vec-default when not using vector code

ZarkoCA created this revision. ZarkoCA added reviewers: cebowleratibm, hubert.reinterpretcast, sfertile, Xiangling_L, etiotto. ZarkoCA requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we are not using vector code `-maltivec` should not b

[PATCH] D33029: [clang-format] add option for dangling parenthesis

blandcr added a comment. Hi, this is a pretty desirable feature for me and I see there hasn't been any work for a few months. Is this still being worked on and/or is there anything I can do to help it along? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33029/new/ https://reviews.llvm

[PATCH] D94472: [WIP][clang][cli] Command line round-trip for HeaderSearch options

jansvoboda11 added a comment. Thanks for putting your time into the comment, @dexonsmith. I agree that adding a `-round-trip-args` flag to enable/disable round-tripping is more sensible than hard-coding it via something like `#ifndef NDEBUG`. Providing `-round-trip-args-debug-mode` to help with

[PATCH] D94927: [clangd] Use ASTSignals in Heuristics CC Ranking.

usaxena95 updated this revision to Diff 317613. usaxena95 marked an inline comment as done. usaxena95 added a comment. Added a comment about the calculation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94927/new/ https://reviews.llvm.org/D94927

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

bjope added a comment. In D94979#2507242 , @lebedev.ri wrote: > As far as i recall, all RFC's about LLVM support for non-8-bit char targets > didn't end in favor of the proposal > I'd say that until there's general consensus/buy-in (including testing path

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

lebedev.ri added subscribers: jfb, lebedev.ri. lebedev.ri added a comment. As far as i recall, all RFC's about LLVM support for non-8-bit char targets didn't end in favor of the proposal I'd say that until there's general consensus/buy-in (including testing path), cleaning stuff up will only con

[PATCH] D94624: PATCH] [clang-query] Add a --use-color option to clang-query to allow forcing the behavior

aaron.ballman added a comment. In D94624#2506906 , @tomrittervg wrote: > In D94624#2506831 , @aaron.ballman > wrote: > >> In D94624#2501894 , @tomrittervg >> wrote: >> >>>

[PATCH] D94979: [CGExpr] Honor getCharWidth() in ConstantAggregateBuilderUtils

bjope created this revision. bjope requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In CGExprConstant.cpp, when dealing with padding etc, some sizes are calculated as char units. But then the type used when creating the aggregate expression

[PATCH] D94977: [CodeGen] Honor getCharWidth() in CGRecordLowering

bjope created this revision. bjope requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using getByteArrayType the requested size was calculated in char units, but the type used for the array was hardcoded to the Int8Ty. Honor the size of c

[PATCH] D94906: [clang-format] Apply Allman style to lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbdde495ba28: [clang-format] Apply Allman style to lambdas (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94906/new/ https:

  1   2   >