[PATCH] D94039: [WebAssembly] Update WasmEHPrepare for the new spec

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9724c3cff46f: [WebAssembly] Update WasmEHPrepare for the new spec (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] 9724c3c - [WebAssembly] Update WasmEHPrepare for the new spec

Author: Heejin Ahn Date: 2021-01-08T23:38:26-08:00 New Revision: 9724c3cff46fb9e333df7d27b44758b4aba07168 URL: https://github.com/llvm/llvm-project/commit/9724c3cff46fb9e333df7d27b44758b4aba07168 DIFF: https://github.com/llvm/llvm-project/commit/9724c3cff46fb9e333df7d27b44758b4aba07168.diff LO

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt updated this revision to Diff 315573. rgreenblatt added a comment. Fixed completion extension bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94337/new/ https://reviews.llvm.org/D94337 Files: clang/include/clang/Driver/Types.def

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy updated this revision to Diff 315572. hoy added a comment. Removing the UniqueDebugLinakgeNames switch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93747/new/ https://reviews.llvm.org/D93747 Files: llvm/include/llvm/IR/DebugInfoMetadata.h

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

hoy added a comment. In D93747#2488399 , @dblaikie wrote: > In D93747#2488390 , @tmsriram wrote: > >> In D93747#2488387 , @dblaikie wrote: >> >>> Seems alright to me - I thin

[PATCH] D49916: [CodeGen] Add to emitted DebugLoc information about coverage when it's required

MaskRay added a comment. @calixte This was reverted and never relanded. Is D49915 (DILocation::ImplicitCode) still needed? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49916/new/ https://reviews.llvm.org/D49916 ___

[PATCH] D87147: PR-47391 : Two DIFile entries are describing the same file two different ways

This revision was automatically updated to reflect the committed changes. Closed by commit rG33c8e16f660d: PR47391: Canonicalize DIFiles (authored by umesh.kalappa0, committed by dblaikie). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorep

[clang] 33c8e16 - PR47391: Canonicalize DIFiles

Author: Umesh Kalappa Date: 2021-01-08T22:11:16-08:00 New Revision: 33c8e16f660de9bbe177c1bf821063c146278d8e URL: https://github.com/llvm/llvm-project/commit/33c8e16f660de9bbe177c1bf821063c146278d8e DIFF: https://github.com/llvm/llvm-project/commit/33c8e16f660de9bbe177c1bf821063c146278d8e.diff

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie added a comment. In D93747#2488390 , @tmsriram wrote: > In D93747#2488387 , @dblaikie wrote: > >> Seems alright to me - I think we've hashed out the deeper issues (missing >> opportunity for C functions wh

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

tmsriram added a comment. In D93747#2488387 , @dblaikie wrote: > Seems alright to me - I think we've hashed out the deeper issues (missing > opportunity for C functions which could/should be addressed by moving the > implementation to the frontend, where

[PATCH] D93747: Rename debug linkage name with -funique-internal-linkage-names

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems alright to me - I think we've hashed out the deeper issues (missing opportunity for C functions which could/should be addressed by moving the implementation to the frontend, where th

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt updated this revision to Diff 315568. rgreenblatt added a comment. Fused commits so CI passes??? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94337/new/ https://reviews.llvm.org/D94337 Files: clang/include/clang/Driver/Types.def c

[PATCH] D94268: Allow _mm_empty() (via llvm.x86.mmx.emms) to be a no-op without MMX.

jyknight abandoned this revision. jyknight added a comment. OK thanks -- abandoning this patch. I'll adjust the comment on _mm_empty to mention that it's no longer necessary except with asm in the intrinsics patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D94268: Allow _mm_empty() (via llvm.x86.mmx.emms) to be a no-op without MMX.

pengfei added a comment. In D94268#2487765 , @jyknight wrote: > In D94268#2485958 , @pengfei wrote: > >> Is inline assembly the only case `emms` instruction will be needed? But >> inline assembly doesn't enable `mm

[clang-tools-extra] 467cbd2 - [clangd][NFC] Remove unnecessary copy in CodeComplete

Author: Nathan James Date: 2021-01-09T02:32:23Z New Revision: 467cbd2981840745a84dda07855c4e41501f6903 URL: https://github.com/llvm/llvm-project/commit/467cbd2981840745a84dda07855c4e41501f6903 DIFF: https://github.com/llvm/llvm-project/commit/467cbd2981840745a84dda07855c4e41501f6903.diff LOG:

[clang] aab25fa - Never call a destroying operator delete when cleaning up from an

Author: Richard Smith Date: 2021-01-08T16:51:47-08:00 New Revision: aab25fa7d853d6da960607310e2cd3e3a843d5a9 URL: https://github.com/llvm/llvm-project/commit/aab25fa7d853d6da960607310e2cd3e3a843d5a9 DIFF: https://github.com/llvm/llvm-project/commit/aab25fa7d853d6da960607310e2cd3e3a843d5a9.diff

[PATCH] D94231: [clang][Sema] Compare SourceLocations directly [NFCI]

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Based on your explanation, this seems good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94231/new/ https://reviews.llvm.org/D94231

[PATCH] D94224: [clang][AST] Get rid of an alignment hack in DeclObjC.h [NFCI]

aprantl added inline comments. Comment at: clang/include/clang/AST/DeclObjC.h:660 + /// Location of the left and right angle brackets. + alignas(ObjCTypeParamDecl *) SourceRange Brackets; /// The number of parameters in the list, which are tail-allocated. Ca

[PATCH] D94349: Fix some missing applications of TY_CUDAHeader

rgreenblatt abandoned this revision. rgreenblatt added a comment. Oops didn't mean to open new revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94349/new/ https://reviews.llvm.org/D94349 ___ cfe-c

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt updated this revision to Diff 315542. rgreenblatt added a comment. Fixed some missing applications Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94337/new/ https://reviews.llvm.org/D94337 Files: clang/lib/Driver/Driver.cpp clang/li

[PATCH] D94349: Fix some missing applications of TY_CUDAHeader

rgreenblatt created this revision. Herald added a subscriber: yaxunl. rgreenblatt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94349 Files: clang/lib/Driver/Driver.cpp

[PATCH] D93743: [NewPM] Run ObjC ARC passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG756dd707668c: [NewPM] Run ObjC ARC passes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/ https://reviews.llvm.org/D93743

[clang] 756dd70 - [NewPM] Run ObjC ARC passes

Author: Arthur Eubanks Date: 2021-01-08T15:47:11-08:00 New Revision: 756dd707668ccc1ac22b88d5899984843a5a3262 URL: https://github.com/llvm/llvm-project/commit/756dd707668ccc1ac22b88d5899984843a5a3262 DIFF: https://github.com/llvm/llvm-project/commit/756dd707668ccc1ac22b88d5899984843a5a3262.diff

[PATCH] D93743: [NewPM] Run ObjC ARC passes

ahatanak added a comment. OK, I see. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93743/new/ https://reviews.llvm.org/D93743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D94325: [DebugInfo][CodeView] Use a fancier function display name when using line tables only to better differentiate between functions.

rnk added a comment. I put some comments on https://bugs.llvm.org/show_bug.cgi?id=48432#c4 about this. I'm not sure we should keep going this direction. Thanks for getting numbers, though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94325/new/

[clang] 2bf6e44 - Attempt to complete an incomplete expression type when considering a

Author: Richard Smith Date: 2021-01-08T15:19:28-08:00 New Revision: 2bf6e443e54604c7818c4d1a1837f3d091023270 URL: https://github.com/llvm/llvm-project/commit/2bf6e443e54604c7818c4d1a1837f3d091023270 DIFF: https://github.com/llvm/llvm-project/commit/2bf6e443e54604c7818c4d1a1837f3d091023270.diff

[PATCH] D93743: [NewPM] Run ObjC ARC passes

aeubanks added a comment. In D93743#2487987 , @ahatanak wrote: > LGTM. ARC contract pass isn't being run by the NPM, but you are going to > change that in the future, I guess? Looks like that's part of the codegen pipeline and not the optimization pipel

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

This revision was automatically updated to reflect the committed changes. Closed by commit rGe05baf40de8a: [InitLLVM] Ensure SIGPIPE handler installed before sigaction() (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94324/new/ htt

[clang] e05baf4 - [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

Author: Vedant Kumar Date: 2021-01-08T15:13:04-08:00 New Revision: e05baf40de8a3bbfcf4a765761b1147e94b7309c URL: https://github.com/llvm/llvm-project/commit/e05baf40de8a3bbfcf4a765761b1147e94b7309c DIFF: https://github.com/llvm/llvm-project/commit/e05baf40de8a3bbfcf4a765761b1147e94b7309c.diff

[PATCH] D94338: [Clang][Docs] Fix ambiguity in clang-offload-bundler docs

t-tye accepted this revision. t-tye added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94338/new/ https://reviews.llvm.org/D94338 ___ cfe

[PATCH] D93743: [NewPM] Run ObjC ARC passes

ahatanak accepted this revision. ahatanak added a comment. This revision is now accepted and ready to land. LGTM. ARC contract pass isn't being run by the NPM, but you are going to change that in the future, I guess? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

jdoerfert added a comment. In D94315#2487809 , @ABataev wrote: > In D94315#2487643 , @jdoerfert wrote: > >> What we should do, as we move to the OpenMPIRBuilder, is to use runtime >> interfaces that match OpenMP di

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek updated this revision to Diff 315516. rjelonek added a comment. upload diff via arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 Files: clang/lib/Format/Format.cpp clang/unittests/Format/Sor

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek updated this revision to Diff 315513. rjelonek added a comment. upload diff via arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 Files: clang/lib/Format/Format.cpp clang/unittests/Format/Sor

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315509. rjelonek added a comment. upload diff via arc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittests/Format/Sor

[PATCH] D94338: [Clang][Docs] Fix ambiguity in clang-offload-bundler docs

scott.linder created this revision. scott.linder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94338 Files: clang/docs/ClangOffloadBundler.rst Index: clang/docs/ClangOf

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. In D94315#2487643 , @jdoerfert wrote: > What we should do, as we move to the OpenMPIRBuilder, is to use runtime > interfaces that match OpenMP direct

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

NeHuang accepted this revision as: NeHuang. NeHuang added a comment. LGTM and please wait for Nemanja's approval before committing this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 ___ cfe-co

[PATCH] D94268: Allow _mm_empty() (via llvm.x86.mmx.emms) to be a no-op without MMX.

jyknight added a comment. In D94268#2485958 , @pengfei wrote: > Is inline assembly the only case `emms` instruction will be needed? But > inline assembly doesn't enable `mmx` attribute automatically, right? E.g. > https://godbolt.org/z/43ases Yes, inlin

[PATCH] D77056: [Sema] Allow non-member operators for sizeless SVE types

rsmith added a comment. In D77056#2465936 , @rsandifo-arm wrote: > Either way, I realise this isn't great style. It just seems like a practical > compromise between the rock of classes having a constant size and the hard > place of vectors having a var

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

mcgrathr added a comment. You've said you want to avoid expressing the C++ ABI as a generic switch orthogonal to target because people can use it when it's not what they actually want or isn't actually useful to attempt. This is true of all switches affecting ABI and they haven't all been reje

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt added a comment. I haven't added any tests for this change. This is my first commit, so I am not sure how to write a test or what tests are appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94337/new/ https://reviews.llvm.org/

[PATCH] D94337: Add cuda header type for cuh files

rgreenblatt created this revision. Herald added a subscriber: yaxunl. rgreenblatt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a cuda header type with file extension "cuh". The output type file extension is "cuhi" - not sure if

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

vsk added a comment. In D94324#2487572 , @aganea wrote: > What are the exact conditions to repro Nick's failure? On Fedora 32, I ran > `py llvm-lit sigpipe-handling.c` before this patch and before > rGbf401256edd00e921a5d3a0bf4cf6ee66ae51cd6 >

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

vsk updated this revision to Diff 315498. vsk added a comment. Reduce the test a bit further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94324/new/ https://reviews.llvm.org/D94324 Files: clang/test/Driver/sigpipe-handling.c llvm/include/llv

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e23fd676c39: [Driver] Add DWARF64 flag: -gdwarf64 (authored by hoy). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 0e23fd6 - [Driver] Add DWARF64 flag: -gdwarf64

Author: Hongtao Yu Date: 2021-01-08T12:58:38-08:00 New Revision: 0e23fd676c3984a2b867c167950464262c8e0dc6 URL: https://github.com/llvm/llvm-project/commit/0e23fd676c3984a2b867c167950464262c8e0dc6 DIFF: https://github.com/llvm/llvm-project/commit/0e23fd676c3984a2b867c167950464262c8e0dc6.diff LO

[clang] 16fdc5d - APINotes: annotate dump methods (NFC)

Author: Saleem Abdulrasool Date: 2021-01-08T20:49:28Z New Revision: 16fdc5da89068f646c153c6bd6c493b1d666bfbf URL: https://github.com/llvm/llvm-project/commit/16fdc5da89068f646c153c6bd6c493b1d666bfbf DIFF: https://github.com/llvm/llvm-project/commit/16fdc5da89068f646c153c6bd6c493b1d666bfbf.diff

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo updated this revision to Diff 315495. ayermolo added a comment. rebased on latest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/incl

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

jdoerfert added a subscriber: ggeorgakoudis. jdoerfert added a comment. What we should do, as we move to the OpenMPIRBuilder, is to use runtime interfaces that match OpenMP directives. Here is the `omp parallel` one for the host: D94332 The device one should loo

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! We may want to file a bug report for the static analyzer to not duplicate the diagnostics from the frontend now that this is no longer ignored by default. CHANGES SINCE LA

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

aganea added a comment. What are the exact conditions to repro Nick's failure? On Fedora 32, I ran `py llvm-lit sigpipe-handling.c` before this patch and before rGbf401256edd00e921a5d3a0bf4cf6ee66ae51cd6 , the test suceeds,

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

This revision was automatically updated to reflect the committed changes. Closed by commit rG0386f3d4f418: [NFC] Specify C11 in loop-opt-setup.c (authored by ormris). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94327/new/ https://reviews.llvm.org/

[clang] 0386f3d - [NFC] Specify C11 in loop-opt-setup.c

Author: Matthew Voss Date: 2021-01-08T12:15:26-08:00 New Revision: 0386f3d4f4183a93d7e029abef8110ae4f148335 URL: https://github.com/llvm/llvm-project/commit/0386f3d4f4183a93d7e029abef8110ae4f148335 DIFF: https://github.com/llvm/llvm-project/commit/0386f3d4f4183a93d7e029abef8110ae4f148335.diff

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

ormris added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94327/new/ https://reviews.llvm.org/D94327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D94289: [clangd] Add go-to-def metric.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e36d21fabcd: [clangd] Add go-to-def metric. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang-tools-extra] 8e36d21 - [clangd] Add go-to-def metric.

Author: Haojian Wu Date: 2021-01-08T21:03:59+01:00 New Revision: 8e36d21fabcd23835d17855025d06946eb0dfb9b URL: https://github.com/llvm/llvm-project/commit/8e36d21fabcd23835d17855025d06946eb0dfb9b DIFF: https://github.com/llvm/llvm-project/commit/8e36d21fabcd23835d17855025d06946eb0dfb9b.diff LO

[PATCH] D94289: [clangd] Add go-to-def metric.

hokein updated this revision to Diff 315480. hokein marked 3 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94289/new/ https://reviews.llvm.org/D94289 Files: clang-tools-extra/cla

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

nickdesaulniers added a comment. Much thanks for the patch! Comment at: clang/test/Driver/sigpipe-handling.c:2 +// REQUIRES: shell +// RUN: %clang -E -fno-integrated-cc1 %s | tee /dev/null | head -n1 | FileCheck %s + Looks like clang -E -fno-integrated-c

[PATCH] D77056: [Sema] Allow non-member operators for sizeless SVE types

rsandifo-arm added a comment. Ping. Also, please let me know if the response above doesn't answer the concerns and if you'd like more info/justification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77056/new/ https://reviews.llvm.org/D77056 __

[PATCH] D94321: [clangd] Prevent tests from failing when /tmp/compile_flags.txt exists

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, this looks like a reasonable workaround. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94321/new/ https://reviews.llvm.org/D94321 _

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

vsk updated this revision to Diff 315473. vsk added a comment. Fix a typo in the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94324/new/ https://reviews.llvm.org/D94324 Files: clang/test/Driver/sigpipe-handling.c llvm/include/llvm/Suppo

[PATCH] D94324: [InitLLVM] Ensure SIGPIPE handler installed before sigaction()

vsk updated this revision to Diff 315472. vsk added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a clang driver test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94324/new/ https://reviews.llvm.org/D94324

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7783-7784 "|%diff{casting $ to type $|casting between types}0,1}2" - " converts between pointers to integer types with different sign">, + " converts between pointers to integer

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb updated this revision to Diff 315471. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/Analysis/NewDelete-intersections.mm

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb updated this revision to Diff 315470. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/Analysis/NewDelete-intersections.mm

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

atmnpatel accepted this revision. atmnpatel added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94327/new/ https://reviews.llvm.org/D94327 __

[PATCH] D94327: [NFC] Specify C11 in loop-opt-setup.c

ormris created this revision. ormris added a reviewer: atmnpatel. ormris requested review of this revision. Herald added a project: clang. This test was failing in our internal CI, since our driver does not default to C11. Adding this switch fixes the issue. Repository: rG LLVM Github Monorep

[PATCH] D94325: [DebugInfo][CodeView] Use a fancier function display name when using line tables only to better differentiate between functions.

akhuang created this revision. akhuang added reviewers: rnk, dblaikie. Herald added a subscriber: hiraditya. akhuang requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Previously we emitted the fully qualified name when using

[PATCH] D93668: [clang] Add -ffuchsia-c++-abi flag to explicitly use the Fuchsia C++ ABI

rnk added a comment. In D93668#2485719 , @mcgrathr wrote: > It's fine to have a target tuple translate to a default C++ ABI. > But the C++ ABI selection is fundamentally not a target flavor thing. It's > just a C++ ABI thing. > So using the target tuple

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

jdoerfert added a comment. In D94315#2487259 , @ABataev wrote: > In D94315#2487257 , @jdoerfert wrote: > >> In D94315#2487244 , @ABataev wrote: >> >>> In D94315#2487242

[PATCH] D93942: [OpenCL] Improve online documentation.

Anastasia updated this revision to Diff 315447. Anastasia added a comment. Added the correction from Sven. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93942/new/ https://reviews.llvm.org/D93942 Files: clang/docs/OpenCLSupport.rst clang/docs/UsersManual.rst Index: clang/docs/User

[PATCH] D94321: [clangd] Prevent tests from failing when /tmp/compile_flags.txt exists

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. The BuildDir test uses RealFS and would fail when /tmp/compile_flags.txt or

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

ABataev added a comment. In D94315#2487257 , @jdoerfert wrote: > In D94315#2487244 , @ABataev wrote: > >> In D94315#2487242 , @jdoerfert >> wrote: >> >>> I don't understand

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

jdoerfert added a comment. In D94315#2487244 , @ABataev wrote: > In D94315#2487242 , @jdoerfert wrote: > >> I don't understand where `inaccessiblemem_or_argmemonly` is coming from. >> This prevents us from inlining

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7783-7784 "|%diff{casting $ to type $|casting between types}0,1}2" - " converts between pointers to integer types with different sign">, + " converts between pointers t

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

ABataev added a comment. In D94315#2487242 , @jdoerfert wrote: > In D94315#2487164 , @ABataev wrote: > >> In D94315#2487150 , >> @JonChesterfield wrote: >> >>> I'm guessing

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

jdoerfert added a comment. In D94315#2487164 , @ABataev wrote: > In D94315#2487150 , @JonChesterfield > wrote: > >> I'm guessing we're using the function boundary as a compiler barrier. That >> seems fragile in th

[PATCH] D94217: [clang-format] Find main include after block ended with #pragma hdrstop

rjelonek updated this revision to Diff 315431. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94217/new/ https://reviews.llvm.org/D94217 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94206: [clang-format] turn on formatting after "clang-format on" while sorting includes

rjelonek updated this revision to Diff 315428. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94206/new/ https://reviews.llvm.org/D94206 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek added a comment. @curdeius Can you commit this patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D94201: [clang-format] Skip UTF8 Byte Order Mark while sorting includes

rjelonek updated this revision to Diff 315424. rjelonek added a comment. rebase patch on master/main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94201/new/ https://reviews.llvm.org/D94201 Files: clang/lib/Format/Format.cpp clang/unittests/Format/SortIncludesTest.cpp Index: clan

[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

nickdesaulniers added a comment. Compiler crash reported in: https://bugs.llvm.org/show_bug.cgi?id=48695 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78105/new/ https://reviews.llvm.org/D78105 ___ cfe-c

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

ABataev added a comment. In D94315#2487150 , @JonChesterfield wrote: > I'm guessing we're using the function boundary as a compiler barrier. That > seems fragile in the face of improving cross-function optimisation. Looks like applying inaccessiblemem_o

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

JonChesterfield added a comment. I'm guessing we're using the function boundary as a compiler barrier. That seems fragile in the face of improving cross-function optimisation. What is the invariant we want around entry to a data environment, which happens to be met by a function boundary? Rep

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

whisperity added a comment. In D69560#2487117 , @aaron.ballman wrote: > In D69560#2487093 , @whisperity > wrote: > >> Not sure what CVR-modelling's default should be... it finds less when "off", >> but too easily

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

aaron.ballman added a comment. In D69560#2487093 , @whisperity wrote: > I have posted two questions to GitHub, mostly related to the guideline rule > and how free the implementation could be: #1732 >

[PATCH] D94169: [clang][driver] Restore the original help text for `-I`

awarzynski added a comment. Thank you all for your input. Let me summarize. **SUGGESTION 1** Tweak the wording to clarify that it is Clang-specific. That's a good compromise IMO. It highlights that the described semantics apply to Clang only. And I'm not aware of any other way to achieve this r

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7783-7784 "|%diff{casting $ to type $|casting between types}0,1}2" - " converts between pointers to integer types with different sign">, + " converts between pointers to integer

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

whisperity added a comment. I have posted two questions to GitHub, mostly related to the guideline rule and how free the implementation could be: #1732 and #1733 , I think I tagged y

[PATCH] D94315: [OpenMP][FIX] Enforce a function boundary for a new data environment

jdoerfert created this revision. jdoerfert added reviewers: JonChesterfield, ABataev, sstefan1. Herald added subscribers: guansong, bollu, yaxunl. jdoerfert requested review of this revision. Herald added a project: clang. Whenever we enter a new OpenMP data environment we want to enter a function

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

aganea added a comment. In D86694#2463429 , @russell.gallop wrote: > - With scudo all lit tests (generally) pass, but there are some intermittent > failures (Access Violation) on the following tests: > >> ExecutionEngine/MCJIT/test-global-init-nonzero-sm

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-parameters-of-the-same-type' check

aaron.ballman added a comment. In D69560#2486806 , @whisperity wrote: > I was just about to write an issue to the CoreGuidelines project, but I was > @vingeldal has posted about "relatedness" before me: > https://github.com/isocpp/CppCoreGuidelines/issue

[PATCH] D94314: [clangd] Add missing "override" to fix the build.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e1bb7940a4d: [clangd] Add missing "override" to fix the build. (a

[clang-tools-extra] 2e1bb79 - [clangd] Add missing "override" to fix the build.

Author: Adam Czachorowski Date: 2021-01-08T17:24:47+01:00 New Revision: 2e1bb7940a4ddc847cebd25092d10f40866a7fad URL: https://github.com/llvm/llvm-project/commit/2e1bb7940a4ddc847cebd25092d10f40866a7fad DIFF: https://github.com/llvm/llvm-project/commit/2e1bb7940a4ddc847cebd25092d10f40866a7fad.d

[PATCH] D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char

hubert.reinterpretcast added a comment. Ping, @aaron.ballman? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93999/new/ https://reviews.llvm.org/D93999 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D94314: [clangd] Add missing "override" to fix the build.

adamcz created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up to d4af86581e80ef0f7a6f4a4fff1c97260a726e71

[PATCH] D93095: Introduce -Wreserved-identifier

aaron.ballman added inline comments. Comment at: clang/lib/AST/Decl.cpp:1099 +const DeclContext *CurrentContext = getDeclContext(); +while (true) { + if (isa(CurrentContext)) Rather than trying to manually decide whether the name will be exposed at t

[clang] d4af865 - [clangd] Fix type printing in the presence of qualifiers

Author: Adam Czachorowski Date: 2021-01-08T17:00:39+01:00 New Revision: d4af86581e80ef0f7a6f4a4fff1c97260a726e71 URL: https://github.com/llvm/llvm-project/commit/d4af86581e80ef0f7a6f4a4fff1c97260a726e71 DIFF: https://github.com/llvm/llvm-project/commit/d4af86581e80ef0f7a6f4a4fff1c97260a726e71.d

[PATCH] D94259: [clangd] Fix type printing in the presence of qualifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4af86581e80: [clangd] Fix type printing in the presence of qualifiers (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

  1   2   >