[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

2020-12-12 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In D92409#2450550 , @thopre wrote: > In D92409#2426196 , @thopre wrote: > >> Is there a way to disable it from the header? I've noticed this warning when >> compiling an application using li

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks. The tests still work fine on my machine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 ___

LLVM buildmaster will be restarted tonight

2020-12-12 Thread Galina Kistanova via cfe-commits
Hello everyone, LLVM buildmaster will be restarted at 9PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-12 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 updated this revision to Diff 311423. kaz7 added a comment. Rebase and update following suggestions. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93084/new/ https://reviews.llvm.org/D93084 Files: clang/test/Driver/Inputs/basic_ve_

[PATCH] D93084: [VE] Optimize toolchain regression test

2020-12-12 Thread Kazushi Marukawa via Phabricator via cfe-commits
kaz7 added a comment. Thank you for suggestions. Comment at: clang/test/Driver/ve-toolchain.cpp:115 +// DEF-SAME: "-z" "max-page-size=0x400" +// DEF-SAME: "crtbegin.o" +// DEF-SAME: "-lc++" "-lc++abi" "-lunwind" "-lpthread" "-ldl" MaskRay wrote: > You proba

[PATCH] D92409: [AST][NFC] Silence GCC warning about multiline comments

2020-12-12 Thread Thomas Preud'homme via Phabricator via cfe-commits
thopre added a comment. In D92409#2426196 , @thopre wrote: > In D92409#2426188 , @rsmith wrote: > >> Let's just disable this broken GCC warning. IIRC, the corresponding clang >> warning covers the actual bugs cause

[PATCH] D93170: [clang-format][NFC] Expand BreakBeforeBraces examples

2020-12-12 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added a reviewer: MyDeveloperDay. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github

[PATCH] D92782: [CodeGen][AMDGPU] Fix ICE for static initializer IR generation

2020-12-12 Thread Alexey Bader via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa500a4358789: [CodeGen][AMDGPU] Fix ICE for static initializer IR generation (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] a500a43 - [CodeGen][AMDGPU] Fix ICE for static initializer IR generation

2020-12-12 Thread Alexey Bader via cfe-commits
Author: Alexey Bader Date: 2020-12-12T23:26:54+03:00 New Revision: a500a4358789d1794bc672421c55900ea2bbc938 URL: https://github.com/llvm/llvm-project/commit/a500a4358789d1794bc672421c55900ea2bbc938 DIFF: https://github.com/llvm/llvm-project/commit/a500a4358789d1794bc672421c55900ea2bbc938.diff

[clang] 956034c - [mac/arm] XFAIL two more tests on arm64-apple

2020-12-12 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-12T15:20:50-05:00 New Revision: 956034c6c894d1291306baed2e59e51c16e5df70 URL: https://github.com/llvm/llvm-project/commit/956034c6c894d1291306baed2e59e51c16e5df70 DIFF: https://github.com/llvm/llvm-project/commit/956034c6c894d1291306baed2e59e51c16e5df70.diff LO

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

2020-12-12 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D92155#2419549 , @sammccall wrote: > In D92155#2419346 , @psionic12 wrote: > >> Or, could you help to point out what's the difference between passing a >> plugin path through *clangd* sta

[clang] a5c65de - mac/arm: XFAIL the last 3 failing tests

2020-12-12 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-12-12T15:09:17-05:00 New Revision: a5c65de2953e755532da2e171e452d11e80d4714 URL: https://github.com/llvm/llvm-project/commit/a5c65de2953e755532da2e171e452d11e80d4714 DIFF: https://github.com/llvm/llvm-project/commit/a5c65de2953e755532da2e171e452d11e80d4714.diff LO

[PATCH] D93018: [AMDGPU] Add missing targets to target-invalid-cpu-note.c

2020-12-12 Thread Tony Tye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7beee561e23d: [AMDGPU] Add missing targets to target-invalid-cpu-note.c (authored by t-tye). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D93017: [AMDGPU] Add missing targets to amdgpu-features.cl

2020-12-12 Thread Tony Tye via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92ab6ed6672b: [AMDGPU] Add missing targets to amdgpu-features.cl (authored by t-tye). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 7beee56 - [AMDGPU] Add missing targets to target-invalid-cpu-note.c

2020-12-12 Thread via cfe-commits
Author: Tony Date: 2020-12-12T18:19:03Z New Revision: 7beee561e23db56c7e24462a9870a3ba58a9b2b3 URL: https://github.com/llvm/llvm-project/commit/7beee561e23db56c7e24462a9870a3ba58a9b2b3 DIFF: https://github.com/llvm/llvm-project/commit/7beee561e23db56c7e24462a9870a3ba58a9b2b3.diff LOG: [AMDGPU]

[clang] 92ab6ed - [AMDGPU] Add missing targets to amdgpu-features.cl

2020-12-12 Thread via cfe-commits
Author: Tony Date: 2020-12-12T18:19:02Z New Revision: 92ab6ed6672b99549f8fd63e3a442db47b1982fe URL: https://github.com/llvm/llvm-project/commit/92ab6ed6672b99549f8fd63e3a442db47b1982fe DIFF: https://github.com/llvm/llvm-project/commit/92ab6ed6672b99549f8fd63e3a442db47b1982fe.diff LOG: [AMDGPU]

[PATCH] D93164: [AST] Add generator for source location introspection

2020-12-12 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 311398. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93164/new/ https://reviews.llvm.org/D93164 Files: clang/lib/Tooling/CMakeLists.txt clang/lib/Tooling/DumpTool/APIData

[PATCH] D93164: [AST] Add generator for source location introspection

2020-12-12 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: aaron.ballman, njames93. Herald added a subscriber: mgorny. steveire requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Generate a json file

[PATCH] D93017: [AMDGPU] Add missing targets to amdgpu-features.cl

2020-12-12 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93017/new/ https://reviews.llvm.org/D93017 _

[PATCH] D93018: [AMDGPU] Add missing targets to target-invalid-cpu-note.c

2020-12-12 Thread Konstantin Zhuravlyov via Phabricator via cfe-commits
kzhuravl accepted this revision. kzhuravl added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93018/new/ https://reviews.llvm.org/D93018 _

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

2020-12-12 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.org/D92721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D93163: [clang-format] Fix handling of ## comments in TextProto

2020-12-12 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, krasimir. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As @krasimir said i

[PATCH] D92920: [clang-tidy] Add a diagnostic callback to parseConfiguration

2020-12-12 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 311391. njames93 added a comment. Fix up test case now bug in yaml error locations has been fixed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92920/new/ https://reviews.llvm.org/D92920 Files: clang-tools-

[PATCH] D92756: [clang-tidy] Support all YAML supported spellings for bools in CheckOptions.

2020-12-12 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 311388. njames93 added a comment. Fix test failures and added some to demonstrate this behaviour. Haven't added exhaustive cases as they are present in the YAML parser tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

2020-12-12 Thread Melanie Blower via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG320af6b13839: Create SPIRABIInfo to enable SPIR_FUNC calling convention. (authored by mibintc). Changed prior to commit: https://reviews.llvm.org/

[clang] 320af6b - Create SPIRABIInfo to enable SPIR_FUNC calling convention.

2020-12-12 Thread Melanie Blower via cfe-commits
Author: Melanie Blower Date: 2020-12-12T05:48:20-08:00 New Revision: 320af6b138391d289fe70db39c51da92e8d3d9df URL: https://github.com/llvm/llvm-project/commit/320af6b138391d289fe70db39c51da92e8d3d9df DIFF: https://github.com/llvm/llvm-project/commit/320af6b138391d289fe70db39c51da92e8d3d9df.diff

[PATCH] D92837: [X86] Support tilezero intrinsic and c interface for AMX.

2020-12-12 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke updated this revision to Diff 311375. LuoYuanke added a comment. a. Change tilezero back to be chained. 1. It avoid copy if several tilezero are same. Copy is expensive in AMX. 2. To keep the original order of amx intrinsics. b. Refactor __tilezero interface. Repository: rG LLVM Gi

[clang] adf3c27 - [clang][cli] Revert accidental access-control flag rename

2020-12-12 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2020-12-12T11:26:53+01:00 New Revision: adf3c27742ed272e0785a305995a70078eda6fe3 URL: https://github.com/llvm/llvm-project/commit/adf3c27742ed272e0785a305995a70078eda6fe3 DIFF: https://github.com/llvm/llvm-project/commit/adf3c27742ed272e0785a305995a70078eda6fe3.diff L

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

2020-12-12 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGadf3c27742ed: [clang][cli] Revert accidental access-control flag rename (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D93104: [clang][cli] Revert accidental access-control flag rename

2020-12-12 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. > (Or maybe OptOutFFLag could reject an option beginning with `"no-"`?) I think this is reasonable. I'll reach out to the mailing list to see if there's a way to add assertions to TableGen that would catch this. > Thanks! Sorry for the breakage. No problem. Repo

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

2020-12-12 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6baa9769ed57: [clang][cli] Add flexible TableGen multiclass for boolean options (authored by jansvoboda11). Repository: rG LLVM Github Monorepo C

[clang] 6baa976 - [clang][cli] Add flexible TableGen multiclass for boolean options

2020-12-12 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2020-12-12T10:53:28+01:00 New Revision: 6baa9769ed573741290fb186d02df7cf676fc8de URL: https://github.com/llvm/llvm-project/commit/6baa9769ed573741290fb186d02df7cf676fc8de DIFF: https://github.com/llvm/llvm-project/commit/6baa9769ed573741290fb186d02df7cf676fc8de.diff L

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

2020-12-12 Thread Jan Svoboda via Phabricator via cfe-commits
jansvoboda11 added a comment. I was, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92775/new/ https://reviews.llvm.org/D92775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] 10f4057 - [clang][cli] Don't always emit -f[no-]legacy-pass-manager

2020-12-12 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2020-12-12T10:11:23+01:00 New Revision: 10f40576f7b482dc55b9a0ba780c294c4e45817c URL: https://github.com/llvm/llvm-project/commit/10f40576f7b482dc55b9a0ba780c294c4e45817c DIFF: https://github.com/llvm/llvm-project/commit/10f40576f7b482dc55b9a0ba780c294c4e45817c.diff L

[PATCH] D92857: [clang][cli] Don't always emit -f[no-]legacy-pass-manager

2020-12-12 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG10f40576f7b4: [clang][cli] Don't always emit -f[no-]legacy-pass-manager (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D92774: [clang][cli] CompilerInvocationTest: add tests for boolean options

2020-12-12 Thread Jan Svoboda via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f26a6de489e: Reland "[clang][cli] CompilerInvocationTest: add tests for boolean options" (authored by jansvoboda11). Repository: rG LLVM Github

[clang] 6f26a6d - Reland "[clang][cli] CompilerInvocationTest: add tests for boolean options"

2020-12-12 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2020-12-12T09:46:20+01:00 New Revision: 6f26a6de489e66830c3181b747f6b18e439f36be URL: https://github.com/llvm/llvm-project/commit/6f26a6de489e66830c3181b747f6b18e439f36be DIFF: https://github.com/llvm/llvm-project/commit/6f26a6de489e66830c3181b747f6b18e439f36be.diff L