[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Could we consider dropping the maximum? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.

[PATCH] D92661: [RFC] Fix TLS and Coroutine

hoy added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:1309 +// Intrinsic to obtain the address of a thread_local variable. +def int_threadlocal : Intrinsic<[llvm_ptr_ty], [llvm_ptr_ty]>; + lxfind wrote: > hoy wrote: > > lxfind wrote: > > > hoy

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

MyDeveloperDay added a comment. In D92257#2435906 , @lebedev.ri wrote: > In D92257#2435902 , @MyDeveloperDay > wrote: > >> In D92257#2435899 , >> @HazardyKnusperkeks wrote:

[PATCH] D92792: [clang] - Also look for devtoolset-10

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92792/new/ https://reviews.llvm.org/D92792 ___ c

[PATCH] D92465: [PowerPC] Implement intrinsic for DARN instruction

This revision was automatically updated to reflect the committed changes. Closed by commit rG5e85a2ba1645: [PowerPC] Implement intrinsic for DARN instruction (authored by qiucf). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm

[clang] 5e85a2b - [PowerPC] Implement intrinsic for DARN instruction

Author: Qiu Chaofan Date: 2020-12-08T14:08:52+08:00 New Revision: 5e85a2ba1645c3edbf26bba096631fbd318ada47 URL: https://github.com/llvm/llvm-project/commit/5e85a2ba1645c3edbf26bba096631fbd318ada47 DIFF: https://github.com/llvm/llvm-project/commit/5e85a2ba1645c3edbf26bba096631fbd318ada47.diff L

[PATCH] D92078: [asan] Default to -asan-use-private-alias=1

vitalybuka added a subscriber: kcc. vitalybuka added a comment. I've chatted about that with @kcc and @eugenis . It seems the problem the patch is trying to solve is less important than regressions. Even with the current state when rare false ODR reports are possible it still useful. It would be

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

kito-cheng added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_INT(

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper added a subscriber: bkramer. craig.topper added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:548 break; - case CK_ZNVER3: -defineCPUMacros(Builder, "znver3"); Why is this being deleted? Comment at: clang/l

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

craig.topper added a comment. Please upload the patch with full context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

GGanesh created this revision. GGanesh added reviewers: RKSimon, craig.topper, lebedev.ri, courbet. GGanesh added projects: LLVM, clang. Herald added subscribers: mstojanovic, pengfei, jfb, gbedwell, hiraditya. Herald added a reviewer: andreadb. GGanesh requested review of this revision. Herald add

[PATCH] D92810: [clang-tidy] Recognize single character needles for absl::StrContains.

ckennelly created this revision. ckennelly added reviewers: EricWF, ymandel, hokein. Herald added a subscriber: xazax.hun. ckennelly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit fbdff6f3ae0b in the Abseil tree adds an overload for

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

aeubanks added inline comments. Comment at: llvm/lib/IR/PassTimingInfo.cpp:47 +cl::desc("Time each pass run, printing elapsed time for each run on exit"), +cl::callback([](const bool &) { TimePassesIsEnabled = true; })); + ychen wrote: > aeubanks wrote: >

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e614b0c7ed3: [NFC][MSan] Round up OffsetPtr in PoisonMembers (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 6e614b0 - [NFC][MSan] Round up OffsetPtr in PoisonMembers

Author: Vitaly Buka Date: 2020-12-07T19:57:49-08:00 New Revision: 6e614b0c7ed3a9a66428f342bf2a4b3700525395 URL: https://github.com/llvm/llvm-project/commit/6e614b0c7ed3a9a66428f342bf2a4b3700525395 DIFF: https://github.com/llvm/llvm-project/commit/6e614b0c7ed3a9a66428f342bf2a4b3700525395.diff L

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen added inline comments. Comment at: llvm/lib/IR/PassTimingInfo.cpp:47 +cl::desc("Time each pass run, printing elapsed time for each run on exit"), +cl::callback([](const bool &) { TimePassesIsEnabled = true; })); + aeubanks wrote: > is this necessary

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

ychen updated this revision to Diff 310079. ychen marked an inline comment as done. ychen added a comment. - `clang/test/Misc/time-passes.c`: add -fno-experimental-new-pass-manager - `llvm/test/Other/time-passes.ll`: makes sure each pass has one entry. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added a comment. > If the implementation-specific builtins don't match on these, then maybe they > should have different names, is his argument I think. That's a fair point. And I agree, if they don't match, maybe it would be best to have different names. I'm hoping that we can all ag

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

__simt__ added a comment. I think Jonathan is asking whether there is a match in the gray areas. The two cases people bring up most: 1. Unions, where the padding overlaps for all the possible active members. 2. Tail padding, up to the allocator granularity / alignment size. If the implementatio

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

khchen added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:67 +RVV_VECTOR_TYPE_INT("__rvv_int8m2_t", RvvInt8m2, RvvInt8m2Ty, 16, 8, 1, true) +RVV_VECTOR_TYPE_INT("__rvv_int8m4_t", RvvInt8m4, RvvInt8m4Ty, 32, 8, 1, true) +RVV_VECTOR_TYPE_INT("__r

[PATCH] D92809: [Driver] Add -gno-split-dwarf which can disable debug fission

MaskRay created this revision. MaskRay added reviewers: debug-info, dblaikie. Herald added a subscriber: dang. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently when -gsplit-dwarf is specified (could be buried in a build sys

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

zoecarver added a comment. In D87974#2438682 , @BillyONeal wrote: >> Are they actually the same, with the same handling of corner cases like >> unions and tail padding? >> There's more to this than just the name, and if they aren't the same, it >> seems

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

smeenai added a reviewer: compnerd. smeenai resigned from this revision. smeenai added a subscriber: compnerd. smeenai added a comment. I'm super excited to see this happen, but it's also well out of my review comfort zone, unfortunately. Adding @compnerd to take a look. Repository: rG LLVM G

[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

ahatanak created this revision. ahatanak added reviewers: rjmccall, smeenai, dexonsmith, pete, fhahn. ahatanak added projects: clang, LLVM. Herald added subscribers: ributzka, pengfei, jkorous, hiraditya, kristof.beyls. ahatanak requested review of this revision. Background: === This fixe

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay updated this revision to Diff 310073. MaskRay edited the summary of this revision. MaskRay added a comment. Comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391 Files: clang/docs/ReleaseNotes.r

[PATCH] D87974: [Builtin] Add __builtin_zero_non_value_bits.

BillyONeal added a comment. > Are they actually the same, with the same handling of corner cases like > unions and tail padding? > There's more to this than just the name, and if they aren't the same, it > seems better to have two names. They are both implementing the same C++ feature, with the

[clang] 590e146 - Fix assertion failure due to incorrect dependence bits on a DeclRefExpr

Author: Richard Smith Date: 2020-12-07T18:48:38-08:00 New Revision: 590e14653252faa97c2a32ba38aeef05ec681f9b URL: https://github.com/llvm/llvm-project/commit/590e14653252faa97c2a32ba38aeef05ec681f9b DIFF: https://github.com/llvm/llvm-project/commit/590e14653252faa97c2a32ba38aeef05ec681f9b.diff

[clang] 29295e2 - [test] Rewrite split-debug.c

Author: Fangrui Song Date: 2020-12-07T18:40:31-08:00 New Revision: 29295e21651f7071f1961a126d1c25a5526cec5a URL: https://github.com/llvm/llvm-project/commit/29295e21651f7071f1961a126d1c25a5526cec5a DIFF: https://github.com/llvm/llvm-project/commit/29295e21651f7071f1961a126d1c25a5526cec5a.diff

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote: > gulfem wrote: > > aaron.ballman wrote: > >

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added inline comments. Comment at: clang/test/Driver/cuda-unsupported-debug-options.cu:18 +// RUN: %clang -### -target x86_64-linux-gnu -c %s -gdwarf-5 -gembed-source 2>&1 | FileCheck %s --check-prefix=DWARF-CLAMP +// CHECK: debug information option '{{-gz|-fdebug-info

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3718 + } else +DwarfFission = DwarfFissionKind::None; MaskRay wrote: > dblaikie wrote: > > Rather than undoing the DwarfFission uinitialization, instead could the > > DwarfF

[PATCH] D92673: [ThinLTO] Remove unused symbol declarations when possible

tejohnson abandoned this revision. tejohnson added a comment. Subsumed by D92804 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92673/new/ https://reviews.llvm.org/D92673 ___

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3718 + } else +DwarfFission = DwarfFissionKind::None; dblaikie wrote: > Rather than undoing the DwarfFission uinitialization, instead could the > DwarfFission initialization

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra updated this revision to Diff 310062. tra marked an inline comment as done. tra added a comment. Adjusted openmp test for the changed -gembed-source warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92617/new/ https://reviews.llvm.org/D926

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra updated this revision to Diff 310061. tra added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92617/new/ https://reviews.llvm.org/D92617 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include

[PATCH] D92800: [Clang] Add disable-merge function attribute which generates nomerge function attribute in IR

zequanwu created this revision. zequanwu added reviewers: aaron.ballman, rnk. Herald added subscribers: dexonsmith, jdoerfert. zequanwu requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This adds `disable-merge` function att

[clang] efc063b - Fix lit test failure due to 0b81d9

Author: Yaxun (Sam) Liu Date: 2020-12-07T19:50:21-05:00 New Revision: efc063b621ea0c4d1e452bcade62f7fc7e1cc937 URL: https://github.com/llvm/llvm-project/commit/efc063b621ea0c4d1e452bcade62f7fc7e1cc937 DIFF: https://github.com/llvm/llvm-project/commit/efc063b621ea0c4d1e452bcade62f7fc7e1cc937.dif

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem updated this revision to Diff 310052. gulfem added a comment. Only support leaf attribute in functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90275/new/ https://reviews.llvm.org/D90275 Files: clang/include/clang/Basic/Attr.td cla

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310050. tmroeder added a comment. Fixed the clang-tidy warning as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatchersReferenc

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added a comment. In D80391#2438447 , @MaskRay wrote: > In D80391#2437926 , @dblaikie wrote: > >> Looks like GCC has changed the semantics here despite the backwards >> compatibility break - as much as I'd

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd added inline comments. Comment at: clang/lib/APINotes/APINotesWriter.cpp:35 + bool SwiftImportAsMember = false; +#endif + Please ignore this `#if`-defed portion, it is not intended for upstream, but I need to keep this working downstream. I will remov

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

compnerd created this revision. compnerd added reviewers: martong, gribozavr2, MForster. Herald added subscribers: mgrang, rnkovacs, mgorny. compnerd requested review of this revision. Herald added a project: clang. This adds the skeleton for serializing out the APINotes data from the APINotes. T

[PATCH] D92775: [clang][cli] Add flexible TableGen multiclass for boolean options

dexonsmith added a comment. > Not 100% sure the benefits are worth the added complexity. I think this is worth it. Names seem pretty clear to me. All around, this seems a lot more clear to me than the approach you had in the CodeGenOptions patch. Comment at: clang/unittests/F

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder updated this revision to Diff 310047. tmroeder added a comment. Added structural equivalence and a few tests for it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92600/new/ https://reviews.llvm.org/D92600 Files: clang/docs/LibASTMatche

[PATCH] D92774: [clang][cli] Add command line marshalling tests

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. I think the content here is mostly good, but there a number of things intermingled so it's hard see what's going on. I suggest splitting out one or more NFC commits to land a

[clang] a64c26a - Fix deserialization cycle in preferred_name attribute.

Author: Richard Smith Date: 2020-12-07T16:02:05-08:00 New Revision: a64c26a47a81b1b44e36d235ff3bc6a74a0bad9f URL: https://github.com/llvm/llvm-project/commit/a64c26a47a81b1b44e36d235ff3bc6a74a0bad9f DIFF: https://github.com/llvm/llvm-project/commit/a64c26a47a81b1b44e36d235ff3bc6a74a0bad9f.diff

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay added a comment. In D80391#2437926 , @dblaikie wrote: > Looks like GCC has changed the semantics here despite the backwards > compatibility break - as much as I'd rather not break backwards compatibility > it's probably best on balance to maintai

[PATCH] D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes.

tmroeder added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2366 +/// Matches C11 _Generic expression. +extern const internal::VariadicDynCastAllOfMatcher +genericSelectionExpr; aaron.ballman wrote: > Do we have a use case for ad

[PATCH] D92773: [clang][cli] Unify boolean marshalling

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM! This is a nice cleanup. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92773/new/ https://reviews.llvm.org/D92773

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro updated this revision to Diff 310044. evandro marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/AST/TypePr

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

evandro marked 7 inline comments as done. evandro added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:32 +// - ElBits is the size of one element in bits (SEW). +// +// - IsSigned is true for vectors of signed integer elements and HsiangKa

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:2385 + + def : Pat <(v2i64 (PPCxxsplti32dx v2i64:$XT, i32:$XI, i32:$IMM32)), + (v2i64 (XXSPLTI32DX v2i64:$XT, i32:$XI, i32:$IMM32))>; amyk wrote: > It would be good

[PATCH] D91310: [AMDGPU] Add -mcode-object-version=n

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b81d9a99257: [AMDGPU] add -mcode-object-version=n (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D91310?vs=304688&id=310037#toc Repository: rG

[clang] 0b81d9a - [AMDGPU] add -mcode-object-version=n

Author: Yaxun (Sam) Liu Date: 2020-12-07T18:08:37-05:00 New Revision: 0b81d9a992579ef55b0781c9bc678aa1f3133e9e URL: https://github.com/llvm/llvm-project/commit/0b81d9a992579ef55b0781c9bc678aa1f3133e9e DIFF: https://github.com/llvm/llvm-project/commit/0b81d9a992579ef55b0781c9bc678aa1f3133e9e.dif

[clang] 5cae708 - [clang][AMDGPU] remove mxnack and msramecc options

Author: Yaxun (Sam) Liu Date: 2020-12-07T18:08:37-05:00 New Revision: 5cae70800266119bbf319675a175cba9a7f315b1 URL: https://github.com/llvm/llvm-project/commit/5cae70800266119bbf319675a175cba9a7f315b1 DIFF: https://github.com/llvm/llvm-project/commit/5cae70800266119bbf319675a175cba9a7f315b1.dif

[clang] 4bed1d9 - [HIP] fix bundle entry ID for --

Author: Yaxun (Sam) Liu Date: 2020-12-07T18:08:37-05:00 New Revision: 4bed1d9b32b19f786aed17865e08c966962513cd URL: https://github.com/llvm/llvm-project/commit/4bed1d9b32b19f786aed17865e08c966962513cd DIFF: https://github.com/llvm/llvm-project/commit/4bed1d9b32b19f786aed17865e08c966962513cd.dif

[PATCH] D86217: rename sram-ecc as sramecc in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG40ad476a3244: [clang][AMDGPU] rename sram-ecc as sramecc (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D86217?vs=286562&id=310031#toc Repository

[clang] 40ad476 - [clang][AMDGPU] rename sram-ecc as sramecc

Author: Yaxun (Sam) Liu Date: 2020-12-07T18:05:47-05:00 New Revision: 40ad476a32445ec98666adcf24d2b33fd887ccc6 URL: https://github.com/llvm/llvm-project/commit/40ad476a32445ec98666adcf24d2b33fd887ccc6 DIFF: https://github.com/llvm/llvm-project/commit/40ad476a32445ec98666adcf24d2b33fd887ccc6.dif

[PATCH] D92792: [clang] - Also look for devtoolset-10

stephan.dollberg created this revision. stephan.dollberg added reviewers: phosek, chandlerc. stephan.dollberg requested review of this revision. Herald added a project: clang. devtoolset-10 has just been released so look for it as well. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGClass.cpp:1742 + Context.toCharUnitsFromBits(Layout.getFieldOffset(layoutStartOffset) + +

[PATCH] D92140: Fix noderef for array member of deref expr

thejh added a comment. Thanks! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92140/new/ https://reviews.llvm.org/D92140 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D92141: Fix noderef for AddrOf on MemberExpr

leonardchan closed this revision. leonardchan added a comment. Ok this time I remembered the email. Unsure why the bug isn't automatically closed though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92141/new/ https://reviews.llvm.org/D92141 ___

[clang] 6dad7ec - [clang] Fix noderef for AddrOf on MemberExpr

Author: Jann Horn Date: 2020-12-07T14:48:41-08:00 New Revision: 6dad7ec539cbcf6f59b63753a86b8015bd6ea66f URL: https://github.com/llvm/llvm-project/commit/6dad7ec539cbcf6f59b63753a86b8015bd6ea66f DIFF: https://github.com/llvm/llvm-project/commit/6dad7ec539cbcf6f59b63753a86b8015bd6ea66f.diff LOG

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

dblaikie added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:296 +def warn_drv_dwarf_version_limited_by_target : Warning< + "debug information option '%0' is not supported. It needs DWARF-%2 but target '%1' only provides DWARF-%3.">, + InGroup

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

aeubanks accepted this revision. aeubanks added a comment. lgtm with comments Comment at: clang/test/Misc/time-passes.c:2 +// Check that legacy pass manager could only use -ftime-report +// RUN: %clang_cc1 -emit-obj -O1 -ftime-report %s -o /dev/null 2>&1 | FileCheck %s --check

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

njames93 added a comment. Not sure I'm a huge fan of this, Some of these cases the size is specified because that's the upper limit we typically expect the SmallVector to use. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92788/new/ https://review

[PATCH] D92140: Fix noderef for array member of deref expr

leonardchan closed this revision. leonardchan added a comment. Committed in 155fca3cae275562e626d3e4fbfac70b4b75d2e7 . (Sorry, I forgot to change the author email in the commit) Repository: rG LLVM Github Monorepo CHANGES

[clang] 155fca3 - [clang] Fix noderef for array member of deref expr

Author: Leonard Chan Date: 2020-12-07T14:39:42-08:00 New Revision: 155fca3cae275562e626d3e4fbfac70b4b75d2e7 URL: https://github.com/llvm/llvm-project/commit/155fca3cae275562e626d3e4fbfac70b4b75d2e7 DIFF: https://github.com/llvm/llvm-project/commit/155fca3cae275562e626d3e4fbfac70b4b75d2e7.diff

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev added a comment. I've excluded the cases where the size does not seem arbitrary (e.g. `1`/ code relying on `sizeof(Something) == Value`, e.g. dex payloads and CodeCompletion bundles). The rest looks fairly innocent but I don't know all the code around changed lines. Repository: rG

[PATCH] D92742: [clang] Add support for attribute 'swift_async'

This revision was automatically updated to reflect the committed changes. erik.pilkington marked 2 inline comments as done. Closed by commit rG5a28e1d9e50e: [clang] Add support for attribute 'swift_async' (authored by erik.pilkington). Herald added a project: clang. Changed prior to commit: htt

[PATCH] D92495: [clang] Add a new nullability annotation for swift async: _Nullable_result

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cd2413f1ca7: [clang] Add a new nullability annotation for swift async: _Nullable_result (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 5a28e1d - [clang] Add support for attribute 'swift_async'

Author: Erik Pilkington Date: 2020-12-07T17:19:26-05:00 New Revision: 5a28e1d9e50eb0b866351b5ab3213678fd28374b URL: https://github.com/llvm/llvm-project/commit/5a28e1d9e50eb0b866351b5ab3213678fd28374b DIFF: https://github.com/llvm/llvm-project/commit/5a28e1d9e50eb0b866351b5ab3213678fd28374b.dif

[clang] 9cd2413 - [clang] Add a new nullability annotation for swift async: _Nullable_result

Author: Erik Pilkington Date: 2020-12-07T17:19:20-05:00 New Revision: 9cd2413f1ca7a7f40132ea3c44f251851aa325c2 URL: https://github.com/llvm/llvm-project/commit/9cd2413f1ca7a7f40132ea3c44f251851aa325c2 DIFF: https://github.com/llvm/llvm-project/commit/9cd2413f1ca7a7f40132ea3c44f251851aa325c2.dif

[PATCH] D92788: [clangd] NFC: Use SmallVector where possible

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. kbobyrev requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. SmallVector with def

[PATCH] D92140: Fix noderef for array member of deref expr

leonardchan added a comment. Sorry. I accidentally missed this in my emails. Will commit these. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92140/new/ https://reviews.llvm.org/D92140 ___ cfe-commits ma

[PATCH] D92617: [DWARF] Allow toolchain to adjust specified DWARF version.

tra updated this revision to Diff 310019. tra added a comment. Updated to address the comments. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92617/new/ https://reviews.llvm.org/D92617 Files: clang/include/clang/Basic/DiagnosticDriverKinds

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

fhahn added a comment. I think this also fixes https://bugs.llvm.org/show_bug.cgi?id=47397 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436 ___ cfe-commits mailing

[PATCH] D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation

asbirlea accepted this revision. asbirlea added a comment. This revision is now accepted and ready to land. lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92436/new/ https://reviews.llvm.org/D92436

[PATCH] D92728: [NFC][MSan] Round up OffsetPtr in PoisonMembers

vitalybuka added a comment. In D92728#2437506 , @eugenis wrote: > Don't you want to similarly align down PoisonEnd? > > But if this is something that should never happen, as your comment rightly > suggests, wouldn't it be better to add an assert()? > The

[PATCH] D91270: [Clang][CodeGen][RISCV] Fix hard float ABI test cases with empty struct

lenary accepted this revision. lenary added a comment. LGTM! Please land these tonight so we can have them backported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91270/new/ https://reviews.llvm.org/D91270 ___

[PATCH] D91278: [Clang][CodeGen][RISCV] Fix hard float ABI for struct with empty struct and complex

lenary accepted this revision. lenary added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91278/new/ https://reviews.llvm.org/D91278 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e1cb0db8a79: [CodeGen][MSan] Don't use offsets of zero-sized fields (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3e1cb0d - [CodeGen][MSan] Don't use offsets of zero-sized fields

Author: Vitaly Buka Date: 2020-12-07T13:37:40-08:00 New Revision: 3e1cb0db8a79b19996fcea210b639fe513a5eaf3 URL: https://github.com/llvm/llvm-project/commit/3e1cb0db8a79b19996fcea210b639fe513a5eaf3 DIFF: https://github.com/llvm/llvm-project/commit/3e1cb0db8a79b19996fcea210b639fe513a5eaf3.diff L

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet added a comment. Thanks @aaron.ballman for the comments! I fixed all your comments in the new patch. I will upload a new one with the Sema tests! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89490/new/ https://reviews.llvm.org/D89490 __

[PATCH] D89490: Introduce __attribute__((darwin_abi))

aguinet updated this revision to Diff 310006. aguinet marked 3 inline comments as done. aguinet added a comment. Multiple things: - remove clang-format tags - remove const usage - enhanced attribute documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader updated this revision to Diff 310003. bader added a comment. Move CodeGen crash fix to a separate review request: https://reviews.llvm.org/D92782 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89909/new/ https://reviews.llvm.org/D89909 Files

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4029 + D.Diag(diag::err_drv_argument_only_allowed_with) + << A->getAsString(Args) << "elf output format"; +else "elf output format" -> "ELF platforms" ELF is usual

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:62-72 +static AMDGPUSubtarget::Generation initializeGen(const Triple &TT, + StringRef GPU) { + if (GPU.contains("generic")) { +return TT.get

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay added inline comments. Comment at: clang/test/Driver/debug-options.c:390 +// GDWARF64_OFF: error: invalid argument '-gdwarf64' only allowed with 'DWARFv3 or greater' +// GDWARF64_32ARCH: error: invalid argument '-gdwarf64' only allowed with '64 bit architecture' --

[PATCH] D86119: [OPENMP50]Allow overlapping mapping in target constrcuts.

cchen added a comment. Below test asserts inside `generateInfoForComponentList`: Assertion failed: (!IsPointer && "Unexpected base element with the pointer type."), function generateInfoForComponentList, file /Users/cchen/workspace/llvm-project/clang/lib/CodeGen/CGOpenMPRuntime.cpp, line 775

[PATCH] D91311: Add new 'preferred_name' attribute.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG98f76adf4e94: Add new 'preferred_name' attribute. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D91311?vs=307496&id=3099

[clang] 98f76ad - Add new 'preferred_name' attribute.

Author: Richard Smith Date: 2020-12-07T12:53:07-08:00 New Revision: 98f76adf4e941738c0b9fe3b9965fa63603e9c89 URL: https://github.com/llvm/llvm-project/commit/98f76adf4e941738c0b9fe3b9965fa63603e9c89 DIFF: https://github.com/llvm/llvm-project/commit/98f76adf4e941738c0b9fe3b9965fa63603e9c89.diff

[PATCH] D90275: [clang][IR] Add support for leaf attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; gulfem wrote: > aaron.ballman wrote: > > gulfem wrote: > >

[PATCH] D90275: [clang][IR] Add support for leaf attribute

gulfem marked an inline comment as not done. gulfem added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1435 + let Spellings = [GCC<"leaf">]; + let Subjects = SubjectList<[Function]>; + let Documentation = [Undocumented]; aaron.ballman wrote:

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

mibintc added a comment. There are many RuntimeCalls that are created in Clang, including _read_pipe, all the OpenMP runtime calls, etc. Shall they all have their calling conventions set from the ABIInfo? Currently those calls are being set to 0. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

lebedev.ri added a comment. In D92257#2437918 , @HazardyKnusperkeks wrote: > In D92257#2435906 , @lebedev.ri > wrote: > >> In D92257#2435902 , @MyDeveloperDay >> wrote: >>

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4031 +else + CmdArgs.push_back("-gdwarf64"); + } Use `render` (see other `render` in the file) Comment at: clang/test/Driver/debug-options.c:379 +// +//

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

erichkeane added a comment. From my perspective I think this is right... I don't feel comfortable approving this however until someone from OpenCL/OpenMP takes a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92721/new/ https://reviews.llvm.o

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

bader added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4596 + IRFuncTy->getParamType(FirstIRArg)); +} + bader wrote: > bader wrote: > > rjmccall wrote: > > > This seems problematic; code like this

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks like GCC has changed the semantics here despite the backwards compatibility break - as much as I'd rather not break backwards compatibility it's probably best on balance to maintain

  1   2   3   >