[PATCH] D91927: [X86] Add x86_amx type for intel AMX.

2020-12-05 Thread LuoYuanke via Phabricator via cfe-commits
LuoYuanke updated this revision to Diff 309761. LuoYuanke added a comment. Avoid generatng constant for x86_amx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91927/new/ https://reviews.llvm.org/D91927 Files: clang/test/CodeGen/X86/amx_api.c l

[PATCH] D92727: [CodeGen][MSan] Don't use offsets of zero-sized fields

2020-12-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. vitalybuka added reviewers: eugenis, morehouse. vitalybuka requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Such fields will likely have offset zero making __sanitizer_dtor_callback poisoning wrong regions.

[clang] 1f21f6d - [NFC][CodeGen] Simplify SanitizeDtorMembers::Emit

2020-12-05 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-12-05T21:11:27-08:00 New Revision: 1f21f6d6a4cef3dd7cb169e1071ee372c2efe1a7 URL: https://github.com/llvm/llvm-project/commit/1f21f6d6a4cef3dd7cb169e1071ee372c2efe1a7 DIFF: https://github.com/llvm/llvm-project/commit/1f21f6d6a4cef3dd7cb169e1071ee372c2efe1a7.diff L

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

2020-12-05 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:32 +// - ElBits is the size of one element in bits (SEW). +// +// - IsSigned is true for vectors of signed integer elements and craig.topper wrote: > NF argument isn't document

[PATCH] D91157: [AArch64] Out-of-line atomics (-moutline-atomics) implementation.

2020-12-05 Thread Sebastian Pop via Phabricator via cfe-commits
sebpop added a comment. I tested this change on Graviton2 aarch64-linux by building https://github.com/xianyi/OpenBLAS with `clang -O3 -moutline-atomics` and `make test`: all tests pass with and without outline-atomics. Clang was configured to use libgcc. I also tested https://github.com/boosto

[clang] 452eddf - [NFC][CodeGen] Add sanitize-dtor-zero-size-field test

2020-12-05 Thread Vitaly Buka via cfe-commits
Author: Vitaly Buka Date: 2020-12-05T16:39:48-08:00 New Revision: 452eddf30bfcd0f8ade9796ef24b3e8773ef1618 URL: https://github.com/llvm/llvm-project/commit/452eddf30bfcd0f8ade9796ef24b3e8773ef1618 DIFF: https://github.com/llvm/llvm-project/commit/452eddf30bfcd0f8ade9796ef24b3e8773ef1618.diff L

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

2020-12-05 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/include/clang/Basic/RISCVVTypes.def:32 +// - ElBits is the size of one element in bits (SEW). +// +// - IsSigned is true for vectors of signed integer elements and NF argument isn't documented. And is always 1

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

2020-12-05 Thread Evandro Menezes via Phabricator via cfe-commits
evandro updated this revision to Diff 309750. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td clang/include/clang/Basic/RI

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

2020-12-05 Thread Evandro Menezes via Phabricator via cfe-commits
evandro updated this revision to Diff 309749. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Type.h clang/include/clang/AST/TypeProperties.td clang/include/clang/Basic/RI

[clang] 2a136a7 - [X86] Autodetect znver3

2020-12-05 Thread Benjamin Kramer via cfe-commits
Author: Benjamin Kramer Date: 2020-12-05T19:08:20+01:00 New Revision: 2a136a7a9c68e4818b28bea6051b78a8181ba78e URL: https://github.com/llvm/llvm-project/commit/2a136a7a9c68e4818b28bea6051b78a8181ba78e DIFF: https://github.com/llvm/llvm-project/commit/2a136a7a9c68e4818b28bea6051b78a8181ba78e.dif

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

2020-12-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/ASTMatchers/ASTMatchersInternal.cpp:155 public: - TrueMatcherImpl() { -Retain(); // Reference count will never become zero. - } + TrueMa

[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

2020-12-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Can I assume you need someone to land this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92257/new/ https://reviews.llvm.org/D92257 ___ cfe-commits mailing list c

[PATCH] D27377: clang-format: Support the Java 8 'default' method modifier

2020-12-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay commandeered this revision. MyDeveloperDay edited reviewers, added: lhchavez; removed: MyDeveloperDay. MyDeveloperDay added a comment. This revision is no needed, the test will pass without any additional code changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27377/ne

[PATCH] D91507: [clang-format] Add option for case sensitive regexes for sorted includes

2020-12-05 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8668eae2adf2: [clang-format] Add option for case sensitive regexes for sorted includes (authored by MyDeveloperDay). Changed prior to commit: http

[clang] 8668eae - [clang-format] Add option for case sensitive regexes for sorted includes

2020-12-05 Thread via cfe-commits
Author: mydeveloperday Date: 2020-12-05T16:33:21Z New Revision: 8668eae2adf23209e3f8d19477725eb7e73ba93c URL: https://github.com/llvm/llvm-project/commit/8668eae2adf23209e3f8d19477725eb7e73ba93c DIFF: https://github.com/llvm/llvm-project/commit/8668eae2adf23209e3f8d19477725eb7e73ba93c.diff LOG

[clang-tools-extra] f687b4a - [NFC][clang-tidy] Fixes comment typos.

2020-12-05 Thread Mark de Wever via cfe-commits
Author: Mark de Wever Date: 2020-12-05T16:31:16+01:00 New Revision: f687b4ac84a3f76ec850dccb675ac2b5c00f8661 URL: https://github.com/llvm/llvm-project/commit/f687b4ac84a3f76ec850dccb675ac2b5c00f8661 DIFF: https://github.com/llvm/llvm-project/commit/f687b4ac84a3f76ec850dccb675ac2b5c00f8661.diff

[PATCH] D92721: [PATCH] [clang] Create SPIRABIInfo to enable SPIR_FUNC calling convention

2020-12-05 Thread Melanie Blower via Phabricator via cfe-commits
mibintc created this revision. mibintc added reviewers: v_klochkov, Anastasia, yaxunl. mibintc requested review of this revision. Herald added a project: clang. Background: Call to library arithmetic functions for div is emitted by the compiler and it set wrong ā€œCā€ calling convention for calls to

[PATCH] D92720: [HIP] unbundle bundled preprocessor output

2020-12-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. There is a use case that users want to emit preprocessor output as file and compile the preprocessor output later with `-x hip-cpp-output`. Clang emits bundled preprocessor output when users comp

[PATCH] D92408: [clangd] ExtractFunction: disable on regions that sometimes, but not always return.

2020-12-05 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 accepted this revision. usaxena95 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:711 +// Returns true if ExtZone contains any ReturnStms. +bool hasReturnStmt(const Extrac

[PATCH] D91495: [clang-tidy] false-positive for bugprone-redundant-branch-condition in case of passed-by-ref params

2020-12-05 Thread Zinovy Nis via Phabricator via cfe-commits
zinovy.nis updated this revision to Diff 309732. zinovy.nis added a comment. Fixed remarks from Aaron. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91495/new/ https://reviews.llvm.org/D91495 Files: clang-tools-extra/clang-tidy/bugprone/RedundantBranchConditionCheck.cpp clang-tool

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

2020-12-05 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 309730. njames93 added a comment. Refactored the ManagedStatic instance into a function static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92480/new/ https://reviews.llvm.org/D92480 Files: clang/lib/ASTM

[PATCH] D92480: [llvm] Add asserts in (ThreadSafe)?RefCountedBase destructors

2020-12-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added inline comments. Comment at: llvm/include/llvm/Support/ManagedStatic.h:25 +// that are const with no params. +template struct HasRetainRelease { +private: dblaikie wrote: > njames93 wrote: > > dblaikie wrote: > > > Are there many uses that rely on

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

2020-12-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. Maybe I'm confused if you the setting is to break before ASM Colon then I expect it to always break, is that not what is required? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 _

[PATCH] D92666: [clang-format] [NFC] keep clang-format tests clang-format clean

2020-12-05 Thread MyDeveloperDay via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0e226d00d21c: [clang-format] [NFC] keep clang-format tests clang-format clean (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D926

[clang] 0e226d0 - [clang-format] [NFC] keep clang-format tests clang-format clean

2020-12-05 Thread via cfe-commits
Author: mydeveloperday Date: 2020-12-05T10:15:52Z New Revision: 0e226d00d21cdefe82ef4d6531e4e73d3b5c0494 URL: https://github.com/llvm/llvm-project/commit/0e226d00d21cdefe82ef4d6531e4e73d3b5c0494 DIFF: https://github.com/llvm/llvm-project/commit/0e226d00d21cdefe82ef4d6531e4e73d3b5c0494.diff LOG

[PATCH] D92715: [Clang][RISCV] Define RISC-V V builtin types

2020-12-05 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. Can you re-upload the patch with full context? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92715/new/ https://reviews.llvm.org/D92715 ___ cfe-commits mailing list cfe-comm

[PATCH] D92640: Add ability to load a FixedCompilationDatabase from a buffer.

2020-12-05 Thread Utkarsh Saxena via Phabricator via cfe-commits
usaxena95 accepted this revision. usaxena95 added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92640/new/ https://reviews.llvm.org/D92640

[clang] 1ab9327 - [TargetMachine][CodeGenModule] Delete unneeded ppc32 special case from shouldAssumeDSOLocal

2020-12-05 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-12-05T00:42:07-08:00 New Revision: 1ab9327d1c01645806394faa648f65e947b65177 URL: https://github.com/llvm/llvm-project/commit/1ab9327d1c01645806394faa648f65e947b65177 DIFF: https://github.com/llvm/llvm-project/commit/1ab9327d1c01645806394faa648f65e947b65177.diff