[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/DumpASTTests.cpp:12 +#include "TestTU.h" +#include "llvm/Support/ScopedPrinter.h" +#include "gmock/gmock.h" sammccall wrote: > adamcz wrote: > > include order lint warning here > Not s

[PATCH] D91844: [llvm][clang] Add checks for the smart pointers with the possibility to be null

OikawaKirie created this revision. OikawaKirie added reviewers: aaron.ballman, avl, mehdi_amini, ilya-biryukov, tejohnson, jansvoboda11. OikawaKirie added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. OikawaKirie requested review of

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban updated this revision to Diff 306604. yrouban marked 4 inline comments as done. yrouban edited the summary of this revision. yrouban added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://reviews.llvm.org/D91327 Files: clang/lib/

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added a comment. In D80344#2407309 , @belliash wrote: > Does it really work for x86_64 architecture only? I have tried using this > with x86 build and produced binaries looks like this should work on this > platform as well, but I have not tried

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

belliash added a comment. Does it really work for x86_64 architecture only? I have tried using this with x86 build and produced binaries looks like this should work on this platform as well, but I have not tried running produced executables to see the results yet tbh. Repository: rG LLVM Gi

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen marked 2 inline comments as done. tentzen added a comment. In D80344#2407250 , @pengfei wrote: > Do we need to consider FP exceptions in _try block? Yes, FP exception is handled as long as FP exceptions are not disabled (Ex via _controlfp() runti

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 306598. yonghong-song added a comment. add some comments in test w.r.t. __sync_lock_test_and_set() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72184/new/ https://reviews.llvm.org/D72184 Files: clang/

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added a comment. okay, my fault. I must have uploaded an old version of the patch so comment is not in the test. will upload the new version tonight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72184/new/ https://reviews.llvm.org/D

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added a comment. In D72184#2407264 , @ast wrote: > Looks like the test didn't change. Only commit log... that's fine. I think > the diff is ready to land, but let's wait for the kernel patches to be ready > as well. I added some comments i

[PATCH] D72184: [BPF] support atomic instructions

ast added a comment. Looks like the test didn't change. Only commit log... that's fine. I think the diff is ready to land, but let's wait for the kernel patches to be ready as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72184/new/ https:/

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

rnk added inline comments. Comment at: clang/include/clang/Frontend/FrontendOptions.h:307 + /// Wheather using -mthread-model single. + unsigned IsSingleThreadModel : 1; + This doesn't seem to fit with the other frontend options. This seems more like a languag

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

pengfei added a comment. Do we need to consider FP exceptions in _try block? Comment at: clang/include/clang/Driver/Options.td:886 HelpText<"Enable C++ exceptions">, Flags<[CC1Option]>; +def feh_asynch: Flag<["-"], "feh-asynch">, Group, + HelpText<"Enable EH Asynchronous ex

[PATCH] D91567: [llvm][inliner] Reuse the inliner pass to implement 'always inliner'

mtrofin updated this revision to Diff 306593. mtrofin added a comment. Herald added subscribers: wenlei, steven_wu. patched up tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91567/new/ https://reviews.llvm.org/D91567 Files: clang/test/CodeG

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 306592. yonghong-song edited the summary of this revision. yonghong-song added a comment. add proper comment in test and clarify in commit message for __sync_lock_test_and_set which actually means an atomic exchange operation. Repository: rG LLVM Gi

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init.cpp:65 +void fview() { + std::string_view a = ""; aaron.ballman wrote: > Can you also add tests for `wstring_view`? > > Also, perhaps on

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly updated this revision to Diff 306591. ckennelly marked 3 inline comments as done. ckennelly added a comment. Applied review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91009/new/ https://reviews.llvm.org/D91009 Files: clang-

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

smhc added a comment. Regexes may be a bit of a slippery slope as any identifier scheme could be represented as a regex (casing, prefix, suffix etc) but it's not practical to provide a fix or suggestion with a regex. For example with a 'ShortThreshold' a fix could offer to change the casing/xff

[PATCH] D91840: OpaquePtr: Require byval on x86_intrcc parameter 0

arsenm created this revision. arsenm added reviewers: rnk, aaboud, craig.topper. Herald added subscribers: dexonsmith, pengfei, hiraditya. Herald added a project: LLVM. arsenm requested review of this revision. Herald added a subscriber: wdng. Currently the backend special cases x86_intrcc and tre

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme

[PATCH] D91297: Frontend: Take VFS and MainFileBuffer by reference in PrecompiledPreamble::CanReuse, NFC

dexonsmith added inline comments. Comment at: clang/include/clang/Frontend/PrecompiledPreamble.h:108 bool CanReuse(const CompilerInvocation &Invocation, -const llvm::MemoryBuffer *MainFileBuffer, PreambleBounds Bounds, -llvm::vfs::FileSystem *V

[PATCH] D91047: Add a call super attribute plugin example

psionic12 added a comment. @aaron.ballman That would be nice if your could help, and `Yafei Liu ` is okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91047/new/ https://reviews.llvm.org/D91047 ___ cf

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

Xiangling_L added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616 + if (Args.hasArg(options::OPT_maltivec) && + (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) { +for (const Arg *A : Args) { ZarkoCA wrote: > Xiangling_L wrote:

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

MaskRay added inline comments. Comment at: clang/tools/driver/CMakeLists.txt:123 + +check_linker_flag("-Wl,-z,relax=transtls" LINKER_SUPPORTS_Z_RELAX_TRANSTLS) ro wrote: > MaskRay wrote: > > GNU ld reports a warning instead of an error when an unknown `-z` is see

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM but you should probably also wait for @aaron.ballman or @rsmith to also chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D91605: [sanitizers] Implement GetTls on Solaris

vitalybuka added a comment. Other than file issue, compiler-rt part is LGTM leaving the rest to @MaskRay Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:455-520 +#if SANITIZER_SOLARIS +// dlpi_tls_modid is only available since Solaris 11.4 SRU 10. Use

[PATCH] D91747: [Clang] Add __STDCPP_THREADS__ to standard predefine macros

zequanwu updated this revision to Diff 306561. zequanwu added a comment. Add a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91747/new/ https://reviews.llvm.org/D91747 Files: clang/include/clang/Frontend/FrontendOptions.h clang/lib/

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7641 + /// (which accepts anything) and (later) extensions. + StringRef RawString; }; mikerice wrote: > This field doesn't seem to have serialization code. Is that expected or

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

mikerice added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:7641 + /// (which accepts anything) and (later) extensions. + StringRef RawString; }; This field doesn't seem to have serialization code. Is that expected or an oversight? R

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh updated this revision to Diff 306555. thejh added a comment. re-uploading to trigger a new build, since the build error looks unrelated. maybe current trunk is flaky? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91828/new/ https://reviews.ll

[PATCH] D49317: Move __construct_forward (etc.) out of std::allocator_traits.

Quuxplusone abandoned this revision. Quuxplusone added a comment. Abandoning, as this has been done in d9a4f936d05 . Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49317/new/ https://reviews.

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme

[clang-tools-extra] 8adc4d1 - [clangd] Add textDocument/ast extension method to dump the AST

Author: Sam McCall Date: 2020-11-20T01:13:28+01:00 New Revision: 8adc4d1ec76471bc283d888f3077f7d8f591d6ad URL: https://github.com/llvm/llvm-project/commit/8adc4d1ec76471bc283d888f3077f7d8f591d6ad DIFF: https://github.com/llvm/llvm-project/commit/8adc4d1ec76471bc283d888f3077f7d8f591d6ad.diff LO

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG8adc4d1ec764: [clangd] Add textDocument/ast extension method to dump the AST (authored by sammccall). Ch

[PATCH] D89571: [clangd] Add textDocument/ast extension method to dump the AST

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/DumpASTTests.cpp:12 +#include "TestTU.h" +#include "llvm/Support/ScopedPrinter.h" +#include "gmock/gmock.h" adamcz wrote: > include order l

[PATCH] D91029: [clangd] Implement clang-tidy options from config

sammccall added a comment. Thanks, this looks massively simpler. It seems clear that we get config by applying a sequence of strategies in order, and these strategies (e.g. .clang-tidy files, config, disabled checks) are mostly independent. So I have a suggestion for expressing this composition

[PATCH] D91828: [Sema/Attribute] Ignore noderef attribute in unevaluated context

thejh created this revision. thejh added reviewers: leonardchan, rsmith, aaron.ballman, mcgrathr. Herald added a project: clang. Herald added a subscriber: cfe-commits. thejh requested review of this revision. The noderef attribute is for catching code that accesses pointers in a different address

[PATCH] D87981: [X86] AMX programming model.

LuoYuanke added a comment. In D87981#2406777 , @craig.topper wrote: > Remind me what happened with the idea of using a dedicated type for tiles in > IR like mmx? Yes, that's good idea. Do you think we need a separate patch to support the new IR type fo

[PATCH] D90507: [Driver] Add DWARF64 flag: -gdwarf64

ayermolo added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme

[PATCH] D87981: [X86] AMX programming model.

craig.topper added a comment. Remind me what happened with the idea of using a dedicated type for tiles in IR like mmx? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87981/new/ https://reviews.llvm.org/D87981 _

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 306545. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Fixed failing test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Files: llvm/include/llvm/Target/TargetMachine.h llvm/l

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay added a comment. In D91760#2406747 , @joerg wrote: > The difference is whether we promise to be instruction precise or not. I'm > not sure we do or want to promise that as default. `gcc/common/config/{aarch64,rs6000}/*-common.c` enables -fasynch

[PATCH] D87981: [X86] AMX programming model.

LuoYuanke added a comment. In D87981#2406530 , @craig.topper wrote: > This triggers an assertion in X86LowerAMXType::visit() when compiled with > clang test.c -O3 > > typedef int vec1024 __attribute__((vector_size(1024))); > > vec1024 foo(vec1024

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

jfb added a comment. Most of the tests as written should be failing right now, at least on macOS and Linux, because they likely should be identified as POSIX, right? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

abelkocsis updated this revision to Diff 306543. abelkocsis added a comment. Fixes, `PPCallbacks` class add Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75229/new/ https://reviews.llvm.org/D75229 Files: clang-tools-extra/clang-tidy/bugprone/Bugp

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

joerg added a comment. The difference is whether we promise to be instruction precise or not. I'm not sure we do or want to promise that as default. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91760/new/ https://reviews.llvm.org/D91760

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 306538. MaskRay added a comment. Fix comments: 'future' -> 'none' Add a test for llc -binutils-version=none Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D85474 Files: cla

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

MaskRay added a comment. In D91760#2406650 , @joerg wrote: > I have no problem with the change, but please adjust the description to take > about -funwind-tables. I don't think we do async by default, at least not by > design. AFAICT we don't make disti

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

joerg added a comment. I have no problem with the change, but please adjust the description to take about -funwind-tables. I don't think we do async by default, at least not by design. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91760/new/ http

[PATCH] D91821: Fix PR42049 - Crash when parsing bad decltype use within template argument list after name assumed to be a function template

faisalv created this revision. faisalv added a reviewer: rsmith. faisalv added a project: clang. Herald added a subscriber: cfe-commits. faisalv requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=42049 Currently clang, in the following code, when tentatively parsing the tem

[PATCH] D91565: Guard init_priority attribute within libc++

zibi updated this revision to Diff 306524. zibi marked an inline comment as done. zibi added a comment. updated doc. and test as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91565/new/ https://reviews.llvm.org/D91565 Files: clang/incl

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

nickdesaulniers added a comment. Also, built and boot tested an aarch64 defconfig just to be safe. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91760/new/ https://reviews.llvm.org/D91760 ___ cfe-commits

[PATCH] D91565: Guard init_priority attribute within libc++

zibi marked an inline comment as done. zibi added inline comments. Comment at: clang/include/clang/Basic/Attr.td:384 +def ExcludeTarget : TargetSpec { + let CustomCode = [{ !Target.getTriple().isOSzOS() }]; aaron.ballman wrote: > This is not a very descriptive

[PATCH] D91760: [Driver] Default Generic_GCC aarch64 to use -fasynchronous-unwind-tables

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the heads up, I don't see this being a problem for us, especially since GCC already behaves this way; arch/arm64/Makefile: 55 # Avoid generating .eh_frame* sectio

[PATCH] D91819: [PowerPC] Enable paired vector type and intrinsics when MMA is disabled

bsaleil created this revision. bsaleil added reviewers: nemanjai, saghir, amyk, lei. bsaleil added projects: PowerPC, LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, shchenz, arphaman, martong, kbarton, hiraditya. Herald added a reviewer: shafik. bsaleil requested rev

[PATCH] D87981: [X86] AMX programming model.

craig.topper added a comment. This triggers an assertion in X86LowerAMXType::visit() when compiled with clang test.c -O3 typedef int vec1024 __attribute__((vector_size(1024))); vec1024 foo(vec1024 x, vec1024 y) { return x + y; } While deleting: <256 x i32> %x Use still stuck

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:35 CODEGENOPT(AsmVerbose, 1, 0) ///< -dA, -fverbose-asm. +CODEGENOPT(Dwarf64 , 1, 0) ///< -gdwarf64. CODEGENOPT(PreserveAsmComments, 1, 1) ///< -dA, -fno-preserve-as-comme

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA marked 6 inline comments as done. ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCRegisterInfo.cpp:235 +return TM.isPPC64() + ? (Subtarget.hasAltivec() ? CSR_64_AllRegs_Altivec_RegMask + : CSR

[PATCH] D88676: [PPC][AIX] Add vector callee saved registers for AIX extended vector ABI

ZarkoCA updated this revision to Diff 306515. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Rebase and remove regmask altivec change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88676/new/ https://reviews.llvm.org/D88676 Fil

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clangd/README.md:26 +- Create a build directory, for example at `$LLVM_ROOT/build`. +- Inside the build directory run: `cmake $LLV

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen updated this revision to Diff 306510. tentzen added a comment. Per Joseph's feedback, further clarify the semantic of llvm.seh.try.begin and llvm.seh.try.end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80344/new/ https://reviews.llvm.or

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA marked 10 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4616 + if (Args.hasArg(options::OPT_maltivec) && + (Triple.isOSAIX() || Triple.isOSBinFormatXCOFF())) { +for (const Arg *A : Args) { -

[PATCH] D90282: [clang-tidy] Add IgnoreShortNames config to identifier naming checks

njames93 added a comment. In D90282#2405615 , @aaron.ballman wrote: > I don't have a strong opinion on that approach. It would be a more flexible > approach and that's appealing, but it also means writing regular expressions > which is a bit unappealing

[PATCH] D91789: [clang-tidy] find/fix unneeded trailing semicolons in macros

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. The request in D90180 was to not add a check for each kind of problematic semicolon situation but to instead make a single check that

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

aaron.ballman added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:91-94 +This mode is hard to use correctly and +requires more development iteration because it means +that the user must write AST Matchers to explicitly traverse or ignore nodes +which are no

[PATCH] D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs.

ZarkoCA updated this revision to Diff 306509. ZarkoCA marked 3 inline comments as done. ZarkoCA added a comment. Addressed comments: Added and fixed test cases and changed option selection logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89684/

[PATCH] D90896: [Clang][Driver] default to nossp

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Prefer: https://reviews.llvm.org/D91816 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90896/new/ https://reviews.llvm.org/D90896

[PATCH] D90348: [Driver] specify -stack-protector 0 for -fno-stack-protector

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Prefer: https://reviews.llvm.org/D91816 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90348/new/ https://reviews.llvm.org/D90348

[PATCH] D90194: [Driver] split LangOptions::SSPOff into SSPOFF and SSPUnspecified

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Prefer: https://reviews.llvm.org/D91816 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90194/new/ https://reviews.llvm.org/D90194

[PATCH] D87956: [IR] add fn attr for no_stack_protector; prevent inlining on mismatch

nickdesaulniers added a comment. Simpler approach: https://reviews.llvm.org/D91816 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 ___ cfe-commits mailing list cf

[PATCH] D91531: [RFC][OpenCL] Provide mechanisms for defining extension macros

azabaznov added a comment. Yes, in general this approach looks good to me conceptually. I have two suggestions: 1. As we discussed, the term //core functionality// should be revisited here. There's no clear meaning about that in the spec and I think interpreting it as //supported by default//

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

tentzen added inline comments. Comment at: llvm/docs/LangRef.rst:11591 +and the EH cleanup is no longer required (e.g. because the destructor is being +called). + JosephTremoulet wrote: > Maybe add something here like > > > Any set of operations can then be conf

[PATCH] D91756: [CSSPGO] Pseudo probes for function calls.

hoy updated this revision to Diff 306497. hoy added a comment. Updating D91756 : [CSSPGO] Pseudo probes for function calls. Corresponding changes to support IR/MIR intrinsic attributes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/test/CodeGen/BPF/atomics_2.ll:14 +; int test_xchg_64(long *p, long v) { +; return __sync_lock_test_and_set(p, v); +; } yonghong-song wrote: > ast wrote: > > test_and_set is not the same as xchg. > > xchg doesn't

[PATCH] D91812: [ThinLTO/WPD] Enable -wholeprogramdevirt-skip in ThinLTO backends

tejohnson created this revision. tejohnson added reviewers: pcc, evgeny777. Herald added subscribers: cfe-commits, steven_wu, hiraditya, inglorion, Prazek. Herald added projects: clang, LLVM. tejohnson requested review of this revision. Previously this option could be used to skip devirtualization

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:303 + + Replacement of `begin()` with `cbegin()`: + aaron.ballman wrote: > Backticks won't help here -- should probably use tags. `pre` is equivalent to three backticks. I added

[PATCH] D88394: [Driver][M68k] (Patch 8/8) Add driver support for M68k

bruno added inline comments. Comment at: clang/include/clang/Driver/Options.td:3125 +foreach i = {0-4} in + def m680#i#0 : Flag<["-"], "m680"#i#"0">, Group; rengolin wrote: > Same question as @RKSimon had below: Shouldn't this cover all models the > back-end

[PATCH] D91639: Add documentation illustrating use of IgnoreUnlessSpelledInSource

steveire updated this revision to Diff 306494. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91639/new/ https://reviews.llvm.org/D91639 Files: clang/docs/LibASTMatchersReference.html Index: clang/docs/LibASTMatc

[PATCH] D88393: [cfe][M68k] (Patch 7/8) Basic Clang support

bruno added a comment. Looking forward to see m68k support (and hopefully sega genesis toolchain support someday)! Comment at: clang/lib/Basic/Targets/M68k.cpp:73 +void M68kTargetInfo::getTargetDefines(const LangOptions &Opts, +MacroBuil

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song added inline comments. Comment at: llvm/test/CodeGen/BPF/atomics_2.ll:14 +; int test_xchg_64(long *p, long v) { +; return __sync_lock_test_and_set(p, v); +; } ast wrote: > test_and_set is not the same as xchg. > xchg doesn't do comparison. I

[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

JosephTremoulet added inline comments. Comment at: llvm/docs/LangRef.rst:11587 +C++ object with a non-trivial destructor. ``llvm.seh.scope.begin`` is used to mark +the start of the region; it is aways called with ``invoke``, with the unwind block +being the desired unwind dest

[PATCH] D72184: [BPF] support atomic instructions

ast added inline comments. Comment at: llvm/test/CodeGen/BPF/atomics_2.ll:14 +; int test_xchg_64(long *p, long v) { +; return __sync_lock_test_and_set(p, v); +; } test_and_set is not the same as xchg. xchg doesn't do comparison. Repository: rG LLVM Gi

[PATCH] D91585: [NPM] Move more O0 pass building into PassBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG72badbcdccd1: [NPM] Move more O0 pass building into PassBuilder (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] 72badbc - [NPM] Move more O0 pass building into PassBuilder

Author: Arthur Eubanks Date: 2020-11-19T11:22:23-08:00 New Revision: 72badbcdccd11c12555147d48dee4a776f5da87d URL: https://github.com/llvm/llvm-project/commit/72badbcdccd11c12555147d48dee4a776f5da87d DIFF: https://github.com/llvm/llvm-project/commit/72badbcdccd11c12555147d48dee4a776f5da87d.diff

[PATCH] D86502: [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation.

hoy updated this revision to Diff 306488. hoy added a comment. Updating D86502 : [CSSPGO] A Clang switch -fpseudo-probe-for-profiling for pseudo-probe instrumentation. Changing test corresponding to intrinsic attributes. Repository: rG LLVM Github Monorepo C

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd added inline comments. Comment at: clang/include/clang/APINotes/Types.h:529 + /// Adds the return type info. + void addReturnTypeInfo(NullabilityKind kind) { addTypeInfo(0, kind); } + compnerd wrote: > martong wrote: > > Do we document somewhere that t

[PATCH] D72184: [BPF] support atomic instructions

yonghong-song updated this revision to Diff 306485. yonghong-song edited the summary of this revision. yonghong-song added a comment. - remove all char/short atomic operations - remove barrier instruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D91104: APINotes: add property models for YAML attributes

compnerd updated this revision to Diff 306487. compnerd marked 5 inline comments as done. compnerd added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91104/new/ https://reviews.llvm.org/D91104 Files: clang/inc

[clang-tools-extra] ad5a195 - [clangd] Express ASAN interactions of tests more clearly. NFC

Author: Sam McCall Date: 2020-11-19T20:14:51+01:00 New Revision: ad5a195ae510fbfaf7885549e4899c85f0593fa5 URL: https://github.com/llvm/llvm-project/commit/ad5a195ae510fbfaf7885549e4899c85f0593fa5 DIFF: https://github.com/llvm/llvm-project/commit/ad5a195ae510fbfaf7885549e4899c85f0593fa5.diff LO

[PATCH] D91299: [clangd] Also detect corrupt stri table size.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7747dacba8e: [clangd] Also detect corrupt stri table size. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D91299?vs=304641&id=306484#toc Repository: rG LLVM Github Monore

[clang-tools-extra] d7747da - [clangd] Also detect corrupt stri table size.

Author: Sam McCall Date: 2020-11-19T20:11:14+01:00 New Revision: d7747dacba8e4a7784ea8ef20abbff87d5681b81 URL: https://github.com/llvm/llvm-project/commit/d7747dacba8e4a7784ea8ef20abbff87d5681b81 DIFF: https://github.com/llvm/llvm-project/commit/d7747dacba8e4a7784ea8ef20abbff87d5681b81.diff LO

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 ___ c

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306482. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Driver/Options.td clang/lib/CodeGen

[PATCH] D85576: [clang][Fuchsia] Add relative-vtables multilib

leonardchan added a comment. *ping* any more comments on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85576/new/ https://reviews.llvm.org/D85576 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

dblaikie added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4023 + D.Diag(diag::err_drv_argument_only_allowed_with) + << A->getAsString(Args) << "DWARVv3 or greater"; +else if (!RawTriple.isArch64Bit())

[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

MaskRay updated this revision to Diff 306478. MaskRay edited the summary of this revision. MaskRay added a comment. Switch to -fbinutils-version=none from 'future' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85474/new/ https://reviews.llvm.org/D8

[PATCH] D86671: [clang-tidy] Add new case type to check variables with Hungarian notation

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:237 +std::string Val = HNOption.General.lookup(Opt.first); +if (Val.empty()) { + HNOption.General.insert({Opt.first, Opt.second.str()}); -

[PATCH] D90507: Adding DWARF64 clang flag: -gdwarf64

ayermolo updated this revision to Diff 306477. ayermolo marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90507/new/ https://reviews.llvm.org/D90507 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/

[PATCH] D90719: [DebugInfo] Modify ctor homing as workaround for unconstructed libcxx types

akhuang added a comment. Thanks, looks like I'll try to see if libcxx code can be changed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90719/new/ https://reviews.llvm.org/D90719 ___ cfe-commits ma

[PATCH] D83812: [clang][RelativeVTablesABI] Use dso_local_equivalent rather than emitting stubs

leonardchan updated this revision to Diff 306472. leonardchan added a comment. Rebased. @rjmccall This might've changed a bit since you last accepted the revision. Will wait a couple of days before submitting if you have any more comments on this. Repository: rG LLVM Github Monorepo CHANGE

  1   2   >